Friday, 2016-11-18

« Thursday, 2016-11-17 Index Saturday, 2016-11-19 »
*** limao has joined #openstack-kuryr00:39
*** tonanhngo has quit IRC00:39
*** tonanhngo has joined #openstack-kuryr00:54
*** tonanhngo_ has joined #openstack-kuryr00:56
*** tonanhngo has quit IRC00:59
*** tonanhngo_ has quit IRC01:00
openstackgerritLiping Mao proposed openstack/kuryr-libnetwork: Miss subnetpool_id in neutron subnet  https://review.openstack.org/38783501:44
*** yedongcan has joined #openstack-kuryr01:47
*** yedongcan has quit IRC02:35
*** ivc_ has quit IRC02:58
*** ivc_ has joined #openstack-kuryr02:59
*** yamamot__ has joined #openstack-kuryr03:05
*** yedongcan has joined #openstack-kuryr03:19
*** tonanhngo has joined #openstack-kuryr03:41
*** tonanhngo has quit IRC03:42
vikasclimao, ping03:51
vikasclimao, git_link_iface function needs both the interface, i.e container-port (port) and vm-port03:52
vikasclimao, vm-port it is accessing from config from within the func03:52
vikascand container port is being passed as parameter03:53
vikasclimao, now does your comment mean that we should pass both as parameter even though we are using vm-port from config file03:54
vikascmchiappero, ping03:54
vikascmchiappero, in auto-detection if there are more than interfaces on vm how we are going to handle that? I would prefer an extra configuratin parameter(vm-port) over imposing an limitation that vm should have one port only03:56
*** tonanhngo has joined #openstack-kuryr04:03
*** tonanhngo has quit IRC04:05
*** yedongcan has quit IRC04:31
limaovikasc: hi04:56
limaovikasc: get_link_iface is used to get the interface name on the nested VM. It is using the VM mac to look for the ifname now. IMO, we do not need container-port there.04:58
*** yedongcan has joined #openstack-kuryr05:08
*** yamamot__ has quit IRC05:41
*** janki has joined #openstack-kuryr05:47
*** yedongcan has quit IRC05:56
*** yedongcan has joined #openstack-kuryr06:17
*** yamamot__ has joined #openstack-kuryr06:20
*** limao has quit IRC06:20
*** limao has joined #openstack-kuryr06:21
openstackgerritvikas choudhary proposed openstack/kuryr: Fix container port ipaddress setting in ipvlan/macvlan drivers  https://review.openstack.org/39705706:28
vikasclimao, i was reading it wrong. you are right06:29
limaovikasc: just see your new patchset, lgtm. thanks06:30
vikasclimao, thanks :)06:30
*** pc_m has quit IRC06:38
*** tonanhngo has joined #openstack-kuryr06:58
*** tonanhngo has quit IRC07:00
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: tox: fix coverage  https://review.openstack.org/39940707:19
ivc_apuimedo, vikasc, pls take a look at https://review.openstack.org/#/c/399407/, if we can merge it, i'd rebase my other patches onto it07:21
*** oanson has joined #openstack-kuryr07:31
vikascivc_, done07:33
ivc_vikasc, cool, thnx07:33
vikascivc_, np07:33
*** oanson has quit IRC07:46
*** oanson has joined #openstack-kuryr07:59
*** dimak has joined #openstack-kuryr08:00
*** openstackgerrit has quit IRC08:03
*** openstackgerrit has joined #openstack-kuryr08:03
*** pc_m has joined #openstack-kuryr08:09
* apuimedo on it08:28
apuimedomerged08:30
yedongcanapuimedo, vikasc: ping08:35
openstackgerritMerged openstack/kuryr-kubernetes: tox: fix coverage  https://review.openstack.org/39940708:35
vikascyedongcan, pong08:35
apuimedoyedongcan: pong08:36
yedongcanapuimedo, vikasc: Is kuryr IPAM driver the only one we can use?08:37
apuimedoyes08:37
apuimedoit was made with that assumption08:37
vikasc+108:37
apuimedoothers, you can use at your own risk :P08:37
apuimedoit may work, but there's no guarantee08:37
yedongcanapuimedo, vikasc: Got it08:38
apuimedo;_008:38
yedongcanapuimedo, vikasc:  I will abandon that patch: https://review.openstack.org/#/c/372955/08:39
vikascapuimedo, i am ipvlan changes, docker is giving error with the mac-address provided by neutron...i am able to recall mchiappero raised issue at docker. is this related08:39
vikascapuimedo, or do you have handy that issue link08:39
vikasc\\"error running hook: exit status 1, stdout: , stderr: time=\\\\\\\\\\\\\\\"2016-11-18T07:47:15Z\\\\\\\\\\\\\\\" level=fatal msg=\\\\\\\\\\\\\\\"failed to add interface t_c9e2dfe63-cc to sandbox: error setting interface \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"t_c9e2dfe63-cc\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\" MAC to \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"fa:16:3e:30:aa:fc\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\": operation not supported\\\\\\\\\\\\\\\" \\\\\\\\n\\\\\\\"\\\"\08:40
vikasc\n\""08:40
vikascs/am/ am trying08:41
apuimedovikasc: weird, haven't seen that one08:41
apuimedoplease, keep digging on it08:41
vikascapuimedo, everything seems fine on kuryr side08:41
apuimedodid you try restarting the docker engine?08:42
vikascDocker version 1.12.3, build 6b644ec08:42
vikascapuimedo, not yet, will do now as you suggested08:42
vikascapuimedo, no luck.. IIRC mchiappero mentoned something similar like they are facing problem with neutron provided mac address08:44
*** pmannidi has quit IRC08:45
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Controller driver base and pod project driver  https://review.openstack.org/39785308:55
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod subnet driver and os-vif utils  https://review.openstack.org/39832408:56
*** pmannidi has joined #openstack-kuryr08:58
*** garyloug has joined #openstack-kuryr09:01
*** lmdaly has joined #openstack-kuryr09:11
lmdalyvikasc, ping09:12
vikasclmdaly, pong09:12
lmdalyI was reading the chat log and see you're getting the error with mac addresses09:12
vikasclmdaly, i have one more observation09:13
lmdalythe ipvlan driver doesn't accept any mac address and docker tries to pass it a mac address (even if the same one is passed)09:13
lmdalyas a workaround I have been passing None for the mac address for ipvlan09:13
vikasclmdaly, you mean None in response to libnetwork for Macaddress?09:14
lmdalyyes, for the response_interface[MacAddress] in create endpoint09:15
vikasclmdaly, cool, so this issue is known to you which i am facing09:15
lmdalyyes, we have tried contacting docker guys about it but have had no luck :(09:16
vikasclmdaly, can you please provide me linkto query to docker?09:17
vikascs/docker mailing list09:17
lmdalyhttps://github.com/docker/libnetwork/issues/155909:20
vikascthanks a lot lmdaly :)09:20
vikascu saved my time09:20
lmdalyno problem! :)09:20
*** vikasc has quit IRC09:39
yedongcanapuimedo: ping09:40
apuimedoyedongcan: pong09:41
*** vikasc has joined #openstack-kuryr09:42
apuimedoyedongcan: I have to step out for a while09:43
yedongcanapuidemo: Do Gal still working on this bug: https://bugs.launchpad.net/kuryr-libnetwork/+bug/152801909:43
openstackLaunchpad bug 1528019 in kuryr-libnetwork "Make neutron-client creation in Kuryr from admin credentials configurable" [Low,Triaged] - Assigned to Gal Sagie (gal-sagie)09:43
apuimedoyedongcan: I don't think so09:43
apuimedohe does noty09:43
apuimedo*not09:43
yedongcanokay, can I take charge it?09:44
apuimedoyedongcan: check if it is already solved otherwise you can assign it to yourself ;-)09:44
apuimedoI'll be back in an hour09:44
yedongcanapuidemo: sure09:44
vikasclmdaly, aorund?10:04
lmdalyvikasc, yep10:06
vikasclmdaly, other than passing None, you would be running allow-address-pair neutron command manually, right?10:06
lmdalyI have code myself to do that but updating it manually would work too10:08
vikasccool10:08
lmdalyhttps://github.com/lmdaly/kuryr-libnetwork/commit/1dc895a6d8bfaa03c0dd5cfb2d3e23e2e948a67c10:13
lmdalythis code is pretty outdated and not very efficient :P10:13
lmdalybut if you want to take the code from _ipvlan_update_port & _ipvlan_remove_ip10:14
lmdalyit does the updating10:15
vikascthats a lot lmdaly10:22
*** limao has quit IRC10:22
*** yedongcan has quit IRC10:22
*** yedongcan has joined #openstack-kuryr10:32
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod security groups driver  https://review.openstack.org/39951810:50
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod security groups driver  https://review.openstack.org/39951810:52
*** janki has quit IRC11:46
*** lmdaly has quit IRC12:10
*** garyloug has quit IRC12:19
*** irenab has joined #openstack-kuryr12:20
*** irenab has quit IRC12:24
*** irenab has joined #openstack-kuryr12:25
vikascirenab, ping12:25
vikascltomasbo, ping12:25
*** irenab has quit IRC12:29
*** garyloug has joined #openstack-kuryr12:39
*** tonanhngo has joined #openstack-kuryr12:41
vikascapuimedo, ping12:42
*** tonanhngo has quit IRC12:43
*** yamamot__ has quit IRC12:59
openstackgerritDongcan Ye proposed openstack/kuryr-libnetwork: Func Test: Using the credentials from config file  https://review.openstack.org/39958513:09
apuimedovikasc: pong13:12
vikascapuimedo, neutron trunk port creation command was not working, then realised plugin  is not enable in neutron.conf13:13
vikascapuimedo, nevermind pls13:13
apuimedo;-)13:13
vikasc:)13:13
*** garyloug has quit IRC13:24
*** irenab has joined #openstack-kuryr13:26
*** irenab has quit IRC13:31
*** ajo_ has joined #openstack-kuryr13:52
*** ajo_ has quit IRC13:54
*** yamamoto has joined #openstack-kuryr13:57
*** yamamoto has quit IRC14:01
*** lmdaly has joined #openstack-kuryr14:06
*** yamamoto has joined #openstack-kuryr14:09
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod security groups driver  https://review.openstack.org/39951814:25
*** garyloug has joined #openstack-kuryr14:38
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Controller driver base and pod project driver  https://review.openstack.org/39785314:47
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod subnet driver and os-vif utils  https://review.openstack.org/39832414:47
*** irenab has joined #openstack-kuryr14:48
*** irenab has quit IRC14:52
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod subnet driver and os-vif utils  https://review.openstack.org/39832414:54
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod security groups driver  https://review.openstack.org/39951814:58
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod security groups driver  https://review.openstack.org/39951815:00
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod security groups driver  https://review.openstack.org/39951815:02
*** lmdaly has quit IRC15:04
*** lmdaly has joined #openstack-kuryr15:05
openstackgerritDongcan Ye proposed openstack/kuryr-libnetwork: Fullstack: Catch neutron-client exception and cleanup resources  https://review.openstack.org/39963315:11
apuimedoivc_: the stevedore approach looks good15:11
apuimedonow that you've added it, I was wondering if you'd not want to use it also for getting the handlers called15:12
ivc_yedongcan, thnx for your suggestion on https://review.openstack.org/#/c/399518! you made me rethink my approach with unset values!15:12
ivc_apuimedo, ofc, but handlers will not use drivers15:12
ivc_we'll use extensions :)15:13
apuimedoyeah, extensions is what I meant15:13
apuimedothe map syntax I find a bit ugly15:13
apuimedobut I guess that we can clean it up a bit15:13
ivc_its ok15:13
ivc_apuimedo, i think i'm not gonna add extensions for handlers until we are done with services/endpoints handler15:16
openstackgerritDongcan Ye proposed openstack/kuryr-libnetwork: Fullstack: Catch neutron-client exception and cleanup resources  https://review.openstack.org/39963315:16
apuimedoivc_: that's sensible15:16
*** irenab has joined #openstack-kuryr15:17
ivc_apuimedo, its non-essential so its its on the bottom of my todo-list, but if someone wants to implement it it is totally possible right now15:17
apuimedogotcha15:18
*** hongbin has joined #openstack-kuryr15:19
apuimedoivc_: I was wondering about the type checking you added to DriverBase.get_instance15:19
apuimedofeels a bit unidiomatic15:20
ivc_apuimedo, you mean non-pythonic?15:21
*** irenab has quit IRC15:21
apuimedoyup15:21
ivc_i had my doubts about it for different reason - i.e. if someone wants to implement a driver he'll need to import driverbase from our module15:22
apuimedoyes, I got it as a help for plugin implementers15:22
apuimedoI'm not flatly opposed to having it. It just seems that it could be covered with devref for driver implementation15:23
ivc_but we are dealing with external stuff here. i'd rather do a type check than let things explode with wrong plugin15:23
apuimedothere's many ways in which external things can explode :-)15:23
apuimedolet's keep this for now, but we may move it to doc in the future15:24
ivc_aight15:24
apuimedovikasc: please, review https://review.openstack.org/#/c/397853/515:24
ivc_mind reviewing those patches while you are at it? xD15:24
apuimedowhich?15:24
apuimedoI'm in the process of approving the whole dependency chain15:24
ivc_https://review.openstack.org/#/c/398324/15:24
ivc_https://review.openstack.org/#/c/399518/15:24
apuimedoI'm just a bit slow reviewing tests15:24
apuimedo:P15:25
ivc_right15:25
vikascits got late now15:25
ivc_thnx :)15:25
vikasctomorrow morning will try out15:25
apuimedothanks vikasc15:25
vikascall the changes15:25
vikascapuimedo, ye15:25
vikascs/yw15:25
*** yamamoto_ has joined #openstack-kuryr15:26
ivc_i'm glad i've managed to sneak that 'RequiredOptError' change before you reviewed it :) yedongcan comment was so well timed!15:27
apuimedo:-)15:27
apuimedoand I'm glad you kept https://review.openstack.org/#/c/398324/6/kuryr_kubernetes/controller/drivers/default_subnet.py module level :P15:27
ivc_i know you are obsessed with module-level stuff :)15:28
*** oanson has quit IRC15:29
apuimedo/¯\_(ツ)_/¯15:29
apuimedoyou got me15:29
ivc_xD15:29
*** yamamoto has quit IRC15:29
ivc_i was tempted to make it a mixin just to see your comment xD15:30
apuimedoyou are evil15:31
apuimedo:P15:31
ivc_but my hands simply wont type that15:31
apuimedoy=ｰ( ﾟдﾟ)･∵.15:31
apuimedoivc_: there's some disagreement in https://review.openstack.org/#/c/398324/6/kuryr_kubernetes/controller/drivers/base.py between subnet/subnets15:35
ivc_true15:35
ivc_should be 'subnets'15:36
apuimedothe method is called get_subnets but apparently it returns a single os_vif net (in a dict)15:36
ivc_for now15:36
apuimedoI suppose15:36
ivc_but we expect multiple ports in k8s, right?15:36
apuimedothat it should be returning a mapping for all subnet_id to all os_vif nets15:36
apuimedoif for example it uses teh etcd backing you wanted15:36
apuimedoivc_: we do15:37
ivc_it should return all subnets we want to create ports on15:37
apuimedoright15:37
apuimedoso I got it right15:37
apuimedothe docstring should be fixed15:37
apuimedoshould I post a comment?15:37
ivc_sure15:37
apuimedovery well15:37
ivc_bump your -1 stats :P15:37
apuimedo:-)15:37
ivc_honestly if it wasnt for the fact that os-vif lacks subnet.id (while it has an id for both vif and network), i would've probably made it get_subnet that returns a single Network object (not confusing at all, right!)15:40
apuimedo:O15:43
apuimedoI didn't notice that at all15:43
* apuimedo checks15:44
apuimedowtf15:44
apuimedoivc_: what do you say we send a patch to os-vif and in the future we use that?15:44
ivc_apuimedo, well we won't need it since we already making it {subnet_id:Network} in API15:45
ivc_and it is in fact more convinient this way15:46
apuimedook then15:46
ivc_as we'd have to build this dictionary when converting Port to VIF15:46
apuimedoyeah15:48
*** yedongcan has left #openstack-kuryr15:49
*** HenryG has quit IRC15:50
*** HenryG has joined #openstack-kuryr15:51
ivc_apuimedo, btw do you know if there's any dependency mechanism in devstack plugins?15:52
apuimedokinda15:52
apuimedoyou can have a plugin enable another15:52
apuimedobut I'm not aware of anything more than that15:52
ivc_we need to set 'neutron_defaults' in kuryr.conf at some point15:53
ivc_but for that we need neutron to be available and fully configured (i.e. with subnets/sec.groups/etc)15:54
*** tonanhngo has joined #openstack-kuryr15:54
apuimedothere's a post hook15:54
*** tonanhngo has quit IRC15:54
ivc_oh btw the new 'openstack' client thingy is lovely! try 'openstack security group list' - there's no way specifying tenant/project_id there!15:55
ivc_apuimedo, do you think i should keep the driver's alias 'pod_subnet' or make it 'pod_subnets' (and the same for the class name itself)?16:03
*** dimak has quit IRC16:12
*** vikasc has quit IRC16:14
*** vikasc has joined #openstack-kuryr16:15
*** tonanhngo has joined #openstack-kuryr16:16
*** tonanhngo has quit IRC16:17
ivc_apuimedo, also regarding the 'str' casting - not sure if it is worth it since values are from ascii range16:17
*** tonanhngo has joined #openstack-kuryr16:24
*** tonanhngo has quit IRC16:25
*** tonanhngo has joined #openstack-kuryr16:26
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod subnet driver and os-vif utils  https://review.openstack.org/39832416:31
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod subnet driver and os-vif utils  https://review.openstack.org/39832416:33
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes: Default pod subnet driver and os-vif utils  https://review.openstack.org/39832416:43
lmdalyapuimedo, can this get a +2 whenever you get the chance? ( Critical fix ;) ) https://review.openstack.org/#/c/396683/17:08
lmdalyAlso would it be possible to get the dependency fix so this review can be merged? As it is needed for the libnetwork driver https://review.openstack.org/#/c/394547/17:10
*** lmdaly has quit IRC17:34
*** garyloug has quit IRC17:59
*** irenab has joined #openstack-kuryr17:59
*** irenab has quit IRC18:03
*** irenab has joined #openstack-kuryr18:16
*** irenab has quit IRC18:20
*** diga has joined #openstack-kuryr18:47
*** oanson has joined #openstack-kuryr18:52
*** irenab has joined #openstack-kuryr18:55
*** irenab has quit IRC19:00
*** oanson has quit IRC19:31
*** neiljerram has quit IRC19:34
apuimedosure can19:58
apuimedoivc_: it's not about the ascii range, sometimes with py2/py3 can get you problems there IIRC19:59
apuimedoivc_: regarding the name change... Yes I think we should make it plural20:00
openstackgerritMerged openstack/kuryr-libnetwork: [TrivialFix] Replace DeleteEndpoint with Leave in debug  https://review.openstack.org/39668320:05
openstackgerritOpenStack Proposal Bot proposed openstack/kuryr-libnetwork: Updated from global requirements  https://review.openstack.org/35197621:26
*** diga has quit IRC21:34
ivc_apuimedo, regarding 'str', there are indeed problems with py3 where (b"1" != "1") while in py2 (u"1" == "1"), but we are dealing with strings here and tests on 'gate-kuryr-kubernetes-python35-nv' pass without issues for py321:52
ivc_apuimedo, also consider that we are comparing a constant (that is of 'str' type for both py2 and py3) with value cast to 'str'21:57
*** hongbin has quit IRC22:22
*** hongbin has joined #openstack-kuryr22:26
*** hongbin has quit IRC22:29
*** irenab has joined #openstack-kuryr22:31
*** irenab has quit IRC22:35
*** irenab has joined #openstack-kuryr23:25
*** irenab has quit IRC23:30
« Thursday, 2016-11-17 Index Saturday, 2016-11-19 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!