*** limao has joined #openstack-kuryr | 00:35 | |
*** yedongcan1 has joined #openstack-kuryr | 01:37 | |
*** diogogmt has quit IRC | 01:46 | |
*** yedongcan1 has quit IRC | 01:58 | |
*** yedongcan has joined #openstack-kuryr | 02:01 | |
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Fullstack: Using the credentials from openrc config file https://review.openstack.org/399585 | 02:10 |
---|---|---|
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Fullstack: Using the credentials from openrc config file https://review.openstack.org/399585 | 02:51 |
*** yamamoto has joined #openstack-kuryr | 02:51 | |
*** yamamoto has quit IRC | 02:52 | |
*** tonanhngo has quit IRC | 02:53 | |
*** diogogmt has joined #openstack-kuryr | 02:56 | |
vikasc | mchiappero, sorry i could not understand your last line "regarding kuryr-lib assigning IP addresses, yes, I think we can provide no IPs (good), a flag (less good), an additional code path to be invoked by k-k8s only" | 03:00 |
vikasc | mchiappero, what is "we" in "we can provide"? and which "flag"? | 03:01 |
vikasc | hello limao | 03:03 |
limao | hi vikasc | 03:03 |
vikasc | limao, first of all thanks a lot for the time you put in on my query :) | 03:03 |
limao | vikasc:-) | 03:04 |
vikasc | limao, i verified that setting ageing to 0 make it work | 03:04 |
vikasc | limao, but now in mac table i dont see an entry for ns macs? | 03:05 |
vikasc | limao, what does this step do actually | 03:05 |
limao | vikasc: Yes... set ageing to 0 means not learn mac | 03:05 |
limao | vikasc: Another thing is neutron do not work with hybird-iptables fw by design | 03:06 |
limao | vikasc: so we need to use ovs-fw... not hybird-iptables fw | 03:06 |
vikasc | limao, do you think we should be worried about that.. i think we should not | 03:06 |
vikasc | :) | 03:06 |
vikasc | limao, because that upto user if he is using trunk support, he should choose backened accordingly | 03:07 |
limao | vikasc: Yeah, But for cloud provider, this will be a limitation :) | 03:07 |
vikasc | limao, yes..and limitation will be from neutron, right? | 03:08 |
limao | vikasc: in our perspactive, we just need to update our default devstack configure (I think need to enable trunk and use ovs-fw by default) | 03:08 |
vikasc | limao, i think i should test and complete my vlan driver patch with this ageingtimer setting | 03:08 |
vikasc | limao, agree | 03:08 |
limao | vikasc: you should test with ovs-fw | 03:09 |
limao | vikasc: that has been confrimed with neutron guys | 03:09 |
vikasc | limao, yeah...will do | 03:09 |
limao | (You can see the log we posted yestorday) | 03:09 |
vikasc | limao, another point on vlan-per-container and vlan-per-network | 03:10 |
vikasc | limao, yeah i read the logs | 03:10 |
limao | vikasc: Cool, I will also do some test... (I post some comments on that patch, please help to have a look when you have time) | 03:11 |
vikasc | limao, i have not tried, but i think it vxlan-per-segment should also be possible | 03:11 |
vikasc | limao, sorry vxlan-per-container i mean | 03:11 |
vikasc | limao, because trunk apis just take segment id | 03:12 |
limao | vikasc: well, what is vxlan-per-container ? | 03:12 |
vikasc | limao, instead of creating vlan interfaces, creating vxlan interfaces | 03:12 |
vikasc | limao, per container | 03:13 |
limao | vikasc: well , I think vm-nested do not care what kind of segment you are using between compute nodes(vxlan/vlan/gre) | 03:13 |
limao | vikasc: I did not get why we need to create vxlan interface in nested vm? | 03:13 |
vikasc | limao, this segment is not betwen compute nodes, this is inside compute node for isolating container traffic | 03:14 |
vikasc | limao, just like why we create vlan interface in nested vm | 03:14 |
limao | vikasc: when we create vlan segment in nested-vm, it will mapping to a neutron network, I think we do not need to care what the segment of that neutron network is using(vlan/vxlan/gre) | 03:16 |
limao | vikasc: (sorry I may not get what you mean...) | 03:16 |
vikasc | limao, i am not saying we need to care.. i am saying like vlan-vlan or vlan-vxlan or vlan-gre are possible combinations | 03:17 |
vikasc | limao, vxlan-vlan, vxlan-vxlan, vxlan-gre are also possible combinations | 03:17 |
vikasc | limao, could i make my point clear now? | 03:18 |
limao | vikasc: oh... vlan-vlan or vlan-vxlan or vlan-gre, naturally it already supported by neutron | 03:18 |
limao | vikasc: I'm not understand why we need vxlan-vlan, vxlan-vxlan, vxlan-gre ? | 03:19 |
vikasc | limao, to avoid the limitation of 4094 containers if vlan-per-container is used | 03:19 |
limao | vikasc: oh... I think 4096 containers on one node(VM) is large enough in my mind.. | 03:20 |
vikasc | limao, "large enough" might be a relative term :) | 03:21 |
vikasc | limao, bigger limit with vxlan will be an additional option | 03:22 |
limao | vikasc: yeah maybe, then we will have double overlay | 03:22 |
limao | vikasc:) | 03:23 |
vikasc | limao, double overlay will not be there if vxlan is supported by neutron trunk port feature | 03:23 |
vikasc | limao, first overlay would end an trunk bridge just like vlan tags | 03:24 |
limao | vikasc: oh... get you, that need supported by neutron trunk | 03:24 |
vikasc | limao, yes | 03:24 |
vikasc | limao, we can consider it next after first completing vlan part | 03:25 |
limao | vikasc: Yeah, after neutron support this :) | 03:25 |
vikasc | limao, yep, because trunk bridge has to be configured with flows to encap-decap | 03:26 |
limao | vikasc: I will try vlan driver later, will let you know if there is problem | 03:26 |
vikasc | limao, sure, i have not tested it yet.. now will do testing and add unit test cases | 03:27 |
vikasc | limao, thanks Liping | 03:27 |
limao | vikasc: wlc, some comments on that patch, please have a look when you have time | 03:27 |
vikasc | limao, sure. | 03:28 |
limao | vikasc: see you , have lunch now. | 03:28 |
vikasc | limao, c u | 03:28 |
openstackgerrit | Zhigang Li proposed openstack/kuryr-libnetwork: Replace six.iteritems() with .items() https://review.openstack.org/401056 | 03:56 |
*** yedongcan1 has joined #openstack-kuryr | 04:01 | |
*** yedongcan has quit IRC | 04:05 | |
openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: Unittests with Mock and added a TestCase https://review.openstack.org/394001 | 04:08 |
*** jgriffith is now known as jgriffith_away | 04:10 | |
*** yamamoto has joined #openstack-kuryr | 04:21 | |
*** yamamoto has quit IRC | 04:23 | |
*** tonanhngo has joined #openstack-kuryr | 04:32 | |
openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: Unittests with Mock and added a TestCase https://review.openstack.org/394001 | 04:46 |
openstackgerrit | vikas choudhary proposed openstack/kuryr: Nested-Containers: vlan driver https://review.openstack.org/361993 | 04:52 |
janonymous | apuimedo, ivc_, irenab, vikasc: ^^ | 04:53 |
*** yamamoto has joined #openstack-kuryr | 04:54 | |
*** yamamoto has quit IRC | 04:54 | |
openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: Unittests with Mock and added a TestCase https://review.openstack.org/394001 | 05:14 |
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Fullstack: Catch neutron-client exception and cleanup resources https://review.openstack.org/399633 | 05:23 |
vikasc | limao, ping | 05:46 |
vikasc | limao, on segmentation id, "penstack network trunk set --subport port=child-port,segmentation-type=vlan,segmentation-id=101 trunk0" user seems to be telling segmentation id to neutron. Later on it can be queried using trunk port details from neutron | 05:48 |
yedongcan1 | vikasc: ping | 05:51 |
vikasc | yedongcan1, pong | 05:51 |
yedongcan1 | vikasc: Thanks for you review, would see this message is suitable: | 05:53 |
yedongcan1 | Missing environment variable %s in your local. Please add it and also check other missing environment variables. After that please source the openrc file. | 05:53 |
vikasc | yedongcan1, will it be needed to source openrc even after adding all missing env variable? | 05:56 |
limao | vikasc: hi | 05:57 |
limao | vikasc | 05:57 |
vikasc | hi limao, i just verified | 05:57 |
vikasc | limao, user need to pass segmentation id while attaching subport to parent port | 05:58 |
limao | Yes, it is , I mean you can pull what has been used in this trunk when kuryr-libnetwork restart | 05:58 |
vikasc | limao, in kuryr case, kuryr has to generate and pass that | 05:58 |
yedongcan1 | vikasc: yes, we need. | 05:59 |
limao | vikasc: logically, you can pull what has been used, then choose an unused one, then use it and pass it to openstack network trunk set | 05:59 |
vikasc | limao, okay got it | 06:00 |
limao | vikasc: (by this way we use neutron trunk info as our 'DB') | 06:00 |
vikasc | limao, nice | 06:00 |
limao | vikasc :) | 06:00 |
vikasc | limao, good idea | 06:00 |
vikasc | limao, :) | 06:00 |
vikasc | limao, but i think calling neutron apis should be in COE code | 06:01 |
limao | For, performance, we can cache the info when kuryr start, so that we do not need to get it every time from neutron | 06:01 |
vikasc | limao, and then somehow extracted info should be passed to kuryr-lib apis | 06:01 |
limao | vikasc: Yeah, | 06:02 |
*** yamamoto has joined #openstack-kuryr | 06:02 | |
limao | vikasc: it can be pass to driver from kuryr-libnetwork or kuryr-k8s | 06:02 |
vikasc | limao, yep, so this caching part should be done in kuryr-libnetwork and cached values set should be passed to the api | 06:03 |
limao | vikasc: Yes, then we need an api in kuryr-lib to set it | 06:04 |
vikasc | limao, cool, let me reformat it | 06:04 |
limao | vikasc: thanks | 06:04 |
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Fullstack: Using the credentials from openrc config file https://review.openstack.org/399585 | 06:05 |
vikasc | yedongcan1, limao why do we need to source the openrc when we have already set all the required env variables, asking just for my understanding | 06:05 |
limao | vikasc: I was thought, yedongcan1 want to run this fulltest in an existed "openstack environment" | 06:06 |
yedongcan1 | vikasc: if we modify the file, we need to source it. This will export the new env. | 06:10 |
limao | vikasc: something like, I enable kuryr in an existed "openstack environment", well, I want to try fullstack test there, if I can easily import from openrc, it will be easy for run the fullstack test there. (This is what I was thought), correct me, yedongcan1 | 06:10 |
yedongcan1 | limao: Yes , you're right. | 06:11 |
vikasc | yedongcan1, got the point. | 06:11 |
yedongcan1 | limao: this also can run DevStack environment | 06:12 |
vikasc | limao, yedongcan1 ifullstack tests wont stop though, it will give warning and try to get neutron client using credentials from clouds.yaml | 06:12 |
yedongcan1 | vikasc: Yes, we provide two options. | 06:13 |
vikasc | cool | 06:14 |
vikasc | yedongcan1, this warning sounds like an strict exception message though. do you guys think it should additionally be saying "trying credentials from cloud.yaml"? | 06:16 |
vikasc | limao, ^ | 06:16 |
vikasc | its upto you guys | 06:16 |
vikasc | :) | 06:16 |
vikasc | i am fine anyways | 06:17 |
limao | vikasc: me too, upto yedongcan1 | 06:17 |
yedongcan1 | vikasc, limao: sounds good, will update | 06:18 |
vikasc | thanks yedongcan1 limao | 06:18 |
openstackgerrit | Zhigang Li proposed openstack/kuryr-libnetwork: Replace six.iteritems() with .items() https://review.openstack.org/401056 | 06:21 |
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Fullstack: Using the credentials from openrc config file https://review.openstack.org/399585 | 06:24 |
yedongcan1 | vikasc: thanks, update it | 06:24 |
vikasc | yedongcan1, done | 06:25 |
*** janki has joined #openstack-kuryr | 06:26 | |
openstackgerrit | Ilya Chukhnakov proposed openstack/kuryr-kubernetes: devstack: set neutron_defaults https://review.openstack.org/401078 | 06:29 |
*** yamamoto has quit IRC | 06:34 | |
*** yamamoto has joined #openstack-kuryr | 06:43 | |
*** yamamoto has quit IRC | 06:43 | |
*** oanson has joined #openstack-kuryr | 06:43 | |
*** yamamoto has joined #openstack-kuryr | 06:51 | |
openstackgerrit | Ilya Chukhnakov proposed openstack/kuryr-kubernetes: Controller side of pods' port/VIF binding https://review.openstack.org/376044 | 06:53 |
openstackgerrit | Ilya Chukhnakov proposed openstack/kuryr-kubernetes: devstack: set neutron_defaults https://review.openstack.org/401078 | 06:53 |
ivc_ | apuimedo, ping | 06:55 |
openstackgerrit | vikas choudhary proposed openstack/kuryr: Nested-Containers: vlan driver https://review.openstack.org/361993 | 06:57 |
*** yamamoto has quit IRC | 06:57 | |
mchiappero | vikasc: by "we" I mean you, Toni, me, whoever... | 07:13 |
mchiappero | forget about the flag | 07:13 |
vikasc | mchiappero, aah.. thanks | 07:15 |
*** dimak has joined #openstack-kuryr | 07:51 | |
*** tonanhngo has quit IRC | 07:57 | |
*** tonanhngo has joined #openstack-kuryr | 08:01 | |
*** tonanhngo has quit IRC | 08:03 | |
*** yamamoto has joined #openstack-kuryr | 08:08 | |
*** yamamoto has quit IRC | 08:19 | |
*** gsagie has joined #openstack-kuryr | 08:19 | |
*** yamamoto has joined #openstack-kuryr | 08:23 | |
*** tonanhngo has joined #openstack-kuryr | 08:24 | |
*** tonanhngo has quit IRC | 08:25 | |
*** yamamoto has quit IRC | 08:29 | |
*** yamamoto has joined #openstack-kuryr | 08:30 | |
*** yamamoto has quit IRC | 08:35 | |
irenab | vikasc: hi | 08:42 |
vikasc | irenab, hi | 08:43 |
irenab | vikasc: I want to merge https://review.openstack.org/#/c/400010/, do you want to take a look or can I merge it? | 08:43 |
vikasc | irenab, yes please go ahead. | 08:44 |
irenab | vikasc: great, thanks | 08:44 |
vikasc | irenab, thank you!! | 08:45 |
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Fullstack: Catch neutron-client exception and cleanup resources https://review.openstack.org/399633 | 08:51 |
*** tonanhngo has joined #openstack-kuryr | 08:54 | |
*** tonanhngo has quit IRC | 08:57 | |
ivc_ | irenab, thnx, i just want to note that https://review.openstack.org/#/c/400010/ depends on https://review.openstack.org/#/c/399953 | 09:03 |
irenab | ivc_: yep, just realized and going thouth it | 09:03 |
ivc_ | irenab, cool. btw if you want to test it with devstack, i've added https://review.openstack.org/#/c/401078/ | 09:04 |
irenab | ivc_: great, thanks! | 09:04 |
irenab | ivc_: merged both of them | 09:11 |
ivc_ | irenab, awesome! | 09:11 |
openstackgerrit | Merged openstack/kuryr-kubernetes: Port-to-VIF os-vif translator for hybrid OVS case https://review.openstack.org/399953 | 09:14 |
openstackgerrit | Merged openstack/kuryr-kubernetes: Generic VIF controller driver https://review.openstack.org/400010 | 09:15 |
*** tonanhngo has joined #openstack-kuryr | 09:15 | |
*** tonanhngo has quit IRC | 09:15 | |
openstackgerrit | Dongcan Ye proposed openstack/kuryr: Fix wrong exception catch in port_unbind https://review.openstack.org/401148 | 09:19 |
*** garyloug has joined #openstack-kuryr | 09:32 | |
*** lmdaly has joined #openstack-kuryr | 09:34 | |
ivc_ | irenab, vikasc, apuimedo, is anyone going to atlanta ptg? or have we decided to have a virtual meeting? | 09:35 |
vikasc | ivc_, i think virtual meeting is that we decided on in last meeting, not sure though. | 09:36 |
vikasc | ivc_, are you going? | 09:36 |
ivc_ | vikasc, dunno yet | 09:37 |
*** tonanhngo has joined #openstack-kuryr | 09:44 | |
*** tonanhngo has quit IRC | 09:46 | |
yedongcan1 | vikasc, apuimedo: ping, are you around? | 09:50 |
irenab | ivc_: apuimedo suggested virtual meeting | 09:50 |
vikasc | yedongcan1, pong | 09:50 |
yedongcan1 | vikasc: how to pass option in network create, if we want pass pool name? | 09:51 |
yedongcan1 | vikasc: In the API, is this format correct: "Options": {"com.docker.network.generic": {"neutron.pool.name": "test_kuryr_pool"}} ? | 09:52 |
vikasc | yedongcan1, https://github.com/openstack/kuryr-libnetwork#limitations-1 | 09:53 |
vikasc | yedongcan1, $ sudo docker network create --driver=kuryr --ipam-driver=kuryr \ | 09:54 |
vikasc | --subnet 10.0.0.0/16 --ip-range 10.0.0.0/24 \ | 09:54 |
vikasc | -o neutron.pool.name=neutron_pool2 \ | 09:54 |
vikasc | --ipam-opt=neutron.pool.name=neutron_pool2 \ | 09:54 |
vikasc | bar | 09:54 |
yedongcan1 | vikasc: Do you mean we no need "com.docker.network.generic" here? | 09:58 |
vikasc | yedongcan1, i dont think so... docker will add it implicitly | 09:58 |
vikasc | yedongcan1, please try it out | 09:59 |
limao | yedongcan1: "com.docker.network.generic" is added by libnetwork | 10:00 |
*** tonanhngo has joined #openstack-kuryr | 10:05 | |
yedongcan1 | vikasc, limao: Thanks, Got it. | 10:05 |
vikasc | yedongcan1, np | 10:06 |
*** tonanhngo has quit IRC | 10:07 | |
*** limao has quit IRC | 10:17 | |
*** limao has joined #openstack-kuryr | 10:17 | |
*** yedongcan1 has left #openstack-kuryr | 10:17 | |
*** limao has quit IRC | 10:22 | |
*** tonanhngo has joined #openstack-kuryr | 10:24 | |
*** tonanhngo has quit IRC | 10:25 | |
apuimedo | vikasc please, merge https://review.openstack.org/#/c/394771/ | 10:42 |
vikasc | apuimedo, done :) | 10:44 |
openstackgerrit | Merged openstack/kuryr-libnetwork: Fullstack: Catch neutron-client exception and cleanup resources https://review.openstack.org/399633 | 10:45 |
openstackgerrit | Merged openstack/kuryr-libnetwork: Unittests with Mock and added a TestCase https://review.openstack.org/394001 | 10:45 |
openstackgerrit | Merged openstack/kuryr-libnetwork: Fullstack: Using the credentials from openrc config file https://review.openstack.org/399585 | 10:45 |
openstackgerrit | Merged openstack/kuryr: Fix container port ipaddress setting in ipvlan/macvlan drivers https://review.openstack.org/397057 | 10:45 |
openstackgerrit | Merged openstack/kuryr: Fixed Warning while executing 'tox -e docs' https://review.openstack.org/394771 | 10:47 |
apuimedo | thanks vikasc ! | 10:50 |
apuimedo | janonymous: could you rebase https://review.openstack.org/#/c/394324/ and the other one? | 10:51 |
*** tonanhngo has joined #openstack-kuryr | 10:54 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-libnetwork: Updated from global requirements https://review.openstack.org/351976 | 10:56 |
*** tonanhngo has quit IRC | 10:59 | |
*** tonanhngo has joined #openstack-kuryr | 11:04 | |
*** tonanhngo has quit IRC | 11:05 | |
vikasc | ivc_, DO we still need this directory, https://github.com/openstack/kuryr-kubernetes/tree/master/kuryr_kubernetes/handlers ? | 11:19 |
ivc_ | vikasc, yes ofc | 11:19 |
ivc_ | its the core of the pipeline and base for controller/cni handlers | 11:20 |
vikasc | ivc_, got it | 11:21 |
vikasc | ivc_, thansk | 11:21 |
vikasc | s/thanks | 11:21 |
ivc_ | np | 11:21 |
*** tonanhngo has joined #openstack-kuryr | 11:24 | |
*** tonanhngo has quit IRC | 11:25 | |
*** gsagie has quit IRC | 11:28 | |
*** tonanhngo has joined #openstack-kuryr | 11:44 | |
*** tonanhngo has quit IRC | 11:46 | |
mchiappero | folks, what do you think about the check on the mac address for neutron ports? It's a fair check frankly, but do you think there would be a chance to get it removed? | 11:50 |
apuimedo | mchiappero: which check? | 12:01 |
apuimedo | link? | 12:01 |
*** openstackgerrit has quit IRC | 12:03 | |
*** openstackgerrit has joined #openstack-kuryr | 12:03 | |
mchiappero | I don't have a link but if you run neutron port-create and provide a mac address already used by another port it will complain and bail out | 12:12 |
*** tonanhngo has joined #openstack-kuryr | 12:15 | |
*** tonanhngo has quit IRC | 12:16 | |
mchiappero | Unable to complete operation for network cf61d688-65b8-4ee8-8ff7-ace2926c2cb2. The mac address fa:16:3e:db:59:e3 is in use. | 12:21 |
mchiappero | Neutron server returns request_ids: ['req-622a6a4c-4f0e-45d1-88dc-00ed3b317eda'] | 12:21 |
*** lmdaly has quit IRC | 12:27 | |
*** tonanhngo has joined #openstack-kuryr | 12:34 | |
*** tonanhngo has quit IRC | 12:35 | |
*** dimak has quit IRC | 12:50 | |
*** garyloug has quit IRC | 12:50 | |
irenab | apuimedo: ping | 12:51 |
*** oanson has quit IRC | 12:53 | |
*** tonanhngo has joined #openstack-kuryr | 13:05 | |
*** tonanhngo has quit IRC | 13:06 | |
*** tonanhngo has joined #openstack-kuryr | 13:25 | |
*** yamamoto has joined #openstack-kuryr | 13:25 | |
*** tonanhngo has quit IRC | 13:26 | |
ltomasbo | mchiappero, you can create port with the same mac, as long as they are in different subnets | 13:32 |
mchiappero | ltomasbo: ok but nested containers are expected to be part of the same subnet, so... | 13:54 |
mchiappero | thank you for clarifying anyway :) | 13:54 |
*** tonanhngo has joined #openstack-kuryr | 13:55 | |
*** tonanhngo has quit IRC | 13:56 | |
*** dimak has joined #openstack-kuryr | 14:09 | |
apuimedo | irenab: pong | 14:10 |
irenab | apuimedo: I was playing with ivc_ patvhes and had some issues with kubelet and CNI_BIN_DIR | 14:10 |
irenab | mostly due to the problems I coused in my environment :-) | 14:10 |
apuimedo | irenab: can you describe them further | 14:11 |
apuimedo | I'd like to improve devstack | 14:11 |
irenab | but it looks like we may need to bump the k8s version to support CNI BIN DR flag | 14:11 |
irenab | DIR | 14:11 |
ivc_ | and cni-conf-dir | 14:11 |
irenab | with what version did you check https://review.openstack.org/#/c/396113/ | 14:12 |
ivc_ | irenab, there were also problems with 'nsenter' i think | 14:12 |
apuimedo | irenab: I was checking it when I found out it got merged | 14:12 |
apuimedo | xD | 14:12 |
irenab | correct | 14:12 |
irenab | so with 1.3.7? | 14:13 |
apuimedo | and yesterday I didn't launch any more | 14:13 |
apuimedo | yes. 1.3.7 | 14:13 |
ivc_ | i think we need to bump to 1.4.6 to get those options | 14:13 |
ivc_ | well, 1.4.x | 14:13 |
* apuimedo checking now | 14:13 | |
apuimedo | I'll send a patch | 14:14 |
irenab | apuimedo: thanks | 14:14 |
ivc_ | apuimedo, also i've updated https://review.openstack.org/#/c/376044/ this morning and lost your +2 :) | 14:14 |
ivc_ | also it would be nice to merge it along with https://review.openstack.org/#/c/401078 | 14:15 |
apuimedo | ivc_: I'm waiting for the same as irenab on that one :P | 14:16 |
ivc_ | i'm ok if we stall https://review.openstack.org/#/c/376044/ for a bit | 14:16 |
irenab | apuimedo: I verified both ivc_ patches | 14:17 |
apuimedo | irenab: I thought you'd put +2 when you had them verified | 14:17 |
ivc_ | F5 | 14:17 |
ivc_ | :) | 14:18 |
apuimedo | :P | 14:18 |
apuimedo | I am not keeping up ;/ | 14:18 |
irenab | apuimedo: just did | 14:18 |
irenab | even faked the CNI part … | 14:19 |
ivc_ | ^ http://paste.openstack.org/show/590209/ | 14:19 |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes: devstack: move to k8s 1.4.6 https://review.openstack.org/401280 | 14:20 |
irenab | ivc_: actually,I just did it externally to the controller too, so we can see the async ‘beauty’ of this flow | 14:20 |
irenab | apuimedo: I like the way you put ‘pain’ in the commit messge | 14:21 |
* ivc_ wonders if 'beauty' means good or bad because of ' ' :0 | 14:22 | |
apuimedo | irenab: 'pain'? I don't see it | 14:23 |
*** lmdaly has joined #openstack-kuryr | 14:23 | |
irenab | missing gate testing | 14:23 |
apuimedo | ah, yes | 14:23 |
apuimedo | it is terrible | 14:23 |
apuimedo | it has become my top priority now | 14:23 |
apuimedo | ivc_: the rule is: if it works it is beatiful, if it doesn't it is sketchy | 14:24 |
apuimedo | xD | 14:24 |
ivc_ | xD | 14:24 |
irenab | ivc_: possitive meaning | 14:24 |
apuimedo | unless it does too many round trips, then even if it works it is a bit "cute" | 14:25 |
*** tonanhngo has joined #openstack-kuryr | 14:25 | |
*** tonanhngo has quit IRC | 14:26 | |
ivc_ | well it does now more than it needs to :) but we have that in mind | 14:26 |
apuimedo | and in TODO comments :P | 14:26 |
ivc_ | well 1 TODO is intentionally missing :) | 14:27 |
ivc_ | https://review.openstack.org/#/c/376044/6/kuryr_kubernetes/controller/handlers/vif.py@70 | 14:27 |
ivc_ | one of the reasons i'd like to add RecyclingPodVIFDriver :) | 14:28 |
ivc_ | eventually | 14:28 |
irenab | ivc_: instead of Generic? | 14:29 |
ivc_ | atop of it | 14:29 |
ivc_ | or as a decorator | 14:29 |
apuimedo | ivc_: why don't you make a blueprint for recyclingpodvifdriver? | 14:29 |
ivc_ | bcuz i need to deliver services/endpoints in like 3 weeks :) | 14:30 |
apuimedo | ivc_: that's a good point | 14:30 |
ivc_ | and i've only started on cni | 14:30 |
ivc_ | btw | 14:30 |
ivc_ | found 1 cool trick about cni | 14:31 |
ivc_ | probably i can just call https://github.com/containernetworking/cni/tree/master/plugins/main/bridge with dhcp ipam | 14:31 |
ivc_ | after doing os-vif.plug and pass it the bridge name | 14:31 |
ivc_ | which means there'd be no kuryr-lib binding used. it it works :) | 14:32 |
ivc_ | *if | 14:33 |
apuimedo | ivc_: only for the ovs-hybrid | 14:33 |
ivc_ | ovs-native is a problem, yes | 14:34 |
ivc_ | i mean for poc impl | 14:34 |
apuimedo | sdure | 14:34 |
apuimedo | *sure | 14:34 |
ivc_ | but they have ipvlan and macvlan there too | 14:35 |
ivc_ | so maybe we can get ovs-bridge into cni repo | 14:36 |
apuimedo | maybe | 14:37 |
irenab | ivc_: I think we better have it generic, to keep the door open for other backends | 14:38 |
ivc_ | irenab, the idea is that 'cni' is more generic | 14:40 |
irenab | apuimedo: ivc_ do we eventually want kuryr to be one of the option at https://github.com/containernetworking/cni/tree/master/plugins/main? | 14:40 |
ivc_ | irenab, i mean the opposite - that kuryr can reuse existing CNI drivers if possible | 14:41 |
ivc_ | i'm still not sure if it is a good idea or not | 14:41 |
apuimedo | irenab: that's a good question. Personally I would find it agreeable that kuryr CNI binary part was in containernetworking repo | 14:41 |
apuimedo | reusing parts is a bit of a grey aread | 14:42 |
apuimedo | *area | 14:42 |
irenab | ivc_: ‘sleep on this’ and maybe we can have shoe hangout chat tomorrow? | 14:42 |
*** yamamoto has quit IRC | 14:42 | |
irenab | s/show/some | 14:42 |
apuimedo | I'll make it a show | 14:42 |
irenab | :-) | 14:42 |
apuimedo | irenab: I confirm that my patch makes devstack not fail to stack | 14:42 |
irenab | apuimedo: cool. Can we merge it? | 14:43 |
ivc_ | irenab, sure, just send an invite when you feel comfortable | 14:44 |
*** yamamoto has joined #openstack-kuryr | 14:44 | |
apuimedo | irenab: if you +2 I'll merge it | 14:44 |
irenab | apuimedo: I think I already did | 14:44 |
apuimedo | irenab: ivc_: 8-12utc works for me | 14:44 |
irenab | apuimedo: BCN time? | 14:45 |
apuimedo | utc! | 14:45 |
apuimedo | xD | 14:45 |
apuimedo | bcn is utc+1, you utc+2 | 14:45 |
ivc_ | and i'm utc+3 xD | 14:45 |
apuimedo | and ivc_ must be something like utc+4 | 14:45 |
apuimedo | so I was wrong | 14:45 |
apuimedo | :-) | 14:45 |
*** yamamoto has quit IRC | 14:45 | |
irenab | so moring hours, will send asap | 14:46 |
apuimedo | thanks irenab | 14:46 |
irenab | need to go now, see you tomorrow | 14:46 |
apuimedo | irenab: ivc_: I'll now add kubectl config for devstack | 14:46 |
*** garyloug has joined #openstack-kuryr | 14:46 | |
ivc_ | apuimedo, i think it works oob | 14:47 |
ivc_ | you mean ~/.kube, right? | 14:47 |
apuimedo | ivc_: yes | 14:48 |
ivc_ | well somehow it works now, i dont have ~/.kube | 14:48 |
ivc_ | and just did [alias kubectl='hyperkube kubectl'] | 14:49 |
apuimedo | ivc_: so maybe I'll do just that, put a kubectl that uses hyperkube in PATH | 14:50 |
ivc_ | kk | 14:50 |
openstackgerrit | Merged openstack/kuryr-kubernetes: devstack: move to k8s 1.4.6 https://review.openstack.org/401280 | 14:52 |
ivc_ | apuimedo, what about https://review.openstack.org/#/c/376044/ and https://review.openstack.org/#/c/401078/ ? | 14:53 |
apuimedo | ivc_: in! | 14:54 |
*** yamamoto has joined #openstack-kuryr | 14:54 | |
ivc_ | apuimedo, awesome! | 14:55 |
ivc_ | apuimedo, thnx :) | 14:55 |
apuimedo | thanks to you | 14:55 |
openstackgerrit | Merged openstack/kuryr-kubernetes: Controller side of pods' port/VIF binding https://review.openstack.org/376044 | 14:59 |
openstackgerrit | Merged openstack/kuryr-kubernetes: devstack: set neutron_defaults https://review.openstack.org/401078 | 15:00 |
*** oanson has joined #openstack-kuryr | 15:02 | |
*** garyloug has quit IRC | 15:05 | |
*** limao has joined #openstack-kuryr | 15:16 | |
*** dimak has quit IRC | 15:19 | |
*** diogogmt has quit IRC | 15:22 | |
*** hongbin has joined #openstack-kuryr | 15:22 | |
*** limao_ has joined #openstack-kuryr | 15:25 | |
*** limao has quit IRC | 15:28 | |
*** tonanhngo has joined #openstack-kuryr | 15:34 | |
*** tonanhngo has quit IRC | 15:36 | |
*** janki has quit IRC | 15:38 | |
*** limao_ has quit IRC | 15:40 | |
*** limao has joined #openstack-kuryr | 15:41 | |
*** tonanhngo has joined #openstack-kuryr | 15:54 | |
*** tonanhngo has quit IRC | 15:56 | |
*** alraddarla has joined #openstack-kuryr | 16:03 | |
*** tonanhngo has joined #openstack-kuryr | 16:03 | |
*** jgriffith_away is now known as jgriffith | 16:25 | |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes: devstack: add convenience kubectl executable https://review.openstack.org/401338 | 16:30 |
apuimedo | ivc_: https://review.openstack.org/#/c/401338/1 | 16:31 |
ivc_ | apuimedo, done | 16:35 |
apuimedo | thanks! | 16:35 |
apuimedo | ivc_: you are advocating for having devstack/kubectl and then just doing the install of the file, right? | 16:36 |
ivc_ | aye something like that | 16:36 |
ivc_ | well maybe devstack/bin/kubectl | 16:36 |
ivc_ | but i'll be ok with devstack/kubectl too :) | 16:37 |
apuimedo | ok | 16:42 |
*** yamamoto has quit IRC | 16:45 | |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes: devstack: add convenience kubectl executable https://review.openstack.org/401338 | 16:45 |
*** garyloug has joined #openstack-kuryr | 17:02 | |
*** garyloug has quit IRC | 17:02 | |
*** garyloug has joined #openstack-kuryr | 17:02 | |
*** diogogmt has joined #openstack-kuryr | 17:29 | |
*** lmdaly has quit IRC | 17:40 | |
*** yamamoto has joined #openstack-kuryr | 17:45 | |
*** yamamoto has quit IRC | 17:52 | |
*** garyloug has quit IRC | 17:57 | |
*** alraddarla has quit IRC | 18:05 | |
*** jgriffith is now known as jgriffith_away | 18:42 | |
*** jgriffith_away is now known as jgriffith | 19:14 | |
*** tonanhngo has quit IRC | 20:05 | |
*** dimak has joined #openstack-kuryr | 20:06 | |
*** oanson has quit IRC | 20:09 | |
*** tonanhngo has joined #openstack-kuryr | 22:06 | |
*** dimak has quit IRC | 22:06 | |
*** tonanhngo has quit IRC | 22:08 | |
*** tonanhngo has joined #openstack-kuryr | 22:13 | |
*** tonanhngo has quit IRC | 22:14 | |
*** limao has quit IRC | 22:36 | |
*** huikang has joined #openstack-kuryr | 22:42 | |
*** tonanhngo has joined #openstack-kuryr | 23:18 | |
*** tonanhngo has quit IRC | 23:20 | |
*** tonanhngo has joined #openstack-kuryr | 23:40 | |
*** tonanhngo has quit IRC | 23:40 | |
*** huikang has quit IRC | 23:40 | |
*** huikang has joined #openstack-kuryr | 23:41 | |
*** shashank_hegde has joined #openstack-kuryr | 23:45 | |
*** huikang has quit IRC | 23:46 | |
*** tonanhngo has joined #openstack-kuryr | 23:58 | |
*** tonanhngo has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!