*** salv-orlando has joined #openstack-kuryr | 00:14 | |
*** salv-orlando has quit IRC | 00:19 | |
openstackgerrit | Hongbin Lu proposed openstack/fuxi: [WIP] Add devstack plugin https://review.openstack.org/402244 | 00:27 |
---|---|---|
*** hongbin has quit IRC | 00:45 | |
*** salv-orlando has joined #openstack-kuryr | 01:16 | |
*** salv-orlando has quit IRC | 01:20 | |
*** limao has joined #openstack-kuryr | 02:01 | |
*** yedongcan has joined #openstack-kuryr | 02:07 | |
*** salv-orlando has joined #openstack-kuryr | 02:17 | |
openstackgerrit | Zhigang Li proposed openstack/kuryr-libnetwork: Replace six.iteritems() with .items() https://review.openstack.org/401056 | 02:17 |
*** salv-orlando has quit IRC | 02:21 | |
*** hongbin has joined #openstack-kuryr | 02:33 | |
*** yedongcan has quit IRC | 02:40 | |
*** yamamot__ has joined #openstack-kuryr | 03:09 | |
*** salv-orlando has joined #openstack-kuryr | 03:18 | |
*** salv-orlando has quit IRC | 03:22 | |
*** yedongcan has joined #openstack-kuryr | 04:16 | |
openstackgerrit | vikas choudhary proposed openstack/kuryr: Nested-Containers: vlan driver https://review.openstack.org/361993 | 04:19 |
*** yedongcan has quit IRC | 04:22 | |
*** hongbin has quit IRC | 04:37 | |
*** yedongcan has joined #openstack-kuryr | 04:50 | |
*** yamamot__ has quit IRC | 05:16 | |
*** limao has quit IRC | 05:33 | |
*** limao has joined #openstack-kuryr | 05:42 | |
*** janki has joined #openstack-kuryr | 05:49 | |
*** yedongcan has quit IRC | 05:58 | |
*** yedongcan has joined #openstack-kuryr | 05:58 | |
*** yamamot__ has joined #openstack-kuryr | 06:04 | |
yedongcan | janonymous: Hi | 06:07 |
*** salv-orlando has joined #openstack-kuryr | 06:19 | |
*** salv-orlando has quit IRC | 06:25 | |
*** janki has quit IRC | 06:30 | |
*** janki has joined #openstack-kuryr | 06:33 | |
*** salv-orlando has joined #openstack-kuryr | 06:43 | |
*** yedongcan1 has joined #openstack-kuryr | 07:07 | |
*** yedongcan has quit IRC | 07:07 | |
*** oanson has joined #openstack-kuryr | 07:08 | |
*** yedongcan1 has quit IRC | 07:16 | |
*** yedongcan has joined #openstack-kuryr | 07:23 | |
*** janki has quit IRC | 07:27 | |
*** oanson has quit IRC | 07:28 | |
*** janki has joined #openstack-kuryr | 07:47 | |
*** salv-orlando has quit IRC | 07:59 | |
*** janki has quit IRC | 08:23 | |
*** janki has joined #openstack-kuryr | 08:23 | |
*** tonanhngo has joined #openstack-kuryr | 08:46 | |
*** tonanhngo has quit IRC | 08:51 | |
ltomasbo | ping apuimedo | 08:53 |
*** lmdaly has joined #openstack-kuryr | 09:10 | |
*** yedongcan has quit IRC | 09:22 | |
*** limao has quit IRC | 09:31 | |
*** garyloug has joined #openstack-kuryr | 09:51 | |
*** garyloug has quit IRC | 10:04 | |
*** garyloug has joined #openstack-kuryr | 10:05 | |
*** janki has quit IRC | 10:06 | |
*** yamamot__ has quit IRC | 10:23 | |
*** janki has joined #openstack-kuryr | 10:24 | |
*** yedongcan has joined #openstack-kuryr | 10:36 | |
*** yedongcan has left #openstack-kuryr | 10:36 | |
*** yamamoto has joined #openstack-kuryr | 11:04 | |
*** yamamoto has quit IRC | 11:10 | |
*** yamamoto has joined #openstack-kuryr | 11:51 | |
*** janki has quit IRC | 11:53 | |
*** yamamoto has quit IRC | 12:01 | |
*** oanson has joined #openstack-kuryr | 12:09 | |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management https://review.openstack.org/402462 | 12:09 |
*** oanson has quit IRC | 12:13 | |
*** garyloug has quit IRC | 12:17 | |
*** lmdaly has quit IRC | 12:28 | |
*** oanson has joined #openstack-kuryr | 12:29 | |
*** yamamoto has joined #openstack-kuryr | 12:32 | |
openstackgerrit | vikas choudhary proposed openstack/kuryr: Nested-Containers: vlan driver https://review.openstack.org/361993 | 12:33 |
*** oanson has quit IRC | 12:33 | |
openstackgerrit | Flavio Percoco proposed openstack/kuryr-libnetwork: Show team and repo badges on README https://review.openstack.org/402537 | 13:00 |
openstackgerrit | Flavio Percoco proposed openstack/fuxi: Show team and repo badges on README https://review.openstack.org/402538 | 13:00 |
openstackgerrit | Flavio Percoco proposed openstack/kuryr: Show team and repo badges on README https://review.openstack.org/402539 | 13:01 |
openstackgerrit | Flavio Percoco proposed openstack/kuryr-kubernetes: Show team and repo badges on README https://review.openstack.org/402540 | 13:02 |
*** limao has joined #openstack-kuryr | 13:10 | |
*** salv-orlando has joined #openstack-kuryr | 13:19 | |
*** oanson has joined #openstack-kuryr | 13:20 | |
*** limao has quit IRC | 13:22 | |
*** limao has joined #openstack-kuryr | 13:22 | |
*** limao has quit IRC | 13:32 | |
*** limao has joined #openstack-kuryr | 13:33 | |
*** limao has quit IRC | 13:38 | |
*** limao has joined #openstack-kuryr | 13:40 | |
*** limao has quit IRC | 13:45 | |
*** apuimedo has quit IRC | 13:53 | |
*** limao has joined #openstack-kuryr | 14:03 | |
*** garyloug has joined #openstack-kuryr | 14:12 | |
*** apuimedo has joined #openstack-kuryr | 14:18 | |
apuimedo | ltomasbo: pong | 14:22 |
apuimedo | that's a big latency :( | 14:22 |
ltomasbo | :D | 14:23 |
*** lmdaly has joined #openstack-kuryr | 14:24 | |
ltomasbo | was wondering how to device if trunk ports where to be used for the vlan case, but I already proposed a patch for vlan and trunk ports | 14:24 |
ltomasbo | if you want to take a look | 14:24 |
ltomasbo | (relies on vikasc patch ofc) | 14:25 |
apuimedo | s/device/decide/ ? | 14:26 |
apuimedo | ltomasbo: ^^ | 14:26 |
ltomasbo | yep | 14:26 |
apuimedo | also, can you review https://review.openstack.org/#/c/361993/ ? | 14:26 |
apuimedo | your code is the consumer, so your +1 here means a lot | 14:26 |
ltomasbo | I assumed that if the vlan driver is to be used, then a subport will be used | 14:27 |
apuimedo | ltomasbo: I think you can assume that for now | 14:27 |
apuimedo | then we'll move to lmdaly's approach | 14:27 |
apuimedo | ;-) | 14:27 |
ltomasbo | yep, I've been using, testing and reviewning it | 14:27 |
ltomasbo | it works, but there is two 'unsolved' issues with it | 14:27 |
apuimedo | ltomasbo: which? | 14:28 |
ltomasbo | 1.- it leaves the t_cxxxxx device inside the VM when removing the container | 14:28 |
ltomasbo | apuimedo: https://review.openstack.org/#/c/361993/ | 14:28 |
ltomasbo | not a big issue, but once the complete list of vlans is assigned, and it starts again from the mix_value (1-4094), it will start failing | 14:29 |
apuimedo | ltomasbo: I thought vikasc commented that he couldn't reproduce the leftover vlan device | 14:29 |
ltomasbo | it happens to me all the time | 14:29 |
ltomasbo | the 2nd on is that segmentation_type_drivers/__init__.py does not get the info from kuryr.conf | 14:30 |
ltomasbo | so, it always takes the driver as default (veth) | 14:30 |
ltomasbo | I needed to manually change the default to vlan | 14:31 |
ltomasbo | other than that, it works! | 14:31 |
ltomasbo | vikasc, apuimedo: I think the leftover could be an unrelated thing | 14:31 |
apuimedo | ltomasbo: did you find out what it could be? | 14:31 |
ltomasbo | so happy to merge it without that being fix | 14:31 |
ltomasbo | but the config file should be read it | 14:32 |
ltomasbo | not yet, my guess is that the config.py file is in /lib/binding | 14:32 |
ltomasbo | while it is being read from /lib/segmentation_type_drivers/ | 14:32 |
ltomasbo | but need to dig a bit more | 14:33 |
apuimedo | ok | 14:33 |
ltomasbo | but the rest should be ok, when that is fix, I'll give the +1 | 14:34 |
ltomasbo | btw, I've tried both patches together, with container in different and in the same subnet | 14:35 |
ltomasbo | and it works smoothly | 14:35 |
apuimedo | ltomasbo: I think the segmentation type config should be read and chosen by the calling code in kuryr-libnetwork | 14:35 |
apuimedo | *config reading | 14:36 |
ltomasbo | ok, should that be changed then in vikasc patch? right now it is loaded at __init__.py | 14:37 |
apuimedo | let me check | 14:38 |
vikasc | apuimedo, i thnk thik can be avoided | 14:39 |
vikasc | apuimedo, because with vlan driver segmentation type will always be vlan | 14:39 |
vikasc | apuimedo, and vxlan driver it will be vxlan | 14:39 |
apuimedo | sure | 14:39 |
apuimedo | no question about that | 14:39 |
vikasc | apuimedo, plus vxlan is not supported in trunk port support yet | 14:39 |
vikasc | apuimedo, so y to add extra knobs to confuse user :) | 14:40 |
apuimedo | you either have the driver be picked by the binding type | 14:40 |
apuimedo | or by the calling code | 14:40 |
apuimedo | but now it is hardcoded in __init__ | 14:40 |
apuimedo | which is a bit sketchy | 14:40 |
vikasc | segmentation type is being picked using binding driver... what is hardcoded? | 14:42 |
apuimedo | when you do | 14:43 |
apuimedo | from kuryr.lib import segmentation_type_drivers | 14:43 |
apuimedo | it preloads segmentation_type_drivers.driver to be the vlan one | 14:43 |
vikasc | ltomasbo, i dont think think config problem is related to this patch, if use see link_iface, it is not reading this variable also from kuryr.conf. still debugging | 14:43 |
apuimedo | ah no | 14:43 |
apuimedo | I'm a dumbass | 14:43 |
apuimedo | it doesn't | 14:43 |
apuimedo | nvmnd | 14:43 |
vikasc | thanks :) | 14:44 |
apuimedo | vikasc: +2 your own patch | 14:44 |
vikasc | yahooo | 14:44 |
vikasc | finally | 14:44 |
apuimedo | and with ltomasbo +1 I feel confident enough to +2 and merge myself | 14:44 |
apuimedo | ltomasbo: so please, +1 | 14:44 |
apuimedo | but I want bug reports for the leftover devices! | 14:45 |
vikasc | plus we have config file problem | 14:45 |
vikasc | thats another issue | 14:45 |
vikasc | i am working on it | 14:45 |
apuimedo | vikasc: bug report for that too! | 14:45 |
vikasc | sure.. | 14:45 |
ltomasbo | but it is not the config file an issue of including segmentation_types? | 14:46 |
ltomasbo | right now, if the vlan wants to be used, with the current patch | 14:46 |
ltomasbo | you need to included into kuryr.conf, but also to go to the config.py file and modify the default option to vlan | 14:46 |
*** salv-orlando has quit IRC | 14:47 | |
*** salv-orlando has joined #openstack-kuryr | 14:47 | |
apuimedo | ltomasbo: vikasc: can it be because when segmentation_driver is imported is before config has been read? | 14:48 |
apuimedo | so the 17, 18 lines read the default value instead of the current value? | 14:48 |
vikasc | https://bugs.launchpad.net/kuryr/+bug/1644855 | 14:48 |
openstack | Launchpad bug 1644855 in kuryr "COE's not able to read 'binding' section variables from kuryr.conf eg, link_iface and driver" [Undecided,In progress] - Assigned to vikas choudhary (choudharyvikas16) | 14:48 |
ltomasbo | that could be a good reason | 14:48 |
vikasc | i faced issue with link_iface as well | 14:50 |
vikasc | apuimedo, nope, thats does not seem to be the reason, just tested importing segmentation at last | 14:51 |
vikasc | now ticket is on my name.. will get back soon on this | 14:52 |
*** vikasc is now known as vikas|afk | 14:52 | |
*** limao has quit IRC | 15:00 | |
*** limao has joined #openstack-kuryr | 15:01 | |
*** limao has quit IRC | 15:05 | |
*** openstackgerrit has quit IRC | 15:18 | |
*** openstackgerrit has joined #openstack-kuryr | 15:18 | |
*** hongbin has joined #openstack-kuryr | 15:24 | |
*** salv-orlando has quit IRC | 15:33 | |
apuimedo | vikas|afk: ltomasbo: http://paste.openstack.org/show/590480/ | 15:39 |
ltomasbo | but that is a different error, right? | 15:42 |
ltomasbo | or what was the test there? | 15:43 |
apuimedo | ltomasbo: I was trying to just import the module in a clean virtualenv | 15:47 |
apuimedo | I'm not sure I like that the module can't be imported unless you have the config | 15:47 |
*** ajo has quit IRC | 15:52 | |
ltomasbo | yep | 15:54 |
ltomasbo | should that have a default or something? | 15:54 |
ltomasbo | in case the config is not there? | 15:54 |
ltomasbo | I'm also concern about the fact that is supposed to read from the config file, but it is not, that could lead to some difficult to find errors in the future | 15:55 |
apuimedo | prolly | 15:56 |
*** ajo has joined #openstack-kuryr | 16:00 | |
*** limao has joined #openstack-kuryr | 16:13 | |
*** limao has quit IRC | 16:13 | |
*** limao has joined #openstack-kuryr | 16:14 | |
*** limao has quit IRC | 16:18 | |
*** salv-orlando has joined #openstack-kuryr | 17:13 | |
*** yamamoto has quit IRC | 17:21 | |
*** garyloug has quit IRC | 17:30 | |
*** neiljerram has quit IRC | 17:45 | |
*** lmdaly has quit IRC | 17:45 | |
*** yamamoto has joined #openstack-kuryr | 18:22 | |
*** yamamoto has quit IRC | 18:27 | |
*** salv-orl_ has joined #openstack-kuryr | 18:30 | |
*** salv-orlando has quit IRC | 18:32 | |
*** salv-orl_ has quit IRC | 19:05 | |
*** tonanhngo has joined #openstack-kuryr | 19:58 | |
*** tonanhngo has quit IRC | 20:01 | |
*** tonanhngo has joined #openstack-kuryr | 20:30 | |
*** tonanhngo has quit IRC | 20:32 | |
openstackgerrit | Hongbin Lu proposed openstack/fuxi: [WIP] Add devstack plugin https://review.openstack.org/402244 | 20:33 |
*** salv-orlando has joined #openstack-kuryr | 20:36 | |
*** salv-orlando has quit IRC | 20:40 | |
*** salv-orlando has joined #openstack-kuryr | 21:01 | |
*** oanson has quit IRC | 21:45 | |
*** limao has joined #openstack-kuryr | 22:15 | |
openstackgerrit | Hongbin Lu proposed openstack/fuxi: Add devstack plugin for Fuxi https://review.openstack.org/402244 | 22:17 |
*** limao has quit IRC | 22:20 | |
*** limao has joined #openstack-kuryr | 22:48 | |
*** limao has quit IRC | 22:52 | |
*** salv-orlando has quit IRC | 23:05 | |
*** limao has joined #openstack-kuryr | 23:14 | |
*** limao has quit IRC | 23:21 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!