*** limao has joined #openstack-kuryr | 00:46 | |
*** saneax is now known as saneax-_-|AFK | 00:58 | |
*** yamamoto has joined #openstack-kuryr | 01:45 | |
*** yamamoto has quit IRC | 01:53 | |
*** tonanhngo has quit IRC | 01:57 | |
*** tonanhngo has joined #openstack-kuryr | 02:01 | |
*** tonanhngo has quit IRC | 02:05 | |
*** tonanhngo has joined #openstack-kuryr | 02:17 | |
*** tonanhngo has quit IRC | 02:21 | |
*** yamamoto has joined #openstack-kuryr | 02:54 | |
*** yamamoto has quit IRC | 03:05 | |
*** s1061123 has quit IRC | 03:15 | |
*** s1061123 has joined #openstack-kuryr | 03:33 | |
*** diogogmt has quit IRC | 03:54 | |
*** limao has quit IRC | 03:57 | |
*** limao has joined #openstack-kuryr | 03:57 | |
*** limao has quit IRC | 04:01 | |
*** diogogmt has joined #openstack-kuryr | 04:40 | |
*** hongbin has quit IRC | 04:44 | |
*** diogogmt has quit IRC | 05:39 | |
*** yedongcan has joined #openstack-kuryr | 05:44 | |
*** saneax-_-|AFK is now known as saneax | 05:44 | |
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Delete kuryr-subnet in existing Neutron network https://review.openstack.org/411144 | 06:00 |
---|---|---|
*** limao has joined #openstack-kuryr | 06:04 | |
*** janki has joined #openstack-kuryr | 06:54 | |
*** pcaruana has joined #openstack-kuryr | 07:56 | |
*** yedongcan1 has joined #openstack-kuryr | 08:03 | |
*** yedongcan has quit IRC | 08:06 | |
*** garyloug has joined #openstack-kuryr | 08:59 | |
*** neiljerram has joined #openstack-kuryr | 09:24 | |
*** yedongcan has joined #openstack-kuryr | 09:30 | |
*** yedongcan1 has quit IRC | 09:31 | |
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Delete kuryr-subnet in existing Neutron network https://review.openstack.org/411144 | 09:32 |
mchiappero | apuimedo: I should be available in the afternoon and close the unit tests | 10:14 |
apuimedo | mchiappero: looking forward to that | 10:14 |
apuimedo | I want to merge it today :-) | 10:14 |
apuimedo | I reviewed it all yesterday | 10:14 |
mchiappero | I would like to, I've been busy... | 10:15 |
mchiappero | I had a few questions, if you can please address them I'll do my best to close them ASAP later today | 10:15 |
*** openstackgerrit has quit IRC | 10:18 | |
apuimedo | ok | 10:21 |
apuimedo | I didn't see them earlier | 10:21 |
apuimedo | mchiappero: where are they posted? | 10:22 |
apuimedo | can't see them | 10:22 |
*** yamamoto has joined #openstack-kuryr | 10:22 | |
*** limao has quit IRC | 10:29 | |
*** yedongcan has left #openstack-kuryr | 10:29 | |
mchiappero | at a glance, my own reply to patchset 25 and 26 | 10:39 |
mchiappero | there might be more | 10:39 |
mchiappero | but those should be it | 10:39 |
*** yamamoto has quit IRC | 11:03 | |
apuimedo | ok | 11:09 |
*** neiljerram has quit IRC | 11:19 | |
*** roeyc has joined #openstack-kuryr | 11:25 | |
*** garyloug_ has joined #openstack-kuryr | 11:31 | |
*** garyloug has quit IRC | 11:33 | |
*** roeyc has quit IRC | 11:35 | |
apuimedo | mchiappero: I answered all the comments I found | 11:43 |
*** garyloug has joined #openstack-kuryr | 11:47 | |
*** garyloug_ has quit IRC | 11:50 | |
*** openstackgerrit has joined #openstack-kuryr | 11:54 | |
openstackgerrit | Merged openstack/kuryr-kubernetes: Trival: Remove 'MANIFEST.in' https://review.openstack.org/369154 | 11:54 |
apuimedo | vikasc: https://review.openstack.org/411144 | 11:58 |
*** yamamoto has joined #openstack-kuryr | 12:03 | |
vikasc | apuimedo, sure | 12:05 |
apuimedo | thanks | 12:06 |
mchiappero | apuimedo: thank you :) | 12:10 |
mchiappero | I'm still new to mock and all of this | 12:10 |
*** yamamoto has quit IRC | 12:13 | |
apuimedo | ;-) | 12:13 |
apuimedo | no worries | 12:13 |
* apuimedo going for lunch | 12:13 | |
apuimedo | ttyl | 12:13 |
*** janonymous has quit IRC | 12:54 | |
*** dougbtv_ has joined #openstack-kuryr | 13:25 | |
*** janonymous has joined #openstack-kuryr | 13:35 | |
*** garyloug has quit IRC | 13:40 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-kubernetes: Updated from global requirements https://review.openstack.org/409797 | 13:40 |
*** lezbar__ has joined #openstack-kuryr | 14:12 | |
*** lezbar has quit IRC | 14:13 | |
openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Delete kuryr-subnet in existing Neutron network https://review.openstack.org/411144 | 14:29 |
ivc_ | mchiappero if you need any help with mock, i'd be happy to help :) | 14:32 |
ivc_ | vikasc i've added some comments for https://review.openstack.org/#/c/410578 | 14:52 |
ivc_ | vikasc no '-1' since it's WIP | 14:52 |
mchiappero | ivc_: thanks, I'll let you know :) (still busy at the moment) | 15:03 |
*** hongbin has joined #openstack-kuryr | 15:03 | |
*** jgriffith is now known as jgriffith_AutoAw | 15:22 | |
*** jgriffith_AutoAw is now known as jgriffith | 15:22 | |
*** garyloug has joined #openstack-kuryr | 15:36 | |
*** tonanhngo has joined #openstack-kuryr | 15:48 | |
*** tonanhngo has quit IRC | 15:48 | |
*** tonanhngo has joined #openstack-kuryr | 15:49 | |
*** janki has quit IRC | 15:58 | |
*** saneax is now known as saneax-_-|AFK | 16:07 | |
*** garyloug_ has joined #openstack-kuryr | 16:15 | |
*** garyloug has quit IRC | 16:15 | |
*** pcaruana has quit IRC | 16:25 | |
mchiappero | apuimedo: regarding https://review.openstack.org/#/c/400365/26..27/kuryr_libnetwork/tests/unit/port_driver/drivers/test_nested.py | 16:49 |
mchiappero | the comment was about the following line, the network there is not actually being used | 16:50 |
mchiappero | what's the best thing to do there? | 16:51 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management https://review.openstack.org/402462 | 16:54 |
mchiappero | also, here: https://review.openstack.org/#/c/400365/26/kuryr_libnetwork/tests/unit/base.py@49 | 16:58 |
mchiappero | you mean a unittest.mock driver, not an empty (and later patched) one | 16:59 |
mchiappero | right? | 16:59 |
*** jgriffith is now known as jgriffith_AutoAw | 17:13 | |
*** jgriffith_AutoAw is now known as jgriffith | 17:14 | |
mchiappero | apuimedo: I won't be here for long, but I'll definitely check the log tomorrow so reply here if you want | 18:04 |
*** garyloug_ has quit IRC | 18:30 | |
*** jgriffith is now known as jgriffith_AutoAw | 18:33 | |
*** tonanhngo has quit IRC | 18:50 | |
*** jgriffith_AutoAw is now known as jgriffith | 18:55 | |
mchiappero | apuimedo: I still need to finish some tests, especially a few failures for driver.py, I'll push tomorrow | 19:26 |
*** janki has joined #openstack-kuryr | 19:44 | |
*** janki has quit IRC | 19:45 | |
*** jgriffith is now known as jgriffith_AutoAw | 20:20 | |
*** jgriffith_AutoAw is now known as jgriffith | 20:23 | |
*** tonanhngo has joined #openstack-kuryr | 20:51 | |
*** tonanhngo has quit IRC | 20:52 | |
*** dougbtv_ has quit IRC | 21:32 | |
*** jgriffith is now known as jgriffith_AutoAw | 22:11 | |
*** jgriffith_AutoAw is now known as jgriffith | 22:12 | |
*** roeyc has joined #openstack-kuryr | 22:36 | |
*** jgriffith is now known as jgriffith_AutoAw | 22:38 | |
*** hongbin has quit IRC | 23:02 | |
*** saneax-_-|AFK is now known as saneax | 23:12 | |
*** jgriffith_AutoAw is now known as jgriffith | 23:31 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!