| *** huikang has joined #openstack-kuryr | 00:06 | |
| *** huikang has quit IRC | 00:07 | |
| *** hongbin has quit IRC | 00:41 | |
| *** yamamot__ has joined #openstack-kuryr | 01:39 | |
| *** pmannidi_ has joined #openstack-kuryr | 01:56 | |
| *** pmannidi has quit IRC | 01:57 | |
| *** neiljerram has quit IRC | 02:00 | |
| *** saneax is now known as saneax-_-|AFK | 02:52 | |
| *** hongbin has joined #openstack-kuryr | 02:53 | |
| openstackgerrit | xhzhf proposed openstack/kuryr: E128 ignore statement make code unclearly https://review.openstack.org/412715 | 02:59 |
|---|---|---|
| *** yedongcan has joined #openstack-kuryr | 03:01 | |
| *** diga has joined #openstack-kuryr | 03:15 | |
| *** yedongcan has quit IRC | 04:12 | |
| *** yedongcan has joined #openstack-kuryr | 04:12 | |
| *** hongbin has quit IRC | 04:33 | |
| *** limao has joined #openstack-kuryr | 04:58 | |
| *** limao has quit IRC | 04:58 | |
| *** limao has joined #openstack-kuryr | 04:58 | |
| *** saneax-_-|AFK is now known as saneax | 05:31 | |
| yedongcan | limao: ping | 05:38 |
| limao | hi yedongcan | 05:38 |
| yedongcan | limao: hello, would you mind us work together with the bug: https://bugs.launchpad.net/kuryr-libnetwork/+bug/1651015 | 05:39 |
| openstack | Launchpad bug 1651015 in kuryr-libnetwork "kuryr-libnetwork did not clean neutron port when use existed neutron network" [Critical,Confirmed] | 05:39 |
| limao | Sure, | 05:39 |
| limao | the thing in my mind, I think when release address, we can check if the subnet is created by kuryr | 05:40 |
| yedongcan | limao: this morning I update a patch for this, it's a workaround, I will send it to gerrit. | 05:40 |
| limao | if it is, then check subnetpool | 05:40 |
| limao | oh, cool, I'm also testing it with the driver code | 05:41 |
| limao | How are you going to fix? | 05:41 |
| yedongcan | In my patch , I just check the network tags, and then delete the port, if the port doesn't belong the subnet , it will raise exception, here we need pass. | 05:42 |
| limao | yedongcan: so you will not check subnetpool id? | 05:43 |
| yedongcan | what's your think about check subnet? | 05:43 |
| limao | yedongcan: https://review.openstack.org/#/c/411144/ | 05:44 |
| limao | yedongcan: With this patch, if the subnet is created by Kuryr, the name will start with kuryr-subnet- | 05:45 |
| yedongcan | yes, I check the subnetpool id is None or equal with the passing poolid if we get the tags. | 05:45 |
| limao | yedongcan: Do you mean when release address, you will check neutron tag when the subnetpool id is None | 05:47 |
| yedongcan | almost, get the subnet's network first, and then check neutron tag, at last check the subnetpool | 05:48 |
| yedongcan | I think check subnet is anther way, but when we had more than one subnets with same cidr, how do we process? | 05:50 |
| yedongcan | s/anther/another | 05:51 |
| limao | yedongcan: I think we should avoid too much neutron call, so check neutron tag may move to last | 05:52 |
| limao | yedongcan: "had more than one subnets with same cidr" Is this should can be seperated by check subnetpool id? | 05:54 |
| yedongcan | limao: agree with you, but it seems we can't have another things to determine the unique subnet. | 05:55 |
| yedongcan | limao: those subnets will have none subnetpool_id | 05:55 |
| limao | yedongcan: if subnet-name start with kuryr-subnet-; then check subnetpool_id; else : check neutron tag | 05:56 |
| limao | yedongcan: Is this OK? | 05:57 |
| yedongcan | umm, I will have a look. | 05:58 |
| limao | yedongcan : https://github.com/openstack/kuryr-libnetwork/blob/master/kuryr_libnetwork/controllers.py | 05:59 |
| limao | yedongcan: 1467 - 1470 | 05:59 |
| limao | I was thought we can change the logic there | 05:59 |
| yedongcan | umm, yes, how about push my origin patch to gerrit? | 06:00 |
| limao | yedongcan: sure | 06:04 |
| limao | yedongcan: we can start from there~ | 06:04 |
| *** janki has joined #openstack-kuryr | 06:08 | |
| *** dimak has joined #openstack-kuryr | 06:24 | |
| *** jchhatbar has joined #openstack-kuryr | 06:27 | |
| *** janki has quit IRC | 06:29 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Delete port in existing neutron network https://review.openstack.org/412772 | 06:32 |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: [WIP] Delete port in existing neutron network https://review.openstack.org/412772 | 06:36 |
| *** yedongcan has left #openstack-kuryr | 06:43 | |
| *** limao has quit IRC | 07:04 | |
| *** limao has joined #openstack-kuryr | 07:04 | |
| *** tonanhngo has quit IRC | 07:32 | |
| *** diga has quit IRC | 07:34 | |
| *** yedongcan has joined #openstack-kuryr | 07:46 | |
| *** irenab has quit IRC | 07:59 | |
| *** tonanhngo has joined #openstack-kuryr | 08:02 | |
| *** tonanhngo has quit IRC | 08:03 | |
| *** yamamot__ has quit IRC | 08:12 | |
| *** pcaruana has joined #openstack-kuryr | 08:19 | |
| *** jchhatbar is now known as janki | 08:27 | |
| *** yamamoto has joined #openstack-kuryr | 08:43 | |
| *** roeyc has joined #openstack-kuryr | 08:46 | |
| *** yamamoto has quit IRC | 08:47 | |
| *** roeyc1 has joined #openstack-kuryr | 08:48 | |
| *** roeyc has quit IRC | 08:50 | |
| *** yamamoto has joined #openstack-kuryr | 08:58 | |
| limao | ping yedongcan | 09:21 |
| *** oanson has quit IRC | 09:33 | |
| mchiappero | any mock expert here? | 09:36 |
| mchiappero | I need help :( | 09:36 |
| mchiappero | ivc_, alraddarla_ ping me if you have time, thank you | 09:37 |
| *** garyloug has joined #openstack-kuryr | 09:45 | |
| *** yamamoto has quit IRC | 10:02 | |
| *** limao has quit IRC | 10:12 | |
| *** irenab has joined #openstack-kuryr | 10:15 | |
| *** irenab_ has joined #openstack-kuryr | 10:17 | |
| *** yamamoto has joined #openstack-kuryr | 10:59 | |
| *** yedongcan has quit IRC | 11:08 | |
| *** yamamoto has quit IRC | 11:08 | |
| *** yedongcan has joined #openstack-kuryr | 11:08 | |
| *** neiljerram has joined #openstack-kuryr | 11:20 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Delete port created by kuryr https://review.openstack.org/412772 | 11:29 |
| *** tonanhngo has joined #openstack-kuryr | 12:04 | |
| *** tonanhngo has quit IRC | 12:06 | |
| *** yamamoto has joined #openstack-kuryr | 12:09 | |
| *** vikasc has quit IRC | 12:18 | |
| *** yamamoto has quit IRC | 12:18 | |
| *** irenab__ has joined #openstack-kuryr | 12:21 | |
| *** irenab_ has quit IRC | 12:24 | |
| *** saneax is now known as saneax-_-|AFK | 12:24 | |
| *** yamamoto has joined #openstack-kuryr | 12:28 | |
| *** vikasc has joined #openstack-kuryr | 12:34 | |
| *** vikasc has quit IRC | 12:46 | |
| *** pcaruana has quit IRC | 13:01 | |
| *** garyloug has quit IRC | 13:04 | |
| *** vikasc has joined #openstack-kuryr | 13:04 | |
| mchiappero | :( | 13:05 |
| mchiappero | everyone on holiday :) lucky you... | 13:06 |
| *** pcaruana has joined #openstack-kuryr | 13:06 | |
| *** jchhatbar has joined #openstack-kuryr | 13:10 | |
| *** janki has quit IRC | 13:13 | |
| *** yedongcan has left #openstack-kuryr | 13:20 | |
| ivc_ | mchiappero ping :) | 13:21 |
| *** saneax-_-|AFK is now known as saneax | 13:22 | |
| *** limao has joined #openstack-kuryr | 13:23 | |
| *** gsagie has joined #openstack-kuryr | 13:25 | |
| *** limao_ has joined #openstack-kuryr | 13:27 | |
| *** limao has quit IRC | 13:28 | |
| mchiappero | ivc_: are you busy? May I annoy you with my mock problems? | 13:32 |
| *** saneax is now known as saneax-_-|AFK | 13:34 | |
| ivc_ | mchiappero sure | 13:36 |
| mchiappero | so, the problem is that I need to mock a config option | 13:36 |
| mchiappero | I tried patching already without success | 13:36 |
| mchiappero | https://review.openstack.org/#/c/400365/29/kuryr_libnetwork/tests/unit/port_driver/test_driver.py | 13:36 |
| mchiappero | L47 and L73 | 13:37 |
| mchiappero | what's the best approache there in your opinion? | 13:37 |
| ivc_ | https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/test_clients.py#L24 | 13:38 |
| mchiappero | I think I tried that already but let me try again | 13:38 |
| mchiappero | in some cases I do need the actuall string | 13:39 |
| mchiappero | would use a string in palce of the dummy object work? | 13:39 |
| ivc_ | mchiappero why do you need a string? | 13:40 |
| mchiappero | because a function parses it | 13:40 |
| mchiappero | parses the config value, I need to check it parses it correctly | 13:40 |
| ivc_ | well in 'mock' world you could do it differently | 13:42 |
| ivc_ | right now its like a 'black-box' test | 13:42 |
| ivc_ | driver._parse_port_driver_config right? | 13:43 |
| mchiappero | y | 13:43 |
| *** limao_ has quit IRC | 13:44 | |
| *** limao has joined #openstack-kuryr | 13:44 | |
| ivc_ | looking at it. note that it also use oslo_config.cfg.CONF instead of libnetwork.config.CONF, so it is 'oslo_config' that need to be patched | 13:45 |
| mchiappero | I can change that, but it seems that most of the code uses oslo_config | 13:46 |
| ivc_ | doesn't matter, i mean you just need to use the same module in test | 13:46 |
| ivc_ | ok. i think your 'black-box' with string approach should be fine here. you could also do the same with full mocks but that would be more complicated | 13:49 |
| ivc_ | for your case you could mock your CONF and use m_cfg.__getattribute__.return_value = 'config.value.to.test' | 13:50 |
| mchiappero | ok, cool | 13:50 |
| ivc_ | __getattr__ instead of __getattribute__ | 13:50 |
| mchiappero | thank you so much | 13:50 |
| ivc_ | note that it will return the same value for any of CONF.one_thing CONF.another | 13:51 |
| ivc_ | but in your case you only access one attribute and you could also verify it with m_cfg.__getattr__.assert_called_once_with('port_driver') | 13:52 |
| mchiappero | yes, in those tests it's the only value a need | 13:52 |
| *** irenab__ has quit IRC | 13:53 | |
| ivc_ | mchiappero wait, i think, __getattr__ is not supported by mock: https://docs.python.org/3/library/unittest.mock.html#mocking-magic-methods | 13:54 |
| ivc_ | xD | 13:54 |
| mchiappero | otherwise I can assign a function, right? | 13:54 |
| mchiappero | oh ok :( | 13:54 |
| ivc_ | https://github.com/openstack/oslo.config/blob/master/oslo_config/fixture.py | 13:54 |
| ivc_ | i think this is the way to do things with oslo_config :) | 13:55 |
| ivc_ | but m_cfg.port_driver='port_driver.string' would also work as in https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/test_clients.py#L24 | 13:57 |
| mchiappero | sorry, I had to leave for a while | 14:03 |
| mchiappero | I'll have a look now and let you know :) | 14:03 |
| *** limao has quit IRC | 14:05 | |
| *** limao has joined #openstack-kuryr | 14:05 | |
| * apuimedo is back | 14:16 | |
| *** gsagie has quit IRC | 14:22 | |
| *** pcaruana has quit IRC | 14:23 | |
| *** salv-orlando has joined #openstack-kuryr | 14:24 | |
| *** limao has quit IRC | 14:26 | |
| *** limao has joined #openstack-kuryr | 14:27 | |
| apuimedo | ivc_: vikasc: irenab: http://blog.kubernetes.io/2016/12/container-runtime-interface-cri-in-kubernetes.html | 14:35 |
| *** pcaruana has joined #openstack-kuryr | 14:37 | |
| apuimedo | "Networking: The CRI runtime handles network plugins and the setup/teardown of the pod sandbox." | 14:45 |
| apuimedo | we'll have to check if this changes things up | 14:45 |
| *** limao has quit IRC | 14:47 | |
| *** limao has joined #openstack-kuryr | 14:48 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: Driver based model for kuryr-libnetwork https://review.openstack.org/400365 | 14:52 |
| irenab | apuimedo: ack | 14:52 |
| mchiappero | ivc_: thank you, I've fixed the tests :) | 14:53 |
| ivc_ | mchiappero cool | 14:53 |
| *** lmdaly has joined #openstack-kuryr | 14:55 | |
| apuimedo | hurrah! | 14:56 |
| apuimedo | let's get this in and rebase the mock patch then | 14:57 |
| *** garyloug has joined #openstack-kuryr | 14:59 | |
| *** tonanhngo has joined #openstack-kuryr | 15:02 | |
| mchiappero | Christmas gift :P | 15:03 |
| mchiappero | let's wait for the CI but should be okay now | 15:03 |
| apuimedo | ure | 15:04 |
| apuimedo | *sure | 15:04 |
| *** tonanhngo has quit IRC | 15:04 | |
| irenab | mchiappero: apuimedo : what are the plans for fuctional/fullstack tests? | 15:05 |
| mchiappero | irenab: in another life :P | 15:05 |
| mchiappero | I haven't started thinking about it | 15:05 |
| mchiappero | (yet) | 15:05 |
| irenab | mchiappero: Do you mean in the new year :-)? | 15:05 |
| mchiappero | definitely not now | 15:06 |
| irenab | mchiappero: it is not necessarily to be submitted now, but I think we shoudl manage the gap somehow | 15:08 |
| apuimedo | well, Spaniards have a saying, "New year, New life" | 15:08 |
| irenab | :-) | 15:08 |
| apuimedo | so that translates mchiappero's 'another life' to likely mean next year | 15:08 |
| apuimedo | xD | 15:08 |
| mchiappero | pretty much :P | 15:08 |
| apuimedo | it's a top prioirty | 15:08 |
| apuimedo | *priority, of course | 15:09 |
| *** limao has quit IRC | 15:09 | |
| mchiappero | currently time is an extremely scarse resource for me :( | 15:09 |
| *** limao has joined #openstack-kuryr | 15:09 | |
| apuimedo | http://thedaoofdragonball.com/wp-content/uploads/2013/09/room-of-spirit-time-front.jpg | 15:11 |
| apuimedo | mchiappero: ^^ may help | 15:11 |
| mchiappero | sometimes I try not to sleep without success :P | 15:12 |
| *** oanson has joined #openstack-kuryr | 15:16 | |
| *** garyloug has quit IRC | 15:16 | |
| alraddarla_ | mchiappero, looks like CI is passing and will be merged. i will try to rebase by EOW apuimedo | 15:25 |
| apuimedo | yippey! | 15:28 |
| *** dimak has quit IRC | 15:31 | |
| *** limao has quit IRC | 15:33 | |
| *** limao has joined #openstack-kuryr | 15:34 | |
| *** neiljerram has quit IRC | 15:35 | |
| mchiappero | looks ok | 15:42 |
| mchiappero | i guess you can now workflow++ | 15:43 |
| *** limao_ has joined #openstack-kuryr | 15:51 | |
| *** limao has quit IRC | 15:55 | |
| *** jchhatbar has quit IRC | 15:58 | |
| apuimedo | mchiappero: I did | 15:58 |
| apuimedo | :-) | 15:58 |
| *** hongbin has joined #openstack-kuryr | 16:01 | |
| mchiappero | apuimedo: thank you! | 16:11 |
| *** limao_ has quit IRC | 16:15 | |
| *** limao has joined #openstack-kuryr | 16:16 | |
| *** diga has joined #openstack-kuryr | 16:16 | |
| mchiappero | alraddarla_: let me know if there is something you are not clear with in the new test_kuryr.py | 16:19 |
| alraddarla_ | mchiappero, okay sounds good. thanks | 16:20 |
| mchiappero | welcome | 16:22 |
| *** roeyc1 has quit IRC | 16:24 | |
| *** limao has quit IRC | 16:32 | |
| *** limao has joined #openstack-kuryr | 16:33 | |
| *** limao has quit IRC | 16:35 | |
| apuimedo | https://review.openstack.org/#/c/400365/ | 16:44 |
| apuimedo | It is merged! | 16:44 |
| mchiappero | champagne for everyone! | 16:49 |
| apuimedo | I took 'fuet' instead | 16:52 |
| apuimedo | :-) | 16:52 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management https://review.openstack.org/402462 | 16:59 |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Delete kuryr-subnet in existing Neutron network https://review.openstack.org/411144 | 17:09 |
| openstackgerrit | Merged openstack/fuxi: Separate unit tests from fullstack tests https://review.openstack.org/403931 | 17:11 |
| openstackgerrit | Merged openstack/fuxi: Add basic fullstack volume tests https://review.openstack.org/403941 | 17:11 |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Fix misleading info in CreateNetwork https://review.openstack.org/411115 | 17:12 |
| *** garyloug has joined #openstack-kuryr | 17:13 | |
| mchiappero | lots of new code today :) | 17:16 |
| *** neiljerram has joined #openstack-kuryr | 17:21 | |
| *** lmdaly has quit IRC | 17:35 | |
| *** neiljerram has quit IRC | 17:44 | |
| *** neiljerram has joined #openstack-kuryr | 17:57 | |
| *** pcaruana has quit IRC | 17:59 | |
| *** yamamoto has quit IRC | 17:59 | |
| *** yamamoto has joined #openstack-kuryr | 18:03 | |
| *** yamamoto has quit IRC | 18:07 | |
| *** salv-orlando has quit IRC | 18:12 | |
| *** garyloug has quit IRC | 18:32 | |
| *** tonanhngo has joined #openstack-kuryr | 18:50 | |
| *** tonanhngo has quit IRC | 18:50 | |
| *** tonanhngo has joined #openstack-kuryr | 18:57 | |
| *** yamamoto has joined #openstack-kuryr | 19:05 | |
| *** diogogmt has joined #openstack-kuryr | 19:10 | |
| *** yamamoto has quit IRC | 19:13 | |
| *** diga has quit IRC | 19:14 | |
| *** neiljerram has quit IRC | 19:44 | |
| *** oanson has quit IRC | 20:18 | |
| *** neiljerram has joined #openstack-kuryr | 20:58 | |
| *** roeyc has joined #openstack-kuryr | 21:13 | |
| apuimedo | :-) | 21:17 |
| *** irenab_ has joined #openstack-kuryr | 21:21 | |
| *** irenab has quit IRC | 21:21 | |
| *** irenab_ is now known as irenab | 21:21 | |
| *** roeyc has quit IRC | 21:22 | |
| *** roeyc has joined #openstack-kuryr | 21:22 | |
| *** roeyc has quit IRC | 21:35 | |
| apuimedo | ivc_: about the races starting containers in devstack | 22:03 |
| apuimedo | which was it? | 22:03 |
| apuimedo | cause I see all the k8s containers use 'wait_for' | 22:04 |
| apuimedo | even the kubelet | 22:05 |
| apuimedo | only kuryr-kubernetes controller does not | 22:06 |
| apuimedo | so I'll add a wait there | 22:06 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes: devstack: Have controller wait for K8s API https://review.openstack.org/413247 | 22:23 |
| *** roeyc has joined #openstack-kuryr | 22:42 | |
| *** diogogmt has quit IRC | 22:50 | |
| *** salv-orlando has joined #openstack-kuryr | 23:06 | |
| *** salv-orlando has quit IRC | 23:40 | |
| *** diogogmt has joined #openstack-kuryr | 23:42 | |
| *** roeyc has quit IRC | 23:46 | |
| *** roeyc has joined #openstack-kuryr | 23:47 | |
| openstackgerrit | Tony Breeds proposed openstack/fuxi: Add Constraints support https://review.openstack.org/413274 | 23:53 |
| *** diogogmt has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
