| *** salv-orlando has joined #openstack-kuryr | 00:43 | |
| *** salv-orlando has quit IRC | 00:48 | |
| *** saneax is now known as saneax-_-|AFK | 00:53 | |
| *** hongbin has quit IRC | 01:42 | |
| *** salv-orlando has joined #openstack-kuryr | 01:44 | |
| *** salv-orlando has quit IRC | 01:48 | |
| *** hongbin has joined #openstack-kuryr | 02:17 | |
| *** david-lyle has joined #openstack-kuryr | 02:35 | |
| *** david-lyle has quit IRC | 02:39 | |
| *** salv-orlando has joined #openstack-kuryr | 02:44 | |
| *** salv-orlando has quit IRC | 02:49 | |
| *** hongbin has quit IRC | 03:11 | |
| *** salv-orlando has joined #openstack-kuryr | 03:45 | |
| *** salv-orlando has quit IRC | 03:50 | |
| *** hongbin has joined #openstack-kuryr | 04:18 | |
| *** david-lyle has joined #openstack-kuryr | 04:36 | |
| *** david-lyle has quit IRC | 04:41 | |
| *** salv-orlando has joined #openstack-kuryr | 04:46 | |
| *** salv-orlando has quit IRC | 04:51 | |
| *** hongbin has quit IRC | 05:03 | |
| *** janki has joined #openstack-kuryr | 05:40 | |
| *** salv-orlando has joined #openstack-kuryr | 05:47 | |
| *** salv-orlando has quit IRC | 05:51 | |
| *** saneax-_-|AFK is now known as saneax | 06:08 | |
| *** salv-orlando has joined #openstack-kuryr | 06:29 | |
| *** apuimedo has joined #openstack-kuryr | 07:11 | |
| apuimedo | vikas_: ping | 07:11 |
|---|---|---|
| vikas_ | apuimedo, hi | 07:11 |
| apuimedo | :-) | 07:11 |
| vikas_ | :) | 07:12 |
| *** salv-orl_ has joined #openstack-kuryr | 07:13 | |
| *** salv-orlando has quit IRC | 07:16 | |
| *** pcaruana has joined #openstack-kuryr | 07:23 | |
| openstackgerrit | Merged openstack/kuryr: Avoid hard-coding of 'neutron' config group https://review.openstack.org/414767 | 07:36 |
| openstackgerrit | Merged openstack/kuryr: Refactor out keystoneauth code from neutron https://review.openstack.org/414766 | 07:38 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-kubernetes: Add support for nested pods with Vlan trunk port https://review.openstack.org/410578 | 07:45 |
| apuimedo | irenab: ping | 07:46 |
| irenab | apuimedo, hi | 08:22 |
| apuimedo | :-) | 08:23 |
| irenab | apuimedo, is there kuryr meeting today? | 08:24 |
| apuimedo | yes | 08:24 |
| apuimedo | I wanted to ask about the review I made. Give me 5 mins | 08:24 |
| irenab | apuimedo, sure | 08:26 |
| apuimedo | irenab: I think we should modify kuryr_kubernetes/config.py so that it does the cfg.OptGroup creation of neutron_defaults | 08:30 |
| *** salv-orl_ has quit IRC | 08:30 | |
| apuimedo | and then have it use that for "CONF.register_opts(neutron_defaults, group='neutron_defaults')" becoming "CONF.register_opts(neutron_defaults, group=neutron_defaults)" | 08:30 |
| apuimedo | and in your patch use this kuryr_kubernetes/config.py neutron_defualts variable | 08:31 |
| apuimedo | irenab: do I make sense? | 08:31 |
| irenab | apuimedo, maybe. But this is put of scope of this bug that just fixes the wrong exception message | 08:31 |
| irenab | apuimedo, what benefit it makes if you make it the way you suggest? | 08:32 |
| apuimedo | so... do we fix it in a previous patch or a follow-up patch? So many OptGroup creations seem like repeating ourselves needlessly, so that if we change the option string ever we'll have to start hunting | 08:32 |
| irenab | apuimedo, is it the common practice in other projects? | 08:35 |
| irenab | I think more chances is that specific option name may be changed | 08:36 |
| apuimedo | well, it's how we did it in kuryr-lib | 08:36 |
| apuimedo | we register the options with an opt group object instead of a string | 08:36 |
| irenab | lib is supposed to be used by other projects, so it makes total sense. | 08:36 |
| irenab | anyway, I am fine with the approach you suggest, but think it should be reported as bug and handled separetly from fixing wrong exception | 08:38 |
| irenab | apuimedo, it was really annoying, to see the 'unprintable' string for exception (somehow devstack failed to populate thepod_project option) | 08:39 |
| apuimedo | agreed | 08:39 |
| apuimedo | xD | 08:39 |
| apuimedo | I agree with it being annoyed too | 08:39 |
| apuimedo | *annoying | 08:39 |
| irenab | python never stops suprising me | 08:40 |
| apuimedo | vikas_: pls review https://review.openstack.org/#/c/415275/3 | 08:40 |
| apuimedo | well, we have a few layers of python :-) | 08:40 |
| irenab | apuimedo, its a bit ugly to verify exception message in the unit test, but at least makes sure it raises the expected one | 08:41 |
| apuimedo | yup | 08:41 |
| vikas_ | apuimedo, done, lgtm | 08:44 |
| apuimedo | cool | 08:45 |
| *** salv-orlando has joined #openstack-kuryr | 09:02 | |
| *** saneax has left #openstack-kuryr | 10:30 | |
| *** saneax has joined #openstack-kuryr | 10:31 | |
| openstackgerrit | Merged openstack/kuryr-kubernetes: Fix group parameter for cfg.RequiredOptError in default drivers https://review.openstack.org/415275 | 10:36 |
| *** salv-orlando has quit IRC | 12:04 | |
| *** saneax is now known as saneax-_-|AFK | 12:29 | |
| *** yamamoto has joined #openstack-kuryr | 12:32 | |
| *** salv-orlando has joined #openstack-kuryr | 12:41 | |
| *** pcaruana has quit IRC | 13:00 | |
| *** pcaruana has joined #openstack-kuryr | 13:04 | |
| *** janki has quit IRC | 13:10 | |
| *** salv-orl_ has joined #openstack-kuryr | 13:13 | |
| *** salv-orl_ has quit IRC | 13:15 | |
| *** salv-orlando has quit IRC | 13:16 | |
| *** yamamoto has quit IRC | 13:18 | |
| *** david-lyle has joined #openstack-kuryr | 13:43 | |
| *** david-lyle has quit IRC | 13:47 | |
| *** limao has joined #openstack-kuryr | 14:10 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Fix the typo in comment https://review.openstack.org/413461 | 14:15 |
| *** salv-orlando has joined #openstack-kuryr | 14:15 | |
| *** limao_ has joined #openstack-kuryr | 14:17 | |
| *** limao has quit IRC | 14:18 | |
| *** yamamoto has joined #openstack-kuryr | 14:19 | |
| *** salv-orlando has quit IRC | 14:21 | |
| *** yamamoto has quit IRC | 14:29 | |
| *** salv-orlando has joined #openstack-kuryr | 15:17 | |
| *** salv-orlando has quit IRC | 15:21 | |
| *** salv-orlando has joined #openstack-kuryr | 15:41 | |
| *** david-lyle has joined #openstack-kuryr | 15:45 | |
| *** david-lyle has quit IRC | 15:49 | |
| *** hongbin has joined #openstack-kuryr | 16:08 | |
| *** limao_ has quit IRC | 16:12 | |
| *** limao has joined #openstack-kuryr | 16:13 | |
| *** limao has quit IRC | 16:46 | |
| *** neiljerram has joined #openstack-kuryr | 17:01 | |
| *** salv-orlando has quit IRC | 18:04 | |
| *** salv-orlando has joined #openstack-kuryr | 18:05 | |
| *** hongbin has quit IRC | 18:39 | |
| *** salv-orl_ has joined #openstack-kuryr | 19:14 | |
| *** salv-orlando has quit IRC | 19:17 | |
| *** salv-orl_ has quit IRC | 19:25 | |
| *** pcaruana has quit IRC | 20:00 | |
| *** david-lyle has joined #openstack-kuryr | 20:48 | |
| *** david-lyle has quit IRC | 20:52 | |
| *** salv-orlando has joined #openstack-kuryr | 20:55 | |
| *** pcaruana has joined #openstack-kuryr | 21:00 | |
| *** salv-orlando has quit IRC | 21:00 | |
| *** salv-orlando has joined #openstack-kuryr | 21:01 | |
| *** pcaruana has quit IRC | 21:20 | |
| *** pcaruana has joined #openstack-kuryr | 21:42 | |
| *** pcaruana has quit IRC | 22:13 | |
| *** david-lyle has joined #openstack-kuryr | 22:49 | |
| *** david-lyle has quit IRC | 22:54 | |
| *** pmannidi has joined #openstack-kuryr | 23:08 | |
| *** pmannidi has quit IRC | 23:17 | |
| *** pmannidi has joined #openstack-kuryr | 23:29 | |
| *** salv-orlando has quit IRC | 23:29 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!