Thursday, 2017-01-05

*** janonymous has joined #openstack-kuryr00:10
*** hongbin has quit IRC00:40
*** neiljerram has quit IRC00:44
*** yedongcan has joined #openstack-kuryr01:02
*** yamamoto has joined #openstack-kuryr01:09
*** yamamoto has quit IRC01:18
*** yamamoto has joined #openstack-kuryr01:18
*** yamamoto has quit IRC01:33
*** yamamoto has joined #openstack-kuryr01:34
*** yamamoto has quit IRC01:43
*** yedongcan1 has joined #openstack-kuryr01:44
*** yedongcan has quit IRC01:44
*** yamamoto has joined #openstack-kuryr01:49
*** yamamoto has quit IRC01:52
*** yamamoto has joined #openstack-kuryr01:54
*** yedongcan has joined #openstack-kuryr01:55
*** yedongcan1 has quit IRC01:56
openstackgerritxhzhf proposed openstack/kuryr-kubernetes: H402 hacking have been deprecated  https://review.openstack.org/41680702:10
*** yamamoto has quit IRC02:11
openstackgerritxhzhf proposed openstack/kuryr-kubernetes: H402 hacking have been deprecated  https://review.openstack.org/41680702:12
openstackgerritxhzhf proposed openstack/kuryr-libnetwork: H402 hacking have been deprecated  https://review.openstack.org/41681202:21
openstackgerritxhzhf proposed openstack/kuryr-libnetwork: H402 hacking have been deprecated  https://review.openstack.org/41681202:57
*** apuimedo has quit IRC03:05
*** jgriffith has quit IRC03:05
*** jgriffith has joined #openstack-kuryr03:06
*** apuimedo has joined #openstack-kuryr03:06
*** hongbin has joined #openstack-kuryr03:15
openstackgerritvikas choudhary proposed openstack/kuryr-kubernetes: Add support for nested pods with Vlan trunk port  https://review.openstack.org/41057803:17
*** yamamoto has joined #openstack-kuryr03:20
vikascapuimedo, irenab ^03:21
*** yedongcan has quit IRC03:58
*** janki has joined #openstack-kuryr04:14
*** hongbin has quit IRC05:24
*** jchhatbar has joined #openstack-kuryr05:29
*** janki has quit IRC05:30
*** ivc_ has quit IRC05:36
*** salv-orlando has joined #openstack-kuryr05:41
*** ivc_ has joined #openstack-kuryr05:43
*** yedongcan has joined #openstack-kuryr05:53
*** jchhatbar has quit IRC05:58
*** jchhatbar has joined #openstack-kuryr05:58
irenabvikasc: thanks, will check it asap06:12
vikascthanks irenab06:32
*** pcaruana has joined #openstack-kuryr07:05
*** salv-orl_ has joined #openstack-kuryr07:13
*** salv-orl_ has quit IRC07:13
*** salv-orlando has quit IRC07:16
*** yedongcan has quit IRC07:17
*** ivc_ has quit IRC07:19
*** ivc_ has joined #openstack-kuryr07:20
*** ivc_ has quit IRC07:30
*** jchhatbar is now known as janki07:41
*** ivc_ has joined #openstack-kuryr07:46
*** openstackgerrit has quit IRC07:50
*** yedongcan has joined #openstack-kuryr07:58
*** yedongcan1 has joined #openstack-kuryr08:02
*** yedongcan has quit IRC08:04
*** ivc_ has quit IRC08:11
*** ivc_ has joined #openstack-kuryr08:12
*** saneax-_-|AFK is now known as saneax08:46
*** saneax is now known as saneax-_-|AFK08:47
*** saneax-_-|AFK is now known as saneax08:50
*** ivc_ has quit IRC08:50
*** ivc_ has joined #openstack-kuryr08:50
*** janki has quit IRC08:52
*** pmannidi has quit IRC08:57
*** openstackgerrit has joined #openstack-kuryr08:59
openstackgerritBerezovsky Irena proposed openstack/kuryr-kubernetes: Kubernetes Service support design reference document  https://review.openstack.org/41622808:59
*** ivc_ has quit IRC09:00
*** roeyc has joined #openstack-kuryr09:01
*** pmannidi has joined #openstack-kuryr09:09
*** janki has joined #openstack-kuryr09:10
*** pmannidi has quit IRC09:13
*** yamamoto has quit IRC09:14
*** pmannidi has joined #openstack-kuryr09:18
*** ivc_ has joined #openstack-kuryr09:18
openstackgerritLuis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management  https://review.openstack.org/40246209:20
*** pmannidi has quit IRC09:22
*** pmannidi has joined #openstack-kuryr09:33
*** openstackgerrit has quit IRC09:33
*** pmannidi has quit IRC09:37
*** saneax is now known as saneax-_-|AFK09:43
*** saneax-_-|AFK is now known as saneax09:47
*** openstackgerrit has joined #openstack-kuryr09:50
openstackgerritAntoni Segura Puimedon proposed openstack/kuryr-kubernetes: Kubernetes Service support design reference document  https://review.openstack.org/41622809:50
apuimedoirenab: I rebased your doc patch, so that devstac/gate_hook.sh would not be missing09:51
apuimedoplease, check the comments ltomasbo put in the patchset before my rebase09:51
apuimedo(don't want my rebase to hide them)09:51
*** neiljerram has joined #openstack-kuryr09:52
ltomasbo:D they are just two tiny nits09:53
irenabapuimedo, thank!09:54
apuimedoltomasbo: I know. It's just that gerrit doesn't know to move unaddressed comments forward on just rebased patches09:55
apuimedo(which I find bothering)09:55
*** ivc_ has quit IRC09:56
apuimedoirenab: yedongcan1: regarding https://review.openstack.org/#/c/414455/09:57
openstackgerritMerged openstack/kuryr-libnetwork: Remove unnecessary checks in CreateNetwork  https://review.openstack.org/41465909:57
apuimedoI thought there's only tags for networks09:57
apuimedowhen where they added for subnets?09:57
irenabapuimedo, which patch?09:57
apuimedohttps://review.openstack.org/#/c/414455/09:57
yedongcan1apuimedo: https://review.openstack.org/#/c/413662/09:58
yedongcan1apuimedo: still in progress09:58
apuimedoOH09:58
apuimedoCool!09:58
irenabapuimedo, https://github.com/openstack/neutron/blob/master/neutron/extensions/tag.py#L3709:59
apuimedoyedongcan1: irenab: The only issue I see with the patch, is that it breaks backwards compatibility09:59
apuimedothen09:59
apuimedoas in, as soon as we merge this, kuryr master will only work with >=Ocata09:59
*** yamamoto has joined #openstack-kuryr09:59
yedongcan1apuimedo: yes, that will not cherrypick to stable branch.10:00
apuimedoyedongcan1: It would be good if we could have your patch check for support and otherwise keep the old behavior10:00
apuimedowhat do you think irenab vikasc ?10:00
irenabapuimedo, agree with you10:01
* vikasc reading back10:01
irenabfallback to the previous behavior if tags extension is not available10:02
yedongcan1apuimedo: we can't check subnet tags support, we only can check tags support.10:02
*** yamamoto_ has joined #openstack-kuryr10:02
irenabneed to be make sure what extension presence means10:02
apuimedoyedongcan1: I think we can catch the exception when adding the subnet tags10:02
irenabthat it supports other then network10:02
irenabapuimedo, it is a bit 'dirty' way to handle it, but will work10:03
apuimedoirenab: well, the only alternative would be that the extension check would give detailed info10:05
apuimedodoes it?10:05
*** yamamoto has quit IRC10:06
vikascapuimedo, cant we check for extension like we do today for 'tags' and subnetpool extensions?10:06
irenabyes, need to check the patch mentioned above10:07
irenabbut as temporary, we can go with what you suggest10:07
* apuimedo checking10:07
* irenab is going for lunch , brb10:08
*** yamamoto_ has quit IRC10:08
apuimedoirenab: bon appetit10:10
*** neiljerram has quit IRC10:12
yedongcan1apuemedo: what do you mean the extension check would give detailed info?10:12
*** openstack has joined #openstack-kuryr10:14
yedongcan1apuimedo: what do you mean the extension check would give detailed info?10:14
vikascyedongcan1, looks liketags are supported only for network objects10:16
vikascyedongcan1, how are you planning for subnets10:16
apuimedovikasc: his patch depends on one of neutron that adds support for other object tags10:16
apuimedo;-)10:16
apuimedoyedongcan1: What I meant is, if app.neutron.show_extension for tags would give information about which entities support tags10:17
apuimedoIf so, we could just check it like that10:17
vikascapuimedo, +110:20
yedongcan1apuimedo: maybe we need to change neutron code.10:20
yedongcan1# neutron ext-show tag10:20
yedongcan1+-------------+----------------------------------+10:20
yedongcan1| Field       | Value                            |10:20
yedongcan1+-------------+----------------------------------+10:20
yedongcan1| alias       | tag                              |10:20
yedongcan1| description | Enables to set tag on resources. |10:20
yedongcan1| links       |                                  |10:20
yedongcan1| name        | Tag support                      |10:20
yedongcan1| updated     | 2016-01-01T00:00:00-00:00        |10:20
yedongcan1+-------------+----------------------------------+10:20
vikascyedongcan1, yeah, to show all resources that support tags10:22
vikascyedongcan1, that should be very small and easy to get accepted change :)10:23
*** jchhatbar has joined #openstack-kuryr10:23
*** janki has quit IRC10:25
yedongcan1apuimedo, vikasc: sure, I will check that way.10:29
vikascthanks yedongcan1 !10:29
yedongcan1vikasc: you are welcome.10:31
*** jchhatbar_ has joined #openstack-kuryr10:33
*** yamamoto has joined #openstack-kuryr10:34
*** jchhatbar has quit IRC10:36
*** yedongcan1 has left #openstack-kuryr10:42
*** neiljerram has joined #openstack-kuryr10:43
*** yuval has joined #openstack-kuryr10:43
*** ivc_ has joined #openstack-kuryr10:46
*** ivc_ has quit IRC10:50
*** salv-orlando has joined #openstack-kuryr10:52
*** salv-orlando has quit IRC10:57
*** salv-orlando has joined #openstack-kuryr10:57
*** salv-orlando has quit IRC11:02
*** janki has joined #openstack-kuryr11:02
*** jchhatbar_ has quit IRC11:03
*** salv-orlando has joined #openstack-kuryr11:04
*** salv-orlando has quit IRC11:19
*** salv-orlando has joined #openstack-kuryr11:19
*** salv-orlando has quit IRC11:24
openstackgerritBerezovsky Irena proposed openstack/kuryr-kubernetes: Kubernetes Service support design reference document  https://review.openstack.org/41622811:38
*** pmannidi has joined #openstack-kuryr11:46
apuimedoltomasbo: looking at https://review.openstack.org/#/c/402462/20/kuryr_libnetwork/port_driver/driver.py11:49
apuimedoif it's something for the drivers to implement, part of the interface, it probably shouldn't be starting with '_'11:50
ltomasboohh, true!11:51
apuimedo;-)11:51
ltomasboit was only internal to vlan, but after the port_driver re-shaping, it was needed, so I forgot to remove the _11:51
apuimedo:-)11:53
apuimedochange that and you have my +211:53
apuimedo;-)11:53
*** pmannidi has quit IRC11:54
*** mchiappero has quit IRC11:55
*** mchiappero has joined #openstack-kuryr11:55
ltomasbogreat! I'll do in a few mins11:56
apuimedothanks!11:56
openstackgerritLuis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management  https://review.openstack.org/40246212:10
*** saneax is now known as saneax-_-|AFK12:11
irenabltomasbo, checking12:26
ltomasboirenab, great, thanks!12:27
irenabltomasbo, I have some question12:32
ltomasbosure, go ahead!12:32
irenabit looks like update port in nested and veth cases is the same. Am I correct?12:32
ltomasboyes, it is12:32
ltomasboit was before in the controller.py code12:33
irenabmaybe worth to keep the method implementation in the base class12:33
irenabdriver base class12:33
ltomasboin driver.py you mean?12:33
ltomasboinstead of NotImplemented()?12:33
irenabyes12:33
irenabthen each specific driver can call this method12:34
ltomasboI was actually thinking about that when moving the code12:35
irenabactually also the vlan driver keeps repeating the same logic after segmentation stuff12:35
ltomasbobut I was not sure and waited for people to comment on it12:35
irenab:-)12:35
*** yamamoto has quit IRC12:36
ltomasbook, I'll move the similar code to the driver.py12:37
ltomasboas all of them were empty, I was hesitating to move it there12:38
*** yamamoto has joined #openstack-kuryr12:38
irenabI have the same dilema, but since the code is duplicated 3 times, we need to extract it to the common method12:39
*** vikasc has quit IRC12:39
irenabwe may need to add some additional method with NotImpelmented in the base for 'extra_work_on_port_update'12:39
irenabBut having base implementation is ok as well, that can be extended by the specific driver12:40
irenabltomasbo, do you prefer me to comment on the patch, so you can get more opinions?12:41
ltomasboyes, please do12:41
irenabltomasbo, sure12:41
ltomasbojust in case there are other opinions, although I agree with you12:41
irenabadding now12:41
ltomasboI'll wait a bit for other to comment and if no one disagrees, I will move the common part to driver.py12:41
ltomasboirenab, also let me know of any other issues so that I can handle all of them at the same time12:42
irenabsure12:42
irenabltomasbo, do you have devstack setting to try this patch?12:43
ltomasboyep12:43
*** vikasc has joined #openstack-kuryr12:50
*** janki has quit IRC12:51
*** yamamoto has quit IRC12:52
*** dougbtv has quit IRC13:09
*** dougbtv has joined #openstack-kuryr13:14
irenabltomasbo, please attach it to the patch (link in the comment)13:40
*** yamamoto has joined #openstack-kuryr13:55
*** salv-orlando has joined #openstack-kuryr13:56
irenabvikasc, ping13:57
vikascirenab, pong13:57
irenabvikasc, any chance you have set of commands to launch VM with trunk port?13:58
irenabfor the devstack setup you shared?13:58
irenabnot sure what image to use13:58
vikascok13:58
vikasci launched a fedora image13:59
vikascone sec, let me get exact command to you13:59
irenabyou created trunk port on private network?13:59
vikascyes13:59
vikascand then created a trunk trunk014:00
irenabvikasc,  so 1. create  port on private network14:01
irenab2. create trunck port with above port on private network14:01
irenab3. create VM (waiting for command)14:01
irenab4. log into VM, and run devstack with kuryr.14:02
irenabcorrect?14:02
vikasc     openstack port create --network ... parent-port14:02
vikasc#            parent_mac="$( openstack port show parent-port | awk '/ mac_address / { print $4 }' )"14:02
vikasc#            openstack port create --mac-address "$parent_mac" --network ... child-port14:02
vikasc#            openstack network trunk create --parent-port parent-port trunk014:02
vikaschttps://wiki.openstack.org/wiki/Neutron/TrunkPort14:02
vikascirenab, a meeting got started. i will get back14:03
irenabok14:03
ltomasboirenab, what do you mean with attach it to the patch?14:04
vikascirenab, nova boot --flavor m1.large --image fed_1 --nic port-id=59b752ef-f0da-4795-b5ac-73d7eea21f2d --security-group default --key-name my-key vm014:06
vikascirenab, openstack image create fed_1 --public --disk-format "qcow2" --file ../Fedora-Cloud-Base-24-1.2.x86_64.qcow214:07
vikascirenab, i just downloaded this fedora image and added to glance and then launched vm using nova boot14:08
irenabvikasc, thanks14:08
vikascirenab, yw!14:08
vikascirenab, please let me know if you need any help/command14:09
irenabvikasc, sure14:09
*** yamamoto has quit IRC14:10
irenabltomasbo, yes, you can just post the link to it (pastebin) as comment on the patch14:10
irenabltomasbo, no need to add it to the patch itself14:10
ltomasboirenab, you mean the link to a devstack local.conf file?14:13
ltomasboto try the vlan then I also had to create a VM and install kuryr inside (and configure it), so devstack was not enough14:14
irenabltomasbo, it can help if you add some instruction how to bring up the environment to check it. maybe its similar to what vikasc is adding for k8s14:15
*** pc_m has quit IRC14:15
*** pc_m has joined #openstack-kuryr14:15
ltomasbook, I'll check that!14:15
vikascltomasbo, https://review.openstack.org/#/c/410578/7/README.rst irenab is refering to this14:16
ltomasbogreat! Thanks!14:17
vikascnp !14:19
*** yamamoto has joined #openstack-kuryr14:27
*** portdirect is now known as portdirect_lunch14:41
*** salv-orlando has quit IRC14:50
*** hongbin has joined #openstack-kuryr14:51
*** mattmceuen has joined #openstack-kuryr15:12
*** portdirect_lunch is now known as portdirect15:16
*** mattmceuen has quit IRC15:23
*** yuval has quit IRC15:24
*** mattmceuen has joined #openstack-kuryr15:28
*** salv-orlando has joined #openstack-kuryr15:34
*** salv-orl_ has joined #openstack-kuryr15:53
*** salv-orlando has quit IRC15:56
*** yamamoto has quit IRC16:16
*** roeyc has quit IRC16:22
*** saneax-_-|AFK is now known as saneax16:49
*** pcaruana has quit IRC16:58
openstackgerritLuis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management  https://review.openstack.org/40246217:00
*** yamamoto has joined #openstack-kuryr17:16
*** roeyc has joined #openstack-kuryr17:25
*** roeyc has quit IRC17:26
*** yamamoto has quit IRC17:26
*** ivc_ has joined #openstack-kuryr17:27
*** ivc_ has quit IRC17:34
*** ivc_ has joined #openstack-kuryr17:39
*** ivc_ has quit IRC17:45
*** ivc_ has joined #openstack-kuryr17:46
*** saneax is now known as saneax-_-|AFK17:53
*** roeyc has joined #openstack-kuryr18:27
*** salv-orl_ has quit IRC19:41
*** roeyc has quit IRC20:48
*** roeyc has joined #openstack-kuryr20:50
*** salv-orlando has joined #openstack-kuryr21:14
openstackgerritHongbin Lu proposed openstack/fuxi: Use keystoneauth1 for cinder access  https://review.openstack.org/41040321:27
*** portdirect is now known as portdirect_away21:49
*** salv-orl_ has joined #openstack-kuryr21:53
*** salv-orlando has quit IRC21:56
*** saneax-_-|AFK is now known as saneax22:09
*** saneax is now known as saneax-_-|AFK22:26
*** salv-orl_ has quit IRC22:33
*** saneax-_-|AFK is now known as saneax22:34
*** salv-orlando has joined #openstack-kuryr22:36
*** saneax is now known as saneax-_-|AFK22:54
*** pmannidi has joined #openstack-kuryr23:00
*** saneax-_-|AFK is now known as saneax23:05
*** saneax is now known as saneax-_-|AFK23:16
*** ivc_ has quit IRC23:19
*** saneax-_-|AFK is now known as saneax23:26
*** ivc_ has joined #openstack-kuryr23:28
*** mattmceuen has quit IRC23:37
*** saneax is now known as saneax-_-|AFK23:43
*** salv-orlando has quit IRC23:45
*** saneax-_-|AFK is now known as saneax23:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!