*** janonymous has joined #openstack-kuryr | 00:10 | |
*** hongbin has quit IRC | 00:40 | |
*** neiljerram has quit IRC | 00:44 | |
*** yedongcan has joined #openstack-kuryr | 01:02 | |
*** yamamoto has joined #openstack-kuryr | 01:09 | |
*** yamamoto has quit IRC | 01:18 | |
*** yamamoto has joined #openstack-kuryr | 01:18 | |
*** yamamoto has quit IRC | 01:33 | |
*** yamamoto has joined #openstack-kuryr | 01:34 | |
*** yamamoto has quit IRC | 01:43 | |
*** yedongcan1 has joined #openstack-kuryr | 01:44 | |
*** yedongcan has quit IRC | 01:44 | |
*** yamamoto has joined #openstack-kuryr | 01:49 | |
*** yamamoto has quit IRC | 01:52 | |
*** yamamoto has joined #openstack-kuryr | 01:54 | |
*** yedongcan has joined #openstack-kuryr | 01:55 | |
*** yedongcan1 has quit IRC | 01:56 | |
openstackgerrit | xhzhf proposed openstack/kuryr-kubernetes: H402 hacking have been deprecated https://review.openstack.org/416807 | 02:10 |
---|---|---|
*** yamamoto has quit IRC | 02:11 | |
openstackgerrit | xhzhf proposed openstack/kuryr-kubernetes: H402 hacking have been deprecated https://review.openstack.org/416807 | 02:12 |
openstackgerrit | xhzhf proposed openstack/kuryr-libnetwork: H402 hacking have been deprecated https://review.openstack.org/416812 | 02:21 |
openstackgerrit | xhzhf proposed openstack/kuryr-libnetwork: H402 hacking have been deprecated https://review.openstack.org/416812 | 02:57 |
*** apuimedo has quit IRC | 03:05 | |
*** jgriffith has quit IRC | 03:05 | |
*** jgriffith has joined #openstack-kuryr | 03:06 | |
*** apuimedo has joined #openstack-kuryr | 03:06 | |
*** hongbin has joined #openstack-kuryr | 03:15 | |
openstackgerrit | vikas choudhary proposed openstack/kuryr-kubernetes: Add support for nested pods with Vlan trunk port https://review.openstack.org/410578 | 03:17 |
*** yamamoto has joined #openstack-kuryr | 03:20 | |
vikasc | apuimedo, irenab ^ | 03:21 |
*** yedongcan has quit IRC | 03:58 | |
*** janki has joined #openstack-kuryr | 04:14 | |
*** hongbin has quit IRC | 05:24 | |
*** jchhatbar has joined #openstack-kuryr | 05:29 | |
*** janki has quit IRC | 05:30 | |
*** ivc_ has quit IRC | 05:36 | |
*** salv-orlando has joined #openstack-kuryr | 05:41 | |
*** ivc_ has joined #openstack-kuryr | 05:43 | |
*** yedongcan has joined #openstack-kuryr | 05:53 | |
*** jchhatbar has quit IRC | 05:58 | |
*** jchhatbar has joined #openstack-kuryr | 05:58 | |
irenab | vikasc: thanks, will check it asap | 06:12 |
vikasc | thanks irenab | 06:32 |
*** pcaruana has joined #openstack-kuryr | 07:05 | |
*** salv-orl_ has joined #openstack-kuryr | 07:13 | |
*** salv-orl_ has quit IRC | 07:13 | |
*** salv-orlando has quit IRC | 07:16 | |
*** yedongcan has quit IRC | 07:17 | |
*** ivc_ has quit IRC | 07:19 | |
*** ivc_ has joined #openstack-kuryr | 07:20 | |
*** ivc_ has quit IRC | 07:30 | |
*** jchhatbar is now known as janki | 07:41 | |
*** ivc_ has joined #openstack-kuryr | 07:46 | |
*** openstackgerrit has quit IRC | 07:50 | |
*** yedongcan has joined #openstack-kuryr | 07:58 | |
*** yedongcan1 has joined #openstack-kuryr | 08:02 | |
*** yedongcan has quit IRC | 08:04 | |
*** ivc_ has quit IRC | 08:11 | |
*** ivc_ has joined #openstack-kuryr | 08:12 | |
*** saneax-_-|AFK is now known as saneax | 08:46 | |
*** saneax is now known as saneax-_-|AFK | 08:47 | |
*** saneax-_-|AFK is now known as saneax | 08:50 | |
*** ivc_ has quit IRC | 08:50 | |
*** ivc_ has joined #openstack-kuryr | 08:50 | |
*** janki has quit IRC | 08:52 | |
*** pmannidi has quit IRC | 08:57 | |
*** openstackgerrit has joined #openstack-kuryr | 08:59 | |
openstackgerrit | Berezovsky Irena proposed openstack/kuryr-kubernetes: Kubernetes Service support design reference document https://review.openstack.org/416228 | 08:59 |
*** ivc_ has quit IRC | 09:00 | |
*** roeyc has joined #openstack-kuryr | 09:01 | |
*** pmannidi has joined #openstack-kuryr | 09:09 | |
*** janki has joined #openstack-kuryr | 09:10 | |
*** pmannidi has quit IRC | 09:13 | |
*** yamamoto has quit IRC | 09:14 | |
*** pmannidi has joined #openstack-kuryr | 09:18 | |
*** ivc_ has joined #openstack-kuryr | 09:18 | |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management https://review.openstack.org/402462 | 09:20 |
*** pmannidi has quit IRC | 09:22 | |
*** pmannidi has joined #openstack-kuryr | 09:33 | |
*** openstackgerrit has quit IRC | 09:33 | |
*** pmannidi has quit IRC | 09:37 | |
*** saneax is now known as saneax-_-|AFK | 09:43 | |
*** saneax-_-|AFK is now known as saneax | 09:47 | |
*** openstackgerrit has joined #openstack-kuryr | 09:50 | |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes: Kubernetes Service support design reference document https://review.openstack.org/416228 | 09:50 |
apuimedo | irenab: I rebased your doc patch, so that devstac/gate_hook.sh would not be missing | 09:51 |
apuimedo | please, check the comments ltomasbo put in the patchset before my rebase | 09:51 |
apuimedo | (don't want my rebase to hide them) | 09:51 |
*** neiljerram has joined #openstack-kuryr | 09:52 | |
ltomasbo | :D they are just two tiny nits | 09:53 |
irenab | apuimedo, thank! | 09:54 |
apuimedo | ltomasbo: I know. It's just that gerrit doesn't know to move unaddressed comments forward on just rebased patches | 09:55 |
apuimedo | (which I find bothering) | 09:55 |
*** ivc_ has quit IRC | 09:56 | |
apuimedo | irenab: yedongcan1: regarding https://review.openstack.org/#/c/414455/ | 09:57 |
openstackgerrit | Merged openstack/kuryr-libnetwork: Remove unnecessary checks in CreateNetwork https://review.openstack.org/414659 | 09:57 |
apuimedo | I thought there's only tags for networks | 09:57 |
apuimedo | when where they added for subnets? | 09:57 |
irenab | apuimedo, which patch? | 09:57 |
apuimedo | https://review.openstack.org/#/c/414455/ | 09:57 |
yedongcan1 | apuimedo: https://review.openstack.org/#/c/413662/ | 09:58 |
yedongcan1 | apuimedo: still in progress | 09:58 |
apuimedo | OH | 09:58 |
apuimedo | Cool! | 09:58 |
irenab | apuimedo, https://github.com/openstack/neutron/blob/master/neutron/extensions/tag.py#L37 | 09:59 |
apuimedo | yedongcan1: irenab: The only issue I see with the patch, is that it breaks backwards compatibility | 09:59 |
apuimedo | then | 09:59 |
apuimedo | as in, as soon as we merge this, kuryr master will only work with >=Ocata | 09:59 |
*** yamamoto has joined #openstack-kuryr | 09:59 | |
yedongcan1 | apuimedo: yes, that will not cherrypick to stable branch. | 10:00 |
apuimedo | yedongcan1: It would be good if we could have your patch check for support and otherwise keep the old behavior | 10:00 |
apuimedo | what do you think irenab vikasc ? | 10:00 |
irenab | apuimedo, agree with you | 10:01 |
* vikasc reading back | 10:01 | |
irenab | fallback to the previous behavior if tags extension is not available | 10:02 |
yedongcan1 | apuimedo: we can't check subnet tags support, we only can check tags support. | 10:02 |
*** yamamoto_ has joined #openstack-kuryr | 10:02 | |
irenab | need to be make sure what extension presence means | 10:02 |
apuimedo | yedongcan1: I think we can catch the exception when adding the subnet tags | 10:02 |
irenab | that it supports other then network | 10:02 |
irenab | apuimedo, it is a bit 'dirty' way to handle it, but will work | 10:03 |
apuimedo | irenab: well, the only alternative would be that the extension check would give detailed info | 10:05 |
apuimedo | does it? | 10:05 |
*** yamamoto has quit IRC | 10:06 | |
vikasc | apuimedo, cant we check for extension like we do today for 'tags' and subnetpool extensions? | 10:06 |
irenab | yes, need to check the patch mentioned above | 10:07 |
irenab | but as temporary, we can go with what you suggest | 10:07 |
* apuimedo checking | 10:07 | |
* irenab is going for lunch , brb | 10:08 | |
*** yamamoto_ has quit IRC | 10:08 | |
apuimedo | irenab: bon appetit | 10:10 |
*** neiljerram has quit IRC | 10:12 | |
yedongcan1 | apuemedo: what do you mean the extension check would give detailed info? | 10:12 |
*** openstack has joined #openstack-kuryr | 10:14 | |
yedongcan1 | apuimedo: what do you mean the extension check would give detailed info? | 10:14 |
vikasc | yedongcan1, looks liketags are supported only for network objects | 10:16 |
vikasc | yedongcan1, how are you planning for subnets | 10:16 |
apuimedo | vikasc: his patch depends on one of neutron that adds support for other object tags | 10:16 |
apuimedo | ;-) | 10:16 |
apuimedo | yedongcan1: What I meant is, if app.neutron.show_extension for tags would give information about which entities support tags | 10:17 |
apuimedo | If so, we could just check it like that | 10:17 |
vikasc | apuimedo, +1 | 10:20 |
yedongcan1 | apuimedo: maybe we need to change neutron code. | 10:20 |
yedongcan1 | # neutron ext-show tag | 10:20 |
yedongcan1 | +-------------+----------------------------------+ | 10:20 |
yedongcan1 | | Field | Value | | 10:20 |
yedongcan1 | +-------------+----------------------------------+ | 10:20 |
yedongcan1 | | alias | tag | | 10:20 |
yedongcan1 | | description | Enables to set tag on resources. | | 10:20 |
yedongcan1 | | links | | | 10:20 |
yedongcan1 | | name | Tag support | | 10:20 |
yedongcan1 | | updated | 2016-01-01T00:00:00-00:00 | | 10:20 |
yedongcan1 | +-------------+----------------------------------+ | 10:20 |
vikasc | yedongcan1, yeah, to show all resources that support tags | 10:22 |
vikasc | yedongcan1, that should be very small and easy to get accepted change :) | 10:23 |
*** jchhatbar has joined #openstack-kuryr | 10:23 | |
*** janki has quit IRC | 10:25 | |
yedongcan1 | apuimedo, vikasc: sure, I will check that way. | 10:29 |
vikasc | thanks yedongcan1 ! | 10:29 |
yedongcan1 | vikasc: you are welcome. | 10:31 |
*** jchhatbar_ has joined #openstack-kuryr | 10:33 | |
*** yamamoto has joined #openstack-kuryr | 10:34 | |
*** jchhatbar has quit IRC | 10:36 | |
*** yedongcan1 has left #openstack-kuryr | 10:42 | |
*** neiljerram has joined #openstack-kuryr | 10:43 | |
*** yuval has joined #openstack-kuryr | 10:43 | |
*** ivc_ has joined #openstack-kuryr | 10:46 | |
*** ivc_ has quit IRC | 10:50 | |
*** salv-orlando has joined #openstack-kuryr | 10:52 | |
*** salv-orlando has quit IRC | 10:57 | |
*** salv-orlando has joined #openstack-kuryr | 10:57 | |
*** salv-orlando has quit IRC | 11:02 | |
*** janki has joined #openstack-kuryr | 11:02 | |
*** jchhatbar_ has quit IRC | 11:03 | |
*** salv-orlando has joined #openstack-kuryr | 11:04 | |
*** salv-orlando has quit IRC | 11:19 | |
*** salv-orlando has joined #openstack-kuryr | 11:19 | |
*** salv-orlando has quit IRC | 11:24 | |
openstackgerrit | Berezovsky Irena proposed openstack/kuryr-kubernetes: Kubernetes Service support design reference document https://review.openstack.org/416228 | 11:38 |
*** pmannidi has joined #openstack-kuryr | 11:46 | |
apuimedo | ltomasbo: looking at https://review.openstack.org/#/c/402462/20/kuryr_libnetwork/port_driver/driver.py | 11:49 |
apuimedo | if it's something for the drivers to implement, part of the interface, it probably shouldn't be starting with '_' | 11:50 |
ltomasbo | ohh, true! | 11:51 |
apuimedo | ;-) | 11:51 |
ltomasbo | it was only internal to vlan, but after the port_driver re-shaping, it was needed, so I forgot to remove the _ | 11:51 |
apuimedo | :-) | 11:53 |
apuimedo | change that and you have my +2 | 11:53 |
apuimedo | ;-) | 11:53 |
*** pmannidi has quit IRC | 11:54 | |
*** mchiappero has quit IRC | 11:55 | |
*** mchiappero has joined #openstack-kuryr | 11:55 | |
ltomasbo | great! I'll do in a few mins | 11:56 |
apuimedo | thanks! | 11:56 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management https://review.openstack.org/402462 | 12:10 |
*** saneax is now known as saneax-_-|AFK | 12:11 | |
irenab | ltomasbo, checking | 12:26 |
ltomasbo | irenab, great, thanks! | 12:27 |
irenab | ltomasbo, I have some question | 12:32 |
ltomasbo | sure, go ahead! | 12:32 |
irenab | it looks like update port in nested and veth cases is the same. Am I correct? | 12:32 |
ltomasbo | yes, it is | 12:32 |
ltomasbo | it was before in the controller.py code | 12:33 |
irenab | maybe worth to keep the method implementation in the base class | 12:33 |
irenab | driver base class | 12:33 |
ltomasbo | in driver.py you mean? | 12:33 |
ltomasbo | instead of NotImplemented()? | 12:33 |
irenab | yes | 12:33 |
irenab | then each specific driver can call this method | 12:34 |
ltomasbo | I was actually thinking about that when moving the code | 12:35 |
irenab | actually also the vlan driver keeps repeating the same logic after segmentation stuff | 12:35 |
ltomasbo | but I was not sure and waited for people to comment on it | 12:35 |
irenab | :-) | 12:35 |
*** yamamoto has quit IRC | 12:36 | |
ltomasbo | ok, I'll move the similar code to the driver.py | 12:37 |
ltomasbo | as all of them were empty, I was hesitating to move it there | 12:38 |
*** yamamoto has joined #openstack-kuryr | 12:38 | |
irenab | I have the same dilema, but since the code is duplicated 3 times, we need to extract it to the common method | 12:39 |
*** vikasc has quit IRC | 12:39 | |
irenab | we may need to add some additional method with NotImpelmented in the base for 'extra_work_on_port_update' | 12:39 |
irenab | But having base implementation is ok as well, that can be extended by the specific driver | 12:40 |
irenab | ltomasbo, do you prefer me to comment on the patch, so you can get more opinions? | 12:41 |
ltomasbo | yes, please do | 12:41 |
irenab | ltomasbo, sure | 12:41 |
ltomasbo | just in case there are other opinions, although I agree with you | 12:41 |
irenab | adding now | 12:41 |
ltomasbo | I'll wait a bit for other to comment and if no one disagrees, I will move the common part to driver.py | 12:41 |
ltomasbo | irenab, also let me know of any other issues so that I can handle all of them at the same time | 12:42 |
irenab | sure | 12:42 |
irenab | ltomasbo, do you have devstack setting to try this patch? | 12:43 |
ltomasbo | yep | 12:43 |
*** vikasc has joined #openstack-kuryr | 12:50 | |
*** janki has quit IRC | 12:51 | |
*** yamamoto has quit IRC | 12:52 | |
*** dougbtv has quit IRC | 13:09 | |
*** dougbtv has joined #openstack-kuryr | 13:14 | |
irenab | ltomasbo, please attach it to the patch (link in the comment) | 13:40 |
*** yamamoto has joined #openstack-kuryr | 13:55 | |
*** salv-orlando has joined #openstack-kuryr | 13:56 | |
irenab | vikasc, ping | 13:57 |
vikasc | irenab, pong | 13:57 |
irenab | vikasc, any chance you have set of commands to launch VM with trunk port? | 13:58 |
irenab | for the devstack setup you shared? | 13:58 |
irenab | not sure what image to use | 13:58 |
vikasc | ok | 13:58 |
vikasc | i launched a fedora image | 13:59 |
vikasc | one sec, let me get exact command to you | 13:59 |
irenab | you created trunk port on private network? | 13:59 |
vikasc | yes | 13:59 |
vikasc | and then created a trunk trunk0 | 14:00 |
irenab | vikasc, so 1. create port on private network | 14:01 |
irenab | 2. create trunck port with above port on private network | 14:01 |
irenab | 3. create VM (waiting for command) | 14:01 |
irenab | 4. log into VM, and run devstack with kuryr. | 14:02 |
irenab | correct? | 14:02 |
vikasc | openstack port create --network ... parent-port | 14:02 |
vikasc | # parent_mac="$( openstack port show parent-port | awk '/ mac_address / { print $4 }' )" | 14:02 |
vikasc | # openstack port create --mac-address "$parent_mac" --network ... child-port | 14:02 |
vikasc | # openstack network trunk create --parent-port parent-port trunk0 | 14:02 |
vikasc | https://wiki.openstack.org/wiki/Neutron/TrunkPort | 14:02 |
vikasc | irenab, a meeting got started. i will get back | 14:03 |
irenab | ok | 14:03 |
ltomasbo | irenab, what do you mean with attach it to the patch? | 14:04 |
vikasc | irenab, nova boot --flavor m1.large --image fed_1 --nic port-id=59b752ef-f0da-4795-b5ac-73d7eea21f2d --security-group default --key-name my-key vm0 | 14:06 |
vikasc | irenab, openstack image create fed_1 --public --disk-format "qcow2" --file ../Fedora-Cloud-Base-24-1.2.x86_64.qcow2 | 14:07 |
vikasc | irenab, i just downloaded this fedora image and added to glance and then launched vm using nova boot | 14:08 |
irenab | vikasc, thanks | 14:08 |
vikasc | irenab, yw! | 14:08 |
vikasc | irenab, please let me know if you need any help/command | 14:09 |
irenab | vikasc, sure | 14:09 |
*** yamamoto has quit IRC | 14:10 | |
irenab | ltomasbo, yes, you can just post the link to it (pastebin) as comment on the patch | 14:10 |
irenab | ltomasbo, no need to add it to the patch itself | 14:10 |
ltomasbo | irenab, you mean the link to a devstack local.conf file? | 14:13 |
ltomasbo | to try the vlan then I also had to create a VM and install kuryr inside (and configure it), so devstack was not enough | 14:14 |
irenab | ltomasbo, it can help if you add some instruction how to bring up the environment to check it. maybe its similar to what vikasc is adding for k8s | 14:15 |
*** pc_m has quit IRC | 14:15 | |
*** pc_m has joined #openstack-kuryr | 14:15 | |
ltomasbo | ok, I'll check that! | 14:15 |
vikasc | ltomasbo, https://review.openstack.org/#/c/410578/7/README.rst irenab is refering to this | 14:16 |
ltomasbo | great! Thanks! | 14:17 |
vikasc | np ! | 14:19 |
*** yamamoto has joined #openstack-kuryr | 14:27 | |
*** portdirect is now known as portdirect_lunch | 14:41 | |
*** salv-orlando has quit IRC | 14:50 | |
*** hongbin has joined #openstack-kuryr | 14:51 | |
*** mattmceuen has joined #openstack-kuryr | 15:12 | |
*** portdirect_lunch is now known as portdirect | 15:16 | |
*** mattmceuen has quit IRC | 15:23 | |
*** yuval has quit IRC | 15:24 | |
*** mattmceuen has joined #openstack-kuryr | 15:28 | |
*** salv-orlando has joined #openstack-kuryr | 15:34 | |
*** salv-orl_ has joined #openstack-kuryr | 15:53 | |
*** salv-orlando has quit IRC | 15:56 | |
*** yamamoto has quit IRC | 16:16 | |
*** roeyc has quit IRC | 16:22 | |
*** saneax-_-|AFK is now known as saneax | 16:49 | |
*** pcaruana has quit IRC | 16:58 | |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management https://review.openstack.org/402462 | 17:00 |
*** yamamoto has joined #openstack-kuryr | 17:16 | |
*** roeyc has joined #openstack-kuryr | 17:25 | |
*** roeyc has quit IRC | 17:26 | |
*** yamamoto has quit IRC | 17:26 | |
*** ivc_ has joined #openstack-kuryr | 17:27 | |
*** ivc_ has quit IRC | 17:34 | |
*** ivc_ has joined #openstack-kuryr | 17:39 | |
*** ivc_ has quit IRC | 17:45 | |
*** ivc_ has joined #openstack-kuryr | 17:46 | |
*** saneax is now known as saneax-_-|AFK | 17:53 | |
*** roeyc has joined #openstack-kuryr | 18:27 | |
*** salv-orl_ has quit IRC | 19:41 | |
*** roeyc has quit IRC | 20:48 | |
*** roeyc has joined #openstack-kuryr | 20:50 | |
*** salv-orlando has joined #openstack-kuryr | 21:14 | |
openstackgerrit | Hongbin Lu proposed openstack/fuxi: Use keystoneauth1 for cinder access https://review.openstack.org/410403 | 21:27 |
*** portdirect is now known as portdirect_away | 21:49 | |
*** salv-orl_ has joined #openstack-kuryr | 21:53 | |
*** salv-orlando has quit IRC | 21:56 | |
*** saneax-_-|AFK is now known as saneax | 22:09 | |
*** saneax is now known as saneax-_-|AFK | 22:26 | |
*** salv-orl_ has quit IRC | 22:33 | |
*** saneax-_-|AFK is now known as saneax | 22:34 | |
*** salv-orlando has joined #openstack-kuryr | 22:36 | |
*** saneax is now known as saneax-_-|AFK | 22:54 | |
*** pmannidi has joined #openstack-kuryr | 23:00 | |
*** saneax-_-|AFK is now known as saneax | 23:05 | |
*** saneax is now known as saneax-_-|AFK | 23:16 | |
*** ivc_ has quit IRC | 23:19 | |
*** saneax-_-|AFK is now known as saneax | 23:26 | |
*** ivc_ has joined #openstack-kuryr | 23:28 | |
*** mattmceuen has quit IRC | 23:37 | |
*** saneax is now known as saneax-_-|AFK | 23:43 | |
*** salv-orlando has quit IRC | 23:45 | |
*** saneax-_-|AFK is now known as saneax | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!