Monday, 2017-02-06

« Sunday, 2017-02-05 Index Tuesday, 2017-02-07 »
*** pmannidi has joined #openstack-kuryr00:03
*** pmannidi has quit IRC00:05
*** pmannidi has joined #openstack-kuryr00:11
*** yuvalb has quit IRC00:23
*** yuvalb has joined #openstack-kuryr00:25
*** limao has joined #openstack-kuryr01:19
openstackgerritLiping Mao proposed openstack/kuryr-libnetwork master: avoid unnecessary neutron api call in revoke_expose_ports  https://review.openstack.org/42943201:21
*** yedongcan has joined #openstack-kuryr01:32
*** yedongcan1 has joined #openstack-kuryr02:14
*** yedongcan has quit IRC02:16
*** hongbin has joined #openstack-kuryr03:03
openstackgerritfeng.shengqin proposed openstack/fuxi master: Remove support for py33  https://review.openstack.org/42948403:54
openstackgerritHongbin Lu proposed openstack/kuryr-libnetwork master: Optimize the search of subnet  https://review.openstack.org/42792304:11
openstackgerritfeng.shengqin proposed openstack/fuxi master: Add the link for BPs  https://review.openstack.org/42949304:17
*** hongbin has quit IRC04:21
*** v1k0d3n has quit IRC04:36
*** david-lyle has joined #openstack-kuryr04:46
*** david-lyle_ has joined #openstack-kuryr04:50
*** david-lyle has quit IRC04:50
*** david-lyle_ is now known as david-lyle04:52
*** janki has joined #openstack-kuryr05:05
*** limao has quit IRC05:21
*** david-lyle has quit IRC05:21
*** limao has joined #openstack-kuryr05:22
*** mattmceuen has quit IRC05:26
*** limao has quit IRC05:48
*** limao has joined #openstack-kuryr05:52
*** salv-orlando has joined #openstack-kuryr06:00
*** limao has quit IRC06:09
*** limao has joined #openstack-kuryr06:09
*** limao has quit IRC06:14
*** janki has quit IRC06:25
openstackgerritfeng.shengqin proposed openstack/fuxi master: Pyo and pyd files needn't add to the git repository  https://review.openstack.org/42952206:28
*** limao has joined #openstack-kuryr06:32
*** ivc_ has quit IRC07:01
*** ivc_ has joined #openstack-kuryr07:15
*** limao has quit IRC07:16
*** limao has joined #openstack-kuryr07:17
*** saneax-_-|AFK is now known as saneax07:21
*** limao has quit IRC07:21
*** yamamoto has quit IRC07:25
*** janki has joined #openstack-kuryr07:33
*** limao has joined #openstack-kuryr07:36
*** salv-orl_ has joined #openstack-kuryr07:49
*** salv-orlando has quit IRC07:52
*** pcaruana has joined #openstack-kuryr07:55
*** pcaruana has quit IRC08:07
*** pcaruana has joined #openstack-kuryr08:07
openstackgerritfeng.shengqin proposed openstack/fuxi master: Generating config file during installation  https://review.openstack.org/42956008:13
*** yamamoto has joined #openstack-kuryr08:35
*** yedongcan1 has left #openstack-kuryr08:46
*** yedongcan1 has joined #openstack-kuryr08:46
*** yamamoto has quit IRC08:47
*** limao has quit IRC08:51
*** limao has joined #openstack-kuryr08:52
*** salv-orl_ has quit IRC08:52
*** limao has quit IRC08:57
*** vikasc has quit IRC08:57
oanson#startmeeting Dragonflow09:00
openstackMeeting started Mon Feb  6 09:00:19 2017 UTC and is due to finish in 60 minutes.  The chair is oanson. Information about MeetBot at http://wiki.debian.org/MeetBot.09:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.09:00
openstackThe meeting name has been set to 'dragonflow'09:00
oansonAll right, who's here for the weekly?09:01
oanson#endmeeting09:01
openstackMeeting ended Mon Feb  6 09:01:17 2017 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)09:01
openstackMinutes:        http://eavesdrop.openstack.org/meetings/dragonflow/2017/dragonflow.2017-02-06-09.00.html09:01
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/dragonflow/2017/dragonflow.2017-02-06-09.00.txt09:01
openstackLog:            http://eavesdrop.openstack.org/meetings/dragonflow/2017/dragonflow.2017-02-06-09.00.log.html09:01
oansonSorry, wrong channel :(09:01
ivc_irenab ping09:01
irenabivc_, hi09:02
ivc_hi09:02
ivc_about that assertRaisesRegex09:02
ivc_what was the problem with assertRaises that made you change it to assertRaisesRegex?09:03
ivc_were you getting AttributeError on unset option? or was the UT passing when it should not?09:04
ivc_irenab thats about discussion we have on https://review.openstack.org/#/c/42744009:06
irenabivc_, when devstack somehow didn't put one of the expected config values, I think it was subnet_id, the exception messge had failure in it, therefor I fixed the code and added unit test to verify that proper messag eis raised09:09
*** vikasc has joined #openstack-kuryr09:09
ivc_but that was different exception, wasn't it?09:09
irenabmaybe there is better way to verify it, but I though that its good to have unit test that covers for it09:10
ivc_as far as i understand you were getting AttributeError due to group.name access in https://github.com/openstack/oslo.config/blame/master/oslo_config/cfg.py#L53609:10
ivc_so it wasnt RequiredOptError and your added unit test does not test that problem09:10
irenabivc_, it was the exception in the kuryr code, but with failed message, since it failed to build it properly09:11
irenablet me check if I stated it in the bug09:11
*** vikasc has quit IRC09:12
ivc_bug description is rather vague09:13
ivc_https://bugs.launchpad.net/kuryr-kubernetes/+bug/165275609:13
openstackLaunchpad bug 1652756 in kuryr-kubernetes "Incorrect config group parameter in the Default controller drivers" [High,Fix released] - Assigned to Irena Berezovsky (irenab)09:13
irenabyea ..09:14
ivc_if you added logs it might help09:14
irenabagree, sorry I didn't add them09:14
ivc_tho i think the exception was AttributeError09:15
irenabivc_, in a meeting now, will be able to recreate the case in about 30 min09:15
irenabivc_, it was a bit ugly message as far as I remember09:15
ivc_irenab sure. i'm sorry i've missed that fix while i was on vacation. but i'd prefer if we avoid hardcoding exception texts that do not belong to us09:18
irenabivc_, maybe just to check for the attribute or opt_group name and not the whole string09:22
openstackgerritfeng.shengqin proposed openstack/fuxi master: Remove unused _C and _p in i18n.py  https://review.openstack.org/42958609:22
ivc_also the problem you got there was because i misused cfg.RequiredOptError API by passing string instead of OptGroup09:22
irenabindeed, this is what the fixe was for09:23
ivc_so thats not something we need to UT09:23
*** s1061123 has quit IRC09:23
*** s1061123 has joined #openstack-kuryr09:23
*** s1061123 is now known as tohayash09:24
*** tohayash is now known as s106112309:24
*** vikasc has joined #openstack-kuryr09:27
ivc_irenab what i mean is we do not need UT to test the cases where we misuse external APIs09:28
*** salv-orlando has joined #openstack-kuryr09:31
*** s1061123 has quit IRC09:34
*** s1061123 has joined #openstack-kuryr09:35
*** garyloug has joined #openstack-kuryr09:42
openstackgerritfeng.shengqin proposed openstack/fuxi master: Modify comment about FuxiException  https://review.openstack.org/42960609:45
*** s1061123 has quit IRC09:46
*** s1061123 has joined #openstack-kuryr09:46
*** s1061123 has quit IRC09:48
*** s1061123 has joined #openstack-kuryr09:48
*** s1061123 has quit IRC09:49
*** s1061123 has joined #openstack-kuryr09:49
*** neiljerram has joined #openstack-kuryr10:14
*** yamamoto has joined #openstack-kuryr10:45
*** yamamoto has quit IRC10:48
*** yamamoto has joined #openstack-kuryr11:20
*** yedongcan1 has left #openstack-kuryr11:23
*** yamamoto has quit IRC11:31
*** jerms has joined #openstack-kuryr11:35
*** devvesa has joined #openstack-kuryr11:36
*** jerms has quit IRC11:40
*** jerms has joined #openstack-kuryr11:40
openstackgerritfeng.shengqin proposed openstack/fuxi master: Import _ from i18n.py  https://review.openstack.org/42966411:49
*** yamamoto has joined #openstack-kuryr12:04
*** yamamoto has quit IRC12:08
irenabivc_, ping12:17
ivc_irenab pong12:17
*** jerms has quit IRC12:19
irenabjust some thought regarding the service patch. Maybe worth to rename pod_security_groups to something like kuryr_security_groups, so it is less confusing its used both for pods and services12:19
irenabremoved -1 and runnign the setup to verify12:19
openstackgerritLuis Tomas Bolivar proposed openstack/kuryr-kubernetes master: [WIP] Adding pool of ports to speed up containers booting/deletion  https://review.openstack.org/42668712:20
ivc_irenab i thought about it, but kuryr_ prefix or just 'security_groups' are rather vague from the user perspective imo12:20
irenabivc_, agree, just pod is a bit confusing. default?12:21
irenabcluster?12:21
ivc_irenab imo pod_ is the best fit from user perspective12:21
ivc_even tho it maybe a tiny bit confusing from the code perspective12:22
ivc_but i'm not against changing that12:23
irenabI would say that the explanation to the user is what SGs you want to apply on created pod, then pod_sg makes sense12:23
ivc_yup thats my point12:23
irenabbut is its for services and pods, then its a bit wierd12:24
*** jerms has joined #openstack-kuryr12:25
ivc_well the idea was that the user selects sg for pods and the service sg driver just ensures that everything works with that12:25
irenabivc_, if you keep the anem, the help message should be updated12:25
ivc_irenab you see thing is that sg is not for pods and services12:26
ivc_sg is just for pods12:26
irenabivc_, I see your point, services is a side effect12:26
ivc_yup12:26
ivc_well not exactly side effect12:27
*** dougbtv has joined #openstack-kuryr12:27
irenabivc_, then code wise I would probably prefer to use pods driver ..12:27
irenabwell, anyway we have the basic drivers, once evolve into more complicated, can change this12:27
ivc_well you can not use pod driver for service because you do not have pod info when handling service12:28
ivc_and i want our API to provide pod/service info to the driver12:28
irenabivc_, in case of more advanced case, once there is let's say net per namespace and different SGs per namspace, how services driver will get SGs?12:29
ivc_irenab if sg is just per namespace we'll have the same copy-paste pair of drivers12:30
ivc_irenab with pod[namespace] or service[namespace] as key12:30
*** jerms has quit IRC12:33
irenabdon't like the code duplication, but not critical12:33
ivc_irenab i dont like it either, but it keeps API flexible12:34
*** saneax is now known as saneax-_-|AFK12:34
ivc_there's another option12:34
ivc_we can use 'namespace' name as arg instead of passing service/pod to the driver12:34
ivc_that way we'll have just 1 driver12:34
ivc_that will work for the current case and will also work for sg-per-namespace case12:35
*** jerms has joined #openstack-kuryr12:35
ivc_but the problem is if we want a more fine-grained approach (e.g. sg per label or sg per annotation) - we are out of luck12:35
irenabivc_, we may keep the pod and service, but if its None use namespace12:35
ivc_irenab if its None there's no namespace as namespace is part of pod/service data structure12:36
irenabor actually have namespace driver for SG that will be used for both12:36
ivc_irenab duplicating 5 lines of code for a flexible API imo is a fair price12:37
*** salv-orlando has quit IRC12:37
ivc_irenab and you can not have same driver for both Pod and Service SG because they have different base class and we use stevedore to load drivers12:39
irenabivc_, convinced :-)12:40
*** salv-orlando has joined #openstack-kuryr12:40
ivc_irenab :)12:40
irenabivc_, verifing now12:41
*** garyloug has quit IRC12:43
*** limao has joined #openstack-kuryr12:52
*** garyloug has joined #openstack-kuryr12:53
*** janki has quit IRC13:09
*** janki has joined #openstack-kuryr13:09
*** v1k0d3n has joined #openstack-kuryr13:19
*** dims_ has quit IRC13:47
*** dims has joined #openstack-kuryr13:48
*** salv-orl_ has joined #openstack-kuryr13:49
*** salv-orlando has quit IRC13:52
openstackgerritLiping Mao proposed openstack/kuryr-libnetwork master: avoid unnecessary neutron api call in revoke_expose_ports  https://review.openstack.org/42943213:53
*** limao has quit IRC13:54
*** limao has joined #openstack-kuryr13:55
*** yedongcan has joined #openstack-kuryr13:57
*** limao has quit IRC13:58
*** limao has joined #openstack-kuryr13:59
*** devvesa has quit IRC14:03
*** saneax-_-|AFK is now known as saneax14:10
*** devvesa has joined #openstack-kuryr14:19
*** salv-orl_ has quit IRC14:20
openstackgerritMerged openstack/kuryr-kubernetes master: K8s Services support: LBaaSSpecHandler  https://review.openstack.org/42744014:28
*** hongbin has joined #openstack-kuryr14:30
*** gsagie has joined #openstack-kuryr14:52
*** jchhatbar has joined #openstack-kuryr14:57
*** janki has quit IRC14:58
*** yedongcan has quit IRC15:01
*** jchhatbar has quit IRC15:05
*** hongbin has quit IRC15:13
*** garyloug has quit IRC15:21
*** saneax is now known as saneax-_-|AFK15:23
*** v1k0d3n has quit IRC15:26
*** v1k0d3n has joined #openstack-kuryr15:27
*** garyloug has joined #openstack-kuryr15:29
openstackgerritDarla Ahlert proposed openstack/kuryr-libnetwork master: Add reno support to kuryr-libnetwork  https://review.openstack.org/42419815:31
*** limao has quit IRC15:33
*** hongbin has joined #openstack-kuryr15:59
*** limao has joined #openstack-kuryr16:34
*** salv-orlando has joined #openstack-kuryr16:36
*** pcaruana has quit IRC16:38
*** limao has quit IRC16:39
*** gsagie has quit IRC16:47
*** dims has quit IRC17:11
*** dims has joined #openstack-kuryr17:18
*** vikasc has quit IRC17:21
*** devvesa has quit IRC17:28
*** portdirect_away is now known as portdirect17:52
*** pcaruana has joined #openstack-kuryr18:36
*** garyloug has quit IRC18:38
*** pcaruana has quit IRC19:11
*** salv-orlando has quit IRC19:25
*** tonanhngo has joined #openstack-kuryr19:51
*** salv-orlando has joined #openstack-kuryr20:25
*** salv-orlando has quit IRC20:36
*** salv-orlando has joined #openstack-kuryr20:37
*** yamamoto has joined #openstack-kuryr21:06
*** yamamoto has quit IRC21:14
*** yamamoto has joined #openstack-kuryr21:17
*** tonanhngo has quit IRC21:24
*** tonanhngo_ has joined #openstack-kuryr21:24
*** yamamoto has quit IRC21:29
*** yamamoto has joined #openstack-kuryr22:11
openstackgerritHongbin Lu proposed openstack/kuryr-libnetwork master: Consolidate logic of getting pool cidr  https://review.openstack.org/42932922:32
openstackgerritHongbin Lu proposed openstack/kuryr-libnetwork master: Optimize the search of subnet  https://review.openstack.org/42792322:32
openstackgerritHongbin Lu proposed openstack/kuryr master: Update the libnetwork devref  https://review.openstack.org/42664422:37
*** hongbin_ has joined #openstack-kuryr23:25
*** salv-orl_ has joined #openstack-kuryr23:26
*** mchiappe1o has joined #openstack-kuryr23:27
*** salv-orlando has quit IRC23:34
*** hongbin has quit IRC23:34
*** neiljerram has quit IRC23:34
*** mchiappero has quit IRC23:34
*** neiljerram has joined #openstack-kuryr23:40
« Sunday, 2017-02-05 Index Tuesday, 2017-02-07 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!