*** salv-orlando has quit IRC | 00:11 | |
*** hongbin has quit IRC | 00:24 | |
*** saneax-_-|AFK is now known as saneax | 00:24 | |
*** limao has joined #openstack-kuryr | 00:26 | |
apuimedo | ivc_: ping | 00:38 |
---|---|---|
*** tonanhngo has quit IRC | 00:57 | |
ivc_ | apuimedo pong | 01:04 |
*** yedongcan has joined #openstack-kuryr | 01:16 | |
*** tonanhngo has joined #openstack-kuryr | 01:17 | |
*** tonanhngo has quit IRC | 01:22 | |
*** yamamoto has quit IRC | 01:34 | |
*** yamamoto has joined #openstack-kuryr | 01:38 | |
*** yamamoto has quit IRC | 01:43 | |
*** saneax is now known as saneax-_-|AFK | 02:10 | |
*** yedongcan_ has joined #openstack-kuryr | 02:16 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/kuryr master: Remove a py34 environment from tox https://review.openstack.org/416142 | 02:20 |
*** yedongcan_ has quit IRC | 02:31 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/kuryr master: Remove support for py34 https://review.openstack.org/416142 | 02:38 |
*** yamamoto has joined #openstack-kuryr | 02:40 | |
*** yamamoto has quit IRC | 03:01 | |
*** hongbin has joined #openstack-kuryr | 03:51 | |
*** saneax-_-|AFK is now known as saneax | 03:58 | |
*** limao has quit IRC | 04:18 | |
*** limao has joined #openstack-kuryr | 04:18 | |
*** hongbin has quit IRC | 04:27 | |
*** yedongcan1 has joined #openstack-kuryr | 05:09 | |
*** janki has joined #openstack-kuryr | 05:12 | |
*** yedongcan has quit IRC | 05:12 | |
*** tonanhngo has joined #openstack-kuryr | 05:25 | |
*** salv-orlando has joined #openstack-kuryr | 05:45 | |
*** salv-orlando has quit IRC | 05:50 | |
openstackgerrit | Merged openstack/kuryr-kubernetes master: Resolve 'resourceVersion' conflicts https://review.openstack.org/422946 | 06:25 |
*** salv-orlando has joined #openstack-kuryr | 06:46 | |
*** salv-orlando has quit IRC | 06:51 | |
*** salv-orlando has joined #openstack-kuryr | 07:02 | |
*** salv-orl_ has joined #openstack-kuryr | 07:05 | |
*** salv-orlando has quit IRC | 07:09 | |
*** tonanhngo has quit IRC | 07:25 | |
*** pcaruana has joined #openstack-kuryr | 07:29 | |
irenab | apuimedo, hi | 07:29 |
*** david-lyle_ has joined #openstack-kuryr | 07:37 | |
*** devvesa has joined #openstack-kuryr | 07:38 | |
*** devvesa has quit IRC | 07:40 | |
apuimedo | ivc_: For the life of me, I don't remember what I wanted last night | 07:47 |
apuimedo | irenab: hi | 07:47 |
*** salv-orlando has joined #openstack-kuryr | 07:50 | |
*** salv-orl_ has quit IRC | 07:52 | |
*** yamamoto has joined #openstack-kuryr | 07:56 | |
*** yamamoto has quit IRC | 07:56 | |
*** yedongcan has joined #openstack-kuryr | 07:59 | |
*** yedongcan1 has quit IRC | 07:59 | |
*** tonanhngo has joined #openstack-kuryr | 08:03 | |
*** tonanhngo has quit IRC | 08:04 | |
*** salv-orlando has quit IRC | 08:10 | |
openstackgerrit | Merged openstack/fuxi master: Enable Fuxi to use Manila share https://review.openstack.org/375452 | 08:10 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-libnetwork master: Moving from device_owner to tagging https://review.openstack.org/425772 | 08:10 |
apuimedo | yedongcan: did you see my question on https://review.openstack.org/#/c/428002/ | 08:14 |
apuimedo | ? | 08:14 |
yedongcan | apuimedo: I had replied. | 08:16 |
* apuimedo going to look | 08:16 | |
yedongcan | apuimedo: we need "tag-ext" in show_extension, but in app we need "tag_ext". | 08:17 |
yedongcan | apuimedo: thanks. | 08:17 |
openstackgerrit | Merged openstack/kuryr master: Remove support for py34 https://review.openstack.org/416142 | 08:19 |
apuimedo | Got it Thanks | 08:19 |
* apuimedo merging | 08:19 | |
openstackgerrit | Merged openstack/fuxi master: Import _ from i18n.py https://review.openstack.org/429664 | 08:20 |
openstackgerrit | Merged openstack/fuxi master: Sync .gitignore from kuryr-libnetwork https://review.openstack.org/414660 | 08:20 |
*** yamamoto has joined #openstack-kuryr | 08:20 | |
openstackgerrit | Merged openstack/kuryr-libnetwork master: Use Neutron tag-ext extension https://review.openstack.org/428002 | 08:24 |
*** yamamoto has quit IRC | 08:26 | |
*** david-lyle_ has quit IRC | 08:28 | |
*** ltomasbo is now known as ltomasbo|away | 08:44 | |
*** ltomasbo|away is now known as ltomasbo | 08:44 | |
*** salv-orlando has joined #openstack-kuryr | 08:57 | |
openstackgerrit | dengshaolin proposed openstack/fuxi master: Add parameter 'region_name' for novaclient https://review.openstack.org/430658 | 09:00 |
*** garyloug has joined #openstack-kuryr | 09:01 | |
yedongcan | ltomasbo: ping | 09:08 |
ltomasbo | yedongcan, hi! | 09:08 |
yedongcan | ltomasbo: just review your patch: https://review.openstack.org/#/c/425772/, nice work. | 09:09 |
ltomasbo | thanks! | 09:09 |
yedongcan | ltomasbo: just one question, after port created, what's the attribute of device_owner? | 09:10 |
ltomasbo | nothing, is not set | 09:10 |
ltomasbo | if later the port is used as a subport associated to a trunk, it will have trunk:subport | 09:11 |
yedongcan | okay, is there a bug for the inconsistencies attached? | 09:11 |
ltomasbo | do you think we should include something? | 09:11 |
ltomasbo | I filled this one:https://bugs.launchpad.net/neutron/+bug/1657441 | 09:12 |
openstack | Launchpad bug 1657441 in neutron "Remove the set device_owner when attaching subports" [Undecided,New] | 09:12 |
yedongcan | Thanks, I'm ok with nothing | 09:12 |
ltomasbo | I hit that problem for the nested kuryr case | 09:12 |
ltomasbo | where, add_subport was actually changing the device_owner, and then kuryr was not removing the ports after container deletion | 09:13 |
ltomasbo | as the device_owner was not kuryr:container | 09:13 |
ltomasbo | there were some discussions also here: https://review.openstack.org/#/c/419028/3 | 09:14 |
yedongcan | ok, will check. doesn't it support update port's device_owner? | 09:14 |
ltomasbo | yes, we were actually triggering update_port | 09:16 |
ltomasbo | after add_subport | 09:16 |
ltomasbo | with that aim | 09:16 |
ltomasbo | but (as stated in the bug) it seems add_subport also calls update_port | 09:16 |
ltomasbo | due to the patch I wanted to revert in neutron | 09:16 |
ltomasbo | and even if we trigger our update_port after the add_subport | 09:17 |
ltomasbo | it is (some times) executed in the wrong order | 09:17 |
ltomasbo | so, the update_port that applies is the one inside add_subport, leaving the device_owner to trunk:subport | 09:18 |
ltomasbo | instead of kuryr:container | 09:18 |
apuimedo | irenab: http://bofh.nikhef.nl/events/FOSDEM/2017/H.2215/weave_net_npc.mp4 weave talk on performing network policy for kubernetes (haven't seen it yet) | 09:18 |
ltomasbo | could be fixed by waiting, but as we don't reallly needed, it is better to not delay the container booting time (IMO) | 09:18 |
yedongcan | okay, got it. Seems get tag is the proper way. | 09:18 |
ltomasbo | :D | 09:19 |
yedongcan | ltomasbo: thanks. | 09:19 |
apuimedo | ltomasbo: Delaying container boot time is against my religion | 09:22 |
apuimedo | :-) | 09:22 |
ltomasbo | lol | 09:22 |
*** limao has quit IRC | 09:24 | |
irenab | apuimedo, thanks | 09:29 |
irenab | apuimedo, regarding the meeting tomorrow. Any chance to make it 30 mins earlier? | 09:30 |
apuimedo | mmm | 09:30 |
apuimedo | ivc_: vikasc: ltomasbo: does 30min earlier work for you? | 09:30 |
irenab | I may have hard stop after 30 mins | 09:30 |
vikasc | apuimedo, yep | 09:31 |
ltomasbo | would it work 30 minutes later? | 09:31 |
ltomasbo | or 1 hour before? | 09:31 |
apuimedo | ltomasbo: https://review.openstack.org/#/c/425772/ should also be done for kuryr-k8s, shouldn't it? | 09:32 |
apuimedo | ltomasbo: you mean at 13:30? | 09:32 |
apuimedo | cet | 09:32 |
ltomasbo | 15 CET would be perfect | 09:33 |
*** openstackgerrit has quit IRC | 09:34 | |
ltomasbo | but I can handle 14 CET too (if works better for all) | 09:34 |
irenab | 1 hour before yes, but not 30 mins later | 09:34 |
ltomasbo | so, let's go for 14 CET | 09:34 |
irenab | great, thanks | 09:35 |
ltomasbo | apuimedo, regarding the change for kuryr-k8s, yes, agree | 09:35 |
ltomasbo | I'll work on that later too | 09:35 |
irenab | apuimedo, https://docs.google.com/document/d/1TW3P4c8auWwYy-w_5afIPDcGNLK3LZf0m14943eVfVg/edit?ts=58877ea7 | 09:36 |
irenab | proposal for multiple networks support by k8s | 09:36 |
apuimedo | thanks | 09:37 |
*** vikasc has quit IRC | 09:42 | |
*** dims_ has joined #openstack-kuryr | 09:44 | |
*** dims has quit IRC | 09:45 | |
*** devvesa has joined #openstack-kuryr | 09:47 | |
*** vikasc has joined #openstack-kuryr | 09:54 | |
*** yedongcan has left #openstack-kuryr | 10:08 | |
*** yamamoto has joined #openstack-kuryr | 10:17 | |
*** yamamoto has quit IRC | 10:22 | |
*** salv-orlando has quit IRC | 10:49 | |
*** garyloug has quit IRC | 11:05 | |
*** garyloug has joined #openstack-kuryr | 11:05 | |
ltomasbo | irenab, ping | 11:12 |
*** yamamoto has joined #openstack-kuryr | 11:20 | |
*** vikasc has quit IRC | 11:26 | |
*** yamamoto has quit IRC | 11:26 | |
*** limao has joined #openstack-kuryr | 11:33 | |
*** salv-orlando has joined #openstack-kuryr | 11:33 | |
*** vikasc has joined #openstack-kuryr | 11:43 | |
*** limao has quit IRC | 11:50 | |
irenab | ltomasbo: hi | 11:50 |
*** limao has joined #openstack-kuryr | 11:50 | |
ltomasbo | hi | 11:53 |
ltomasbo | irenab, I saw your comments on the device_owner patch | 11:54 |
ltomasbo | the comment about the tag_ext extension | 11:54 |
ltomasbo | does it means the API is changed? | 11:54 |
ltomasbo | I didn't think so | 11:54 |
*** limao has quit IRC | 11:55 | |
ltomasbo | and the other question is about leaving device_owner, I don't have a strong opinion there, but there may be collisions with other components using this field (as the trunk port) | 11:56 |
ltomasbo | so, if we are not going to use it at all, why keep it? | 11:57 |
irenab | ltomasbo: trunk port is a bit unique case, and I am not sure why they set device owner, but for the common bare metal case, device owner should have nova equivalent | 12:05 |
ltomasbo | seems for baremetal (ironic) they are also using this | 12:06 |
ltomasbo | as well as for nova when booting a VM | 12:06 |
ltomasbo | then again, I don't have a strong opinion here, and I don't mind to include it. Though it can break things if other people is relying on that (which they should not) | 12:07 |
irenab | ltomasbo: I also do not have strong opinion on this, just seems proper if the one who creates the port will set the owner | 12:09 |
irenab | Regarding the extensions, check here https://review.openstack.org/#/c/428002/ | 12:09 |
ltomasbo | irenab, I agree with you on that. But armax suggested to not use device_owner | 12:11 |
ltomasbo | and regarding the extension | 12:11 |
ltomasbo | that is to check if the support for subnet/router tagging is available | 12:11 |
ltomasbo | but then, the actual tagging happens with the normal neutron add tag API | 12:11 |
irenab | ltomasbo: you are correct about the extension, just somehow missed the check if the ext of tag is supported | 12:16 |
irenab | regarding the device_owner, I think the advise was not to count on the value to do some logic based on it. Seems there is no proper definition on what is expected from that field | 12:18 |
irenab | but I do not have strong opinion if we should keep it, I tend to keep | 12:19 |
irenab | ltomasbo: check here about the device_owner field http://www.innervoice.in/blogs/2015/07/05/ports-in-openstack-neutron/ | 12:25 |
irenab | looks like to be aligned we should set something like compute:kuryr | 12:26 |
ltomasbo | irenab, ok, I'll keep it and modify it to compute:kuryr | 12:31 |
*** salv-orlando has quit IRC | 12:34 | |
*** yamamoto has joined #openstack-kuryr | 12:35 | |
*** dougbtv has joined #openstack-kuryr | 12:44 | |
*** yamamoto has quit IRC | 12:48 | |
*** devvesa has quit IRC | 13:00 | |
apuimedo | alraddarla: ping | 13:11 |
*** garyloug has quit IRC | 13:17 | |
*** salv-orlando has joined #openstack-kuryr | 13:19 | |
*** saneax is now known as saneax-_-|AFK | 13:32 | |
*** roeyc has joined #openstack-kuryr | 13:33 | |
*** janki has quit IRC | 13:38 | |
*** devvesa has joined #openstack-kuryr | 13:40 | |
*** janki has joined #openstack-kuryr | 13:46 | |
*** mchiappe1o is now known as mchiappero | 13:48 | |
*** yamamoto has joined #openstack-kuryr | 13:49 | |
*** salv-orl_ has joined #openstack-kuryr | 13:50 | |
*** salv-orlando has quit IRC | 13:52 | |
*** yamamoto has quit IRC | 13:55 | |
*** roeyc has quit IRC | 13:56 | |
*** limao has joined #openstack-kuryr | 14:02 | |
alraddarla | apuimedo, hi | 14:05 |
*** limao_ has joined #openstack-kuryr | 14:05 | |
*** limao has quit IRC | 14:06 | |
apuimedo | alraddarla: nevermind. It was one thing about your patch, but I already found out :-) | 14:09 |
alraddarla | apuimedo, okay :) | 14:14 |
alraddarla | Now that https://review.openstack.org/#/c/426644/ is merged I can move the doc to libnetwork? | 14:14 |
apuimedo | alraddarla: yes please! | 14:16 |
apuimedo | :-) | 14:16 |
alraddarla | just that file? | 14:16 |
apuimedo | alraddarla: any devref you see for kuryr-libnetwork | 14:18 |
alraddarla | Okay! There is also a k8 devref...do you want that moved to kuryr-kuberentes while I'm at it? | 14:19 |
alraddarla | apuimedo, https://github.com/openstack/kuryr/blob/master/doc/source/devref/k8s_api_watcher_design.rst link for reference | 14:21 |
*** limao_ has quit IRC | 14:23 | |
*** limao has joined #openstack-kuryr | 14:24 | |
apuimedo | alraddarla: interesting, we have to see if it conflicts 100% with the one in kuryr-kubernetes or if it adds something | 14:24 |
alraddarla | apuimedo, I'll look into it | 14:24 |
*** garyloug has joined #openstack-kuryr | 14:32 | |
apuimedo | thanks alraddarla | 14:33 |
*** devvesa has quit IRC | 14:40 | |
*** limao has quit IRC | 14:45 | |
*** limao has joined #openstack-kuryr | 14:45 | |
apuimedo | ivc_: irenab: ltomasbo: vikasc: so what about tomorrow 12 utc? | 14:50 |
ivc_ | apuimedo i'm ok with that | 14:51 |
ltomasbo | that is 13 CET? | 14:51 |
apuimedo | ltomasbo: indeed | 14:51 |
ltomasbo | works for me! | 14:51 |
apuimedo | ok | 14:53 |
*** tonanhngo has joined #openstack-kuryr | 15:01 | |
*** tonanhngo has quit IRC | 15:02 | |
*** limao has quit IRC | 15:06 | |
*** limao has joined #openstack-kuryr | 15:06 | |
*** saneax-_-|AFK is now known as saneax | 15:25 | |
*** hongbin has joined #openstack-kuryr | 15:26 | |
*** limao_ has joined #openstack-kuryr | 15:27 | |
*** limao has quit IRC | 15:30 | |
*** saneax is now known as saneax-_-|AFK | 15:40 | |
*** limao_ has quit IRC | 15:45 | |
*** janki has quit IRC | 15:49 | |
*** limao has joined #openstack-kuryr | 15:51 | |
*** limao has quit IRC | 16:12 | |
*** limao has joined #openstack-kuryr | 16:13 | |
*** salv-orl_ has quit IRC | 16:19 | |
ltomasbo | apuimedo: I was just checking the use of device_owner in kuryr-k8s | 16:21 |
ltomasbo | it is just set but not used anywhere | 16:21 |
apuimedo | and? | 16:21 |
ltomasbo | so I think we don't need to modify anything there | 16:21 |
apuimedo | ltomasbo: not even for nested? | 16:21 |
ltomasbo | nop | 16:21 |
ltomasbo | I mean, we set it, but we only used it before in kuryr-libnetwork to remove the port | 16:22 |
ltomasbo | but here, we already have the vif.id, so no need to search for the port to delete | 16:23 |
apuimedo | true | 16:25 |
apuimedo | ltomasbo: but the fact is that there's no kuryr mark on subports then | 16:25 |
ivc_ | ltomasbo i was actually considering device_owner for (now lacking) cleanup job | 16:25 |
apuimedo | ivc_: so then we should port over ltomasbo's libnetwork work | 16:25 |
*** saneax-_-|AFK is now known as saneax | 16:26 | |
ltomasbo | I will not remove device_owner anyway | 16:26 |
ltomasbo | so, it is still there | 16:26 |
ltomasbo | the only thing is that it is not used inside kuryr later one | 16:26 |
ltomasbo | s/one/on | 16:26 |
apuimedo | but it will | 16:26 |
apuimedo | :-) | 16:26 |
ivc_ | apuimedo ltomasbo what libnetwork is using? | 16:27 |
ivc_ | instead of device_owner | 16:27 |
apuimedo | ivc_: Ocata introduced tags for everything | 16:27 |
ltomasbo | I'm going to include tags | 16:27 |
ltomasbo | but so far, just the fact that port_name = device_id (in kuryr-libnetwork | 16:27 |
ivc_ | apuimedo ltomasbo did you check how tag lookup is implemented behind the scenes on neutron side? | 16:28 |
apuimedo | ivc_: you mean filtering by tag? | 16:28 |
ivc_ | apuimedo yup | 16:28 |
apuimedo | I did not | 16:28 |
ltomasbo | I think it is not yet there | 16:29 |
ivc_ | is the db query indexed or do they simply do "tag like '%TAG_TEXT%'"? | 16:29 |
ivc_ | if its the latter, than its pretty bad | 16:30 |
apuimedo | I'd bet it's the latter | 16:30 |
*** limao has quit IRC | 16:30 | |
apuimedo | but something that could be improved and likely to be accepted | 16:30 |
*** limao has joined #openstack-kuryr | 16:30 | |
ivc_ | apuimedo i was thinking that we use another approach | 16:31 |
ltomasbo | https://review.openstack.org/#/c/429621/ | 16:31 |
ivc_ | s/use/could use/ | 16:31 |
ivc_ | we could get trunk port by device_owner/device_id | 16:32 |
ivc_ | and that would include the collection of subports | 16:32 |
ivc_ | so the only question if we know device_id of a trunk | 16:32 |
ltomasbo | and what about the baremetal case? | 16:33 |
ltomasbo | https://github.com/openstack/neutron/blob/master/neutron/db/tag_db.py | 16:34 |
apuimedo | ltomasbo: is the trunk port ownership changed? Or only the subports | 16:34 |
apuimedo | ? | 16:34 |
ivc_ | the only problem with device_owner is with sub-ports | 16:34 |
ltomasbo | well, the only we are aware of | 16:34 |
ltomasbo | and there may be others to come | 16:35 |
ltomasbo | I would prefer avoiding device_owner, as it seems there is no consensus on their usage | 16:35 |
ivc_ | ltomasbo ok, from tag_db.py it seems the lookup should be efficient (can only tell for sure after seeing actual db model/query, but even if there are problems, those could be fixed) | 16:37 |
ivc_ | but my point was also about the logic - i.e. we should only delete what we 'own' | 16:39 |
ltomasbo | yes yes, that is already working | 16:40 |
ltomasbo | and there will be a case for tagging and another one without tagging, and from ocata, it should be fine with tagging | 16:41 |
*** limao has quit IRC | 16:42 | |
ivc_ | ltomasbo i mean i'm not too comfortable with us removing ports based on tags rather than device_owner | 16:42 |
ivc_ | what if a user decides to add a tag that would match ours? | 16:42 |
ltomasbo | for the kubernetes case, it will not matter | 16:45 |
ltomasbo | for the libnetwork | 16:45 |
ivc_ | apuimedo suggested that we use libnetwork approach in kuryr-k8s | 16:46 |
ltomasbo | it needs to match subnet_cidr, ip_address and tag name | 16:46 |
*** salv-orlando has joined #openstack-kuryr | 16:54 | |
*** tonanhngo has joined #openstack-kuryr | 16:56 | |
*** tonanhngo has quit IRC | 16:56 | |
*** ivc_ has quit IRC | 17:36 | |
*** ivc_ has joined #openstack-kuryr | 17:38 | |
*** openstackgerrit has joined #openstack-kuryr | 17:39 | |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-libnetwork master: Moving from device_owner to tagging https://review.openstack.org/425772 | 17:39 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/fuxi master: Updated from global requirements https://review.openstack.org/431085 | 17:47 |
*** ltomasbo is now known as ltomasbo|away | 17:52 | |
*** roeyc has joined #openstack-kuryr | 17:54 | |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr master: Change DEVICE_OWNER to make it more Neutron compliant https://review.openstack.org/431091 | 17:55 |
*** portdirect has quit IRC | 18:35 | |
*** janonymous has quit IRC | 18:35 | |
*** sridhar_ram has quit IRC | 18:45 | |
*** tonanhngo has joined #openstack-kuryr | 18:45 | |
*** tonanhngo has quit IRC | 18:47 | |
*** tonanhngo has joined #openstack-kuryr | 18:48 | |
*** garyloug has quit IRC | 19:13 | |
*** roeyc has quit IRC | 19:15 | |
*** saneax is now known as saneax-_-|AFK | 19:15 | |
*** roeyc has joined #openstack-kuryr | 19:16 | |
*** roeyc has quit IRC | 19:29 | |
*** sridhar_ram has joined #openstack-kuryr | 19:39 | |
*** roeyc has joined #openstack-kuryr | 19:42 | |
*** salv-orlando has quit IRC | 19:48 | |
*** tonanhngo has quit IRC | 19:54 | |
*** portdirect has joined #openstack-kuryr | 19:57 | |
*** roeyc has quit IRC | 20:03 | |
*** tonanhngo has joined #openstack-kuryr | 20:08 | |
*** salv-orlando has joined #openstack-kuryr | 20:11 | |
*** janonymous has joined #openstack-kuryr | 20:14 | |
*** pcaruana has quit IRC | 20:43 | |
*** salv-orlando has quit IRC | 20:56 | |
*** salv-orlando has joined #openstack-kuryr | 21:40 | |
*** yamamoto has joined #openstack-kuryr | 22:10 | |
*** dougbtv has quit IRC | 22:40 | |
*** tonanhngo has quit IRC | 23:12 | |
*** ajo has quit IRC | 23:26 | |
*** ajo has joined #openstack-kuryr | 23:27 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!