*** limao has joined #openstack-kuryr | 00:30 | |
openstackgerrit | gecong proposed openstack/kuryr-libnetwork master: Remove support for py34 https://review.openstack.org/449377 | 01:01 |
---|---|---|
openstackgerrit | Ruijing proposed openstack/kuryr-kubernetes master: remove unused devstack settings https://review.openstack.org/447381 | 01:18 |
*** hongbin_ has joined #openstack-kuryr | 01:28 | |
*** yedongcan has joined #openstack-kuryr | 01:33 | |
*** svinota has quit IRC | 01:39 | |
*** limao has quit IRC | 02:36 | |
*** limao_ has joined #openstack-kuryr | 02:36 | |
*** yuanying has quit IRC | 02:58 | |
*** hongbin_ has quit IRC | 03:24 | |
*** limao_ has quit IRC | 04:09 | |
*** limao has joined #openstack-kuryr | 04:10 | |
*** limao has quit IRC | 04:14 | |
*** yuanying has joined #openstack-kuryr | 04:20 | |
*** limao has joined #openstack-kuryr | 04:43 | |
*** janki has joined #openstack-kuryr | 04:53 | |
*** aojea has joined #openstack-kuryr | 06:12 | |
*** aojea has quit IRC | 06:18 | |
*** yedongcan has quit IRC | 06:19 | |
*** yedongcan has joined #openstack-kuryr | 06:26 | |
openstackgerrit | Liping Mao proposed openstack/kuryr-libnetwork master: Kuryr-libnetwork container ssl error in multi-thread https://review.openstack.org/449002 | 06:27 |
*** svinota has joined #openstack-kuryr | 07:04 | |
*** pmannidi has quit IRC | 07:21 | |
*** pmannidi has joined #openstack-kuryr | 07:28 | |
*** pmannidi has quit IRC | 07:32 | |
*** ltomasbo|away is now known as ltomasbo | 07:38 | |
*** kzaitsev_ws has joined #openstack-kuryr | 07:46 | |
*** aojea has joined #openstack-kuryr | 08:18 | |
*** aojea has quit IRC | 08:18 | |
*** aojea has joined #openstack-kuryr | 08:19 | |
openstackgerrit | gecong proposed openstack/kuryr-libnetwork master: Remove support for py34 https://review.openstack.org/449377 | 08:19 |
*** janki has quit IRC | 08:20 | |
kzaitsev_ws | have you folks dug into that privsep issue? I'm looking into it now, but so far it looks like the issue might not be in kuryr-k8s. | 08:45 |
apuimedo | kzaitsev_ws: I haven't had the time yet | 08:46 |
apuimedo | it looks unrelated, but for some reason, for nova-compute dmellado told me it didn't blow up | 08:46 |
apuimedo | and our usage is almost the same | 08:46 |
*** devvesa has joined #openstack-kuryr | 08:54 | |
*** garyloug has joined #openstack-kuryr | 09:09 | |
*** aojea_ has joined #openstack-kuryr | 09:10 | |
*** yuanying has quit IRC | 09:12 | |
*** aojea has quit IRC | 09:12 | |
*** garyloug_ has joined #openstack-kuryr | 09:21 | |
*** garyloug has quit IRC | 09:21 | |
*** limao has quit IRC | 09:21 | |
mchiappero | Hi folks, hi apuimedo, hi irenab, hi ltomasbo | 09:23 |
mchiappero | I have a question on this comment https://review.openstack.org/#/c/440669/3/kuryr_kubernetes/objects/vif.py@23 | 09:23 |
apuimedo | mchiappero: irenab doesn't work Fridays, she does Sundays instead | 09:24 |
mchiappero | oh cool :) | 09:24 |
apuimedo | the comment is from ltomasbo | 09:24 |
mchiappero | I would happy to do the same :) | 09:24 |
apuimedo | ltomasbo: I summon thee | 09:24 |
apuimedo | :D | 09:24 |
ltomasbo | I was a question, but my understanding about OVO | 09:25 |
mchiappero | yes I know but you're probably familiar with oslo versioned objects | 09:25 |
ltomasbo | is that if you modify the object, you should bump the version | 09:25 |
mchiappero | no, it makes sense | 09:25 |
mchiappero | my question is: did we have any realease meanwhile? Is such a change going to break any deployment in production? | 09:26 |
ltomasbo | ahh, that is true too | 09:26 |
mchiappero | I guess supporting both versions would require different codepaths in the CNI driver, which defeats the purpose of the refactoring itself (which is actually good) | 09:26 |
mchiappero | I have some (not yet working) code to share the parent interface logic in the controller side | 09:27 |
mchiappero | so it would be beneficial to have the same shared logic on the CNI side, but my concern is having to unecessarily support different versions | 09:28 |
mchiappero | especially if no one actually started using the previous one | 09:28 |
mchiappero | let me know if you have feedbacks/opinions | 09:28 |
ltomasbo | makes senses | 09:29 |
mchiappero | I've been busy this week, and I'll be next week (as I'll be at KubeCon), but I would like to push at least some of the code I have, that the only big thing I need to address | 09:29 |
mchiappero | I mean push today | 09:30 |
ltomasbo | it is find with me to not increase the version | 09:31 |
mchiappero | is anyone else fine with that? :) | 09:31 |
ltomasbo | as, as you said, it will not break deployments | 09:32 |
ltomasbo | that said, if I got the OVO right | 09:33 |
ltomasbo | the think is that you just need to specify which one to use | 09:33 |
ltomasbo | and it should be ok | 09:33 |
ltomasbo | but I see you changed some code to use that field in the vlan side, so that is your concern, right? | 09:34 |
ltomasbo | so, fine with me | 09:36 |
*** janki has joined #openstack-kuryr | 09:38 | |
*** yedongcan1 has joined #openstack-kuryr | 09:43 | |
*** yedongcan has quit IRC | 09:46 | |
*** yamamoto has quit IRC | 09:50 | |
*** yuanying has joined #openstack-kuryr | 09:54 | |
apuimedo | fine for me too | 09:55 |
*** pcaruana has joined #openstack-kuryr | 10:05 | |
kzaitsev_ws | after digging some logs I stumbled onto 'oslo.privsep.daemon [-] privsep log: root is not in the sudoers file. This incident will be reported.' | 10:07 |
kzaitsev_ws | and after adding 'root ALL=(ALL) NOPASSWD: ALL' | 10:08 |
kzaitsev_ws | the issue is gone for me | 10:08 |
kzaitsev_ws | well not entirelly — I still have that logging issue irenab commented about in the bug | 10:11 |
mchiappero | ok, thanks :) | 10:23 |
mchiappero | guys, what's the story with the localization? I get "Log messages require translation hints!" from pep8, but I saw a change under review claiming translations should no longer be used | 10:40 |
mchiappero | (and I started removing them) | 10:40 |
kzaitsev_ws | mchiappero: there was a letter from i18n team, stating that they no longer want to translate log messages | 10:42 |
kzaitsev_ws | since when you get an error and try to google the log message | 10:43 |
kzaitsev_ws | and it's translated — you severely limit your results | 10:43 |
kzaitsev_ws | I can dig the message if you want | 10:43 |
mchiappero | but pep8 errors will prevent the code to be merged | 10:44 |
mchiappero | I mean, I don't have an opinion, I'm okay with removing the translations, but... | 10:44 |
kzaitsev_ws | can you show me an example? cause I'm pretty sure we merged a similar patch in murano this week | 10:45 |
kzaitsev_ws | not that I like this kind of patches, but... | 10:45 |
mchiappero | maybe I'm misinterpreting pep8 | 10:47 |
mchiappero | ./kuryr_kubernetes/controller/drivers/nested_macvlan_vif.py:87:13: N531 Log messages require translation hints! | 10:47 |
mchiappero | LOG.warning('Unable to release port {} as it no longer ' | 10:48 |
mchiappero | BTW there is an error in the message :D | 10:48 |
mchiappero | just spotted | 10:48 |
mchiappero | oh no, it's ok, never mind | 10:48 |
*** yamamoto has joined #openstack-kuryr | 10:49 | |
*** yamamoto_ has joined #openstack-kuryr | 10:50 | |
mchiappero | of course I have many more, LOG.error and so on | 10:50 |
*** yamamoto has quit IRC | 10:54 | |
kzaitsev_ws | I wonder who adds the check, but it looks like you have a non-standard check registered somewhere | 10:56 |
kzaitsev_ws | https://github.com/openstack/neutron/blob/master/neutron/hacking/checks.py#L90 | 10:56 |
kzaitsev_ws | like this one | 10:56 |
mchiappero | ok, so, it shouldn't complain when pushing to gerrit, right? | 11:01 |
kzaitsev_ws | i don't think so ) | 11:04 |
mchiappero | cool, tnx :) We will soon find out anyway :) | 11:05 |
*** yamamoto_ has quit IRC | 11:05 | |
*** yamamoto has joined #openstack-kuryr | 11:05 | |
*** yamamoto has quit IRC | 11:17 | |
apuimedo | mchiappero: it probably needs a change to hacking | 11:47 |
*** yamamoto has joined #openstack-kuryr | 12:06 | |
*** yamamoto has quit IRC | 12:15 | |
*** dougbtv_ has joined #openstack-kuryr | 12:18 | |
*** yedongcan1 has left #openstack-kuryr | 12:30 | |
*** janki has quit IRC | 12:30 | |
*** dougbtv_ has quit IRC | 12:42 | |
*** dougbtv_ has joined #openstack-kuryr | 12:45 | |
*** dougbtv_ is now known as dougbtv|laptop | 12:46 | |
*** vikasc has quit IRC | 13:12 | |
*** yamamoto has joined #openstack-kuryr | 13:19 | |
kzaitsev_ws | apuimedo: do I understand correctly, that I need https://review.openstack.org/#/c/376045/ is needed for k8s's service virtual IPs and kube-proxy implementation? | 13:33 |
apuimedo | kzaitsev_ws: yes. You need that patch, otherwise services won't get fully translated to neutron-lbaasv2 | 13:35 |
apuimedo | kzaitsev_ws: make sure that kube-proxy doesn't run | 13:35 |
kzaitsev_ws | oh, so that patch makes kuryr-k8s take place of kube-proxy then | 13:37 |
kzaitsev_ws | I wonder if Ilya is still around. looks like he's not actively working on it at the moment =( | 13:38 |
apuimedo | kzaitsev_ws: he is when he has time | 13:38 |
apuimedo | which is not often these days | 13:38 |
kzaitsev_ws | I should see if I would be able to help out with the patch. It feels pretty much obligatory to have it in. | 13:43 |
apuimedo | kzaitsev_ws: aboslutely obligatory | 13:49 |
*** vikasc has joined #openstack-kuryr | 14:05 | |
apuimedo | kzaitsev_ws: We're also looking at moving to using octavia | 14:27 |
*** hongbin has joined #openstack-kuryr | 14:37 | |
*** pcaruana has quit IRC | 16:03 | |
*** kzaitsev_ws has quit IRC | 16:20 | |
*** mattmceuen has joined #openstack-kuryr | 16:24 | |
*** devvesa has quit IRC | 16:42 | |
*** aojea_ has quit IRC | 16:56 | |
*** yamamoto has quit IRC | 17:19 | |
*** ltomasbo is now known as ltomasbo|away | 17:45 | |
*** yamamoto has joined #openstack-kuryr | 17:56 | |
*** ltomasbo|away is now known as ltomasbo | 17:56 | |
*** ltomasbo is now known as ltomasbo|away | 18:07 | |
*** yamamoto has quit IRC | 18:19 | |
*** tonanhngo has joined #openstack-kuryr | 19:09 | |
*** tonanhngo has quit IRC | 19:09 | |
*** yamamoto has joined #openstack-kuryr | 19:17 | |
*** tonanhngo has joined #openstack-kuryr | 19:19 | |
*** yamamoto has quit IRC | 19:25 | |
*** kzaitsev_mb has joined #openstack-kuryr | 19:43 | |
*** aojea has joined #openstack-kuryr | 20:18 | |
*** yamamoto has joined #openstack-kuryr | 20:23 | |
*** yamamoto has quit IRC | 20:33 | |
*** dougbtv|laptop has quit IRC | 20:35 | |
*** aojea has quit IRC | 21:06 | |
*** kzaitsev_mb has quit IRC | 21:11 | |
*** mattmceuen has quit IRC | 21:18 | |
*** aojea has joined #openstack-kuryr | 21:22 | |
*** kzaitsev_mb has joined #openstack-kuryr | 21:25 | |
*** kzaitsev_mb has quit IRC | 21:34 | |
*** kzaitsev_mb has joined #openstack-kuryr | 22:00 | |
*** kzaitsev_mb has quit IRC | 22:12 | |
*** tonanhngo has quit IRC | 22:30 | |
*** svinota has quit IRC | 22:35 | |
*** kzaitsev_mb has joined #openstack-kuryr | 22:38 | |
openstackgerrit | Hongbin Lu proposed openstack/fuxi master: [WIP] Add fullstack test for manila provider https://review.openstack.org/449833 | 22:38 |
*** kzaitsev_mb has quit IRC | 22:43 | |
*** apuimedo has quit IRC | 22:45 | |
*** aojea has quit IRC | 22:59 | |
openstackgerrit | Hongbin Lu proposed openstack/fuxi master: [WIP] Add fullstack test for manila provider https://review.openstack.org/449833 | 23:11 |
*** hongbin has quit IRC | 23:28 | |
*** tonanhngo has joined #openstack-kuryr | 23:30 | |
*** tonanhngo has quit IRC | 23:34 | |
*** kzaitsev_mb has joined #openstack-kuryr | 23:41 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!