| *** tonanhngo has quit IRC | 00:08 | |
| *** tonanhngo has joined #openstack-kuryr | 00:26 | |
| *** tonanhngo has quit IRC | 00:30 | |
| *** tonanhngo has joined #openstack-kuryr | 00:33 | |
| *** tonanhngo_ has joined #openstack-kuryr | 00:35 | |
| *** tonanhngo has quit IRC | 00:37 | |
| *** tonanhngo_ has quit IRC | 00:39 | |
| *** limao has joined #openstack-kuryr | 00:52 | |
| *** hongbin has joined #openstack-kuryr | 01:36 | |
| vikasc | apuimedo, recording link please :) | 03:40 |
|---|---|---|
| *** jayahn has joined #openstack-kuryr | 03:41 | |
| *** limao has quit IRC | 04:07 | |
| *** jayahn has quit IRC | 04:12 | |
| *** limao has joined #openstack-kuryr | 04:16 | |
| *** salv-orlando has joined #openstack-kuryr | 04:19 | |
| *** limao has quit IRC | 04:20 | |
| *** salv-orlando has quit IRC | 04:23 | |
| *** hongbin has quit IRC | 04:32 | |
| *** salv-orlando has joined #openstack-kuryr | 04:33 | |
| *** pmannidi has quit IRC | 05:02 | |
| *** pmannidi has joined #openstack-kuryr | 05:04 | |
| *** limao has joined #openstack-kuryr | 05:15 | |
| *** aojea has joined #openstack-kuryr | 05:21 | |
| openstackgerrit | Merged openstack/kuryr-kubernetes master: Remove subunit-trace fork https://review.openstack.org/454294 | 05:22 |
| *** janki has joined #openstack-kuryr | 05:26 | |
| *** aojea has quit IRC | 05:39 | |
| *** tonanhngo has joined #openstack-kuryr | 06:10 | |
| *** salv-orlando has quit IRC | 06:12 | |
| *** pcaruana has joined #openstack-kuryr | 06:40 | |
| *** dimak_ has joined #openstack-kuryr | 06:46 | |
| *** yedongcan has joined #openstack-kuryr | 06:53 | |
| *** pmannidi has quit IRC | 06:54 | |
| *** pmannidi has joined #openstack-kuryr | 06:57 | |
| *** tonanhngo_ has joined #openstack-kuryr | 07:03 | |
| *** tonanhngo has quit IRC | 07:04 | |
| *** jchhatbar has joined #openstack-kuryr | 07:07 | |
| *** janki has quit IRC | 07:09 | |
| *** salv-orlando has joined #openstack-kuryr | 07:11 | |
| *** yedongcan has quit IRC | 07:16 | |
| *** yedongcan has joined #openstack-kuryr | 07:16 | |
| *** aojea has joined #openstack-kuryr | 07:16 | |
| *** aojea has quit IRC | 07:18 | |
| *** aojea has joined #openstack-kuryr | 07:18 | |
| *** ltomasbo|away is now known as ltomasbo | 07:21 | |
| *** jchhatbar_ has joined #openstack-kuryr | 07:35 | |
| *** jchhatbar has quit IRC | 07:38 | |
| *** egonzalez has joined #openstack-kuryr | 07:39 | |
| *** jchhatbar_ has quit IRC | 07:42 | |
| *** jchhatbar_ has joined #openstack-kuryr | 07:42 | |
| *** garyloug has joined #openstack-kuryr | 08:39 | |
| kzaitsev_ws | oh. I missed the meeting =( | 08:40 |
| kzaitsev_ws | I thought you transfered it to today | 08:40 |
| apuimedo | vikasc: ping | 08:41 |
| kzaitsev_ws | apuimedo: +1 to irenab's request for a meeting recording | 08:42 |
| kzaitsev_ws | sorry I mixed the dates =/ | 08:42 |
| vikasc | apuimedo, pong | 08:43 |
| *** jchhatbar has joined #openstack-kuryr | 08:44 | |
| dmellado | kzaitsev_ws: it got recorded in any case ;) | 08:45 |
| dmellado | but maybe we can do a follow-up | 08:45 |
| *** jchhatbar_ has quit IRC | 08:46 | |
| irenab | dmellado, +1 on follow-up | 08:57 |
| *** salv-orlando has quit IRC | 09:13 | |
| *** yedongcan1 has joined #openstack-kuryr | 09:16 | |
| *** yedongcan has quit IRC | 09:16 | |
| *** limao has quit IRC | 09:24 | |
| openstackgerrit | selvakumar proposed openstack/kuryr-kubernetes master: K8s service delete does not delete load balancer https://review.openstack.org/458413 | 09:26 |
| *** limao has joined #openstack-kuryr | 09:28 | |
| *** aojea has quit IRC | 10:08 | |
| *** limao has quit IRC | 10:18 | |
| *** aojea has joined #openstack-kuryr | 10:22 | |
| mchiappero | call for review :P https://review.openstack.org/#/c/440669/ | 10:23 |
| dmellado | mchiappero: I know, my fault | 10:24 |
| dmellado | will review by today, I promise! | 10:24 |
| dmellado | xD | 10:24 |
| irenab | mchiappero, you posted that you do not plan to update for now | 10:25 |
| mchiappero | I need to know what is going to be accepted | 10:29 |
| mchiappero | we cannot afford to change code, update the UT and have to change again | 10:29 |
| mchiappero | ok, probably the wording wasn't the best one.. I meant I'm waiting for you folks to make a decision | 10:34 |
| *** aojea has quit IRC | 10:39 | |
| irenab | mchiappero, got it, sounds reasonable | 10:43 |
| irenab | apuimedo, can you provide short summary on yesterday's discussion? | 10:43 |
| *** aojea has joined #openstack-kuryr | 10:47 | |
| *** yedongcan has joined #openstack-kuryr | 10:49 | |
| kzaitsev_ws | apuimedo: just a reminder that you wnated to make an intermediate release of kuryr-k8s =) | 10:50 |
| kzaitsev_ws | I can make a commit if you like, but you would need to +1 it | 10:51 |
| ivc | mchiappero i think you missed the point of that kwargs comment. i suggested that instead of using kwargs.get(...) in 'implementation' we could validate kwargs in our driver proxy (neutron_to_osvif_vif) | 10:51 |
| kzaitsev_ws | oh | 10:51 |
| kzaitsev_ws | and I need to update pike goals commit | 10:51 |
| *** yedongcan1 has quit IRC | 10:53 | |
| *** tonanhngo has joined #openstack-kuryr | 10:53 | |
| *** tonanhngo_ has quit IRC | 10:54 | |
| ivc | mchiappero but i'd prefer if we follow the stevedore approach. that vif_plugin belongs to kuryr namespace and (by coincedense... sort of) had the same name as the os-vif plugin which is really misleading. instead of driver calling neutron_to_osvif_vif(vif_plugin='noop', nested_type='macvlan') it should be neutron_to_osvif_vif(vif_plugin='macvlan') | 10:55 |
| ivc | mchiappero and when you construct the os-vif object, your 'macvlan' vif_plugin (kuryr_kubernetes.vif_translators stevedore namespace) will set os-vif object's plugin to 'noop' (os_vif stevedore namespace) | 10:57 |
| ivc | mchiappero and that vif_plugin means vif_translator_plugin, not os-vif plugin | 10:57 |
| apuimedo | kzaitsev_ws: I made the release | 10:59 |
| apuimedo | kzaitsev_ws: https://tarballs.openstack.org/kuryr-kubernetes/ | 11:00 |
| apuimedo | irenab: right. I'll send an email with a summary | 11:00 |
| kzaitsev_ws | oh, cool | 11:04 |
| mchiappero | ivc: I've already replied to this | 11:10 |
| mchiappero | ivc: I don't fully understand what you mean by 'validate kwargs in our driver | 11:11 |
| mchiappero | ' | 11:11 |
| ivc | mchiappero yes i got it and thus i messaged you on irc :) | 11:12 |
| mchiappero | and the purpuse of that: implementation specific parameters should be read and validated in the implementation | 11:12 |
| mchiappero | or | 11:12 |
| ivc | mchiappero i'm on a meeting atm. lets discuss in ~45 minutes | 11:13 |
| mchiappero | remove implementation specific parameters by removing the unnecessary decoupling (which seems to me it's not really needed). As for os-vif, following your changes, my question is: should it be set in the translator functions or in the driver (as it used to be)? | 11:14 |
| mchiappero | ivc: ok :) I might be away by the time but I'll definitely catch up | 11:22 |
| *** openstackgerrit has quit IRC | 11:32 | |
| *** yedongcan has left #openstack-kuryr | 11:35 | |
| *** gsagie has joined #openstack-kuryr | 12:10 | |
| *** alraddarla_ has joined #openstack-kuryr | 12:23 | |
| *** salv-orlando has joined #openstack-kuryr | 12:35 | |
| *** gsagie has quit IRC | 12:49 | |
| *** alraddarla_ has quit IRC | 12:59 | |
| *** limao has joined #openstack-kuryr | 13:33 | |
| *** limao has quit IRC | 13:38 | |
| *** limao has joined #openstack-kuryr | 13:39 | |
| *** vikasc has quit IRC | 13:54 | |
| *** vikasc has joined #openstack-kuryr | 13:56 | |
| *** alraddarla_ has joined #openstack-kuryr | 14:04 | |
| *** jchhatbar has quit IRC | 14:04 | |
| *** alraddarla_ has quit IRC | 14:11 | |
| *** alraddarla_ has joined #openstack-kuryr | 14:12 | |
| *** alraddarla_ has quit IRC | 14:16 | |
| *** alraddarla_ has joined #openstack-kuryr | 14:16 | |
| *** alraddarla has quit IRC | 14:17 | |
| *** alraddarla_ has quit IRC | 14:18 | |
| *** alraddarla has joined #openstack-kuryr | 14:18 | |
| *** alraddarla_ has joined #openstack-kuryr | 14:26 | |
| ivc | mchiappero i think decoupling is really necessary. macvlan and trunk are 2 different configurations and should be separated if possible. if we have 2 different translators ('trunk' and 'macvlan') both of them can still use os-vif plugin='noop'. os-vif plugin and translator 'plugin'. | 14:39 |
| ivc | mchiappero so the changes that i would expect are: | 14:40 |
| ivc | 1) rename current 'noop' _translator_ (not the os-vif plugin!) to 'trunk' | 14:40 |
| ivc | 2) rename the corresponding translator function (add '_trunk' suffix) | 14:40 |
| ivc | 3) introduce new macvlan = neutron_to_osvif_vif_macvlan translator (in os_vif_util.py and setup.cfg) | 14:41 |
| ivc | 4) the macvlan driver (nested_macvlan_vif.py) should use vif_plugin = const.K8S_OS_VIF_MACVLAN_PLUGIN instead | 14:42 |
| ivc | 5) and const.K8S_OS_VIF_NOOP_PLUGIN to be renamed to vif_plugin = const.K8S_OS_VIF_TRUNK_PLUGIN | 14:42 |
| ivc | 6) maybe replace _PLUGIN with _TRANSLATOR and rename vif_plugin to vif_translator in os_vif_util.py to avoid further confusion | 14:43 |
| ivc | mchiappero but there is also another option of refactoring the VIF driver <-> translator relationship (i.e. scrapping translators altogether and moving the responsibility to the VIF driver itself) | 14:47 |
| *** dimak_ has quit IRC | 15:03 | |
| *** hongbin has joined #openstack-kuryr | 15:13 | |
| *** pcaruana has quit IRC | 15:14 | |
| mchiappero | ivc: you replied with obvious information but haven't answered my question yet | 15:29 |
| ivc | mchiappero can you repeat the question then? :) | 15:30 |
| mchiappero | translators can still be there, but the stevedore mechanism can definitely be remove | 15:30 |
| mchiappero | *removed | 15:30 |
| mchiappero | I need to go now, I'll reply later | 15:31 |
| ivc | without stevedore, how do you propose to implement it? as a huge if-else chain? or as a lookup-dict of translators? or something else? | 15:32 |
| ivc | mchiappero also consider that while your macvlan driver is indeed tied to a very specific translator, there is also a case of non-nested drivers (i.e. generic vif) | 15:33 |
| *** alraddarla has quit IRC | 15:43 | |
| *** alraddarla has joined #openstack-kuryr | 15:44 | |
| *** salv-orl_ has joined #openstack-kuryr | 15:49 | |
| *** salv-orlando has quit IRC | 15:51 | |
| *** aojea has quit IRC | 15:52 | |
| *** egonzalez has quit IRC | 16:02 | |
| *** tonanhngo has quit IRC | 16:08 | |
| *** openstackgerrit has joined #openstack-kuryr | 16:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-kubernetes master: Updated from global requirements https://review.openstack.org/455931 | 16:18 |
| *** limao has quit IRC | 16:21 | |
| *** garyloug has quit IRC | 16:44 | |
| *** vikasc has quit IRC | 16:50 | |
| *** vikasc has joined #openstack-kuryr | 17:06 | |
| *** tonanhngo has joined #openstack-kuryr | 17:13 | |
| *** aojea has joined #openstack-kuryr | 17:17 | |
| *** tonanhngo has quit IRC | 17:17 | |
| *** tonanhngo has joined #openstack-kuryr | 17:17 | |
| *** ltomasbo is now known as ltomasbo|away | 17:17 | |
| *** aojea has quit IRC | 17:22 | |
| *** kzaitsev_ws has quit IRC | 17:36 | |
| *** aojea has joined #openstack-kuryr | 17:37 | |
| *** aojea has quit IRC | 17:42 | |
| *** salv-orl_ has quit IRC | 17:44 | |
| *** salv-orlando has joined #openstack-kuryr | 17:44 | |
| *** alraddarla has quit IRC | 17:50 | |
| *** alraddarla has joined #openstack-kuryr | 17:54 | |
| *** salv-orlando has quit IRC | 18:06 | |
| *** tonanhngo has quit IRC | 19:01 | |
| *** salv-orlando has joined #openstack-kuryr | 19:41 | |
| *** salv-orlando has quit IRC | 20:01 | |
| *** aojea has joined #openstack-kuryr | 20:06 | |
| *** salv-orlando has joined #openstack-kuryr | 20:09 | |
| *** aojea has quit IRC | 20:10 | |
| *** aojea_ has joined #openstack-kuryr | 20:27 | |
| *** aojea_ has quit IRC | 20:31 | |
| *** aojea has joined #openstack-kuryr | 20:46 | |
| *** aojea has quit IRC | 20:51 | |
| *** tonanhngo has joined #openstack-kuryr | 20:55 | |
| *** tonanhngo has quit IRC | 20:59 | |
| *** alraddarla has quit IRC | 21:06 | |
| *** salv-orl_ has joined #openstack-kuryr | 21:49 | |
| *** salv-orlando has quit IRC | 21:51 | |
| *** limao has joined #openstack-kuryr | 22:03 | |
| *** tonanhngo has joined #openstack-kuryr | 22:08 | |
| *** tonanhngo has quit IRC | 22:10 | |
| *** salv-orl_ has quit IRC | 22:22 | |
| *** salv-orlando has joined #openstack-kuryr | 22:23 | |
| *** salv-orlando has quit IRC | 22:27 | |
| *** limao has quit IRC | 23:23 | |
| *** salv-orlando has joined #openstack-kuryr | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!