| *** limao has joined #openstack-kuryr | 00:26 | |
| hongbin | limao: hey, waiting for you :) | 00:32 |
|---|---|---|
| *** neiljerram has quit IRC | 00:32 | |
| limao | Hi hongbin | 00:33 |
| hongbin | limao: have a chance to review this: https://review.openstack.org/#/c/461832/ , it shoudl fix the gate | 00:33 |
| limao | hongbin: checking it now | 00:33 |
| hongbin | limao: ack | 00:34 |
| hongbin | fyi, the gate is breaking because devstack switch to systemd now, so it requires an absolute path for command | 00:35 |
| hongbin | here is the failure: https://review.openstack.org/#/c/461376/ | 00:35 |
| limao | hongbin: thanks for the info, checking | 00:35 |
| limao | hongbin: LGTM, thanks for this, let me get it merged | 00:37 |
| hongbin | limao: thx | 00:38 |
| openstackgerrit | Merged openstack/kuryr-libnetwork master: Use absoluted path for command https://review.openstack.org/461832 | 00:42 |
| *** yamamoto has joined #openstack-kuryr | 00:57 | |
| openstackgerrit | Liping Mao proposed openstack/kuryr-libnetwork master: Kuryr-libnetwork Docker managed plugin https://review.openstack.org/449038 | 00:59 |
| *** yamamoto has quit IRC | 01:05 | |
| *** yedongcan has joined #openstack-kuryr | 01:39 | |
| openstackgerrit | Hongbin Lu proposed openstack/kuryr-libnetwork master: [WIP] Move to devstack-plugin-container https://review.openstack.org/461210 | 01:52 |
| openstackgerrit | Hongbin Lu proposed openstack/fuxi master: Use absoluted path for command https://review.openstack.org/461956 | 02:17 |
| openstackgerrit | Hongbin Lu proposed openstack/fuxi master: Mova to devstack-plugin-container https://review.openstack.org/461212 | 02:19 |
| openstackgerrit | Hongbin Lu proposed openstack/fuxi master: Remove the usage of tox command in devstack https://review.openstack.org/461965 | 02:41 |
| *** janki has joined #openstack-kuryr | 02:55 | |
| *** hongbin has quit IRC | 02:59 | |
| *** jchhatbar has joined #openstack-kuryr | 03:49 | |
| *** janki has quit IRC | 03:52 | |
| *** salv-orlando has joined #openstack-kuryr | 04:18 | |
| *** salv-orlando has quit IRC | 04:23 | |
| *** jchhatbar is now known as janki | 04:30 | |
| *** aojea has joined #openstack-kuryr | 04:36 | |
| *** aojea has quit IRC | 04:40 | |
| *** salv-orlando has joined #openstack-kuryr | 04:49 | |
| *** aojea has joined #openstack-kuryr | 05:14 | |
| *** salv-orl_ has joined #openstack-kuryr | 05:46 | |
| *** ltomasbo|away is now known as ltomasbo | 05:47 | |
| *** salv-orlando has quit IRC | 05:49 | |
| *** salv-orl_ has quit IRC | 05:50 | |
| *** aojea has quit IRC | 05:52 | |
| *** limao has quit IRC | 05:55 | |
| *** limao has joined #openstack-kuryr | 05:55 | |
| *** limao has quit IRC | 05:56 | |
| *** limao has joined #openstack-kuryr | 06:00 | |
| *** limao has quit IRC | 06:06 | |
| *** limao has joined #openstack-kuryr | 06:24 | |
| *** pcaruana has joined #openstack-kuryr | 06:27 | |
| irenab | limao, hi | 06:35 |
| ltomasbo | good morning! | 06:41 |
| ltomasbo | apuimedo, irenab, ivc_, vikasc, could you take a look at the ports pool patches (and the updated devref) | 06:42 |
| irenab | ltomasbo, good morning | 06:43 |
| ltomasbo | good morning irenab | 06:43 |
| irenab | ltomasbo, its on my todo list for today | 06:43 |
| ltomasbo | great! thanks! | 06:43 |
| *** limao has quit IRC | 06:48 | |
| *** kzaitsev_ws has joined #openstack-kuryr | 07:19 | |
| *** aojea has joined #openstack-kuryr | 07:23 | |
| *** salv-orlando has joined #openstack-kuryr | 07:38 | |
| *** salv-orlando has quit IRC | 07:46 | |
| *** egonzalez has joined #openstack-kuryr | 07:47 | |
| *** limao has joined #openstack-kuryr | 07:50 | |
| *** garyloug has joined #openstack-kuryr | 07:50 | |
| limao | irenab: Hi | 07:51 |
| openstackgerrit | Liping Mao proposed openstack/kuryr-libnetwork master: Update Kuryr-libnetwork Docker managed plugin related doc https://review.openstack.org/451479 | 07:52 |
| *** oanson has quit IRC | 07:52 | |
| *** irenab has quit IRC | 07:53 | |
| *** oanson has joined #openstack-kuryr | 07:53 | |
| *** irenab has joined #openstack-kuryr | 07:53 | |
| *** neiljerram has joined #openstack-kuryr | 08:04 | |
| *** salv-orlando has joined #openstack-kuryr | 08:05 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Adding support for vif pool driver https://review.openstack.org/436875 | 08:16 |
| *** garyloug_ has joined #openstack-kuryr | 08:24 | |
| *** garyloug has quit IRC | 08:24 | |
| irenab | limao, I was checking the https://review.openstack.org/#/c/449038/ | 08:44 |
| limao | Hi irenab | 08:44 |
| irenab | The network got created ok, but whiule creating container, I got the error as in here: http://paste.openstack.org/show/608667/ | 08:45 |
| irenab | I wonder if this worked for you | 08:45 |
| limao | irenab: Can you check if your bindir is /usr/libexec/kuryr in /etc/kuryr/kuryr.conf ? | 08:48 |
| limao | irenab: I build it locally, and use my ansible to deploy it in my nested-vm, it works for me in that case. | 08:49 |
| *** salv-orlando has quit IRC | 08:56 | |
| *** neiljerram has quit IRC | 09:06 | |
| *** yamamoto has joined #openstack-kuryr | 09:07 | |
| *** yamamoto has quit IRC | 09:11 | |
| *** limao has quit IRC | 09:20 | |
| *** salv-orlando has joined #openstack-kuryr | 10:06 | |
| *** oanson has quit IRC | 10:19 | |
| *** oanson has joined #openstack-kuryr | 10:21 | |
| *** salv-orlando has quit IRC | 10:30 | |
| *** neiljerram has joined #openstack-kuryr | 10:36 | |
| *** pcaruana has quit IRC | 11:53 | |
| *** pcaruana has joined #openstack-kuryr | 11:57 | |
| *** yedongcan has quit IRC | 12:05 | |
| *** yedongcan has joined #openstack-kuryr | 12:06 | |
| *** yedongcan has left #openstack-kuryr | 12:07 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/fuxi master: Updated from global requirements https://review.openstack.org/454474 | 12:12 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr master: Updated from global requirements https://review.openstack.org/462106 | 12:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr-libnetwork master: Updated from global requirements https://review.openstack.org/461376 | 12:14 |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Adding support for vif pool driver https://review.openstack.org/436875 | 12:44 |
| *** salv-orlando has joined #openstack-kuryr | 13:25 | |
| *** ltomasbo is now known as ltomasbo|away | 13:33 | |
| *** ltomasbo|away is now known as ltomasbo | 13:36 | |
| *** irenab has quit IRC | 13:45 | |
| *** irenab has joined #openstack-kuryr | 13:46 | |
| *** janki has quit IRC | 13:53 | |
| *** irenab has quit IRC | 13:55 | |
| *** irenab has joined #openstack-kuryr | 13:57 | |
| irenab | dmellado: | 14:15 |
| irenab | hi | 14:15 |
| dmellado | hey irenab | 14:15 |
| irenab | I | 14:15 |
| dmellado | how're you doing? ;) | 14:15 |
| irenab | I heard from apuimedo that you are checking the failure at the gate | 14:15 |
| irenab | I wonder if its not related to the systemd usage | 14:16 |
| dmellado | Basically it happens when it runs on OSIC (IPv6 only) cloud | 14:17 |
| dmellado | so it's like a cloudroulette, as I stated on the bug | 14:17 |
| dmellado | irenab: did you check my bz? | 14:17 |
| dmellado | bz/launchpad | 14:17 |
| irenab | ++ functions-common:_run_under_systemd:1497 : sudo systemctl start devstack@docker.service | 14:17 |
| irenab | http://logs.openstack.org/75/436875/8/check/gate-install-dsvm-default-kuryr-kubernetes/7e2585f/logs/devstacklog.txt.gz#_2017-05-03_12_54_47_938 | Failed to start devstack@docker.service: Unit devstack@docker.service is not loaded properly: Invalid argument. | 14:17 |
| irenab | tl status devstack@docker.servibz? | 14:17 |
| irenab | bz? | 14:17 |
| dmellado | I meant launchpad | 14:18 |
| dmellado | let me get you the link | 14:18 |
| *** openstackgerrit has quit IRC | 14:18 | |
| dmellado | https://bugs.launchpad.net/kuryr-kubernetes/+bug/1687054 | 14:21 |
| openstack | Launchpad bug 1687054 in kuryr-kubernetes "upstream CI fails randomly with POST_FAILURE error" [Undecided,New] - Assigned to Daniel Mellado (daniel-mellado) | 14:21 |
| dmellado | irenab: so basically I don't understand how dsvm-kuryr-k8s can disable these services | 14:23 |
| dmellado | * net.ipv6.conf.all.disable_ipv6 | 14:23 |
| dmellado | * net.ipv6.conf.default.disable_ipv6 | 14:23 |
| dmellado | I'm trying to deploy a local ipv6 dsvm and check what's going on | 14:23 |
| dmellado | but I'm wondering if this was triggered by an infra change | 14:24 |
| dmellado | I'm waiting for the osic infra guy to come online to check | 14:24 |
| dmellado | irenab: actually, I'm speaking with him now | 14:28 |
| dmellado | will sync with you after it, or I can have him join the channel if you want to follow up ;) | 14:28 |
| dmellado | irenab: I got access to OSIC tenant | 14:38 |
| dmellado | so I'll try to deploy this and check | 14:38 |
| *** alraddarla_ has joined #openstack-kuryr | 14:43 | |
| *** salv-orl_ has joined #openstack-kuryr | 14:53 | |
| *** salv-orlando has quit IRC | 14:56 | |
| *** hongbin has joined #openstack-kuryr | 15:13 | |
| *** salv-orl_ has quit IRC | 15:18 | |
| *** salv-orlando has joined #openstack-kuryr | 15:18 | |
| *** ltomasbo is now known as ltomasbo|away | 15:43 | |
| *** dougbtv has quit IRC | 15:54 | |
| *** egonzalez has quit IRC | 16:03 | |
| *** pcaruana has quit IRC | 16:24 | |
| *** alraddarla_ has quit IRC | 16:27 | |
| *** vikasc has quit IRC | 16:44 | |
| mchiappero | what do you think about moving the private methods of GenericPodVIFDriver to a skeleton class? | 16:59 |
| mchiappero | and have nested drivers derive from that rather than from Generic? | 17:00 |
| *** kzaitsev_ws has quit IRC | 17:22 | |
| *** aojea has quit IRC | 17:36 | |
| *** hongbin has quit IRC | 17:55 | |
| *** egonzalez has joined #openstack-kuryr | 18:05 | |
| *** salv-orlando has quit IRC | 18:12 | |
| *** hongbin has joined #openstack-kuryr | 18:59 | |
| *** hongbin has quit IRC | 19:06 | |
| *** hongbin has joined #openstack-kuryr | 19:07 | |
| *** salv-orlando has joined #openstack-kuryr | 19:41 | |
| *** garyloug has joined #openstack-kuryr | 19:48 | |
| *** garyloug_ has quit IRC | 19:48 | |
| apuimedo | mchiappero: I'd rather they didn't derive | 19:51 |
| apuimedo | I usually don't like inheritance | 19:51 |
| apuimedo | (unless we're talking about real state or money) | 19:51 |
| *** salv-orl_ has joined #openstack-kuryr | 20:56 | |
| *** salv-orlando has quit IRC | 20:59 | |
| mchiappero | apuimedo: so would a util file okay with you? | 21:11 |
| mchiappero | nested drivers already derive from Generic | 21:11 |
| apuimedo | a util file? | 21:12 |
| *** hongbin has quit IRC | 21:12 | |
| mchiappero | for common code | 21:12 |
| *** hongbin has joined #openstack-kuryr | 21:12 | |
| mchiappero | vlan and macvlan share a method | 21:13 |
| mchiappero | plus some more with Generic (and indeed derive from it) | 21:13 |
| apuimedo | with saying that I'd rather they don't derive. I don't mean you shouldn't | 21:15 |
| apuimedo | I don't want you to have to rewrite it | 21:15 |
| apuimedo | because of my taste ;-) | 21:16 |
| apuimedo | I meant that in general, I prefer to find the code together in the module | 21:16 |
| apuimedo | and not to have to go hunting around | 21:16 |
| apuimedo | I specially hate mixins | 21:16 |
| apuimedo | those I don't merge | 21:16 |
| mchiappero | I'm ok with changing even though I have the code already | 21:16 |
| mchiappero | but the alternative is a utils file | 21:16 |
| mchiappero | I'm not sure what you would like then | 21:17 |
| mchiappero | (ok for mixins :)) | 21:17 |
| mchiappero | basically Generic implements common stuff, which applies to all drivers | 21:18 |
| mchiappero | what is really specific to generic is request_vif, release_vif, activate_vif | 21:18 |
| mchiappero | moreover vlan and macvlan share an additional method | 21:19 |
| mchiappero | I would like to limit the amout of changes as it breaks the UTs | 21:20 |
| apuimedo | which additional method? | 21:20 |
| mchiappero | hoever going back and forth with the reviews actually causes me more pain | 21:20 |
| mchiappero | _get_parent_port | 21:21 |
| apuimedo | right | 21:22 |
| apuimedo | what have you changed already? | 21:23 |
| mchiappero | I have an abstract NestedDriver | 21:23 |
| mchiappero | the options are: 1) have a skeleton with all these methods, including the _get_parent_port. Then 3 derived classes Generic, Vlan, Macvlan | 21:24 |
| mchiappero | 2) have a util file, with the functions (I haven't checked but IIRC they don't leverage any internal member) | 21:25 |
| mchiappero | (or a mix) | 21:25 |
| mchiappero | I think vlan has been merged without redesigning a bit first, so now it implies a bit of rework, but if there is something you don't like with the structure then it gets worse and worse | 21:26 |
| mchiappero | anyway, no rush, we can continue tomorrow | 21:26 |
| mchiappero | but as soon as I get a feedback I make the changes and push | 21:27 |
| mchiappero | *I'll | 21:27 |
| apuimedo | I'll sleep on it :P | 21:28 |
| apuimedo | 1) could be clean | 21:28 |
| apuimedo | but it remains to be seen | 21:28 |
| apuimedo | :-) | 21:28 |
| mchiappero | ok :) | 21:32 |
| mchiappero | I would go for 1 too but it's just my preference | 21:32 |
| mchiappero | I don't like the NestedDriver base, but it was the least impacting solution | 21:33 |
| apuimedo | tbh, I think the easiest would be to just not share anything, get it merged, and then refactor | 21:36 |
| mchiappero | it's the way it was (is) | 21:40 |
| mchiappero | (is = on gerrit) | 21:40 |
| mchiappero | okay... | 21:40 |
| mchiappero | let's continue tomorrow then | 21:40 |
| mchiappero | btw, thank you :) | 21:41 |
| apuimedo | you're welcome | 22:06 |
| *** irenab_ has joined #openstack-kuryr | 22:27 | |
| *** irenab has quit IRC | 22:28 | |
| *** irenab_ is now known as irenab | 22:28 | |
| *** salv-orl_ has quit IRC | 22:32 | |
| *** egonzalez has quit IRC | 22:43 | |
| *** limao_ has joined #openstack-kuryr | 22:43 | |
| *** openstackgerrit has joined #openstack-kuryr | 23:01 | |
| openstackgerrit | Hongbin Lu proposed openstack/fuxi master: Move to devstack-plugin-container https://review.openstack.org/461212 | 23:01 |
| *** hongbin has quit IRC | 23:08 | |
| *** garyloug has quit IRC | 23:38 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!