Friday, 2018-06-08

« Thursday, 2018-06-07 Index Saturday, 2018-06-09 »
*** yamamoto has joined #openstack-kuryr00:34
*** yamamoto has quit IRC00:39
*** hongbin has joined #openstack-kuryr00:43
*** rh-jelabarre has quit IRC02:25
*** hongbin has quit IRC02:26
*** rh-jelabarre has joined #openstack-kuryr02:30
*** yamamoto has joined #openstack-kuryr03:26
*** yamamoto has quit IRC03:26
*** yamamoto has joined #openstack-kuryr03:31
*** maysamacedos has quit IRC03:39
*** rh-jelabarre has quit IRC04:14
*** rh-jelabarre has joined #openstack-kuryr04:23
*** janonymous has joined #openstack-kuryr04:55
*** pcaruana has joined #openstack-kuryr05:57
*** pcaruana has quit IRC06:14
*** pcaruana has joined #openstack-kuryr06:15
*** openstackgerrit has joined #openstack-kuryr06:30
openstackgerritLuis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add ports pool clean up support to namespace deletion  https://review.openstack.org/56414806:30
openstackgerritLuis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Retry namespace deletion to mitigate cascading race  https://review.openstack.org/57234406:30
openstackgerritLuis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Experimental gate for namespace subnet driver  https://review.openstack.org/57036506:31
ltomasbodulek, celebdor:I lost the +W on this patch sets as I had to rebase them: https://review.openstack.org/564148 https://review.openstack.org/57234406:32
ltomasboalso, dulek, irenab: can you take a look at: https://review.openstack.org/#/c/573235/06:33
*** celebdor1 has joined #openstack-kuryr06:40
*** dulek has quit IRC06:41
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Fix the experimental multinode jobs  https://review.openstack.org/55876206:59
*** celebdor1 has quit IRC07:04
*** jistr is now known as jistr|reloc07:25
*** hongbin has joined #openstack-kuryr07:32
*** hongbin has quit IRC07:35
*** celebdor1 has joined #openstack-kuryr07:37
*** salv-orlando has joined #openstack-kuryr07:41
*** irenab has quit IRC07:45
*** salv-orlando has quit IRC07:46
*** irenab has joined #openstack-kuryr07:46
*** dulek has joined #openstack-kuryr07:54
dmelladohow blazing fast is zuul being today08:06
dmelladoxD08:06
dmelladonote the 'blazing'08:06
*** yamamoto has quit IRC08:08
*** jistr|reloc is now known as jistr08:19
*** yamamoto has joined #openstack-kuryr08:22
*** garyloug has joined #openstack-kuryr08:24
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Create network policy handler and driver  https://review.openstack.org/57361608:32
dmelladosplit code -> Unhappy dmellado08:33
dmelladoxD08:33
openstackgerritMichał Dulko proposed openstack/kuryr-kubernetes master: kuryr-controller A/P HA  https://review.openstack.org/57331208:35
celebdor1dmellado: ?08:35
celebdor1dulek: will review yours now08:35
dmelladocelebdor1: I'm reshaping08:36
dmelladoand splitting08:36
dmelladonetwork policies08:36
dmelladoas it was unreviewable08:36
openstackgerritMichał Dulko proposed openstack/kuryr-kubernetes master: kuryr-controller A/P HA  https://review.openstack.org/57331208:36
dmelladoI'll be taking eyal's code but step by step08:36
dmelladoand also adding small tempest tests for that08:36
dmelladootherwise this won't be ever landing08:37
celebdor1dmellado: you're right. Without the small tempest tests it won't land08:37
dmelladoso first step08:38
dmelladoalmost dummy driver/handler for network policies08:38
dmelladoand mock tempest test08:38
celebdor1dulek: why KURYR_CONTROLLER_HA var?08:38
celebdor1in devstack/settings, I mean08:38
celebdor1wouldn't it make more sense to just have KURYR_CONTROLLER_REPLICAS08:39
dulekcelebdor1: Makes sense, sure. I've started development without replicas setting. Can you make a note on review?08:39
celebdor1so in one fell swoop you get the replicas and the fact that you are enabling HA?08:40
celebdor1sure08:40
*** salv-orlando has joined #openstack-kuryr08:42
*** janonymous has quit IRC08:44
*** salv-orlando has quit IRC08:46
celebdor1dulek: very well written devref on your patch08:49
dulekcelebdor1: It should be, I've forgot about a meeting with russellb while writing it. :P08:50
dulekltomasbo: https://review.openstack.org/#/c/573235 - why those were class variables in the first place?08:54
ltomasbodulek, a mistake08:54
dulekltomasbo: Too much Java? :D08:55
ltomasboI suppose, though I've never liked Java...08:55
ltomasboxD08:55
dulekltomasbo: Was there ever anyone who liked it?08:56
ltomasbogiven the amount of people using it... I guess so08:57
dulekIt's hard to believe…08:57
ltomasboxD08:57
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Create network policy handler and driver  https://review.openstack.org/57361609:00
dmelladodulek: sadly, when I was in university, some of the labs were sponsored by Sun/Oracle09:01
dmelladoso guess who liked Java... xD09:01
dulek:)09:01
celebdor1my university had most courses in Java09:11
celebdor1:/09:11
ltomasbocelebdor1, so you love Java?? xD09:13
celebdor1ltomasbo: almost09:14
celebdor1xD09:14
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Create network policy handler and driver  https://review.openstack.org/57361609:14
celebdor1btw, congratulations. You are now a kuryr-role owner on openshift-ansible09:14
celebdor1it just got merged09:14
dulekltomasbo: Congrats! If you don't have love for Java, you'll like Ansible.09:20
ltomasboxD09:20
ltomasboI prefer ansible :D09:21
ltomasbothanks celebdor109:21
celebdor1dulek: you've added meta classes?!09:22
dulekcelebdor1: Hm, that fragment could use a comment probably.09:22
celebdor1ltomasbo: you can start by looking at the modules I made in the library kuryr role path09:22
celebdor1dulek: please09:22
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Create network policy handler and driver  https://review.openstack.org/57361609:22
dulekcelebdor1: Basically - oslo_service.service.Service has AbcMeta metaclass.09:23
dulekcelebdor1: And oslo_service.periodic_tasks.PeriodicTasks has PeriodicTaskMeta metaclass.09:23
dulekcelebdor1: So when I do multiple inheritance I get infamous metaclass conflict error.09:23
dulekcelebdor1: The trick with this six.with_metaclass solves that.09:24
ltomasbocelebdor1, what modules?09:25
celebdor1dulek: argh... Metaclass combinations09:25
celebdor1we'll become Neutron09:25
celebdor1I can live with it for this case09:26
dulekcelebdor1: It's only to get periodic tasks working in an easy way. During this work I've discovered that we don't really need to use oslo.service in controller, so we can switch to cotyledon one day.09:27
celebdor1ltomasbo: sorry, I meant this https://github.com/openshift/openshift-ansible/tree/master/roles/openshift_openstack/library09:27
celebdor1you also made the one to get rid of ports09:27
celebdor1so you probably already looked at mine too09:27
celebdor1dulek: "so we can switch to cotyledon one day" happiness++09:27
ltomasbocelebdor1, yep, and a new one for the namespaces feature09:28
celebdor1great09:29
ltomasbocelebdor1, and by looking you meant look familiar with, right? not that I have to modify them (for now) for any reason I'm not aware of, right?09:31
celebdor1ltomasbo: exactly09:33
celebdor1only take a look09:33
celebdor1:-)09:33
ltomasbook ok! that I already did!09:33
ltomasbocelebdor1, and I didn't really like how the adapter manages some of the data09:34
ltomasbocelebdor1, I had to do a hack to be able to create the data in the way it needs it: https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_openstack/library/os_subports_deletion.py#L109-L11209:34
ltomasbosuper awful...09:35
celebdor1lol09:35
celebdor1that replace is fugly09:35
ltomasboyes, and the encode ascii thing, but I waste quite some time debugging why the call was not working, have to use pdb to see the actual call and the one this adapter was making to see the differences09:37
ltomasbodmellado was involved in that fun too...09:38
celebdor1dulek: https://review.openstack.org/#/c/573312/3/kuryr_kubernetes/controller/service.py09:38
dmelladoyeah, it was 'awesome'09:39
celebdor1why do we have a periodic_task method09:39
celebdor1if it only calls run_periodic_tasks09:39
celebdor1?09:39
*** janonymous has joined #openstack-kuryr09:39
*** salv-orlando has joined #openstack-kuryr09:42
*** salv-orlando has quit IRC09:46
celebdor1dmellado: what's wrong with zuul09:47
celebdor1?09:47
celebdor1it is taking forever09:47
celebdor1to merge stuff09:47
dmelladocelebdor1: seems to be having issues09:48
dmelladocheck openstack-infra09:48
celebdor1:/09:48
dmelladonetwork issues or so09:48
dulekcelebdor1: It's just a wrapper. This periodic_tasks machinery requires run_periodic_tasks to be run… periodically. :D09:49
dulekcelebdor1: So when HA is on I'm starting a timer that calls this method.09:49
dulekcelebdor1: Great day for reviews, isn't it? ;)09:50
celebdor1dulek: my point with the wrapper was09:51
dulekcelebdor1: You mean I could add "run_periodic_tasks" to the timer? I've tried it and had an issue, but I can revisit that.09:51
celebdor1that you could probably just use functools partial09:52
dulekcelebdor1: Agreed!09:52
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Create network policy handler and driver  https://review.openstack.org/57361610:26
celebdor1dmellado: what's this MERGER_FAILURE?10:50
dmelladocelebdor1: didn't I just reply to that?10:51
dmelladozuul seems to be having network issues10:51
dmelladoso I'd do s/MERGER_FAILURE/recheck10:51
dmelladoxD10:51
celebdor1bummer10:51
openstackgerritDaniel Mellado proposed openstack/kuryr-kubernetes master: Create network policy handler and driver  https://review.openstack.org/57361610:58
ltomasbodmellado, celebdor1: one of my patch sets is already queueing on the gate for 2 hours... and it has not even started with tox-pep8!11:37
dmelladolol11:37
dmelladoltomasbo: celebdor111:38
dmelladoawesome, now my devstack env11:39
dmelladodoesn't spin up pods11:39
dmelladoxD11:39
openstackgerritMichał Dulko proposed openstack/kuryr-kubernetes master: kuryr-controller A/P HA  https://review.openstack.org/57331211:39
dmelladocould you please try my patch11:39
dmelladowith a working env11:39
dmelladoand this network policy11:39
dmelladohttps://da.gd/IUja11:39
dmellado?11:39
dmelladohttps://review.openstack.org/#/c/573616/11:39
*** yamamoto has quit IRC12:11
*** yamamoto has joined #openstack-kuryr12:15
*** yamamoto has quit IRC12:16
*** premsankar has joined #openstack-kuryr12:21
*** yamamoto has joined #openstack-kuryr12:27
*** maysamacedos has joined #openstack-kuryr12:27
*** yamamoto has quit IRC12:28
*** janonymous has quit IRC12:29
*** atoth has joined #openstack-kuryr13:20
celebdor1dulek: thanks for addressing my comments13:22
celebdor1there's still the fact that it's not clear to me what do we expect to happen when in monitor_leader() utils.get_leader_name() returns None13:23
*** yamamoto has joined #openstack-kuryr13:29
*** yamamoto has quit IRC13:31
*** yamamoto has joined #openstack-kuryr13:32
openstackgerritMerged openstack/kuryr-kubernetes master: Ensure different pool related dicts per pool driver  https://review.openstack.org/57323513:53
*** hongbin has joined #openstack-kuryr14:05
*** gcheresh_ has joined #openstack-kuryr14:24
*** jistr is now known as jistr|mtg14:28
*** premsankar has quit IRC14:41
*** dougbtv_ has joined #openstack-kuryr14:54
*** celebdor1 has quit IRC15:03
*** premsankar has joined #openstack-kuryr15:04
*** jistr|mtg is now known as jistr15:16
*** garyloug has quit IRC15:29
*** garyloug has joined #openstack-kuryr15:30
*** maysamacedos has quit IRC15:56
*** pcaruana has quit IRC17:02
*** celebdor1 has joined #openstack-kuryr17:06
*** maysamacedos has joined #openstack-kuryr17:07
*** celebdor1 has quit IRC17:17
*** garyloug has quit IRC17:29
*** dougbtv_ has quit IRC17:35
*** dougbtv_ has joined #openstack-kuryr17:37
*** atoth has quit IRC17:55
*** atoth has joined #openstack-kuryr17:56
*** atoth has quit IRC18:00
*** atoth has joined #openstack-kuryr18:01
*** yamamoto has quit IRC18:25
*** yamamoto has joined #openstack-kuryr18:26
*** yamamoto has quit IRC18:31
*** gcheresh_ has quit IRC19:18
*** yamamoto has joined #openstack-kuryr19:29
*** yamamoto has quit IRC19:37
*** gcheresh_ has joined #openstack-kuryr20:05
*** dougbtv_ has quit IRC20:06
*** premsankar has quit IRC20:31
*** gcheresh_ has quit IRC20:32
*** maysamacedos has quit IRC20:56
openstackgerritMerged openstack/kuryr-kubernetes master: Service: Decoupling and improvements of LBaaS driver  https://review.openstack.org/56617522:02
*** maysamacedos has joined #openstack-kuryr22:07
*** maysamacedos has quit IRC22:11
*** hongbin has quit IRC22:43
*** atoth has quit IRC23:20
« Thursday, 2018-06-07 Index Saturday, 2018-06-09 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!