*** hongbin has joined #openstack-kuryr | 01:44 | |
*** hongbin has quit IRC | 03:52 | |
*** pmannidi has joined #openstack-kuryr | 05:13 | |
*** janki has joined #openstack-kuryr | 05:44 | |
*** pmannidi has quit IRC | 07:16 | |
celebdor | Morning | 07:25 |
---|---|---|
dmellado | morning celebdor | 07:39 |
celebdor | dmellado: this patch is meant for you I think https://review.openstack.org/#/c/588222/ | 07:43 |
dmellado | lemme see | 07:43 |
dmellado | hmm it timed out on the multinode xD | 07:45 |
dmellado | dulek: did you check the cause of it? | 07:45 |
dmellado | http://logs.openstack.org/22/588222/3/check/kuryr-kubernetes-tempest-multinode-octavia/8f72d78/compute1/logs/_.localrc_auto.txt | 07:45 |
dmellado | kubelet was added there just right, but let's see | 07:45 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-tempest-plugin master: Namespace svc isolation tempest coverage https://review.openstack.org/587778 | 07:46 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-tempest-plugin master: Fix delete namespace resources function https://review.openstack.org/588463 | 07:46 |
celebdor | ltomasbo: I don't see us using sudo on the other places | 07:46 |
dmellado | btw celebdor, did you handle your yesterday's patch | 07:46 |
dmellado | I recall I saw some user permission issues | 07:46 |
dmellado | on docker | 07:47 |
dmellado | but didn't get back to the patch today | 07:47 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Ensure OpenShift gate uses the namespace subnet/sg drivers https://review.openstack.org/580680 | 07:50 |
celebdor | dmellado: which? | 07:53 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add namespace isolation for services https://review.openstack.org/581421 | 07:53 |
celebdor | the devstack kuryr/demo thing? | 07:54 |
celebdor | Yes, it works already | 07:54 |
dmellado | yep | 07:54 |
celebdor | and it is merged | 07:54 |
dmellado | awesome, makes my life even easier xD | 07:54 |
openstackgerrit | Merged openstack/kuryr-kubernetes master: fix a typo https://review.openstack.org/562108 | 07:54 |
dulek | dmellado: Not yet, yesterday I've had issues with api_root not being set on the node. | 07:58 |
dulek | dmellado: Let's see what happened this time! | 07:58 |
dmellado | dulek: I left a comment there, I saw some SSL issues on the compute's kubelet | 07:58 |
dulek | dmellado: Damn… | 07:59 |
dmellado | dulek: reenable tls-proxy and let's see if it makes a differnece | 07:59 |
dmellado | difference | 07:59 |
dulek | dmellado: Nah, it's not tls-proxy. It's kubernetes certs. | 07:59 |
dmellado | yeah, that was my 2nd thought | 07:59 |
dulek | dmellado: I assumed this magically worked, but it was a while ago and we were connecting through magic localhost:8080 which is unauthorized and plain HTTP. | 08:00 |
dmellado | heh, which of course won't apply when multinode | 08:00 |
dulek | dmellado: The issue is - if tls-proxy doesn't work in multinode due to certs synchronization, then I don't even know where to look for example… | 08:01 |
dulek | I'll dig this. | 08:01 |
dmellado | dulek: in any case it's been a while since I tried the tls-proxy thing in multinode tbh | 08:01 |
dmellado | there was an issue on orchestrate-devstack which prevented for it to work but tbh I'm not sure about its current state | 08:01 |
celebdor | of course it is k8s certs | 08:02 |
celebdor | there's a reason I didn't do multinode | 08:02 |
celebdor | :P | 08:02 |
celebdor | you need to generate a kubeconfig with certs for the other nodes | 08:02 |
dmellado | celebdor: you like botching up stuff xD | 08:02 |
celebdor | with openshift it is easy | 08:02 |
celebdor | and my patch adds support for it | 08:03 |
celebdor | (the one for the registry) | 08:03 |
dmellado | I'm pretty sure you'd generate a random number like this | 08:03 |
dmellado | https://imgs.xkcd.com/comics/random_number.png | 08:03 |
dulek | celebdor: Oh come one, why don't we just hardcode a cert in DevStack? xD | 08:04 |
celebdor | dulek: I won't | 08:05 |
dmellado | dulek: in fact | 08:15 |
dmellado | let's hardcode everything | 08:15 |
* dmellado thinking about the tests | 08:15 | |
dmellado | return True | 08:15 |
dmellado | just like VW! | 08:15 |
ltomasbo | dulek, celebdor: besides the tempest tests/gates, this is the last remaining patch for the namespace isolation functionality: https://review.openstack.org/#/c/581421 | 08:16 |
celebdor | thanks ltomasbo | 08:16 |
celebdor | dulek: what surprises me if the scc addition is necessary | 08:16 |
ltomasbo | celebdor, note it also fix some route when deploying with devstack so that host->pod connectivity is properly allowed | 08:16 |
celebdor | is that the yaml I create the registry from is generated by oc adm | 08:17 |
celebdor | one would think that it should just work | 08:17 |
dulek | dmellado: Hey, VW did more like "if in_test_mode: result /= result". ;) | 08:20 |
ltomasbo | celebdor, I'm giving it a try to your buildah patch, without much success | 08:21 |
ltomasbo | cp: cannot stat ‘/var/lib/containers/storage/overlay/9e10b3e7e28e3ea6c49ec3057428e550d4324a4e75d4ca7dc4468969f469505f/merged/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Cloud’: No such file or directory | 08:22 |
celebdor | ltomasbo: distro? | 08:24 |
ltomasbo | CentOS Linux release 7.5.1804 (Core) | 08:24 |
celebdor | interesting | 08:25 |
celebdor | let me see | 08:25 |
celebdor | ltomasbo: run a find | 08:26 |
celebdor | to see where the SIG-Cloud key was left | 08:26 |
ltomasbo | I think it is related to this: http://paste.openstack.org/show/727210/ | 08:27 |
*** garyloug_ has joined #openstack-kuryr | 08:27 | |
ltomasbo | though find shows: | 08:28 |
*** garyloug has joined #openstack-kuryr | 08:28 | |
ltomasbo | -> /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Cloud | 08:28 |
ltomasbo | -> /var/lib/docker/overlay2/ea646937ed2a831a7c1ddad0413e52c508f07cf5af73b23fce359f651a093601/merged/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Cloud | 08:28 |
ltomasbo | -> /var/lib/docker/overlay2/589716330a09e8db6b81e4c7c253aae301ec56bb1db5509070139399328391db/diff/etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Cloud | 08:28 |
ltomasbo | so, /var/lib/docker/overlay2 instead | 08:29 |
dulek | dmellado: Hey, actually if I'll run Kuryr containerized, then K8s will take care of giving Kuryr pods the certs! | 08:30 |
dmellado | heh xD | 08:30 |
dmellado | that makes things much easier xD | 08:30 |
dulek | dmellado: I mean https://review.openstack.org/#/c/588223 still failed, but probably due to different reason. | 08:30 |
dmellado | we can just go and run multinode only containerized for now xD | 08:30 |
dmellado | dulek: I'll take a look while I wait xD | 08:31 |
dulek | dmellado: Same reason, I did something wrong… | 08:31 |
*** garyloug has quit IRC | 08:33 | |
*** garyloug_ has joined #openstack-kuryr | 08:33 | |
*** garyloug has joined #openstack-kuryr | 08:34 | |
ltomasbo | celebdor, actually, I manually mounted the container with buildah, and directory scratchmnt seems to be empty | 08:34 |
celebdor | dafuq | 08:35 |
celebdor | at that step it should already be mounted! | 08:35 |
celebdor | you running as sudo? | 08:35 |
ltomasbo | yep | 08:35 |
celebdor | try to run the commands in the terminal | 08:35 |
celebdor | manually | 08:35 |
celebdor | see where it goes to hell | 08:35 |
ltomasbo | that is what I'm doing | 08:35 |
ltomasbo | sudo buildah from scratch | 08:36 |
ltomasbo | sudo buildah mount working-container-5 | 08:36 |
ltomasbo | -> /var/lib/containers/storage/overlay/5387bba9d90c7876793cfa1dff2216da6e4a561d8d5132647c2a43291668cb91/merged | 08:36 |
ltomasbo | but then ls on that dir shows nothing | 08:36 |
celebdor | man | 08:37 |
celebdor | of course it is empty | 08:37 |
celebdor | "from scratch" | 08:37 |
celebdor | it will only be filled after you do the yum --installroot | 08:37 |
ltomasbo | ok | 08:38 |
ltomasbo | there you are | 08:38 |
ltomasbo | then the problem will be with that yum install... | 08:39 |
celebdor | probably | 08:39 |
ltomasbo | Error: Package: centos-release-storage-common-2-2.el7.centos.noarch (buildah_el7_extras) | 08:41 |
ltomasbo | Requires: centos-release >= 7-5.1804.el7.centos.2 | 08:41 |
ltomasbo | Installing: centos-release-7-5.1804.el7.centos.x86_64 (buildah_el7) | 08:41 |
ltomasbo | centos-release = 7-5.1804.el7.centos | 08:41 |
ltomasbo | yep, it complains and suggest either --skip-broken or rpm -Va --nofiles --nodigest | 08:41 |
ltomasbo | you are testing this on fedora, right? | 08:41 |
celebdor | mmm | 08:41 |
ltomasbo | or a different centos... let me try yum update... | 08:42 |
celebdor | ltomasbo: yes | 08:42 |
celebdor | on fedora | 08:42 |
celebdor | I'm probably blind | 08:42 |
celebdor | what's the diff between the requires and the installing | 08:42 |
celebdor | ? | 08:42 |
celebdor | looks like it's the same version to me | 08:42 |
ltomasbo | I don't see it either... | 08:42 |
ltomasbo | centos.2 instead of centos.x86 | 08:42 |
celebdor | yeah... | 08:43 |
celebdor | I know | 08:43 |
celebdor | that's weird | 08:43 |
celebdor | dulek: what a load of bollocks | 08:43 |
celebdor | with the scc addition then it works | 08:44 |
* celebdor taking a break for breakfast | 08:44 | |
dulek | celebdor: ¯\_(ツ)_/¯ | 08:45 |
celebdor | dulek: now to see how I can put that addition into a yaml | 08:48 |
celebdor | :/ | 08:48 |
celebdor | oc get all | 08:48 |
celebdor | is false advertising | 08:48 |
celebdor | it misses most resources | 08:48 |
celebdor | xD | 08:48 |
dulek | celebdor: Missing the non-vanilla-k8s resources? | 08:49 |
celebdor | resources like securitycontextconstraints.security.openshift.io | 08:49 |
celebdor | which is exactly what I need | 08:49 |
celebdor | :/ | 08:49 |
ltomasbo | celebdor, I think I found the issue on your script, some repo is missing | 09:19 |
ltomasbo | celebdor, if I remove the disablerepo, then it works | 09:19 |
ltomasbo | celebdor, dmellado: this fix the issue with the namespace tempest test: https://review.openstack.org/#/c/588463 | 09:22 |
ltomasbo | I checked it on https://review.openstack.org/#/c/580680 | 09:22 |
ltomasbo | on that one, the kuryr-kubernetes-tempest-daemon-containerized-octavia-namespace gate fails due to me removing the regex to only execute the namespace test, but those passed | 09:23 |
celebdor | ltomasbo: repo can't be missing | 09:23 |
celebdor | since it works on my machine that does not have centos stuff at all | 09:23 |
celebdor | :P | 09:23 |
celebdor | most likely there's some collision between your centos repos and those that I put | 09:24 |
ltomasbo | probably | 09:24 |
dulek | Oh crap, now there's an issue of Docker images missing on second node… | 09:26 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Ensure OpenShift gate uses the namespace subnet/sg drivers https://review.openstack.org/580680 | 09:33 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Set namespace security group driver for namespace gate https://review.openstack.org/588487 | 09:33 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add namespace isolation for services https://review.openstack.org/581421 | 09:36 |
celebdor | dulek: that's a good one | 09:38 |
dulek | celebdor: I'm just working on forcing a build on subnode as well. | 09:39 |
dulek | But it would be best to have a registry on master. :) | 09:39 |
celebdor | dulek: either that or pulling from master | 09:39 |
celebdor | yes | 09:39 |
celebdor | that would be the best | 09:39 |
dulek | celebdor: Can I pull from master without setting anything? Isn't Docker binding to 127.0.0.1 by default? | 09:40 |
celebdor | mmm | 09:44 |
celebdor | unsure | 09:44 |
celebdor | dulek: IIRC you'll have to use docker save and docker load | 09:45 |
celebdor | if you don't want to run a proper registry | 09:45 |
dulek | celebdor: Oh no, no, orchestrating SCP in multinode DevStack isn't something I'll do. | 09:45 |
openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: WIP: Add HA gate https://review.openstack.org/588223 | 09:46 |
celebdor | dulek: I knew you'd like the idea | 09:46 |
celebdor | :-) | 09:46 |
celebdor | it's easier to run a registry probably | 09:46 |
celebdor | xD | 09:47 |
celebdor | or to run a python http server via devstack | 09:47 |
celebdor | xD | 09:47 |
dulek | celebdor: Definitely. But even easier to add KURYR_FORCE_IMAGE_BUILD. ;) | 09:47 |
dulek | celebdor: I'm guessing there are no guarantees about synchronization of DevStack's progress on both nodes, so still it's hard. | 09:47 |
dulek | dmellado: ^ ? | 09:47 |
dmellado | dulek: just back here, let me read the backlog | 09:48 |
dulek | dmellado: Nah, just the last question about synchronization. :) | 09:48 |
dmellado | oh, no, that deff won't be synced | 09:49 |
dmellado | so I wouldn't count on that at all | 09:49 |
celebdor | dulek: xD | 09:54 |
celebdor | dulek: hey, wait | 09:54 |
celebdor | there is a better solution, maybe | 09:54 |
dulek | ? | 09:56 |
celebdor | dulek: http://logs.openstack.org/01/580201/11/check/kuryr-kubernetes-tempest-daemon-containerized-octavia/17f3a5f/job-output.txt.gz#_2018-08-02_16_45_00_343836 | 09:58 |
celebdor | wonder if that's somewhere we could push | 09:58 |
celebdor | and pull from | 09:59 |
celebdor | (probably not) | 09:59 |
dulek | celebdor: Ah, interesting. But I highly doubt we would get access. | 10:00 |
celebdor | yeah | 10:00 |
celebdor | dulek: well, we could always use the ocp registry after my patch | 10:01 |
celebdor | but on k8s we still don't have it coded | 10:02 |
dulek | Yup! | 10:02 |
dmellado | tbh I'm really looking forward for the openstack-infra registry... | 10:08 |
dmellado | dulek: that's something that I'd like you to bring on the PTG, although I'm not that optimistic about it | 10:09 |
dulek | dmellado: Me too! | 10:10 |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: devstack: deploy openshift registry on origin envs https://review.openstack.org/580201 | 10:11 |
celebdor | dmellado: yes, I also look forward to things that will probably never come, like Catalan independence | 10:14 |
dmellado | celebdor: you shouldn't say that, man xD | 10:15 |
celebdor | I'd put registry in about as likely as my son who doesn't like football ending up playing in the Ekstraklasa league | 10:15 |
dmellado | what's that, the czech league? | 10:16 |
celebdor | no, an even funnier one, source of multiple fail videos | 10:17 |
celebdor | the polish one | 10:17 |
celebdor | https://www.reddit.com/r/soccer/comments/90agrj/today_is_the_day_the_best_league_in_the_world_is/ | 10:19 |
celebdor | in this case, Ekstraklasa is not a 'nomen omen' | 10:20 |
dmellado | lol | 10:20 |
dmellado | that's even worse than Abreu | 10:20 |
celebdor | indeed | 10:23 |
dulek | celebdor, dmellado: Oh, now it's even funnier - it's Europa League qualifications time! | 10:44 |
dulek | There's even a term for that - eurowpierdol. | 10:45 |
dmellado | lol | 10:45 |
dmellado | dulek: LOL | 10:45 |
dulek | Which kinda translates to eurobeating. | 10:45 |
dmellado | did you know that pierdo means 'I lost' in spanish xD | 10:45 |
dulek | dmellado: Nah, seems like it's clever than I thought. :D | 10:45 |
ltomasbo | dulek, celebdor: this is fixing the namespace gate. Can you review it: https://review.openstack.org/#/c/588463/ | 10:45 |
celebdor | xD | 10:46 |
celebdor | will check | 10:47 |
celebdor | did I ever tell you all how much I hate devstack plugin development? | 10:47 |
ltomasbo | lol | 10:47 |
ltomasbo | it rings a bell... | 10:47 |
dmellado | celebdor: since midonet? | 10:47 |
dmellado | I still recall about the devstack FORK | 10:47 |
dmellado | which was almost impossible to keep sane | 10:47 |
celebdor | dmellado: cause it shouldn't have been forked | 10:49 |
celebdor | the TC should have just force moved to ansible | 10:49 |
celebdor | fuck | 10:49 |
dmellado | well, that's funny | 10:49 |
dmellado | as we proposed that | 10:49 |
dmellado | I guess I'll tell you the storytale when we get to meet | 10:49 |
dmellado | xD | 10:49 |
dulek | I'd say that main issue is rewriting all the DevStack plugins. There's quite a number of them out there. | 11:01 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Add namespace isolation for services https://review.openstack.org/581421 | 11:04 |
celebdor | dulek: indeed | 11:17 |
*** rh-jelabarre has joined #openstack-kuryr | 11:26 | |
*** garyloug has quit IRC | 11:39 | |
*** garyloug_ has quit IRC | 11:39 | |
*** garyloug_ has joined #openstack-kuryr | 11:39 | |
*** garyloug has joined #openstack-kuryr | 11:39 | |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: devstack: deploy openshift registry on origin envs https://review.openstack.org/580201 | 11:40 |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: devstack: deploy openshift registry on origin envs https://review.openstack.org/580201 | 11:45 |
celebdor | ltomasbo: dulek: dmellado: ^^ seems ready | 12:21 |
*** garyloug_ has quit IRC | 12:23 | |
*** garyloug has quit IRC | 12:23 | |
dmellado | celebdor: let's take a look | 12:28 |
dmellado | celebdor: do you know how much do I hate those devstack patches with bash, python and EOF hacks? xD | 12:29 |
celebdor | dmellado: not enough | 12:30 |
celebdor | if you had to write them you'd hate them more | 12:30 |
dmellado | celebdor: you know what is even worse than having ISP issues? | 12:34 |
celebdor | tell me about ISP issues | 12:35 |
celebdor | I'm having meetings on 4g cause the dsl here is crap | 12:35 |
dmellado | having ISP issues on my parents in law place | 12:36 |
dmellado | I'm on 4g now... | 12:36 |
dmellado | calling the dreadeds movistar folks | 12:36 |
* dmellado sighs | 12:36 | |
celebdor | dmellado: so you are in a similar situation | 12:37 |
celebdor | but 4g works really well | 12:38 |
dmellado | say goodby to video conferences, though xD | 12:38 |
dmellado | goodbye | 12:38 |
celebdor | dmellado: they work, if your data cap is high enough | 12:41 |
* celebdor -> weekend | 12:41 | |
celebdor | Blessed be 35h week in August | 12:41 |
dmellado | Celebdor | 12:44 |
dmellado | Enjoy! | 12:44 |
dmellado | Nice weekend | 12:45 |
celebdor | thanks | 12:45 |
celebdor | you too | 12:45 |
celebdor | and merge my registry patch | 12:45 |
celebdor | ltomasbo: try it please | 12:45 |
ltomasbo | celebdor, is you still here | 12:54 |
ltomasbo | +2/+W this one: https://review.openstack.org/#/c/588463/ | 12:54 |
ltomasbo | (if you think it is ok ofc) | 12:55 |
dulek | ltomasbo: Don't worry, I'm still here. | 13:05 |
ltomasbo | \o/ | 13:05 |
ltomasbo | xD | 13:05 |
dulek | ltomasbo: And reviewing seems like a great activity when you're in passenger car seat. ;) | 13:05 |
ltomasbo | dulek, I have quite a few patch sets depending one on another | 13:05 |
ltomasbo | xD | 13:06 |
ltomasbo | where are you traveling to? | 13:06 |
dmellado | To a foreign country, Spain xD | 13:07 |
dulek | ltomasbo: Gdańsk->Giżycko, my hometown. Ah, perks of remote work. :) | 13:08 |
dmellado | Dulek, enjoy home food xD | 13:08 |
dulek | ltomasbo: Seems like namespaces gate still failed? | 13:09 |
dulek | dmellado: I will. :) | 13:09 |
*** tzumainn has joined #openstack-kuryr | 13:13 | |
dulek | ltomasbo: Ping, question above. ^ | 13:29 |
celebdor | dulek: what a fishy coat of arms your town has | 13:29 |
celebdor | between two lakes must have a good amount of mosquitos | 13:30 |
celebdor | :P | 13:30 |
dulek | celebdor: Oh yes, there's this dull legend that a prince gave the… placement law (?) after being served three fishes on blue plate. | 13:34 |
*** garyloug has joined #openstack-kuryr | 13:34 | |
*** garyloug_ has joined #openstack-kuryr | 13:34 | |
dulek | celebdor: And yes, but after ~20 bites you don't feel any new. | 13:35 |
ltomasbo | dulek, sorry I was in a meeting | 13:38 |
ltomasbo | dulek, it does not fail, check it here: https://review.openstack.org/#/c/588487/ | 13:39 |
dulek | ltomasbo: I'm convinced. :) | 13:40 |
ltomasbo | dulek, it is kind of a chicken/egg problem | 13:40 |
dulek | ltomasbo: Sure, sure, I get it. | 13:40 |
ltomasbo | I need to fix the kuryr-tempest-plugin, but as the first namespace isolation patch got merged, I need to enable the SG-driver (as in the second patch) | 13:41 |
ltomasbo | ok | 13:41 |
openstackgerrit | Vladimir Kuramshin proposed openstack/kuryr-kubernetes master: Add SR-IOV binding driver to CNI https://review.openstack.org/512281 | 13:46 |
openstackgerrit | Vladimir Kuramshin proposed openstack/kuryr-kubernetes master: Add SR-IOV capabilities to VIF handler https://review.openstack.org/512280 | 13:47 |
ltomasbo | dulek, ... https://review.openstack.org/#/c/588487/ | 13:57 |
ltomasbo | :D | 13:57 |
ltomasbo | dulek, last one to review for today (in case you are still bored at the car) https://review.openstack.org/#/c/581421 | 14:15 |
openstackgerrit | Vladimir Kuramshin proposed openstack/kuryr-kubernetes master: Add SR-IOV capabilities to VIF handler https://review.openstack.org/512280 | 14:15 |
dulek | ltomasbo: I'm already reading it. :) | 14:16 |
dulek | ltomasbo: What happens here: https://review.openstack.org/#/c/580680/8/.zuul.d/octavia.yaml ? | 14:16 |
ltomasbo | that I will fix it later | 14:16 |
ltomasbo | the problem there is that if we enable isolation, some of the current tests will fail | 14:16 |
ltomasbo | as they are expecting to have fip connectivity | 14:17 |
ltomasbo | which they will not have until the last namespace patch lands | 14:17 |
openstackgerrit | Vladimir Kuramshin proposed openstack/kuryr-kubernetes master: Add SR-IOV binding driver to CNI https://review.openstack.org/512281 | 14:17 |
dulek | ltomasbo: Okay, so I'm leaving it out for now. | 14:17 |
ltomasbo | I can actually try to change the depends on and try | 14:17 |
ltomasbo | yep, important ones remaining are these two: | 14:17 |
ltomasbo | https://review.openstack.org/#/c/581421 | 14:18 |
ltomasbo | https://review.openstack.org/#/c/587778/4 | 14:18 |
openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-kubernetes master: Ensure OpenShift gate uses the namespace subnet/sg drivers https://review.openstack.org/580680 | 14:19 |
*** janki has quit IRC | 14:28 | |
dulek | ltomasbo: Aww, you're removing worker_nodes_subnet option? | 14:30 |
ltomasbo | am I? | 14:30 |
ltomasbo | let me see... | 14:31 |
dulek | ltomasbo: https://review.openstack.org/#/c/581421/21/kuryr_kubernetes/controller/drivers/nested_vif.py | 14:31 |
dulek | ltomasbo: Maybe you move it, haven't seen rest of the files yet. | 14:31 |
ltomasbo | ahh, yes, I moved to the main one | 14:31 |
ltomasbo | as I needed https://review.openstack.org/#/c/581421/21/kuryr_kubernetes/config.py | 14:32 |
*** hongbin has joined #openstack-kuryr | 14:33 | |
ltomasbo | dulek, I needed to have it accessible from the lbaasv2 driver, to add support for the non-native route, i.e., access from the nodes where the route pods run to the pods | 14:34 |
dulek | ltomasbo: Awesome! | 14:34 |
ltomasbo | men, I wrote that code 2 weeks ago and it seems like it was 2 years... I completely forgot about that... xD | 14:35 |
dulek | ltomasbo: +2, now you need to convince celebdor. :) | 14:40 |
ltomasbo | thanks! I expected -1s!! xD | 14:41 |
*** kzaitsev_pi has quit IRC | 14:41 | |
dulek | ltomasbo: Nah, I've already looked at it previously. :) | 14:46 |
dulek | Okay, have a great weekend folks! :) | 14:46 |
ltomasbo | you too! | 14:47 |
ltomasbo | thanks! | 14:47 |
*** janki has joined #openstack-kuryr | 14:51 | |
openstackgerrit | Merged openstack/kuryr-tempest-plugin master: Fix delete namespace resources function https://review.openstack.org/588463 | 14:56 |
openstackgerrit | Merged openstack/kuryr-kubernetes master: devstack: deploy openshift registry on origin envs https://review.openstack.org/580201 | 15:12 |
*** janki has quit IRC | 15:29 | |
*** openstackgerrit has quit IRC | 16:49 | |
*** dmellado has quit IRC | 17:22 | |
*** dmellado has joined #openstack-kuryr | 19:56 | |
*** pcaruana has quit IRC | 21:38 | |
*** rh-jelabarre has quit IRC | 21:56 | |
*** hongbin has quit IRC | 22:19 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!