*** hongbin has joined #openstack-kuryr | 01:23 | |
*** threestrands has quit IRC | 01:33 | |
*** maysams has quit IRC | 02:41 | |
*** hongbin has quit IRC | 03:15 | |
*** pcaruana has joined #openstack-kuryr | 04:36 | |
*** pcaruana has quit IRC | 04:43 | |
*** yboaron_ has joined #openstack-kuryr | 04:47 | |
*** itzikb has joined #openstack-kuryr | 05:13 | |
*** ccamposr has joined #openstack-kuryr | 05:16 | |
*** itzikb has quit IRC | 05:21 | |
*** ccamposr__ has joined #openstack-kuryr | 05:22 | |
*** ccamposr has quit IRC | 05:25 | |
*** maysams has joined #openstack-kuryr | 05:41 | |
*** maysams has quit IRC | 05:42 | |
*** dims has quit IRC | 06:38 | |
*** dims has joined #openstack-kuryr | 06:44 | |
*** dims has quit IRC | 06:48 | |
*** dims has joined #openstack-kuryr | 06:51 | |
*** pcaruana has joined #openstack-kuryr | 07:01 | |
*** oanson has joined #openstack-kuryr | 07:01 | |
danil | hello, folks. Could you please explain what wrong with this patch? https://review.openstack.org/#/c/600022/ | 07:26 |
---|---|---|
*** celebdor has joined #openstack-kuryr | 08:05 | |
*** celebdor has quit IRC | 08:06 | |
*** celebdor has joined #openstack-kuryr | 08:06 | |
*** yboaron_ has quit IRC | 08:14 | |
*** yboaron_ has joined #openstack-kuryr | 08:14 | |
*** garyloug has joined #openstack-kuryr | 08:21 | |
*** garyloug_ has joined #openstack-kuryr | 08:23 | |
*** garyloug has quit IRC | 08:26 | |
*** yboaron_ has quit IRC | 08:42 | |
*** yboaron_ has joined #openstack-kuryr | 08:46 | |
*** gkadam has joined #openstack-kuryr | 08:48 | |
*** garyloug__ has joined #openstack-kuryr | 08:57 | |
openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: [CI TEST] DNM https://review.openstack.org/607132 | 08:59 |
*** garyloug_ has quit IRC | 08:59 | |
*** yboaron_ has quit IRC | 09:02 | |
*** yboaron_ has joined #openstack-kuryr | 09:03 | |
*** garyloug__ has quit IRC | 09:06 | |
openstackgerrit | Itzik Brown proposed openstack/kuryr-tempest-plugin master: Use read_namespaced_pod to get a pod https://review.openstack.org/604079 | 09:15 |
celebdor | dmellado: dulek: https://review.openstack.org/#/c/605605/ ? | 09:21 |
dulek | celebdor: Oh, this one seems to be easy. ;) | 09:21 |
dmellado | I was tempted to -1 it just to annoy him | 09:22 |
dmellado | xD | 09:22 |
dmellado | and ask for documentation or smthing xd | 09:23 |
dulek | dmellado: I'm trying very hard, but this might really be worth +2… :( | 09:23 |
dulek | dmellado: Oh, I got it! six isn't a builtin library. xD | 09:24 |
dmellado | xD | 09:24 |
celebdor | dulek: dmellado: hey, don't we already have it in reqs? | 09:24 |
dmellado | six? | 09:24 |
dmellado | maybe seven | 09:24 |
celebdor | we do | 09:25 |
celebdor | dulek: dmellado: you bunch of scammers | 09:25 |
dulek | celebdor: We do, but it's not a builtin, it's third-party. | 09:25 |
dulek | celebdor: https://docs.openstack.org/hacking/latest/user/hacking.html#imports | 09:25 |
celebdor | I'll take away your core privileged | 09:25 |
celebdor | *privileges | 09:25 |
dulek | But don't worry, I won't be doing -1 on it. ;) | 09:25 |
celebdor | fuuuuuuuu | 09:25 |
celebdor | you're right | 09:25 |
celebdor | I always treat it as core | 09:25 |
celebdor | it should be! | 09:25 |
dmellado | celebdor: could you send a follow-up patch | 09:25 |
celebdor | I'll fix it now | 09:26 |
celebdor | do not merge | 09:26 |
dmellado | so you correct that behavior | 09:26 |
dmellado | ? | 09:26 |
dmellado | xD | 09:26 |
dulek | celebdor: No, no, come on. | 09:26 |
dulek | celebdor: It's not worth another gate run. | 09:26 |
dmellado | lol | 09:26 |
dulek | celebdor: And we import six as builtin all over the place. | 09:26 |
celebdor | ok | 09:27 |
celebdor | then | 09:27 |
celebdor | I forgive myself | 09:27 |
dulek | Had anyone figured out how to run only some of the unit tests? | 09:36 |
*** yboaron_ has quit IRC | 09:39 | |
*** yboaron_ has joined #openstack-kuryr | 09:40 | |
celebdor | dulek: several times | 09:40 |
celebdor | and then I promptly forget again | 09:40 |
celebdor | :-) | 09:40 |
celebdor | we should document it once | 09:41 |
celebdor | xD | 09:41 |
*** irenab has joined #openstack-kuryr | 09:49 | |
*** garyloug has joined #openstack-kuryr | 09:59 | |
dulek | danil: Ah, this is the same error we've seen lately. I've tried updating my tox env and it still doesn't help. I recommend asking on #openstack-infra. | 10:27 |
dulek | danil: But first thing you should do (and this will probably make it work on the gate) is to remove :: before codeblocks. | 10:29 |
dulek | danil: Or let me just submit it. | 10:29 |
openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: Introduce test case document for SRIOV functionality https://review.openstack.org/600022 | 10:30 |
dulek | danil: I've pointed it out last time you were asking. This time it should work (at least on gate). | 10:30 |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: Set handler health even in _sleep exception https://review.openstack.org/605620 | 10:34 |
dulek | danil: Okay, I've also managed to build it locally - just delete doc/build and .tox/docs and retry. | 10:34 |
openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: devstack: Add compatibility for newer k8s https://review.openstack.org/606044 | 10:44 |
openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: Support network policy update https://review.openstack.org/605150 | 11:07 |
*** phuoc_ has quit IRC | 11:39 | |
*** phuoc_ has joined #openstack-kuryr | 11:40 | |
openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: Support network policy update https://review.openstack.org/605150 | 11:52 |
*** aojea_ has joined #openstack-kuryr | 11:55 | |
*** rh-jelabarre has joined #openstack-kuryr | 12:03 | |
*** aojea_ has quit IRC | 12:05 | |
*** aojea_ has joined #openstack-kuryr | 12:06 | |
*** aojea_ has quit IRC | 12:10 | |
*** aojea_ has joined #openstack-kuryr | 12:29 | |
*** pcaruana has quit IRC | 12:57 | |
*** maysams has joined #openstack-kuryr | 13:07 | |
*** aojea_ has quit IRC | 13:09 | |
*** pcaruana has joined #openstack-kuryr | 13:27 | |
*** yboaron_ has quit IRC | 13:39 | |
*** yboaron has joined #openstack-kuryr | 13:42 | |
openstackgerrit | Merged openstack/kuryr-kubernetes master: drop reraise from the controller https://review.openstack.org/605605 | 13:52 |
*** celebdor has quit IRC | 14:14 | |
*** irenab has quit IRC | 14:19 | |
*** celebdor has joined #openstack-kuryr | 14:32 | |
openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: Support network policy update https://review.openstack.org/605150 | 14:38 |
*** celebdor has quit IRC | 14:39 | |
*** celebdor has joined #openstack-kuryr | 14:39 | |
*** celebdor has quit IRC | 15:04 | |
*** yboaron has quit IRC | 15:06 | |
danil | ltomasbo, dmellado: Could you please review this patch? https://review.openstack.org/#/c/600022/ | 15:13 |
ltomasbo | danil, sure, I'll try to do that later today or tomorrow morning | 15:14 |
danil | ltomasbo: thansk a lot. It's a little work;) it already has +2 by dulek | 15:15 |
*** maysams has quit IRC | 15:17 | |
*** maysams has joined #openstack-kuryr | 15:17 | |
*** Sigyn has quit IRC | 15:56 | |
*** ccamposr__ has quit IRC | 15:56 | |
*** Sigyn has joined #openstack-kuryr | 15:57 | |
*** celebdor has joined #openstack-kuryr | 16:23 | |
openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: Add kuryr-status utility for upgrade-checkers https://review.openstack.org/607311 | 16:38 |
dulek | ltomasbo, dmellado: Finally! ^ | 16:38 |
dulek | Writing unit tests for this took me way too long. | 16:38 |
dulek | Even docs were easier. :P | 16:38 |
*** garyloug has quit IRC | 16:57 | |
*** celebdor has quit IRC | 17:14 | |
*** gkadam has quit IRC | 17:28 | |
dmellado | dulek: lol, you tell me | 17:45 |
dmellado | I'm writing unit tests too | 17:45 |
dmellado | xD | 17:45 |
dulek | dmellado: The only situation when I like that is on a train or plane. | 17:48 |
dulek | dmellado: Like you rarely need to look into docs, so it's a perfect activity when you just can't run from it. | 17:49 |
*** openstackgerrit has quit IRC | 17:51 | |
*** pcaruana has quit IRC | 18:02 | |
*** aojea has joined #openstack-kuryr | 18:12 | |
*** openstackgerrit has joined #openstack-kuryr | 18:38 | |
openstackgerrit | Michał Dulko proposed openstack/kuryr-tempest-plugin master: A/P HA tests https://review.openstack.org/590416 | 18:38 |
*** maysams has quit IRC | 19:10 | |
*** maysams has joined #openstack-kuryr | 21:04 | |
*** celebdor has joined #openstack-kuryr | 21:35 | |
*** rh-jelabarre has quit IRC | 22:08 | |
*** aojea has quit IRC | 23:11 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!