| *** rh-jelabarre has quit IRC | 02:20 | |
| *** rh-jelabarre has joined #openstack-kuryr | 02:21 | |
| *** gcheresh has joined #openstack-kuryr | 04:52 | |
| *** rh-jelabarre has quit IRC | 06:05 | |
| *** rh-jelabarre has joined #openstack-kuryr | 06:06 | |
| *** ltomasbo has joined #openstack-kuryr | 06:24 | |
| *** noonedeadpunk has quit IRC | 06:31 | |
| *** noonedeadpunk has joined #openstack-kuryr | 06:32 | |
| *** noonedeadpunk has quit IRC | 06:34 | |
| *** noonedeadpunk has joined #openstack-kuryr | 06:39 | |
| *** ccamposr__ has joined #openstack-kuryr | 07:09 | |
| *** ccamposr has quit IRC | 07:12 | |
| *** DjeufackZane has joined #openstack-kuryr | 07:24 | |
| *** maysams-afk is now known as maysams | 08:01 | |
| *** DjeufackZane has quit IRC | 08:33 | |
| openstackgerrit | Merged openstack/kuryr-kubernetes master: CNI: Lookup offending interface on NetlinkError https://review.opendev.org/759005 | 08:55 |
|---|---|---|
| openstackgerrit | Itzik Brown proposed openstack/kuryr-tempest-plugin master: Add test_network_policy_add_remove_pod https://review.opendev.org/754956 | 09:43 |
| *** maysams has quit IRC | 10:13 | |
| *** maysams has joined #openstack-kuryr | 10:15 | |
| openstackgerrit | Maysa de Macedo Souza proposed openstack/kuryr-kubernetes master: Allow to config network MTU https://review.opendev.org/759147 | 11:37 |
| *** takamatsu has joined #openstack-kuryr | 11:54 | |
| openstackgerrit | Kafilat Adeleke proposed openstack/kuryr-kubernetes master: corrects selflink on kubernetes resources https://review.opendev.org/759250 | 12:00 |
| *** tabbie_fash has joined #openstack-kuryr | 13:08 | |
| *** takamatsu is now known as mauro|call | 14:04 | |
| *** mauro|call is now known as takamatsu | 14:04 | |
| *** tabbie_fash has quit IRC | 14:10 | |
| *** tabbie_fash has joined #openstack-kuryr | 14:17 | |
| *** tabbie_fash has quit IRC | 14:50 | |
| openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: Delete ports created for host networking pods https://review.opendev.org/759108 | 14:56 |
| *** gcheresh has quit IRC | 15:00 | |
| *** tabbie_fash has joined #openstack-kuryr | 15:04 | |
| *** gregwork has joined #openstack-kuryr | 15:25 | |
| *** kafilat has joined #openstack-kuryr | 15:31 | |
| kafilat | Hello maysams | 15:32 |
| *** tabbie_fash has quit IRC | 15:32 | |
| kafilat | Hello | 15:40 |
| *** DjeufackZane has joined #openstack-kuryr | 15:48 | |
| maysams | Hello kafilat, did my explanation helped a bit? | 15:49 |
| kafilat | No. I don't get it | 15:49 |
| maysams | kalifat: what exactly? | 15:50 |
| maysams | kafilat: dulek, could you explain a bit more on the patch your idea with the new method for the selfLink handling? | 15:51 |
| dulek | maysams, kafilat: Sure! Basically resources in K8s are pretty structured (see https://v1-18.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/). | 15:52 |
| *** tabbie_fash has joined #openstack-kuryr | 15:53 | |
| dulek | kafilat: So with information from apiVersion and kind fields along with name and namespace we should be able to build URL to that resource. | 15:53 |
| dulek | See pod's definition: https://v1-18.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#pod-v1-core | 15:53 |
| dulek | Or even better: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#resources | 15:54 |
| dulek | So the idea is to write a method called e.g. getSelfLink() in k8s_client class. | 15:54 |
| dulek | And then wherever we do obj['metadata']['selfLink'] - do k8s.getSelfLink(obj). | 15:55 |
| dulek | And that getSelfLink(obj) will effectively just format URL as I wrote on review: f'/api/{obj['apiVersion']}/namespaces/{obj['metadata']['namespace']}/{kind}/{obj['metadata']['name']} | 15:56 |
| dulek | (those are f-strings https://www.python.org/dev/peps/pep-0498/) | 15:56 |
| dulek | Now the problem is "kind" - as it's a bit different than kind field on the resources. | 15:57 |
| dulek | So to mitigate that we need to create a constant dictionary with mappings - e.g. {'KuryrPort': 'kuryrports', 'Pod': 'pods'} and so on. | 15:57 |
| dulek | Then in the getSelfLink(obj) code will just do `kind = self.kind_mappings.get(obj['kind'])` to get what kind should go into the URL. | 15:58 |
| dulek | That's it. | 15:58 |
| dulek | kafilat: Does this help? | 15:58 |
| kafilat | Thank you. I'll go through it again. | 15:59 |
| kafilat | What about kuryr specific resources? | 16:00 |
| dulek | kafilat: They'll have correct prefix in apiVersion already. | 16:01 |
| dulek | Ouch. It's either '/api' or '/apis', it'd need to figure out when to use which. :/ | 16:02 |
| kafilat | Okay. Thank you. | 16:02 |
| dulek | kafilat: It will be something like this: http://paste.openstack.org/show/799289/ | 16:08 |
| dulek | Apparently it's '/api' only for v1 and it's '/apis' for anything else. | 16:08 |
| kafilat | Oh, that really helps. Thanks. | 16:10 |
| *** tabbie_fash has quit IRC | 16:13 | |
| *** gcheresh has joined #openstack-kuryr | 16:41 | |
| *** DjeufackZane has quit IRC | 16:51 | |
| *** gcheresh has quit IRC | 17:05 | |
| *** ccamposr has joined #openstack-kuryr | 17:06 | |
| *** ccamposr__ has quit IRC | 17:09 | |
| *** ltomasbo has quit IRC | 17:13 | |
| *** KurtB has quit IRC | 18:35 | |
| *** kafilat has quit IRC | 19:49 | |
| *** aghasaad04 has joined #openstack-kuryr | 20:30 | |
| *** gcheresh has joined #openstack-kuryr | 20:56 | |
| *** aghasaad04 has quit IRC | 21:37 | |
| *** gcheresh has quit IRC | 21:46 | |
| *** DjeufackZane has joined #openstack-kuryr | 22:28 | |
| *** maysams has left #openstack-kuryr | 22:34 | |
| *** maysams has joined #openstack-kuryr | 22:34 | |
| maysams | Hello DjeufackZane, I saw you mentioned interest on the Kuryr project a while ago | 22:56 |
| maysams | DjeufackZane: I'm glad about your interest. If you want to get started contributing feel free to pick a task from this list not yet assigned to anyone https://bugs.launchpad.net/kuryr-kubernetes/+bugs?field.tag=low-hanging-fruit | 22:58 |
| *** DjeufackZane has quit IRC | 22:58 | |
| *** rh-jelabarre has quit IRC | 23:15 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!