| *** carcablop19 has quit IRC | 00:31 | |
| *** maysams has quit IRC | 04:56 | |
| *** ltomasbo has joined #openstack-kuryr | 06:26 | |
| *** digitalsimboja has joined #openstack-kuryr | 06:46 | |
| dulek | We're starting today's PTG now in the Icehouse room! | 07:01 |
|---|---|---|
| *** digitalsimboja has joined #openstack-kuryr | 07:31 | |
| *** gcheresh has joined #openstack-kuryr | 07:38 | |
| digitalsimboja | Thanks everyone once again for meeting you guys today especially dmellado that joined later on | 08:11 |
| digitalsimboja | Have a great day ahead | 08:12 |
| dmellado | thanks all! ;) | 08:12 |
| dulek | digitalsimboja: Isn't this a good little bug you could try tackling: https://bugs.launchpad.net/kuryr-kubernetes/+bug/1922235 ? | 08:12 |
| openstack | Launchpad bug 1922235 in kuryr-kubernetes "Switch to golang modules" [Undecided,New] | 08:12 |
| digitalsimboja | yeah makes sense as I was about to request for this | 08:12 |
| digitalsimboja | Let me take a look then | 08:12 |
| dmellado | dulek, didn't you move to go mod yet? | 08:13 |
| dmellado | that'd be a cool low hanging fruit to work into, digitalsimboja ;) | 08:13 |
| digitalsimboja | Thanks | 08:14 |
| dulek | dmellado: Well, as the golang expert you can point digitalsimboja to some resources about it. | 08:14 |
| dulek | Honestly when fixing this I just realized I don't understand go modules yet and simply solved it by disabling it. | 08:14 |
| digitalsimboja | Yeah would appreciate that | 08:14 |
| dmellado | sure, let me search for something | 08:15 |
| digitalsimboja | alright | 08:15 |
| dmellado | in the end, it's a bit like having a requirements.txt | 08:15 |
| dmellado | if you're familiar with that | 08:15 |
| dmellado | digitalsimboja: that'd be a good start | 08:16 |
| dmellado | https://blog.golang.org/using-go-modules | 08:16 |
| dmellado | and this is the official reference https://golang.org/ref/mod | 08:17 |
| dmellado | dulek: probably what you could also do is explaining to digitalsimboja how do you consume the kuryr_cni | 08:18 |
| dmellado | binary-wise and so | 08:18 |
| digitalsimboja | that would surely help | 08:20 |
| dulek | dmellado: It's compiled in here: https://github.com/openstack/kuryr-kubernetes/blob/0ece1e0c6afbebbcba627387afea017ba38889de/cni.Dockerfile#L6 | 08:20 |
| dmellado | yeah, one thing that would be also cool to have | 08:20 |
| dmellado | is adding a few auxiliary 'hack' files | 08:21 |
| dulek | And then when kuryr-cni is run as a container it copies the binary into /opt/cni/bin, which is the standard folder where K8s CNI plugins are supposed to go. | 08:21 |
| dmellado | so whoever uses this would also be able to compile the binary | 08:21 |
| dmellado | i.e add ad hack/build-go file within the cni folder | 08:21 |
| dulek | dmellado: Well, yeaaah… Just you know, it's just a very scratch app, we haven't even changed it in years. | 08:22 |
| dmellado | i.e. https://github.com/openshift/egress-router-cni/tree/master/hack | 08:22 |
| dmellado | I know xD | 08:22 |
| dmellado | in any case, digitalsimboja , don't hesitate pinging me around | 08:23 |
| digitalsimboja | taking a look | 08:23 |
| dmellado | I'll try having some time to contribute back to kuryr from now on | 08:23 |
| gryf | dmellado, that's sounds awesome! | 08:25 |
| dmellado | at least to annoy you back with terrible network policies bugs lol xD | 08:27 |
| digitalsimboja | @dmellado: sure I will | 08:28 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/kuryr-kubernetes master: ___________________________ < DO NOT MERGE, TESTING OVN > --------------------------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || || https://review.opendev.org/c/openstack/kuryr-kubernetes/+/778443 | 08:31 |
| dmellado | in any case, I think that maybe the cni-plugin would be better off living on its own github repo, tbh | 08:43 |
| *** digitalsimboja has quit IRC | 08:44 | |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: Migrate kuryr-cni to go.mod https://review.opendev.org/c/openstack/kuryr-kubernetes/+/787690 | 08:48 |
| dmellado | dulek: I've started this so digitalsimboja can take over https://review.opendev.org/c/openstack/kuryr-kubernetes/+/787690 | 08:49 |
| dmellado | I'll let him take over and finish it, but it compiles, uses go mod and blah | 08:50 |
| dmellado | I'd move kuryr_cni to its own github repo, though | 08:50 |
| dulek | One day we'll rewrite kuryr-daemon into golang and then it'll land in a separate repo. ;) | 08:51 |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: Migrate kuryr-cni to go.mod https://review.opendev.org/c/openstack/kuryr-kubernetes/+/787690 | 08:53 |
| openstackgerrit | Daniel Mellado proposed openstack/kuryr-kubernetes master: Migrate kuryr-cni to go.mod https://review.opendev.org/c/openstack/kuryr-kubernetes/+/787690 | 08:56 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/kuryr-kubernetes master: ___________________________ < DO NOT MERGE, TESTING OVN > --------------------------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || || https://review.opendev.org/c/openstack/kuryr-kubernetes/+/778443 | 09:01 |
| openstackgerrit | Michał Dulko proposed openstack/kuryr-kubernetes master: Fix NPs for OVN LBs with hairpin traffic https://review.opendev.org/c/openstack/kuryr-kubernetes/+/786035 | 09:42 |
| *** gcheresh has quit IRC | 09:48 | |
| *** digitalsimboja has joined #openstack-kuryr | 10:18 | |
| *** gcheresh has joined #openstack-kuryr | 10:35 | |
| *** ccamposr has quit IRC | 11:21 | |
| *** ccamposr has joined #openstack-kuryr | 11:21 | |
| *** digitalsimboja has quit IRC | 11:43 | |
| *** digitalsimboja has joined #openstack-kuryr | 11:45 | |
| *** digitalsimboja has quit IRC | 12:02 | |
| *** digitalsimboja has joined #openstack-kuryr | 12:02 | |
| *** rh-jelabarre has joined #openstack-kuryr | 12:11 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/kuryr-kubernetes master: ___________________________ < DO NOT MERGE, TESTING OVN > --------------------------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || || https://review.opendev.org/c/openstack/kuryr-kubernetes/+/778443 | 12:15 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/kuryr-kubernetes master: Prepare gate for OVN as default in DevStack https://review.opendev.org/c/openstack/kuryr-kubernetes/+/787720 | 12:15 |
| *** digitalsimboja has quit IRC | 12:36 | |
| *** maysams has joined #openstack-kuryr | 12:40 | |
| openstackgerrit | Darshna Das proposed openstack/kuryr-kubernetes master: Remove pyroute2 deprication warning https://review.opendev.org/c/openstack/kuryr-kubernetes/+/786759 | 12:51 |
| *** digitalsimboja has joined #openstack-kuryr | 13:25 | |
| *** digitalsimboja has quit IRC | 13:36 | |
| *** digitalsimboja has joined #openstack-kuryr | 13:45 | |
| openstackgerrit | Roman Dobosz proposed openstack/kuryr-kubernetes master: [WIP] Use kubeadm for installing kubernetes on devstack. https://review.opendev.org/c/openstack/kuryr-kubernetes/+/779250 | 13:48 |
| *** digitalsimboja has quit IRC | 14:13 | |
| *** gcheresh has quit IRC | 14:37 | |
| *** carcablop19 has joined #openstack-kuryr | 14:38 | |
| *** gcheresh has joined #openstack-kuryr | 14:46 | |
| *** maysams has quit IRC | 16:30 | |
| *** gcheresh has quit IRC | 17:32 | |
| *** gcheresh has joined #openstack-kuryr | 17:41 | |
| *** gcheresh has quit IRC | 17:47 | |
| *** gcheresh has joined #openstack-kuryr | 17:48 | |
| *** gcheresh has quit IRC | 18:14 | |
| *** gcheresh has joined #openstack-kuryr | 19:24 | |
| *** ltomasbo has quit IRC | 20:05 | |
| *** gcheresh has quit IRC | 20:18 | |
| *** carcablop19 has quit IRC | 20:57 | |
| *** maysams has joined #openstack-kuryr | 22:03 | |
| *** maysams has quit IRC | 23:08 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!