| *** pmannidi is now known as pmannidi|Lunch | 03:52 | |
| *** pmannidi|Lunch is now known as pmannidi | 04:54 | |
| digitalsimboja | Good morning! | 05:59 |
|---|---|---|
| digitalsimboja | This is me trying to collect my thoughts for a newbie to writing tempest tests, still more to add as I journey along | 06:00 |
| digitalsimboja | https://digitalsimboja.wordpress.com/2021/08/09/write-your-first-tempest-test-in-kuryr-tempest-plugin/ | 06:00 |
| ltomasbo | good morning digitalsimboja!! | 06:00 |
| digitalsimboja | Hi ltomasbo | 06:00 |
| digitalsimboja | Welcome! | 06:00 |
| digitalsimboja | Good morning | 06:00 |
| digitalsimboja | gryf, zuul is happy now! | 06:01 |
| gryf | digitalsimboja, yay! | 06:02 |
| ltomasbo | digitalsimboja, where, your patch? | 06:02 |
| digitalsimboja | I just triggered my main patch | 06:03 |
| gryf | ah, no. | 06:03 |
| digitalsimboja | We fixed a gate issue affecting it initially | 06:03 |
| digitalsimboja | so lets see and I trust it would pass this time | 06:03 |
| gryf | I've removed the change to see if it might bring instability. let me rollback the change. | 06:03 |
| digitalsimboja | ohh! | 06:03 |
| ltomasbo | yeah, the depending patch seems to do nothing... so... | 06:04 |
| opendevreview | Roman Dobosz proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 06:04 |
| gryf | digitalsimboja, ltomasbo ^^ | 06:04 |
| digitalsimboja | line 23: https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527/14/.zuul.d/octavia.yaml#23 | 06:06 |
| gryf | aww | 06:06 |
| ltomasbo | thanks gryf! that looks ok from my side! lets see the gates! | 06:06 |
| opendevreview | Roman Dobosz proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 06:06 |
| gryf | fixed. | 06:07 |
| digitalsimboja | lets see now | 06:08 |
| ltomasbo | digitalsimboja, nice blog post, perhaps you can "personalize it" a bit more and refer your patch, what it intents to test, what problems you faced in relation to octavia plugin, etc (maybe a follow up post) | 06:08 |
| digitalsimboja | Okay cool!. Thanks | 06:08 |
| digitalsimboja | Please check the implementation of the Periodic Tasks as advised by dulek | 06:09 |
| digitalsimboja | https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803870 | 06:09 |
| opendevreview | Roman Dobosz proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 06:09 |
| gryf | there was issue with indenting. now let's wait and see. | 06:10 |
| digitalsimboja | ltomasbo, please check my comment and help clarify | 07:56 |
| digitalsimboja | https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803870/1/kuryr_kubernetes/controller/service.py#170 | 07:56 |
| ltomasbo | digitalsimboja, maybe I got confused... are you planning to add that check_resources() for all handlers? | 08:03 |
| ltomasbo | then, perhaps the commit message is a bit misleading | 08:03 |
| ltomasbo | I thought this was just about the loadbalancer one | 08:04 |
| ltomasbo | and if that is not the case, you should also create a check_resource() function for the rest (even if it is empty) | 08:04 |
| digitalsimboja | The idea as I understand from dulek reviews is to iterate through all the handlers, those which have check_for_reconciliation, it would reconcile | 08:07 |
| digitalsimboja | But for those without, then it will just pass | 08:07 |
| ltomasbo | digitalsimboja, yep, that makes sense | 08:08 |
| digitalsimboja | Great! | 08:09 |
| digitalsimboja | As I define check_for_reconciliation in the required handlers, that k8sService would handle that as well | 08:10 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Update the LoadBalancers Reconciliation Loop https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803870 | 09:53 |
| opendevreview | Sunday Mgbogu proposed openstack/kuryr-kubernetes master: Add Octavia Tempest Plugin https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803527 | 12:48 |
| digitalsimboja | Hello dulek | 13:43 |
| dulek | digitalsimboja: Hi! | 13:45 |
| digitalsimboja | Welcome back | 13:46 |
| digitalsimboja | Please take a look | 13:46 |
| digitalsimboja | https://review.opendev.org/c/openstack/kuryr-kubernetes/+/803870 | 13:46 |
| dulek | digitalsimboja: I opened your patches a while ago, going over the one adding test at the moment. :D | 13:47 |
| digitalsimboja | okay cool | 13:48 |
| *** pmannidi is now known as pmannidi|AFK | 14:07 | |
| *** pmannidi|AFK is now known as pmannidi | 23:41 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!