| *** sbfox has quit IRC | 00:05 | |
| *** mestery has joined #openstack-lbaas | 00:20 | |
| *** mestery has quit IRC | 00:25 | |
| *** woodster__ has quit IRC | 00:45 | |
| *** mestery has joined #openstack-lbaas | 00:49 | |
| *** mestery has quit IRC | 00:51 | |
| *** VijayB has quit IRC | 00:52 | |
| *** VijayB has joined #openstack-lbaas | 01:14 | |
| *** vivek-ebay has joined #openstack-lbaas | 01:23 | |
| *** sbfox has joined #openstack-lbaas | 01:27 | |
| *** sbfox has quit IRC | 01:37 | |
| *** vivek-ebay has quit IRC | 01:39 | |
| *** mestery has joined #openstack-lbaas | 01:42 | |
| *** mestery has quit IRC | 01:42 | |
| *** mestery has joined #openstack-lbaas | 01:42 | |
| *** vivek-ebay has joined #openstack-lbaas | 01:52 | |
| *** vivek-ebay has quit IRC | 01:52 | |
| *** woodster__ has joined #openstack-lbaas | 02:10 | |
| *** fnaval has joined #openstack-lbaas | 02:11 | |
| *** mestery has quit IRC | 02:15 | |
| dougwig | blogan: do the unit tests pass on the branch? | 02:35 |
|---|---|---|
| *** fnaval has quit IRC | 02:35 | |
| blogan | they should, though I ran into one that was not passing in the vmware tests because of a missing table, but I couldn't figure that one out | 02:36 |
| blogan | you run into any issues | 02:38 |
| blogan | ? | 02:38 |
| dougwig | just started. i was going to refactor one of your tests to be a lot shorter, and fix the main noop driver at the same time. | 02:39 |
| dougwig | i like your 4k+ review. :) | 02:39 |
| blogan | you dont touch my tests!!! | 02:39 |
| blogan | lol i know | 02:39 |
| dougwig | we should start a pool on how many patch sets. i'm in for 50. | 02:40 |
| blogan | oh god | 02:40 |
| blogan | num patch sets = num lines of code | 02:40 |
| dougwig | they have a pile of 'hacking' reviews that are going in soon, which should cause rebasing hell, as well. (one bit me.) | 02:40 |
| blogan | what sorts of changes are in store? | 02:41 |
| dougwig | we're still on this branch, right? bp/lbaas-api-and-objmodel-improvement | 02:41 |
| blogan | yep | 02:41 |
| blogan | i squashed and rebased | 02:41 |
| blogan | and pushed it to that branch | 02:41 |
| blogan | on oslbaas | 02:41 |
| dougwig | see the pep8/flake8 reviews at the top of the list here: https://review.openstack.org/#/projects/openstack/neutron,dashboards/important-changes:review-inbox-dashboard | 02:43 |
| ptoohill | :/ | 02:43 |
| dougwig | just got a test bomb (usually a syntax error in a python file), which testr hides like a demon. let me track that down. | 02:43 |
| blogan | have you pulled down the new branch? | 02:44 |
| dougwig | yes. let me try a tox -r | 02:44 |
| dougwig | maybe my env is messed up | 02:45 |
| blogan | does run_tests.sh work? | 02:46 |
| dougwig | fox failed again. let me try run_tests.sh | 02:47 |
| dougwig | tox | 02:47 |
| dougwig | that's cranky too. let me track it down. | 02:49 |
| blogan | hmm | 02:51 |
| blogan | damnit I forgot Dustin in the commit message | 02:54 |
| ptoohill | patch set 2 | 02:55 |
| ptoohill | :) | 02:55 |
| blogan | it can wait for a real patch set | 02:55 |
| dougwig | i'd expect that to be a long list by the time all is said and done. | 02:55 |
| blogan | i fully expect patch set 1 to be greeted by all reviewers with tears of joy exclaiming that had the written this it would be exactly the same way | 02:56 |
| dougwig | i expect you'll get tears. | 02:58 |
| dougwig | :) | 02:58 |
| blogan | lol | 02:58 |
| blogan | everyone will be crying after this | 02:58 |
| dougwig | i'm still bombing out. let me try linux instead of os x real quick. | 02:59 |
| blogan | well there's your problem | 03:00 |
| dougwig | macs are supported for unit tests; didn't you see how many were at the summit? | 03:03 |
| blogan | lol i use one | 03:04 |
| blogan | but i run linux on it | 03:04 |
| dougwig | ha. | 03:04 |
| blogan | bbiab | 03:05 |
| *** fnaval has joined #openstack-lbaas | 03:08 | |
| *** mestery has joined #openstack-lbaas | 03:26 | |
| *** mestery has quit IRC | 03:29 | |
| *** sbfox has joined #openstack-lbaas | 03:34 | |
| *** VijayB has quit IRC | 03:39 | |
| dougwig | got it, after futzing with manually creating the venv. hmm. battery life remaining before: 7 hours. battery life remaining during: 1 hour, 10 minutes. | 03:44 |
| *** fnaval has quit IRC | 03:47 | |
| *** vjay has joined #openstack-lbaas | 03:49 | |
| *** sbfox has quit IRC | 03:59 | |
| *** mestery has joined #openstack-lbaas | 04:00 | |
| *** mestery has quit IRC | 04:05 | |
| *** blogan is now known as zz_blogan | 04:09 | |
| *** vivek-ebay has joined #openstack-lbaas | 04:18 | |
| *** crc32 has quit IRC | 04:34 | |
| *** mestery has joined #openstack-lbaas | 05:01 | |
| *** mestery has quit IRC | 05:06 | |
| *** dlundquist has joined #openstack-lbaas | 05:10 | |
| *** dlundquist has left #openstack-lbaas | 05:10 | |
| *** dlundquist has joined #openstack-lbaas | 05:12 | |
| *** dlundquist has left #openstack-lbaas | 05:12 | |
| *** sab has joined #openstack-lbaas | 05:14 | |
| *** vivek-ebay has quit IRC | 05:19 | |
| *** sab_ has joined #openstack-lbaas | 05:20 | |
| *** sab has quit IRC | 05:24 | |
| dougwig | zz_blogan: is this a v2 change? in your test noop, in health monitor manager, you call self.plugin.update_status. in v1 land, health monitors call self.plugin.update_pool_health_monitor | 05:24 |
| dougwig | zz_blogan: here's my bomb, on both platforms | 05:41 |
| dougwig | https://www.irccloud.com/pastebin/LvbDFNoN | 05:41 |
| dougwig | and indeed, that path does not exist. did we miss an upstream merge? | 05:42 |
| dougwig | ok, it looks like you might be behind the branch? because the branch is now using oslo.db, and your file is still using neutron.openstack.common.db. maybe you have a .pyc hanging around? | 05:48 |
| dougwig | standby, pr with fix incoming | 05:55 |
| dougwig | still need an answer to the update_status question. | 05:55 |
| dougwig | nevermind, it's right in git. ok, no clue how i got into a place where git thought life was up to date and it wasn't. re-cloning. | 05:58 |
| *** mestery has joined #openstack-lbaas | 06:02 | |
| *** mestery has quit IRC | 06:06 | |
| *** mestery has joined #openstack-lbaas | 07:03 | |
| *** HenryG has quit IRC | 07:07 | |
| *** mestery has quit IRC | 07:08 | |
| *** woodster__ has quit IRC | 07:35 | |
| *** mestery has joined #openstack-lbaas | 08:04 | |
| *** mestery has quit IRC | 08:09 | |
| *** mestery has joined #openstack-lbaas | 09:05 | |
| *** HenryG has joined #openstack-lbaas | 09:05 | |
| *** mestery has quit IRC | 09:09 | |
| *** mestery has joined #openstack-lbaas | 11:07 | |
| *** mestery has quit IRC | 11:11 | |
| *** vjay has quit IRC | 12:01 | |
| *** mestery has joined #openstack-lbaas | 12:08 | |
| *** markmcclain has joined #openstack-lbaas | 12:11 | |
| *** mestery has quit IRC | 12:12 | |
| *** markmcclain1 has joined #openstack-lbaas | 12:13 | |
| *** markmcclain has quit IRC | 12:16 | |
| *** sab_ has quit IRC | 12:28 | |
| *** vjay has joined #openstack-lbaas | 12:56 | |
| *** markmcclain1 has quit IRC | 13:06 | |
| *** mestery has joined #openstack-lbaas | 13:08 | |
| *** mestery has quit IRC | 13:13 | |
| *** woodster__ has joined #openstack-lbaas | 13:15 | |
| *** HenryG has quit IRC | 13:17 | |
| *** mestery has joined #openstack-lbaas | 13:25 | |
| sballe | jorge? | 13:40 |
| *** vjay has quit IRC | 13:59 | |
| *** TrevorV_ has joined #openstack-lbaas | 14:14 | |
| *** vjay has joined #openstack-lbaas | 14:19 | |
| *** sab_ has joined #openstack-lbaas | 14:41 | |
| *** vishnoianil has joined #openstack-lbaas | 14:45 | |
| *** sab_ has quit IRC | 14:47 | |
| *** vishnoianil is now known as avishnoi | 14:49 | |
| avishnoi | Hi folks | 14:51 |
| avishnoi | i have one query regarding pool member creation | 14:51 |
| avishnoi | anybody up for it ? :-) | 14:51 |
| dougwig | Shoot | 14:53 |
| avishnoi | I created pool and added two instances to it | 14:54 |
| avishnoi | when i see details of the pool | 14:55 |
| avishnoi | member's id mentioned in member :{} are different then the actual instance id | 14:55 |
| dougwig | That's normal. The member object contains the server ids | 14:55 |
| avishnoi | can you explain a bit | 14:57 |
| avishnoi | what do you mean by server ids, do you mean host machines id? | 14:57 |
| *** fnaval has joined #openstack-lbaas | 14:57 | |
| dougwig | Member is a standalone db object for Lbaas. It contains a few bits of data plus an instance I'd, and pool links to the member object. | 14:58 |
| dougwig | Id, not I'd | 14:58 |
| *** xgerman has joined #openstack-lbaas | 15:00 | |
| avishnoi | dougwig: okay, but when i see member object, its id is also not same as instance id | 15:00 |
| avishnoi | actually what i want to do is, whenever user creates the pool with instances, i want to fetch their CPU statistics using ceilometer | 15:01 |
| avishnoi | and ceilometer actually need instance id | 15:01 |
| avishnoi | and i am getting member id | 15:01 |
| dougwig | Right. If you give me a few to get to a computer, I can tell you which field it is | 15:02 |
| avishnoi | and instance id = member id | 15:02 |
| avishnoi | sure | 15:02 |
| dougwig | You're right, it's not saved. Currently, youd have to look up the member, get it's ip, and then use that to look up its instance. | 15:06 |
| dougwig | Members can point at non nova ips, which will make it more fun. | 15:06 |
| avishnoi | :( | 15:08 |
| avishnoi | this is bit complex | 15:08 |
| dougwig | I'm still tapping on my phone. Will you be around in an hour? | 15:09 |
| avishnoi | yup | 15:09 |
| *** jorgem has joined #openstack-lbaas | 15:12 | |
| *** vjay has quit IRC | 15:14 | |
| *** vjay has joined #openstack-lbaas | 15:16 | |
| *** jorgem has quit IRC | 15:25 | |
| *** jorgem1 has joined #openstack-lbaas | 15:25 | |
| *** jorgem1 is now known as jorgem | 15:25 | |
| *** avishnoi has quit IRC | 15:53 | |
| ptoohill | With the current progress, should we assume TLS, L7 and anything else is to be left for next cycle? | 15:59 |
| *** sbfox has joined #openstack-lbaas | 16:02 | |
| *** sbfox1 has joined #openstack-lbaas | 16:03 | |
| dougwig | they're juno-3, if not K. | 16:05 |
| *** sbfox has quit IRC | 16:07 | |
| *** jorgem has quit IRC | 16:07 | |
| *** jorgem has joined #openstack-lbaas | 16:07 | |
| ptoohill | whats deadline for j-3 bps? | 16:07 |
| *** dlundquist has joined #openstack-lbaas | 16:18 | |
| dougwig | july 10 gerrit, july 20 accepted | 16:23 |
| *** zz_blogan is now known as blogan | 16:27 | |
| ptoohill | thank you | 16:27 |
| blogan | dougwig: did you figure all that out? | 16:28 |
| dougwig | blogan: yes, there's a python 2.6 pull request waiting for you | 16:29 |
| dougwig | i'll have some status questions for you when you've got a sec. | 16:29 |
| blogan | did you fix the nested contexts or something for 2.6? | 16:30 |
| blogan | ill just look lol | 16:30 |
| dougwig | nested contexts and dictionary comprehensions. | 16:31 |
| dougwig | and oh my, you loved them. :) | 16:31 |
| blogan | lol | 16:33 |
| blogan | had i actually thought about 2.6 i wouldn't have done them obviously | 16:33 |
| dougwig | i did the exact same thing. :) | 16:33 |
| blogan | what better way to learn than to make the mistake first | 16:34 |
| dougwig | if not for centos/rhel, we could also just not support an ancient python. | 16:34 |
| blogan | if not for python 3 being backwards incompatible, there would be peace on earth | 16:36 |
| dougwig | i was mindlessly converting last night while watching dr. who. at about line 800, i was thinking, 'jeez, this is a long test.' | 16:36 |
| dougwig | python 2 -> 3 is just a good time to switch to ruby. | 16:36 |
| dougwig | :) | 16:36 |
| blogan | blasphemy | 16:39 |
| blogan | ping mestery | 16:39 |
| mestery | blogan: howdy man! | 16:40 |
| blogan | mestery: oh just bc im from texas you greet me with "howdy" | 16:40 |
| dougwig | blogan is feisty this morning. | 16:41 |
| mestery | blogan: :P | 16:41 |
| blogan | mestery: so there have been complaints about the lbaas v2 patch set being too many lines, and rightfully so as I suspected would happen. How would splitting a review work in this case? | 16:42 |
| dougwig | you could do db + tests and then the rest. that'd split it in 2. | 16:42 |
| blogan | dougwig: thats what I figured but wasn't sure if thats the proper way | 16:43 |
| blogan | ill bb in a few, i gotta get some lunch and bring it abck to my desk | 16:43 |
| dougwig | it's gotta be pieces that can be tested separately but which don't yet link together to something else. | 16:43 |
| dougwig | ok, we need to talk about healthmon status. | 16:44 |
| *** TrevorV_ has quit IRC | 16:51 | |
| *** sbfox1 has quit IRC | 16:52 | |
| *** rolledback has joined #openstack-lbaas | 16:57 | |
| *** sbfox has joined #openstack-lbaas | 16:59 | |
| *** vjay has quit IRC | 16:59 | |
| *** vjay has joined #openstack-lbaas | 17:00 | |
| blogan | ok dougwig lets talk | 17:02 |
| dougwig | scroll up to my question at 11:25pm, before i got myself into git hell. | 17:03 |
| dougwig | basically, you're calling a different status interface in v2 than in v1, and i wanted to verify that it was intentional, and the old entry point is gone? | 17:03 |
| blogan | oh i see | 17:05 |
| blogan | let me verify what I think it is right now is correct so let me look at the v1 code | 17:06 |
| blogan | dougwig: ok so that was just me testing, so the driver can call whatever it wants, it won't be calling update_pool_health_monitor now, since health monitors are not child REST resources of a pool | 17:09 |
| dougwig | i'm cool with whatever it needs to call; i just need to know what the right thing is, so i can fix the driver. i'll fix that and add the proper delete calls at the same time. | 17:10 |
| *** VijayB has joined #openstack-lbaas | 17:10 | |
| VijayB | blogan: You there? | 17:10 |
| *** mestery has quit IRC | 17:10 | |
| dougwig | it's my turn to run to lunch, and it's a meeting, so i'll be back in about an hour. | 17:10 |
| VijayB | blogan: You need to amend the commit to replace Co-authored-by: Vijay Venkatachalam <Vijay.Venkatachalam@citrix.com> with Vijayendra Bhamidipati <vbhamidipati@paypal.com> | 17:11 |
| dougwig | if avishnoi shows back up, i was able to chase down the instance id in the api by going from pool -> member -> nova list, and then matching on either the float or fixed ip. i didn't find a cleaner path. | 17:11 |
| VijayB | people are getting confused between us all the time since we both were with Citrix at one time D: | 17:11 |
| dougwig | i just read that as "we were both born at citrix at the same time", and i thought "whoa, hardcore. wait, that can't be right." | 17:12 |
| blogan | dougwig: if just needing to update the status then either method works, update_status or update_healthmonitor, however with the update_healthmonitor you dont need a reference to the sqlalchemy model class | 17:12 |
| dougwig | shit, i need some caffeine. | 17:12 |
| blogan | VijayB: i was going to ask you but I saw that was the email you've been using so I wasn't sure | 17:12 |
| dougwig | the v1 method takes both the hm object AND the pool object, i assume for associate? | 17:12 |
| VijayB | dougwig: Hahaha no we weren't born at Citrix at the same time, but highly probable that we were both born in the same city ;) | 17:13 |
| blogan | VijayB: lol that wasn't you | 17:13 |
| blogan | VijayB: sorry man | 17:13 |
| VijayB | blogan: Np! ;) | 17:13 |
| blogan | i remember you said you used to work at citrix so i thought that was you | 17:13 |
| blogan | the real problem is too many Vijays | 17:13 |
| blogan | dougwig: yes taht is correct | 17:14 |
| VijayB | hahaha yeah too many Vijays.. it's all because of a very famous actor of the 80s.. all his movies had his name as Vijay.. so Moms went crazy | 17:14 |
| blogan | lol | 17:14 |
| blogan | i was named after a soap opera character :( | 17:15 |
| VijayB | blogan: that would make us cross continental brothers ;p | 17:15 |
| blogan | i feel your pain! | 17:17 |
| VijayB | <:'( | 17:17 |
| VijayB | same here v_v | 17:17 |
| *** sballe has quit IRC | 17:18 | |
| *** avishnoi has joined #openstack-lbaas | 17:36 | |
| rm_work | VijayB: do you know if vivek is in today? | 17:37 |
| rm_work | (you're both at ebay, right?) | 17:38 |
| avishnoi | dougwig: there? | 17:43 |
| blogan | avishnoi: he went to get some lunch but told me to tell you: | 17:47 |
| blogan | if avishnoi shows back up, i was able to chase down the instance id in the api by going from pool -> member -> nova list, and then matching on either the float or │ | 17:47 |
| blogan | │ | fixed ip. i didn't find a cleaner path. | 17:47 |
| blogan | that did not paste correctly | 17:47 |
| blogan | but its legible | 17:47 |
| avishnoi | yeah, that's the way i also figured out. | 17:48 |
| avishnoi | blogan: thanks for conveying the message blogan | 17:48 |
| *** vjay has quit IRC | 17:48 | |
| blogan | np | 17:49 |
| avishnoi | so can i raise bug/enhancement for this ? | 17:49 |
| avishnoi | because i think if member object contains the reference to instance -id it will be more convenient for folks who wants to collect stats for each pool member from ceilometer | 17:50 |
| *** sbalukoff has joined #openstack-lbaas | 17:50 | |
| enikanorov_ | avishnoi: theoretically a member is not necessarily a VM | 17:53 |
| enikanorov_ | so it might not have id | 17:53 |
| enikanorov_ | but i'm fine with such enchancement | 17:54 |
| *** TrevorV_ has joined #openstack-lbaas | 17:55 | |
| *** rolledba_ has joined #openstack-lbaas | 18:03 | |
| avishnoi | okay | 18:04 |
| avishnoi | enikanorov_: can you give be example of any other possible candidate for members ? | 18:04 |
| avishnoi | enikanorov_: can port be a member ? | 18:04 |
| enikanorov_ | port - no. right now member is just an ip | 18:04 |
| enikanorov_ | nowhere is stated that it is a VM | 18:05 |
| enikanorov_ | it can be ip address outside the subnet | 18:05 |
| *** rolledback has quit IRC | 18:06 | |
| avishnoi | okay, but the way i am looking at this enhancement is -- to include the associated resource object in the member object details IF ANY | 18:07 |
| avishnoi | that way i think we are not making this exceptional case for VM | 18:07 |
| VijayB | rm_work: Hey Adam, both Vivek and I are in a meeting.. he's in today.. I'll let him know so he can ping you after the meeting's over.. | 18:07 |
| rm_work | VijayB: ok… i just want to catch him before he spends a lot of time on those tests (hopefully i am in time) because some stuff changed | 18:08 |
| rm_work | and also I got a few of them done yesterday at the barbican mid-cycle meet | 18:08 |
| avishnoi | enikanorov_: can you direct me, where i can create this enhacement/bug ? launchpad? or do we have bugzilla ? | 18:09 |
| enikanorov_ | avishnoi: launchpad https://bugs.launchpad.net/neutron | 18:09 |
| avishnoi | enikanorov_: cool thanks | 18:10 |
| VijayB | rm_work: Sure will let him know.. | 18:11 |
| *** vivek-ebay has joined #openstack-lbaas | 18:15 | |
| *** avishnoi has quit IRC | 18:30 | |
| *** fnaval has quit IRC | 18:32 | |
| *** avishnoi has joined #openstack-lbaas | 18:46 | |
| vivek-ebay | @rm_work hey | 18:48 |
| rm_work | hey | 18:48 |
| rm_work | so, it looks like the admin-api is being deprecated probably | 18:48 |
| rm_work | so I ported the code over to the main API | 18:49 |
| vivek-ebay | oh ok...thats great. | 18:49 |
| rm_work | with RBAC rules to restrict access | 18:49 |
| rm_work | yeah, makes testing much easier | 18:49 |
| vivek-ebay | :) | 18:49 |
| rm_work | i did a few of the tests | 18:49 |
| rm_work | i am going to check those in | 18:49 |
| rm_work | and i need to work on some local fires right now... | 18:49 |
| rm_work | so if you wanted to go from there | 18:49 |
| vivek-ebay | ok got it. I see some pushes from you yesterday | 18:50 |
| rm_work | i need to do another | 18:50 |
| rm_work | and … i don't know what I was thinking, but I literally just removed the admin-api | 18:50 |
| rm_work | i need to undo that | 18:50 |
| vivek-ebay | :) | 18:50 |
| rm_work | since that will be a separate BP/CR obviously, lol | 18:50 |
| rm_work | anyway, i pushed the tests | 18:51 |
| rm_work | running tox should come up clean | 18:51 |
| rm_work | and coverage is… non-zero ;P | 18:51 |
| rm_work | I based the two sections I added on the existing container tests | 18:51 |
| *** rolledba_ has quit IRC | 18:54 | |
| *** markmcclain has joined #openstack-lbaas | 18:59 | |
| *** mestery has joined #openstack-lbaas | 18:59 | |
| *** mestery has quit IRC | 18:59 | |
| *** mestery has joined #openstack-lbaas | 18:59 | |
| blogan | mestery: did you get earlier message about the review? | 19:00 |
| *** markmcclain1 has joined #openstack-lbaas | 19:00 | |
| mestery | blogan: I did, will look | 19:00 |
| blogan | mestery: its more just a question about whether it should be broken up into smaller chunks, and if so how should that be done | 19:01 |
| mestery | blogan: That's always the million dollar question :) | 19:02 |
| mestery | blogan: I think that myself and amotoki are the cores on your patch, let me talk to him and figure this out. | 19:03 |
| *** markmcclain has quit IRC | 19:03 | |
| blogan | mestery: excellent, thanks very much | 19:03 |
| *** sbfox has quit IRC | 19:04 | |
| vivek-ebay | rm_work: what is tox command to run just one test method ? | 19:10 |
| rm_work | i don't know | 19:10 |
| rm_work | i was running them in PyCharm | 19:10 |
| vivek-ebay | how do you run it ? | 19:11 |
| vivek-ebay | ok | 19:11 |
| rm_work | right click on method -> Run/Debug | 19:11 |
| rm_work | easy peasy :P | 19:11 |
| *** avishnoi has quit IRC | 19:14 | |
| enikanorov_ | blogan: usually it's API, DB and Driver part | 19:15 |
| enikanorov_ | blogan: initially it was done that way | 19:15 |
| blogan | enikanorov_: by API do you mean extension? | 19:19 |
| enikanorov_ | blogan: yes | 19:19 |
| blogan | enikanorov_: I can definitely do that, and just link the reviews together? | 19:19 |
| enikanorov_ | blogan: i think it should be done as a sequence of patches depending one on another | 19:20 |
| enikanorov_ | so the last one is collecting whole work | 19:20 |
| enikanorov_ | blogan: there should be something here https://wiki.openstack.org/wiki/Gerrit_Workflow for the reference | 19:21 |
| blogan | enikanorov_: excuse my ignorance, but by patches do you mean commits in the same review or, patch sets in the same review, or separate reviews? | 19:21 |
| enikanorov_ | blogan: that would be several separate reviews, such that next review depends on previous one | 19:22 |
| enikanorov_ | so when you checkout the last one of such sequence, you'll get whole work | 19:22 |
| enikanorov_ | here it is: https://wiki.openstack.org/wiki/Gerrit_Workflow#Add_dependency | 19:22 |
| blogan | on that link is it the last part? | 19:22 |
| blogan | yep | 19:22 |
| blogan | okay that seems to be the easiest thing to do | 19:23 |
| enikanorov_ | an example: https://review.openstack.org/#/c/89694/ | 19:23 |
| blogan | awesome thainks enikanorov_! | 19:25 |
| blogan | *thanks | 19:26 |
| *** TrevorV_ has quit IRC | 19:26 | |
| *** TrevorV_ has joined #openstack-lbaas | 19:27 | |
| *** markmcclain has joined #openstack-lbaas | 19:36 | |
| *** markmcclain1 has quit IRC | 19:37 | |
| *** VijayB has quit IRC | 19:37 | |
| *** vivek-ebay has quit IRC | 19:38 | |
| *** sbfox has joined #openstack-lbaas | 19:44 | |
| dougwig | vivek-ebay: tox -e py27 neutron.tests.unit.blah:Class | 19:49 |
| blogan | enikanorov_: each one of those separate reviews needs to have its own unit tests, and those unit tests need to pass correct? | 19:53 |
| enikanorov_ | blogan: it's preferable. | 19:54 |
| enikanorov_ | btw existing unit tests imo are messy | 19:54 |
| enikanorov_ | they test plugin and extension at once | 19:54 |
| blogan | enikanorov_: lol ive noticed | 19:55 |
| enikanorov_ | i'd prefer seeing separate tests where extension is tested for validation and policy and plugin is tested for persistence logic and such | 19:55 |
| enikanorov_ | but that's too much of routine work | 19:55 |
| blogan | eniaknorov_: i was actually going to do that after this is all done | 19:56 |
| blogan | enikanorov_: but that makes separating the extension and plugin/db layer tough bc those tests wont pass | 19:57 |
| enikanorov_ | well, then they just go with the part that can actually be tested | 19:57 |
| enikanorov_ | (e.g. plugin or db plugin part) | 19:58 |
| blogan | enikanorov_: yeah, it just might not cut down on the number of lines as much as people wants, but i'll just have to do what I can | 19:58 |
| dougwig | blogan: ok, so we agreed that v1 hm status used two objects. did you modify v2 to only need one? | 20:03 |
| *** jorgem has quit IRC | 20:04 | |
| blogan | dougwig: yes because that was due to the many to many relationship pools and hms had in v1 versus the many-to-one (or even one-to-one) in v2 | 20:04 |
| dougwig | ahh, then we can keep it with update_status and the interface remains consistent? i like that much better. | 20:04 |
| dougwig | ok, unless you scream, i'll update the noop driver for that + deletes, and make a few other tweaks, and send a pull request to you. | 20:05 |
| blogan | yes, though i reserve the right to scream, this is a very fluid thing right now | 20:06 |
| dougwig | screaming in fluid sounds dangerous | 20:06 |
| dougwig | you'll drown | 20:06 |
| blogan | only if i breathe back in for another scream, then I'll just have projectile water vomit | 20:06 |
| blogan | or drown | 20:07 |
| *** vivek-ebay has joined #openstack-lbaas | 20:08 | |
| *** vivek-ebay has quit IRC | 20:09 | |
| *** vivek-ebay has joined #openstack-lbaas | 20:09 | |
| dougwig | vivek-ebay: tox -e py27 neutron.tests.unit.blah:Class | 20:09 |
| vivek-ebay | thanks dougwig | 20:10 |
| dougwig | this gets you reasonably quick and complete coverage for our stuff: | 20:11 |
| dougwig | https://www.irccloud.com/pastebin/TsKYO6sT | 20:11 |
| *** fnaval has joined #openstack-lbaas | 20:12 | |
| *** sbfox has quit IRC | 20:14 | |
| blogan | dougwig: thanks for fixing those py26 issues, i wasn't looking forward to doing that | 20:15 |
| dougwig | np, it was a slow dr. who episode. | 20:15 |
| blogan | lol | 20:16 |
| blogan | yeah I'd like to really clean those tests up to be real unit tests but in the interest of time i decided to follow the same process | 20:16 |
| blogan | actually doing that would be a good learning exercise for anyone who wants to learn the code base though | 20:17 |
| *** VijayB has joined #openstack-lbaas | 20:20 | |
| *** dlundquist has left #openstack-lbaas | 20:25 | |
| dougwig | concur, it would, don't you have interns? :) | 20:26 |
| *** sbfox has joined #openstack-lbaas | 20:28 | |
| dougwig | well, fixing the noop driver shrinks your diff by 147 lines. 3000 more to go. | 20:29 |
| *** TrevorV_ has quit IRC | 20:30 | |
| *** mestery has quit IRC | 20:32 | |
| blogan | we have one intern but he's on our existing lbaas product | 20:34 |
| blogan | dougwig: ive got a decent idea on how to break it up | 20:35 |
| dougwig | let me give you a quick PR before you structural hammer on things, to make my merge life easier? :) | 20:35 |
| blogan | lol sounds good | 20:35 |
| blogan | one win though, jenkins +1'ed the latest patch set | 20:35 |
| dougwig | woohoo | 20:37 |
| dougwig | hmm, one tiny change in your db test and it exploded, which means that the noop driver has something way broken. standby. | 20:37 |
| *** sab has joined #openstack-lbaas | 20:44 | |
| blogan | oh and i meant to change that noop driver in the tests to use yours, though i would have made some changes | 20:47 |
| dougwig | i'm doing that now, no worries. | 20:48 |
| dougwig | and there are changes. | 20:48 |
| *** sab has quit IRC | 20:48 | |
| dougwig | to the driver, not the test. test was a one-liner. | 20:48 |
| *** vivek-ebay has quit IRC | 20:48 | |
| *** vivek-ebay has joined #openstack-lbaas | 20:49 | |
| dougwig | blogan: is there a reason your passing id directly to stats() and not the lb obj? | 20:54 |
| blogan | to the driver? | 20:54 |
| dougwig | yes. | 20:54 |
| dougwig | your noop signature: - def stats(self, context, load_balancer_id): | 20:55 |
| dougwig | abstract signature: def stats(self, context, obj): | 20:55 |
| blogan | no particular reason, just following the plugin convention, that can certainly be changed | 20:55 |
| dougwig | second question, most of the deletes are of the form _db_delete_obj (e.g. _db_delete_pool), but member is delete_member(). any reason? :) | 20:55 |
| *** mestery has joined #openstack-lbaas | 20:56 | |
| dougwig | ok on stats, let me give you this pull using _id instead of obj, and if we want to switch it later, it can be separate. | 20:56 |
| blogan | ah so that was because the api's delete member actually calls delete_pool_member, so I just called the actual db method delete_member, it can be changed to be consistent for sure | 20:58 |
| blogan | though all that woudl be solved by doing composition with the database instead of inheritance, which i was planning on experiementing with but haven't had the time yet | 20:59 |
| dougwig | just making sure it was expected. | 21:01 |
| dougwig | i've got dueling unit tests now due to the stats() mismatch, one sec while i resolve that. | 21:02 |
| blogan | okay | 21:02 |
| *** markmcclain has quit IRC | 21:07 | |
| dougwig | pr up | 21:11 |
| blogan | oh yeah on the stats i have a feeling people are gong to want stats per pool | 21:17 |
| dougwig | yep, i figured we'd eventually put stats on everything. | 21:20 |
| dougwig | but as a driver guy, i'd still rather call obj.id than have to go look up the id if i happen to need meta-data to finish my request. | 21:21 |
| dougwig | it's like a ninth order issue of consistency. nothing to worry about. | 21:24 |
| dougwig | but stats is its own mixin because i expected it to get added to other objects before juno shipped. | 21:24 |
| blogan | oh no | 21:25 |
| blogan | fail review on my part | 21:25 |
| blogan | i had squashed your previous PR into the same commit, and i don't think you got that change in | 21:26 |
| dougwig | need another push, or can you recover? | 21:28 |
| blogan | attempting to recover, but another push might be the easiest | 21:29 |
| blogan | one sec | 21:29 |
| dougwig | worst case, it's gotta still be in my fork: https://github.com/dougwig/neutron-oslbaas/tree/bp/lbaas-api-and-objmodel-improvement | 21:30 |
| blogan | reflog is always the safety net | 21:30 |
| *** mestery has quit IRC | 21:33 | |
| *** mestery has joined #openstack-lbaas | 21:33 | |
| blogan | okay do another PR | 21:34 |
| blogan | repull though | 21:34 |
| dougwig | ok, one sec. | 21:34 |
| dougwig | let me just archive my local first | 21:35 |
| blogan | sounds good | 21:35 |
| blogan | what is in gerrit vs whats on the oslbaas branch is the same | 21:36 |
| dougwig | git think it's up to date, and then the pull is 4000 lines. one sec, let me see if a recursive diff will be cleaner. | 21:38 |
| blogan | you're probably just better off deleting your local branch and just repulling, of course after you get the changes you just made out of the local branch | 21:39 |
| dougwig | yep, got the patch. let me apply to a new branch. | 21:40 |
| dougwig | there you go | 21:42 |
| blogan | much better, thanks, sorry for the trouble | 21:43 |
| dougwig | it's no biggee, i'll just hate you forever. | 21:43 |
| blogan | you already did so it meant nothing | 21:43 |
| dougwig | right, right. let me go back to sharpening my knives and dreaming of revenge. | 21:44 |
| blogan | whats the email gerrit recognizes you with? | 21:45 |
| dougwig | dougw@a10networks.com | 21:45 |
| blogan | ok squashed and repushed | 21:47 |
| blogan | back to oslbaas | 21:47 |
| blogan | time for breaking apart | 21:56 |
| *** fnaval has quit IRC | 22:00 | |
| *** fnaval has joined #openstack-lbaas | 22:06 | |
| *** arosen has joined #openstack-lbaas | 22:43 | |
| *** arosen has left #openstack-lbaas | 22:43 | |
| *** sbfox has quit IRC | 22:48 | |
| *** sbfox has joined #openstack-lbaas | 23:00 | |
| *** fnaval has quit IRC | 23:01 | |
| dougwig | the review shrunk by just a wee bit. :) | 23:02 |
| blogan | lol | 23:03 |
| dougwig | ok all, it's time to start +1'ing the smaller review chunks, so we can start to get stuff in: https://review.openstack.org/#/c/105331/ | 23:05 |
| dougwig | please put your feedback in there so blogan can get to patchset 50. | 23:05 |
| dougwig | oh, you beat me to the mailing list. nvm. | 23:06 |
| *** VijayB_ has joined #openstack-lbaas | 23:06 | |
| blogan | well i put all but the first as a WIP bc they will still be changing | 23:08 |
| blogan | well more like additions being made | 23:08 |
| blogan | i know people are going to not like the tests not being in the same review as the pieces it is testing | 23:09 |
| *** VijayB has quit IRC | 23:09 | |
| *** VijayB_ has quit IRC | 23:16 | |
| *** VijayB has joined #openstack-lbaas | 23:16 | |
| *** fnaval has joined #openstack-lbaas | 23:18 | |
| blogan | alright ill bbl | 23:22 |
| *** blogan is now known as zz_blogan | 23:22 | |
| *** sbfox has quit IRC | 23:25 | |
| *** vivek-ebay has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!