*** Aish has joined #openstack-lbaas | 00:05 | |
*** vivek-eb_ has quit IRC | 00:14 | |
*** banix has quit IRC | 00:23 | |
*** mlavalle has quit IRC | 00:31 | |
*** jamiem has quit IRC | 00:40 | |
*** mwang2 has quit IRC | 00:45 | |
*** fnaval has quit IRC | 00:54 | |
*** fnaval has joined #openstack-lbaas | 01:01 | |
*** banix has joined #openstack-lbaas | 01:06 | |
*** apuimedo has quit IRC | 01:12 | |
*** vivek-ebay has joined #openstack-lbaas | 01:20 | |
*** banix has quit IRC | 01:22 | |
*** vivek-ebay has quit IRC | 01:22 | |
*** vivek-ebay has joined #openstack-lbaas | 01:23 | |
*** vivek-ebay has quit IRC | 01:36 | |
*** banix has joined #openstack-lbaas | 01:40 | |
*** sbfox has joined #openstack-lbaas | 01:44 | |
*** woodster_ has quit IRC | 02:00 | |
*** sbfox has quit IRC | 02:21 | |
*** sbfox has joined #openstack-lbaas | 02:36 | |
*** woodster_ has joined #openstack-lbaas | 02:39 | |
*** sbfox has quit IRC | 02:42 | |
*** BrianShang has quit IRC | 02:50 | |
*** BrianShang has joined #openstack-lbaas | 02:52 | |
*** amotoki has joined #openstack-lbaas | 02:53 | |
*** xgerman has joined #openstack-lbaas | 02:55 | |
openstackgerrit | Madhusudhan Kandadai proposed openstack/neutron-lbaas: Added negative public API tempest tests https://review.openstack.org/165627 | 03:06 |
---|---|---|
*** amotoki has quit IRC | 03:11 | |
*** xgerman has quit IRC | 03:18 | |
*** xgerman_ has joined #openstack-lbaas | 03:18 | |
*** sbfox has joined #openstack-lbaas | 03:27 | |
*** vivek-ebay has joined #openstack-lbaas | 03:36 | |
*** xgerman_ has quit IRC | 04:02 | |
*** mwang2 has joined #openstack-lbaas | 04:06 | |
*** amotoki has joined #openstack-lbaas | 04:09 | |
*** vivek-eb_ has joined #openstack-lbaas | 04:12 | |
*** vivek-ebay has quit IRC | 04:14 | |
*** banix has quit IRC | 04:27 | |
*** mwang2 has quit IRC | 04:45 | |
*** BrianShang_ has joined #openstack-lbaas | 04:46 | |
*** BrianShang has quit IRC | 04:49 | |
*** amotoki_ has joined #openstack-lbaas | 05:00 | |
*** chlong has quit IRC | 05:02 | |
*** Aish has quit IRC | 05:16 | |
*** chlong has joined #openstack-lbaas | 05:19 | |
openstackgerrit | min wang proposed stackforge/octavia: Add the config file for nova compute drive https://review.openstack.org/163240 | 05:26 |
*** chlong has quit IRC | 06:01 | |
*** vivek-eb_ has quit IRC | 06:07 | |
*** chlong has joined #openstack-lbaas | 06:13 | |
*** Santosh_NS_ has joined #openstack-lbaas | 06:34 | |
*** fnaval has quit IRC | 07:02 | |
*** fnaval has joined #openstack-lbaas | 07:03 | |
*** fnaval has quit IRC | 07:07 | |
*** chlong has quit IRC | 07:45 | |
*** sbfox has quit IRC | 08:10 | |
*** apuimedo has joined #openstack-lbaas | 08:20 | |
*** openstackgerrit has quit IRC | 08:22 | |
*** openstackgerrit has joined #openstack-lbaas | 08:22 | |
*** vivek-ebay has joined #openstack-lbaas | 09:08 | |
*** vivek-ebay has quit IRC | 09:12 | |
*** amotoki has quit IRC | 09:37 | |
*** mwang2 has joined #openstack-lbaas | 10:41 | |
*** mwang2 has quit IRC | 10:46 | |
*** BrianShang_ has quit IRC | 10:48 | |
*** BrianShang has joined #openstack-lbaas | 10:49 | |
*** enikanorov has quit IRC | 10:54 | |
*** enikanorov has joined #openstack-lbaas | 10:55 | |
*** BrianShang has quit IRC | 11:01 | |
*** BrianShang has joined #openstack-lbaas | 11:02 | |
*** enikanorov has quit IRC | 11:04 | |
*** enikanorov has joined #openstack-lbaas | 11:05 | |
*** enikanorov has quit IRC | 11:06 | |
*** enikanorov has joined #openstack-lbaas | 11:07 | |
*** enikanorov has quit IRC | 11:26 | |
*** enikanorov has joined #openstack-lbaas | 11:27 | |
*** enikanorov has quit IRC | 11:30 | |
*** enikanorov has joined #openstack-lbaas | 11:31 | |
*** enikanorov has quit IRC | 11:39 | |
*** enikanorov has joined #openstack-lbaas | 11:40 | |
*** mestery is now known as mestery_afk | 11:45 | |
*** Santosh_NS_ has quit IRC | 12:04 | |
*** enikanorov has quit IRC | 13:09 | |
*** enikanorov has joined #openstack-lbaas | 13:11 | |
*** amotoki_ has quit IRC | 13:35 | |
*** amotoki has joined #openstack-lbaas | 13:35 | |
*** raginbajin has joined #openstack-lbaas | 13:55 | |
*** localloop127 has joined #openstack-lbaas | 14:07 | |
*** TrevorV|Home has joined #openstack-lbaas | 14:08 | |
*** Aish has joined #openstack-lbaas | 14:14 | |
*** mestery_afk has quit IRC | 14:19 | |
*** enikanorov has quit IRC | 14:47 | |
*** fnaval has joined #openstack-lbaas | 14:47 | |
*** enikanorov has joined #openstack-lbaas | 14:48 | |
*** vivek-ebay has joined #openstack-lbaas | 14:54 | |
*** xgerman_ has joined #openstack-lbaas | 15:09 | |
sballe | Morning | 15:14 |
*** mestery has joined #openstack-lbaas | 15:15 | |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Included more api test cases for neutron-lbaas https://review.openstack.org/165716 | 15:16 |
rm_work | morning | 15:18 |
*** ajmiller has joined #openstack-lbaas | 15:19 | |
*** fnaval has quit IRC | 15:21 | |
*** openstackgerrit has quit IRC | 15:21 | |
*** openstackgerrit has joined #openstack-lbaas | 15:22 | |
*** fnaval has joined #openstack-lbaas | 15:35 | |
*** mlavalle has joined #openstack-lbaas | 15:50 | |
*** vivek-eb_ has joined #openstack-lbaas | 15:56 | |
*** vivek-ebay has quit IRC | 15:58 | |
*** banix has joined #openstack-lbaas | 16:04 | |
*** Aish has quit IRC | 16:05 | |
*** amotoki has quit IRC | 16:07 | |
*** amotoki has joined #openstack-lbaas | 16:07 | |
*** banix has quit IRC | 16:12 | |
*** banix has joined #openstack-lbaas | 16:16 | |
*** kbyrne has quit IRC | 16:18 | |
*** banix has quit IRC | 16:25 | |
*** BrianShang_ has joined #openstack-lbaas | 16:25 | |
*** sbfox has joined #openstack-lbaas | 16:27 | |
*** sbfox has quit IRC | 16:28 | |
*** sbfox has joined #openstack-lbaas | 16:28 | |
*** BrianShang has quit IRC | 16:28 | |
*** madhu__ has joined #openstack-lbaas | 16:34 | |
*** amotoki has quit IRC | 16:36 | |
*** vivek-eb_ has quit IRC | 16:36 | |
*** mlavalle has quit IRC | 16:51 | |
*** mwang2 has joined #openstack-lbaas | 17:05 | |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Included more api test cases for neutron-lbaas https://review.openstack.org/165716 | 17:07 |
*** Aish has joined #openstack-lbaas | 17:08 | |
*** openstackgerrit has quit IRC | 17:21 | |
*** openstackgerrit has joined #openstack-lbaas | 17:22 | |
*** banix has joined #openstack-lbaas | 17:25 | |
*** bharath has joined #openstack-lbaas | 17:38 | |
Aish | blogan: Is there any rule for giving a listener name? max length, invalid characters ?? | 17:41 |
xgerman_ | Aish you cna check in the database/datamodel how the tables are set up | 17:50 |
*** sbfox has quit IRC | 17:50 | |
Aish | xgerman_: thnks | 17:52 |
xgerman_ | rm_work: When you have a chance can you please review https://review.openstack.org/#/c/160034/ | 17:54 |
rm_work | sure | 17:55 |
xgerman_ | thanks a dozen | 17:55 |
xgerman_ | I am expeiclaly interested if I overlooked some TLS util functions | 17:56 |
*** sbfox has joined #openstack-lbaas | 17:57 | |
*** jorgem has joined #openstack-lbaas | 18:07 | |
*** banix has quit IRC | 18:19 | |
*** mlavalle has joined #openstack-lbaas | 18:19 | |
*** jorgem has quit IRC | 18:20 | |
*** banix has joined #openstack-lbaas | 18:24 | |
*** crc32 has joined #openstack-lbaas | 18:35 | |
*** dougwig has quit IRC | 18:39 | |
*** jorgem has joined #openstack-lbaas | 18:46 | |
*** banix has quit IRC | 18:50 | |
blogan | Aish: what xgerman said | 18:53 |
*** madhu__ has quit IRC | 18:58 | |
*** banix has joined #openstack-lbaas | 19:01 | |
*** jorgem has quit IRC | 19:10 | |
Aish | blogan: yup.. got it.. thnks :) | 19:20 |
openstackgerrit | min wang proposed stackforge/octavia: Add the config file for nova compute drive https://review.openstack.org/163240 | 19:20 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Amphora SSH Driver https://review.openstack.org/160964 | 19:25 |
*** TrevorV|Home has quit IRC | 19:26 | |
*** banix has quit IRC | 19:27 | |
*** xgerman_ has quit IRC | 19:30 | |
*** Trevor_V has joined #openstack-lbaas | 19:36 | |
*** apuimedo has quit IRC | 19:41 | |
*** dougw2 has joined #openstack-lbaas | 19:44 | |
*** ajmiller_ has joined #openstack-lbaas | 19:56 | |
*** ajmiller has quit IRC | 20:00 | |
*** madhu_ has joined #openstack-lbaas | 20:05 | |
*** dougwig has joined #openstack-lbaas | 20:13 | |
*** ajmiller_ is now known as ajmiller | 20:14 | |
*** jorgem has joined #openstack-lbaas | 20:23 | |
*** Trevor_V has quit IRC | 20:32 | |
*** localloop127 has quit IRC | 20:44 | |
*** xgerman has joined #openstack-lbaas | 20:45 | |
*** xgerman has quit IRC | 20:47 | |
*** xgerman has joined #openstack-lbaas | 20:48 | |
*** enikanorov has quit IRC | 20:50 | |
johnsom | blogan dougwig : I guess we have to get busy http://sched.co/2qbg | 20:51 |
*** enikanorov has joined #openstack-lbaas | 20:51 | |
rm_work | xgerman: hey | 20:51 |
xgerman | hey | 20:51 |
rm_work | xgerman: so how do you feel about ''.format()? :P | 20:51 |
blogan | johnsom: ill just do a dance routine | 20:52 |
xgerman | not very fondly - never worked for me | 20:52 |
rm_work | T_T | 20:52 |
xgerman | but I probably should learn it | 20:52 |
rm_work | I got distracted while reviewing that CR by the huge number of %substitutions | 20:52 |
rm_work | lol | 20:52 |
blogan | rm_work gets distracted by different approaches | 20:54 |
rm_work | %s substitution is supposed to be deprecated T_T | 20:54 |
rm_work | EVENTUALLY <_< | 20:54 |
rm_work | and .format() has many advantages | 20:54 |
xgerman | maybe, one thing I noticed was that it wouldn't substitute stuff | 20:55 |
rm_work | which wouldn't? | 20:55 |
xgerman | it's just "bla %s".format('bla') | 20:56 |
*** localloop127 has joined #openstack-lbaas | 20:56 | |
xgerman | and when you pass that as an argument it doesn't get substituted right away and causes errors | 20:57 |
xgerman | whereas magiclaly % gets substituted right away | 20:57 |
xgerman | now after two minutes I gave up on that | 20:57 |
xgerman | probably should push myse;lf harder ;-) | 20:58 |
rm_work | heh | 20:58 |
rm_work | "blah {0}".format('bla') | 20:58 |
rm_work | but more importantly | 20:58 |
xgerman | ah, thyat's what I did wrong | 20:58 |
xgerman | \me wonders where is dougwig and Ruby when you need him | 20:59 |
rm_work | "The {object_type} with IP {ip} was not found -- when making a(n) {object_type}, please use care!".format(object_type=a, ip=b) | 21:00 |
rm_work | and that it auto-casts | 21:00 |
rm_work | so you don't need to do str(a)\ | 21:01 |
rm_work | or str(b) | 21:01 |
dougwig | "The #{object_type} with IP #{ip} was not found" <- ruby. | 21:01 |
xgerman | yep | 21:01 |
dougwig | python string interpolation blows baby goats in comparison. | 21:01 |
xgerman | + 1 | 21:01 |
xgerman | no wonder I got confused | 21:01 |
rm_work | $mystring = "This is a string about $object_type and $ip"; | 21:01 |
rm_work | thanks PHP | 21:01 |
rm_work | for being dumb but still having decent string support | 21:02 |
rm_work | also BASH | 21:02 |
dougwig | where would the world be without print("hello %s world %s", "foo"); style security bugs? | 21:02 |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Included more API tests for listener creation/updation https://review.openstack.org/165716 | 21:02 |
rm_work | dougwig: does that print "hello foo world foo" or cause an exception or ??? | 21:03 |
dougwig | it reads and inserts random garbage from the stack. | 21:03 |
rm_work | awesome | 21:03 |
*** jorgem has quit IRC | 21:04 | |
xgerman | rm_work flag that and I will fix | 21:07 |
*** jorgem has joined #openstack-lbaas | 21:08 | |
rm_work | heh, I had originally flagged EVERY SINGLE ONE, but I decided to remove those comments, i just have a single comment per file about it | 21:08 |
rm_work | there were like 15 usages | 21:08 |
xgerman | yep | 21:08 |
xgerman | thanks though | 21:08 |
rm_work | "If you use .format() you don't need to do an explicit str() cast here. I recommend using .format() everywhere actually, but I don't think we ever came to an official consensus, and it would be good to be consistent. Right now I believe there are significant uses of both styles in our codebase." | 21:08 |
rm_work | is what I put | 21:08 |
*** localloop127 has quit IRC | 21:11 | |
xgerman | I can change it everywhere... | 21:11 |
rm_work | I mean, I'm all for that! but I thought it might actually merit a discussion | 21:11 |
johnsom | Hmm, I have gone off of this doc in the past: http://docs.openstack.org/developer/oslo.i18n/guidelines.html | 21:14 |
johnsom | Seems to encourage the %(name)s syntax | 21:14 |
rm_work | well it makes sense for | 21:15 |
rm_work | LOG.info(_LI('some message: variable=%s'), variable) | 21:15 |
rm_work | since this has actual distinct advantage | 21:15 |
rm_work | but raise ValueError(_('some message: v1=%(v1)s v2=%(v2)s') % {'v1': v1, 'v2': v2}) might as well use .format() | 21:16 |
rm_work | it's interesting that their docs still use %s tho | 21:16 |
rm_work | but being recommended by Oslo -- not sure whether that is a pro or a con <_< | 21:17 |
johnsom | hahah | 21:17 |
*** xgerman has quit IRC | 21:18 | |
*** xgerman has joined #openstack-lbaas | 21:19 | |
dougwig | if you really want to be on a the warpath, add a HACKING check. | 21:30 |
rm_work | heh | 21:30 |
rm_work | I might just :P | 21:30 |
*** banix has joined #openstack-lbaas | 21:31 | |
rm_work | I have been staring at this patchset for like 2 hours now | 21:35 |
rm_work | xgerman ate my productivity today entirely :P | 21:35 |
rm_work | almost done | 21:35 |
xgerman | thanks a ton | 21:36 |
rm_work | looks pretty good on the whole | 21:36 |
rm_work | you had a regex bug | 21:36 |
*** jorgem has quit IRC | 21:39 | |
rm_work | xgerman: review up, will get to the tests on Monday | 21:39 |
*** banix has quit IRC | 21:39 | |
xgerman | thanks | 21:40 |
madhu_ | blogan, dougwig: what is the max character length can the user give in for name/description while creating loadbalancer? | 21:50 |
*** enikanorov has quit IRC | 21:53 | |
*** enikanorov has joined #openstack-lbaas | 21:54 | |
madhu_ | fnaval : ^^ | 21:57 |
*** banix has joined #openstack-lbaas | 21:58 | |
*** banix has quit IRC | 22:00 | |
*** banix has joined #openstack-lbaas | 22:03 | |
*** sbfox has quit IRC | 22:10 | |
xgerman | I thought Aish looke dit up in DB | 22:18 |
*** madhu_ has quit IRC | 22:25 | |
Aish | madhu_: | 22:29 |
Aish | name = sa.Column(sa.String(255)) | 22:29 |
Aish | description = sa.Column(sa.String(255)) | 22:29 |
*** jorgem has joined #openstack-lbaas | 22:34 | |
*** mlavalle has quit IRC | 22:52 | |
*** enikanorov has quit IRC | 22:55 | |
*** enikanorov has joined #openstack-lbaas | 22:56 | |
*** jorgem has quit IRC | 23:01 | |
xgerman | after I stole rmworks productivity... can we get a +2 for https://review.openstack.org/163240 blogan? | 23:03 |
dougwig | xgerman: i crushed your hopes and dreams. | 23:21 |
xgerman | notthe first time | 23:22 |
*** dougw2 has quit IRC | 23:22 | |
*** enikanorov has quit IRC | 23:22 | |
*** enikanorov has joined #openstack-lbaas | 23:23 | |
*** banix has quit IRC | 23:24 | |
*** bharath has quit IRC | 23:32 | |
*** Aish has quit IRC | 23:32 | |
*** ajmiller has quit IRC | 23:46 | |
*** xgerman has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!