| *** xgerman has quit IRC | 00:08 | |
| madhu_ak | blogan, dougwig, fnaval: I get created a devstack setup on my new vm, after pulling the right tempest version using :1f88ecec48dd89cc101fdf30458ed177bd7f20ef, when I run the tests "tox -v -epy27", I could see bunch of errors : "from neutron.tests.unit import test_api_v2 | 00:13 |
|---|---|---|
| madhu_ak | ImportError: cannot import name test_api_v2" and "from neutron.tests.unit.openvswitch import test_agent_scheduler | 00:13 |
| madhu_ak | ImportError: No module named openvswitch | 00:13 |
| madhu_ak | The test run didn't actually run any tests | 00:13 |
| madhu_ak | ERROR: InvocationError: '/bin/sh tools/pretty_tox.sh '" | 00:13 |
| madhu_ak | exact error can be seen: https://review.openstack.org/#/c/165627/ | 00:15 |
| dougwig | madhu_ak: the fix for that is in the gate right now | 00:29 |
| madhu_ak | thanks for confirming dougwig. could you let me know once that fix is merged? | 00:32 |
| *** madhu_ak has quit IRC | 01:22 | |
| *** sbfox has joined #openstack-lbaas | 01:31 | |
| *** vivek-eb_ has quit IRC | 01:44 | |
| *** sbfox has quit IRC | 01:51 | |
| *** mugu has quit IRC | 02:01 | |
| *** Varun_Lodaya has quit IRC | 02:06 | |
| *** mugu has joined #openstack-lbaas | 02:15 | |
| *** vivek-ebay has joined #openstack-lbaas | 02:17 | |
| openstackgerrit | Merged openstack/neutron-lbaas: Rename imports based on neutron tests reorganization. https://review.openstack.org/170983 | 02:21 |
| dougwig | madhu_ak: ^^ | 02:22 |
| *** sbfox has joined #openstack-lbaas | 02:26 | |
| *** mwang2 has quit IRC | 02:32 | |
| *** fnaval has quit IRC | 02:47 | |
| *** Varun_Lodaya has joined #openstack-lbaas | 02:54 | |
| *** fnaval has joined #openstack-lbaas | 02:54 | |
| *** sbfox has quit IRC | 03:04 | |
| *** vivek-ebay has quit IRC | 03:06 | |
| *** xgerman has joined #openstack-lbaas | 03:16 | |
| *** xgerman has quit IRC | 03:18 | |
| *** vivek-ebay has joined #openstack-lbaas | 03:19 | |
| *** vivek-ebay has quit IRC | 03:30 | |
| *** vivek-ebay has joined #openstack-lbaas | 03:31 | |
| *** madhu_ak has joined #openstack-lbaas | 03:33 | |
| *** xgerman has joined #openstack-lbaas | 03:43 | |
| *** xgerman has quit IRC | 03:54 | |
| *** vivek-ebay has quit IRC | 04:00 | |
| *** rm_you| has joined #openstack-lbaas | 04:02 | |
| *** rm_you has quit IRC | 04:05 | |
| *** woodster_ has quit IRC | 04:20 | |
| *** sbfox has joined #openstack-lbaas | 04:35 | |
| *** woodster_ has joined #openstack-lbaas | 04:46 | |
| *** xgerman has joined #openstack-lbaas | 04:48 | |
| *** Varun_Lodaya has quit IRC | 04:55 | |
| *** TrevorV|Home has joined #openstack-lbaas | 04:57 | |
| *** xgerman has quit IRC | 05:03 | |
| *** TrevorV|Home has quit IRC | 05:05 | |
| *** fnaval has quit IRC | 05:06 | |
| *** madhu_ak has quit IRC | 05:07 | |
| *** Varun_Lodaya has joined #openstack-lbaas | 05:10 | |
| *** Varun_Lodaya has quit IRC | 05:41 | |
| *** apuimedo has joined #openstack-lbaas | 06:07 | |
| *** kobis has joined #openstack-lbaas | 06:21 | |
| *** kiran_ has joined #openstack-lbaas | 06:22 | |
| *** _kiran_ has joined #openstack-lbaas | 06:22 | |
| *** _kiran_ has quit IRC | 06:22 | |
| *** kiran_ is now known as kiran-r | 06:26 | |
| *** kobis has quit IRC | 06:28 | |
| *** kobis has joined #openstack-lbaas | 07:09 | |
| *** sbfox has quit IRC | 07:12 | |
| openstackgerrit | Merged openstack/neutron-lbaas: Updated from global requirements https://review.openstack.org/171398 | 07:25 |
| *** amotoki has joined #openstack-lbaas | 07:50 | |
| *** woodster_ has quit IRC | 07:50 | |
| *** Tiancheng has joined #openstack-lbaas | 08:27 | |
| *** mugu has quit IRC | 09:03 | |
| *** mugu has joined #openstack-lbaas | 09:06 | |
| openstackgerrit | Santosh Sharma proposed openstack/neutron-lbaas: changes to skip negative test cases with invalid/empty tenant_id https://review.openstack.org/171547 | 09:55 |
| *** rm_work has quit IRC | 10:04 | |
| *** rm_work has joined #openstack-lbaas | 10:06 | |
| *** rm_work has quit IRC | 10:06 | |
| *** rm_work has joined #openstack-lbaas | 10:06 | |
| openstackgerrit | enikanorov proposed openstack/neutron-lbaas: Use id attribute of the object in assert_modifications_allowed https://review.openstack.org/171567 | 10:52 |
| *** f13o has joined #openstack-lbaas | 10:52 | |
| *** Tiancheng has quit IRC | 12:02 | |
| openstackgerrit | Santosh Sharma proposed openstack/neutron-lbaas: changes to skip negative test cases with invalid/empty tenant_id https://review.openstack.org/171547 | 12:11 |
| *** woodster_ has joined #openstack-lbaas | 12:14 | |
| *** apuimedo has quit IRC | 13:50 | |
| *** chlong has quit IRC | 13:58 | |
| *** vivek-ebay has joined #openstack-lbaas | 14:24 | |
| *** kiran-r has quit IRC | 14:27 | |
| *** vivek-eb_ has joined #openstack-lbaas | 14:34 | |
| *** vivek-ebay has quit IRC | 14:36 | |
| *** Varun_Lodaya has joined #openstack-lbaas | 14:59 | |
| *** xgerman has joined #openstack-lbaas | 15:07 | |
| *** xgerman has quit IRC | 15:09 | |
| *** xgerman has joined #openstack-lbaas | 15:10 | |
| *** vivek-eb_ has quit IRC | 15:23 | |
| openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Amphora SSH Driver https://review.openstack.org/160964 | 15:56 |
| *** kiran has joined #openstack-lbaas | 15:58 | |
| *** kiran has quit IRC | 16:12 | |
| *** madhu_ak has joined #openstack-lbaas | 16:14 | |
| *** kiran has joined #openstack-lbaas | 16:17 | |
| *** Varun_Lodaya has quit IRC | 16:22 | |
| *** kiran has quit IRC | 16:25 | |
| *** kiran has joined #openstack-lbaas | 16:25 | |
| *** kiran has quit IRC | 16:30 | |
| *** mlavalle has joined #openstack-lbaas | 16:36 | |
| *** bharath has joined #openstack-lbaas | 16:37 | |
| *** enikanorov_ has quit IRC | 16:42 | |
| *** mwang2 has joined #openstack-lbaas | 16:43 | |
| *** kobis has quit IRC | 16:47 | |
| openstackgerrit | Al Miller proposed stackforge/octavia: Add devstack plugin for octavia https://review.openstack.org/167796 | 17:12 |
| *** amotoki has quit IRC | 17:20 | |
| *** vivek-ebay has joined #openstack-lbaas | 17:27 | |
| *** bharath has quit IRC | 17:31 | |
| *** bharath has joined #openstack-lbaas | 17:31 | |
| dougwig | morning all. do we want to plan a summer mid-cycle for lbaas/octavia coding? | 17:39 |
| *** Varun_Lodaya has joined #openstack-lbaas | 17:42 | |
| xgerman | yep | 17:43 |
| xgerman | I would aslo like to invite the VPN and FwaaS folks - since they probbaly don't have enough mass -- unless they are doing the Neutron midcycle | 17:43 |
| xgerman | I can get probably HP to host in Seattle | 17:44 |
| xgerman | put it on the agenda for today | 17:47 |
| *** Aish has joined #openstack-lbaas | 18:04 | |
| *** mwang2 has quit IRC | 18:05 | |
| *** mwang2 has joined #openstack-lbaas | 18:06 | |
| sballe | morning | 18:18 |
| sballe | xgerman: sounds like a good plan | 18:18 |
| sballe | both inviting FW and VPN and hosting it in Seattle | 18:18 |
| Santosh_NS | I would like to go through all docs/desgins for octavia . Starting with https://github.com/stackforge/octavia/blob/master/doc/source/design/version0.5/component-design.rst | 18:20 |
| Santosh_NS | If there are other pointers plz share | 18:20 |
| openstackgerrit | Merged openstack/neutron-lbaas: changes to skip negative test cases with invalid/empty tenant_id https://review.openstack.org/171547 | 18:22 |
| *** SumitNaiksatam has joined #openstack-lbaas | 18:22 | |
| xgerman | Santosh_NS those are our main documents but we haven't done a good job with keeping up on documentation | 18:27 |
| *** vivek-ebay has quit IRC | 18:31 | |
| openstackgerrit | min wang proposed openstack/neutron-lbaas: Introduced tempest API tests for openstack/neutron-lbaas https://review.openstack.org/168439 | 18:34 |
| openstackgerrit | Merged stackforge/octavia: Adds rise threshold to configuration generation https://review.openstack.org/171268 | 18:43 |
| *** sbalukoff has joined #openstack-lbaas | 18:54 | |
| *** vivek-ebay has joined #openstack-lbaas | 18:55 | |
| *** vivek-ebay has quit IRC | 18:57 | |
| openstackgerrit | Merged stackforge/octavia: Updates Jinja templater with additional optional params https://review.openstack.org/170906 | 19:16 |
| *** fnaval has joined #openstack-lbaas | 19:23 | |
| openstackgerrit | Franklin Naval proposed openstack/neutron-lbaas: Neutron LBaaS: Load Balancer Basic Scenario Test https://review.openstack.org/158904 | 19:24 |
| openstackgerrit | Franklin Naval proposed openstack/neutron-lbaas: Neutron_LBaaS: Update README for Tests https://review.openstack.org/161346 | 19:25 |
| *** madhu_ak has quit IRC | 19:31 | |
| *** enikanorov has joined #openstack-lbaas | 19:51 | |
| *** xgerman has quit IRC | 19:53 | |
| *** xgerman has joined #openstack-lbaas | 19:54 | |
| *** jorgem has joined #openstack-lbaas | 19:58 | |
| openstackgerrit | Franklin Naval proposed openstack/neutron-lbaas: Neutron_LBaaS: Update README for Tests https://review.openstack.org/161346 | 19:59 |
| openstackgerrit | Franklin Naval proposed openstack/neutron-lbaas: WIP: Neutron LBaaS: TLS Barbican Scenario Test https://review.openstack.org/164828 | 20:00 |
| *** madhu_ak has joined #openstack-lbaas | 20:05 | |
| *** vivek-ebay has joined #openstack-lbaas | 20:16 | |
| *** ptoohill-oo has joined #openstack-lbaas | 20:28 | |
| *** crc32 has joined #openstack-lbaas | 20:30 | |
| *** ptoohill-oo has quit IRC | 20:35 | |
| *** apuimedo has joined #openstack-lbaas | 20:43 | |
| *** sbfox has joined #openstack-lbaas | 20:47 | |
| *** vivek-ebay has quit IRC | 20:51 | |
| *** sbfox has quit IRC | 21:00 | |
| johnsom | blogan, you add it, I will call it. Are you going to update the spec and noop driver? | 21:02 |
| johnsom | After you push this through of course: https://review.openstack.org/#/c/171434/ | 21:02 |
| blogan | yeah, im goign to make a new review for it too | 21:03 |
| johnsom | Sounds good. Was there another topic? | 21:04 |
| blogan | whoops, i missed that, thanks for covering | 21:04 |
| blogan | johnsom: yeah, so the plug_vip method in the network driver is going to return a list of data models call AmpGroups (Please come up with a better name for them) | 21:05 |
| blogan | johnsom: basically it will contain the amphora_id, the bind_ip, and the ha_ip | 21:05 |
| blogan | the bind_ip will be the ip that the amphora will be listening on, while the ha_ip will be the ip that something like keepalived would use as a virtual ip | 21:05 |
| blogan | the ips can both be the same if the network driver decides that | 21:06 |
| openstackgerrit | Merged stackforge/octavia: Adding post_network_plug to the noop amphora driver https://review.openstack.org/171434 | 21:07 |
| blogan | there just has to be a way to tell the amphora what ip it's haproxy should be listening on, and what ha_ip it should use if it needs that, so this is what i came up with | 21:07 |
| xgerman | I think we can dynamically reconfigure keepalived - so no need for an ha ip? | 21:08 |
| blogan | but the controller worker would take that list of AmpGroups and insert the bind_ip and ha_ip into the db for each amphora | 21:08 |
| johnsom | Ok, so I would take that and send it down to the amp in post vip right? | 21:08 |
| blogan | xgerman: not for all network driver implementatiosn, for instance the allowed address pairs driver ive worked on allocates antoher ip for that, there's no way to dynamically figure out which ip that is | 21:09 |
| xgerman | Just trying to wrap my head around that: | 21:10 |
| blogan | johnsom: once you insert it and get a refresh load_balancer tree, you should just pass the load_balancer to the post_vip as it will probably need all the amphorae and the vip information | 21:10 |
| openstackgerrit | Merged openstack/neutron-lbaas: Use id attribute of the object in assert_modifications_allowed https://review.openstack.org/171567 | 21:10 |
| johnsom | Ok | 21:11 |
| blogan | xgerman: read this blog post | 21:11 |
| blogan | http://blog.aaronorosen.com/implementing-high-availability-instances-with-neutron-using-vrrp/ | 21:11 |
| xgerman | thanks | 21:12 |
| * xgerman reading | 21:12 | |
| blogan | xgerman: its essentially what the network driver will do, with a few minor changes | 21:12 |
| blogan | well the driver i've written | 21:13 |
| blogan | the driver we will use internally probably wont' even use the ha_ip field, even with an active active topology | 21:14 |
| dougwig | i love vrrp of nova instances, with no provision for ensuring separate compute nodes. | 21:15 |
| johnsom | dougwig yeah, there is still scheduler work to do | 21:15 |
| blogan | but that driver will still work with these data structures and workflow, and so will the allowed-address-pairs driver, and from what i remember will handle the network architecure yall mapped out in seattle, along with bluebox'es | 21:15 |
| blogan | babysteps dougwig | 21:16 |
| blogan | if yall could kind of map this out for what yall plan on doing with your implementation, and see if it will work for yall that'd be great, if it doesn't more work will need to be done to make sure it works for all of us | 21:18 |
| blogan | bbiab | 21:19 |
| *** SumitNaiksatam has quit IRC | 21:21 | |
| johnsom | blogan Does this work with dvr? | 21:22 |
| johnsom | blogan also, can we keep the option open to use unicast for the vrrp? | 21:25 |
| johnsom | vrrp_unicast_bind 192.168.1.11 # Internal IP of this machine | 21:26 |
| johnsom | vrrp_unicast_peer 192.168.1.12 # Internal IP of peer | 21:26 |
| xgerman | unicast ++ -- I don't want to set up a subnet for each haproxy cluster | 21:26 |
| xgerman | if I can help it ;-) | 21:26 |
| johnsom | I have heard rumblings of multicast issues in openstack deployments, so it might be best avoided if we can. | 21:28 |
| xgerman | +1 (we share the same source) | 21:31 |
| *** jorgem has quit IRC | 21:31 | |
| openstackgerrit | Carlos Garza proposed stackforge/octavia: Implementation for bp/api-to-oslo-messing-handler https://review.openstack.org/149079 | 21:37 |
| openstackgerrit | Carlos Garza proposed stackforge/octavia: Implementation for bp/api-to-oslo-messing-handler https://review.openstack.org/149079 | 21:46 |
| *** vivek-ebay has joined #openstack-lbaas | 21:51 | |
| *** vivek-ebay has quit IRC | 21:53 | |
| *** vivek-ebay has joined #openstack-lbaas | 21:53 | |
| *** amotoki has joined #openstack-lbaas | 21:54 | |
| *** jorgem has joined #openstack-lbaas | 22:00 | |
| *** chlong has joined #openstack-lbaas | 22:01 | |
| blogan | johnsom: those ips would essentially be all the amphora ips correct? | 22:01 |
| blogan | well all the amphora bind_ips | 22:01 |
| openstackgerrit | min wang proposed stackforge/octavia: Add health check amphora-driver-interface https://review.openstack.org/170599 | 22:01 |
| xgerman | blogan, yes | 22:02 |
| johnsom | The vrrp_unicast ips? They would be the HA IPs right? | 22:02 |
| blogan | the bind ip being the ip that haproxy would be listening on | 22:03 |
| xgerman | isn't ha_ip the one we trade around? | 22:03 |
| blogan | xgerman: yeah | 22:03 |
| blogan | the ha_ip would be the virtual ip basically, but not necessarily the vip the user sees | 22:04 |
| blogan | depends on the driver implementation | 22:04 |
| openstackgerrit | Madhusudhan Kandadai proposed openstack/neutron-lbaas: Introduced admin_api tempest tests https://review.openstack.org/171832 | 22:04 |
| johnsom | Now I am confused. If the HA IP is the one that floats between the Master/Slave AMP that is the address HAProxy will bind to right? | 22:06 |
| blogan | johnsom: in some implemetnations, yes, in others no | 22:06 |
| johnsom | It's a non-arp lo address | 22:06 |
| johnsom | ok | 22:06 |
| xgerman | let's talk about the one for devstack | 22:06 |
| blogan | so the one for devstack, the bind_ip would be in the haproxy config as the listen ip | 22:07 |
| xgerman | and the ha_ip would be the same? | 22:07 |
| blogan | the ha_ip would be the keepalvied conf | 22:07 |
| blogan | no they'd be different | 22:07 |
| johnsom | blogan assuming no vrrp? | 22:07 |
| blogan | assuming no vrrp, ha_ip deosn't really matter, unless you're donig some kind of active active topology that might need that ha_ip, which i dont know of any examples | 22:08 |
| xgerman | ok, so bind_ip is the one we are trading | 22:08 |
| blogan | xgerman: what do you mean by trading? | 22:09 |
| xgerman | if haproxy1 fails haproxy2 will grab | 22:09 |
| blogan | nope, thats the ha_ip | 22:09 |
| blogan | well it doesn't grab it | 22:09 |
| blogan | in this network driver | 22:10 |
| johnsom | Borrowing this: http://louwrentius.com/static/images/vrrp.png | 22:10 |
| johnsom | haproxy will listen on 10.0.1.140 on both master and slave | 22:11 |
| xgerman | yep, that was my thought, too | 22:11 |
| johnsom | typically it is on a non-arping lo interface | 22:11 |
| johnsom | 141 and 142 are used for vrrp communication | 22:11 |
| xgerman | (and potentially for our management network if wqe want to save a subnet) | 22:12 |
| johnsom | and outbound to the members | 22:12 |
| xgerman | bind_ip is the one outbound to the members? | 22:12 |
| johnsom | That would be my thought, but I think blogan has a different thought | 22:13 |
| xgerman | he usually has the same thought but we misunderstand him in the beginning :-) | 22:13 |
| johnsom | I guess you could do nonlocal bind and skip the lo interface | 22:14 |
| xgerman | well, I also like the ha_ip be in the tenant network | 22:15 |
| blogan | xgerman: ha in this case i don't think we have the same thought | 22:15 |
| xgerman | ok, explain | 22:15 |
| fnaval | hi - is the jenkins gate broken | 22:15 |
| dougwig | fnaval: is it a day ending in 'y' ? | 22:15 |
| fnaval | in english, yes | 22:16 |
| fnaval | ;-) | 22:16 |
| blogan | so in the allowed address pairs example, the ha_ip would not be an interface at all on teh amphora, just an entry in the keepalived conf as the virtual_ipaddress | 22:16 |
| blogan | the bind_ip would have an interface, and be different for each amphora, and that is what haproxy would listen on | 22:17 |
| blogan | so in that image 141 and 142 would be the bind_ips and 140 the ha_ip | 22:17 |
| blogan | but that doesn't mean another network driver can't implement it antoher way | 22:18 |
| johnsom | That works? I know you can get away with ip_nonlocal_bind, but I thought the listener had to have the IP 140 | 22:18 |
| xgerman | yep + from the blog you cited the ha_ip needs to be bound to some port on one of the josts | 22:18 |
| xgerman | host | 22:18 |
| blogan | so i have tested out the allowed-address-pairs, and it does work, i'm not sure of all the mechanics behind it, but i believe it just sets firewall rules to allow traffic destined for the ip specified in the allowed-address-pair port attribute, to go to the fixed ip | 22:19 |
| xgerman | yeah, I believe that | 22:20 |
| blogan | xgerman: actually the ha_ip doesn't even need to be bound to a port, he's jsut doing it so that ip address is reserved and won't be allocated in the future | 22:20 |
| xgerman | but haproxy needs to listen on some ip? | 22:20 |
| Aish | blogan: again to confirm… As a demo tenant, should we be able to create a listener with an empty/invalid tenant id? | 22:21 |
| blogan | yeah the fixed_ip for each of the ports that the nova-interface-attach call created | 22:21 |
| blogan | Aish: if by empty you mean providing an empty string then no it probably won't bc it will think you're tyring to add something under a tenant you dont have permissions to do so, but thats going through keystonemiddleware to do i believe | 22:23 |
| xgerman | ok, I think I understand | 22:24 |
| xgerman | haproxy listens on 10.0.0.3 and 10.0.0.4 repectively | 22:25 |
| xgerman | 10.0.0.201 get's added as an allowed address to both | 22:25 |
| blogan | yes | 22:25 |
| blogan | and like i said before this is not meant for any kind of production environment, just for the demo to get it out quickly, and if we want to show HA then we have that opportunity | 22:26 |
| blogan | otherwise it will still work with only one amphora | 22:26 |
| xgerman | ok, we can definitely build on that but in our cloud it's hard to say what works without actually truing it ;-) | 22:27 |
| blogan | xgerman: lol yeah we dont even have an environment to test our custom network driver out yet so we dont even know if it will work yet | 22:28 |
| xgerman | I will bring my shirt "works in devstack" :-) | 22:29 |
| blogan | so the case of haproxy binding to the ha_ip and the amphora using the bind_ip woudl require a different amphora driver than the ssh driver | 22:29 |
| blogan | and different network driver too probably | 22:30 |
| xgerman | well, I think what you did is fine | 22:30 |
| blogan | would still work, but i was hoping just a new network driver woudl be needed, not having to change the amp driver | 22:30 |
| xgerman | practically customers care more about from which address the packages come to their members | 22:31 |
| Aish | blogan: ok then, I think the existing tests are correct. | 22:31 |
| Aish | The failure occurs because while running tox -e tempest, it is actually creating the listener even when we give empty/invalid tenant id. | 22:31 |
| Aish | And, this newly created listener is not being deleted. That is why the subsequent tests fails with the “already has a listener with protocol_port of 80”. While running nosetests, there wasn’t any problem with the existing tests. | 22:31 |
| Aish | I am not sure why this happens though. | 22:32 |
| blogan | Aish: that is odd | 22:32 |
| Aish | blogan: yes.. | 22:33 |
| blogan | Aish: that is under the demo user? | 22:33 |
| Aish | yes blogan | 22:33 |
| blogan | Aish: it is actually allowing the creation of a listener with an empty string tenant_id? | 22:33 |
| Aish | nosetests doesn’t. but seems like tempest allows it | 22:34 |
| Aish | i mean tox -e tempest | 22:34 |
| Aish | blogan: ^^ | 22:34 |
| blogan | Aish: i bet when you run nose its using the /etc/tempest/tempest.conf which may have a different user, and tox -e tempest uses the octavia/tests/tempest/etc/tempest.conf | 22:35 |
| Aish | blogan: octavia/tests….?? | 22:36 |
| Aish | i ll take a look | 22:36 |
| blogan | Aish: yeah running tox -e tempest uses the octavia/tests/tempest/etc/tempest.conf config file | 22:37 |
| Aish | i ll check that blogan | 22:38 |
| Aish | blogan from the tox.ini I oculd see that it uses /neutron_lbaas/tests/tempest/etc/tempest.conf | 22:49 |
| Aish | and it is using admin credentials.. | 22:50 |
| blogan | and it passes with tox, and fails with nose right? | 22:50 |
| blogan | err, it depends on what pass and fail is | 22:51 |
| Aish | existing tests fails with tox and passes with nosetests as nosetests points to demo user | 22:51 |
| blogan | so it passes bc it expects a failure | 22:51 |
| blogan | is nosetests indeed using the /etc/tempest/tempest.conf? | 22:52 |
| Aish | yes. the test is actually for demo user.. and it is expected to pass. But, since the config file used by tox has admin credentials, it lets u create a listener with empty/invalid tenant id and that is not being deleted … | 22:52 |
| Aish | hence the subsequent tests faild | 22:53 |
| Aish | blogan: ^^ | 22:54 |
| blogan | Aish: that config file should probably be changed to use the demo user then | 22:54 |
| blogan | Aish: that one is my fault | 22:54 |
| *** jorgem has quit IRC | 22:54 | |
| *** sbfox has joined #openstack-lbaas | 22:54 | |
| Aish | ok. i can do that.. But, when we have to test for admin user, how do we do it then? | 22:54 |
| blogan | Aish: that i am unsure, i feel like tempest has config values for admin_users to tailor tests for in the same test suite, but im unsure | 22:55 |
| blogan | i am no tempest expert | 22:55 |
| Aish | hmmm.. .Okay.. So for now, can i change the config file to have demo user | 22:56 |
| blogan | Aish: yes please | 22:56 |
| Aish | okay blogan Thnk you,, | 22:57 |
| blogan | Aish: thank you | 22:57 |
| xgerman | ptoohill | 23:02 |
| xgerman | so back to logging | 23:02 |
| xgerman | I am still trying to wrap my head around it | 23:02 |
| xgerman | we fire up one haproxy per listener so for me to get logs they need to have different identifiers | 23:03 |
| xgerman | aka log 127.0.0.1 <identifier> notice | 23:03 |
| xgerman | how does that chime with the jinja engine? | 23:03 |
| *** chlong has quit IRC | 23:05 | |
| *** mlavalle has quit IRC | 23:08 | |
| xgerman | I guess foosball | 23:09 |
| *** sbfox has quit IRC | 23:09 | |
| blogan | xgerman: lol no he's gone, he'll be back later im sure | 23:13 |
| xgerman | yeah, I think we want logging to be like /var/log/haproxy-<listener-id>.log | 23:13 |
| blogan | xgerman: its 6pm bro! you west coasters live in the past | 23:13 |
| xgerman | just work on WestCoast time ;-) | 23:14 |
| xgerman | give you nice long mornings | 23:14 |
| blogan | and then leave on east coast time? | 23:14 |
| xgerman | square that with jorgem | 23:15 |
| blogan | xgerman: is there a review where you're having this discussion with ptoohill? | 23:15 |
| blogan | jorgem is just a puppet | 23:15 |
| xgerman | soon there will be ;-) | 23:15 |
| blogan | xgerman: ah okay, is it currently storing the logs in one file for all haproxy processes? | 23:16 |
| xgerman | yep | 23:16 |
| openstackgerrit | German Eichberger proposed stackforge/octavia: Adds a log identifier to the template https://review.openstack.org/171871 | 23:18 |
| xgerman | ^^^ blogan | 23:19 |
| openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Amphora SSH Driver https://review.openstack.org/160964 | 23:20 |
| blogan | xgerman: that just allows the location to be overridden in the template right? | 23:21 |
| xgerman | no, that allows to add an identifier | 23:21 |
| xgerman | then we need to make some rsyslogfile | 23:21 |
| blogan | well before it was always local0 | 23:22 |
| *** vivek-ebay has quit IRC | 23:22 | |
| xgerman | yep | 23:22 |
| blogan | so now its just defaults to it, but the driver should override it | 23:22 |
| xgerman | yep | 23:22 |
| blogan | for each listener | 23:22 |
| blogan | okay | 23:22 |
| xgerman | abd then according to http://kvz.io/blog/2010/08/11/haproxy-logging/ | 23:22 |
| xgerman | we need some syslogd file telling the computer that | 23:23 |
| xgerman | local1.* -/var/log/haproxy_1.log | 23:23 |
| xgerman | aka identifier -> different file | 23:23 |
| blogan | ill need to read up on that | 23:24 |
| xgerman | yeah, caught me by surprise, too | 23:25 |
| blogan | but you need tests :) | 23:25 |
| blogan | or modify the test | 23:25 |
| xgerman | they passed | 23:25 |
| xgerman | but feel free to -1 | 23:25 |
| blogan | a test that tests the identifier gets rendered correctly | 23:25 |
| blogan | hmm | 23:26 |
| blogan | it deafults to local0 though, so at that point you'd kind of just be testing python default arg overridden | 23:26 |
| xgerman | well it will also render | 23:26 |
| xgerman | so I felt it would be ok-ish the way it is | 23:27 |
| blogan | yeah but i wast hinking a test to make sure you passing in a different value for identifier would end up in an haproxy with that identifier, but the fact that it defaults to 'local0' and the tests already assume 'local0' and they pass, that tests it | 23:27 |
| blogan | so i retract my test comment | 23:27 |
| xgerman | thanks | 23:28 |
| *** amotoki has quit IRC | 23:29 | |
| blogan | gonna give ptoohill a chance to review it before i +2, but I +1'ed it | 23:29 |
| blogan | i gotta go now | 23:30 |
| blogan | adios | 23:30 |
| xgerman | bye | 23:30 |
| *** sbfox has joined #openstack-lbaas | 23:32 | |
| openstackgerrit | Merged stackforge/octavia: Add health check amphora-driver-interface https://review.openstack.org/170599 | 23:36 |
| *** sbfox has quit IRC | 23:43 | |
| *** apuimedo has quit IRC | 23:44 | |
| *** sbfox has joined #openstack-lbaas | 23:46 | |
| ptoohill | xgerman, good catch on that. When i updated for defaults i must have overwrote it and didnt notice. Though, i do have a comment on this that im about to make | 23:54 |
| xgerman | yeah, I am still wrapping my head around this logging thing | 23:54 |
| ptoohill | agreed, i need to look into it more if we want individual files for each listener | 23:57 |
| ptoohill | but how it is now: | 23:57 |
| ptoohill | the log0 line will log all http requests to the defined file, and local1 all haproxy (server) specific logs to the defined file | 23:58 |
| ptoohill | im sure theres a way to specidify per listener if thats what we want to accomplish. Again, keep in mind this was a cp/tweak from neutron so there are probably more gotchas that we want done | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
