openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas: Merge tag '2015.1.0' https://review.openstack.org/179304 | 00:13 |
---|---|---|
*** SumitNaiksatam has joined #openstack-lbaas | 00:24 | |
*** madhu_ak has quit IRC | 00:26 | |
*** hitalia has quit IRC | 00:31 | |
*** madhu_ak has joined #openstack-lbaas | 00:39 | |
*** clev-away is now known as clev | 00:44 | |
*** mwang2_ has quit IRC | 00:44 | |
*** clev is now known as clev-away | 01:00 | |
openstackgerrit | Al Miller proposed stackforge/octavia: Add devstack plugin for octavia https://review.openstack.org/167796 | 01:16 |
*** Aish has quit IRC | 01:25 | |
*** ajmiller has quit IRC | 01:25 | |
*** bharath has quit IRC | 01:28 | |
*** madhu_ak has quit IRC | 01:28 | |
*** fnaval has quit IRC | 01:51 | |
*** fnaval has joined #openstack-lbaas | 02:07 | |
*** clev-away is now known as clev | 02:27 | |
*** sbalukoff has joined #openstack-lbaas | 02:52 | |
*** hitalia has joined #openstack-lbaas | 03:04 | |
blogan | query ptoohill | 03:07 |
rm_you| | query blogan | 03:08 |
*** rm_you| is now known as rm_you | 03:08 | |
blogan | query rm_you| | 03:08 |
blogan | changed your name | 03:08 |
blogan | damnit! | 03:08 |
*** clev is now known as clev-away | 03:09 | |
ptoohill | query blogan | 03:10 |
*** clev-away is now known as clev | 03:18 | |
*** SumitNaiksatam has quit IRC | 03:59 | |
*** SumitNaiksatam has joined #openstack-lbaas | 04:00 | |
*** bharath has joined #openstack-lbaas | 04:29 | |
*** bharath has quit IRC | 04:34 | |
*** SumitNaiksatam has quit IRC | 04:51 | |
*** SumitNaiksatam has joined #openstack-lbaas | 04:53 | |
*** clev is now known as clev-away | 04:57 | |
*** clev-away is now known as clev | 05:11 | |
*** clev is now known as clev-away | 05:28 | |
*** rm_work|away is now known as rm_work | 06:05 | |
rm_work | such query | 06:06 |
*** chlong has quit IRC | 06:21 | |
*** chlong has joined #openstack-lbaas | 06:35 | |
*** chlong has quit IRC | 07:02 | |
*** woodster_ has quit IRC | 07:10 | |
*** chlong has joined #openstack-lbaas | 07:26 | |
*** chlong has quit IRC | 07:37 | |
*** chlong has joined #openstack-lbaas | 07:49 | |
*** chlong has quit IRC | 07:53 | |
*** chlong has joined #openstack-lbaas | 07:55 | |
*** chlong has quit IRC | 08:01 | |
*** chlong has joined #openstack-lbaas | 08:18 | |
*** chlong has quit IRC | 08:40 | |
*** chlong has joined #openstack-lbaas | 10:14 | |
*** hitalia has quit IRC | 10:14 | |
*** Miouge has joined #openstack-lbaas | 10:31 | |
*** chlong has quit IRC | 11:01 | |
*** chlong has joined #openstack-lbaas | 11:04 | |
*** SumitNaiksatam has quit IRC | 11:11 | |
*** chlong has quit IRC | 11:15 | |
*** Miouge has quit IRC | 11:46 | |
*** Miouge has joined #openstack-lbaas | 11:48 | |
*** Miouge has quit IRC | 11:55 | |
*** Miouge has joined #openstack-lbaas | 11:57 | |
*** woodster_ has joined #openstack-lbaas | 12:01 | |
*** Miouge has quit IRC | 12:05 | |
*** clev-away is now known as clev | 12:25 | |
*** TrevorV|Home has joined #openstack-lbaas | 12:48 | |
*** clev is now known as clev-away | 13:00 | |
*** clev-away is now known as clev | 13:00 | |
*** ajmiller has joined #openstack-lbaas | 13:10 | |
*** Miouge has joined #openstack-lbaas | 13:40 | |
*** Miouge has quit IRC | 13:40 | |
*** Miouge has joined #openstack-lbaas | 13:41 | |
*** openstackgerrit has quit IRC | 13:51 | |
*** openstackgerrit has joined #openstack-lbaas | 13:51 | |
*** fnaval has quit IRC | 14:14 | |
*** fnaval has joined #openstack-lbaas | 14:30 | |
ajmiller | ptoohill blogan I'm about to push a patch to octavia devstack that addresses your comments about the executable paths. | 14:43 |
TrevorV|Home | ajmiller, they'll be online within an hour or so, but its not typical they get online before that | 14:52 |
ajmiller | ok | 14:53 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Update vip and network plug methods https://review.openstack.org/179400 | 14:59 |
openstackgerrit | Al Miller proposed stackforge/octavia: Add devstack plugin for octavia https://review.openstack.org/167796 | 15:11 |
blogan | ajmiller: ping | 15:19 |
ajmiller | hey | 15:19 |
ajmiller | Nothing big, just wanted to touch base on fixing executable paths. I submitted a patch to that, and am not trying to figure out what I did with phil's code, it looks like I blew away some of his changes with a patch I made last night. | 15:20 |
blogan | ajmiller: why did you remove the api execution in the devstack plugin? | 15:20 |
blogan | ah okay | 15:21 |
ajmiller | yeah, I think it was a git fubar on my end | 15:21 |
ajmiller | Nothing I intended t odo. | 15:21 |
ajmiller | do. | 15:21 |
blogan | git + gerrit = mass fubars | 15:21 |
ajmiller | yes. | 15:22 |
ajmiller | Sorry about that. | 15:22 |
*** jorgem has joined #openstack-lbaas | 15:31 | |
ajmiller | blogan ptoohill I think the best thing to do is for me to try to put things back like they were before I made my checkin last night, then move forward from there. Comments? | 15:35 |
ajmiller | I've fetched that patchset into my repo, | 15:36 |
ajmiller | and if I push that as a review, the end of the patchset chain should be back to how it was before I messed it up last night. | 15:37 |
rm_work | yep sounds right | 15:38 |
blogan | ajmiller: thats usually what i do when i've done something like that | 15:38 |
blogan | go to the last known good state and replay the smaller changes | 15:39 |
ajmiller | yup, ok, thanks. The next review should put things back like they were at patchset 32 | 15:39 |
openstackgerrit | Al Miller proposed stackforge/octavia: Add devstack plugin for octavia https://review.openstack.org/167796 | 15:44 |
ajmiller | blogan can you have a look and double-check that I brought back the right stuff? | 15:46 |
blogan | ajmiller: sure | 15:46 |
ajmiller | thanks. | 15:46 |
ajmiller | After that I'll take a breather and then redo my changes. | 15:47 |
blogan | ajmiller: if all you did was pull down the old patchset and repush it, that'll definitely have those changes | 15:49 |
ajmiller | That's what I did, pulled patchset 32, amended the commit so that it has a new hash (otherwise gerrit woudlnt' accept it), and sent it back up. | 15:49 |
ajmiller | And I do see the API startup stuff in there that I didn't write. | 15:50 |
ajmiller | So we should be good to go. | 15:50 |
blogan | yeah i think so | 15:50 |
*** mlavalle has joined #openstack-lbaas | 15:55 | |
*** mlavalle has quit IRC | 15:57 | |
*** mlavalle has joined #openstack-lbaas | 15:57 | |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Update vip and network plug methods https://review.openstack.org/179400 | 16:05 |
*** jorgem has quit IRC | 16:15 | |
xgerman | dougwig somehow I can’t vote on https://review.openstack.org/#/c/179417/ | 16:23 |
dougwig | only TC members can vote on governance patches. I'd just leave your opinion in the comments | 16:24 |
dougwig | that's what i usually do. | 16:24 |
xgerman | ok | 16:24 |
rm_work | is it worth noting if you're a core reviewer when commenting? | 16:28 |
rm_work | is there a "vote" that happens between cores + PTL of new project, or is it just the PTLs that decide? | 16:28 |
rm_work | dougwig: ^^ | 16:29 |
xgerman | we had a proposal on the ML | 16:29 |
rm_work | ah, so voting was ther? | 16:29 |
rm_work | *there | 16:29 |
xgerman | sort of | 16:29 |
rm_work | well, responded anyway | 16:29 |
xgerman | thanks | 16:30 |
dougwig | the only "votes" that are counted in that patch is kyle + the TC. though i expect that if any of us object, that'd be taken notice of. | 16:30 |
rm_work | k | 16:33 |
rm_work | interesting though :P | 16:33 |
rm_work | cores could all be like "wtf?" and have their project taken over by the TC :P | 16:33 |
rm_work | but I guess that kinda makes sense in a weird way | 16:33 |
rm_work | and yeah, in practice, even non-voting opinions would probably be taken into account | 16:34 |
dougwig | oh yes, i'm sure anyone here could veto it. | 16:35 |
*** ajmiller has quit IRC | 16:40 | |
blogan | vetoed! | 16:47 |
johnsom | https://review.openstack.org/#/c/179277/ | 16:51 |
*** TrevorV|Home has quit IRC | 16:52 | |
*** HenryG is now known as floccinaucinihil | 16:54 | |
*** floccinaucinihil is now known as HenryThe8th | 16:55 | |
blogan | johnsom: i have some various fixes too, they definitely overla | 17:09 |
blogan | p with that review | 17:09 |
johnsom | Umm, ok | 17:10 |
blogan | just saying i'll pull yours down and compaire | 17:10 |
blogan | compare | 17:10 |
johnsom | Ok | 17:10 |
blogan | i don't think we need to do the update_amphora return though | 17:11 |
blogan | if you just pass in amphora_id | 17:11 |
johnsom | I wondered about that, but your comment said we needed to, so I trusted you... | 17:11 |
blogan | no i just said we need to update the amphora | 17:12 |
blogan | or whatever is being passed | 17:12 |
blogan | reload from db | 17:12 |
johnsom | I'm not following. We needed to update the loadbalancer object after we assigned an amphora to it. That is what this patch does by adding a task the creates a new "updated_loadbalancer" object and swaps it in for the rest of the networking flow | 17:13 |
johnsom | If we don't do that the network tasks won't see the amp and wont plug the network in. If we pass around ids were are querying the DB in each of the network steps. | 17:14 |
blogan | what i mean is taskflow won't allow you to require amphora nad also provide it from teh same task, but you can provide amphora and require amphora_id, which would just overwrite the old amphora, so amphora is now updated | 17:14 |
blogan | so if all you ever need is the amphora id, then all you need to do is just require amphora_id, and only provide amphora whenever you absolutely need it reloaded, which in that task would | 17:15 |
johnsom | That doesn't work for loadbalancer however, since it was injected into the flow at flow load time. The original loadbalancer object will get used by the subflow | 17:16 |
blogan | yeah so i just passed in loadbalancer_id, and let a task retrieve it for me and provide, so now it can be overwritten | 17:16 |
blogan | and you don't have to reload it after every task, just when you know you will need it updated | 17:16 |
*** madhu_ak has joined #openstack-lbaas | 17:17 | |
johnsom | I'm not reloading it after every task, only the one time it is updated | 17:17 |
ptoohill | thank you ajmiller | 17:18 |
blogan | i know but i think it'd be better if you just had amphora and loadbalancer, and just kept overwriting those becuase i don't see a case where a task will need the original amphora and loadbalancer | 17:18 |
blogan | i dont know why taskflow doesn't allow a task to require and provide the same thing though, that would make it simpler, and overwriting store objects | 17:20 |
johnsom | I agree, you should be able to overwrite them inside the task, probably by accessing the engine storage, but they don't seem to expose that (yet). | 17:21 |
blogan | yeah but just providing lb_id in the store and providing loadbalancer from a task should get around that and its not terribly hacky | 17:22 |
johnsom | blogan So, have you coded this up and tested it? I think I see what you have done by changing some of the tasks. Also, it would be cool if we keep in sync on the bugs in launchpad so we aren't duplicating effort. | 17:23 |
johnsom | Let's post it and I'll give it a look and abandon my patch. | 17:24 |
blogan | johnsom: actually i was more jsut trying to get it all working, but yeah ive got it successfully completing | 17:24 |
blogan | johnsom: no dont abandon yet, it may not be right, but ill post it | 17:24 |
blogan | haven't modified the tests though | 17:25 |
blogan | actually im giong to post the "test" i have for it that creates all the setup resources | 17:25 |
johnsom | That's ok | 17:25 |
blogan | eventually that'll ajmiller's devstack plugin will do all that for the test | 17:27 |
johnsom | Yeah, I have sql scripts and a python test framework that walks through create/update/delete | 17:28 |
blogan | i just have create right now | 17:28 |
*** hitalia has joined #openstack-lbaas | 17:29 | |
*** jorgem has joined #openstack-lbaas | 17:30 | |
johnsom | blogan did you also update the network sub-flow plug network/plug vip stuff? | 17:32 |
*** barclaac has joined #openstack-lbaas | 17:40 | |
blogan | johnsom: yeah | 17:41 |
barclaac | Morning all. | 17:41 |
johnsom | Ok, how about https://bugs.launchpad.net/octavia/+bug/1450524 | 17:41 |
openstack | Launchpad bug 1450524 in octavia "Controller worker needs to call allocate vip" [Critical,In progress] - Assigned to Michael Johnson (johnsom) | 17:41 |
johnsom | blogan I'm trying to decide what to work on next | 17:41 |
*** Aish has joined #openstack-lbaas | 17:42 | |
barclaac | QOTD (at least for me anyway ;-) If I have setup with LBaaS v1 and I want to upgrade it to v2 what things in the v1 data model can't be represented in v2? | 17:42 |
blogan | what about breaking it up by loadbalancers listeners pools members and healtmonitors | 17:43 |
blogan | barclaac: many to many health monitors to pools | 17:43 |
barclaac | And v2 is a one to many only? | 17:43 |
blogan | barclaac: 1:1 right now | 17:43 |
barclaac | so I could achieve an upgrade by duplicating any health monitors? | 17:44 |
blogan | johnsom: what i mean is pick the curd operations in the controller_worker.py for those entities and whomever wants to work on those can call it, we can put a LP bug in | 17:44 |
blogan | barclaac: if the pool has many healthmonitors then you'd basically have to choose one, if a health monitor exists on many pools then yeah duplication will work | 17:45 |
blogan | johnsom: or we can get even more granular and specify object and cud operation | 17:46 |
barclaac | Got it. So an upgrade sounds quite feasible then. In the former case I've just got to ask "which one do you want to keep?" | 17:46 |
blogan | barclaac: yep, that should be the only change a user sees, as for doing the migration for the operator, thats going to be fun, but doable | 17:47 |
blogan | barclaac: actually there might be one more, dougwig inquired about it a while back but i can't remember | 17:48 |
barclaac | blogan: I could also release note it and tell any v1 people "don't even think of using multiple monitors" to save pain later | 17:48 |
blogan | dougwig do you happen to remember any of the v1 to v2 changes that v1 coudl do but v2 can't? | 17:48 |
johnsom | blogan I guess I'm not following (or IRC is dropping messages). I'm looking at the bugs. Are you talking about what areas we should be testing/fixing? | 17:48 |
blogan | johnsom: there aren't any bugs, but yeah put a bug in LP for create lb, and someone tests and fixes that, also have one for update lb, delete lb, create listener, etc | 17:49 |
blogan | i mean there aren't any bugs in LP yet | 17:49 |
johnsom | https://bugs.launchpad.net/octavia | 17:50 |
johnsom | Yes there are, it's what I've been working against | 17:50 |
blogan | no i mean the generic bugs im suggesting | 17:50 |
blogan | sorry im thinking too fast and my fingers can't keep up | 17:50 |
johnsom | Other than the bugs listed, create and update through all of the components work. I haven't had a chance to test delete yet. | 17:52 |
blogan | you've tested create and update for all components? | 17:52 |
johnsom | Yes | 17:52 |
johnsom | With work arounds for the bugs listed. After we get those fixed new issues may pop up. | 17:53 |
xgerman | johnsom rocks - as you know :-=) | 17:53 |
johnsom | Controller worker down to ssh driver to clarify | 17:54 |
blogan | okay so in that case, thats where some overlap in thsi will happen bc i'd like to test them all out, and if i find issues and fix them they might overlap with what you've done, bc if i find a bug i'm usually just going to fix it right then and there (after talking to you and whomever first) | 17:54 |
johnsom | Yeah, or just pop a bug in LP and claim it | 17:55 |
blogan | xgerman: yes i know, he's gotten a ton done | 17:56 |
*** crc32 has joined #openstack-lbaas | 18:02 | |
*** bharath has joined #openstack-lbaas | 18:07 | |
*** mlavalle has quit IRC | 18:17 | |
*** mlavalle has joined #openstack-lbaas | 18:17 | |
*** mlavalle has quit IRC | 18:22 | |
*** mlavalle has joined #openstack-lbaas | 18:22 | |
dougwig | barclaac: things you can't do: 1) TLS, 2) if you have multiple health monitors associated, you have to pick one. the rest is straight-forward translation. | 18:35 |
barclaac | Thanks dougwig - TLS was the hook I was going to use to get people to upgrade :-D | 18:35 |
*** kobis has joined #openstack-lbaas | 18:39 | |
*** TrevorV|Home has joined #openstack-lbaas | 18:40 | |
openstackgerrit | Brandon Logan proposed stackforge/octavia: Fixed various issues with create lb and amphora flow https://review.openstack.org/179452 | 18:43 |
blogan | johnsom ^^ | 18:44 |
johnsom | Cool, will have a look | 18:44 |
*** clev is now known as clev-away | 18:46 | |
*** clev-away is now known as clev | 18:47 | |
*** hitalia has quit IRC | 19:10 | |
*** madhu_ak has quit IRC | 19:25 | |
ptoohill | https://review.openstack.org/#/c/178875/, I suppose I'm the only one running into these errors, besides maybe Trevor. But would like this to be evaluated. | 19:40 |
blogan | ptoohill: i ran into them too | 19:43 |
ptoohill | Good deal, does this change sound right? | 19:45 |
ptoohill | ty | 19:49 |
*** HenryThe8th has quit IRC | 19:50 | |
*** HenryG has joined #openstack-lbaas | 19:54 | |
*** HenryG has quit IRC | 19:55 | |
*** HenryG has joined #openstack-lbaas | 19:56 | |
*** bharath_ has joined #openstack-lbaas | 19:58 | |
*** bharath has quit IRC | 19:58 | |
*** madhu_ak has joined #openstack-lbaas | 20:07 | |
*** hitalia has joined #openstack-lbaas | 20:08 | |
*** hitalia has quit IRC | 20:11 | |
*** TrevorV|Home has quit IRC | 20:13 | |
*** mwang2 has joined #openstack-lbaas | 20:15 | |
*** HenryG has quit IRC | 20:16 | |
*** jorgem has quit IRC | 20:18 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas: Updated from global requirements https://review.openstack.org/179497 | 20:19 |
*** mwang2 has quit IRC | 20:19 | |
*** TrevorV|home has joined #openstack-lbaas | 20:20 | |
*** HenryG has joined #openstack-lbaas | 20:21 | |
openstackgerrit | Merged stackforge/octavia: Remove extra requirements https://review.openstack.org/178875 | 20:27 |
openstackgerrit | Merged stackforge/octavia: Update nova_driver to use amp_network https://review.openstack.org/178477 | 20:28 |
ptoohill | ! | 20:29 |
blogan | johnsom: do you prefer explicit requires in the flow or taskflow inferring from the arguments list? or specify requires in some particular cases? | 20:29 |
xgerman | I think I went with explicit... | 20:30 |
johnsom | I have tried to be explicit in an attempt to keep the namespace sane (i.e. not hunting for which task is injecting what) | 20:30 |
blogan | well i think we have to explicity with the provides, which is what injects into the namespace | 20:31 |
blogan | but yeah explicit is good if only being able to read it from looking at the flows | 20:32 |
*** mwang2 has joined #openstack-lbaas | 20:32 | |
openstackgerrit | Phillip Toohill proposed stackforge/octavia: Add devstack plugin for octavia https://review.openstack.org/167796 | 20:35 |
*** hitalia has joined #openstack-lbaas | 20:41 | |
johnsom | blogan If you name the tasks different you can reuse them inside a flow | 20:49 |
*** mwang2 has quit IRC | 20:56 | |
openstackgerrit | Phillip Toohill proposed stackforge/octavia: Add devstack plugin for octavia https://review.openstack.org/167796 | 21:01 |
blogan | johnsom: you mean rename class? | 21:09 |
*** kobis has quit IRC | 21:10 | |
*** blogan_ has joined #openstack-lbaas | 21:18 | |
blogan_ | one day ill switch off time warner | 21:18 |
rm_work | lol | 21:20 |
xgerman | they are giving me pan, too | 21:33 |
blogan_ | pretty sure their slogan is "we give you pain so we don't have it" | 21:35 |
*** crc32 has quit IRC | 21:39 | |
xgerman | well, my alternative is AT&T... | 21:39 |
xgerman | so the lesser evil | 21:39 |
*** nmagnezi has joined #openstack-lbaas | 21:40 | |
blogan_ | mine too :( | 21:53 |
blogan_ | though they can't be any worse honestly with stability | 21:53 |
*** blogan_ has quit IRC | 22:00 | |
*** barclaac has quit IRC | 22:03 | |
johnsom | blogan Sorry, had to be away for a bit talking to a potential intern. You can "name" tasks when building the flow | 22:05 |
*** barclaac has joined #openstack-lbaas | 22:06 | |
*** nmagnezi has quit IRC | 22:06 | |
*** barclaac has quit IRC | 22:16 | |
*** barclaac has joined #openstack-lbaas | 22:17 | |
*** TrevorV|home has quit IRC | 22:17 | |
*** Miouge has quit IRC | 22:21 | |
*** blogan_ has joined #openstack-lbaas | 22:27 | |
*** mlavalle has quit IRC | 22:28 | |
*** mlavalle has joined #openstack-lbaas | 22:33 | |
*** barclaac has quit IRC | 22:42 | |
*** barclaac has joined #openstack-lbaas | 22:47 | |
*** barclaac has quit IRC | 23:04 | |
*** mlavalle has quit IRC | 23:05 | |
*** mlavalle has joined #openstack-lbaas | 23:10 | |
*** barclaac has joined #openstack-lbaas | 23:14 | |
*** mlavalle has quit IRC | 23:20 | |
madhu_ak | blogan_, blogan: could you have a look into this patch and offer your suggestions, if any: https://review.openstack.org/#/c/178022/ | 23:22 |
openstackgerrit | Merged openstack/neutron-lbaas: Updated from global requirements https://review.openstack.org/179497 | 23:23 |
*** bharath_ has quit IRC | 23:27 | |
*** Aish has quit IRC | 23:29 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!