*** bharath_ has joined #openstack-lbaas | 00:03 | |
*** bharath has quit IRC | 00:05 | |
*** ypraveen has joined #openstack-lbaas | 00:07 | |
openstackgerrit | min wang proposed openstack/neutron-lbaas: Admin API tempest for healthmonitor https://review.openstack.org/173542 | 00:15 |
---|---|---|
*** Aish has quit IRC | 00:30 | |
*** Aish has joined #openstack-lbaas | 00:32 | |
*** ganeshna has joined #openstack-lbaas | 00:32 | |
*** bharath_ has quit IRC | 00:37 | |
*** ganeshna has quit IRC | 00:40 | |
*** bharath has joined #openstack-lbaas | 00:43 | |
*** bharath has quit IRC | 00:47 | |
*** Aish has quit IRC | 00:48 | |
*** madhu_ak has quit IRC | 00:49 | |
*** madhu_ak has joined #openstack-lbaas | 00:52 | |
madhu_ak | blogan: around? | 00:53 |
madhu_ak | blogan: after rebasing fnaval's scenario tests with correct imports module and adding 'scenario' in tox.ini, when I run the test, I am getting an error. Any idea about this: https://gist.github.com/akmadhusudhan/d0faaee37599a06b137b | 00:56 |
madhu_ak | scenario's patch : https://review.openstack.org/#/c/158904/ | 00:56 |
*** KunalGandhi has quit IRC | 01:14 | |
*** madhu_ak has quit IRC | 01:33 | |
*** fnaval has quit IRC | 01:45 | |
*** Aish has joined #openstack-lbaas | 01:53 | |
*** fnaval has joined #openstack-lbaas | 02:01 | |
*** ypraveen has quit IRC | 02:20 | |
*** Kunal has joined #openstack-lbaas | 02:29 | |
*** KunalGandhi has joined #openstack-lbaas | 02:29 | |
*** KunalGan_ has joined #openstack-lbaas | 02:34 | |
*** KunalGandhi has quit IRC | 02:35 | |
*** Kunal has quit IRC | 02:35 | |
*** Djinnn has joined #openstack-lbaas | 02:50 | |
*** Djinnn has quit IRC | 02:55 | |
*** SumitNaiksatam_ has joined #openstack-lbaas | 03:05 | |
*** SumitNaiksatam has quit IRC | 03:07 | |
*** SumitNaiksatam_ has quit IRC | 03:10 | |
*** kiran-r has joined #openstack-lbaas | 03:12 | |
*** SumitNaiksatam has joined #openstack-lbaas | 03:18 | |
*** SumitNaiksatam has quit IRC | 03:24 | |
*** kiran-r has quit IRC | 03:45 | |
*** ganeshna has joined #openstack-lbaas | 03:46 | |
*** kiran-r has joined #openstack-lbaas | 03:51 | |
*** kiranr has joined #openstack-lbaas | 03:55 | |
*** kiran-r has quit IRC | 03:55 | |
*** kiranr has quit IRC | 04:02 | |
*** KunalGan_ has quit IRC | 04:34 | |
*** ypraveen has joined #openstack-lbaas | 04:44 | |
*** chlong is now known as chlong_mtg | 04:59 | |
*** kiran-r has joined #openstack-lbaas | 05:17 | |
*** kiran-r has quit IRC | 05:21 | |
*** kiran-r has joined #openstack-lbaas | 05:21 | |
*** ganeshna has quit IRC | 05:40 | |
*** ganeshna has joined #openstack-lbaas | 05:41 | |
*** chlong_mtg is now known as chlong | 06:06 | |
*** ypraveen has quit IRC | 06:11 | |
*** amotoki has joined #openstack-lbaas | 06:16 | |
*** Aish has quit IRC | 06:23 | |
*** KunalGandhi has joined #openstack-lbaas | 06:32 | |
*** Kunal has joined #openstack-lbaas | 06:34 | |
*** KunalGandhi has quit IRC | 06:39 | |
*** KunalGandhi has joined #openstack-lbaas | 06:39 | |
*** KunalGandhi has quit IRC | 06:43 | |
*** Kunal has quit IRC | 06:44 | |
*** amotoki has quit IRC | 06:47 | |
*** amotoki has joined #openstack-lbaas | 06:50 | |
*** kiranr has joined #openstack-lbaas | 08:15 | |
*** kiran-r has quit IRC | 08:15 | |
*** kiranr has quit IRC | 08:15 | |
*** kiranr has joined #openstack-lbaas | 08:16 | |
*** chlong is now known as chlong_afk | 08:16 | |
*** kiranr is now known as kiran-r | 08:18 | |
*** haigang has joined #openstack-lbaas | 08:25 | |
*** haigang has quit IRC | 08:26 | |
*** fnaval has quit IRC | 08:38 | |
*** fnaval has joined #openstack-lbaas | 08:41 | |
*** Alex_Stef has joined #openstack-lbaas | 08:48 | |
*** woodster_ has quit IRC | 09:01 | |
*** chlong_afk has quit IRC | 09:03 | |
*** Alex_Stef has quit IRC | 09:27 | |
*** numan has joined #openstack-lbaas | 09:48 | |
*** numan has quit IRC | 09:49 | |
*** numan has joined #openstack-lbaas | 09:49 | |
*** Miouge has joined #openstack-lbaas | 10:20 | |
*** ganeshna has quit IRC | 10:27 | |
*** ganeshna has joined #openstack-lbaas | 10:33 | |
openstackgerrit | Jian Wen proposed openstack/neutron-lbaas: Run as root for killing haproxy https://review.openstack.org/191008 | 10:35 |
*** Miouge has left #openstack-lbaas | 10:40 | |
*** ganeshna has quit IRC | 11:23 | |
*** Aish has joined #openstack-lbaas | 13:00 | |
*** Aish has quit IRC | 13:05 | |
*** bradjones has quit IRC | 13:35 | |
*** bradjones has joined #openstack-lbaas | 13:38 | |
*** bradjones has quit IRC | 13:38 | |
*** bradjones has joined #openstack-lbaas | 13:38 | |
*** kiran-r has quit IRC | 13:49 | |
*** localloo1 has joined #openstack-lbaas | 13:50 | |
*** woodster_ has joined #openstack-lbaas | 13:51 | |
*** localloo1 has quit IRC | 14:02 | |
*** TrevorV has joined #openstack-lbaas | 14:15 | |
*** fnaval has quit IRC | 14:49 | |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete pool flow https://review.openstack.org/190780 | 15:21 |
*** mlavalle has joined #openstack-lbaas | 15:37 | |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete loadbalancer flow https://review.openstack.org/187237 | 15:40 |
*** mixos has joined #openstack-lbaas | 15:43 | |
TrevorV | johnsom, I addressed your concerns my man | 15:46 |
johnsom | Yep, thanks! Working on those reviews now | 15:47 |
*** Aish has joined #openstack-lbaas | 15:48 | |
johnsom | Don't we have tests for the models under the functional tests? octavia/tests/functional/db/test_models.py | 15:48 |
*** pck has quit IRC | 15:49 | |
TrevorV | those are for the models, not the data_models | 15:50 |
TrevorV | Models are the database objects | 15:50 |
johnsom | Ah yes | 15:51 |
TrevorV | Once again, I can add a class to test it, I just don't know that it's worth it since it literally just makes whatever is there "None"... Does it really provide that much? | 15:52 |
TrevorV | I'm not against it, its not a hard test obviously, just seems silly | 15:52 |
johnsom | It was a nit, let's pass | 15:54 |
johnsom | I agree, it would be a silly test | 15:54 |
TrevorV | Alright, I was just checking. I mean, if we start adding some other methods that do things like that throughout the data_models then we should add a test class, just for tracking changes, but for one simple method, I feel that's not really necessary | 15:56 |
*** numan has quit IRC | 15:58 | |
johnsom | Cool stuff. Now you just need to bother one of your co-workers to kick them through | 15:58 |
*** pck has joined #openstack-lbaas | 16:00 | |
*** KunalGandhi has joined #openstack-lbaas | 16:03 | |
*** Kunal has joined #openstack-lbaas | 16:03 | |
TrevorV | johnsom, I'm the only dev in the office today... blogan is out through Monday, back Tuesday | 16:03 |
TrevorV | We'll see if anyone here can get to it ha ha | 16:03 |
johnsom | Maybe Adam or Doug can hit them | 16:04 |
*** Aish has quit IRC | 16:08 | |
*** kiran-r has joined #openstack-lbaas | 16:14 | |
*** KunalGandhi has quit IRC | 16:16 | |
*** Kunal has quit IRC | 16:20 | |
*** fnaval has joined #openstack-lbaas | 16:33 | |
*** sbalukoff has quit IRC | 16:34 | |
*** Aish has joined #openstack-lbaas | 16:35 | |
*** KunalGandhi has joined #openstack-lbaas | 16:45 | |
*** madhu_ak has joined #openstack-lbaas | 16:50 | |
*** jorgem has joined #openstack-lbaas | 16:55 | |
xgerman | are we good to +A | 16:57 |
xgerman | ? | 16:57 |
xgerman | last I saw was a pep8 error | 16:58 |
xgerman | but maybe I am looking at the wrong thing | 16:58 |
xgerman | TrevorV ping me and I can +2 or whatever is needed | 16:58 |
openstackgerrit | min wang proposed openstack/neutron-lbaas: Introduced tempest API tests for openstack/neutron-lbaas https://review.openstack.org/168439 | 17:04 |
*** jorgem has quit IRC | 17:07 | |
openstackgerrit | Doug Wiegley proposed openstack/neutron-lbaas: Add v1 quota tests in-tree https://review.openstack.org/191153 | 17:08 |
*** ypraveen has joined #openstack-lbaas | 17:10 | |
*** kiran-r has quit IRC | 17:10 | |
*** fnaval_ has joined #openstack-lbaas | 17:14 | |
*** fnaval has quit IRC | 17:16 | |
*** fnaval has joined #openstack-lbaas | 17:16 | |
*** fnaval_ has quit IRC | 17:20 | |
*** jorgem has joined #openstack-lbaas | 17:26 | |
*** fnaval has quit IRC | 17:34 | |
openstackgerrit | Doug Wiegley proposed openstack/neutron-lbaas: Add neutron to requirements https://review.openstack.org/191161 | 17:40 |
*** amotoki has quit IRC | 17:41 | |
*** kiran-r has joined #openstack-lbaas | 17:43 | |
openstackgerrit | Merged openstack/neutron-lbaas: Admin API tempest for healthmonitor https://review.openstack.org/173542 | 17:49 |
*** sbalukoff has joined #openstack-lbaas | 17:51 | |
*** jorgem has quit IRC | 17:51 | |
openstackgerrit | Merged openstack/neutron-lbaas: Adding code to prevent vip port deletion from port api https://review.openstack.org/176016 | 18:00 |
*** bharath has joined #openstack-lbaas | 18:00 | |
*** mixos is now known as mixos-away | 18:04 | |
TrevorV | xgerman, I swear I ran tox... but I guess I fudged it up. | 18:10 |
TrevorV | Are we okay with the only +2's being from HP? I thought we wanted cross-company +2's? | 18:11 |
*** mixos-away is now known as mixos | 18:15 | |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete loadbalancer flow https://review.openstack.org/187237 | 18:18 |
*** kiran-r has quit IRC | 18:30 | |
TrevorV | johnsom, that test already exists, I made a duplicate. | 18:30 |
TrevorV | On accident | 18:30 |
johnsom | Oh, ok, let me take a look again | 18:31 |
TrevorV | Sure thing | 18:31 |
TrevorV | The original one is on current line 361 if that helps | 18:31 |
TrevorV | Sorry, 334, wrong line | 18:31 |
johnsom | That test runs MarkAmphoraDeletedInDB() vs. your MarkLBAmphoraeDeletedInDB() | 18:35 |
TrevorV | Ooooooooooh... I misread that... DAMNIT... Alright I'll add it back and change the name | 18:37 |
johnsom | Yep, it's a different test | 18:43 |
TrevorV | I just checked the one I removed, its exactly the same with just differently mocked parameters to one | 18:45 |
TrevorV | they both test this: MarkAmphoraDeletedInDB | 18:45 |
*** mwang2_ has quit IRC | 18:47 | |
TrevorV | I probably copied it and forgot to mod it for the testing of marking ALL amphorae deleted. Which I'm about to do. | 18:47 |
TrevorV | johnsom, ^^ | 18:47 |
*** mwang2 has joined #openstack-lbaas | 18:48 | |
openstackgerrit | min wang proposed openstack/neutron-lbaas: Admin_state_up tempest test for health monitor https://review.openstack.org/178827 | 18:55 |
openstackgerrit | Trevor Vardeman proposed stackforge/octavia: Fix the delete loadbalancer flow https://review.openstack.org/187237 | 19:09 |
*** bharath has quit IRC | 19:26 | |
openstackgerrit | Madhusudhan Kandadai proposed openstack/neutron-lbaas: Tempest API tests using testscenarios for create/update pool https://review.openstack.org/180019 | 19:44 |
*** TrevorV has quit IRC | 19:45 | |
*** bharath has joined #openstack-lbaas | 19:51 | |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Moving the base-admin-state-up.py to a separate patch. https://review.openstack.org/191205 | 19:53 |
*** Aish has quit IRC | 20:07 | |
*** pck has quit IRC | 20:07 | |
*** SlickNik has quit IRC | 20:07 | |
*** redrobot has quit IRC | 20:07 | |
*** pck has joined #openstack-lbaas | 20:07 | |
*** redrobot has joined #openstack-lbaas | 20:08 | |
*** SlickNik has joined #openstack-lbaas | 20:08 | |
*** redrobot is now known as Guest67074 | 20:08 | |
*** Aish has joined #openstack-lbaas | 20:08 | |
johnsom | All good Trevor, have a good weekend | 20:16 |
*** ebagdasa has quit IRC | 20:59 | |
*** ebagdasa has joined #openstack-lbaas | 21:01 | |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Moving base_admin_state_up.py to a new patch https://review.openstack.org/191217 | 21:13 |
*** ebagdasa has quit IRC | 21:22 | |
*** ebagdasa has joined #openstack-lbaas | 21:24 | |
madhu_ak | fnaval: you around? | 21:35 |
madhu_ak | ptoohill, blogan: ^^ | 21:36 |
*** madhu_ak has quit IRC | 21:37 | |
*** madhu_ak has joined #openstack-lbaas | 21:38 | |
*** mixos has quit IRC | 23:04 | |
johnsom | FYI, I have a patchset ready for the octavia rename to update the devstack samples, etc. | 23:19 |
johnsom | Just waiting for infra to finish | 23:19 |
*** openstackgerrit has quit IRC | 23:22 | |
*** openstackgerrit has joined #openstack-lbaas | 23:22 | |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Tempest tests for Members using testscenarios. https://review.openstack.org/180436 | 23:24 |
openstackgerrit | Aishwarya Thangappa proposed openstack/neutron-lbaas: Tempest tests for Listener using testscenarios. https://review.openstack.org/179818 | 23:26 |
*** Aish has quit IRC | 23:33 | |
*** ajmiller has quit IRC | 23:48 | |
openstackgerrit | Jeremy Stanley proposed openstack/octavia: Update .gitreview file for project rename https://review.openstack.org/191282 | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!