| *** minwang2 has quit IRC | 00:15 | |
| *** abdelwas has quit IRC | 00:21 | |
| madhu_ak | finally, jenkins is happy with the scenario tests for lbaasv2! https://review.openstack.org/#/c/207196/ | 00:38 |
|---|---|---|
| bana_k | when is the next octavia hackthon? | 00:46 |
| *** amotoki has joined #openstack-lbaas | 00:58 | |
| *** h00327910__ has joined #openstack-lbaas | 00:58 | |
| *** johnsom__ has quit IRC | 00:59 | |
| *** vivek-ebay has quit IRC | 01:12 | |
| *** vivek-ebay has joined #openstack-lbaas | 01:12 | |
| *** madhu_ak has quit IRC | 01:17 | |
| sbalukoff | bana_k: There probably won't be one until the next mid-cycle. So probably December or January. | 01:27 |
| sbalukoff | At least, not one where we meet in person and work on stuff / discuss stuff in the same room. | 01:27 |
| sbalukoff | If we wanted to do a 'virtual hack-a-thon' where we try to do the same purely over tele-presence, this could probably happen (as it costs nothing, and a limiting factor here is travel budgets)... | 01:28 |
| sbalukoff | Did you have something in mind you wanted to work on, or was your question more about just meeting in person to have an easier time pairing up on work? | 01:29 |
| *** chlong has joined #openstack-lbaas | 01:29 | |
| sbalukoff | bana_k: As far as things you can help with right now: I would love it if you could take a look at the sqlalchemy stuff in the Neutron LBaaS patch I have up right now and let me know if you think I'm doing it wrong. I suspect I am. | 01:33 |
| sbalukoff | This is what I'm talking about, the all_pools methods / property I'm adding to the model: https://review.openstack.org/#/c/204957/3/neutron_lbaas/db/loadbalancer/models.py | 01:34 |
| sbalukoff | There are many ways I could be doing this wrong, and I suspect I'm violating at least a couple rules with this. | 01:34 |
| sbalukoff | (This all needs to be unit-tested out, as well.) | 01:35 |
| bana_k | sbalukoff: Oh I see. Nothing in particular. Was just thinking if its there, can attend and speedup the learning process :). | 01:40 |
| bana_k | I can definitely work on it | 01:41 |
| *** Tiancheng has joined #openstack-lbaas | 01:52 | |
| *** mixos has joined #openstack-lbaas | 02:00 | |
| *** mixos has left #openstack-lbaas | 02:03 | |
| *** bana_k has quit IRC | 02:06 | |
| *** vivek-ebay has quit IRC | 02:26 | |
| *** mixos has joined #openstack-lbaas | 02:37 | |
| *** ajmiller has joined #openstack-lbaas | 02:41 | |
| *** KunalGandhi has quit IRC | 02:55 | |
| *** ajmiller has quit IRC | 02:58 | |
| *** ajmiller has joined #openstack-lbaas | 02:58 | |
| *** woodster_ has quit IRC | 03:14 | |
| *** fnaval has quit IRC | 03:34 | |
| *** fnaval has joined #openstack-lbaas | 03:43 | |
| santosh_ | ping | 03:46 |
| *** fnaval has quit IRC | 03:47 | |
| *** fnaval has joined #openstack-lbaas | 03:47 | |
| *** vivek-ebay has joined #openstack-lbaas | 03:49 | |
| *** minwang2 has joined #openstack-lbaas | 04:05 | |
| *** bana_k has joined #openstack-lbaas | 04:31 | |
| *** Tiancheng has quit IRC | 04:34 | |
| *** madhu_ak has joined #openstack-lbaas | 04:43 | |
| *** vivek-eb_ has joined #openstack-lbaas | 05:06 | |
| *** vivek-ebay has quit IRC | 05:08 | |
| *** Tiancheng has joined #openstack-lbaas | 05:22 | |
| *** minwang2 has quit IRC | 05:26 | |
| *** minwang2 has joined #openstack-lbaas | 05:28 | |
| *** KunalGandhi has joined #openstack-lbaas | 05:31 | |
| *** vivek-eb_ has quit IRC | 05:37 | |
| *** KunalGandhi has quit IRC | 05:43 | |
| *** KunalGandhi has joined #openstack-lbaas | 05:43 | |
| *** jschwarz has joined #openstack-lbaas | 05:43 | |
| *** madhu_ak has quit IRC | 05:57 | |
| *** numan has joined #openstack-lbaas | 06:08 | |
| *** Tiancheng has quit IRC | 06:09 | |
| *** Tiancheng has joined #openstack-lbaas | 06:10 | |
| *** jschwarz has quit IRC | 06:39 | |
| *** minwang2 has quit IRC | 07:05 | |
| *** nmagnezi has joined #openstack-lbaas | 07:07 | |
| *** bana_k has quit IRC | 07:11 | |
| *** KunalGan_ has joined #openstack-lbaas | 07:16 | |
| *** KunalGandhi has quit IRC | 07:19 | |
| *** KunalGan_ has quit IRC | 07:21 | |
| *** chlong has quit IRC | 07:25 | |
| *** kiran-r has joined #openstack-lbaas | 08:25 | |
| *** enikanorov has joined #openstack-lbaas | 08:33 | |
| openstackgerrit | Phillip Toohill proposed openstack/octavia: Pluggable controller worker https://review.openstack.org/202329 | 08:51 |
| openstackgerrit | Phillip Toohill proposed openstack/neutron-lbaas: Fixing private key loading https://review.openstack.org/207341 | 08:59 |
| *** chlong has joined #openstack-lbaas | 09:07 | |
| openstackgerrit | Phillip Toohill proposed openstack/octavia: Adding new network driver https://review.openstack.org/197858 | 09:08 |
| *** ig0r_ has joined #openstack-lbaas | 09:31 | |
| *** Tiancheng has quit IRC | 10:10 | |
| *** kbyrne has quit IRC | 10:21 | |
| *** kbyrne has joined #openstack-lbaas | 10:23 | |
| *** jschwarz has joined #openstack-lbaas | 10:52 | |
| *** Tiancheng has joined #openstack-lbaas | 12:05 | |
| *** _kiran_ has joined #openstack-lbaas | 12:06 | |
| *** kiran-r has quit IRC | 12:09 | |
| *** _kiran_ has quit IRC | 12:20 | |
| *** mixos has quit IRC | 12:40 | |
| *** nmagnezi has quit IRC | 12:41 | |
| *** nmagnezi has joined #openstack-lbaas | 12:56 | |
| *** ig0r_ has quit IRC | 13:10 | |
| *** ig0r_ has joined #openstack-lbaas | 13:16 | |
| *** rbrooker has joined #openstack-lbaas | 13:23 | |
| *** woodster_ has joined #openstack-lbaas | 13:24 | |
| *** kbyrne has quit IRC | 13:26 | |
| *** kbyrne has joined #openstack-lbaas | 13:27 | |
| *** ig0r_ has quit IRC | 13:31 | |
| *** Tiancheng has quit IRC | 14:08 | |
| *** mlavalle has joined #openstack-lbaas | 14:11 | |
| *** KunalGandhi has joined #openstack-lbaas | 14:20 | |
| *** ajmiller has quit IRC | 14:21 | |
| *** KunalGandhi has quit IRC | 14:24 | |
| *** ajmiller has joined #openstack-lbaas | 14:30 | |
| *** ig0r_ has joined #openstack-lbaas | 14:32 | |
| pothole | https://review.openstack.org/#/c/185540/ | 14:37 |
| pothole | https://review.openstack.org/#/c/188703/ | 14:38 |
| *** rbrooker has quit IRC | 14:38 | |
| *** madhu_ak has joined #openstack-lbaas | 14:47 | |
| *** fnaval has quit IRC | 14:57 | |
| *** nmagnezi has quit IRC | 15:01 | |
| *** jschwarz has quit IRC | 15:01 | |
| *** rbrooker has joined #openstack-lbaas | 15:02 | |
| *** ig0r_ has quit IRC | 15:03 | |
| *** ig0r__ has joined #openstack-lbaas | 15:03 | |
| *** fnaval has joined #openstack-lbaas | 15:07 | |
| *** logan2 has quit IRC | 15:08 | |
| *** ig0r_ has joined #openstack-lbaas | 15:09 | |
| *** ig0r__ has quit IRC | 15:09 | |
| *** ig0r__ has joined #openstack-lbaas | 15:13 | |
| *** ig0r__ has quit IRC | 15:15 | |
| *** ig0r_ has quit IRC | 15:15 | |
| *** vivek-ebay has joined #openstack-lbaas | 15:16 | |
| *** numan has quit IRC | 15:20 | |
| *** KunalGandhi has joined #openstack-lbaas | 15:21 | |
| *** madhu_ak has quit IRC | 15:26 | |
| *** KunalGandhi has quit IRC | 15:27 | |
| *** vivek-ebay has quit IRC | 15:27 | |
| *** xgerman has quit IRC | 15:29 | |
| *** minwang2 has joined #openstack-lbaas | 15:31 | |
| *** rbrooker has quit IRC | 15:45 | |
| *** ig0r_ has joined #openstack-lbaas | 15:52 | |
| *** woodster_ has quit IRC | 15:55 | |
| *** h00327910__ has quit IRC | 15:55 | |
| *** rbrooker has joined #openstack-lbaas | 15:59 | |
| *** rbrooker has quit IRC | 16:06 | |
| *** rbrooker has joined #openstack-lbaas | 16:08 | |
| johnsom | blogan rm_work Anyone around to give this the +A? https://review.openstack.org/#/c/203207 Data model updates part 1 for VRRP | 16:14 |
| *** rbrooker has quit IRC | 16:14 | |
| *** logan2 has joined #openstack-lbaas | 16:19 | |
| *** minwang2 has quit IRC | 16:28 | |
| *** woodster_ has joined #openstack-lbaas | 16:33 | |
| openstackgerrit | Merged openstack/octavia: Adding model changes to support active/standby https://review.openstack.org/203207 | 16:36 |
| *** vivek-ebay has joined #openstack-lbaas | 16:36 | |
| *** madhu_ak has joined #openstack-lbaas | 16:37 | |
| *** xgerman has joined #openstack-lbaas | 16:37 | |
| *** KunalGandhi has joined #openstack-lbaas | 16:44 | |
| *** TrevorV has joined #openstack-lbaas | 16:57 | |
| *** bana_k has joined #openstack-lbaas | 17:01 | |
| *** h00327910__ has joined #openstack-lbaas | 17:08 | |
| *** minwang2 has joined #openstack-lbaas | 17:09 | |
| johnsom | mestery Any thoughts on the pyroute2 package? We are considering it for setting up some routes we need on the amphora. | 17:42 |
| johnsom | I see that it has been proposed off and on for various things, https://review.openstack.org/#/c/155631/ being the last I see. | 17:43 |
| johnsom | However it isn't currently in global-requirements | 17:43 |
| *** bharath has joined #openstack-lbaas | 17:43 | |
| mestery | johnsom: I'd be in favor of it, yes. It's now dual-licensed (GPL and AV2), so that was the biggest hurdle. | 17:49 |
| *** SumitNaiksatam has joined #openstack-lbaas | 17:51 | |
| johnsom | Ok, cool. I will probably start making motions to get it added. | 17:51 |
| xgerman | awesome | 17:53 |
| xgerman | johnsom I can help you with adding | 17:53 |
| johnsom | Ok. I'm reading up on the process now | 17:53 |
| *** KunalGandhi has quit IRC | 18:24 | |
| *** ig0r__ has joined #openstack-lbaas | 18:24 | |
| *** bana_k has quit IRC | 18:31 | |
| *** bana_k has joined #openstack-lbaas | 18:31 | |
| *** KunalGandhi has joined #openstack-lbaas | 18:31 | |
| *** kbyrne has quit IRC | 18:34 | |
| *** kbyrne has joined #openstack-lbaas | 18:35 | |
| *** KunalGandhi has quit IRC | 18:48 | |
| *** KunalGan_ has joined #openstack-lbaas | 18:48 | |
| sballe | mestery: Just saw you comment around the license. What GPL are we talking about? | 18:48 |
| sballe | johnsom: maybe you know what version of GPL we are talking about? | 18:48 |
| mestery | sballe: pyroute2 is dual licensed, so we can likely use it | 18:49 |
| *** ig0r_ has quit IRC | 18:50 | |
| *** minwang2 has quit IRC | 18:51 | |
| sballe | Ok let's check with our our IP attorney. | 18:51 |
| *** ig0r_ has joined #openstack-lbaas | 19:04 | |
| *** openstackgerrit has quit IRC | 19:46 | |
| *** chadix has joined #openstack-lbaas | 19:46 | |
| *** openstackgerrit has joined #openstack-lbaas | 19:47 | |
| *** ig0r_ has quit IRC | 19:56 | |
| openstackgerrit | Merged openstack/octavia: Pluggable controller worker https://review.openstack.org/202329 | 19:56 |
| xgerman | blogan yt? | 19:57 |
| xgerman | you like to talk UDP design | 19:57 |
| xgerman | ? | 19:57 |
| blogan | xgerman: im here and there some :) | 19:58 |
| xgerman | ok, so what do we want to send in those UDP packages/ | 19:58 |
| *** minwang2 has joined #openstack-lbaas | 19:58 | |
| xgerman | ? | 19:58 |
| xgerman | Member status? Listener status? Stats? | 19:59 |
| xgerman | I like to send everything but I am also greedy :-) | 19:59 |
| blogan | how much room do we have? | 19:59 |
| xgerman | 64 KB I think | 19:59 |
| blogan | well that should be plenty | 19:59 |
| xgerman | yeah and we gzip | 19:59 |
| rm_work | you have to be careful with sending anything that is N-count | 20:00 |
| rm_work | like members | 20:00 |
| rm_work | otherwise there is a bit of room... | 20:00 |
| blogan | well hopefully we have limits on the number of members a lb can have | 20:00 |
| blogan | we dont now of course | 20:00 |
| rm_work | ah true | 20:00 |
| blogan | xgerman: would listener status be a check that haproxy is running? | 20:01 |
| xgerman | yes, you get all of that from the stats socket | 20:01 |
| blogan | xgerman: oh yeah i forgot about that, okay yeah if we could send all that info obviously i'd like that | 20:02 |
| xgerman | same here | 20:02 |
| xgerman | you will also get stats from that socket aka bytes in/out | 20:02 |
| blogan | bc that adds better health monitoring knowing haproxy is running, however we may still need an extra bit of info to make sure it is receiving packets on the vip | 20:03 |
| blogan | but i tink that can be something we as a follow up | 20:03 |
| blogan | bc not exactly sure what to do otehr than fire off a packet to the vip | 20:03 |
| xgerman | I think harpy has some monitoring page you can activate | 20:04 |
| blogan | lol harpy | 20:04 |
| xgerman | so you could query that over the VIP | 20:04 |
| xgerman | haproxy | 20:04 |
| xgerman | just make sure to narrow down IPs for that page | 20:04 |
| blogan | hmmm would that make it accessible to users? | 20:04 |
| xgerman | well they enter over the VIP so... | 20:05 |
| blogan | i know | 20:05 |
| blogan | not sure i like them being able to access taht | 20:05 |
| blogan | tehn again it might be a requested feature one day | 20:06 |
| xgerman | yep, now if you are HP you would just say the user has to monitor that | 20:06 |
| xgerman | and he has to set up some status page in his web app | 20:06 |
| xgerman | :-) | 20:06 |
| *** abdelwas has joined #openstack-lbaas | 20:08 | |
| *** openstackgerrit has quit IRC | 20:16 | |
| *** openstackgerrit has joined #openstack-lbaas | 20:17 | |
| abdelwas | Hi, this is Sherif | 20:24 |
| abdelwas | I am getting the following an error when I try to create a load balancer in octavia. | 20:24 |
| abdelwas | Here is the error details: https://gist.github.com/abdelwas/4e1b913e38b8900c2fef | 20:25 |
| abdelwas | Any suggestions ? | 20:25 |
| xgerman | tghere has been some subnet changes… but not sure | 20:25 |
| abdelwas | The subnet id in the VIP table is always null | 20:25 |
| blogan | abdelwas: did you provie a subnet_id in the vip field through the API? | 20:26 |
| blogan | are you using the client? | 20:26 |
| blogan | the neutron client | 20:26 |
| abdelwas | I am using the neutron client | 20:26 |
| abdelwas | and the rest api driver | 20:27 |
| blogan | ah | 20:27 |
| blogan | hmm | 20:27 |
| blogan | what task is it failing in? | 20:27 |
| blogan | on i see the line | 20:27 |
| abdelwas | PlugVIP, during the allocate_vip method | 20:28 |
| abdelwas | I get this debug message: DEBUG octavia.controller.worker.tasks.network_tasks [-] Allocate_vip port_id 443d31a2-e824-4539-a259-266389dc2c5e, subnet_id None,ip_address | 20:29 |
| abdelwas | then everything fails apart afterwards. | 20:29 |
| openstackgerrit | Evgeny Fedoruk proposed openstack/neutron-lbaas: Fixing Radware LBaaS v2 driver bugs https://review.openstack.org/207148 | 20:30 |
| blogan | that exception is coming back from the plug_vip method | 20:31 |
| abdelwas | How the subnet_id is passed at the Plug_VIP task? could it be reltated to changes from network_id to subnet_id | 20:32 |
| abdelwas | ? | 20:32 |
| blogan | subnet_id will be part of the loadbalancer object and vip object, so it sholud be populated | 20:33 |
| blogan | allocate_vip should have populated subnet_id of the vip | 20:33 |
| blogan | which in this case looks like subnet_id is not populated | 20:33 |
| abdelwas | Yeah but why it could be NULL, if the neutron command passed "private_net" lets say | 20:34 |
| blogan | not sure yet, would have to breadcrumb it | 20:34 |
| blogan | follow the breadcrumbs | 20:34 |
| blogan | or just run debugger | 20:35 |
| TrevorV | I'm fairly certain this is a known issue when using octavia through neutron lbaas. pothole I think you were the one that knows about this one | 20:35 |
| johnsom | Yes, I think this is an known issue when going through client/lbaas api. | 20:39 |
| johnsom | It was introduced with a patchset that switched network_id and subnet_id or something | 20:39 |
| blogan | i thought that got fixed | 20:39 |
| blogan | yeah the octavia driver passes subnet_id now | 20:41 |
| johnsom | Hmm, ok. Maybe I will do a debug session with Sherif and help him figure it out | 20:41 |
| blogan | im starting one too | 20:42 |
| blogan | abdelwas: what patchset are you using of the octavia driver reveiw? | 20:42 |
| minwang2 | i can try to us postman to create a lb see it is working that way | 20:42 |
| abdelwas | Just an updated master | 20:42 |
| blogan | abdelwas: master won't matter, your localrc is set up to pull down a specific review in neutron-lbaas so your devstack pulls down the octavia driver since it has not been merged into master | 20:43 |
| blogan | abdelwas: so if you look in yoru localrc where it does the enable_plugin of neutron_lbaas, it should have a ref/changes/*/* at the end of the line | 20:45 |
| *** openstackgerrit has quit IRC | 20:46 | |
| abdelwas | Hmm, let me check this | 20:47 |
| *** openstackgerrit has joined #openstack-lbaas | 20:47 | |
| abdelwas | I actually change what localrc do | 20:49 |
| abdelwas | When I checkout different branch. | 20:49 |
| blogan | do you checkout the octavia driver reveiw? | 20:49 |
| abdelwas | No! I just learned about that from you now :) | 20:50 |
| abdelwas | Which patch set I should consider | 20:50 |
| blogan | 16 | 20:50 |
| abdelwas | OK let me test this | 20:50 |
| blogan | well how was neutron lbaas-loadbalancer-create going to octavia before? | 20:50 |
| abdelwas | give me few minutes. I will figure it out | 20:51 |
| blogan | okie | 20:52 |
| abdelwas | forget about what I said | 20:53 |
| abdelwas | I didn't touch this part localrc is corret | 20:53 |
| abdelwas | and the driver is patched with this https://review.openstack.org/#/c/174114/15 | 20:54 |
| minwang2 | i tried to use postman to create lb against octavia, it always gave me pending_create status | 20:54 |
| abdelwas | check Phillip comment here: https://review.openstack.org/#/c/174114/15/neutron_lbaas/drivers/octavia/driver.py | 20:56 |
| abdelwas | Got it! | 20:58 |
| blogan | abdelwas: should be patched with the 16th patchset | 20:58 |
| blogan | not 15th | 20:58 |
| blogan | minwang2: is it slow fro the amphora to become active? | 20:59 |
| abdelwas | Yep | 20:59 |
| abdelwas | Thank ouy | 20:59 |
| abdelwas | s/ouy/you | 20:59 |
| minwang2 | yeah | 20:59 |
| minwang2 | i am testing it now | 20:59 |
| blogan | up the timeout limit | 21:00 |
| *** woodster_ has quit IRC | 21:00 | |
| *** openstack has joined #openstack-lbaas | 21:08 | |
| blogan | but basically you rebasing master locally could cause a lost patchset on a parent, if i had pushed up a patch set after you did a git review -d on yours, then that patchset would ahve been overwritten | 21:09 |
| blogan | its fine right now so no harm done, just be careful in the future and make sure you have the up-to-date parent patches before you do a rebase and push | 21:10 |
| minwang2 | how can i make sure that i have the up-to-date parent patches | 21:11 |
| minwang2 | just click the button’ rebase change’ ? | 21:12 |
| blogan | yeah, but there's no way to be 100% certain as there will always be a time gap between the time you check and the time you push | 21:13 |
| blogan | so just check before you push | 21:13 |
| minwang2 | ok, good to know | 21:14 |
| minwang2 | thanks | 21:14 |
| openstackgerrit | Banashankar k proposed openstack/octavia: Excluding virtual interfaces like eth0:1 while reading the stats file /sys/class/net/{interface}/statistics/{type}_bytes https://review.openstack.org/206275 | 21:19 |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Decouple amp driver from network using new models https://review.openstack.org/205313 | 21:20 |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Adding amphora failover flows https://review.openstack.org/202336 | 21:20 |
| *** TrevorV has quit IRC | 21:20 | |
| pothole | https://review.openstack.org/#/c/185540/ https://review.openstack.org/#/c/188703/ Can we get some eyes one these, please? | 21:22 |
| minwang2 | i tried to create lb by postman, it is always in pending_create status | 21:24 |
| pothole | If you query the lb after you create it is the status the same? | 21:25 |
| blogan | pothole: was just starting up on that, but i gotta get barbican running again | 21:26 |
| blogan | minwang2: is the amphora not going active in nova? | 21:27 |
| pothole | K, if you need a hand let me know blogan | 21:27 |
| pothole | I have an array of manequin hands in the closet I will ship via fedex if you so need. | 21:27 |
| blogan | creeper | 21:28 |
| minwang2 | https://gist.github.com/mallow111/cbf9239fc5eacb461657 | 21:30 |
| minwang2 | i put it here | 21:30 |
| minwang2 | the lb’s status in db are pending_create, there are 2 nova instance, they are active | 21:30 |
| blogan | well you'd have to look at the logs of the controller worker then | 21:31 |
| *** jorgem has joined #openstack-lbaas | 21:44 | |
| *** ig0r__ has quit IRC | 21:51 | |
| xgerman | pothole gave you +2 on one of the patches; rm_work? | 22:06 |
| rm_work | which one? | 22:07 |
| rm_work | i was looking at one of blogan's patches then got into a 1.5h meeting | 22:07 |
| rm_work | >_> | 22:07 |
| *** jorgem has quit IRC | 22:08 | |
| pothole | ? | 22:08 |
| pothole | I gave him no such thing! | 22:08 |
| blogan | pothole will have to push up a new patchset | 22:09 |
| pothole | ok, i misread that >< | 22:10 |
| openstackgerrit | Phillip Toohill proposed openstack/octavia: Hooking TLS together https://review.openstack.org/185540 | 22:10 |
| *** jorgem has joined #openstack-lbaas | 22:11 | |
| minwang2 | "debuginfo": "Traceback (most recent call last):\n\n File \"/usr/local/lib/python2.7/dist-packages/wsmeext/pecan.py\", line 84, in callfunction\n result = f(self, *args, **kwargs)\n\n File \"/opt/stack/octavia/octavia/api/v1/controllers/load_balancer.py\", line 62, in get_all\n [lb_types.LoadBalancerResponse])\n\n File \"/opt/stack/octavia/octavia/api/v1/controllers/base.py\", line 57, in _convert_db_to_type\n converted = | 22:12 |
| minwang2 | [_convert(db_obj) for db_obj in db_entity]\n\n File \"/opt/stack/octavia/octavia/api/v1/controllers/base.py\", line 49, in _convert\n api_type.vip = lb_types.VIP.from_data_model(db_obj.vip)\n\n File \"/opt/stack/octavia/octavia/api/v1/types/base.py\", line 48, in from_data_model\n return cls(**data_model.to_dict())\n\nAttributeError: 'NoneType' object has no attribute 'to_dict'\n", | 22:12 |
| minwang2 | "faultcode": "Server", | 22:12 |
| minwang2 | "faultstring": "'NoneType' object has no attribute 'to_dict'" | 22:12 |
| minwang2 | this when i tried to retrieve the latest lb that i created | 22:12 |
| minwang2 | from the db table, this new lb’s provisioing status is active | 22:12 |
| rm_work | xgerman: which patchset? the one he just submitted? | 22:20 |
| rm_work | i am doing reviews right now | 22:20 |
| rm_work | so | 22:20 |
| rm_work | i can add another to my queue | 22:21 |
| xgerman | https://review.openstack.org/#/c/188703/ | 22:23 |
| *** jorgem has quit IRC | 22:25 | |
| *** jorgem has joined #openstack-lbaas | 22:26 | |
| *** jorgem has quit IRC | 22:27 | |
| xgerman | actually: https://review.openstack.org/#/c/185540/ | 22:28 |
| xgerman | and he overwrote my +2 so never mind :-) | 22:28 |
| pothole | >< | 22:28 |
| pothole | Forgot things have merged with other migrations. Had to update revisions | 22:28 |
| rm_work | heh | 22:29 |
| rm_work | was gonna say, i don't see you ever giving that first one a +2 | 22:29 |
| xgerman | yeah, need to +2 some more | 22:30 |
| *** apuimedo has quit IRC | 22:31 | |
| pothole | bloogan is saying that might be wrong also, so give me a sec. i got distracted with other things | 22:31 |
| xgerman | yep, I was holding my horses... | 22:32 |
| *** apuimedo has joined #openstack-lbaas | 22:36 | |
| *** harlowja has quit IRC | 22:44 | |
| *** harlowja has joined #openstack-lbaas | 22:44 | |
| rm_work | gah | 22:46 |
| rm_work | finally finished reviewing blogan's | 22:46 |
| rm_work | but on an old patchset >_< | 22:46 |
| rm_work | https://review.openstack.org/#/c/205313/4 | 22:46 |
| rm_work | will try to move them over | 22:46 |
| *** abdelwas has quit IRC | 22:48 | |
| rm_work | loool | 22:48 |
| rm_work | german and i had the same issue with call_count | 22:48 |
| rm_work | almost identical comments | 22:48 |
| rm_work | lol | 22:48 |
| rm_work | ok | 22:49 |
| rm_work | updated | 22:49 |
| rm_work | all moved to new patchset | 22:49 |
| rm_work | https://review.openstack.org/#/c/205313/6 | 22:49 |
| rm_work | blogan: ^^ | 22:49 |
| xgerman | lol | 22:50 |
| rm_work | using call_count is almost always just lazy | 22:51 |
| rm_work | >_> | 22:51 |
| rm_work | I guess blogan has been in a hurry recently :P | 22:51 |
| blogan | ha it was laziness | 22:51 |
| rm_work | you lazy bastard | 22:52 |
| blogan | but i would still use it in addition | 22:52 |
| blogan | bc i'd like to know if it is ever called more than i expect | 22:52 |
| rm_work | if you check the specific calls, it implicitly checks call_count | 22:52 |
| rm_work | because it will fail the assert if there are non-listed calls | 22:52 |
| blogan | has_calls? | 22:52 |
| blogan | assert_has_calls? | 22:52 |
| rm_work | assert_called_with() | 22:53 |
| rm_work | i think | 22:53 |
| blogan | nope | 22:53 |
| rm_work | and a list of mock.call() | 22:53 |
| blogan | that doesn't exist | 22:53 |
| rm_work | yes it does | 22:53 |
| rm_work | assert_called_once_with() doesn't | 22:53 |
| xgerman | I usually do assert_any_call_with | 22:53 |
| blogan | that one does! | 22:53 |
| xgerman | of course order is hard to test | 22:53 |
| blogan | assert_called_with exists too damnit | 22:53 |
| *** minwang2 has quit IRC | 22:53 | |
| rm_work | ah yeah assert_has_calls | 22:54 |
| rm_work | is what you want i guess | 22:54 |
| blogan | no bc that won't fail if there is other calls | 22:54 |
| rm_work | but the ones i mentioned do exist | 22:54 |
| rm_work | it should | 22:54 |
| rm_work | hmm | 22:54 |
| blogan | need to use any_order argument then | 22:55 |
| rm_work | ah yeah | 22:55 |
| blogan | never looked at that one | 22:55 |
| rm_work | " There can be extra calls before or after the specified calls." | 22:55 |
| rm_work | so i guess you do | 22:55 |
| rm_work | hmm | 22:55 |
| rm_work | yeah unless "any_order" | 22:55 |
| blogan | but what i fi want to test order and call count? | 22:55 |
| rm_work | err | 22:55 |
| *** minwang2 has joined #openstack-lbaas | 22:55 | |
| rm_work | actually i think any_order=True still doesn't guarantee call count | 22:56 |
| rm_work | damn | 22:56 |
| rm_work | the wording is weird | 22:56 |
| blogan | sounds like it does | 22:56 |
| blogan | but it woudl be weird that any_order=True and False has different behavior with that | 22:56 |
| rm_work | yeah | 22:56 |
| rm_work | it has the same behavior | 22:56 |
| rm_work | so, no guarantee | 22:56 |
| blogan | oh yeah it doesn't sound like it would | 22:56 |
| blogan | yeah i dont think it would assert call count either | 22:57 |
| blogan | so i stand by my original statement | 22:57 |
| rm_work | do both | 22:57 |
| rm_work | sure | 22:57 |
| openstackgerrit | Phillip Toohill proposed openstack/octavia: Hooking TLS together https://review.openstack.org/185540 | 22:57 |
| rm_work | damnit pothole i'm trying to review that | 22:57 |
| rm_work | are you done? :P | 22:57 |
| blogan | if he tested the migration ran he is | 22:57 |
| blogan | pothole: did you test the migration this time? | 22:58 |
| pothole | yes | 22:59 |
| rm_work | heh k | 23:08 |
| *** apuimedo has quit IRC | 23:12 | |
| blogan | alright responded to comments, will fix later tonight, im going home | 23:13 |
| rm_work | pothole: some issues with the tests on yours, but otherwise giving it a +2 | 23:15 |
| rm_work | kk blogan | 23:15 |
| blogan | rm_work: did you test out functionality too wtih barbican? | 23:15 |
| rm_work | i haven't run it in devstack, if that's what you mean | 23:15 |
| rm_work | but it should work | 23:15 |
| blogan | oh should it eh? | 23:15 |
| rm_work | yes :P | 23:15 |
| rm_work | I am assuming pothole has run it in devstack | 23:16 |
| blogan | im going to test it out, if yall want to merge it fine by me actually, bc we can do follow up bug fixes | 23:16 |
| rm_work | well, it's more than an assumption, since i have seen him running this code IIRC | 23:16 |
| rm_work | pothole: comments on that? | 23:16 |
| pothole | Yes, ive had this running, not since the migration update | 23:17 |
| openstackgerrit | German Eichberger proposed openstack/octavia: Adds method to update server.pem to Amphora REST spec https://review.openstack.org/207659 | 23:17 |
| pothole | but, that shouldnt really matter and nothing else has changed since it was last running | 23:18 |
| pothole | in other words, i have not ran it today | 23:18 |
| blogan | pothole, rm_work: they still haven't fixed the issue with teh barbican client not allowing a normal use to store a secret? | 23:20 |
| blogan | actually sounds like a barbican api problem | 23:20 |
| pothole | lol, comments on stuff that's been there and i didnt touch >< | 23:20 |
| rm_work | ? | 23:20 |
| rm_work | my only comments were on changed code? I thought | 23:21 |
| rm_work | it was green | 23:21 |
| rm_work | i'll check again | 23:21 |
| pothole | no :P | 23:21 |
| pothole | none were on changed code | 23:21 |
| rm_work | oh prolly it came in as part of a rebase | 23:21 |
| pothole | :P | 23:21 |
| rm_work | i was viewing changed from 4:6 | 23:21 |
| rm_work | err | 23:21 |
| rm_work | 14:16 | 23:21 |
| pothole | ah | 23:22 |
| blogan | pothole 14:16 sounds like a chapter:verse i'd like to read | 23:22 |
| blogan | i really should go home | 23:22 |
| pothole | :P | 23:22 |
| blogan | and i really am | 23:22 |
| blogan | adios | 23:22 |
| pothole | bye | 23:22 |
| pothole | hit a pothole on the way | 23:22 |
| pothole | <3 | 23:22 |
| blogan | only if you're walking across the street | 23:23 |
| pothole | </3 | 23:23 |
| rm_work | pothole: well I gave you a +2 anyway <_< | 23:23 |
| rm_work | so no complaining | 23:23 |
| pothole | :P lol, thank you | 23:23 |
| rm_work | any others need review? | 23:24 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!