| *** openstack has joined #openstack-lbaas | 14:36 | |
| *** openstack has joined #openstack-lbaas | 15:44 | |
| *** johnsom has joined #openstack-lbaas | 15:46 | |
| *** amotoki has quit IRC | 15:53 | |
| *** ajmiller has joined #openstack-lbaas | 15:56 | |
| *** manishg has quit IRC | 16:01 | |
| *** markvan_ is now known as markvan | 16:10 | |
| *** chlong has joined #openstack-lbaas | 16:40 | |
| *** manishg has joined #openstack-lbaas | 16:45 | |
| *** armax has joined #openstack-lbaas | 16:54 | |
| *** prabampm has quit IRC | 16:58 | |
| *** markvan has quit IRC | 16:59 | |
| ptoohill | rm_work: sbalukoff I've already scheduled a room with the CEC. We should be good to go | 17:01 |
|---|---|---|
| rm_work | awesome | 17:01 |
| *** markvan has joined #openstack-lbaas | 17:02 | |
| johnsom | Cool | 17:08 |
| ptoohill | Ill double check that we also have the backup room reserved assuming we get booted from the fancy one :) | 17:09 |
| *** minwang2 has joined #openstack-lbaas | 17:10 | |
| *** Piet has joined #openstack-lbaas | 17:22 | |
| xgerman | ptoohill since FWaaS is coming, too, we need two rooms probably anyway | 17:26 |
| ptoohill | o.o | 17:27 |
| ptoohill | how many people are expected | 17:27 |
| xgerman | like maybe 6 more | 17:27 |
| ptoohill | either of the two rooms are big enough to house us | 17:28 |
| ptoohill | untill we get above the 25 persons mark | 17:29 |
| ptoohill | then we have meeting outside on pic-a-nic table | 17:29 |
| *** prabampm has joined #openstack-lbaas | 17:32 | |
| *** diogogmt has joined #openstack-lbaas | 17:33 | |
| dougwig | please rsvp here: https://etherpad.openstack.org/p/lbaas-mitaka-midcycle | 17:45 |
| xgerman | well, gotta check budget | 17:50 |
| *** madhu_ak has joined #openstack-lbaas | 17:59 | |
| johnsom | FYI, oslo team is looking for comments on: "Backwards compatibility for clients and libraries" https://review.openstack.org/#/c/226157 | 18:02 |
| *** harlowja has joined #openstack-lbaas | 18:10 | |
| *** chlong has quit IRC | 18:10 | |
| *** adam_g has quit IRC | 18:14 | |
| *** rm_work has quit IRC | 18:17 | |
| *** clev_ has quit IRC | 18:20 | |
| *** davidlenwell has quit IRC | 18:21 | |
| *** rm_work has joined #openstack-lbaas | 18:22 | |
| *** davidlenwell has joined #openstack-lbaas | 18:23 | |
| *** clev has joined #openstack-lbaas | 18:25 | |
| *** chlong has joined #openstack-lbaas | 18:26 | |
| *** bana_k has joined #openstack-lbaas | 18:27 | |
| *** yamamoto has quit IRC | 18:27 | |
| *** doug-fish has quit IRC | 18:28 | |
| *** crc32 has joined #openstack-lbaas | 18:28 | |
| *** prabampm1 has joined #openstack-lbaas | 18:29 | |
| *** manishg has quit IRC | 18:29 | |
| *** prabampm has quit IRC | 18:30 | |
| *** manishg has joined #openstack-lbaas | 18:32 | |
| sc68cal | c=INBOX | 18:38 |
| sc68cal | whhops this isn't mutt | 18:39 |
| xgerman | no... | 18:39 |
| openstackgerrit | min wang proposed openstack/octavia: Add cert tracking and rotating in Housekeeping https://review.openstack.org/215359 | 18:39 |
| *** itsuugo has quit IRC | 18:40 | |
| *** itsuugo has joined #openstack-lbaas | 18:41 | |
| *** minwang2 has quit IRC | 18:49 | |
| *** minwang2 has joined #openstack-lbaas | 18:50 | |
| *** manishg_ has joined #openstack-lbaas | 19:02 | |
| *** manishg has quit IRC | 19:04 | |
| *** ducttape_ has quit IRC | 19:10 | |
| *** neelashah has joined #openstack-lbaas | 19:10 | |
| blogan | dougwig: is January considered Winter 2015? | 19:23 |
| *** ducttape_ has joined #openstack-lbaas | 19:23 | |
| *** TrevorV|Home has joined #openstack-lbaas | 19:24 | |
| *** yamamoto has joined #openstack-lbaas | 19:28 | |
| *** neelashah has quit IRC | 19:31 | |
| xgerman | not sure — you know winter in the norther hemisphere is summer somewhere else | 19:31 |
| blogan | somewhere else = southern hemisphere :) | 19:32 |
| *** yamamoto has quit IRC | 19:33 | |
| sc68cal | blogan: frankly depends on where we go - san antonio in january may not actually be a winter climate ;) | 19:33 |
| blogan | haha, wel its been in the 50s the last couple of days, thats pretty wintery | 19:34 |
| blogan | had to turn the old heater on | 19:34 |
| ptoohill | Yea, those 40 something degree nights were freezing. Heater spit out dust | 19:36 |
| dougwig | blogan: heh, did i do that? | 19:37 |
| TrevorV|Home | You sill kids. I turned off the heat in my house last week. Sat in 62 degree house in shorts and a t-shirt. Love it. Perfect weather | 19:37 |
| *** minwang2 has quit IRC | 19:47 | |
| *** manishg_ has quit IRC | 19:47 | |
| *** manishg has joined #openstack-lbaas | 19:47 | |
| *** doug-fish has joined #openstack-lbaas | 20:14 | |
| *** minwang2 has joined #openstack-lbaas | 20:14 | |
| *** neelashah has joined #openstack-lbaas | 20:28 | |
| *** neelashah has quit IRC | 20:38 | |
| *** TrevorV|Home has quit IRC | 20:40 | |
| *** pc_m has joined #openstack-lbaas | 20:42 | |
| pc_m | Hi folks, is pep8 broken for neutron-lbaas right now? | 20:42 |
| pc_m | I had an older repo, that I pulled latest from master, and ran pep8 and it has a bunch of failures. | 20:43 |
| * pc_m scratching head | 20:43 | |
| ptoohill | pc_m: Testing now | 20:44 |
| ptoohill | pep8 shouldn't be broken | 20:44 |
| rm_work | hmm | 20:44 |
| pc_m | ptoohill: renamed the repo area, and cloning again. | 20:45 |
| pc_m | ptoohill: Running pep8 | 20:45 |
| pc_m | ptoohill: it's failing... | 20:46 |
| ptoohill | def seeing interesting output that ive not seen before | 20:46 |
| ptoohill | yea, it failed for me | 20:46 |
| ptoohill | looks like something updated recently and broken all the things | 20:46 |
| ptoohill | awesome! | 20:47 |
| pc_m | ptoohill: whew... thought it was me. | 20:47 |
| ptoohill | This is a mess, dear lord, what happened | 20:47 |
| ptoohill | There is a patch that this might be convering | 20:47 |
| pc_m | Got about 25 lines of errors | 20:47 |
| ptoohill | guess they changed rules, everywhere | 20:47 |
| ptoohill | yea | 20:47 |
| ptoohill | :/ | 20:47 |
| ptoohill | https://review.openstack.org/#/c/251346/ | 20:48 |
| ptoohill | Think this is attempting to fix it | 20:48 |
| ptoohill | eh, maybe not | 20:49 |
| ptoohill | im assuming we only need to worry about the actual 'errors' and not the pink 'R' stuff. Ive not seen this before | 20:50 |
| ptoohill | complaining about things in rdware driver and everywhere else | 20:50 |
| ptoohill | blogan, thoughts? | 20:50 |
| ptoohill | dougwig: xgerman anyone with any knowledge of 'new' pep8? not sure when this happened but everythings a mess according to it | 20:51 |
| *** doug-fish has quit IRC | 20:51 | |
| johnsom | pylint changed, likely not for the good. | 20:51 |
| xgerman | nope. I am as surprised as everybody | 20:51 |
| ptoohill | :/ | 20:52 |
| ptoohill | fantastic | 20:52 |
| ptoohill | complaining about nested blocks and if statements, this seems fun | 20:52 |
| *** prabampm1 has quit IRC | 20:53 | |
| pc_m | ptoohill: sorry to mess up your day... | 20:53 |
| ptoohill | lol, thanks :) | 20:53 |
| *** doug-fish has joined #openstack-lbaas | 20:54 | |
| pc_m | ptoohill: I guess better now, that right at M1 deadline :) | 20:54 |
| *** doug-fis_ has joined #openstack-lbaas | 20:55 | |
| ptoohill | so it does look like that patch i linked is attempting to resolve some of this. Ill dig in | 20:57 |
| *** doug-fi__ has joined #openstack-lbaas | 20:57 | |
| *** doug-fish has quit IRC | 20:58 | |
| *** doug-fis_ has quit IRC | 21:00 | |
| pc_m | ptoohill: thanks! | 21:01 |
| *** doug-fi__ has quit IRC | 21:02 | |
| *** Piet has quit IRC | 21:04 | |
| *** doug-fish has joined #openstack-lbaas | 21:04 | |
| rm_work | we can also just... add some rules to our ignore list | 21:08 |
| rm_work | might be best for the time being | 21:08 |
| rm_work | then make patches to fix some of those and remove them from the ignore list later | 21:08 |
| *** doug-fish has quit IRC | 21:09 | |
| xgerman | rm_work +1 | 21:09 |
| rm_work | so wait, what rules did they change | 21:12 |
| rm_work | did they seriously think it would be a good idea to just swap import order? or is this not actually true | 21:13 |
| rm_work | i feel like that can't be right | 21:13 |
| blogan | is this abotu import error? | 21:13 |
| blogan | import ordering? | 21:13 |
| rm_work | yeah, looking at venkat's patch | 21:13 |
| rm_work | this is a whole lot of "wat" | 21:13 |
| blogan | yeah neutron is a 3rd party lib to us | 21:13 |
| rm_work | yeah so it goes second | 21:14 |
| rm_work | right? | 21:14 |
| blogan | yep | 21:14 |
| rm_work | system, third party, us | 21:14 |
| blogan | should | 21:14 |
| rm_work | so that isn't a change | 21:14 |
| ptoohill | run pep8 on master | 21:14 |
| rm_work | hasn't it always been like that? | 21:14 |
| ptoohill | just to see for yourself | 21:14 |
| rm_work | running now | 21:14 |
| johnsom | It's the new 1.5 pylint | 21:14 |
| ptoohill | get ready | 21:14 |
| blogan | oh boy | 21:14 |
| rm_work | rebuilding env takes a bit <_< | 21:14 |
| ptoohill | lel | 21:14 |
| rm_work | ah that's not too bad | 21:17 |
| rm_work | just a few | 21:17 |
| rm_work | i'd add a couple to ignore-list, fix the imports, and call it good | 21:17 |
| ptoohill | you see all the pink and yellow things? | 21:18 |
| ptoohill | my screen filled up with stuff | 21:18 |
| ptoohill | youre not running with his patch? | 21:18 |
| ptoohill | i mean, do it without his patch | 21:18 |
| dougwig | there's a "new" pep8? wtf? | 21:18 |
| ptoohill | pylint update | 21:18 |
| rm_work | i am on master | 21:19 |
| rm_work | just pulled and rebuilt | 21:19 |
| ptoohill | my screen filled with red/pink/green and yellow errors | 21:19 |
| rm_work | only about one screen of stuff | 21:19 |
| rm_work | yeah | 21:19 |
| rm_work | but it's not too bad | 21:19 |
| ptoohill | oh, yea, just one screen, k | 21:19 |
| ptoohill | lol | 21:19 |
| dougwig | awesome. so glad that we spend so much time on useful work. | 21:19 |
| ptoohill | ^ | 21:19 |
| rm_work | ignore unsubscriptable-object too-many-nested-blocks redefined-variable-type | 21:19 |
| johnsom | +1 | 21:19 |
| pc_m | about 25 msgs | 21:19 |
| rm_work | fix the others | 21:19 |
| rm_work | I could do it | 21:20 |
| rm_work | if you want | 21:20 |
| ptoohill | sure, have at it! :D | 21:20 |
| rm_work | i was planning to help trevor with stuff today but he's out sick now, so | 21:20 |
| *** bana_k has quit IRC | 21:20 | |
| blogan | lets just ignore all thsoe rules | 21:20 |
| ptoohill | though, that other patch is fixing a majority of these i thought | 21:20 |
| rm_work | i can mash this out really quick I think | 21:20 |
| rm_work | blogan: yeah most of them | 21:20 |
| ptoohill | maybe collab with him? | 21:20 |
| rm_work | that patch... i don't ... hmm | 21:20 |
| ptoohill | k, whatever is best/easiest | 21:20 |
| rm_work | yeah lol | 21:21 |
| ptoohill | :P | 21:21 |
| * ajmiller noticed all the gate failure, thought he'd look here and see if anyone knows what's up... | 21:21 | |
| ptoohill | :D | 21:21 |
| *** prabampm has joined #openstack-lbaas | 21:21 | |
| * blogan looks at ajmiller | 21:21 | |
| ptoohill | ajmiller slowly steps out | 21:22 |
| rm_work | yeah let me put something up for that really quick | 21:22 |
| ptoohill | cool | 21:22 |
| pc_m | rm_work: Let me know the patch. I can try it on my repo (I'm trying some changes related to neutron-lib) | 21:22 |
| * ajmiller backs out the way he came | 21:22 | |
| ajmiller | Seriously, let me know if I can help. | 21:22 |
| blogan | pc_m: vpnaas didn't have similar issues? | 21:23 |
| ajmiller | blogan It looks like it does. | 21:23 |
| pc_m | blogan: ummm, haven't ran it recently :) | 21:23 |
| blogan | pc_m: lol that was my next question | 21:23 |
| blogan | should have been my first question | 21:23 |
| pc_m | blogan: I can look over there. | 21:23 |
| blogan | looks like ajmiller has though | 21:23 |
| blogan | pc_m: nah | 21:23 |
| pc_m | Probably will need to do the same thing. | 21:24 |
| ajmiller | http://logs.openstack.org/19/250719/1/gate/gate-neutron-vpnaas-pep8/b23ff3b/console.html | 21:24 |
| blogan | ah yeah | 21:24 |
| blogan | pc_m: run it on neutron? i just did tons of failures | 21:25 |
| pc_m | blogan: bummer | 21:25 |
| pc_m | my neutron repo is a few weeks old... yaya! | 21:28 |
| pc_m | ajmiller: I can work on the VPN repo | 21:28 |
| blogan | pc_m: i had to update tox to 2.0 to run the new one | 21:29 |
| blogan | wonder if that is somethign we all have to do | 21:29 |
| blogan | or if i'm just the one lagger | 21:29 |
| ajmiller | pc_m Cool, that would be great. I'll keep an eye out and review ASAP... | 21:29 |
| pc_m | blogan: I think I did that last week in my VMs | 21:29 |
| pc_m | ajmiller: OK | 21:29 |
| *** doug-fish has joined #openstack-lbaas | 21:32 | |
| *** crc32 has quit IRC | 21:33 | |
| *** doug-fis_ has joined #openstack-lbaas | 21:35 | |
| openstackgerrit | Adam Harwell proposed openstack/neutron-lbaas: Gatefix: ignore most new pylint rules, fix some imports https://review.openstack.org/251546 | 21:35 |
| *** doug-fis_ has quit IRC | 21:35 | |
| rm_work | ^^ pretty much that's it | 21:35 |
| rm_work | not sure what was going on in that other patch | 21:35 |
| *** doug-fis_ has joined #openstack-lbaas | 21:35 | |
| rm_work | I wanted to look at some of the other ones but they're in radware's stuff or netscaler's stuff and while they don't quite look right, it's not really good for me to mess with them probably :/ | 21:36 |
| rm_work | I guess if they start breaking, someone at those companies will look at it? | 21:36 |
| *** doug-fish has quit IRC | 21:37 | |
| pc_m | rm_work: I'm seeing some odd errors in VPN with import ordering. | 21:39 |
| pc_m | rm_work: Is there a way to ignore in the file? | 21:39 |
| rm_work | no | 21:39 |
| rm_work | pc_m: which errors in vpnaas? i can take a look | 21:39 |
| rm_work | sec let me pull it down | 21:39 |
| blogan | pc_m: you can ignore in the file with pylint directives | 21:40 |
| pc_m | In https://github.com/openstack/neutron-vpnaas/blob/master/neutron_vpnaas/services/vpn/common/netns_wrapper.py | 21:40 |
| rm_work | blogan: ah, is that so? maybe should do that for the weirder ones then | 21:40 |
| rm_work | didn't think they allowed that yet | 21:40 |
| rm_work | I remember trying before ... maybe that was only for pep8 and not pylint | 21:40 |
| pc_m | Says config parser should be before eventlet. If move up, then don't have six defined. | 21:41 |
| *** Piet has joined #openstack-lbaas | 21:41 | |
| rm_work | err | 21:41 |
| rm_work | so, I have seen eventlet defined in its own category, lol | 21:41 |
| pc_m | If I move siz up then it complains about it being before configparser. | 21:41 |
| pc_m | six | 21:41 |
| rm_work | https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/services/loadbalancer/drivers/radware/driver.py#L23 | 21:42 |
| rm_work | check out THAT | 21:42 |
| rm_work | i don't even know what they are doing but it seems to work | 21:42 |
| rm_work | can you do similar? | 21:42 |
| rm_work | looking at using pylint directives for the radware/netscaler issues instead of global | 21:43 |
| pc_m | added blank line, but still failed. | 21:44 |
| *** bana_k has joined #openstack-lbaas | 21:45 | |
| blogan | rm_work: you have to import eventlet as one of the first imports and monkey patch it immediately to not cause issues with other imports | 21:45 |
| rm_work | yeah apparently... lol eventlet | 21:46 |
| blogan | of course i think import eventlet and monkey patching it would be best in the __init__ module for that package | 21:46 |
| xgerman | isn’t there a pep8 preventing putting stuff in __ini? | 21:48 |
| pc_m | blogan: on VPN, I've got a chick and the egg issue. | 21:48 |
| pc_m | It want's configparser before eventlet, but configparser is in an if-clause using six, which has to be after eventlet. | 21:49 |
| blogan | pc_m: oh nice | 21:49 |
| blogan | pc_m: damn required monkey patching! | 21:49 |
| blogan | pc_m: why does it need configparser before eventlet? | 21:50 |
| blogan | pc_m: i'm sure its a long story lol | 21:50 |
| pc_m | pep8 thinks order is wrong. | 21:50 |
| blogan | ohhh | 21:50 |
| pc_m | I had, eventlet, six, if-clause with configparser | 21:51 |
| pc_m | pep8 wants configparser, eventlet | 21:51 |
| blogan | yeah | 21:51 |
| pc_m | See link above. | 21:51 |
| blogan | even with the if statement? | 21:51 |
| pc_m | Wondering if I can do #pylint: comment in the file. | 21:51 |
| blogan | you can | 21:51 |
| blogan | but before pylint wouldn't worry about import ordering after there was already 3 sections | 21:52 |
| rm_work | pc_m: also if it's in the 4th section (after everything else) it isn't even checked | 21:52 |
| rm_work | ^^ yeah what blogan said | 21:52 |
| blogan | is that not the case anymore? | 21:52 |
| pc_m | Well, it is in the 4th section, I guess. https://github.com/openstack/neutron-vpnaas/blob/master/neutron_vpnaas/services/vpn/common/netns_wrapper.py#L16-L33 | 21:53 |
| blogan | yea it is | 21:55 |
| blogan | so does pylint now check sections after the 3rd section? | 21:55 |
| pc_m | seems to | 21:55 |
| blogan | okay so | 21:55 |
| blogan | do a #pylint: disable=import-order at end end of those lines | 21:56 |
| blogan | 31, and 33 | 21:56 |
| blogan | i guess thats the only option | 21:56 |
| pc_m | Will try... I was trying to figure out the syntax. | 21:57 |
| blogan | i can't remember the rules symbolic name | 21:57 |
| blogan | pc_m: did you ever run tox on neutron and get the same errors i was? | 21:58 |
| pc_m | not yet. | 21:58 |
| blogan | could you for my own sanity check? | 21:59 |
| pc_m | says import-order is bad-option-vallue | 21:59 |
| pc_m | will try wrong-import-order | 21:59 |
| pc_m | ^^ worked | 22:00 |
| pc_m | thanks! | 22:00 |
| pc_m | Pushed up a fix for VPN. Trying neutron now. | 22:02 |
| blogan | i have a fix ready to go for neutron but i'm not sure i'm getting the same thign as what is giong on in the check jobs | 22:03 |
| pc_m | blogan: I'm running pep8 right now | 22:04 |
| pc_m | blogan: I updated my master with latest, and pep8 passed. | 22:05 |
| *** crc32 has joined #openstack-lbaas | 22:06 | |
| pc_m | blogan: Deleted all .pyc, .tox dir and re-running, just to double check. | 22:06 |
| pc_m | blogan: yikes! | 22:08 |
| pc_m | blogan: I got tons of undefined-variable errors... I'm rechecking... | 22:09 |
| pc_m | something is really hosed. I'm cloning a new repo and retrying... | 22:12 |
| openstackgerrit | Adam Harwell proposed openstack/neutron-lbaas: Gatefix: ignore most new pylint rules, fix some imports https://review.openstack.org/251546 | 22:16 |
| rm_work | ok there, i like that better too ^^ | 22:16 |
| pc_m | New clone, getting thousands of undefined variable errors... | 22:16 |
| *** ducttape_ has quit IRC | 22:16 | |
| rm_work | pc_m: finished with mine, let me look again | 22:16 |
| pc_m | rm_work: VPN change is up | 22:17 |
| rm_work | this is neutron-vpnaas? | 22:17 |
| pc_m | yeah | 22:17 |
| pc_m | https://review.openstack.org/251556 | 22:17 |
| pc_m | rm_work: blogan asked if I tried neutron. I cloned a new repo and ran pep8 and see thousands of errors. | 22:18 |
| rm_work | aaah neutron, lol | 22:19 |
| rm_work | fff prolly | 22:19 |
| blogan | pc_m: okay good to knwo ill push up this review | 22:19 |
| pc_m | blogan: cool. I'll be on in the early AM and will see what happens. | 22:20 |
| *** neelashah has joined #openstack-lbaas | 22:21 | |
| *** prabampm has quit IRC | 22:23 | |
| *** neelashah has quit IRC | 22:26 | |
| *** neelashah has joined #openstack-lbaas | 22:34 | |
| *** rtheis has quit IRC | 22:42 | |
| *** neelashah has quit IRC | 22:43 | |
| *** doug-fis_ has quit IRC | 22:44 | |
| *** doug-fish has joined #openstack-lbaas | 22:44 | |
| *** doug-fish has quit IRC | 22:49 | |
| *** doug-fish has joined #openstack-lbaas | 22:49 | |
| *** doug-fis_ has joined #openstack-lbaas | 22:50 | |
| *** doug-fish has quit IRC | 22:54 | |
| *** doug-fis_ has quit IRC | 22:55 | |
| *** doug-fish has joined #openstack-lbaas | 23:03 | |
| *** ducttape_ has joined #openstack-lbaas | 23:04 | |
| *** doug-fish has quit IRC | 23:07 | |
| *** minwang2 has quit IRC | 23:09 | |
| rm_work | anyone want to throw a quick review at https://review.openstack.org/#/c/216140/ | 23:31 |
| rm_work | 220 lines, not too bad | 23:31 |
| *** barra204 has quit IRC | 23:38 | |
| *** shakamunyi has joined #openstack-lbaas | 23:38 | |
| *** jerrygb has quit IRC | 23:39 | |
| *** jerrygb has joined #openstack-lbaas | 23:39 | |
| *** manishg has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!