| *** Aish has left #openstack-lbaas | 00:11 | |
| sbalukoff | Thanks for the +2 ptoohill! | 00:31 |
|---|---|---|
| sbalukoff | TrevorV: Stacking to checkout the latest one-call-create patches (this time incorporating the controller patch as well. XD) | 00:35 |
| sbalukoff | Does anyone know who the cores are for the python-neutronclient project? | 00:56 |
| *** hayato_ has joined #openstack-lbaas | 01:00 | |
| *** paco20151113 has joined #openstack-lbaas | 01:38 | |
| *** yamamoto_ has joined #openstack-lbaas | 01:50 | |
| *** ducttape_ has joined #openstack-lbaas | 01:53 | |
| *** yamamoto_ has quit IRC | 01:55 | |
| *** ducttape_ has quit IRC | 02:05 | |
| *** yamamoto_ has joined #openstack-lbaas | 02:08 | |
| *** yamamoto_ has quit IRC | 02:09 | |
| *** manishg has quit IRC | 02:12 | |
| *** ajmiller has quit IRC | 02:25 | |
| *** yamamoto has joined #openstack-lbaas | 02:33 | |
| *** yamamoto has quit IRC | 02:40 | |
| *** manishg has joined #openstack-lbaas | 02:43 | |
| *** mdavidson has quit IRC | 02:46 | |
| *** paco20151113 has quit IRC | 02:47 | |
| *** manishg has quit IRC | 02:48 | |
| *** paco20151113 has joined #openstack-lbaas | 02:48 | |
| *** kfox1111 has quit IRC | 02:49 | |
| *** kfox1111 has joined #openstack-lbaas | 02:49 | |
| *** mdavidson has joined #openstack-lbaas | 02:50 | |
| *** manishg has joined #openstack-lbaas | 03:05 | |
| *** manishg has quit IRC | 03:09 | |
| *** neelashah has joined #openstack-lbaas | 03:22 | |
| *** yamamoto_ has joined #openstack-lbaas | 03:23 | |
| *** Purandar has joined #openstack-lbaas | 03:26 | |
| *** hayato__ has joined #openstack-lbaas | 03:39 | |
| *** hayato_ has quit IRC | 03:41 | |
| *** links has joined #openstack-lbaas | 03:44 | |
| *** neelashah has quit IRC | 03:51 | |
| *** links has quit IRC | 04:01 | |
| *** hayato_ has joined #openstack-lbaas | 04:05 | |
| *** manishg has joined #openstack-lbaas | 04:06 | |
| *** hayato__ has quit IRC | 04:08 | |
| *** hayato__ has joined #openstack-lbaas | 04:09 | |
| *** hayato___ has joined #openstack-lbaas | 04:10 | |
| *** hayato_ has quit IRC | 04:10 | |
| *** hayato_ has joined #openstack-lbaas | 04:11 | |
| *** manishg has quit IRC | 04:11 | |
| *** hayato__ has quit IRC | 04:11 | |
| *** hayato__ has joined #openstack-lbaas | 04:11 | |
| *** hayato___ has quit IRC | 04:15 | |
| *** hayato_ has quit IRC | 04:15 | |
| *** links has joined #openstack-lbaas | 04:18 | |
| openstackgerrit | Madhusudhan Kandadai proposed openstack/neutron-lbaas: [WIP] Neutron LBaaS: TLS Barbican Scenario Test https://review.openstack.org/164828 | 04:23 |
| *** numans has joined #openstack-lbaas | 04:59 | |
| *** manishg has joined #openstack-lbaas | 05:07 | |
| *** manishg has quit IRC | 05:11 | |
| *** manishg has joined #openstack-lbaas | 05:12 | |
| rm_you | sbalukoff: does trevor's fix look good? was just about to test it | 05:13 |
| sbalukoff | Am just getting back to it. Looks like it works to create a complicated LB tree... | 05:13 |
| sbalukoff | Trying to break it now. :) | 05:13 |
| sbalukoff | It caught my l7rule error... | 05:13 |
| sbalukoff | So that's good. | 05:13 |
| sbalukoff | Going to try an l7policy error. | 05:14 |
| rm_you | yes | 05:14 |
| rm_you | i have been mostly testing happy-path, since if it passes that, i'll +2 for merge and then file bugs for any issues on the other paths | 05:14 |
| sbalukoff | yeah, so far happy path looks good. | 05:14 |
| sbalukoff | I'm suspecting that I can break it with an l7policy error... but I would blame that more on how I was doing validations... | 05:15 |
| sbalukoff | (There's a patch go fix that...) | 05:15 |
| sbalukoff | (But I don't want that patch getting in the way of this feature merging. | 05:16 |
| sbalukoff | since that's a bugfix and the feature freeze is tomorrow.) | 05:16 |
| rm_you | yeah | 05:16 |
| sbalukoff | Oh, awesome! He catches it! | 05:19 |
| sbalukoff | So yeah... it looks like this works. | 05:19 |
| sbalukoff | I want to go over the code some more, but from what I can see, this is looking like a +2 from me so far with caveats (again, I want a bug to back-fill the documentation on this, and a bug showing shared-pools support is missing from this.) | 05:20 |
| sbalukoff | But first, I'mma eat this pizza. :) | 05:21 |
| rm_you | heh | 05:22 |
| rm_you | i want to +2 it as well, but first I'mma let this tequila wear off | 05:22 |
| *** yuanying has quit IRC | 05:24 | |
| *** yuanying_ has joined #openstack-lbaas | 05:24 | |
| xgerman | well, sbalukoff those LBaaS reviewers are slackers — I didn’t get much bites for my cascading delete stuff... | 05:29 |
| *** prabampm has joined #openstack-lbaas | 05:46 | |
| *** fawadkhaliq has joined #openstack-lbaas | 05:54 | |
| *** amotoki has joined #openstack-lbaas | 05:56 | |
| *** kevo has joined #openstack-lbaas | 06:01 | |
| *** manishg has quit IRC | 06:01 | |
| openstackgerrit | lei zhang proposed openstack/octavia: Replace deprecated LOG.warn with LOG.warning https://review.openstack.org/263617 | 06:18 |
| *** kevo has quit IRC | 06:19 | |
| sbalukoff | xgerman: I think it helps to poke them directly. | 06:26 |
| rm_you | yeah generally i get best results when i find people who should be reviewing and poke them in IRC | 06:29 |
| rm_you | as a reviewer, often i don't have time to just randomly browse (even though ideally i'd | 06:29 |
| rm_you | *i'd be doing just that) | 06:29 |
| *** kevo has joined #openstack-lbaas | 06:30 | |
| *** manishg has joined #openstack-lbaas | 06:32 | |
| *** manishg has quit IRC | 06:36 | |
| *** Purandar has quit IRC | 06:38 | |
| *** kobis has joined #openstack-lbaas | 06:42 | |
| *** outofmemory is now known as reedip_ | 06:44 | |
| *** rcernin has joined #openstack-lbaas | 06:44 | |
| *** rcernin has quit IRC | 06:49 | |
| sbalukoff | xgerman: Are you still around? | 06:50 |
| sbalukoff | I wanted to talk with you about your comments on the one-call-create controller tasks (and for loops therein) | 06:50 |
| *** kevo has quit IRC | 06:56 | |
| *** hayato__ has quit IRC | 07:04 | |
| *** bana_k has quit IRC | 07:05 | |
| *** fnaval has joined #openstack-lbaas | 07:12 | |
| *** fawadk has joined #openstack-lbaas | 07:15 | |
| *** fawadkhaliq has quit IRC | 07:15 | |
| *** fawadkhaliq has joined #openstack-lbaas | 07:15 | |
| *** amotoki has quit IRC | 07:19 | |
| *** fawadk has quit IRC | 07:20 | |
| *** rcernin has joined #openstack-lbaas | 07:24 | |
| *** amotoki has joined #openstack-lbaas | 07:31 | |
| *** manishg has joined #openstack-lbaas | 07:33 | |
| openstackgerrit | Yi Zhao proposed openstack/neutron-lbaas: Fixed typo in subunit-trace.py https://review.openstack.org/285913 | 07:34 |
| *** amotoki has quit IRC | 07:35 | |
| *** manishg has quit IRC | 07:38 | |
| *** pcaruana has joined #openstack-lbaas | 07:43 | |
| *** fawadkhaliq has quit IRC | 07:43 | |
| *** evgenyf has joined #openstack-lbaas | 07:46 | |
| *** amotoki has joined #openstack-lbaas | 07:49 | |
| *** amotoki has quit IRC | 07:49 | |
| *** fnaval has quit IRC | 07:50 | |
| *** fnaval has joined #openstack-lbaas | 07:59 | |
| *** fnaval has quit IRC | 08:04 | |
| *** ihrachys has joined #openstack-lbaas | 08:06 | |
| *** fnaval has joined #openstack-lbaas | 08:07 | |
| *** kevo has joined #openstack-lbaas | 08:08 | |
| *** fnaval has quit IRC | 08:11 | |
| *** kevo has quit IRC | 08:15 | |
| *** hayato_ has joined #openstack-lbaas | 08:15 | |
| *** hayato_ has quit IRC | 08:15 | |
| *** hayato_ has joined #openstack-lbaas | 08:16 | |
| *** fawadkhaliq has joined #openstack-lbaas | 08:27 | |
| *** rcernin has quit IRC | 08:29 | |
| *** manishg has joined #openstack-lbaas | 08:34 | |
| *** amotoki has joined #openstack-lbaas | 08:35 | |
| *** amotoki has quit IRC | 08:36 | |
| *** rcernin has joined #openstack-lbaas | 08:37 | |
| *** fawadkhaliq has quit IRC | 08:38 | |
| *** manishg has quit IRC | 08:38 | |
| *** amotoki has joined #openstack-lbaas | 08:45 | |
| *** jschwarz has joined #openstack-lbaas | 08:47 | |
| reedip_ | sbalukoff: ping | 08:49 |
| *** eezhova has quit IRC | 08:51 | |
| reedip_ | sbalukoff: I have mentioned 2 syntaxes which are used to mention a list in NeutronClient . Considering that you are using Syntax 1, IMHO, it seems that changing the message for --sni-container-refs would be enough. | 08:54 |
| reedip_ | sbalukoff: but I have given option#2 , considering the 3rd Syntax. | 08:54 |
| reedip_ | sbalukoff: which is more useful | 08:55 |
| *** nmagnezi has joined #openstack-lbaas | 08:56 | |
| *** amotoki has quit IRC | 09:10 | |
| *** amotoki has joined #openstack-lbaas | 09:13 | |
| *** nmagnezi has quit IRC | 09:15 | |
| *** amotoki has quit IRC | 09:24 | |
| *** nmagnezi has joined #openstack-lbaas | 09:28 | |
| *** amotoki has joined #openstack-lbaas | 09:34 | |
| *** manishg has joined #openstack-lbaas | 09:34 | |
| *** paco20151113 has quit IRC | 09:36 | |
| *** manishg has quit IRC | 09:39 | |
| *** evgenyf has quit IRC | 09:53 | |
| *** ihrachys has quit IRC | 09:54 | |
| *** ihrachys has joined #openstack-lbaas | 09:59 | |
| *** kobis has quit IRC | 10:20 | |
| *** kobis has joined #openstack-lbaas | 10:22 | |
| *** manishg has joined #openstack-lbaas | 10:35 | |
| *** hayato_ has quit IRC | 10:39 | |
| *** manishg has quit IRC | 10:40 | |
| *** yamamoto_ has quit IRC | 10:53 | |
| *** amotoki has quit IRC | 11:00 | |
| *** amotoki has joined #openstack-lbaas | 11:03 | |
| *** amotoki has quit IRC | 11:11 | |
| *** yamamoto has joined #openstack-lbaas | 11:31 | |
| *** yamamoto_ has joined #openstack-lbaas | 11:33 | |
| *** otsuka_ has joined #openstack-lbaas | 11:36 | |
| *** yamamoto has quit IRC | 11:36 | |
| *** manishg has joined #openstack-lbaas | 11:38 | |
| *** kobis has quit IRC | 11:38 | |
| *** otsuka has quit IRC | 11:39 | |
| *** kobis has joined #openstack-lbaas | 11:41 | |
| *** manishg has quit IRC | 11:42 | |
| *** kobis has quit IRC | 11:42 | |
| *** kobis has joined #openstack-lbaas | 11:43 | |
| *** kobis has quit IRC | 11:47 | |
| *** kobis has joined #openstack-lbaas | 11:48 | |
| *** kobis has quit IRC | 11:53 | |
| *** kobis has joined #openstack-lbaas | 11:56 | |
| *** otsuka has joined #openstack-lbaas | 12:13 | |
| *** otsuka_ has quit IRC | 12:15 | |
| *** otsuka_ has joined #openstack-lbaas | 12:23 | |
| *** otsuka has quit IRC | 12:26 | |
| *** amotoki has joined #openstack-lbaas | 12:30 | |
| *** H3y has joined #openstack-lbaas | 12:35 | |
| *** otsuka has joined #openstack-lbaas | 12:37 | |
| *** manishg has joined #openstack-lbaas | 12:38 | |
| *** otsuka_ has quit IRC | 12:41 | |
| *** rtheis has joined #openstack-lbaas | 12:42 | |
| *** manishg has quit IRC | 12:43 | |
| *** amotoki has quit IRC | 12:45 | |
| *** pcaruana has quit IRC | 12:53 | |
| *** prabampm has quit IRC | 12:54 | |
| *** amotoki has joined #openstack-lbaas | 13:02 | |
| *** Oku_OS has joined #openstack-lbaas | 13:05 | |
| *** pcaruana has joined #openstack-lbaas | 13:08 | |
| *** otsuka has quit IRC | 13:18 | |
| *** otsuka has joined #openstack-lbaas | 13:18 | |
| *** links has quit IRC | 13:18 | |
| *** amotoki has quit IRC | 13:39 | |
| *** manishg has joined #openstack-lbaas | 13:39 | |
| *** otsuka has quit IRC | 13:40 | |
| *** fawadkhaliq has joined #openstack-lbaas | 13:43 | |
| *** manishg has quit IRC | 13:44 | |
| *** amotoki has joined #openstack-lbaas | 13:53 | |
| *** neelashah has joined #openstack-lbaas | 13:58 | |
| *** links has joined #openstack-lbaas | 13:58 | |
| *** otsuka has joined #openstack-lbaas | 14:06 | |
| *** otsuka has quit IRC | 14:07 | |
| *** otsuka has joined #openstack-lbaas | 14:08 | |
| *** localloo1 has joined #openstack-lbaas | 14:12 | |
| nmagnezi | dougwig, ping re: haproxy namespace | 14:13 |
| *** links has quit IRC | 14:16 | |
| *** ajmiller has joined #openstack-lbaas | 14:18 | |
| *** ajmiller has quit IRC | 14:25 | |
| *** localloo1 has quit IRC | 14:37 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/octavia: glance: support relying on tags to extract image id https://review.openstack.org/284690 | 14:37 |
| *** pcaruana has quit IRC | 14:38 | |
| *** H3y has quit IRC | 14:38 | |
| *** H3y has joined #openstack-lbaas | 14:39 | |
| *** manishg has joined #openstack-lbaas | 14:40 | |
| dougwig | nmagnezi: ack | 14:43 |
| *** manishg has quit IRC | 14:45 | |
| *** woodster_ has joined #openstack-lbaas | 14:49 | |
| *** pcaruana has joined #openstack-lbaas | 14:52 | |
| *** ducttape_ has joined #openstack-lbaas | 14:53 | |
| *** doug-fish has joined #openstack-lbaas | 14:56 | |
| *** TrevorV has joined #openstack-lbaas | 15:00 | |
| *** otsuka has quit IRC | 15:03 | |
| *** H3y has quit IRC | 15:04 | |
| *** H3y has joined #openstack-lbaas | 15:05 | |
| *** ajmiller has joined #openstack-lbaas | 15:16 | |
| TrevorV | sbalukoff I don't expect you to be around just yet, but when you jump online can you hit me up? I want to chat with you a bit about the shared pool single-create situation | 15:17 |
| *** fnaval has joined #openstack-lbaas | 15:18 | |
| *** mestery has quit IRC | 15:19 | |
| *** mestery has joined #openstack-lbaas | 15:19 | |
| *** manishg has joined #openstack-lbaas | 15:29 | |
| *** numans has quit IRC | 15:47 | |
| *** armax has joined #openstack-lbaas | 15:50 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/octavia: glance: support relying on tags to extract image id https://review.openstack.org/284690 | 15:51 |
| ihrachys | bharathm: thanks for reviews on glance tag patch, and sorry for the churn: spending most of my time in neutron code, I already managed to forget how to manage config files manually ;) | 15:56 |
| bharathm | ihrachys: Heh.. Happens sometimes. Thanks for fixing it. Looks good now | 16:00 |
| *** nmagnezi has quit IRC | 16:05 | |
| openstackgerrit | Evgeny Fedoruk proposed openstack/neutron-lbaas: L7 support for Radware LBaaS v2 driver https://review.openstack.org/202147 | 16:05 |
| *** Purandar has joined #openstack-lbaas | 16:13 | |
| *** rcernin has quit IRC | 16:16 | |
| *** fawadkhaliq has quit IRC | 16:17 | |
| *** pcaruana has quit IRC | 16:17 | |
| *** Aish has joined #openstack-lbaas | 16:19 | |
| *** neelashah has quit IRC | 16:20 | |
| *** jwarendt has joined #openstack-lbaas | 16:22 | |
| *** Purandar has quit IRC | 16:23 | |
| *** neelashah has joined #openstack-lbaas | 16:33 | |
| *** sbalukoff has quit IRC | 16:38 | |
| *** bana_k has joined #openstack-lbaas | 16:38 | |
| *** Purandar has joined #openstack-lbaas | 16:41 | |
| *** klindgren has quit IRC | 16:44 | |
| *** manishg has quit IRC | 16:52 | |
| *** manishg has joined #openstack-lbaas | 16:53 | |
| johnsom | TrevorV ping | 16:53 |
| TrevorV | johnsom pong | 16:54 |
| johnsom | https://review.openstack.org/#/c/257013/27 | 16:54 |
| johnsom | Why do we need the peer port task? | 16:54 |
| *** yamamoto_ has quit IRC | 16:54 | |
| johnsom | https://github.com/openstack/octavia/blob/master/octavia/db/repositories.py#L380 | 16:54 |
| *** yamamoto has joined #openstack-lbaas | 16:55 | |
| TrevorV | Honestly johnsom I'm not sure I'm the right person to answer that... That's something i pulled from the review earlier that blogan wrote, so I'd have to really look at what it was doing... sorry (my fault) | 16:56 |
| johnsom | Oh, ok. sbalukoff changed this recently, so maybe that can go away | 16:56 |
| blogan | TrevorV, johnsom: i don't remember honestly, so it may not be needed | 16:56 |
| blogan | if i did it, i'm sure i had a good reason, but i also could have just been crazy | 16:57 |
| TrevorV | Well we know you cray | 16:57 |
| johnsom | Cool, well, that will remove some comments... grin | 16:57 |
| TrevorV | :D | 16:58 |
| TrevorV | I'll delete that task and anywhere its referenced, and see if it 'splodes real quick | 16:58 |
| johnsom | As for the other "discussion", I think the try/catch blocks would be good, just so we don't halt the revert. The repo updates are an enhancement and can be done later if we open a bug (which I can do for you if you would like | 16:58 |
| TrevorV | repo updates? | 16:59 |
| johnsom | Yeah, have one repo call to update all of the listeners on an LB instead of looping and opening multiple db connections | 16:59 |
| TrevorV | Isn't it all done via one session though? | 16:59 |
| TrevorV | so X queries in one session? Did I misread that bit? | 17:00 |
| *** kobis has quit IRC | 17:00 | |
| *** sbalukoff has joined #openstack-lbaas | 17:00 | |
| johnsom | Yes, I meant DB calls | 17:00 |
| johnsom | Haven't had all of by coffee rations for the morning | 17:00 |
| TrevorV | johnsom that's fine ha ha, but then doesn't that mean that its behaving the way we should want? If one of the calls in the session were to fail, it would revert, which is "expected" behavior, right? | 17:01 |
| TrevorV | wouldn't it be best to not have one listener ACTIVE and the others "ERROR" just because we had a failure updating the "ACTIVE" one in the DB? | 17:01 |
| johnsom | An exception inside the revert itself would halt the revert | 17:01 |
| TrevorV | But the session won't update the rows until its exited, right? | 17:02 |
| *** neelashah has quit IRC | 17:02 | |
| TrevorV | So an exception would trickle up, and close the session, updating the rows to all "ACTIVE" which *may* be better than spotty "ERROR" here and there. | 17:02 |
| TrevorV | Especially when the one at fault WASN'T marked as ERROR, potentially | 17:02 |
| TrevorV | Keep in mind, I might be overthinking this, and trusting too much on SQL Alchemy, I'm just talking right now, you know? | 17:03 |
| johnsom | Not 100% sure I follow you, but let's take the mark LB active revert() method as an example. If we get an exception, during that loop setting the listeners to ERROR, it would halt the revert. So the prior tasks in that flow will not have their revert() called. This could mean that the LB itself would not get marked in ERROR because one listener did not update right. | 17:05 |
| *** neelashah has joined #openstack-lbaas | 17:05 | |
| johnsom | At least I think that is what happens when the revert itself gets an exception | 17:06 |
| johnsom | brb | 17:06 |
| *** yamamoto has quit IRC | 17:10 | |
| *** amotoki has quit IRC | 17:13 | |
| johnsom | Back | 17:15 |
| *** kevo has joined #openstack-lbaas | 17:15 | |
| TrevorV | johnsom I see your point. I'm adding a try-catch right now, and am about to go to lunch, so I'll toss up the change here in a second and then be AFK | 17:17 |
| johnsom | Ok | 17:17 |
| *** openstackgerrit has quit IRC | 17:18 | |
| *** openstackgerrit has joined #openstack-lbaas | 17:19 | |
| xgerman | TrevorV thanks — I think each call to the repo opens its own DB session… so they will all be committed | 17:20 |
| TrevorV | johnsom also removing the peer ports task, and running tox. | 17:20 |
| sbalukoff | Major pet peeve of mine: Waiting until the day of a major deadline to point out what are essentially cosmetic errors and -1'ing an important patchset because of them. | 17:20 |
| TrevorV | xgerman yeah that's what johnsom was alluding to. | 17:20 |
| TrevorV | Its something I didn't follow until I looked and saw the "with" context in the DB method | 17:20 |
| TrevorV | It made more sense there. | 17:20 |
| sbalukoff | Could someone please throw some +1's at these: https://review.openstack.org/#/c/218563/ https://review.openstack.org/#/c/217276/ | 17:20 |
| johnsom | sbalukoff re-adding a task to allocate peer ports is not cosmetic | 17:21 |
| *** evgenyf has joined #openstack-lbaas | 17:21 | |
| sbalukoff | johnsom: I wasn't talking about that. XD | 17:21 |
| sbalukoff | I was talking about the python-neutronclient comments that came in last night. | 17:21 |
| johnsom | Ah, ok. Just feeling the hate | 17:21 |
| *** jschwarz has quit IRC | 17:21 | |
| xgerman | python-neutronclient hates everybody - ask jwarendt | 17:21 |
| sbalukoff | Naw-- you and xgerman make good points in your comments on that review. | 17:22 |
| johnsom | Yeah, neutronclient can be slow going | 17:22 |
| TrevorV | Yeah, they were valid concerns. They could have waited for bug stuffs, but only because I'm afraid of the gate right now o_0 | 17:22 |
| TrevorV | ha ha | 17:22 |
| xgerman | well, we can always do that... | 17:23 |
| *** kevo has quit IRC | 17:23 | |
| TrevorV | Its fine, I'm about to push up the changes. | 17:23 |
| TrevorV | We'll hoep for the best. | 17:23 |
| TrevorV | hope*** | 17:24 |
| *** bana_k has quit IRC | 17:24 | |
| xgerman | thanks… my delete-lb stuff is moving slow as well… but I am secretly hoping for an extension ;-) | 17:24 |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Get Me A Load Balancer Controller https://review.openstack.org/257013 | 17:24 |
| TrevorV | johnsom xgerman sbalukoff new patch up. Take a gander if you don't mind. | 17:25 |
| TrevorV | Hopefully I didn't skip one of the suggestions... o_0 | 17:25 |
| TrevorV | brb, goin to lunch | 17:25 |
| xgerman | k | 17:25 |
| sbalukoff | Well... when it comes to L7 code, the CLI is actually the least important thing to get in before the deadline; But this is still important to get merged today if at all possible: https://review.openstack.org/#/c/148232/ Could one or more of y'all neutron-lbaas cores please have a look? | 17:26 |
| sbalukoff | TrevorV: Having a look now. | 17:26 |
| openstackgerrit | German Eichberger proposed openstack/neutron-lbaas: Adds Cascade option for load balancer drivers https://review.openstack.org/268237 | 17:28 |
| *** Aish has quit IRC | 17:28 | |
| xgerman | TrevorV you forgot a try..catch :-( | 17:32 |
| sbalukoff | xgerman: +1 | 17:34 |
| sbalukoff | If we're going to wrap one, we should wrap them all. :) | 17:34 |
| *** fawadkhaliq has joined #openstack-lbaas | 17:36 | |
| *** Aish has joined #openstack-lbaas | 17:40 | |
| xgerman | yep | 17:41 |
| *** bana_k has joined #openstack-lbaas | 17:43 | |
| *** manishg has quit IRC | 17:44 | |
| *** ihrachys has quit IRC | 17:45 | |
| *** ajmiller has quit IRC | 17:50 | |
| sbalukoff | Woo-hoo! Thank you johnsom for the +A on the neutron-lbaas L7 patch! | 17:51 |
| sbalukoff | xgerman: Checking out your latest patchset now. | 17:52 |
| johnsom | The issue I had with it was fixed, so looked good to go | 17:52 |
| *** ajmiller has joined #openstack-lbaas | 17:52 | |
| xgerman | sbalukoff that only removed WIP | 17:56 |
| sbalukoff | johnsom: Yeah, evgenyf and I went through a bunch of back-and-forth revision and feedback cycles over the last few days ironing out all the bugs I was able to find. | 18:00 |
| sbalukoff | xgerman: Aah, good to know. | 18:00 |
| *** madhu_ak|away has joined #openstack-lbaas | 18:04 | |
| *** madhu_ak|away is now known as madhu_ak | 18:06 | |
| *** kevo has joined #openstack-lbaas | 18:06 | |
| *** H3y has quit IRC | 18:06 | |
| openstackgerrit | Merged openstack/neutron-lbaas: L7 capability extension implementation for lbaas v2 https://review.openstack.org/148232 | 18:14 |
| * sbalukoff pops the cork out of the champagne bottle. | 18:15 | |
| *** yamamoto has joined #openstack-lbaas | 18:16 | |
| madhu_ak | http://i.telegraph.co.uk/multimedia/archive/02778/Fig2-Jacques-Honva_2778403b.jpg | 18:17 |
| *** kobis has joined #openstack-lbaas | 18:18 | |
| *** yamamoto has quit IRC | 18:21 | |
| * johnsom worries that we drove sbalukoff to drink.... | 18:29 | |
| sbalukoff | Haha! Oh, I have contemplated it maaaany times this last month. XD | 18:29 |
| *** Purandar has quit IRC | 18:30 | |
| *** doug-fish has quit IRC | 18:32 | |
| *** madhu_ak has quit IRC | 18:34 | |
| *** Purandar has joined #openstack-lbaas | 18:35 | |
| *** madhu_ak has joined #openstack-lbaas | 18:35 | |
| *** evgenyf has quit IRC | 18:42 | |
| *** doug-fish has joined #openstack-lbaas | 18:46 | |
| *** nmagnezi has joined #openstack-lbaas | 18:46 | |
| *** doug-fish has quit IRC | 18:46 | |
| dougwig | just landed. :) is the l7 etherpad up to date? | 18:46 |
| dougwig | went to look at the extension, it's in. sweet. | 18:46 |
| *** doug-fish has joined #openstack-lbaas | 18:47 | |
| *** madhu_ak_ has joined #openstack-lbaas | 18:49 | |
| TrevorV | xgerman I'm uploading that one here in a second... | 18:50 |
| TrevorV | My bad | 18:50 |
| xgerman | dougwig, now if you can have a look at the cascading delete stuff | 18:51 |
| dougwig | was going to look at l7 client side first. | 18:51 |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Get Me A Load Balancer Controller https://review.openstack.org/257013 | 18:53 |
| fnaval | review requested on this please: https://review.openstack.org/#/c/172199 | 18:53 |
| TrevorV | xgerman updated | 18:53 |
| *** madhu_ak has quit IRC | 18:54 | |
| *** neelashah has quit IRC | 18:55 | |
| openstackgerrit | Andreas Jaeger proposed openstack/neutron-lbaas: Remove unused pngmath Sphinx extension https://review.openstack.org/286210 | 18:56 |
| sbalukoff | dougwig: Thanks for the +2 on the shared pools patch! | 18:57 |
| sbalukoff | Ok, so talking with armax, it appears we need OpenStack doc updates to consider L7 "feature complete". Apparently we have a few more days to get that done. | 18:58 |
| sbalukoff | So, I'mma finish a couple more reviews here and then dive into that. | 18:58 |
| *** fnaval_ has joined #openstack-lbaas | 18:58 | |
| *** fnaval has quit IRC | 19:01 | |
| *** neelashah has joined #openstack-lbaas | 19:02 | |
| dougwig | sbalukoff: yep. ping Sam-I-Am about what they need. might be they just need the raw content, or he might want you to take a stab at the real docs. | 19:03 |
| sbalukoff | Ok. | 19:03 |
| sbalukoff | sam-i-am? | 19:03 |
| sbalukoff | Ok. | 19:03 |
| *** fnaval_ has quit IRC | 19:03 | |
| *** doug-fis_ has joined #openstack-lbaas | 19:03 | |
| dougwig | sbalukoff: he's over in the neutron channel. docs guy. | 19:04 |
| sbalukoff | Oh, sweet, he's an IBMer. I can contact him in ways he can't ignore! | 19:04 |
| *** fnaval has joined #openstack-lbaas | 19:04 | |
| * sbalukoff cackles maniacly. | 19:04 | |
| dougwig | it's ok, Matt's good at biting back. :) | 19:04 |
| sbalukoff | IBM had no idea what it was doing by acquiring my employment along with Blue Box... | 19:05 |
| *** doug-fi__ has joined #openstack-lbaas | 19:06 | |
| *** doug-fi__ has quit IRC | 19:06 | |
| *** doug-fi__ has joined #openstack-lbaas | 19:07 | |
| *** doug-fish has quit IRC | 19:07 | |
| *** doug-fis_ has quit IRC | 19:08 | |
| *** neelashah has quit IRC | 19:09 | |
| *** neelashah has joined #openstack-lbaas | 19:10 | |
| *** kobis has quit IRC | 19:13 | |
| nmagnezi | dougwig, hi :) so followed the instructions we discussed (gate hook for haproxy). despite everything i do i get: WARNING neutron_lbaas.drivers.haproxy.namespace_driver [-] Stats socket not found for loadbalancer | 19:15 |
| *** doug-fi__ is now known as doug-fish | 19:16 | |
| *** ducttape_ has quit IRC | 19:16 | |
| sbalukoff | I am being told by sam-i-am that neutron-lbaas needs release notes and that we should move all our wiki documentation into the official manual, apparently in the openstack-manuals repo. | 19:18 |
| sbalukoff | Have we ever done release notes in neutron-lbaas before? | 19:18 |
| *** ihrachys has joined #openstack-lbaas | 19:20 | |
| sbalukoff | Bah. Whatever. I'll write a neutron-lbaas patch for the release notes later today. | 19:22 |
| sbalukoff | We have a few days to get the manual updates in. | 19:22 |
| johnsom | Release notes is on my list to go learn. We have not been using them to my knowledge | 19:22 |
| sbalukoff | johnsom: Just had to do them for the CLI updates... let me find the (haha!) wiki doc describing how to use them. | 19:23 |
| johnsom | I think we are missing gate jobs for the release notes stuff too. Thanks sbalukoff | 19:23 |
| *** ducttape_ has joined #openstack-lbaas | 19:23 | |
| sbalukoff | http://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes | 19:24 |
| sbalukoff | My bad... | 19:24 |
| sbalukoff | I guess that is in the official docs. | 19:24 |
| sbalukoff | In any case... I see what I can do to make that work in neutron-lbaas today. | 19:25 |
| sbalukoff | Er.. I'll see... | 19:25 |
| johnsom | While you are at it, setup Octavia too | 19:25 |
| sbalukoff | Haha! | 19:27 |
| sbalukoff | If I can. | 19:27 |
| openstackgerrit | Merged openstack/neutron-lbaas: fix mismatch between v1 keyword and v2 driver in gate_hook https://review.openstack.org/285357 | 19:31 |
| johnsom | sbalukoff there is also this: https://etherpad.openstack.org/p/reno-rollout | 19:33 |
| sbalukoff | How old is that etherpad? | 19:34 |
| sbalukoff | Because the doc I linked describes using reno... | 19:34 |
| johnsom | Old, November-ish | 19:34 |
| sbalukoff | OK. | 19:34 |
| johnsom | Yeah, someone pointed me to the etherpad for background. Haven't had time to look at it yet | 19:34 |
| sbalukoff | Yeah, thanks for the link! | 19:35 |
| sbalukoff | I know people hate writing docs... but if you want people to actually use the code you spent months perfecting... they ain't unless it's well documented how to use it. :/ | 19:35 |
| *** bana_k has quit IRC | 19:42 | |
| *** bana_k has joined #openstack-lbaas | 19:43 | |
| sbalukoff | I'm grilling sam-i-am on the all important graphic format question. | 19:43 |
| *** ihrachys has quit IRC | 19:44 | |
| sbalukoff | The answer I'm getting is pretty much "everything sucks, so just commit binary .pngs, and if you used a proprietary source file to generate it, commit that too." | 19:44 |
| sbalukoff | Which is... sad. | 19:44 |
| madhu_ak_ | rm_work, ping | 19:44 |
| *** evgenyf has joined #openstack-lbaas | 19:44 | |
| sbalukoff | Apparently most people use OmniGraffle or draw.io. | 19:44 |
| *** madhu_ak_ is now known as madhu_ak | 19:44 | |
| sbalukoff | Also apparently .svg's have the same inconsistent rendering problem that GraphViz files do. :P | 19:45 |
| sbalukoff | Well... I guess that at least makes things easier. :P | 19:45 |
| dougwig | sbalukoff: we used to relnote in the wiki, like everyone else. mestery added reno support, and i've seen a few folks add reno notes with their features. it's likely not complete. | 19:56 |
| mestery | ++ to reno | 19:56 |
| *** armax has quit IRC | 19:59 | |
| *** Guest71383 is now known as redrobot | 20:01 | |
| *** neelashah has quit IRC | 20:02 | |
| *** neelashah has joined #openstack-lbaas | 20:07 | |
| *** hockeynut_afk is now known as hockeynut | 20:13 | |
| *** fawadkhaliq has quit IRC | 20:22 | |
| *** Purandar has quit IRC | 20:23 | |
| *** doug-fish has quit IRC | 20:24 | |
| *** nmagnezi has quit IRC | 20:26 | |
| *** doug-fish has joined #openstack-lbaas | 20:30 | |
| sbalukoff | dougwig and mestery: Could I get you to take another look at this? https://review.openstack.org/218563 (Rebase after merge conflict + update to release notes as requested by Akihiro) | 20:32 |
| *** doug-fis_ has joined #openstack-lbaas | 20:32 | |
| xgerman | doug-fish yt? | 20:33 |
| *** mixos has joined #openstack-lbaas | 20:34 | |
| *** doug-fish has quit IRC | 20:34 | |
| *** doug-fis_ has quit IRC | 20:37 | |
| *** neelashah1 has joined #openstack-lbaas | 20:40 | |
| *** madhu_ak has quit IRC | 20:41 | |
| *** madhu_ak has joined #openstack-lbaas | 20:42 | |
| *** neelashah has quit IRC | 20:43 | |
| *** fnaval has quit IRC | 20:43 | |
| TrevorV | xgerman alright, the last for-loop listener update I could find is updated... | 20:44 |
| TrevorV | lulz | 20:44 |
| *** fnaval has joined #openstack-lbaas | 20:44 | |
| xgerman | sorry, our code is a mess (hence didn’t give a -1 in case we need to rush it through) | 20:45 |
| *** bana_k has quit IRC | 20:46 | |
| TrevorV | xgerman you mean on my review just now? | 20:46 |
| xgerman | review | 20:47 |
| *** bana_k has joined #openstack-lbaas | 20:47 | |
| madhu_ak | rm_work, you there? | 20:48 |
| *** ducttape_ has quit IRC | 20:50 | |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Get Me A Load Balancer Controller https://review.openstack.org/257013 | 20:50 |
| *** neelashah has joined #openstack-lbaas | 20:52 | |
| *** neelashah1 has quit IRC | 20:52 | |
| rm_work | madhu_ak: yes | 20:54 |
| rm_work | but barely, whats up | 20:55 |
| madhu_ak | so what was the status of this thread? https://www.mail-archive.com/openstack-dev@lists.openstack.org/msg73947.html ? I see you responded to that thread, bcoz I am reproducing the error | 20:58 |
| madhu_ak | rm_work ^^ | 20:58 |
| *** chlong_ has joined #openstack-lbaas | 21:00 | |
| *** neelashah1 has joined #openstack-lbaas | 21:01 | |
| *** manishg has joined #openstack-lbaas | 21:02 | |
| *** ducttape_ has joined #openstack-lbaas | 21:02 | |
| *** neelashah has quit IRC | 21:03 | |
| *** Purandar has joined #openstack-lbaas | 21:03 | |
| mestery | sbalukoff: Done! | 21:04 |
| sbalukoff | mestery: Sweet! One more for you: https://review.openstack.org/#/c/217276/ | 21:05 |
| sbalukoff | And thanks! | 21:05 |
| sbalukoff | (I hope that Akihiro is still online...) | 21:06 |
| madhu_ak | rm_work, http://paste.openstack.org/show/xVl9iuJtGW03fCGetDm3/ | 21:06 |
| TrevorV | xgerman sbalukoff blogan johnsom I have the review up to date with try/catches. Let me know if I missed anything that wasn't "bug-report"-able for the near future. | 21:07 |
| xgerman | I thought you have now two +2s on it | 21:07 |
| *** minwang2 has joined #openstack-lbaas | 21:10 | |
| *** crc32 has joined #openstack-lbaas | 21:10 | |
| *** neelashah has joined #openstack-lbaas | 21:10 | |
| *** jpomeroy has joined #openstack-lbaas | 21:10 | |
| *** Aish has quit IRC | 21:11 | |
| jpomeroy | ajmiller, for LBaaS v2 the listener and pool protocols need to match? | 21:11 |
| TrevorV | xgerman I saw that, but that doesn't mean +A, which means we have to make sure gate gets them o_0 | 21:11 |
| TrevorV | johnsom are you swamped right now? | 21:11 |
| *** Aish has joined #openstack-lbaas | 21:12 | |
| sbalukoff | TrevorV: Will have another look right now. | 21:12 |
| TrevorV | sbalukoff thanks | 21:12 |
| johnsom | TrevorV no, just working through reviews | 21:12 |
| TrevorV | johnsom I was just trying to make sure I had all the bugs listed that we identified. | 21:13 |
| TrevorV | So we had 2 missing unit tests | 21:13 |
| *** neelashah1 has quit IRC | 21:13 | |
| TrevorV | Then we had "shared pools support in single-create" | 21:14 |
| TrevorV | Which I want to discuss a little before that gets figured in | 21:14 |
| TrevorV | I also need to get the documentation updated | 21:14 |
| TrevorV | Was that everything? | 21:15 |
| johnsom | I think that is what I know of. | 21:15 |
| johnsom | Maybe an RFE for the repo update to do the listener updates in one DB call. | 21:15 |
| TrevorV | johnsom I actually want to talk about the pros/cons of that behavior, if you guys don't mind entertaining that point as well. | 21:16 |
| johnsom | Sure | 21:16 |
| TrevorV | Alright, so let me figure out how to report a bug, ha ha, and then we can get to talkins | 21:17 |
| johnsom | https://bugs.launchpad.net/octavia/+filebug | 21:20 |
| TrevorV | Yeah, I was just doing that, just was taking me a second to make sure of the steps. sorry, new to this | 21:20 |
| johnsom | NP | 21:20 |
| johnsom | rm_work https://review.openstack.org/#/c/284690/ | 21:21 |
| TrevorV | johnsom https://bugs.launchpad.net/octavia/+bug/1551427 | 21:23 |
| openstack | Launchpad bug 1551427 in octavia "Missing branch-coverage unit tests" [Undecided,New] - Assigned to Trevor Vardeman (trevor-vardeman) | 21:23 |
| TrevorV | does that look right? | 21:23 |
| johnsom | Sure | 21:23 |
| TrevorV | Alright, so the discussion with the database objects, and anyone should interject if they like ( xgerman sbalukoff you guys specifically had comments about it in the review) | 21:26 |
| johnsom | rm_work this one too: https://review.openstack.org/#/c/282113 (I am assuming you would like a chance to look at these) | 21:26 |
| TrevorV | One side of the argument, johnsom, is when you combine all the updates into one call, and then that call fails, would it solve anything that doing a singular update at a time won't? | 21:27 |
| johnsom | Other than save database round-trips, no. | 21:27 |
| TrevorV | I'm also concerned with diagnostics. | 21:27 |
| xgerman | and not switches things to active | 21:27 |
| jpomeroy | anyone know? LBaaS v2 the listener and pool protocols need to match? | 21:28 |
| xgerman | no | 21:28 |
| jpomeroy | getting errors if we don't set them to the same thing | 21:28 |
| xgerman | jpomeroy no | 21:28 |
| TrevorV | xgerman but a roll-back would also not update the status | 21:28 |
| TrevorV | I mean a DB roll-back | 21:28 |
| *** manishg has quit IRC | 21:28 | |
| xgerman | jpomeroy Terminated TLS/HTTP | 21:28 |
| sbalukoff | jpomeroy: Not exactly. HTTP pool can work with HTTP or TERMINATED_HTTP listener. | 21:28 |
| xgerman | should ork | 21:28 |
| sbalukoff | jpomeroy: But HTTP listener doesn't work with TCP pool. | 21:29 |
| xgerman | TrevorV right | 21:29 |
| *** manishg has joined #openstack-lbaas | 21:29 | |
| xgerman | but things would not switch to the next state | 21:29 |
| TrevorV | I'm confused, what stance are you taking? It should all be one call or it shouldn't? | 21:30 |
| sbalukoff | Honestly, I'm pretty sure most of our revert code needs a good overhaul anyway: I'm pretty sure we are missing opportunities for more graceful failure modes, and probably not doing the right thing in some cases... | 21:30 |
| xgerman | it should be one call. johnsom’s argument regarding performance is the main one | 21:30 |
| TrevorV | Sure, but doesn't that potentially muddy up diagnostics? | 21:30 |
| sbalukoff | Especially once we get job-board, maybe it would be better to queue up revert DB calls if they fail to be retried again at some point? | 21:30 |
| johnsom | sbalukoff this isn't for revert, but for the execute path | 21:31 |
| TrevorV | For example, how would we distinguish the failed entry into the DB given the arguments? | 21:31 |
| sbalukoff | johnsom: Aah. | 21:31 |
| TrevorV | If that one call fails, we won't know a "culprit" so to speak | 21:31 |
| TrevorV | If we do each update individually, it can make things more clear, can it not? | 21:31 |
| xgerman | well, we implicitly decided that if I create/update two listeners one succeeds and one fails - both need to be rolled back | 21:31 |
| *** neelashah has quit IRC | 21:32 | |
| TrevorV | Sure, "rolled back" being relative here where all we do is update a status. | 21:32 |
| xgerman | I would like that to be explicit: no partial success | 21:32 |
| johnsom | At least not the code I am thinking of. In the execute() we are looping and sending DB updates for each listener on an LB, where I argue we can save DB round trips with a smarter repo call that updates them all to Active | 21:32 |
| xgerman | yep, if we need to do single calls I like each update be it’s own task | 21:32 |
| TrevorV | johnsom sure, I'm getting at diagnostics if that should fail | 21:32 |
| xgerman | well, for diagnostics it would be best to have single tasks and not loop inside a task | 21:33 |
| sbalukoff | xgerman: +1 | 21:33 |
| TrevorV | If you make a potentially large query to update a list of objects, can we easily decipher the issue if one specific thing fails? | 21:33 |
| *** manishg has quit IRC | 21:33 | |
| sbalukoff | But if those tasks are executed in some sequence, that doesn't save us DB round-trip. | 21:34 |
| sbalukoff | So, they'd need to be unordered, essentially. | 21:34 |
| xgerman | yep | 21:34 |
| johnsom | TrevorV I don't think it makes much difference. It's a DB call failure either way. The content may be different, but basically the same result. | 21:34 |
| TrevorV | sbalukoff unordered or otherwise its still the same number of executions to the DB based on the number of objects in the list. | 21:34 |
| sbalukoff | TrevorV: | 21:34 |
| sbalukoff | I agree | 21:34 |
| johnsom | Yeah, unordered doesn't buy much here. | 21:35 |
| sbalukoff | And a failure would result in the same kind of revert, right? | 21:35 |
| sbalukoff | (A failure in any one of them, task or not.) | 21:35 |
| TrevorV | johnsom I'm only trying to play devil's advocate here. I'm okay with the iterations, and I'm okay with a large update. I just want to make sure we vet each option to find the least of all issues. | 21:35 |
| TrevorV | I'm mostly concerned about error diagnostics providing false positives given each situation | 21:35 |
| johnsom | Yeah, no problem | 21:35 |
| *** Purandar has quit IRC | 21:36 | |
| TrevorV | On the hand where we do individual updates, and one of them fails, so the task reverts, AND one of the revert try/catches fail, then we have x listeners marked ERROR, and y listeners marked "ACTIVE", so we start figuring out why they're still active. | 21:36 |
| TrevorV | If we do a batch-update to the DB, we have ALL listeners "ACTIVE" and have to look at every single one individually most likely to diagnose the issue | 21:36 |
| xgerman | I think if the database repeatedly balks we have bigger problems | 21:37 |
| TrevorV | xgerman i meant where we have half success and half failure | 21:37 |
| xgerman | I can see it being shaky while the DB fails over/etc. | 21:37 |
| TrevorV | LIke lets say we have 4 listeners | 21:37 |
| *** neelashah has joined #openstack-lbaas | 21:37 | |
| TrevorV | if 2 go active and 2 go ERROR, then we have a place to start | 21:37 |
| xgerman | Trevor V understood | 21:37 |
| TrevorV | Oh okay, sorry | 21:37 |
| xgerman | but if we have like more than 20 listeners in that state we have nigger problems | 21:38 |
| TrevorV | typo... | 21:38 |
| johnsom | Actually with the single update, you still only have one thing to debug, the DB update call | 21:38 |
| neelashah | xgerman: are there any combination of different listerner and pool protocols allowed? or do they always have to be the same? | 21:38 |
| blogan | yikes xgerman! | 21:38 |
| TrevorV | Alright, I see your point johnsom . So I guess its fine doing the batch update. | 21:39 |
| TrevorV | How do you put in an enhancement request? | 21:39 |
| sbalukoff | neelashah: HTTP pool can work with both HTTP and TERMINATED_HTTPS listener. | 21:40 |
| johnsom | TrevorV You open a bug and put the tag RFE on it. | 21:40 |
| neelashah | neelashah: ah, ok got it | 21:41 |
| neelashah | sbalukoff: got it, thanks | 21:41 |
| *** Purandar has joined #openstack-lbaas | 21:42 | |
| *** manishg has joined #openstack-lbaas | 21:46 | |
| TrevorV | johnsom assign it to myself probably? or should I leave it for *anyone* to update? | 21:46 |
| johnsom | I would leave it open unless you are going to start working on it. It's an RFE and not a bug against your code necessarily | 21:47 |
| TrevorV | Right, gotcha. I'll leave it open for now. | 21:47 |
| johnsom | Unlike: https://bugs.launchpad.net/octavia/+bug/1551436 | 21:47 |
| openstack | Launchpad bug 1551436 in octavia "Cascading LB delete is missing documentation updates" [Critical,New] - Assigned to German Eichberger (german-eichberger) | 21:47 |
| sbalukoff | blogan or rm_work or dougwig: Could one of you have a look at this and decide whether you're OK with +A on it? https://review.openstack.org/#/c/282113 | 21:47 |
| TrevorV | sbalukoff if that gets a +A, it might affect single-create... ha ha ha | 21:48 |
| sbalukoff | Oh, no! | 21:49 |
| TrevorV | Then again, if single-create gets a +A, IT might affect THIS | 21:49 |
| TrevorV | That seems... really bad | 21:49 |
| sbalukoff | Well, we're trying to get both single-create and single-destroy in today, right? | 21:49 |
| sbalukoff | Someone's going to have to rebase. :/ | 21:49 |
| TrevorV | Yeah. | 21:49 |
| blogan | sbalukoff, xgerman: what's calling that controller worker method? | 21:49 |
| sbalukoff | blogan: Dependent patch. | 21:49 |
| TrevorV | I guess whoever gets the short straw gets the short straw, but with gate jobs taking 3-7 hours, one of them won't get in. | 21:49 |
| blogan | okay | 21:50 |
| *** fawadkhaliq has joined #openstack-lbaas | 21:50 | |
| ajmiller | jpomeroy -- sorry, didn't see your ping. It looks like you got your question answered? | 21:50 |
| sbalukoff | Well... I'm in the PST timezone... it'll still be Feb. 29 here for a while. :) | 21:50 |
| jpomeroy | ajmiller, yes thank you | 21:50 |
| sbalukoff | Also, any of the other Octavia cores have a problem with merging whichever patch gets the short straw, if the only change is that it needs a rebase? | 21:51 |
| sbalukoff | TrevorV and xgerman: Other option is for one of you to rebase behind the other's patch. | 21:52 |
| sbalukoff | From my perspective, both of these new features are essentially ready. | 21:52 |
| TrevorV | I agree. | 21:52 |
| TrevorV | If the cascade delete changes are already tested right now, then we should +A them asap so I can get that code now | 21:53 |
| TrevorV | If we can do that. | 21:53 |
| *** armax has joined #openstack-lbaas | 21:53 | |
| TrevorV | Then we might be able to +A my stuff this evening. | 21:53 |
| johnsom | I'm reviewing the second delete now. Though per-protocol I should give one of the other cores the +A | 21:54 |
| sbalukoff | Ok, let me have another look at xgerman's second patch that is part of cascade-delete... | 21:54 |
| TrevorV | Cool. | 21:55 |
| sbalukoff | Ok, I already +2'ed it. | 21:57 |
| sbalukoff | blogan or rm_work or dougwig: Need one of y'alls stamp of approval on this: https://review.openstack.org/#/c/282587/ | 21:57 |
| sbalukoff | Yeah, both these patch sets are just waiting on a last +2/+A to merge. | 21:59 |
| sbalukoff | And yes, they conflict... so TrevorV and xgerman: Y'all should work it out amongst yourselves which of you is going to rebase. | 22:00 |
| TrevorV | The only question is who is waiting on zuul | 22:01 |
| TrevorV | xgerman are you waiting on zuul for the deletes? | 22:01 |
| sbalukoff | Note that xgerman's total line count is around 250, whereas TrevorV's is around 1200... | 22:02 |
| sbalukoff | Ok, blogan just +A'ed xgerman's patch. | 22:02 |
| johnsom | Well, I'm equal opportunity, xgerman missed a unit test in https://review.openstack.org/#/c/282587 | 22:02 |
| sbalukoff | So that one will get in first. | 22:02 |
| sbalukoff | TrevorV: Get to rebasing, man! :D | 22:03 |
| TrevorV | johnsom are you not gonna just bug that and let it fly? | 22:03 |
| TrevorV | Ugh... Alright :P | 22:03 |
| blogan | full disclosure, i didn't test it out, i just looked over the code to make sure it made sense, but bugs can be fixed later | 22:03 |
| johnsom | TrevorV I would, but I am going to flag them as I see them and give the developer the option | 22:03 |
| TrevorV | johnsom alright, well it looks like we're getting the +A on cascade delete, so bug-reporting is a necessity at this point. Is xgerman in a meeting or something right now? | 22:04 |
| johnsom | blogan beat me on my -1 | 22:04 |
| sbalukoff | blogan: FWIW, I did test it out yesterday. Didn't see the code change significantly in the mean time. | 22:04 |
| johnsom | He ran to lunch | 22:04 |
| *** Purandar has quit IRC | 22:04 | |
| sbalukoff | TrevorV: Ping me as soon as you've got a rebased patch set up there, and I'll run it through a quick test to make sure there aren't any unexpected complications from the rebase. | 22:05 |
| TrevorV | sbalukoff alright, will do. | 22:05 |
| TrevorV | I may be travelling home here in a second (to beat traffic) but it'll be up in the next couple hours ideally | 22:06 |
| sbalukoff | In the mean time... lunch sounds like an excellent idea. | 22:06 |
| *** doug-fish has joined #openstack-lbaas | 22:06 | |
| sbalukoff | TrevorV: I'll be sticking around to see this one get through, so long as we have at least one more core willing to +2. | 22:06 |
| TrevorV | sbalukoff awesome, I'll be online to see that double +2 as well. That's the best thing about working on a laptop while being able to go home to my tower :D | 22:07 |
| *** Purandar has joined #openstack-lbaas | 22:08 | |
| *** TrevorV has quit IRC | 22:09 | |
| *** neelashah1 has joined #openstack-lbaas | 22:09 | |
| xgerman | sorry, was out for a bit. Thanks for merging my stuff... | 22:10 |
| *** neelashah has quit IRC | 22:11 | |
| johnsom | xgerman you picked up some bugs | 22:12 |
| xgerman | figured | 22:13 |
| xgerman | how did I make so many mistakes in such a small code base? | 22:13 |
| *** neelashah has joined #openstack-lbaas | 22:13 | |
| johnsom | blogan sbalukoff When you get a chance: https://review.openstack.org/#/c/284690/ | 22:15 |
| *** neelashah1 has quit IRC | 22:16 | |
| sbalukoff | Will check it out, eh... | 22:17 |
| *** armax has quit IRC | 22:19 | |
| *** neelashah1 has joined #openstack-lbaas | 22:24 | |
| *** neelashah has quit IRC | 22:24 | |
| *** armax has joined #openstack-lbaas | 22:26 | |
| *** crc32 has quit IRC | 22:27 | |
| blogan | johnsom: that failed all scenario tests | 22:30 |
| sbalukoff | johnsom, xgerman: Any merit to the nit I just added here, do you think? https://review.openstack.org/#/c/284690/ | 22:30 |
| rm_work | sbalukoff: ok so we're going to try to merge single-create later tonight? | 22:30 |
| rm_work | sbalukoff: i'll be around if i need to be, around 11pm/midnight | 22:30 |
| sbalukoff | rm_work: I hope so, yes. | 22:30 |
| rm_work | or rather, i WILL be around 11pm/midnight :P | 22:30 |
| rm_work | regardless of whether i need to be... <_< | 22:30 |
| blogan | so for some reason the controller worker could not talk to that instance with the glance tags review | 22:31 |
| blogan | for every test | 22:31 |
| blogan | that ahs be concerned | 22:31 |
| blogan | has me | 22:31 |
| *** mixos has quit IRC | 22:31 | |
| rm_work | hmm | 22:31 |
| sbalukoff | blogan: +1 | 22:32 |
| johnsom | blogan I see some that connected | 22:32 |
| johnsom | http://logs.openstack.org/90/284690/9/check/gate-neutron-lbaasv2-dsvm-scenario/7e7e62e/logs/screen-o-cw.txt.gz#_2016-02-29_20_56_08_980 | 22:32 |
| blogan | johnsom: ah good point, but still all scenario tests failed | 22:33 |
| johnsom | Hmm, but yeah, the main log looks bad | 22:33 |
| johnsom | I think computewait would have bombed if the instance didn't boot because of a messed up image ID | 22:35 |
| *** neelashah1 has quit IRC | 22:35 | |
| blogan | johnsom: yeah i misread the logs, they all went active it looks like, except that last one | 22:35 |
| *** doug-fis_ has joined #openstack-lbaas | 22:35 | |
| johnsom | It shouldn't get to the attempting to connect | 22:35 |
| blogan | which it just looks liek the logs stopped | 22:35 |
| johnsom | Yeah | 22:35 |
| *** neelashah has joined #openstack-lbaas | 22:36 | |
| *** doug-fish has quit IRC | 22:37 | |
| *** manishg_ has joined #openstack-lbaas | 22:39 | |
| *** manishg has quit IRC | 22:39 | |
| *** neelashah has quit IRC | 22:43 | |
| openstackgerrit | Merged openstack/octavia: Improved LoadBalancer Delete https://review.openstack.org/282113 | 22:43 |
| *** rtheis has quit IRC | 22:43 | |
| xgerman | yeah! | 22:44 |
| sbalukoff | Sweet! | 22:45 |
| *** doug-fis_ has quit IRC | 22:48 | |
| openstackgerrit | Merged openstack/octavia: Cascading LB delete https://review.openstack.org/282587 | 22:48 |
| *** doug-fish has joined #openstack-lbaas | 22:48 | |
| *** doug-fish has quit IRC | 22:53 | |
| sbalukoff | Woot! | 22:53 |
| *** doug-fish has joined #openstack-lbaas | 22:53 | |
| xgerman | Yeah!! | 22:58 |
| xgerman | Now LBaaS V2… I think ajmiller was looking at that | 22:58 |
| ajmiller | xgerman Yes, I read through them this morning. | 23:00 |
| ajmiller | been mostly focussed on our internal stuff all that though. | 23:00 |
| xgerman | ok, sounds good | 23:01 |
| xgerman | thanks | 23:01 |
| ajmiller | blogan, how do you feel about xgerman's reply to your -1 on https://review.openstack.org/#/c/284340/ | 23:03 |
| *** jpomeroy has quit IRC | 23:04 | |
| *** TrevorV has joined #openstack-lbaas | 23:04 | |
| xgerman | thanks for bringing that up | 23:05 |
| TrevorV | xgerman did cascade delete merge? | 23:06 |
| xgerman | yep | 23:06 |
| TrevorV | Awesome | 23:06 |
| TrevorV | Gonna rebase my changes on master and push change | 23:07 |
| sbalukoff | Sweet. | 23:07 |
| *** yamamoto_ has joined #openstack-lbaas | 23:11 | |
| *** yamamoto_ has quit IRC | 23:16 | |
| blogan | ajmiller: i feel xgerman should never disagree with me | 23:17 |
| TrevorV | sbalukoff xgerman johnsom blogan rm_work ha ha all the tags... Sooo it was a super simple rebase, that's the good news. Its about to go up in a review. | 23:17 |
| johnsom | I disagree with that | 23:17 |
| blogan | i also feel johnsom should never disagree with me either | 23:17 |
| sbalukoff | Cool! | 23:17 |
| sbalukoff | Haha | 23:18 |
| openstackgerrit | Henry Gessau proposed openstack/neutron-lbaas: Track alembic heads https://review.openstack.org/285465 | 23:18 |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Get Me A Load Balancer Controller https://review.openstack.org/257013 | 23:19 |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Get me a Load Balancer API https://review.openstack.org/256974 | 23:19 |
| TrevorV | johnsom you disagree with it being a simple rebase? | 23:19 |
| xgerman | he agrees to disagree | 23:20 |
| sbalukoff | TrevorV: Restacking to try out your new, rebased patches now! | 23:23 |
| * TrevorV is scared | 23:23 | |
| sbalukoff | Well, now that xgerman's cascade delete patch is merged... at this point it'll make for easy clean-up. ;) | 23:25 |
| blogan | xgerman: could you make an api tempest test for the cascade delete? | 23:26 |
| blogan | xgerman: in a follow up patch | 23:26 |
| xgerman | Octavia or LBaaS V2 | 23:26 |
| xgerman | ? | 23:26 |
| blogan | lbaas v2 | 23:27 |
| xgerman | sure I can try - never made a tempest test… but it’s always a first | 23:27 |
| xgerman | also cascading delete is the same as delete so should be copy&paste | 23:28 |
| blogan | xgerman: well your assertions would be different | 23:28 |
| blogan | also, just so i'm clear, this will do a cascading delete if the dirver supports it, always? | 23:29 |
| xgerman | yes, that’s what we agreed at the midcycle | 23:29 |
| blogan | like a DELETE /loadbalancers/{lb_id} will cascade delete always? | 23:29 |
| xgerman | yep, if the driver supports it | 23:29 |
| blogan | yeah i kind of remember that, but still makes me feel uneasy, but meh, it should be how the api was all along | 23:29 |
| *** manishg_ has quit IRC | 23:30 | |
| blogan | meaning i wish we just had /loadbalancers endpoint, thats it and just ahd get me a lb and cascade delete | 23:30 |
| *** manishg has joined #openstack-lbaas | 23:30 | |
| blogan | but with shared pools, we'ed need a /loadbalancers/{lb_id}/pools endpoint or a /pools endpoint | 23:30 |
| xgerman | labs v3? | 23:30 |
| xgerman | lbaas | 23:31 |
| blogan | octavia? | 23:31 |
| sbalukoff | er... | 23:32 |
| blogan | xgerman: i don't think we have api tests that try to delete a load balancer with children, if we did, those should ahve failed | 23:32 |
| sbalukoff | Octavia does have a loadbalancers/{lb_id}/pools endpoint. | 23:32 |
| xgerman | blogan, ok. I can add that as a test | 23:33 |
| * xgerman is picking up lots of work today | 23:33 | |
| sbalukoff | Heh! I know the feeling. | 23:33 |
| sbalukoff | Oh... sorry, missed the context on that... | 23:34 |
| openstackgerrit | Evgeny Fedoruk proposed openstack/neutron-lbaas: L7 support for Radware LBaaS v2 driver https://review.openstack.org/202147 | 23:35 |
| blogan | sbalukoff: yea i was talking about neutron-lbaas | 23:36 |
| blogan | xgerman: mind if i rebase that patch? | 23:37 |
| blogan | https://review.openstack.org/#/c/284340 | 23:37 |
| blogan | or if you want to | 23:38 |
| sbalukoff | blogan: How would updates to objects subordinate to a loadbalancer work in that case? | 23:38 |
| xgerman | blogan, go ahead | 23:39 |
| blogan | sbalukoff: probably just update by doing /loadbalancers/{lb_id}/listeners | 23:40 |
| blogan | similar to octavia | 23:40 |
| sbalukoff | Right. | 23:40 |
| sbalukoff | Makes sense. | 23:40 |
| blogan | which is really where we could take octavia's api | 23:41 |
| sbalukoff | Sure. | 23:41 |
| sbalukoff | It's very similar in most other ways already. | 23:41 |
| *** yamamoto_ has joined #openstack-lbaas | 23:42 | |
| openstackgerrit | Brandon Logan proposed openstack/neutron-lbaas: Adds Cascade Delete for LoadBalancers to Octavia Driver https://review.openstack.org/284340 | 23:44 |
| TrevorV | sbalukoff at the progress?! | 23:44 |
| sbalukoff | Still stacking... this machine is pretty slow. | 23:45 |
| sbalukoff | (Sorry!) | 23:45 |
| TrevorV | All good, just curious :D | 23:45 |
| *** manishg has quit IRC | 23:49 | |
| *** fnaval has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
