Saturday, 2016-03-12

johnsomrm_work blogan Could use some reviews on some of the last Octavia patches: https://review.openstack.org/287118 https://review.openstack.org/290963 https://review.openstack.org/290444 https://review.openstack.org/28963800:08
rm_workkk00:13
rm_workah i started reviewing some of these and got pulled off this week00:14
rm_worki think the session persistence one at least is good last i checked, kinda wanted to test it manually, but00:14
johnsomYeah, me to.  I think one of the unit test ones I reviewed like three times00:14
rm_workhonestly just do not have time to run every single change through devstack with manual testing00:14
johnsomWe have time if you want to load it up00:14
rm_workwhen is the cutoff00:14
rm_workwell this is 4 reviews00:15
johnsomI am still working with bharathm on the admin_state_up issue00:15
rm_worki'd have to spin 4 devstacks00:15
rm_workthis is T_T00:15
rm_worki think it's probably fine00:15
rm_workyeah code looks fine, +A00:18
rm_worknext00:18
rm_workah right00:20
rm_workI had looked at this one before too but the validator changes squeebed me out a bit00:20
rm_worki wasn't quite sure I followed the logic, but since i'm not super familiar with L7 I didn't want to ask a bunch of dumb questions <_<00:20
johnsomNo harm in asking the questions00:21
rm_workwoah what, https://review.openstack.org/#/c/290444/6/octavia/common/data_models.py00:21
rm_workI thought the SNI change already happened as part of Single-Create when TrevorV found a related bug a while back00:21
rm_worki am so confused now00:22
rm_workand it's in the "add unit tests" change?!00:22
johnsomI remember it as being moved out too, but I thought it was just this patch.00:22
johnsomYeah, but he did mention it in the commit message00:22
rm_workhmm00:23
rm_workk... well.... k00:23
johnsomPing him if you don't like it00:23
*** jcook_ has quit IRC00:23
rm_workeh, it needs to be changed if it didn't get updated already, so whatever00:23
rm_worki am aware of why that fix is necessary00:23
rm_workjust confusing to see it pop up in this CR00:24
sbalukoffOh--- yes, it turns out that get unique ID thing is in a few places in the code.00:25
rm_workAH ok00:25
sbalukoffAnd was only fixed in on of them.00:25
rm_workso this is another place00:25
sbalukoffone.00:25
rm_workalright00:25
rm_workthought I was going insane00:25
sbalukoffWell, that remains to be seen. XD00:25
rm_workok and yeah, can you look at: https://review.openstack.org/#/c/290963/3/octavia/common/validate.py00:25
rm_workif you look at those validators again and tell me it's for sure right, I will trust you00:26
johnsomsbalukoff is going to go have a nice dry soda tonight....00:26
rm_workjust wondering for instance, why do we update the redirect_pool_id and url but REMOVE the redirect_pool00:26
rm_workisn't redirect_pool loaded in from the id or v.v.?00:27
rm_workdo we just ALWAYS pop it off?00:27
sbalukoffrm_work: To the best of my knowledge that is correct. The extensive changes there are to essentially un-do the work-around I had in place for the work-around for the API request to_dict() method defaulting to populating unspecified values in the request.00:27
rm_workalright00:27
sbalukoff(That bugfix from blogan was merged earlier this week.)00:27
rm_workI'll let it through, we can always fix it again if it breaks something, and no one is using this actively yet probably as we JUST merged it to begin with <_<00:28
sbalukoffredirect_pool_id and redirect_url are both values that get populated in the DB.00:28
rm_worklooking forward to fnaval's work on functional testing00:28
rm_workso we'll have some validation around this stuff00:28
sbalukoffredirect_pool only exists for single-create requests.00:28
rm_workwithout me having to manually spin and test everything by hand00:28
sbalukoffYes, I'm looking forward to fnaval's patch finally landing, too!00:28
fnavalrm_work:  with octavia?  eh - i've swtiched gears back to neutron-lbaas for awhile00:29
rm_workT_T00:29
rm_workI get why I think, but you're killing me T_T00:29
sbalukoffWell... it would help to add an L7 scenario or two to the neutron-lbaas stuff as well.00:29
rm_workthere's some puckering that happens every time I +A00:30
sbalukoffrm_work: Ditto!00:30
fnavalsbalukoff / rm_work :  i've made a comment on that octavia scenario patch that I need help on00:30
fnavali'm a bit blocked on how to proceed00:30
sbalukoffOk.00:30
rm_workerk I have to run to dinner, meeting some people00:30
rm_workbut I think I can +A all of those now00:30
rm_workk00:31
openstackgerritFranklin Naval proposed openstack/neutron-lbaas: Delete tempest fork  https://review.openstack.org/27381700:31
fnavaleyes on that one ^^ once it passes00:32
rm_workjohnsom / sbalukoff I think i got all of the ones you mentioned00:33
rm_worki have to run for a bit but i'll be back on later00:33
sbalukoffrm_work: Thanks muchly!00:33
johnsomThank you.  Check later for the admin_state_up00:33
sbalukoffI also need to run away for a wihle.00:33
openstackgerritMerged openstack/octavia: Add hacking check to ensure not use xrange()  https://review.openstack.org/29150200:33
sbalukoffWill be back on probably after midnight.00:33
rm_workhttps://review.openstack.org/#/c/290265/2 looks ok after a recheck00:35
rm_workbbl00:35
sbalukoffOk. I just +A'ed that one.00:36
johnsomIt's a bit past feature freeze for that00:37
sbalukoffOh, should I remove the +A?00:37
johnsomIt's small change, so let's leave it, but let's not +A any more features00:37
sbalukoffI didn't think it was a big deal given it doesn't affect anyone but RAX, and it's a tiny change.00:37
johnsomIf the amp images don't build anymore, I will sacrifice you to the PTL00:38
sbalukoffSo, RC1 gets cut next week, and then Newton gets opened up, yes?00:38
sbalukoffHeh!00:38
sbalukoffOk.00:38
johnsomIf we get these last bugs fixed, I could cut it this weekend00:38
sbalukoffNice!00:38
sbalukoffWe're close.00:39
johnsomI did block kobi's patch until newton00:39
johnsomfeature I mean00:39
sbalukoffYes, but I didn't think that one was ready.00:39
sbalukoffAnd that would be a substantial change, IMO.00:39
sbalukoffBTW, has anyone had a look at the neutron-lbaas session_persistence update bugfix?  https://review.openstack.org/#/c/287004/00:41
sbalukoffI think having that in place will help lend more clarity to our efforts to fix that intermittent session_persistence scenario test bug.00:41
johnsomI lost track of that one.  I will look at it tonight00:42
johnsomI have one out for that too: https://review.openstack.org/#/c/278874/00:43
johnsomIt might help a little, but not a full fix IMO00:43
sbalukoffI'll have a look.00:44
sbalukoffYep, that looks like it might help and probably wouldn't hurt.00:45
sbalukoffOk, I'm off. In case I don't catch any of y'all online: Have a good weekend, eh!00:49
openstackgerritMerged openstack/octavia: Fix session_persistence deletion bug  https://review.openstack.org/28711800:57
*** ajmiller has quit IRC00:59
openstackgerritMerged openstack/octavia: Add unit tests for L7 data model additions  https://review.openstack.org/29044401:01
openstackgerritMerged openstack/octavia: Fix L7Policy update regression  https://review.openstack.org/29096301:08
openstackgerritMerged openstack/octavia: Add missing unit tests for L7 repo classes  https://review.openstack.org/28963801:10
*** madhu_ak has joined #openstack-lbaas01:10
*** madhu_ak has quit IRC01:14
*** lixinhui_ has joined #openstack-lbaas01:17
lixinhui_I have update the bug https://bugs.launchpad.net/octavia/+bug/1556015 with complete log01:18
openstackLaunchpad bug 1556015 in octavia "blocked by Pending to Create" [Undecided,New]01:18
johnsomThank you!01:18
lixinhui_it would be nice if you could help to take a look.01:18
openstackgerritMerged openstack/octavia: Add VHD support in DIB  https://review.openstack.org/29026501:22
johnsomlixinhui_ Are you still online?01:33
johnsomMaybe lixinhui01:34
*** Qiming has joined #openstack-lbaas01:36
johnsomI have added a comment to the bug01:39
openstackgerritMichael Johnson proposed openstack/octavia: Fix LB and Listener admin_state Update  https://review.openstack.org/29040801:40
*** _amrith_ is now known as amrith01:42
lixinhui_yes01:43
lixinhui_johnsom01:43
johnsomlixinhui_ Hi.  I added a comment to the bug.01:43
johnsomLet me know if you have a question about that01:43
lixinhui_thanks, johnsom. I will add the mentioned logs.01:45
johnsomOk, great.  I will be here another hour, so will have a look01:45
lixinhui_ok01:48
*** kevo has quit IRC01:49
*** kevo has joined #openstack-lbaas01:50
*** Purandar has quit IRC01:54
*** kevo has quit IRC01:57
*** jwarendt has quit IRC01:57
*** kevo has joined #openstack-lbaas02:01
*** madhu_ak has joined #openstack-lbaas02:14
*** madhu_ak has quit IRC02:16
lixinhui_johnsom, I just update the https://bugs.launchpad.net/octavia/+bug/1556015 with console and amphora-agent logs02:22
openstackLaunchpad bug 1556015 in octavia "blocked by Pending to Create" [Undecided,Incomplete]02:22
johnsomOk02:22
lixinhui_home network condition is very poor02:22
johnsomHmmm, I have not seen that before02:25
lixinhui_Thanks all the same. So weird problem02:26
johnsomYeah, we will have to research that one more.  It seems the request is getting to the agent, but it is getting interrupted before it can respond02:27
*** kevo has quit IRC02:28
lixinhui_... I once use the same data center machine to create lbaas successfully with older version in late Feb.02:29
johnsomlixinhui_ Can you also post the localrc and /etc/octavia/octavia.conf from the devstack host?  Please remember to remove any passwords or private data.02:30
lixinhui_okay02:31
johnsomThank you02:31
lixinhui_Thanks for your help here02:31
johnsomMany of us are running pretty current code, so there is something unique here that is triggering this issue.02:32
*** ducttape_ has joined #openstack-lbaas02:34
*** minwang2 has quit IRC02:35
lixinhui_have posted local.conf and octavia.conf for your check02:39
lixinhui_I think so, johnsom02:39
johnsomlixinhui_ Thank you!02:40
lixinhui_:)02:40
johnsomlixinhui_ Can you try setting "amp_active_wait_sec = 10"?02:41
lixinhui_ok, will try02:41
*** amrith is now known as _amrith_02:44
openstackgerritMichael Johnson proposed openstack/octavia: Fix admin-state-up  https://review.openstack.org/29040802:51
openstackgerritDoug Wiegley proposed openstack/neutron-lbaas: WIP - DO NOT MERGE - ci test, 1  https://review.openstack.org/26489802:56
lixinhui_johnsom, no lucky with bigger amp_active_wait_sec03:02
*** ajmiller has joined #openstack-lbaas03:07
*** ajmiller_ has joined #openstack-lbaas03:08
*** links has joined #openstack-lbaas03:11
*** ajmiller has quit IRC03:11
*** johnsom_ has joined #openstack-lbaas03:17
*** Qiming has quit IRC03:17
johnsomOk, thank you for trying it03:18
*** ducttape_ has quit IRC03:19
*** johnsom_ has quit IRC03:19
*** johnsom_ has joined #openstack-lbaas03:20
johnsom_Ok, time to finish up the admin state patch03:20
*** Qiming has joined #openstack-lbaas03:21
*** johnsom_ has quit IRC03:23
*** johnsom_ has joined #openstack-lbaas03:24
*** ajmiller_ has quit IRC03:24
*** johnsom_ has quit IRC03:25
*** Purandar has joined #openstack-lbaas03:25
*** johnsom_ has joined #openstack-lbaas03:26
*** Qiming has quit IRC03:27
*** Aish has joined #openstack-lbaas03:28
*** Aish has left #openstack-lbaas03:29
*** Qiming has joined #openstack-lbaas03:30
*** johnsom_ has quit IRC03:34
*** johnsom_ has joined #openstack-lbaas03:34
*** Qiming has quit IRC03:35
*** bank has joined #openstack-lbaas03:50
*** lixinhui_ has quit IRC04:01
*** woodster_ has quit IRC04:17
fnavalhi dougwig - per https://review.openstack.org/#/c/273817/04:27
fnavala lot of v1 tests are failing04:27
fnavalshould those v1 gates be non-voting?04:27
dougwigfnaval: they pass without your change.04:28
fnavalhmmm ok so something happened that caused it to fail04:29
dougwigfnaval: i triggered this after i saw your failure to check: https://review.openstack.org/#/c/264898/04:29
fnavalah, is that the state prior to the change?04:30
dougwigfnaval: yes, that's a freshly rebased master.04:30
fnavalok, so for me to debug I"ll need to restack so that i'm running lbaasv1 - would you happen to have a localrc that would have the correct params04:30
fnavalor which services/plugins I should enable/disable04:31
dougwigyes, one sec.04:31
fnavalcool thanks!04:31
dougwighttps://www.irccloud.com/pastebin/9UFkf2FU/04:33
fnavalthank you sir!04:33
dougwigfnaval: that's my normal v1 file, but you can remove the a10 specific parts.04:33
fnavalk i see it, i'll pick it apart to make it work04:34
fnavalthanks04:34
dougwignp04:34
dougwigfnaval: thanks for picking up that fix.04:34
fnavalnp - it needs to get done before I add any new tests to the suite as I'm about to in the coming days.04:35
ptoohillis there a bug in that?04:35
*** ajmiller has joined #openstack-lbaas04:35
ptoohill'enable_server q-lbaas'04:36
fnavalapparently in the tempest refactor (removing tempest in-tree for neutron-lbaas), a test bug was introduced into the v1 tests.04:36
fnavalin order for me to debug, i'll have to run lbaas v1.04:37
fnavalptoohill: so would lbaasv1 also be running octavia s the backend?04:37
ptoohillno04:38
ptoohillthat runs in namespace04:38
fnavali see it declared here: http://logs.openstack.org/17/273817/14/check/gate-neutron-lbaasv1-dsvm-api/c9b5bda/console.html04:38
fnavalin the gate test logs04:38
fnaval(search for octavia)04:39
ptoohillyea, hmmm lol, can it be ran with octavia04:39
fnavalhere's a passing run of the same gate: http://logs.openstack.org/98/264898/5/check/gate-neutron-lbaasv1-dsvm-api/71cd28b/console.html04:40
fnavaloctavia is declared as well04:40
ptoohilli havnt really looked at your change, but did the tempest config alter the config at all for this?04:40
ptoohillv1?04:40
ptoohillit should be ok if octavia is running, which is what this ljooks like04:41
ptoohillneutron-lbaas should be using the agent04:41
fnavalthe change I'm making is not the Octavia LB Scenario test.   this is different.  this is in the neutron-lbaas side04:41
ptoohilland based off of this it isnt04:41
ptoohill.test_lbaas_agent_scheduler.LBaaSAgentSchedulerTestJSON04:41
fnavalit's just removing tempest in-tree04:41
ptoohillthis is a neutron-lbaas patch?04:42
ptoohillim confused04:42
fnavalptoohill: https://review.openstack.org/#/c/273817/04:42
fnavalv1 gates on the CL are failing04:42
ptoohillbut thats in neutron-lbaas, what do you mean this is octavia scenario04:42
fnavalin order for me to fix the tests to make the gates pass, I'll have to run lbaasv1 to debug04:42
fnavalno this is not octavia scenario04:43
ptoohillso, im assuming that the removal of all that changed config04:43
fnavalthis totally different04:43
ptoohilloh, i misread that statement above, that confused me. i was on the same page with you04:43
ptoohillit looks like the spin up of the environment has been altered by what ever you removed04:44
ptoohillim not super familiar with tempest nor have a dug into it, but thats what it looks like from my view04:44
fnavalptoohill: so basically just  using: enable_server q-lbaas04:44
fnavalinstead of enable_server q-lbaasv2  ?04:45
ptoohillthat should be all you need, yes04:45
fnavalok cool. i'll see if i can get it up04:45
fnavaland running04:45
*** fnaval has quit IRC04:56
dougwigyou don't want to use the enable_plugin, either.05:05
*** fnaval has joined #openstack-lbaas05:12
*** armax has quit IRC05:38
*** amotoki has joined #openstack-lbaas05:49
*** ajmiller has quit IRC05:58
*** bank has quit IRC06:07
*** Purandar has quit IRC06:18
*** anilvenkata has joined #openstack-lbaas06:30
*** kobis has joined #openstack-lbaas06:57
*** johnsom_ has quit IRC07:21
openstackgerritFranklin Naval proposed openstack/neutron-lbaas: Delete tempest fork  https://review.openstack.org/27381707:45
fnavalok v1 lbaas tests fixed ^^07:45
*** amotoki has quit IRC08:03
*** kfox1111 has quit IRC08:14
*** anilvenkata has quit IRC09:09
*** anilvenkata has joined #openstack-lbaas09:25
*** fawadkhaliq has joined #openstack-lbaas09:39
*** anilvenkata has quit IRC09:46
openstackgerritFranklin Naval proposed openstack/neutron-lbaas: Delete tempest fork  https://review.openstack.org/27381709:58
*** fawadkhaliq has quit IRC09:58
*** Paco has joined #openstack-lbaas09:59
*** anilvenkata has joined #openstack-lbaas10:02
*** fawadkhaliq has joined #openstack-lbaas10:10
*** fawadkhaliq has quit IRC10:11
*** yamamoto has joined #openstack-lbaas10:19
*** yamamoto has quit IRC10:19
*** anilvenkata has quit IRC10:22
*** anilvenkata has joined #openstack-lbaas10:35
*** yamamoto has joined #openstack-lbaas11:20
*** yamamoto has quit IRC11:22
*** yamamoto has joined #openstack-lbaas11:22
*** yamamoto has quit IRC11:22
*** yamamoto has joined #openstack-lbaas11:50
*** kobis has quit IRC11:52
*** _amrith_ is now known as amrith11:54
*** yamamoto has quit IRC12:15
*** yamamoto has joined #openstack-lbaas12:22
*** yamamoto has quit IRC12:36
*** yamamoto has joined #openstack-lbaas13:14
*** links has quit IRC13:23
*** yamamoto has quit IRC13:41
*** numans has joined #openstack-lbaas13:41
*** amotoki has joined #openstack-lbaas13:43
*** yamamoto has joined #openstack-lbaas13:43
*** yamamoto has quit IRC13:43
*** yamamoto has joined #openstack-lbaas13:44
*** neelashah has joined #openstack-lbaas13:45
*** numans has quit IRC13:46
*** yamamoto has quit IRC13:58
*** yamamoto has joined #openstack-lbaas13:59
*** ajmiller has joined #openstack-lbaas14:25
*** ajmiller_ has joined #openstack-lbaas14:26
*** ajmiller has quit IRC14:30
*** neelashah has quit IRC14:35
*** Paco has quit IRC14:40
*** kobis has joined #openstack-lbaas14:56
*** yamamoto has quit IRC15:11
*** yamamoto has joined #openstack-lbaas15:12
*** yamamoto has quit IRC15:16
*** eranra_ has joined #openstack-lbaas15:26
*** eranra has quit IRC15:30
*** openstackgerrit_ has quit IRC15:30
*** yamamoto has joined #openstack-lbaas15:40
*** openstackgerrit_ has joined #openstack-lbaas15:43
*** ducttape_ has joined #openstack-lbaas15:51
*** ducttape_ has quit IRC16:05
*** Oku_OS has quit IRC16:12
*** jorgem has quit IRC16:12
*** jorgem has joined #openstack-lbaas16:13
*** amit213 has quit IRC16:22
*** amit213 has joined #openstack-lbaas16:22
*** amit213 has quit IRC16:23
*** amit213 has joined #openstack-lbaas16:24
*** amit213 has quit IRC16:33
*** amit213 has joined #openstack-lbaas16:34
*** armax has joined #openstack-lbaas16:39
*** kobis has quit IRC16:45
*** Purandar has joined #openstack-lbaas16:51
*** kobis has joined #openstack-lbaas16:53
*** Purandar has quit IRC16:58
*** yamamoto has quit IRC17:00
*** Aish has joined #openstack-lbaas17:00
*** Aish has quit IRC17:00
*** itsuugo has quit IRC17:21
*** itsuugo has joined #openstack-lbaas17:22
*** fawadkhaliq has joined #openstack-lbaas17:23
*** fawadkhaliq has quit IRC17:24
*** fawadkhaliq has joined #openstack-lbaas17:26
*** fawadkhaliq has quit IRC17:26
*** ducttape_ has joined #openstack-lbaas17:40
*** ducttape_ has quit IRC17:42
*** kobis has quit IRC17:50
*** fawadkhaliq has joined #openstack-lbaas18:00
*** yamamoto has joined #openstack-lbaas18:00
*** fawadkhaliq has quit IRC18:05
*** yamamoto has quit IRC18:11
*** doug-fis_ has quit IRC18:24
*** doug-fish has joined #openstack-lbaas18:27
*** ducttape_ has joined #openstack-lbaas18:29
*** anilvenkata has quit IRC18:32
*** ducttape_ has quit IRC18:35
*** kobis has joined #openstack-lbaas18:49
*** armax has quit IRC19:01
*** cody-somerville has joined #openstack-lbaas19:46
*** bana_k has joined #openstack-lbaas20:29
*** ajmiller has joined #openstack-lbaas20:35
*** ajmiller_ has quit IRC20:35
*** ajmiller has quit IRC20:36
*** cody-somerville has quit IRC20:40
*** ajmiller has joined #openstack-lbaas20:46
*** kobis has quit IRC20:47
*** bana_k has quit IRC21:04
*** ajmiller has quit IRC21:04
*** ajmiller has joined #openstack-lbaas21:04
*** jcook_ has joined #openstack-lbaas21:24
*** ajmiller has quit IRC21:25
*** ducttape_ has joined #openstack-lbaas21:38
*** ducttape_ has quit IRC21:51
*** doug-fish has quit IRC21:52
*** doug-fish has joined #openstack-lbaas21:56
*** nmagnezi has joined #openstack-lbaas22:28
*** kobis has joined #openstack-lbaas22:31
*** kobis has quit IRC22:31
*** nmagnezi has quit IRC22:40
*** mixos has joined #openstack-lbaas23:02

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!