| *** ducttape_ has quit IRC | 00:07 | |
| *** ducttape_ has joined #openstack-lbaas | 00:28 | |
| *** ducttape_ has quit IRC | 00:31 | |
| *** chenli has joined #openstack-lbaas | 00:41 | |
| *** chenli_ has joined #openstack-lbaas | 00:42 | |
| *** chenli has quit IRC | 00:46 | |
| *** chenli_ is now known as chenli | 00:46 | |
| *** ducttape_ has joined #openstack-lbaas | 00:49 | |
| *** bana_k has quit IRC | 01:01 | |
| *** kevo has quit IRC | 01:06 | |
| *** ducttape_ has quit IRC | 01:15 | |
| *** chlong has joined #openstack-lbaas | 01:18 | |
| *** ducttape_ has joined #openstack-lbaas | 01:18 | |
| *** ducttape_ has quit IRC | 01:42 | |
| *** hockeynut has quit IRC | 01:43 | |
| *** ducttape_ has joined #openstack-lbaas | 01:46 | |
| openstackgerrit | li,chen proposed openstack/octavia: Update listener stats https://review.openstack.org/354593 | 01:53 |
|---|---|---|
| *** ducttape_ has quit IRC | 01:54 | |
| *** woodster_ has quit IRC | 01:59 | |
| *** chenli has quit IRC | 02:02 | |
| *** chenli has joined #openstack-lbaas | 02:06 | |
| *** cody-somerville has joined #openstack-lbaas | 02:13 | |
| *** yamamoto_ has joined #openstack-lbaas | 02:14 | |
| *** ducttape_ has joined #openstack-lbaas | 02:19 | |
| openstackgerrit | li,chen proposed openstack/octavia: Add class 'StatsMixin' https://review.openstack.org/355764 | 02:25 |
| *** ducttape_ has quit IRC | 02:27 | |
| *** anilvenkata has joined #openstack-lbaas | 02:30 | |
| *** ducttape_ has joined #openstack-lbaas | 02:35 | |
| *** ducttape_ has quit IRC | 02:43 | |
| *** armax has quit IRC | 02:45 | |
| *** amotoki has joined #openstack-lbaas | 02:51 | |
| *** armax has joined #openstack-lbaas | 03:03 | |
| *** cody-somerville has quit IRC | 03:05 | |
| *** amotoki has quit IRC | 03:08 | |
| *** armax has quit IRC | 03:08 | |
| *** cody-somerville has joined #openstack-lbaas | 03:11 | |
| *** kevo has joined #openstack-lbaas | 03:12 | |
| *** cody-somerville has quit IRC | 03:16 | |
| *** amotoki has joined #openstack-lbaas | 03:21 | |
| *** fnaval has joined #openstack-lbaas | 03:25 | |
| *** amotoki has quit IRC | 03:30 | |
| *** amotoki has joined #openstack-lbaas | 03:35 | |
| sbalukoff | johnsom: Are you around? | 03:43 |
| johnsom | Yep | 03:43 |
| *** ducttape_ has joined #openstack-lbaas | 03:43 | |
| johnsom | sbalukoff what is up? | 03:44 |
| sbalukoff | So, I was looking at this patch: https://review.openstack.org/#/c/344658/ | 03:45 |
| sbalukoff | And it appears to work, though the testing I'm asking for might be pretty esoteric. | 03:46 |
| johnsom | Ok | 03:46 |
| sbalukoff | Given this is the namespace driver, do we care? | 03:46 |
| sbalukoff | In any case, it accomplishes what it sets out to do: haproxy gets respawned if you kill it, and when you alter the load balancer config, haproxy gets restarted gracefully (ie. with the "-sf <old_pid>" option added.) | 03:47 |
| johnsom | So, yeah. People are using this driver still. | 03:48 |
| *** ducttape_ has quit IRC | 03:49 | |
| johnsom | I hate haven toneat a | 03:49 |
| johnsom | Ugh,mobile sorry | 03:49 |
| johnsom | I have having to babysit this in this way. We do it with Upstart in Octavia. Which I need to implement systemd as well. | 03:50 |
| sbalukoff | Yep, but I have trouble finding fault with using neutron libraries intended to do this stuff in a neutron environment. :/ | 03:50 |
| johnsom | I think if it is a functional and complete solution we shouldn't block it. Just keep in mind the maintenance. | 03:51 |
| sbalukoff | Yeah. Should I insist on the tests I asked for there? | 03:51 |
| sbalukoff | (Mostly, I think the tests I asked for wouldn't really test this in any meaningful way... though I have a hard time thinking of a meaningful test for process monitoring that isn't a scenario test.) | 03:52 |
| johnsom | For drivers that the cores don't regularly use, I think we should make sure there are good tests. You know how picky I am about tests, so personally I think you are right. | 03:52 |
| sbalukoff | Ok, I'll update my note to continue requesting the tests. | 03:53 |
| sbalukoff | In any case, as long as the process monitoring enable() method is being called with the right parameters, this should continue to work (and we should notice if something changes there in our code tree to break it). | 03:54 |
| johnsom | We got bit by a revert on this once already, so good tests makes sense. | 03:54 |
| sbalukoff | Agreed. Ok. Thanks! | 03:55 |
| sbalukoff | I'm about to test Chen's octavia stats code stuff... | 03:56 |
| johnsom | Np. Thanks! | 03:56 |
| sbalukoff | I know she's really hoping to get this in for Newton... so any eyes we can get on that pronto would be great. (Otherwise... how would she go about trying to get a feature freeze extension). | 03:57 |
| sbalukoff | FWIW, I think she's been pretty responsive and prompt both getting the spec changes done and code up for review for us. | 03:57 |
| sbalukoff | (We just haven't had time to review it, given how busy things have been in the last few weeks.) | 03:57 |
| johnsom | Yeah, this was a late land and I've been asking our team to review as they have been looking at metrics recently. I think there are some open comments on those. | 03:59 |
| sbalukoff | Ok. Thanks for that, eh! | 03:59 |
| johnsom | Yes, we have been slammed and are still catching up. | 03:59 |
| *** chenli has quit IRC | 04:00 | |
| johnsom | If it is good, please feel free to +2 it and push us | 04:00 |
| sbalukoff | Ok, will do. (Will probably be around for several more hours tonight as well. I've been asked to do some relatively urgent testing on some internal code tonight as well...) | 04:00 |
| *** amotoki has quit IRC | 04:01 | |
| johnsom | Ok, thanks | 04:01 |
| *** cody-somerville has joined #openstack-lbaas | 04:05 | |
| *** amotoki has joined #openstack-lbaas | 04:16 | |
| *** kevo has quit IRC | 04:19 | |
| *** cody-somerville has quit IRC | 04:20 | |
| *** yamamoto_ has quit IRC | 04:23 | |
| *** chenli has joined #openstack-lbaas | 04:32 | |
| *** links has joined #openstack-lbaas | 04:32 | |
| chenli | johnsom, dougwig ping | 04:35 |
| *** amit213 has quit IRC | 04:37 | |
| *** yamamoto_ has joined #openstack-lbaas | 04:39 | |
| *** amit213 has joined #openstack-lbaas | 04:40 | |
| *** cody-somerville has joined #openstack-lbaas | 04:40 | |
| *** ducttape_ has joined #openstack-lbaas | 04:45 | |
| *** bana_k has joined #openstack-lbaas | 04:46 | |
| *** yamamoto_ has quit IRC | 04:49 | |
| *** ducttape_ has quit IRC | 04:50 | |
| *** pcaruana has quit IRC | 04:57 | |
| *** dougwig has quit IRC | 05:03 | |
| *** vmtyler has quit IRC | 05:03 | |
| *** amitry has quit IRC | 05:04 | |
| *** vmtyler has joined #openstack-lbaas | 05:04 | |
| *** sbelous_ has quit IRC | 05:04 | |
| *** amitry has joined #openstack-lbaas | 05:05 | |
| *** sbelous_ has joined #openstack-lbaas | 05:06 | |
| *** dougwig has joined #openstack-lbaas | 05:07 | |
| openstackgerrit | li,chen proposed openstack/octavia: Add a new API to list loadbalancer statistics https://review.openstack.org/356268 | 05:09 |
| *** gcheresh has joined #openstack-lbaas | 05:13 | |
| *** saju_m has joined #openstack-lbaas | 05:28 | |
| *** chenli has quit IRC | 05:29 | |
| *** kevo has joined #openstack-lbaas | 05:33 | |
| *** yamamoto_ has joined #openstack-lbaas | 05:34 | |
| *** kobis has joined #openstack-lbaas | 05:38 | |
| *** ihrachys has joined #openstack-lbaas | 05:42 | |
| *** cody-somerville has quit IRC | 05:45 | |
| *** ducttape_ has joined #openstack-lbaas | 05:46 | |
| *** kobis has quit IRC | 05:48 | |
| *** ducttape_ has quit IRC | 05:50 | |
| *** carrbs has quit IRC | 05:52 | |
| *** reedip has quit IRC | 06:03 | |
| *** rcernin has quit IRC | 06:08 | |
| *** anilvenkata has quit IRC | 06:15 | |
| *** nagyz has quit IRC | 06:22 | |
| *** nagyz has joined #openstack-lbaas | 06:22 | |
| *** anilvenkata has joined #openstack-lbaas | 06:27 | |
| *** pcaruana has joined #openstack-lbaas | 06:30 | |
| *** kobis has joined #openstack-lbaas | 06:33 | |
| *** ihrachys has quit IRC | 06:33 | |
| *** saju_m has quit IRC | 06:38 | |
| *** rcernin has joined #openstack-lbaas | 06:41 | |
| *** chenli has joined #openstack-lbaas | 06:44 | |
| *** rcernin has quit IRC | 06:45 | |
| *** rcernin has joined #openstack-lbaas | 06:45 | |
| *** bana_k has quit IRC | 06:46 | |
| *** ducttape_ has joined #openstack-lbaas | 06:47 | |
| *** ducttape_ has quit IRC | 06:52 | |
| *** tesseract- has joined #openstack-lbaas | 07:03 | |
| *** chenli has quit IRC | 07:06 | |
| openstackgerrit | Ravikumar proposed openstack/octavia: Housekeeping service does not cleanup stale amphora https://review.openstack.org/364110 | 07:17 |
| *** Alex_Stef has quit IRC | 07:24 | |
| *** kevo has quit IRC | 07:29 | |
| *** chenli has joined #openstack-lbaas | 07:37 | |
| *** ihrachys has joined #openstack-lbaas | 07:41 | |
| *** chenli has quit IRC | 07:43 | |
| *** chenli has joined #openstack-lbaas | 07:46 | |
| *** ducttape_ has joined #openstack-lbaas | 07:49 | |
| *** ducttape_ has quit IRC | 07:53 | |
| *** ihrachys has quit IRC | 07:55 | |
| *** saju_m has joined #openstack-lbaas | 07:59 | |
| *** nmagnezi has joined #openstack-lbaas | 08:09 | |
| *** duvarenkov has joined #openstack-lbaas | 08:17 | |
| *** duvarenkov has quit IRC | 08:29 | |
| *** duvarenkov has joined #openstack-lbaas | 08:31 | |
| *** eezhova has joined #openstack-lbaas | 08:38 | |
| *** anilvenkata has quit IRC | 08:45 | |
| *** noshankus has joined #openstack-lbaas | 08:46 | |
| *** ducttape_ has joined #openstack-lbaas | 08:49 | |
| *** Alex_Stef has joined #openstack-lbaas | 08:53 | |
| *** pck_ has joined #openstack-lbaas | 08:53 | |
| *** pck_ has quit IRC | 08:54 | |
| *** pck_ has joined #openstack-lbaas | 08:54 | |
| *** HenryG_ has joined #openstack-lbaas | 08:54 | |
| *** ducttape_ has quit IRC | 08:54 | |
| *** amotoki_ has joined #openstack-lbaas | 08:55 | |
| *** saju_m has quit IRC | 08:57 | |
| *** amotoki has quit IRC | 08:58 | |
| *** darrenc has quit IRC | 08:58 | |
| *** HenryG has quit IRC | 08:58 | |
| *** pck has quit IRC | 08:58 | |
| *** johnsom_ has quit IRC | 08:58 | |
| *** malos has quit IRC | 08:58 | |
| *** jidar has quit IRC | 08:58 | |
| *** _laco has quit IRC | 08:58 | |
| *** johnsom_ has joined #openstack-lbaas | 08:59 | |
| *** malos has joined #openstack-lbaas | 08:59 | |
| *** chenli has quit IRC | 09:02 | |
| *** darrenc has joined #openstack-lbaas | 09:03 | |
| *** jidar has joined #openstack-lbaas | 09:03 | |
| *** _laco has joined #openstack-lbaas | 09:03 | |
| *** anilvenkata has joined #openstack-lbaas | 09:03 | |
| *** _laco has quit IRC | 09:09 | |
| *** saju_m has joined #openstack-lbaas | 09:10 | |
| *** HenryG_ is now known as HenryG | 09:17 | |
| *** fnaval has quit IRC | 09:19 | |
| *** ihrachys has joined #openstack-lbaas | 09:25 | |
| *** numans has joined #openstack-lbaas | 09:27 | |
| *** HenryG has quit IRC | 09:29 | |
| *** HenryG has joined #openstack-lbaas | 09:29 | |
| *** ducttape_ has joined #openstack-lbaas | 09:50 | |
| *** ducttape_ has quit IRC | 09:54 | |
| *** yamamoto_ has quit IRC | 10:02 | |
| *** yamamoto has joined #openstack-lbaas | 10:43 | |
| *** anilvenkata has quit IRC | 10:43 | |
| *** gongysh has quit IRC | 10:49 | |
| *** ducttape_ has joined #openstack-lbaas | 10:51 | |
| *** yamamoto has quit IRC | 10:52 | |
| *** ducttape_ has quit IRC | 10:55 | |
| *** anilvenkata has joined #openstack-lbaas | 10:58 | |
| *** yamamoto has joined #openstack-lbaas | 11:00 | |
| *** reedip has joined #openstack-lbaas | 11:15 | |
| *** nmagnezi has quit IRC | 11:28 | |
| *** nmagnezi has joined #openstack-lbaas | 11:28 | |
| *** gongysh has joined #openstack-lbaas | 11:49 | |
| *** ducttape_ has joined #openstack-lbaas | 11:52 | |
| nmagnezi | sbalukoff, hi | 11:52 |
| nmagnezi | sbalukoff, re: https://review.openstack.org/#/c/299998 | 11:53 |
| nmagnezi | sbalukoff, first, thanks a lot for taking the time to review this. re your comment: you mean that whenever I reffer to the config option I'm just missing the default section name? | 11:54 |
| nmagnezi | meaning: cfg.CONF.default.foo_param ? | 11:54 |
| *** ducttape_ has quit IRC | 11:56 | |
| *** yamamoto has quit IRC | 12:11 | |
| *** ducttape_ has joined #openstack-lbaas | 12:11 | |
| *** ducttape_ has quit IRC | 12:13 | |
| *** yamamoto has joined #openstack-lbaas | 12:13 | |
| *** yamamoto has quit IRC | 12:16 | |
| *** ducttape_ has joined #openstack-lbaas | 12:17 | |
| *** yamamoto has joined #openstack-lbaas | 12:26 | |
| *** cody-somerville has joined #openstack-lbaas | 12:34 | |
| *** ducttape_ has quit IRC | 12:35 | |
| *** gongysh has quit IRC | 12:36 | |
| *** anilvenkata has quit IRC | 12:39 | |
| *** anilvenkata has joined #openstack-lbaas | 12:39 | |
| *** cody-somerville has quit IRC | 12:45 | |
| *** links has quit IRC | 12:51 | |
| *** ducttape_ has joined #openstack-lbaas | 12:53 | |
| *** yamamoto has quit IRC | 12:57 | |
| *** numans has quit IRC | 13:02 | |
| *** anilvenkata_ has joined #openstack-lbaas | 13:06 | |
| *** anilvenkata_ is now known as anilvenkata_afk | 13:06 | |
| *** anilvenkata has quit IRC | 13:07 | |
| *** ducttape_ has quit IRC | 13:07 | |
| *** amotoki_ has quit IRC | 13:14 | |
| *** matt-borland has joined #openstack-lbaas | 13:15 | |
| *** gongysh has joined #openstack-lbaas | 13:16 | |
| openstackgerrit | Merged openstack/neutron-lbaas: Change assertTrue(isinstance()) by optimal assert https://review.openstack.org/357570 | 13:23 |
| *** yamamoto has joined #openstack-lbaas | 13:26 | |
| *** yamamoto has quit IRC | 13:27 | |
| *** yamamoto has joined #openstack-lbaas | 13:30 | |
| *** amotoki has joined #openstack-lbaas | 13:31 | |
| *** ducttape_ has joined #openstack-lbaas | 13:32 | |
| *** yamamoto has quit IRC | 13:32 | |
| *** yamamoto has joined #openstack-lbaas | 13:33 | |
| *** yamamoto has quit IRC | 13:34 | |
| *** yamamoto has joined #openstack-lbaas | 13:34 | |
| *** yamamoto has quit IRC | 13:34 | |
| *** diogogmt has quit IRC | 13:39 | |
| openstackgerrit | Merged openstack/neutron-lbaas: Add special handling for functional tests https://review.openstack.org/362293 | 13:42 |
| *** amotoki has quit IRC | 13:43 | |
| *** ducttape_ has quit IRC | 13:44 | |
| *** diogogmt has joined #openstack-lbaas | 13:45 | |
| *** openstackgerrit has quit IRC | 13:49 | |
| *** openstackgerrit has joined #openstack-lbaas | 13:50 | |
| *** amotoki has joined #openstack-lbaas | 13:50 | |
| *** diogogmt has quit IRC | 13:50 | |
| *** ducttape_ has joined #openstack-lbaas | 13:57 | |
| *** amotoki has quit IRC | 13:59 | |
| *** ddaskal has joined #openstack-lbaas | 14:00 | |
| *** yamamoto has joined #openstack-lbaas | 14:00 | |
| *** ddaskal has quit IRC | 14:04 | |
| *** ducttape_ has quit IRC | 14:09 | |
| *** RichB has quit IRC | 14:13 | |
| *** amotoki has joined #openstack-lbaas | 14:14 | |
| *** carrbs has joined #openstack-lbaas | 14:26 | |
| *** gongysh has quit IRC | 14:33 | |
| *** pglass has joined #openstack-lbaas | 14:33 | |
| *** ducttape_ has joined #openstack-lbaas | 14:40 | |
| *** kobis has quit IRC | 14:44 | |
| *** diogogmt has joined #openstack-lbaas | 14:51 | |
| *** saju_m has quit IRC | 14:56 | |
| *** Alex_Stef has quit IRC | 14:59 | |
| *** pcaruana has quit IRC | 15:03 | |
| *** rcernin has quit IRC | 15:06 | |
| *** ddaskal has joined #openstack-lbaas | 15:07 | |
| *** eezhova has quit IRC | 15:10 | |
| *** yamamoto has quit IRC | 15:10 | |
| *** armax has joined #openstack-lbaas | 15:26 | |
| *** rcernin has joined #openstack-lbaas | 15:31 | |
| TrevorV | diltram, my bro | 15:32 |
| ptoohill | nmagnezi: I think he was saying that it should be placed in an appropriate section, or maybe it is already in that section but the code is already looking in default, hence it working when he moved the option | 15:34 |
| openstackgerrit | Merged openstack/octavia: Updated from global requirements https://review.openstack.org/363872 | 15:38 |
| *** anilvenkata_afk is now known as anilvenkata | 15:38 | |
| *** BjoernT has joined #openstack-lbaas | 15:49 | |
| *** ddaskal_ has joined #openstack-lbaas | 15:52 | |
| *** ddaskal has quit IRC | 15:55 | |
| *** gcheresh has quit IRC | 16:08 | |
| *** yamamoto has joined #openstack-lbaas | 16:11 | |
| *** ddaskal has joined #openstack-lbaas | 16:15 | |
| *** yamamoto has quit IRC | 16:15 | |
| *** ddaskal_ has quit IRC | 16:19 | |
| *** bana_k has joined #openstack-lbaas | 16:29 | |
| *** BjoernT has left #openstack-lbaas | 16:39 | |
| diltram | TrevorV: hey man | 16:41 |
| *** woodster_ has joined #openstack-lbaas | 16:42 | |
| openstackgerrit | Trevor Vardeman proposed openstack/octavia: Add quota support to Octavia https://review.openstack.org/360794 | 16:42 |
| *** yamamoto has joined #openstack-lbaas | 16:46 | |
| *** yamamoto has quit IRC | 16:50 | |
| *** amotoki has quit IRC | 16:51 | |
| *** anilvenkata is now known as anilvenkata_afk | 16:54 | |
| nmagnezi | ptoohill, thanks Phil, I will taking a look right now. | 16:56 |
| nmagnezi | s/taking/take | 16:56 |
| ptoohill | nmagnezi: no problem. but, yeah I think he was saying once he added it to default it works, so it probably should be in the 'right' section. At least thats how I understood it | 16:57 |
| nmagnezi | ptoohill, i was under the impression that it should be under the default section :-) , i'm re-spinning a devstack to have another look at this (also, i can't recall the section names so it will help) | 16:58 |
| ptoohill | Maybe it is supposed to be and your question is the answer. 'setting CONF.DEFAULT...' Though, are we sure that should be a default config option? | 16:59 |
| *** tesseract- has quit IRC | 17:01 | |
| *** ducttape_ has quit IRC | 17:03 | |
| diltram | sbalukoff: https://review.openstack.org/#/c/355764/13 - I'm against that code | 17:04 |
| *** ducttape_ has joined #openstack-lbaas | 17:04 | |
| diltram | that tests are not verifying anything | 17:04 |
| sbalukoff | Oh? | 17:05 |
| diltram | there is everything mocked and there is even no code tested at all | 17:05 |
| diltram | sbalukoff: https://review.openstack.org/#/c/355764/13/octavia/tests/unit/common/test_stats.py | 17:05 |
| diltram | take a look into that setUp | 17:05 |
| sbalukoff | Ok | 17:05 |
| diltram | everything is mocked without using original spec | 17:05 |
| diltram | and everything is mocked | 17:06 |
| diltram | I will comment there but later | 17:06 |
| diltram | I need to eat something because I'm starving | 17:06 |
| diltram | so I will comment later | 17:06 |
| diltram | but if you could reconcider that +2 in this time will be great :) | 17:06 |
| diltram | ok, food :D | 17:07 |
| *** bana_k has quit IRC | 17:07 | |
| ptoohill | statsmixin isnt mocked and it calls it, it seems | 17:08 |
| *** kevo has joined #openstack-lbaas | 17:08 | |
| ptoohill | ls_stats = self.sm.get_listener_stats( | 17:08 |
| ptoohill | self.session, self.listener_id) | 17:08 |
| ptoohill | maybe i just need more coffee | 17:08 |
| ptoohill | :/ | 17:08 |
| ptoohill | diltram: please mark a -1 so other know this is being verified. | 17:09 |
| ptoohill | it does mock the other things inside of it, but its a test for the stats mixin, maybe the question/problem here is there needs to be more tests verifying the other methods functionality | 17:11 |
| openstackgerrit | John Perkins proposed openstack/neutron-lbaas: Temporarily support two INTERFACE_DRIVER_OPTS https://review.openstack.org/364472 | 17:14 |
| *** ducttape_ has quit IRC | 17:15 | |
| ptoohill | and with that said, the only things that are mocked inside the statsmixin are the repos, which seems fine to me | 17:17 |
| ptoohill | Please help me understand the issue youre seeing. | 17:17 |
| *** bana_k has joined #openstack-lbaas | 17:17 | |
| ptoohill | If this were a functional/scenario, having everything mocked would be bad. This seems to mock the appropriate things for unit testing from what I see. | 17:18 |
| *** ducttape_ has joined #openstack-lbaas | 17:23 | |
| johnsom | Is anyone else having the specs tox fail on master? | 17:23 |
| openstackgerrit | John Perkins proposed openstack/neutron-lbaas: Temporarily support two INTERFACE_DRIVER_OPTS https://review.openstack.org/364472 | 17:28 |
| diltram | johnsom: I had with some svg files failing | 17:30 |
| johnsom | Hmm, docs passes for me, it's specs | 17:30 |
| diltram | ptoohill: my point is that she is even mocking data_models | 17:30 |
| diltram | did you saw how she's mocking in lne 38 stats object? | 17:31 |
| diltram | it's not even verifying that attribute really exist in this class | 17:31 |
| diltram | it's all around octavia that we're using MagicMock without autospec/spec and we need to change that if we would like to have a realible tests | 17:33 |
| diltram | and even unit test should mock all interaction with outside | 17:33 |
| diltram | with db, other services etc | 17:33 |
| diltram | but I never heard that we should mock our own code | 17:34 |
| diltram | johnsom: so, no it's working for me :P | 17:34 |
| diltram | in my opinion we should in that situation mock database access methods to returne real data_model/types objects and we're verifying that our data paths really works | 17:37 |
| diltram | and it's true testing will take more time but we will really test something | 17:37 |
| diltram | and we should have overlapping test which are verifying that paths are working and that we didn't change anything - like class methods what we can change here and bum, everything is OK in test | 17:38 |
| diltram | yeah, we just need to mock everywhere keystoneauth1.session.Session to return specific objects and we're good to go | 17:40 |
| diltram | ptoohill: https://review.openstack.org/#/c/355764/13/octavia/tests/unit/controller/healthmanager/test_update_db.py | 17:43 |
| diltram | take a look here | 17:43 |
| diltram | really I can understand what is the idea here | 17:43 |
| diltram | can't* | 17:44 |
| ptoohill | I suppose I still dont see an issue here. I mean I know we need to update and make testing better. But this test is for the mixin which is 'get_stats', the tests verify that if X stats are set they get returned as expected | 17:45 |
| ptoohill | but, im also not the greatest tester, so have it if you will ;) | 17:45 |
| *** SumitNaiksatam has joined #openstack-lbaas | 17:47 | |
| sbalukoff | diltram: So now that I've had a little longer to wake up, I'm not sure I follow you. But, I'll wait for your comments on that patch set. | 17:47 |
| diltram | sure, give me a few minutes and even I will add some additional info about what I'm talking :) | 17:48 |
| ptoohill | oh hrmm | 17:48 |
| johnsom | I have to agree with one point. Mocking a model is strange given our models are not database bound | 17:48 |
| ptoohill | Yeah, not sure why thats mocked there | 17:49 |
| ptoohill | i see | 17:49 |
| ptoohill | Ok, i agree. Not sure whats going on with 477 | 17:49 |
| ptoohill | well, i suppose it could just be | 17:49 |
| ptoohill | no no, im confused o.o | 17:50 |
| ptoohill | 477 shouldnt be there, thats the method that should be test.. so yeah I agree this is off a bit | 17:51 |
| ptoohill | -.- | 17:52 |
| ptoohill | i was looking at this in mixin context | 17:52 |
| ptoohill | this is the other test... | 17:52 |
| ptoohill | which i think is ok, because its mocking the get_stats with the expected data for the update_db method | 17:53 |
| ptoohill | and yeah, no real need to mock the dmodels, but that shouldnt break anything and isnt exactly 'wrong' i dont think. In either case Im not clearing anything up obviously, so Ill leave it as I think this looks ok for unit tests. | 17:55 |
| *** harlowja_ has joined #openstack-lbaas | 17:58 | |
| diltram | o shiet I didn't thought that the result will so horrible | 17:59 |
| diltram | take a look into my comment | 17:59 |
| *** harlowja has quit IRC | 18:00 | |
| *** ihrachys has quit IRC | 18:00 | |
| openstackgerrit | Michael Johnson proposed openstack/octavia: Subnet host routes support for plug_network https://review.openstack.org/349708 | 18:01 |
| sbalukoff | diltram: I'm not sure your comment there proves anything. Sure, I can add a few lines to some member API code which destroys the parent pool object in the database, and the API functional tests will never find it because those tests aren't meant to go that deep. The API functional tests (might be mis-named) are just making sure that for the proper kind of input, you get the proper kind of output. | 18:05 |
| sbalukoff | In any case, I think Chen is in training for the next two days, so this might not be something she gets to for a bit. | 18:16 |
| *** eezhova has joined #openstack-lbaas | 18:18 | |
| *** openstackgerrit has quit IRC | 18:18 | |
| *** openstackgerrit has joined #openstack-lbaas | 18:19 | |
| nmagnezi | sbalukoff, hey :) | 18:21 |
| nmagnezi | sbalukoff, can you please confirm what ptoohill said about the auto reschedule bug? I want to make sure i got you correctly so i can fix this right away | 18:21 |
| nmagnezi | sbalukoff, https://review.openstack.org/#/c/299998/ | 18:21 |
| sbalukoff | nmagnezi: I'm not seeing any comments from ptoohill in that patch set. | 18:22 |
| ptoohill | ah, it was here | 18:23 |
| sbalukoff | Oh, what did you say? | 18:23 |
| ptoohill | I was just expressing what I understood from your comments | 18:23 |
| openstackgerrit | John Perkins proposed openstack/neutron-lbaas: Temporarily support two INTERFACE_DRIVER_OPTS https://review.openstack.org/364472 | 18:23 |
| ptoohill | That when you added to default it worked, So it needs to be in right section, whether that default or not, and called correctly? | 18:23 |
| ptoohill | was a little more to it, but I think nmagnezi is just looking for clarification there | 18:24 |
| ptoohill | dont let me get in the way | 18:24 |
| sbalukoff | So my comments are that the code is looking for the allow_automatic_lbaas_agent_failover option set in the [DEFAULT] section of /etc/neutron/neutron.conf, but this is actually begin set (by the template) in the [DEFAULT] section of /etc/neutron/neutron_lbaas.conf | 18:24 |
| sbalukoff | s/begin/being/ | 18:25 |
| ptoohill | i see, there ya go | 18:25 |
| sbalukoff | nmagnezi: Does that make sense? | 18:25 |
| nmagnezi | sbalukoff, oh, really? will check that. now that i see this i think i misread your comment. so good that I asked :-) but how do you see it's reading it from neutron.conf? I remember I configured it in neutron_lbaas.conf | 18:27 |
| nmagnezi | again, i will recheck myself | 18:27 |
| nmagnezi | if that actually the case than ofcourse your comment is valid | 18:28 |
| sbalukoff | Yep, when you do your test, make sure that option is not set in /etc/neutron/neutron.conf and only in /etc/neutron/neutron_lbaas.conf | 18:29 |
| *** harlowja_ has quit IRC | 18:31 | |
| *** harlowja has joined #openstack-lbaas | 18:32 | |
| carrbs | heyo! Any folk available to help me get Octavia running in devstack? I’m using this guide: http://docs.openstack.org/developer/devstack/guides/devstack-with-lbaas-v2.html and have run into some issues | 18:37 |
| carrbs | Trying to just get a dev environment going so I can look at some bugs in launchpad | 18:37 |
| diltram | sbalukoff: I really can't understand why you're so determined to minimize code testing, in my previous work we never done things like this and we never loose anything because of that, because of that I'm so obsessed with testing as deep as possible without calling external services/dbs | 18:39 |
| bana_k | carrbs you facing any prob? | 18:39 |
| openstackgerrit | John Perkins proposed openstack/neutron-lbaas: Temporarily support two INTERFACE_DRIVER_OPTS https://review.openstack.org/364472 | 18:40 |
| sbalukoff | diltram: Well, unit tests are specifically not meant to be deep. For deep testing, that's sort of what scenario tests are for-- they're supposed to give the code a complete top-to-bottom work-out. And yes, we don't really have much by way of scenario tests yet (just the neutron ones yet). | 18:42 |
| carrbs | bana_k: There’s a section in the guide (^) that says “Set up a simple web server…” I ran those commands and it said (in infinite loop) “address already in use” (or something of the like). I killed that window, and accidentaly killed a few of the other processes that start when you run ./devstack.sh | 18:44 |
| *** eezhova has quit IRC | 18:44 | |
| sbalukoff | diltram: But you're right that it's possible that you can go not deep enough to the point where none of the code you're supposed to be testing is actually being tested. | 18:44 |
| bana_k | carrbs : do you mean for the members ? | 18:44 |
| sbalukoff | In this case, I think there's no reason to mock out the data model, so yes, we should go a little deeper than what's there. | 18:44 |
| carrbs | I tried unstack.sh and stack.sh, but now I seem to be having issues with apache. | 18:44 |
| diltram | sbalukoff: partialy I need to disagree with you - the unit test should verify "simple" things but I never heard that unit test cannot go deep into internal projet code | 18:45 |
| diltram | sure should mock and block connectivity with other things | 18:45 |
| diltram | like db and other services | 18:46 |
| diltram | but unit tests should verify that if I'm runnig this method I'm trying to save that data to db | 18:46 |
| bana_k | carrbs: I have never faced that prob till now. you can try unstack.sh clean.sh and try stack.sh and if you can try it out on the fresh VM that ll be even better | 18:46 |
| diltram | or like in this situation | 18:46 |
| sbalukoff | Right, and in this case I think I'm agreeing with you: Don't mock the model, mock where the model would interact with the DB. | 18:46 |
| diltram | when I'm requesting that stats that they will be grabbed from DB and send to me | 18:47 |
| diltram | sbalukoff: +1 | 18:47 |
| carrbs | bana_k: ok, I’ll try those things first. thanks! | 18:47 |
| *** eezhova has joined #openstack-lbaas | 18:48 | |
| sbalukoff | diltram: Just as a friendly hint, please be careful with accusatory language: I'm not "so determined to minimize code testing." Though I can understand it's frustrating to encounter people with differing opinions on things you're passionate about. | 18:48 |
| diltram | sbalukoff: sorry for that, I didn't mean attacking you or smth | 18:49 |
| diltram | English is my second language and sometimes I have that problems that I wrote smth not like I should | 18:50 |
| sbalukoff | No problem. I appreciate that you don't want bad code to make it into our code base. That's a good thing to be passionate about, eh. | 18:50 |
| sbalukoff | So yes-- please keep pointing out shit where you see it! Just be careful not to use language which implies others don't care about writing good code, eh. | 18:51 |
| diltram | sure :) I will work on that and again sorry | 18:53 |
| sbalukoff | Eh, I'm the resident asshole. I can take it. ;) (Also, I can dish it out...) | 18:54 |
| sbalukoff | carrbs: You might have more luck following this guide in this patch set here: https://review.openstack.org/#/c/232173/ | 18:55 |
| *** harlowja_ has joined #openstack-lbaas | 19:13 | |
| carrbs | sbalukoff: thanks, I will compare the two. I was able to get ./stack.sh to run after a reboot, and I derped one of the steps I’m now realizing (thanks to bana_k for pointing out the derpage). | 19:16 |
| nmagnezi | sbalukoff, hey | 19:16 |
| nmagnezi | sbalukoff, so i just stacked | 19:16 |
| nmagnezi | and is see | 19:16 |
| nmagnezi | $ grep allow_automatic_lbaas_agent_failover -R | 19:17 |
| nmagnezi | neutron_lbaas.conf:#allow_automatic_lbaas_agent_failover = false | 19:17 |
| nmagnezi | sbalukoff, it's only on neutron_lbaas | 19:17 |
| *** harlowja has quit IRC | 19:17 | |
| nmagnezi | sbalukoff, how i tested: I cherry-picked the patch and ./stack.sh (RECLONE="no" , so it did not override the patch) | 19:19 |
| sbalukoff | nmagnezi: Yes. Again, your code does look for this option in /etc/neutron/neutron_lbaas.conf. It looks in /etc/neutron/neutron.conf | 19:23 |
| sbalukoff | er... sorry, your code DOESN'T look for this option in /etc/neutron/neutron_lbaas.conf | 19:23 |
| nmagnezi | sbalukoff, the code uses cfg.CONF.param_name , isn't this point to neutron_lbaas? (sorry, i must be missing something here) | 19:24 |
| nmagnezi | sbalukoff, we are talking about https://review.openstack.org/#/c/299998/31/neutron_lbaas/drivers/common/agent_driver_base.py@166 , right? | 19:26 |
| sbalukoff | nmagnezi: Yes, that's what I'm talking about. And ultimately, isn't that code being run by the q-svc daemon, which doesn't look in /etc/neutron/neutron_lbaas.conf ? | 19:27 |
| *** gcheresh has joined #openstack-lbaas | 19:27 | |
| sbalukoff | nmagnezi: Here's another test for you: | 19:27 |
| sbalukoff | nmagnezi: Uncomment that config line in /etc/neutron/neutron_lbaas.conf and set it to true. Restart your daemons, and deploy a load balancer. Make sure you've got two lbaasv2 agents running. Then kill the one to which the load balaner got scheduled. | 19:29 |
| *** saju_m has joined #openstack-lbaas | 19:29 | |
| sbalukoff | Does the load balancer get rescheduled to the remaining (alive) lbaasv2 agent? | 19:29 |
| nmagnezi | sbalukoff, i have done such a test while i developed this, so the answer is: 'yes'. if you want, I can test it once more. | 19:30 |
| sbalukoff | nmagnezi: So... I ran that test last night and it didn't work unless I put that config line in /etc/neutron/neutron.conf | 19:30 |
| nmagnezi | sbalukoff, really? I will give it a spin :-) | 19:31 |
| nmagnezi | sbalukoff, and re: your first question: to the best of my knowledge the q-svc indeed uses this since the lbaas is a plugin to the neutron server. but when this code runs the cfg.CONF is suppose to aim at neutron_lbaas.conf | 19:32 |
| nmagnezi | but again, i will test this and keep you posted | 19:32 |
| nmagnezi | lemme see if I can add another node to my devstack | 19:32 |
| sbalukoff | I'll start re-stacking as well (the machine I was testing this on is set up to test your process monitor patch, which works, but your patch needs more tests.) | 19:35 |
| *** gcheresh has quit IRC | 19:36 | |
| nmagnezi | sbalukoff, yes i was about to answer that comment. the process monitor has a lot of tests by itself in the neutron code base. so as an infrastructure it is well tested. | 19:38 |
| nmagnezi | sbalukoff, any specific test you wish me to add to the neutron-lbaas codebase? I'm all up for it. | 19:38 |
| nmagnezi | sbalukoff, and re: johnsom's comment (which I will replay as well) your answer was correct and another reason i refrain from using upstart is because it is specific to non systemd base linux flavors (such as Ubuntu). whereas this solution is OS agnostic | 19:40 |
| nmagnezi | sbalukoff, that reminds me of the issue we have with the amphora-agent :-) | 19:41 |
| sbalukoff | nmagnezi: Per my comment on that patch, please make sure we're calling the pm.enable and other methods with the correct parameters. | 19:43 |
| pglass | so I've tried toggling admin_state_up on loadbalancers, listeners, pools, and members and it doesn't seem to have any effect. | 19:44 |
| nmagnezi | sbalukoff, i will make sure to address that | 19:45 |
| sbalukoff | pglass: File a bug! I suspect we're not checking that option in places where we really should. | 19:46 |
| openstackgerrit | Merged openstack/octavia: Corrected test_dir path in TempestPlugin https://review.openstack.org/361615 | 19:46 |
| johnsom | pglass Hmm, We just fixed that in March: https://review.openstack.org/#/c/290408/ Curious to see what it is now | 19:50 |
| pglass | how is admin_state_up implemented? is it haproxy config changes, or something else? | 19:55 |
| johnsom | It depends on the driver you are using | 19:55 |
| johnsom | In Octavia, yes, it is mostly config changes | 19:56 |
| pglass | so in this case, if admin_state_up wasn't working properly, we could probably look into the haproxy config on the amp? | 19:57 |
| pglass | and those config changes are communicated via the amphora's rest api, right? | 19:57 |
| johnsom | Yes | 19:57 |
| pglass | i was looking at the amphora rest api earlier. I was able to `curl -k --cert /etc/octavia/certs/client.pem https://192.168.0.9:9443/0.5/listeners` for example | 19:59 |
| pglass | there was a single listener (in my case) and its status was "OFFLINE". | 20:00 |
| pglass | https://bugs.launchpad.net/octavia/+bug/1619449 | 20:00 |
| openstack | Launchpad bug 1619449 in octavia "Toggling admin_state_up has no effect" [Undecided,New] | 20:00 |
| johnsom | Hmm, just tested admin-state-up on a member and it stopped returning traffic, so.... | 20:05 |
| pglass | alright. is it the controller worker that's responsible for making sure the amphora gets reconfigured when admin_state_up is changed? | 20:07 |
| *** ducttape_ has quit IRC | 20:07 | |
| *** ducttape_ has joined #openstack-lbaas | 20:08 | |
| johnsom | Yes | 20:20 |
| *** nmagnezi_ has joined #openstack-lbaas | 20:27 | |
| *** _ducttape_ has joined #openstack-lbaas | 20:28 | |
| *** nmagnezi has quit IRC | 20:28 | |
| *** carrbs has quit IRC | 20:31 | |
| *** ducttape_ has quit IRC | 20:31 | |
| *** _ducttape_ has quit IRC | 20:34 | |
| *** ducttape_ has joined #openstack-lbaas | 20:35 | |
| *** _ducttape_ has joined #openstack-lbaas | 20:38 | |
| *** ducttape_ has quit IRC | 20:42 | |
| *** _ducttape_ has quit IRC | 20:45 | |
| *** ducttape_ has joined #openstack-lbaas | 20:45 | |
| *** anilvenkata_afk has quit IRC | 20:50 | |
| openstackgerrit | Cedric Shock proposed openstack/neutron-lbaas: Allow creating loadbalancer with network_id https://review.openstack.org/363302 | 20:52 |
| nmagnezi_ | sbalukoff, devstack keeps failing for me when i try to spin, up the secondary node (for having anothe agent) | 20:54 |
| nmagnezi_ | sbalukoff, it's midnight here. so I think i'll pick up on this tomorrow | 20:54 |
| *** nmagnezi_ has quit IRC | 21:01 | |
| *** anilvenkata_afk has joined #openstack-lbaas | 21:02 | |
| *** rcernin has quit IRC | 21:24 | |
| *** ddaskal has quit IRC | 21:25 | |
| *** matt-borland has quit IRC | 21:27 | |
| *** anilvenkata_afk has quit IRC | 21:38 | |
| *** ducttape_ has quit IRC | 21:44 | |
| *** eezhova has quit IRC | 21:44 | |
| *** ducttape_ has joined #openstack-lbaas | 21:45 | |
| *** anilvenkata_afk has joined #openstack-lbaas | 21:52 | |
| johnsom | Ok, the routes patch https://review.openstack.org/#/c/349708 is back up for review. I fixed the type issue and had a successful run on devstack | 21:53 |
| sbalukoff | Ok, I'll have a look. | 21:55 |
| *** ducttape_ has quit IRC | 22:27 | |
| rm_work | just +A'd | 22:37 |
| rm_work | I swear I've reviewed that code 10 times now | 22:37 |
| sbalukoff | Well, you shouldn't have to review it any more. :) | 22:42 |
| *** pglass has quit IRC | 22:46 | |
| *** ducttape_ has joined #openstack-lbaas | 22:48 | |
| rm_work | Ha, just found this: https://noncombatant.org/octavia/architecture.html | 22:57 |
| rm_work | Did you see that before sbalukoff? lol | 22:57 |
| sbalukoff | Haha! No, and I looked around pretty well before choosing that name. Besides: We got the trademark, they don't. | 23:04 |
| rm_work | yep :P | 23:05 |
| sbalukoff | How did you even find that? It doesn't show up on the first four pages of a google search. | 23:07 |
| harlowja_ | thats not octavia :-P | 23:07 |
| harlowja_ | haha | 23:07 |
| rm_work | sbalukoff: skills | 23:07 |
| rm_work | or, maybe luck | 23:08 |
| *** fnaval has joined #openstack-lbaas | 23:16 | |
| openstackgerrit | Merged openstack/octavia: Subnet host routes support for plug_network https://review.openstack.org/349708 | 23:23 |
| *** fnaval has quit IRC | 23:27 | |
| *** fnaval has joined #openstack-lbaas | 23:31 | |
| *** chlong has quit IRC | 23:33 | |
| *** gongysh has joined #openstack-lbaas | 23:35 | |
| *** fnaval has quit IRC | 23:35 | |
| *** diogogmt has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!