*** klindgren__ has quit IRC | 00:02 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia: Updated from global requirements https://review.openstack.org/405830 | 00:06 |
---|---|---|
*** ducttape_ has quit IRC | 00:09 | |
*** ducttape_ has joined #openstack-lbaas | 00:10 | |
greghaynes | johnsom: ohai, we can chat in here since its a bit octavia specific | 00:16 |
greghaynes | johnsom: anything I should look at re: sysctl | 00:16 |
johnsom | So you added pipefail, which is good, it points out a problem | 00:17 |
greghaynes | ah | 00:17 |
johnsom | sysctl-set-value | 00:17 |
greghaynes | yes, we lint on that in DIB but tripleo-image-elements does not | 00:17 |
johnsom | It's doing: if ! sysctl -a | grep -q "^$NAME"; then | 00:17 |
johnsom | Which I think is backwards since they are using -q | 00:17 |
johnsom | But a bigger question is why is it caring about the host and not the image. | 00:18 |
greghaynes | isnt q just quiet? | 00:18 |
johnsom | Quiet; do not write anything to standard output. Exit immediately with zero status if any match is found, | 00:18 |
johnsom | even if an error was detected. | 00:18 |
greghaynes | ah so you think the fail case changed | 00:19 |
johnsom | So, it exits with 0 on match, we invert so it becomes 1, thus, fails on match | 00:19 |
johnsom | Without pipefail it just went along happy | 00:19 |
greghaynes | oh because the sysctl -a succeeded | 00:20 |
greghaynes | hahaa | 00:20 |
johnsom | I just thing that check is invalid as it is testing the host running DIB and not the kernel in the image being built. Same with the sysctl -p | 00:20 |
greghaynes | yea, agreed | 00:21 |
johnsom | sysctl -p sets the values on the host, not in the image. That is what the files the ssyctl-write-value does. | 00:21 |
greghaynes | id +2 removing that | 00:22 |
johnsom | So, I have your patch working and solves my issue. I guess I need to push one up against that sysctl | 00:22 |
johnsom | With that out of the way we are building images again | 00:22 |
greghaynes | awesome :) now without tripleo deps? | 00:22 |
johnsom | Correct | 00:22 |
greghaynes | \O/ | 00:23 |
johnsom | Ok, give me ten minutes to push up a DIB patch | 00:23 |
johnsom | greghaynes https://review.openstack.org/406413 | 00:27 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Stop depending on tripleo-image-elements https://review.openstack.org/356590 | 00:29 |
greghaynes | johnsom: actually, wait a set - why are you all using sysctl-set-value instead of just sysctl-set-value | 00:30 |
greghaynes | er, sec | 00:30 |
greghaynes | and sysctl-write-value | 00:30 |
johnsom | sysctl-set-value checks for conflicting settings from other elements or in the cloud image, sysctl-write-value just writes out the file | 00:31 |
greghaynes | ah | 00:31 |
greghaynes | seems like we should just have one script called sysctl-write-value which does the check | 00:32 |
johnsom | Not sure there is really much value in having them both | 00:32 |
greghaynes | since now its pretty meaningless to have two | 00:32 |
greghaynes | yea | 00:32 |
johnsom | Yeah, same thought | 00:32 |
greghaynes | I suspect what was going on is in tripleo they copied sysctl-set-value in to the image and used it post-boot and just wanted to save some code duplication | 00:33 |
johnsom | Do we need to worry about legacy support? If we merge it, which name wins? | 00:35 |
greghaynes | we can make one a symlink to the other | 00:35 |
greghaynes | although speaking of legacy - FYI we have a dib v2 branch which we are planning to RC pretty soon, you all likely want to check at some point that it doesnt break you all | 00:37 |
johnsom | Yeah, didn't know about that until today. Any pointers to the plan there? | 00:37 |
greghaynes | its all done except one feature were finishing up. The plan was to land that, cut an RC, send out a mail asking people to test, fix whatever breakages people encounter (hopefully within a few weeks) then potentially repeat or merge in to master | 00:38 |
greghaynes | the outstanding feature shouldnt have any effect on you all though so you should be able to try it out now | 00:39 |
*** ducttape_ has quit IRC | 00:41 | |
*** ducttape_ has joined #openstack-lbaas | 00:43 | |
*** bana_k has quit IRC | 00:43 | |
*** yamamoto has joined #openstack-lbaas | 00:44 | |
johnsom | greghaynes See what you think of: https://review.openstack.org/406413 | 00:44 |
greghaynes | johnsom: LGTM | 00:46 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Stop depending on tripleo-image-elements https://review.openstack.org/356590 | 00:46 |
johnsom | Ok, I think with those two we are back in business. | 00:48 |
*** yamamoto has quit IRC | 00:48 | |
johnsom | greghaynes So, I should just get the "feature/v2" branch and give it a go? | 00:48 |
greghaynes | yep | 00:49 |
johnsom | I don't see a spec in there for v2, what is different? | 00:49 |
greghaynes | theres a lot of removal of stuff thats been deprecated for a long time (almost all elements that have a synonym or alternative) | 00:50 |
greghaynes | a diff in how we handle a few wierd cases, the big one is if you have two elements of the same name we no longer merge | 00:50 |
johnsom | Ok. I can test it fairly quickly. | 00:50 |
greghaynes | and now you *have* to pip install, no running ./bin/disk-image-create | 00:51 |
johnsom | Oh, well that will be an issue for us | 00:51 |
greghaynes | Aw, should be easy enough to pip install? | 00:53 |
johnsom | Yeah, just need to re-work the scripts a bit | 00:54 |
johnsom | Actually, no, the way I wrote the script will still work. Just some cleanup of paths that aren't needed any longer | 00:57 |
greghaynes | awesome :) | 00:58 |
openstackgerrit | Michael Johnson proposed openstack/octavia: Stop depending on tripleo-image-elements https://review.openstack.org/356590 | 00:59 |
johnsom | greghaynes Oh yeah, I found another issue. This time in pip-and-virtualenv. It is calling "python /tmp/get-pip.py" but python isn't in the package list | 01:01 |
johnsom | Well, DIB v2 created an image | 01:10 |
*** ducttape_ has quit IRC | 01:11 | |
openstackgerrit | Michael Johnson proposed openstack/octavia: Stop depending on tripleo-image-elements https://review.openstack.org/356590 | 01:16 |
greghaynes | johnsom: oh, right - we likely need to make a Python element | 01:28 |
greghaynes | johnsom: since we need to be smart about installing py2 vs py3 depending on release | 01:28 |
greghaynes | Good to hear about dib v2 though | 01:29 |
johnsom | Yeah, I hope my patch is ok in the interim as it is needed to get us going again. | 01:33 |
*** Purandar has joined #openstack-lbaas | 01:33 | |
*** bana_k has joined #openstack-lbaas | 02:30 | |
*** bana_k has quit IRC | 02:49 | |
*** ducttape_ has joined #openstack-lbaas | 03:12 | |
*** ducttape_ has quit IRC | 03:12 | |
*** ducttape_ has joined #openstack-lbaas | 03:12 | |
*** Purandar has quit IRC | 03:21 | |
*** ducttape_ has quit IRC | 03:25 | |
*** armax has quit IRC | 03:28 | |
*** Purandar has joined #openstack-lbaas | 03:36 | |
*** armax has joined #openstack-lbaas | 04:08 | |
*** bana_k has joined #openstack-lbaas | 04:30 | |
*** yamamoto has joined #openstack-lbaas | 04:38 | |
*** yamamoto has quit IRC | 04:38 | |
*** bana_k has quit IRC | 04:39 | |
*** yamamoto has joined #openstack-lbaas | 04:47 | |
*** armax has quit IRC | 04:51 | |
*** yamamoto has quit IRC | 04:52 | |
*** fnaval has quit IRC | 05:07 | |
*** yatin has quit IRC | 05:19 | |
*** fnaval has joined #openstack-lbaas | 05:24 | |
*** kobis has joined #openstack-lbaas | 05:24 | |
*** Purandar has quit IRC | 05:25 | |
*** ducttape_ has joined #openstack-lbaas | 05:26 | |
*** Purandar has joined #openstack-lbaas | 05:30 | |
*** ducttape_ has quit IRC | 05:31 | |
*** yatin has joined #openstack-lbaas | 05:31 | |
*** yamamoto has joined #openstack-lbaas | 05:33 | |
*** yamamoto has quit IRC | 05:37 | |
*** csomerville has quit IRC | 05:51 | |
*** cody-somerville has joined #openstack-lbaas | 05:52 | |
*** cody-somerville has quit IRC | 05:52 | |
*** cody-somerville has joined #openstack-lbaas | 05:52 | |
*** yamamoto has joined #openstack-lbaas | 06:02 | |
*** yamamoto has quit IRC | 06:07 | |
*** yamamoto has joined #openstack-lbaas | 06:11 | |
*** yamamoto has quit IRC | 06:11 | |
*** kobis has quit IRC | 06:15 | |
openstackgerrit | Reedip proposed openstack/neutron-lbaas: Add support to update members in LBaaS extension https://review.openstack.org/373135 | 06:16 |
*** kobis has joined #openstack-lbaas | 06:25 | |
*** kobis has quit IRC | 06:37 | |
*** kobis has joined #openstack-lbaas | 06:46 | |
*** rcernin has quit IRC | 06:47 | |
*** rcernin has joined #openstack-lbaas | 06:50 | |
*** yamamoto has joined #openstack-lbaas | 07:12 | |
*** numans has quit IRC | 07:18 | |
*** yamamoto has quit IRC | 07:18 | |
*** kobis has quit IRC | 07:26 | |
*** Purandar has quit IRC | 07:30 | |
*** rcernin has quit IRC | 08:11 | |
*** rcernin has joined #openstack-lbaas | 08:11 | |
openstackgerrit | Reedip proposed openstack/neutron-lbaas: Add Timeout on Listeners https://review.openstack.org/273896 | 08:34 |
*** ducttape_ has joined #openstack-lbaas | 09:28 | |
*** ihrachys has joined #openstack-lbaas | 09:29 | |
*** ducttape_ has quit IRC | 09:33 | |
*** yamamoto has joined #openstack-lbaas | 09:38 | |
*** kobis has joined #openstack-lbaas | 09:39 | |
*** kobis has quit IRC | 09:40 | |
*** yamamoto has quit IRC | 09:55 | |
*** yamamoto has joined #openstack-lbaas | 09:56 | |
*** yamamoto has quit IRC | 09:56 | |
*** klindgren__ has joined #openstack-lbaas | 10:40 | |
*** klindgren_ has quit IRC | 10:42 | |
*** kobis has joined #openstack-lbaas | 10:48 | |
*** yamamoto has joined #openstack-lbaas | 10:57 | |
*** yamamoto has quit IRC | 10:59 | |
*** yamamoto has joined #openstack-lbaas | 10:59 | |
*** kobis has quit IRC | 11:14 | |
*** kobis has joined #openstack-lbaas | 11:31 | |
*** fnaval has quit IRC | 11:44 | |
*** kobis has quit IRC | 11:52 | |
*** kobis has joined #openstack-lbaas | 11:53 | |
*** kobis has quit IRC | 11:53 | |
*** ducttape_ has joined #openstack-lbaas | 12:48 | |
*** kobis has joined #openstack-lbaas | 12:53 | |
*** eezhova has joined #openstack-lbaas | 13:00 | |
*** kobis has quit IRC | 13:08 | |
*** kobis has joined #openstack-lbaas | 13:28 | |
*** ducttape_ has quit IRC | 13:28 | |
*** kobis has quit IRC | 13:44 | |
*** ihrachys has quit IRC | 13:48 | |
*** ducttape_ has joined #openstack-lbaas | 14:22 | |
*** harlowja has quit IRC | 14:40 | |
*** ducttape_ has quit IRC | 14:47 | |
*** eezhova has quit IRC | 14:48 | |
*** yamamoto has quit IRC | 15:14 | |
*** diogogmt has quit IRC | 15:54 | |
*** yamamoto has joined #openstack-lbaas | 16:14 | |
*** yamamoto has quit IRC | 16:22 | |
*** Matias has quit IRC | 16:46 | |
*** ducttape_ has joined #openstack-lbaas | 16:47 | |
*** Matias has joined #openstack-lbaas | 16:50 | |
*** ducttape_ has quit IRC | 16:52 | |
*** fnaval has joined #openstack-lbaas | 17:09 | |
*** diogogmt has joined #openstack-lbaas | 17:24 | |
*** ducttape_ has joined #openstack-lbaas | 17:51 | |
*** csomerville has joined #openstack-lbaas | 17:52 | |
*** cody-somerville has quit IRC | 17:52 | |
*** Matias has quit IRC | 17:58 | |
*** bana_k has joined #openstack-lbaas | 18:32 | |
*** ducttape_ has quit IRC | 18:36 | |
*** kobis has joined #openstack-lbaas | 18:52 | |
*** kobis has quit IRC | 19:55 | |
*** bana_k has quit IRC | 19:57 | |
*** ducttape_ has joined #openstack-lbaas | 20:21 | |
*** bana_k has joined #openstack-lbaas | 20:30 | |
*** ducttape_ has quit IRC | 20:44 | |
*** bana_k has quit IRC | 20:59 | |
*** bana_k has joined #openstack-lbaas | 21:05 | |
*** ducttape_ has joined #openstack-lbaas | 21:26 | |
*** bana_k has quit IRC | 21:41 | |
*** fnaval_ has joined #openstack-lbaas | 21:44 | |
*** fnaval has quit IRC | 21:46 | |
*** ducttape_ has quit IRC | 22:12 | |
*** ducttape_ has joined #openstack-lbaas | 22:15 | |
*** bana_k has joined #openstack-lbaas | 22:26 | |
*** ducttape_ has quit IRC | 22:27 | |
*** bana_k has quit IRC | 22:32 | |
*** diogogmt has quit IRC | 22:37 | |
*** bana_k has joined #openstack-lbaas | 22:50 | |
*** catintheroof has joined #openstack-lbaas | 22:58 | |
*** catintheroof has quit IRC | 23:07 | |
*** rcernin has quit IRC | 23:13 | |
*** ducttape_ has joined #openstack-lbaas | 23:43 | |
*** ducttape_ has quit IRC | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!