*** reedip has joined #openstack-lbaas | 00:10 | |
*** catintheroof has joined #openstack-lbaas | 00:20 | |
*** catintheroof has quit IRC | 00:26 | |
*** reedip has quit IRC | 00:38 | |
*** yamamoto has joined #openstack-lbaas | 00:41 | |
*** yamamoto has quit IRC | 00:45 | |
*** nrado has quit IRC | 01:07 | |
*** ducnc has joined #openstack-lbaas | 01:09 | |
*** yamamoto has joined #openstack-lbaas | 01:11 | |
*** yamamoto has quit IRC | 01:15 | |
*** gongysh has joined #openstack-lbaas | 01:16 | |
*** bzhao has quit IRC | 01:22 | |
*** yamamoto has joined #openstack-lbaas | 01:28 | |
*** yamamoto has quit IRC | 01:28 | |
*** reedip has joined #openstack-lbaas | 01:30 | |
*** yamamoto has joined #openstack-lbaas | 01:36 | |
*** bbzhao has joined #openstack-lbaas | 01:38 | |
*** aojea has joined #openstack-lbaas | 01:40 | |
*** yamamoto has quit IRC | 01:41 | |
*** aojea has quit IRC | 01:45 | |
*** yamamoto has joined #openstack-lbaas | 02:19 | |
*** yamamoto has quit IRC | 02:19 | |
*** yamamoto has joined #openstack-lbaas | 02:31 | |
*** sanfern has joined #openstack-lbaas | 02:51 | |
*** cpuga has joined #openstack-lbaas | 03:16 | |
*** cpuga has quit IRC | 03:17 | |
*** aojea has joined #openstack-lbaas | 03:42 | |
*** aojea has quit IRC | 03:46 | |
*** yamamoto has quit IRC | 03:50 | |
*** yamamoto has joined #openstack-lbaas | 03:57 | |
*** yamamoto has quit IRC | 03:59 | |
*** yamamoto has joined #openstack-lbaas | 04:00 | |
*** yamamoto has quit IRC | 04:00 | |
openstackgerrit | Reedip proposed openstack/neutron-lbaas master: Assign dns-name to port during LB creation https://review.openstack.org/404774 | 04:11 |
---|---|---|
*** gongysh has quit IRC | 04:18 | |
*** links has joined #openstack-lbaas | 04:20 | |
*** yamamoto has joined #openstack-lbaas | 04:55 | |
*** yamamoto has quit IRC | 05:00 | |
*** gongysh has joined #openstack-lbaas | 05:04 | |
*** aojea has joined #openstack-lbaas | 05:42 | |
*** aojea has quit IRC | 05:47 | |
*** gongysh has quit IRC | 05:58 | |
*** gcheresh_ has joined #openstack-lbaas | 06:04 | |
*** gongysh has joined #openstack-lbaas | 06:10 | |
*** yamamoto has joined #openstack-lbaas | 06:11 | |
*** yamamoto has quit IRC | 06:18 | |
*** aojea has joined #openstack-lbaas | 06:25 | |
*** korean101 has joined #openstack-lbaas | 06:59 | |
*** kobis has joined #openstack-lbaas | 07:03 | |
*** eezhova has joined #openstack-lbaas | 07:03 | |
*** kobis has quit IRC | 07:46 | |
*** csomerville has joined #openstack-lbaas | 07:49 | |
*** nrado has joined #openstack-lbaas | 07:51 | |
*** cody-somerville has joined #openstack-lbaas | 07:51 | |
*** csomerville has quit IRC | 07:53 | |
*** tesseract has joined #openstack-lbaas | 07:58 | |
*** eezhova has quit IRC | 08:00 | |
*** armax has quit IRC | 08:05 | |
*** pcaruana has joined #openstack-lbaas | 08:14 | |
*** yamamoto has joined #openstack-lbaas | 08:22 | |
*** nrado has quit IRC | 08:29 | |
*** eezhova has joined #openstack-lbaas | 08:30 | |
*** nrado has joined #openstack-lbaas | 08:39 | |
openstackgerrit | Reedip proposed openstack/octavia master: Add Timeout on Listeners https://review.openstack.org/412971 | 08:53 |
openstackgerrit | Reedip proposed openstack/neutron-lbaas master: Add Timeout on Listeners https://review.openstack.org/273896 | 08:54 |
reedip | johnsom : ^^ review requested :) | 08:57 |
*** openstackgerrit has quit IRC | 09:02 | |
*** yamamoto has quit IRC | 09:04 | |
*** csomerville has joined #openstack-lbaas | 09:09 | |
*** cody-somerville has quit IRC | 09:09 | |
*** reedip has quit IRC | 09:14 | |
*** cody-somerville has joined #openstack-lbaas | 09:35 | |
*** csomerville has quit IRC | 09:37 | |
rm_work | reedip_: right, my issue was that the default timeout should be *configurable* | 09:51 |
rm_work | not a constant at all | 09:51 |
rm_work | it should come in via the config file | 09:51 |
rm_work | and the default would be defined in config.py | 09:51 |
*** reedip has joined #openstack-lbaas | 09:53 | |
nmagnezi | rm_work, +1 | 09:59 |
nmagnezi | reedip, also 5000 looks like a very big value for default https://review.openstack.org/#/c/273896/28/neutron_lbaas/db/loadbalancer/models.py | 10:00 |
*** yamamoto has joined #openstack-lbaas | 10:03 | |
*** yamamoto has quit IRC | 10:07 | |
reedip | nmagnezi : sorry , just joined ... network lost.. can you repeat your previous comments if possible ? | 10:11 |
reedip | ( my other account is in India , and I didnt login to that system , so maybe that got the mesages :P ) | 10:11 |
nmagnezi | reedip, yes | 10:16 |
nmagnezi | <rm_work> reedip_: right, my issue was that the default timeout should be *configurable* | 10:16 |
nmagnezi | <rm_work> not a constant at all | 10:16 |
nmagnezi | <rm_work> it should come in via the config file | 10:16 |
nmagnezi | <rm_work> and the default would be defined in config.py | 10:16 |
nmagnezi | reedip, ^^ | 10:16 |
reedip | nmagnezi : right... got it ! | 10:16 |
reedip | will define in octavia's config file | 10:16 |
reedip | nmagnezi , rm_work : what do you think should be the default value if you think 5000 is a bit high | 10:17 |
nmagnezi | reedip, rm_work didn't say that this is too high, i did :D | 10:17 |
reedip | hehe ... I saw that, but thought mayve rm_work also stated that | 10:19 |
reedip | anyways nmagnezi : whats your opinion? | 10:20 |
reedip | 5000 seconds comes out to be >1.5 hours | 10:20 |
reedip | actually 1 hour 20 minutes ... 5400 is 1.5 hours | 10:20 |
nmagnezi | reedip, i'm going for a lunch break. will ping you right afterwards :) | 10:20 |
reedip | (wrong sign ... < 1.5 hours ) | 10:20 |
reedip | nmagnezi : sure thing... I will be right here :) | 10:21 |
*** yamamoto has joined #openstack-lbaas | 10:21 | |
*** yamamoto has quit IRC | 10:21 | |
rm_work | reedip: i don't know or care :P | 10:23 |
rm_work | it does seem long, but | 10:23 |
rm_work | honestly i feel like maybe default should be 0 | 10:23 |
rm_work | (unlimited) | 10:23 |
rm_work | I mean... ok, what is the haproxy default? | 10:23 |
rm_work | if you don't specify anything | 10:23 |
rm_work | that is the value I would go with, since in general they pick very sane defaults | 10:23 |
*** kobis has joined #openstack-lbaas | 10:27 | |
reedip | rm_work : hmm ... actually what I was thinking was keeping a very long ssh connection is also not right from security PoV | 10:29 |
rm_work | you keep saying SSH | 10:30 |
rm_work | but this is totally generic, right? | 10:30 |
rm_work | the parameter is for any type | 10:31 |
reedip | rm_work .... It is generic :) But the request was for ssh connections :D | 10:31 |
rm_work | yes, but 99% of LBs are HTTP(S) | 10:31 |
rm_work | so you're welcome to set whatever default YOU want, when using SSH | 10:31 |
rm_work | but the default should be sane for the 99% case | 10:31 |
rm_work | not the 1% case, even if the reason it is added was for that 1% | 10:31 |
reedip | Agreed ... | 10:33 |
reedip | ok, I will rework my patch | 10:34 |
rm_work | let me know when to review again :) | 10:39 |
rm_work | I'll be around for a while | 10:39 |
rm_work | like... 5 hours | 10:39 |
*** sanfern has quit IRC | 10:49 | |
reedip | I would be publishing it tomorrow morning ( 14 hours from now ) but would be looking at the review comments :) | 10:52 |
reedip | so I guess you can look at it peacefully tomorrow P:) | 10:52 |
rm_work | ok | 10:53 |
*** yamamoto has joined #openstack-lbaas | 11:22 | |
*** yamamoto has quit IRC | 11:30 | |
*** yamamoto has joined #openstack-lbaas | 11:41 | |
*** aojea has quit IRC | 11:45 | |
*** aojea has joined #openstack-lbaas | 11:46 | |
*** aojea has quit IRC | 11:50 | |
*** gongysh has quit IRC | 12:06 | |
*** sanfern has joined #openstack-lbaas | 12:10 | |
*** blogan has joined #openstack-lbaas | 12:16 | |
*** aojea has joined #openstack-lbaas | 12:43 | |
*** yamamoto has quit IRC | 12:55 | |
*** catintheroof has joined #openstack-lbaas | 12:57 | |
*** gongysh has joined #openstack-lbaas | 12:58 | |
*** bcafarel has quit IRC | 12:59 | |
*** bcafarel has joined #openstack-lbaas | 13:00 | |
*** links has quit IRC | 13:11 | |
*** KeithMnemonic1 has quit IRC | 13:15 | |
*** KeithMnemonic1 has joined #openstack-lbaas | 13:16 | |
*** KeithMnemonic1 has quit IRC | 13:17 | |
*** KeithMnemonic has joined #openstack-lbaas | 13:19 | |
*** matt-borland has joined #openstack-lbaas | 13:19 | |
*** krypto has joined #openstack-lbaas | 13:21 | |
*** armax has joined #openstack-lbaas | 13:53 | |
*** yamamoto has joined #openstack-lbaas | 13:55 | |
*** cpuga has joined #openstack-lbaas | 14:01 | |
*** cpuga has quit IRC | 14:02 | |
*** yamamoto has quit IRC | 14:04 | |
*** cody-somerville has quit IRC | 14:29 | |
*** krypto has quit IRC | 14:32 | |
*** krypto has joined #openstack-lbaas | 14:33 | |
*** krypto has quit IRC | 14:33 | |
*** krypto has joined #openstack-lbaas | 14:33 | |
*** openstackgerrit has joined #openstack-lbaas | 14:36 | |
openstackgerrit | Ankur proposed openstack/python-octaviaclient master: Trivial Fix https://review.openstack.org/447527 | 14:36 |
*** matt-borland has quit IRC | 14:36 | |
*** matt-borland has joined #openstack-lbaas | 14:37 | |
*** krypto has quit IRC | 14:38 | |
*** krypto has joined #openstack-lbaas | 14:39 | |
*** diltram has quit IRC | 14:44 | |
*** diltram has joined #openstack-lbaas | 14:44 | |
*** armax has quit IRC | 14:53 | |
*** Vorrtex has joined #openstack-lbaas | 15:15 | |
*** eezhova has quit IRC | 15:30 | |
*** chlong has joined #openstack-lbaas | 15:33 | |
*** armax has joined #openstack-lbaas | 15:33 | |
*** Vorrtex has left #openstack-lbaas | 15:42 | |
*** gongysh has quit IRC | 15:50 | |
*** links has joined #openstack-lbaas | 15:51 | |
*** links has quit IRC | 15:55 | |
*** links has joined #openstack-lbaas | 15:56 | |
*** gcheresh_ has quit IRC | 16:02 | |
*** armax has quit IRC | 16:05 | |
*** links has quit IRC | 16:05 | |
*** eezhova has joined #openstack-lbaas | 16:07 | |
*** tesseract has quit IRC | 16:15 | |
*** nrado has quit IRC | 16:17 | |
*** pcaruana has quit IRC | 16:27 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Adds v2 load balancer API section https://review.openstack.org/438757 | 16:43 |
rm_work | johnsom: do you have a goal for this week? | 16:43 |
rm_work | like... get at least the main patches for apiv2 wrapped up? | 16:44 |
johnsom | Yeah, finish at least the LB API Ref. Do you mean as a team? | 16:44 |
rm_work | yeah, teamwise | 16:44 |
johnsom | Yeah, I would like to see listener finished/merged. Pool would be good too | 16:44 |
johnsom | An get the scenario tests merged for this API | 16:45 |
johnsom | They aren't great/perfect, but it would be something more than we have now | 16:45 |
rm_work | yeah... | 16:47 |
rm_work | there's a bunch of comments on that i think | 16:48 |
rm_work | from diltram | 16:48 |
rm_work | and I kinda wish we were starting more minimal, rather than "here's aaaaall the stuff from neutron-lbaas"" | 16:49 |
johnsom | Well, we do need to basically start over with tempest in the new repo and use the "new" way of building these | 16:50 |
johnsom | Back in a few, I need to do a patch reboot | 16:52 |
rm_work | k | 17:03 |
johnsom | Back | 17:04 |
rm_work | johnsom: so ... i'm just gonna push a patchset to the listeners patch | 17:05 |
rm_work | nothing has happened on it in a bit, and it's sitting in merge conflict | 17:05 |
johnsom | sindhu Should be here | 17:06 |
johnsom | I guess it is lunch time there | 17:07 |
johnsom | It should be fine | 17:07 |
ankur-gupta-f4 | rm_work: +1 | 17:09 |
*** eezhova has quit IRC | 17:09 | |
*** eezhova has joined #openstack-lbaas | 17:20 | |
sindhu | rm_work: hi | 17:23 |
rm_work | hey | 17:23 |
rm_work | ah was just about to submit the fixed version | 17:23 |
rm_work | should i hold off? | 17:23 |
sindhu | if u have it ready pls go ahead | 17:23 |
rm_work | kk | 17:24 |
sindhu | did u have functional tests failing? | 17:25 |
rm_work | i'm running through the last of the testing now | 17:26 |
rm_work | believe that was fixed in my other patch that merged | 17:26 |
rm_work | mostly had to fix some pep8 | 17:26 |
rm_work | and somehow the loadbalancer endpoint got lost there | 17:27 |
sindhu | yeah | 17:27 |
sindhu | some of the functional tests are failing for me now | 17:27 |
rm_work | ah no, i see the functionals failing | 17:28 |
rm_work | i'll get it | 17:28 |
sindhu | which didn't earlier | 17:28 |
rm_work | yeah i think i know why | 17:28 |
rm_work | yep | 17:29 |
sindhu | something changed? or I missed something? | 17:29 |
rm_work | nah something changed under you | 17:31 |
rm_work | got it | 17:31 |
rm_work | ok, just making sure this all passes | 17:35 |
rm_work | hmm, there's a bunch of functional tests that just say "skip, needs work" | 17:35 |
rm_work | are you planning to ... work on them before we merge this? :P | 17:35 |
sindhu | so those are the ones that needs pool | 17:35 |
johnsom | Some of those are cross patch dependecies | 17:36 |
johnsom | They all should be tagged the same way with TODO so we can find them | 17:36 |
rm_work | kk | 17:36 |
rm_work | define "tagged with TODO" | 17:37 |
rm_work | right now it's just: self.skip('Skip, needs work') | 17:37 |
rm_work | for all of them | 17:37 |
rm_work | should I throw a todo in there? | 17:37 |
rm_work | tests all pass | 17:38 |
rm_work | johnsom: ^^ | 17:38 |
rm_work | i'm feeling impatient so i might just push it up as-is | 17:39 |
johnsom | Ha, can't even use the restroom... Yeah, just push it up, we can comment | 17:41 |
rm_work | lol | 17:41 |
rm_work | I mean, what TODO | 17:41 |
rm_work | would you like to see | 17:41 |
rm_work | @testtools.skip('Skip until complete v2 merge') | 17:42 |
rm_work | that maybe? | 17:42 |
rm_work | that is what the loadbalancer ones use | 17:42 |
*** chlong has quit IRC | 17:42 | |
johnsom | Yeah, that should be it | 17:42 |
johnsom | I would have to dig back to find it, but I think that was it | 17:43 |
*** krypto has quit IRC | 17:43 | |
johnsom | We just wanted to have something easily grep-able to find these once we land everything | 17:43 |
*** krypto has joined #openstack-lbaas | 17:43 | |
*** krypto has quit IRC | 17:43 | |
*** krypto has joined #openstack-lbaas | 17:43 | |
rm_work | k | 17:44 |
rm_work | switched them over to that | 17:44 |
johnsom | rm_work What are your thoughts on the /graph thing? Since we never published it (and it doesn't seem to work right now) I am tempted to drop all that and make single call create be just adding to the load balancer body. Thoughts? | 17:44 |
rm_work | yes | 17:44 |
rm_work | fucking yes | 17:44 |
johnsom | Nice. That is three cores leaning that way. I will work on clarifying that in the API docs I'm writing up. | 17:45 |
rm_work | the whole idea of a separate endpoint for that is painful to me | 17:45 |
johnsom | Me too | 17:45 |
johnsom | It's super ugly as implemented IMHO | 17:45 |
rm_work | so you also ran into the whole "oh, and it never actually worked" issue | 17:45 |
johnsom | Yeah, some strange transaction issue creating the VIP | 17:46 |
johnsom | blows up | 17:46 |
rm_work | hmm | 17:46 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Octavia v2 API for listeners https://review.openstack.org/424744 | 17:46 |
johnsom | RuntimeError: Method <function create_port at 0x7fa2d7a0b230> cannot be called within a transaction. | 17:47 |
rm_work | that's different than what I ran into I think >_> | 17:47 |
johnsom | This is neutron-lbaas side | 17:47 |
rm_work | rebasing the pools patch as well | 17:49 |
rm_work | and fixing the part where it skips ALL the tests >_> | 17:50 |
rm_work | actually as of the pools patch, it should be able to add the listener+pools tests] | 17:51 |
sindhu | rm_work: thanks for the patch :) | 17:52 |
rm_work | np, just looking forward to landing all this stuff. thanks for doing all the hard work :P | 17:54 |
sindhu | rm_work: :) | 17:56 |
*** sanfern has quit IRC | 18:03 | |
*** catintheroof has quit IRC | 18:08 | |
*** catintheroof has joined #openstack-lbaas | 18:08 | |
*** blogan has quit IRC | 18:17 | |
*** armax has joined #openstack-lbaas | 18:18 | |
*** blogan has joined #openstack-lbaas | 18:18 | |
*** eezhova has quit IRC | 18:22 | |
*** blogan has quit IRC | 18:35 | |
rm_work | ok this one had some issues, took a little more work | 18:36 |
rm_work | getting there | 18:36 |
*** blogan has joined #openstack-lbaas | 18:39 | |
sshank | rm_work, Sorry. I was waiting for the listeners to be rebased. | 18:40 |
rm_work | ahh no worries | 18:40 |
rm_work | actually, i was really only meaning to rebase this | 18:41 |
rm_work | but it turned into working on it a bit T_T | 18:41 |
rm_work | didn't intend to take over your patch | 18:41 |
rm_work | i can let you do it | 18:41 |
johnsom | Ugh, this stuff is muddy. Health checks, we really should have HTTPS and TLS or SSL, where HTTPS actually does HTTP over TLS and "TLS" just does the hello check. | 18:41 |
rm_work | it's ... a bit of fixes though, as you can't use self.* to store things like loadbalancer_id / listener_id when you are in a controller | 18:42 |
rm_work | because they carry across requests | 18:42 |
rm_work | which is not good | 18:42 |
sshank | yeah. Brandon had suggested to not store those and instead pass it as args into the methods which use them | 18:42 |
rm_work | yes | 18:44 |
rm_work | should i let you handle this? | 18:46 |
rm_work | I would say I am about halfway done now, but i can either finish this, or sleep :P | 18:47 |
sshank | I can do it. | 18:47 |
sshank | But if you have done it half, you can continue as well. I am okay with anything. | 18:47 |
rm_work | maybe update that to "almost done" | 18:50 |
rm_work | so i can prolly just wrap this up if you don't mind :) | 18:51 |
rm_work | i'm used to working really closely with folks so sometimes i don't even think about it when i just start hacking on a patch >_< | 18:51 |
rm_work | yep, done | 18:54 |
rm_work | just running tests | 18:54 |
rm_work | sshank: ^^ | 18:54 |
sshank | Ok | 18:55 |
sshank | No problem. :) | 18:55 |
rm_work | still needs to be gone through with a fine tooth comb | 18:55 |
rm_work | i just kinda fixed the obvious stuff with the merge and with that issue | 18:55 |
rm_work | there could still be bugs | 18:55 |
rm_work | pools patch actually ends up fixing some stuff that we should have caught on the LB patch >_> ah well | 18:57 |
rm_work | i'll stop after this one and let you guys get the rest of them >_> | 18:59 |
sshank | Ok. I'll look into it as well. | 18:59 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Introduce Octavia v2 API for pools https://review.openstack.org/405922 | 18:59 |
*** armax has quit IRC | 19:01 | |
rm_work | ahhh lol just noticed the pools patch was using v1 members until we added the v2 member controllers as the next CR :P | 19:01 |
rm_work | good thing i didn't dive into the member stuff | 19:02 |
rm_work | who was doing the members patch | 19:02 |
rm_work | was that sindhu ? | 19:02 |
ankur-gupta-f4 | members is either ndahiwade or sshank | 19:03 |
sindhu | rm_work: all the patches are under my name but I am working only on Listener and Health Monitor | 19:03 |
sshank | ndahiwade, Was talking care of members | 19:04 |
rm_work | ok | 19:04 |
sshank | taking* | 19:04 |
rm_work | trying VERY hard not to do the rebase on that one right now too | 19:04 |
ndahiwade | rm_work: Members and L7policy are mine | 19:04 |
rm_work | ndahiwade: you can go ahead and rebase :) | 19:04 |
rm_work | listeners/pools are up to date now | 19:04 |
ndahiwade | rm_work, will do :) | 19:04 |
ndahiwade | thanks:) | 19:04 |
rm_work | ndahiwade: out of curiosity, in the controllers/__init__.py why did you move the endpoints out of the base and into both LBaaSController and V2Controller? | 19:08 |
rm_work | seemed like __init__.py was fine untouched | 19:08 |
rm_work | ndahiwade: oh and note that delete is status 204 not 202 | 19:09 |
rm_work | ndahiwade: unless you are busy with other things, then i am perfectly happy to do that rebase too :P | 19:12 |
ndahiwade | rm_work: I was looking into other stuff, but I am good with anything :) | 19:13 |
rm_work | lol k if you are on other stuff I can do it really quick | 19:13 |
rm_work | I am really wired right now for some reason and just chugging through these >_< | 19:14 |
ndahiwade | rm_work: sure go ahead:) | 19:14 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Introduce Octavia v2 API for Members https://review.openstack.org/405932 | 19:15 |
ndahiwade | rm_work: I had moved the endpoints to both LBaas and V2 controllers because of Brandon's patch : https://review.openstack.org/#/c/430455/ | 19:19 |
rm_work | hmm | 19:19 |
ndahiwade | But i am not sure we are moving ahead with that | 19:19 |
rm_work | i just cancelled the changes to that file for now | 19:20 |
rm_work | we can go back and fix it once at the end if we want to | 19:20 |
rm_work | but yeah that patch looks ... dead maybe? | 19:20 |
ndahiwade | rm_work, yes it does | 19:21 |
rm_work | err... i mean, it just looks straight up wrong right now | 19:21 |
rm_work | removes everything? | 19:21 |
rm_work | <_< | 19:21 |
ndahiwade | rm_work, So we'll stick with all three in the __init__? | 19:22 |
ndahiwade | BaseV2, Lbaas, V2 | 19:22 |
*** aojea has quit IRC | 19:22 | |
*** aojea has joined #openstack-lbaas | 19:22 | |
rm_work | i mean | 19:23 |
rm_work | we can fix it at the end | 19:23 |
rm_work | that's what he was doing | 19:23 |
ndahiwade | rm_work, yes, agreed | 19:23 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Introduce Octavia v2 API for Health Monitor https://review.openstack.org/406256 | 19:26 |
rm_work | woo rebase button worked | 19:26 |
ankur-gupta-f4 | best feeling | 19:26 |
*** aojea has quit IRC | 19:27 | |
rm_work | but, that HM patch needs some work | 19:28 |
rm_work | same issue as the pools one -- can't be using self to store stuff in controllers | 19:28 |
rm_work | who was HM? sindhu? | 19:32 |
sindhu | rm_work: yes | 19:33 |
sindhu | rm_work: that needs work | 19:33 |
rm_work | or was it you ankur-gupta-f4 | 19:33 |
sindhu | rm_work: it needed DB migration | 19:33 |
sindhu | rm_work: which got merged recently | 19:33 |
rm_work | yep! woo | 19:33 |
sindhu | rm_work: will work on the remaining required work now | 19:34 |
rm_work | cool cool | 19:34 |
rm_work | REALLY want to try to get ALL of these (at least the initial patches) merged this week | 19:34 |
rm_work | ah ndahiwade I promise I am not doing anything to the L7 ones, so if you have time to get to those, awesome | 19:35 |
rm_work | i'm out for now | 19:35 |
sindhu | rm_work: you are on a roll :) | 19:35 |
ankur-gupta-f4 | rm_work: | 19:35 |
ankur-gupta-f4 | we need to tackle listeners and pools first | 19:35 |
rm_work | yeah | 19:35 |
rm_work | I got those rebased, passing tests, and mostly fixed up for the stuff i saw | 19:36 |
rm_work | I am hoping they are very close to good | 19:36 |
ankur-gupta-f4 | hmmm. its questionable | 19:36 |
rm_work | yes :P | 19:36 |
rm_work | i mean, i only looked at them very briefly | 19:36 |
rm_work | the tests were pretty good though, caught some stuff | 19:37 |
ankur-gupta-f4 | since the listener/pool patch also needs to un-skip the skipped tests for the load_balancer controller. and need to make sure the lb controller returns the right stuff based on the listeners and pool controllers | 19:37 |
rm_work | I figured we'd go through and unskip everything at the end | 19:37 |
ankur-gupta-f4 | i mean it should be sequential | 19:37 |
rm_work | rather than try to figure out on each patch what more can be unskipped | 19:37 |
ankur-gupta-f4 | shouldn't be too hard | 19:37 |
rm_work | but yeah, you are probably right | 19:37 |
ankur-gupta-f4 | if the listeners scenario tests are passing and returning the right info | 19:38 |
ankur-gupta-f4 | the un-skipped tests should also pass | 19:38 |
rm_work | need to actually run scenarios against them | 19:38 |
rm_work | i haven't tested this stuff in devstack yet | 19:38 |
ankur-gupta-f4 | haha | 19:38 |
ankur-gupta-f4 | k boarding. catch up Wednesday | 19:39 |
rm_work | yeah sleeping, same | 19:39 |
rm_work | err well, tomorrow in my case :P | 19:39 |
*** eezhova has joined #openstack-lbaas | 19:40 | |
*** eezhova has quit IRC | 19:43 | |
*** nrado has joined #openstack-lbaas | 19:51 | |
*** matt-borland has quit IRC | 19:54 | |
*** gcheresh_ has joined #openstack-lbaas | 19:57 | |
ndahiwade | rm_work, sure will do. thanks :) | 19:57 |
*** rstarmer has joined #openstack-lbaas | 20:01 | |
*** rstarmer has quit IRC | 20:02 | |
diltram | johnsom: do we have some problem with DIB currently? | 20:11 |
johnsom | I am not sure, it was Friday last time I stacked | 20:12 |
diltram | diskimage_builder.element_dependencies.InvalidElementDir: ELEMENTS_PATH entry '/opt/stack/diskimage-builder' is not a directory | 20:12 |
diltram | and there is no /opt/stack/diskimage-builder dir | 20:12 |
johnsom | Yeah, it isn't used anymore | 20:13 |
johnsom | Ankur saw that last week, I did not. Is it DIB code or something in ours? Gate or local? | 20:13 |
diltram | local | 20:14 |
diltram | our diskaimge-builder.sh is throwing that | 20:14 |
johnsom | Hmm | 20:14 |
johnsom | I am making lunch at the moment, but can look at it with you after if you want | 20:14 |
diltram | johnsom: http://paste.openstack.org/show/603492/ | 20:15 |
diltram | ok, I'm going home to eat something too | 20:15 |
diltram | I will ping you later :) | 20:15 |
*** dlundqui1 has joined #openstack-lbaas | 20:18 | |
*** sbalukoff_ has joined #openstack-lbaas | 20:18 | |
diltram | johnsom: found bug | 20:19 |
diltram | will send to review later | 20:19 |
*** Aju has joined #openstack-lbaas | 20:21 | |
*** jmccrory_ has joined #openstack-lbaas | 20:22 | |
*** aojea has joined #openstack-lbaas | 20:23 | |
*** lunarlamp has joined #openstack-lbaas | 20:24 | |
*** markd_ has joined #openstack-lbaas | 20:26 | |
*** armax has joined #openstack-lbaas | 20:26 | |
*** aojea has quit IRC | 20:28 | |
*** krypto has quit IRC | 20:29 | |
*** dlundquist has quit IRC | 20:29 | |
*** mdavidson has quit IRC | 20:29 | |
*** jmccrory has quit IRC | 20:29 | |
*** sbalukoff has quit IRC | 20:29 | |
*** afranc has quit IRC | 20:29 | |
*** mariusv has quit IRC | 20:29 | |
*** jmccrory_ is now known as jmccrory | 20:29 | |
*** lunarlamp is now known as mariusv | 20:29 | |
*** eezhova has joined #openstack-lbaas | 20:31 | |
openstackgerrit | Reedip proposed openstack/octavia master: Introduce Octavia v2 API for Health Monitor https://review.openstack.org/406256 | 20:34 |
reedip | rm_work, sindhu : changed some minor stuff ^^ | 20:34 |
sindhu | reedip: will look into it | 20:35 |
reedip | :) | 20:35 |
rm_work | ^^ still need to fix the self.* issue | 20:36 |
openstackgerrit | Nakul Dahiwade proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Policy https://review.openstack.org/406328 | 20:36 |
reedip | rm_work : mentioned that in the updated comments :) | 20:37 |
rm_work | lol k | 20:37 |
rm_work | i was too quick | 20:37 |
rm_work | i'm out tho, catch you tomorrow | 20:38 |
reedip | rm_work : If we only need to remove it because its set to None, then it can be done.... | 20:38 |
reedip | rm_work .. okay, sure :) | 20:38 |
rm_work | ah, no | 20:38 |
rm_work | everywhere that uses that as well | 20:38 |
reedip | I know, its not as simple as it sounds :D | 20:38 |
rm_work | right | 20:38 |
rm_work | i did it for pools | 20:38 |
rm_work | it might be very similar | 20:38 |
reedip | thats why I pinged the author ( sindhu ) | 20:38 |
reedip | :) | 20:38 |
rm_work | can look at how I changed pools in the latest patchset | 20:39 |
nmagnezi | o/ | 20:39 |
rm_work | https://review.openstack.org/#/c/405922/40..41/octavia/api/v2/controllers/pool.py | 20:39 |
reedip | rm_work : yeah checking that | 20:39 |
reedip | nmagnezi: \o/ | 20:40 |
*** KeithMnemonic1 has joined #openstack-lbaas | 20:40 | |
nmagnezi | reedip, ¯\_(ツ)_/¯ | 20:40 |
reedip | lol :) | 20:40 |
nmagnezi | reedip, i forgot to ping you back about the default value :< | 20:41 |
*** KeithMnemonic has quit IRC | 20:42 | |
reedip | nmagnezi : no issues, I just woke up ( its 4:00 AM here :D ) | 20:43 |
reedip | lemme know your opinion | 20:43 |
nmagnezi | reedip, oh so you are like rm_work.. you never sleep :) | 20:43 |
reedip | i dont know about rm_work , but I woke up bcz its chilly nmagnezi :D | 20:44 |
rm_work | ah heh, reedip it is 5:45am here :P | 20:44 |
rm_work | but this is just when I work >_> | 20:44 |
nmagnezi | it is 22:45 here :D | 20:44 |
reedip | rm_work : whats ur time zone ? | 20:45 |
rm_work | JST | 20:45 |
reedip | seems to be JST | 20:45 |
reedip | :) | 20:45 |
reedip | I guessed right :D | 20:45 |
openstackgerrit | Nakul Dahiwade proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Policy https://review.openstack.org/406328 | 20:49 |
*** aojea has joined #openstack-lbaas | 20:54 | |
*** aojea has quit IRC | 21:11 | |
*** aojea has joined #openstack-lbaas | 21:12 | |
*** aojea has quit IRC | 21:16 | |
*** amotoki has joined #openstack-lbaas | 21:23 | |
*** aojea has joined #openstack-lbaas | 21:25 | |
*** gcheresh_ has quit IRC | 21:28 | |
*** fnaval has joined #openstack-lbaas | 21:31 | |
openstackgerrit | Lubosz Kosnik (diltram) proposed openstack/octavia master: Remove local DIB elements dir https://review.openstack.org/447701 | 21:31 |
*** eezhova has quit IRC | 21:32 | |
*** fnaval has quit IRC | 21:41 | |
openstackgerrit | Nakul Dahiwade proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Policy https://review.openstack.org/406328 | 21:45 |
nmagnezi | johnsom, o/ | 21:55 |
johnsom | nmagnezi Hello | 21:55 |
nmagnezi | johnsom, hey Michael | 21:55 |
nmagnezi | johnsom, how are you? | 21:55 |
johnsom | I am well for a Monday afternoon, you? | 21:55 |
nmagnezi | I'm well for Monday night :) | 21:56 |
nmagnezi | johnsom, I'm having some issues with amphora images, which makes it a bit hard for me to debug stuff, maybe you'll know better | 21:57 |
nmagnezi | for each image I create | 21:57 |
nmagnezi | either ubuntu or centos/fedora/rhel | 21:57 |
nmagnezi | dns seems to be completely disabled from inside the instance | 21:58 |
johnsom | Yes, we do that on purpose | 21:58 |
nmagnezi | why? and how can I enable it? (for development) | 21:58 |
nmagnezi | I don't know how you did it but it was done very well.. :D | 21:59 |
johnsom | We did it because the design of our amps/load balancers does not use DNS names, we only accept IP addresses. However, many other services on the amps attempt to look up names even though there is no DNS server available to them (not all amps have interfaces on the internet for example). These services slow down startup and logins among other issues, so | 22:01 |
johnsom | instead of trying to go service by service disabling DNS lookups (likely missing some) we decided to overall disable DNS in the image. | 22:01 |
reedip | speaking of DNS | 22:02 |
johnsom | nmagnezi This is the how part: https://github.com/openstack/octavia/tree/master/elements/no-resolvconf | 22:02 |
reedip | https://review.openstack.org/#/c/404774/ :) | 22:02 |
johnsom | reedip lol | 22:02 |
nmagnezi | johnsom, sounds reasonable. actually even as smart optimization. | 22:02 |
johnsom | Nice one | 22:02 |
nmagnezi | johnsom, thank you! | 22:02 |
johnsom | reedip After I am done with this section of the doc I am working on, I will spin a new VM and test the parts I am worried about. | 22:05 |
johnsom | At the moment I am a bit deep into single-call-create documentation | 22:06 |
*** aojea has quit IRC | 22:19 | |
*** aojea has joined #openstack-lbaas | 22:20 | |
*** aojea has quit IRC | 22:24 | |
*** amotoki has quit IRC | 22:41 | |
*** catintheroof has quit IRC | 23:13 | |
openstackgerrit | Nir Magnezi proposed openstack/octavia master: Auto detect haproxy user_group https://review.openstack.org/429398 | 23:22 |
*** gongysh has joined #openstack-lbaas | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!