*** reedip has joined #openstack-lbaas | 00:25 | |
*** aojea has joined #openstack-lbaas | 00:30 | |
*** aojea has quit IRC | 00:35 | |
*** sanfern has quit IRC | 01:38 | |
*** reedip has quit IRC | 01:40 | |
*** rcernin has joined #openstack-lbaas | 01:58 | |
*** reedip has joined #openstack-lbaas | 01:59 | |
reedip | o/ | 02:04 |
---|---|---|
*** yamamoto has joined #openstack-lbaas | 02:29 | |
*** amotoki has joined #openstack-lbaas | 02:39 | |
*** rcernin has quit IRC | 02:45 | |
*** cody-somerville has joined #openstack-lbaas | 02:46 | |
*** csomerville has quit IRC | 02:49 | |
*** sanfern has joined #openstack-lbaas | 02:53 | |
*** catintheroof has joined #openstack-lbaas | 02:55 | |
*** ducttape_ has joined #openstack-lbaas | 02:57 | |
*** ducttape_ has quit IRC | 02:58 | |
*** ducttape_ has joined #openstack-lbaas | 02:58 | |
*** amotoki has quit IRC | 03:00 | |
*** ducttape_ has quit IRC | 03:17 | |
*** amotoki has joined #openstack-lbaas | 03:20 | |
*** fnaval has joined #openstack-lbaas | 03:20 | |
*** ducttape_ has joined #openstack-lbaas | 03:22 | |
*** fnaval_ has quit IRC | 03:24 | |
*** ducttape_ has quit IRC | 03:24 | |
*** ducttape_ has joined #openstack-lbaas | 03:24 | |
*** amotoki has quit IRC | 03:29 | |
*** yamamoto has quit IRC | 03:37 | |
*** amotoki has joined #openstack-lbaas | 03:38 | |
*** ducttape_ has quit IRC | 03:41 | |
*** ducttape_ has joined #openstack-lbaas | 03:48 | |
*** reedip has quit IRC | 03:52 | |
*** ducttape_ has quit IRC | 03:55 | |
*** reedip has joined #openstack-lbaas | 04:00 | |
*** amotoki has quit IRC | 04:01 | |
*** amotoki has joined #openstack-lbaas | 04:08 | |
*** catintheroof has quit IRC | 04:10 | |
*** yamamoto has joined #openstack-lbaas | 04:16 | |
*** ducttape_ has joined #openstack-lbaas | 04:48 | |
*** cody-somerville has quit IRC | 04:51 | |
*** ducttape_ has quit IRC | 04:53 | |
*** rcernin has joined #openstack-lbaas | 04:56 | |
*** fnaval has quit IRC | 04:58 | |
*** rcernin has quit IRC | 05:18 | |
*** rcernin has joined #openstack-lbaas | 05:31 | |
*** gcheresh_ has joined #openstack-lbaas | 05:53 | |
*** oomichi has quit IRC | 06:03 | |
*** oomichi has joined #openstack-lbaas | 06:04 | |
*** IRCFrEAK has joined #openstack-lbaas | 06:05 | |
*** IRCFrEAK has left #openstack-lbaas | 06:06 | |
*** yuanying has quit IRC | 06:07 | |
*** yuanying_ has joined #openstack-lbaas | 06:13 | |
*** kobis has joined #openstack-lbaas | 06:14 | |
*** ducttape_ has joined #openstack-lbaas | 06:18 | |
*** ducttape_ has quit IRC | 06:23 | |
*** oomichi has quit IRC | 06:29 | |
*** oomichi has joined #openstack-lbaas | 06:30 | |
*** voelzmo has joined #openstack-lbaas | 06:31 | |
*** sputnik13 has quit IRC | 06:32 | |
*** sputnik13 has joined #openstack-lbaas | 06:34 | |
*** tesseract has joined #openstack-lbaas | 06:34 | |
*** bzhao has joined #openstack-lbaas | 06:35 | |
*** bbzhao has quit IRC | 06:38 | |
*** voelzmo has quit IRC | 06:38 | |
*** voelzmo has joined #openstack-lbaas | 06:42 | |
*** pcaruana has joined #openstack-lbaas | 06:57 | |
*** fnaval has joined #openstack-lbaas | 06:59 | |
*** fnaval has quit IRC | 07:03 | |
*** aojea has joined #openstack-lbaas | 07:21 | |
*** amotoki_ has joined #openstack-lbaas | 07:41 | |
*** amotoki has quit IRC | 07:44 | |
*** ducttape_ has joined #openstack-lbaas | 07:49 | |
*** ducttape_ has quit IRC | 07:54 | |
*** openstackgerrit has quit IRC | 08:03 | |
*** belharar has joined #openstack-lbaas | 08:15 | |
*** belharar has quit IRC | 08:16 | |
*** belharar has joined #openstack-lbaas | 08:17 | |
*** aojea_ has joined #openstack-lbaas | 08:21 | |
*** aojea has quit IRC | 08:24 | |
*** reedip has quit IRC | 08:28 | |
*** sanfern has quit IRC | 08:32 | |
*** mjblack has quit IRC | 08:33 | |
*** mjblack has joined #openstack-lbaas | 08:38 | |
*** sanfern has joined #openstack-lbaas | 09:01 | |
*** bcafarel has quit IRC | 09:06 | |
*** reedip has joined #openstack-lbaas | 09:08 | |
*** belharar has quit IRC | 09:14 | |
*** ducttape_ has joined #openstack-lbaas | 09:20 | |
*** ducttape_ has quit IRC | 09:24 | |
*** amotoki_ has quit IRC | 09:25 | |
*** bcafarel has joined #openstack-lbaas | 10:00 | |
*** gcheresh has joined #openstack-lbaas | 10:02 | |
*** gcheresh_ has quit IRC | 10:02 | |
*** rcernin has quit IRC | 10:05 | |
*** krypto has joined #openstack-lbaas | 10:13 | |
*** krypto has joined #openstack-lbaas | 10:13 | |
*** openstackgerrit has joined #openstack-lbaas | 10:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas master: Imported Translations from Zanata https://review.openstack.org/449037 | 10:13 |
*** rcernin has joined #openstack-lbaas | 10:24 | |
*** ducttape_ has joined #openstack-lbaas | 10:50 | |
*** sanfern has quit IRC | 10:54 | |
*** ducttape_ has quit IRC | 10:55 | |
*** fnaval has joined #openstack-lbaas | 11:01 | |
*** fnaval has quit IRC | 11:06 | |
*** gcheresh_ has joined #openstack-lbaas | 11:24 | |
*** gcheresh has quit IRC | 11:24 | |
*** voelzmo has quit IRC | 11:52 | |
*** voelzmo has joined #openstack-lbaas | 11:53 | |
*** sanfern has joined #openstack-lbaas | 12:19 | |
*** ducttape_ has joined #openstack-lbaas | 12:20 | |
*** _ducttape_ has joined #openstack-lbaas | 12:24 | |
*** ducttape_ has quit IRC | 12:28 | |
sanfern | Hi All, I want to send my amphora haproxy logs to splunk/graylog, Do we have hooks to enable this? | 12:38 |
*** mjblack has quit IRC | 12:52 | |
*** mjblack has joined #openstack-lbaas | 12:55 | |
*** _ducttape_ has quit IRC | 13:02 | |
*** voelzmo has quit IRC | 13:03 | |
*** sanfern has quit IRC | 13:04 | |
*** sanfern has joined #openstack-lbaas | 13:04 | |
*** krypto has quit IRC | 13:24 | |
xgerman | no | 13:28 |
xgerman | but you are welcome to contribute those ;-) | 13:28 |
xgerman | overall, we sue oslo logging so whatever works with that should work with us | 13:29 |
*** catintheroof has joined #openstack-lbaas | 13:31 | |
nmagnezi | xgerman, i think that specifically for haproxy logs we simply use https://github.com/openstack/octavia/blob/master/elements/haproxy-octavia-ubuntu/post-install.d/20-setup-haproxy-log , no? | 13:33 |
nmagnezi | xgerman, i might be wrong here.. just asking :) | 13:33 |
*** voelzmo has joined #openstack-lbaas | 13:33 | |
xgerman | well, if you move all the haproxy logs into splunk, et. al. - first they are a ton and 2nd for multi tenant you need really good access controls | 13:37 |
xgerman | I was thinking he wanted the octavia logs… | 13:38 |
*** ducttape_ has joined #openstack-lbaas | 13:38 | |
*** ipsecguy has quit IRC | 13:40 | |
*** ipsecguy has joined #openstack-lbaas | 13:45 | |
*** ducttape_ has quit IRC | 13:51 | |
reedip | ...o... | 13:54 |
*** voelzmo has quit IRC | 14:00 | |
*** amotoki has joined #openstack-lbaas | 14:05 | |
*** voelzmo has joined #openstack-lbaas | 14:08 | |
*** voelzmo has quit IRC | 14:08 | |
*** reedip has quit IRC | 14:13 | |
*** voelzmo has joined #openstack-lbaas | 14:14 | |
*** ducttape_ has joined #openstack-lbaas | 14:18 | |
*** amotoki has quit IRC | 14:25 | |
*** reedip has joined #openstack-lbaas | 14:26 | |
openstackgerrit | Merged openstack/octavia master: Updated from global requirements https://review.openstack.org/452479 | 14:28 |
openstackgerrit | Merged openstack/octavia master: Move API v1, v2 hooks to API Common https://review.openstack.org/448288 | 14:29 |
*** ducttape_ has quit IRC | 14:30 | |
sanfern | xgerman, Thanks. I am looking for adding entry into "log {{spunk server ip : port }} syslog info" for haproxy.cfg file | 14:34 |
xgerman | mmh, our default image does not support logging to a central server at all since we didn’t want to open up the network in that (+evertbodt logs differently) | 14:36 |
*** ducttape_ has joined #openstack-lbaas | 14:36 | |
sanfern | this splunk or graylog server details define in octavia.conf | 14:37 |
xgerman | octavia conf takes oslo logging directives | 14:37 |
*** blogan_ is now known as blogan | 14:38 | |
johnsom | You could add a section to octavi.conf that gets passed down into the amphora agent conf that specifies how to configure haproxy to log. Since haproxy.cfg is generated you pretty much have to do that | 14:41 |
johnsom | Or you could just add it to the jinja template to hard code it | 14:42 |
*** ipsecguy has quit IRC | 14:42 | |
*** chlong has joined #openstack-lbaas | 14:45 | |
xgerman | we probably should document that in some way if gaproxy logging is becoming popular | 14:46 |
sanfern | johnsom, to pass the value from octavia.conf to jinja requires change in octavia code | 14:47 |
*** ipsecguy has joined #openstack-lbaas | 14:47 | |
xgerman | yes | 14:48 |
johnsom | Correct | 14:48 |
xgerman | but you could make a patch that it bcomes configurable | 14:48 |
johnsom | Figuring out logging is a research topic for Pike | 14:48 |
xgerman | not sure if we want to log the haproxy logs… but *shrug* | 14:49 |
johnsom | If the target is fixed you can just edit the jinja, but if you need to change it, that is code | 14:52 |
sanfern | server can be changed to different depending on type of workload or cloud. | 14:55 |
*** gcheresh_ has quit IRC | 14:57 | |
*** amotoki has joined #openstack-lbaas | 14:59 | |
*** _ducttape_ has joined #openstack-lbaas | 15:00 | |
*** voelzmo has quit IRC | 15:01 | |
*** voelzmo has joined #openstack-lbaas | 15:02 | |
*** voelzmo has quit IRC | 15:02 | |
*** ducttape_ has quit IRC | 15:03 | |
xgerman | DNS? | 15:07 |
johnsom | DNS is disabled in the amps | 15:21 |
*** _ducttape_ has quit IRC | 15:21 | |
*** ducttape_ has joined #openstack-lbaas | 15:22 | |
xgerman | joking :-) Though somebody was working on making DNS work… | 15:23 |
*** fnaval has joined #openstack-lbaas | 15:25 | |
reedip | who said dns ? | 15:27 |
rm_work | yeah it would be very easy to edit the jinja template that creates the haproxy.conf | 15:27 |
rm_work | we designed it to be very simple for an operator to customize those | 15:27 |
xgerman | yeah, indeed | 15:28 |
xgerman | or we push that etcd pie-in-the-sky OpenStack service | 15:29 |
*** tesseract has quit IRC | 15:31 | |
diltram | johnsom: so we finally know that centos is still not working :P | 15:33 |
johnsom | Ha, is it the group setting I wonder? | 15:34 |
rm_work | centos is working for me | 15:34 |
rm_work | I am using it in GD cloud | 15:34 |
diltram | it's something with amphora-agent | 15:34 |
diltram | rm_work: as amphora base os? | 15:34 |
rm_work | yes | 15:35 |
diltram | weird | 15:35 |
diltram | as on our gates it's not working | 15:35 |
rm_work | just have to set the user_group thing | 15:35 |
rm_work | until nmagnezi's patch merges | 15:35 |
diltram | aaa, ok | 15:35 |
rm_work | which we just spent many hours discussing yesterday :P | 15:35 |
xgerman | what? On a Sunday> | 15:36 |
xgerman | ? | 15:36 |
diltram | so I should make a patch which sets this direclty or we gonna wait for merge? | 15:36 |
xgerman | you have the change-id so we can speed up merging? | 15:36 |
johnsom | Let's wait for the fix | 15:36 |
xgerman | +1 | 15:37 |
*** kobis has quit IRC | 15:37 | |
rm_work | yeah I was working all weekend :/ | 15:38 |
rm_work | xgerman: well, per discussion, he's looking to rework it | 15:38 |
rm_work | johnsom: i don't know if you read any of that scrollback | 15:38 |
*** amotoki has quit IRC | 15:39 | |
rm_work | can we merge https://review.openstack.org/#/c/405932/ today I hope? | 15:40 |
rm_work | it should be good | 15:40 |
rm_work | and https://review.openstack.org/#/c/406328/ is ready for review, as is https://review.openstack.org/#/c/406336/ | 15:40 |
rm_work | L7Policy / L7Rule | 15:41 |
xgerman | ok, I will look over them | 15:41 |
rm_work | there's some stuff in the migration that is a little ... mixed together | 15:41 |
rm_work | but i opted for fewer migrations | 15:41 |
rm_work | because they are annoying to deal with | 15:41 |
rm_work | johnsom: i fixed all the stuff you mentioned, since there was enough material to justify a new patchset :/ | 15:42 |
rm_work | and since it was obvious we weren't merging on friday | 15:43 |
johnsom | Yeah, I see that. Just looking it over now | 15:43 |
xgerman | when are the filters showing up? | 15:43 |
rm_work | xgerman: after we get all of this merged | 15:43 |
rm_work | and then the pagination patch | 15:43 |
xgerman | ok | 15:43 |
rm_work | which is also close | 15:43 |
rm_work | but i need to rebase it on L7Policy/Rule | 15:43 |
xgerman | my plugin-proxy doesn’t work well without filters | 15:43 |
rm_work | the faster we can get some of these merged, the faster I will get to filters :P | 15:44 |
johnsom | +2 again on members from me | 15:44 |
*** aojea_ has quit IRC | 15:45 | |
diltram | rm_work: commented on the Nirs patch, I completely agree with your idea. It should be configured in dib on backing image stage | 15:45 |
diltram | and it's all | 15:45 |
diltram | we can deprecate the config and not use it any more | 15:46 |
rm_work | yes | 15:47 |
diltram | johnsom: spining up devstack with members | 15:47 |
johnsom | +1 | 15:47 |
rm_work | i am sad i didn't look at it a while back and comment, because i have been feeling that it MUST be way overcomplicated for a while | 15:48 |
rm_work | it would be super neat if we could look at both L7s today too | 15:52 |
*** pcaruana has quit IRC | 15:53 | |
johnsom | Yeah, I started on L7 policy Friday, good to know both are ready for a pass | 15:57 |
rm_work | yeah i spent a lot of time this weekend getting those up to speed | 15:58 |
*** ipsecguy has quit IRC | 15:58 | |
*** ipsecguy has joined #openstack-lbaas | 15:58 | |
xgerman | sorry, rm_work | 16:00 |
rm_work | no worries, i had nothing better to do | 16:01 |
johnsom | HA, that global requirements patch... The list of exclusions for DIB should say something about it's recent stability | 16:01 |
openstackgerrit | Ankur proposed openstack/python-octaviaclient master: Initialize plugin for OSC https://review.openstack.org/446223 | 16:01 |
xgerman | rm_work found some nits on members | 16:01 |
rm_work | was stuck in an AirBnB with shitty internet so I couldn't play games or anything :P | 16:02 |
xgerman | :-( | 16:02 |
rm_work | johnsom: heh yeah i was looking at that and how it'll work with the cherry-pick for dib in ocata | 16:02 |
*** cody-somerville has joined #openstack-lbaas | 16:02 | |
rm_work | johnsom: wasn't going to touch it just yet | 16:02 |
rm_work | xgerman: no worries i'll take a look | 16:02 |
johnsom | I shouldn't touch it. Don't want to skew the metrics | 16:02 |
xgerman | lol | 16:03 |
xgerman | I think contributors should weight more than people reviewing… | 16:03 |
johnsom | Sigh, yes. One out of eight metrics and you drop the tag.... | 16:05 |
reedip | ankur-gupta-f4 :any advances with the OSC? | 16:05 |
xgerman | well, TC elections are coming up - we can run on. a platform to chnage metrics ;-) | 16:06 |
johnsom | Hahahaha | 16:06 |
ankur-gupta-f4 | reedip: yea. It runs, the two tests pass. Feel free to review | 16:07 |
reedip | D | 16:07 |
johnsom | Well, if we mirror "other" politics, we would only change the metrics for nova/neutron/keystone and leave it for the other projects | 16:07 |
reedip | so the test-requirements worked | 16:07 |
ankur-gupta-f4 | yea jenkins passing i think | 16:08 |
reedip | :) | 16:08 |
reedip | kk | 16:08 |
xgerman | rm_work living out my nits; not sure how your system works but whoever tests L7 should try a position > MAX_INT and see if the error message makes sense | 16:16 |
xgerman | of course I could pull the patch and look myself ;-) | 16:16 |
johnsom | I tried the range validation on a previous patch and it was reasonable | 16:16 |
johnsom | But, yes, ^^^^ That.... Grin | 16:17 |
rm_work | xgerman: the tests actually do this | 16:29 |
rm_work | xgerman: and you can see i think just from looking at the test code | 16:29 |
rm_work | it checks for the string | 16:29 |
xgerman | the tests I saw did put in like “test” when an integer value was asked | 16:30 |
xgerman | so this doesn’t tell us if the integer is in the range… | 16:30 |
rm_work | oh that's member | 16:31 |
rm_work | you mentioned L7 | 16:31 |
xgerman | L7 s the same - w ehave a position | 16:31 |
xgerman | and test gain “test” | 16:31 |
rm_work | err | 16:31 |
rm_work | in L7 i definitely made a test that does > and < | 16:31 |
rm_work | let me find it | 16:32 |
xgerman | https://review.openstack.org/#/c/406328/25/octavia/tests/unit/api/v2/types/test_l7policies.py - that ain’t it | 16:32 |
rm_work | test_l7policy_positions | 16:32 |
rm_work | just a little down | 16:32 |
xgerman | ah, true, I gave up after not seeing it in post | 16:33 |
rm_work | I guess it should be in both | 16:33 |
xgerman | yep | 16:33 |
rm_work | so if i fix all of the things you guys commented on, xgerman / diltram | 16:33 |
rm_work | those are mergable? :P | 16:34 |
rm_work | or are you going to make more comments on the next patchset? :P | 16:34 |
diltram | rm_work: yes | 16:34 |
rm_work | ok | 16:34 |
xgerman | I think so | 16:34 |
johnsom | I have not tested L7 stuff yet | 16:34 |
xgerman | my stuff are nits | 16:34 |
xgerman | ok, besides actually testing it ;-) | 16:34 |
rm_work | LOL so | 16:40 |
rm_work | while both of you commented on needing to use a set() | 16:40 |
rm_work | neither of you noticed that it is impossible for that condition to even be met <_< | 16:40 |
rm_work | don't even need a set I think | 16:40 |
rm_work | listener_ids = [l.id for l in pool.listeners] | 16:41 |
xgerman | well, then hat code should be removed | 16:41 |
rm_work | yep | 16:41 |
rm_work | done | 16:41 |
rm_work | go ahead and +A it guys :P | 16:53 |
rm_work | not sure why the bot didn't report updates | 16:53 |
openstackgerrit | Merged openstack/octavia master: Adds a new config for soft-anti-affinity https://review.openstack.org/451924 | 16:57 |
rm_work | ah, umm | 17:03 |
rm_work | johnsom: do you know how/when in the API reponses, "children" is actually set to True? | 17:03 |
johnsom | Like for sub paths? or for single call create type requests? | 17:04 |
rm_work | hmmm | 17:04 |
rm_work | I mean I want to test that L7PolicyReponse actually does child calculations properly | 17:05 |
rm_work | but ... it never has children set to True | 17:05 |
diltram | rm_work: this feature doesn't work :P | 17:05 |
diltram | it's buggy | 17:05 |
diltram | and doesn't work really | 17:05 |
*** chlong has quit IRC | 17:05 | |
johnsom | Ah, the from data model stuf | 17:05 |
rm_work | lol | 17:06 |
diltram | yeah | 17:06 |
rm_work | I think it's literally never called with children=True | 17:06 |
rm_work | like, it isn't possible | 17:06 |
rm_work | maybe this was for some future thing? | 17:06 |
rm_work | even in v1 it isn't | 17:06 |
diltram | I was fighting with it a few weeks ago on one of the patches | 17:06 |
diltram | true | 17:06 |
rm_work | ... | 17:06 |
diltram | we need to rewrite this code | 17:06 |
rm_work | ok ... | 17:06 |
diltram | and make this usable | 17:06 |
rm_work | so should I just leave it for now? | 17:06 |
rm_work | or rip it out | 17:06 |
rm_work | and we can add it back later? | 17:07 |
diltram | as it doesn't allow us to really use this rename mechanizm | 17:07 |
diltram | you need to leave it | 17:07 |
rm_work | why? I mean, | 17:07 |
rm_work | the code patch is unreachable | 17:07 |
rm_work | *code path | 17:07 |
diltram | are you sure? | 17:07 |
rm_work | yes | 17:08 |
rm_work | (99%) | 17:08 |
rm_work | I have searched for all usages | 17:08 |
rm_work | there is no way for it to be called with children=True | 17:08 |
rm_work | unless I missed something | 17:08 |
rm_work | BTW you owe me a +A on https://review.openstack.org/#/c/405932/ | 17:08 |
rm_work | :P | 17:08 |
diltram | I would still probably leave and just mark with TODO as thing to be fixed | 17:08 |
rm_work | k | 17:08 |
diltram | done | 17:09 |
diltram | keep it rolling :P | 17:09 |
rm_work | L7Policy is ready for review | 17:10 |
rm_work | GOGOGOGO | 17:10 |
rm_work | diltram / johnsom / xgerman ^^ | 17:13 |
rm_work | xgerman: already fixed your comment | 17:13 |
xgerman | and I gave a +2 for members | 17:14 |
xgerman | L7 I probably should install and test before I | 17:14 |
xgerman | =2 | 17:14 |
rm_work | yesplz | 17:15 |
xgerman | ok, I will pull that patch but my devstack is a fickle friend | 17:17 |
rm_work | xgerman: i added the quota test (whoops, forgot to copy that one over) but I don't honestly know how to hit the duplicate-id thing | 17:18 |
rm_work | since we no longer allow post-by-id | 17:18 |
rm_work | in v2 | 17:18 |
rm_work | so maybe that is honestly dead code | 17:18 |
xgerman | k, it just looked suspicious in Sonar | 17:18 |
rm_work | i mean, the quota test missing was a good catch | 17:19 |
xgerman | well, Sonar is smart ;-) | 17:19 |
*** chlong has joined #openstack-lbaas | 17:21 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Rules https://review.openstack.org/406336 | 17:23 |
*** armax has joined #openstack-lbaas | 17:25 | |
xgerman | ok, vmware updates itself and can’t resume my devstack vm, restarting.. | 17:27 |
*** ducttape_ has quit IRC | 17:27 | |
openstackgerrit | Merged openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/452477 | 17:36 |
openstackgerrit | Merged openstack/neutron-lbaas master: Imported Translations from Zanata https://review.openstack.org/449037 | 17:36 |
openstackgerrit | Merged openstack/octavia master: Tests helper function _send_requests should catch socket.error https://review.openstack.org/452004 | 17:37 |
xgerman | well, if those filters wpould be there I could use that neutron client to test :-( | 17:46 |
xgerman | now I need to copy & paste from that API spec :-) | 17:47 |
*** armax has quit IRC | 17:53 | |
johnsom | That API spec may not help you. They never documented for neutron-lbaas (or it got deleted) and the v1 docs in octavia are slightly different | 17:54 |
johnsom | Two issues posted, still testing L7policy | 17:59 |
rm_work | xgerman: rebasing sorting/paging now... | 18:00 |
rm_work | it was ... complex | 18:00 |
rm_work | lots of changes lol | 18:00 |
rm_work | tons of conflicts | 18:00 |
xgerman | arrgh, wish I had filtering so I can use the passthrouhj | 18:01 |
rm_work | yeah I know | 18:06 |
rm_work | working on it | 18:06 |
*** gcheresh_ has joined #openstack-lbaas | 18:07 | |
*** armax has joined #openstack-lbaas | 18:07 | |
johnsom | Hmm, so update is broken for L7policy.... | 18:11 |
*** harlowja has joined #openstack-lbaas | 18:12 | |
johnsom | Updating the position and the admin-state doesn't actually update | 18:13 |
johnsom | Ok, I have done a test pass | 18:18 |
johnsom | I'm going to take a quick look at what we should do about the L7policy operating status issue. As it is right now, it will never come out of OFFLINE | 18:19 |
xgerman | Bug? https://usercontent.irccloud-cdn.com/file/7jEU5GUJ/Screen%20Shot%202017-04-03%20at%202.27.15%20PM.png | 18:27 |
xgerman | will file :-) | 18:28 |
johnsom | That is interesting... | 18:31 |
xgerman | LP doesn’t let you upload pictures? | 18:31 |
xgerman | https://bugs.launchpad.net/octavia/+bug/1679259 | 18:31 |
openstack | Launchpad bug 1679259 in octavia "[V2 API] Trying to crate a pool causes exception" [Undecided,Confirmed] | 18:31 |
xgerman | Found it | 18:31 |
johnsom | So the request is missing the LB ID or Listener ID. That exception needs some work.... | 18:34 |
johnsom | xgerman By "found it" does that mean you are fixing it? | 18:34 |
xgerman | no, I found where to upload images | 18:35 |
xgerman | I could of course try to fix… | 18:36 |
johnsom | Yeah, I can reproduce that | 18:36 |
rm_work | erg ok | 18:37 |
rm_work | you want to fix it? | 18:37 |
rm_work | i see why | 18:37 |
xgerman | ok, then it’s likely quicker if you do | 18:37 |
rm_work | k | 18:38 |
rm_work | though i have to finish fixing this patch first | 18:38 |
rm_work | i'm deeep into sorting/paging | 18:38 |
johnsom | details -> detail ? | 18:38 |
*** cody-somerville has quit IRC | 18:39 | |
*** cody-somerville has joined #openstack-lbaas | 18:39 | |
*** blogan has quit IRC | 18:40 | |
*** blogan has joined #openstack-lbaas | 18:41 | |
rm_work | i mean i literally just have to finish this and commit/review before i check out to do another change | 18:42 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Implement sorting and pagination for octavia https://review.openstack.org/382147 | 18:55 |
rm_work | ok | 18:55 |
johnsom | Ok, I am done picking on L7Policy. I'm going to grab a bite for lunch and then start on L7rules | 18:55 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Fix pool validation exception typo https://review.openstack.org/452899 | 18:57 |
rm_work | k i'll go fix policy | 18:57 |
rm_work | yes johnsom it was detail(s) | 18:57 |
rm_work | dumb typo | 18:57 |
johnsom | It happens. A quick grep didn't find any others | 18:58 |
*** armax has quit IRC | 19:00 | |
*** aojea has joined #openstack-lbaas | 19:01 | |
xgerman | ok | 19:02 |
*** csomerville has joined #openstack-lbaas | 19:05 | |
xgerman | afk - back in a while | 19:07 |
*** csomerville has quit IRC | 19:07 | |
*** csomerville has joined #openstack-lbaas | 19:07 | |
*** cody-somerville has quit IRC | 19:08 | |
openstackgerrit | Merged openstack/octavia master: Introduce Octavia v2 API for Members https://review.openstack.org/405932 | 19:10 |
rm_work | johnsom: erm, when you're back... | 19:12 |
rm_work | johnsom: IIRC the update isn't SUPPOSED to change the DB | 19:12 |
rm_work | it's the handler that does it | 19:12 |
rm_work | oh but the handler isn't doing it for you? | 19:12 |
rm_work | hold up | 19:12 |
johnsom | Right, second query same result | 19:14 |
rm_work | erm hey | 19:18 |
rm_work | can you check if v1 update works | 19:18 |
rm_work | i don't think it will either | 19:18 |
rm_work | <_< | 19:18 |
rm_work | from what I see | 19:18 |
rm_work | I can fix it | 19:18 |
rm_work | but can you verify that? | 19:18 |
rm_work | johnsom: ^^ | 19:20 |
rm_work | i am 99% sure both are broken and I know why | 19:20 |
rm_work | honestly i am not clear on how member updates works either | 19:22 |
rm_work | ok scratch that I am not clear on how ANY of the updates work | 19:23 |
rm_work | they are ALL passing the wrong type | 19:23 |
rm_work | unless I am blind | 19:23 |
rm_work | OH I SEE ok | 19:24 |
rm_work | well i still do know why | 19:24 |
johnsom | Hmm, I have to figure out the json format for v1, I got a 404 on my first try... | 19:25 |
johnsom | typo, ok | 19:26 |
rm_work | yeah nm i think v1 will work | 19:27 |
rm_work | i missed one conversion layer | 19:27 |
johnsom | Yep, v1 works for at least admin-state | 19:27 |
rm_work | though | 19:27 |
rm_work | hmm | 19:27 |
johnsom | Ok, back to lunch | 19:27 |
rm_work | no errors in the worker log? | 19:27 |
rm_work | ah k | 19:27 |
rm_work | worker/api | 19:27 |
johnsom | no errors | 19:28 |
rm_work | hmm | 19:32 |
rm_work | ah | 19:32 |
rm_work | just noticed the UpdatePoolInDB DB task's Revert is broken | 19:32 |
rm_work | hmm | 19:32 |
rm_work | for a while | 19:32 |
rm_work | looks like from a bad merge | 19:34 |
*** chlong has quit IRC | 19:37 | |
*** harlowja has quit IRC | 19:37 | |
rm_work | or not... hmm | 19:38 |
rm_work | well i see why admin_state_up doesn't work | 19:42 |
*** armax has joined #openstack-lbaas | 19:47 | |
*** sanfern has quit IRC | 19:48 | |
*** chlong has joined #openstack-lbaas | 19:51 | |
xgerman | back as well | 20:02 |
johnsom | Ok, so L7rules are ready right? | 20:08 |
rm_work | should be | 20:16 |
rm_work | hold up, posting an update to policies | 20:16 |
rm_work | admin_state should work | 20:16 |
rm_work | MAYBE position will work? | 20:16 |
rm_work | ah that was many minutes ago :P | 20:17 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Policy https://review.openstack.org/406328 | 20:18 |
rm_work | ok | 20:18 |
rm_work | comments addressed, I believe | 20:18 |
rm_work | please do retest update | 20:18 |
rm_work | only question was about showing rules on the policy response | 20:19 |
rm_work | johnsom: we don't do that currently for pools->members either | 20:19 |
rm_work | I can enable it, but if I do IMO i should do it for both | 20:19 |
rm_work | i honestly feel like we should always return the WHOLE TREE if we know it :P | 20:19 |
rm_work | but that isn't how the API is set up right now | 20:19 |
rm_work | it's very minimal and requires traversing manually and making many calls | 20:20 |
rm_work | but that is not difficult to change | 20:20 |
rm_work | ah, though I just realized when paging/sorting comes into play, that will be a wrench | 20:22 |
rm_work | well, maybe not | 20:22 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Policy https://review.openstack.org/406328 | 20:28 |
rm_work | one more tweak | 20:28 |
rm_work | xgerman: so you reviewing policies? | 20:29 |
xgerman | I am installing the latest | 20:29 |
johnsom | With rules thing, isn't it just the rule IDs? | 20:29 |
rm_work | erm | 20:30 |
rm_work | is that what neutron-lbaas does? | 20:30 |
rm_work | we didn't have it set up that way | 20:30 |
johnsom | Let me look | 20:30 |
rm_work | if it is, I can make it happen | 20:30 |
rm_work | sindhu: are you working on the HM patch? https://review.openstack.org/#/c/406256/ | 20:30 |
sindhu | rm_work: I was looking at functional test | 20:31 |
rm_work | ok | 20:31 |
sindhu | rm_work: but can u take a look | 20:31 |
rm_work | i'd like to apply a set of generic refactors I've been doing to all of the functional test files | 20:31 |
rm_work | to make them consistent | 20:31 |
sindhu | rm_work: sure go ahead | 20:31 |
rm_work | ok, you don't have any outstanding work to push up? | 20:31 |
rm_work | I can wait if you do | 20:32 |
sindhu | rm_work: I haven't made much changes | 20:32 |
sindhu | rm_work: no I don't have any major changes | 20:32 |
rm_work | ok | 20:32 |
johnsom | https://www.irccloud.com/pastebin/GrUxm65B/ | 20:32 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Rules https://review.openstack.org/406336 | 20:33 |
johnsom | rm_work that is a "show" for the policy, it's just IDs like we have in other parts of the API | 20:33 |
rm_work | ok | 20:33 |
rm_work | I can do that | 20:33 |
*** armax has quit IRC | 20:34 | |
*** armax has joined #openstack-lbaas | 20:34 | |
*** armax has quit IRC | 20:35 | |
johnsom | Pools does do members this way as well, FYI... | 20:43 |
*** armax has joined #openstack-lbaas | 20:48 | |
rm_work | yeah ok | 20:51 |
rm_work | i'll fix them both | 20:51 |
rm_work | oh errr | 20:51 |
rm_work | yeah k | 20:51 |
johnsom | Ok, yeah, I see that pool has the full members, not just the IDs. Missed that one | 20:52 |
*** harlowja has joined #openstack-lbaas | 20:53 | |
johnsom | Ok, moving on to rules | 20:55 |
johnsom | Hmm, Unknown column 'l7rule.created_at' in 'field list'\ | 20:59 |
johnsom | I did the migration for L7policy.... | 20:59 |
rm_work | hmmmmmm | 21:00 |
rm_work | recently? | 21:00 |
rm_work | i have updated it a few times | 21:00 |
johnsom | This morning. | 21:00 |
rm_work | k | 21:00 |
rm_work | not sure i did the created_at though, fff | 21:00 |
rm_work | sec | 21:00 |
rm_work | ok I am only partly done with this HM thing but i'm going to push it up and come back to it in a bit | 21:00 |
rm_work | and fix the stuff on L7Policy | 21:00 |
johnsom | Ok, yeah, L7rule is missing those | 21:01 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Introduce Octavia v2 API for Health Monitor https://review.openstack.org/406256 | 21:01 |
*** gcheresh_ has quit IRC | 21:04 | |
* xgerman doesn’t know why I not always start with a clean ubunu install when bringing up devstack | 21:05 | |
nmagnezi | johnsom, rm_work, diltram, thanks for the feedback :-) | 21:07 |
nmagnezi | diltram, currently for centos amp, you must use user_group = haproxy | 21:07 |
rm_work | johnsom: on Pool, does it ALSO do the same thing for Health Monitors (shows a list of IDs)? | 21:09 |
johnsom | https://www.irccloud.com/pastebin/fMZInPQU/ | 21:10 |
johnsom | No, it's not a list, just one line with the HM ID | 21:10 |
rm_work | k | 21:11 |
*** netchord has joined #openstack-lbaas | 21:12 | |
rm_work | about to push up policy, then fix rules | 21:18 |
*** aojea has quit IRC | 21:20 | |
*** aojea has joined #openstack-lbaas | 21:20 | |
rm_work | giving it a separate migration >_< | 21:21 |
openstackgerrit | Ankur proposed openstack/python-octaviaclient master: Initialize plugin for OSC https://review.openstack.org/446223 | 21:23 |
diltram | nmagnezi: we're waiting for a patch | 21:23 |
diltram | I'm not gonna set it | 21:23 |
*** darrenc has quit IRC | 21:24 | |
*** darrenc has joined #openstack-lbaas | 21:24 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Policy https://review.openstack.org/406328 | 21:24 |
*** aojea has quit IRC | 21:25 | |
rm_work | johnsom: ok, actually fixed pools AND l7policy in that patch <_< | 21:29 |
johnsom | Ok | 21:29 |
rm_work | AUGH | 21:30 |
rm_work | missed a pep8 on the policy one | 21:30 |
rm_work | oh nm no i didn't | 21:30 |
rm_work | whew | 21:30 |
rm_work | ah yep I did | 21:31 |
rm_work | fff | 21:31 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Rules https://review.openstack.org/406336 | 21:33 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Policy https://review.openstack.org/406328 | 21:33 |
rm_work | k | 21:33 |
rm_work | johnsom: should be fixed | 21:34 |
rm_work | but i'm about to have to call it for the day... meant to go to sleep 3.5 hours ago | 21:34 |
johnsom | OK | 21:34 |
johnsom | Ok, catch you tomorrow | 21:34 |
*** reedip has quit IRC | 21:35 | |
openstackgerrit | Ankur proposed openstack/python-octaviaclient master: Initialize plugin for OSC https://review.openstack.org/446223 | 21:38 |
*** armax has quit IRC | 21:51 | |
*** armax has joined #openstack-lbaas | 21:57 | |
*** armax has quit IRC | 22:02 | |
*** rcernin has quit IRC | 22:12 | |
rm_work | ugh got distracted by HMs | 22:13 |
rm_work | johnsom: HMs are locked to pool_id in v1 | 22:13 |
rm_work | but in v2 they are distinct objects right? | 22:13 |
johnsom | Yes | 22:13 |
rm_work | k | 22:14 |
johnsom | Part of the migration just copies the uuid from pool to the HM ID field I think | 22:14 |
johnsom | because default UUID isn't a thing... | 22:14 |
johnsom | BTW you added project ID in policy and in rule | 22:16 |
johnsom | Oh, maybe not, maybe it is just my DB state | 22:17 |
johnsom | hmmm | 22:17 |
johnsom | Yep, fixed | 22:21 |
rm_work | yeah sorry | 22:23 |
rm_work | moved it | 22:23 |
rm_work | because... relevancy | 22:23 |
johnsom | Yeah, no problem | 22:23 |
*** chlong has quit IRC | 22:38 | |
*** armax has joined #openstack-lbaas | 22:39 | |
*** fnaval has quit IRC | 22:42 | |
rm_work | johnsom: you can't change a HM type after creation? | 22:43 |
johnsom | I don't think so, let me check | 22:43 |
*** catintheroof has quit IRC | 22:44 | |
johnsom | Nope, it's a delete/recreate | 22:44 |
rm_work | k | 22:44 |
johnsom | Grrrr, something is borked | 22:47 |
rm_work | ok getting weird DB issues | 23:10 |
rm_work | strange | 23:10 |
johnsom | I'm about ready to stop hacking on l7rule just to keep testing | 23:11 |
openstackgerrit | Nir Magnezi proposed openstack/octavia master: (WIP) Auto detect haproxy user_group https://review.openstack.org/429398 | 23:11 |
rm_work | err | 23:17 |
rm_work | what is broken with it | 23:17 |
johnsom | I posted comments already. But the paths are wrong l7rule->rule | 23:17 |
johnsom | I tried hacking it in, but the change list was getting big. I'm going to read through now and get to the other stuff I need to do today. | 23:18 |
rm_work | ok not done with that yet, but I NEED to sleep | 23:19 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Introduce Octavia v2 API for Health Monitor https://review.openstack.org/406256 | 23:19 |
rm_work | kk | 23:19 |
johnsom | Catch you in the morning when we can wrap this stuff up. | 23:19 |
rm_work | do rules HAVE admin_state_up? | 23:27 |
johnsom | https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/extensions/l7.py#L161 | 23:27 |
johnsom | Evidently | 23:27 |
rm_work | k | 23:27 |
johnsom | Got to sleep dude. The issues will still be here in the morning... Grin | 23:28 |
johnsom | I have some administrative junk I need to do today, so I can't hack on them. | 23:29 |
rm_work | k | 23:31 |
rm_work | well | 23:32 |
rm_work | umm | 23:32 |
rm_work | it's cool, i'll get a 3 hour nap before class | 23:32 |
rm_work | i honestly might take tomorrow off | 23:32 |
rm_work | i haven't slept much in a while | 23:33 |
rm_work | this schedule is really bad with classes | 23:33 |
*** armax has quit IRC | 23:38 | |
*** sticker has quit IRC | 23:42 | |
rm_work | seriously why does pep8 take longer to START than py27 does to finish | 23:46 |
johnsom | I don't know.... | 23:46 |
rm_work | alright i think i almost got this | 23:50 |
johnsom | Alright, on administriva done, one to go | 23:51 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Align Octavia API to n-lbaasv2 for L7Rules https://review.openstack.org/406336 | 23:53 |
rm_work | k | 23:53 |
rm_work | should have fixed all of that | 23:53 |
rm_work | anywhooooo | 23:53 |
* rm_work sleeps | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!