*** JudeC has joined #openstack-lbaas | 00:01 | |
*** JudeC has quit IRC | 01:26 | |
*** KeithMnemonic has joined #openstack-lbaas | 01:28 | |
*** yamamoto has quit IRC | 01:33 | |
*** yamamoto has joined #openstack-lbaas | 01:33 | |
*** amotoki has quit IRC | 01:36 | |
*** yamamoto has quit IRC | 02:03 | |
*** armax has quit IRC | 02:19 | |
*** KeithMnemonic has quit IRC | 02:19 | |
*** yamamoto has joined #openstack-lbaas | 02:28 | |
*** Guest76746 is now known as med_ | 02:37 | |
*** med_ has joined #openstack-lbaas | 02:38 | |
*** yamamoto has quit IRC | 02:50 | |
*** yamamoto has joined #openstack-lbaas | 02:53 | |
*** yamamoto has quit IRC | 03:04 | |
*** aojea has joined #openstack-lbaas | 03:14 | |
*** aojea has quit IRC | 03:18 | |
*** csomerville has joined #openstack-lbaas | 03:27 | |
*** cody-somerville has quit IRC | 03:31 | |
*** thomasem_ has quit IRC | 04:04 | |
*** yamamoto has joined #openstack-lbaas | 04:07 | |
*** JudeC has joined #openstack-lbaas | 04:26 | |
*** oomichi has quit IRC | 04:46 | |
*** thomasem_ has joined #openstack-lbaas | 05:00 | |
*** aojea has joined #openstack-lbaas | 05:07 | |
*** fnaval has joined #openstack-lbaas | 05:19 | |
*** gcheresh_ has joined #openstack-lbaas | 05:24 | |
openstackgerrit | Jude Cross proposed openstack/python-octaviaclient master: [WIP] Add rest of load balancer commands https://review.openstack.org/454516 | 05:39 |
---|---|---|
*** aojea has quit IRC | 05:45 | |
*** aojea has joined #openstack-lbaas | 05:47 | |
*** aojea has quit IRC | 05:52 | |
*** JudeC has quit IRC | 05:59 | |
*** kobis has joined #openstack-lbaas | 06:07 | |
*** thomasem_ has quit IRC | 06:16 | |
*** thomasem_ has joined #openstack-lbaas | 06:20 | |
*** aojea has joined #openstack-lbaas | 06:48 | |
*** voelzmo has joined #openstack-lbaas | 06:53 | |
*** aojea has quit IRC | 06:54 | |
*** fnaval has quit IRC | 06:56 | |
*** voelzmo has quit IRC | 07:02 | |
*** voelzmo has joined #openstack-lbaas | 07:12 | |
*** JudeC has joined #openstack-lbaas | 07:20 | |
*** pcaruana has joined #openstack-lbaas | 07:24 | |
*** rcernin has joined #openstack-lbaas | 07:43 | |
*** JudeC has quit IRC | 07:44 | |
*** amotoki has joined #openstack-lbaas | 08:18 | |
*** rcernin has quit IRC | 08:23 | |
*** aojea has joined #openstack-lbaas | 08:50 | |
*** aojea has quit IRC | 08:55 | |
*** aojea has joined #openstack-lbaas | 10:14 | |
nmagnezi | o/ | 10:51 |
rm_work | o/ | 11:10 |
rm_work | going to sleep now, catch you in a few hours | 11:10 |
nmagnezi | good night :) | 11:10 |
rm_work | ok i feel a little dumb | 11:39 |
rm_work | i mean, besides that i'm still not asleep | 11:40 |
rm_work | solved the problem with the wsme response type | 11:40 |
rm_work | by realizing it's never an issue >_< | 11:40 |
rm_work | fix inc | 11:41 |
rm_work | also added a few bug tags | 12:00 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add support for single-create for APIv2 https://review.openstack.org/459032 | 12:00 |
rm_work | OK now bbl | 12:01 |
*** catintheroof has joined #openstack-lbaas | 12:37 | |
nmagnezi | rm_work, I'll just update my devstack node with the latest changes you added before I start :D | 12:41 |
rm_work | k erm | 12:41 |
rm_work | yeah uh | 12:42 |
rm_work | so about that | 12:42 |
nmagnezi | rm_work, no worries, just let me know when it's ready :-) | 12:42 |
rm_work | lol nah i mean | 12:46 |
rm_work | you can | 12:46 |
rm_work | i am about to post another fix | 12:46 |
rm_work | because i started to sleep | 12:46 |
rm_work | and was like | 12:46 |
rm_work | ah, why don't i just finish up the quotas stuff right now really quick | 12:46 |
nmagnezi | rm_work, meanwhile I'm gonna review this small patch: https://review.openstack.org/#/c/458920/2 | 12:49 |
rm_work | ok | 12:49 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add support for single-create for APIv2 https://review.openstack.org/459032 | 12:49 |
nmagnezi | rm_work, trying to figure out how to test with curl again :P | 12:49 |
rm_work | it's funny because it doesn't matter | 12:49 |
rm_work | because i completely change all that code in the single-create patch anyway | 12:49 |
nmagnezi | rm_work, https://birthofamuse.files.wordpress.com/2012/01/what-you-talkin-bout-willis.jpg%3Fw%3D549 | 12:50 |
rm_work | well, the minimal listener stuff at least | 12:51 |
rm_work | err, minimalL7 | 12:51 |
rm_work | https://review.openstack.org/#/c/459032/8/octavia/api/v2/types/listener.py | 12:51 |
rm_work | anywho, quotas should be there | 12:51 |
rm_work | I need to figure out functional testing for them :/ | 12:51 |
rm_work | right now the quota testing is braindead, just makes all quota checks fail, which isn't useful for checking if the Members quota is bad while everything else is good | 12:52 |
rm_work | for example | 12:52 |
rm_work | :( | 12:52 |
*** jerrygb has joined #openstack-lbaas | 13:02 | |
nmagnezi | rm_work, got it, so not sure why to have that small patch in the first place :P | 13:05 |
nmagnezi | rm_work, anyhow, I tried to test but i get the same result when I created a listener (this is how to test right?) both with your patch and with master.. strange | 13:06 |
xgerman | o/ | 13:20 |
*** cpuga has joined #openstack-lbaas | 13:24 | |
xgerman | rm_work: https://review.openstack.org/#/c/458968/ | 13:25 |
*** cpuga_ has joined #openstack-lbaas | 13:25 | |
nmagnezi | xgerman, o/ | 13:26 |
nmagnezi | xgerman, I was trying to review https://review.openstack.org/#/c/458920 | 13:26 |
nmagnezi | xgerman, but couldn't get it to work like i expected, | 13:26 |
nmagnezi | xgerman, created a l7 policy linked it to a listener and queried for that listener | 13:27 |
xgerman | it looks sane to me and it didn’t break the gates ;-) | 13:27 |
nmagnezi | xgerman, didn't see any diff from the result i get when using the master branch | 13:27 |
nmagnezi | xgerman, what did i miss ? :< | 13:27 |
nmagnezi | xgerman, LOL | 13:27 |
*** amotoki has quit IRC | 13:27 | |
xgerman | I see some things regarding the TLS refs | 13:28 |
xgerman | but we can’t test that since TLS is broken ATM | 13:28 |
nmagnezi | xgerman, you patch in this subject is ready for review? | 13:28 |
nmagnezi | your* | 13:28 |
*** cpuga has quit IRC | 13:28 | |
xgerman | yes | 13:28 |
* nmagnezi spins up devstack | 13:29 | |
nmagnezi | :) | 13:29 |
nmagnezi | xgerman, https://review.openstack.org/#/c/458968/ , right? | 13:29 |
xgerman | yep | 13:29 |
xgerman | I think BBQ changed the format of their payload… | 13:30 |
nmagnezi | xgerman, gotta love openstack O_o | 13:39 |
xgerman | :-0 | 13:39 |
nmagnezi | xgerman, stacking.. so it will take some time to be ready. meanwhile I'll try to understand what exactly changed | 13:40 |
xgerman | on the TLS fron they now return six.text_type which can’t be turned into a byte array without decoding | 13:41 |
nmagnezi | xgerman, btw don't we have any test that covers this? | 13:41 |
xgerman | mmh, I could probably force it to the two new types they (claim to) return | 13:42 |
nmagnezi | xgerman, https://docs.openstack.org/developer/python-barbicanclient/usage.html#secret-content-types <<- this? | 13:53 |
xgerman | yep | 13:53 |
nmagnezi | xgerman, so from what I understand about this if they return six.binary_type but if they return six.text_type we'll need to decode | 13:58 |
xgerman | yep, and this is what my code does | 13:58 |
nmagnezi | xgerman, there is no longer a way to make sure thet always return six.binary_type? | 13:58 |
xgerman | nope, that’s what they changed | 13:58 |
nmagnezi | xgerman, i'm trying to understand "I could probably force it to the two new types they (claim to) return" :-) | 13:59 |
nmagnezi | this is what they return anyways, no? | 13:59 |
xgerman | I can add some six.text_type(<TLS stuff>) to the tests | 13:59 |
xgerman | our tests go off a constant | 14:00 |
rm_work | nmagnezi: on that small patch, the only real difference is that the l7policy will only return as an ID | 14:00 |
rm_work | instead of as a full object | 14:00 |
nmagnezi | xgerman, meaning you'll use _conver in tests to cover both cases in the same test? | 14:02 |
nmagnezi | rm_work, maybe i should have used --debug in the cli client to see that diff | 14:03 |
xgerman | I have kept it to the original tests — didn’t try to force it to text_type but I could | 14:03 |
nmagnezi | xgerman, maybe we should. so tests will cover cases where we get the text_type as well | 14:05 |
xgerman | k, will do | 14:05 |
rm_work | nmagnezi: err, dunno about the CLI | 14:08 |
rm_work | use curl | 14:08 |
nmagnezi | xgerman, aye. I commented on the patch. I will also run the actual code when my devstack node is ready and report | 14:09 |
xgerman | sounds good | 14:09 |
nmagnezi | rm_work, but I like CLI :< | 14:09 |
rm_work | the CLI doesn't *work* | 14:11 |
rm_work | lol | 14:11 |
rm_work | anyway, what I REALLY am hoping is that some folks can give the single-create a workout this week | 14:18 |
rm_work | I'd like to get that + paging/sorting merged before the summit | 14:19 |
rm_work | and also possibly filtering (which is my next target) | 14:19 |
rm_work | that'll allow the client stuff Jude is working on to fully function | 14:19 |
openstackgerrit | Merged openstack/octavia master: Correct some v2 Listener response entries https://review.openstack.org/458920 | 14:25 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Install DIB from source so depends-on will work https://review.openstack.org/444707 | 14:28 |
*** amotoki has joined #openstack-lbaas | 14:28 | |
rm_work | rebased that one, it had some weird failure | 14:28 |
rm_work | POST_FAILURE? | 14:28 |
rm_work | oh right, sleep | 14:32 |
*** amotoki has quit IRC | 14:33 | |
*** kobis has quit IRC | 14:39 | |
*** kobis has joined #openstack-lbaas | 14:39 | |
*** blogan has joined #openstack-lbaas | 14:40 | |
*** kobis has quit IRC | 14:40 | |
*** armax has joined #openstack-lbaas | 14:47 | |
xgerman | https://www.irccloud.com/pastebin/PMve76bf/ | 14:48 |
xgerman | ^^ rm_work what’s this unicode and py35 about | 14:48 |
*** armax has quit IRC | 14:57 | |
*** gcheresh_ has quit IRC | 15:02 | |
rm_work | what patch is that part of | 15:07 |
rm_work | huh, master | 15:07 |
rm_work | weird | 15:07 |
rm_work | that's, uhh | 15:07 |
rm_work | I think that was done wrong | 15:08 |
xgerman | yeah, not sure… | 15:10 |
rm_work | yeah so | 15:10 |
rm_work | we kinda cloned what glance did | 15:10 |
rm_work | and they've fixed it | 15:10 |
rm_work | https://github.com/openstack/glance/blob/master/glance/common/exception.py#L57-L61 | 15:10 |
rm_work | I feel like this basic exception thing should be boilerplate in oslo | 15:11 |
rm_work | not implemented EVERYWHERE | 15:11 |
xgerman | ^^ harlowja | 15:11 |
rm_work | very slightly differently to do the same thing | 15:11 |
xgerman | ok, I will ready a patch | 15:11 |
rm_work | https://github.com/openstack/nova/blob/master/nova/exception.py#L62 | 15:12 |
rm_work | https://github.com/openstack/cinder/blob/master/cinder/exception.py#L76 | 15:12 |
johnsom | Josh isn't the oslo PTL anymore... | 15:12 |
rm_work | https://github.com/openstack/neutron-lib/blob/master/neutron_lib/exceptions/__init__.py#L26 | 15:13 |
rm_work | actually maybe we cloned the neutron one, xgerman | 15:13 |
xgerman | I think they all do the same | 15:13 |
rm_work | looks maybe more similar | 15:13 |
rm_work | (they also fixed it, also differently) | 15:13 |
rm_work | maybe I'd do their version | 15:13 |
rm_work | since it looks more like ours | 15:13 |
rm_work | https://github.com/openstack/barbican/blob/master/barbican/common/exception.py#L25 | 15:14 |
rm_work | just proving that *every* project reimplements the *exact* same functionality | 15:14 |
rm_work | just ........ no two the same | 15:14 |
xgerman | ok, patch is forthcomong | 15:15 |
johnsom | rm_work RE: quotas and your functional test comment earlier. Did we not pull the functional tests over when we added quotas to the objects? | 15:16 |
rm_work | umm | 15:17 |
rm_work | we did | 15:17 |
rm_work | i think | 15:17 |
rm_work | but they're kinda braindead | 15:17 |
johnsom | Ah, so what is missing? | 15:17 |
rm_work | so they work for testing individual objects | 15:17 |
rm_work | but trying to test a tree... | 15:17 |
rm_work | i can't easily say "we're only over quota on members", for example | 15:17 |
rm_work | I mean, it's not going to be that hard to fix, I think | 15:18 |
rm_work | just have to do it | 15:18 |
johnsom | Right, ok. Yeah single-call I may have not updated the testing for ti | 15:18 |
rm_work | ah and the quota test for listeners is missing | 15:18 |
rm_work | which explains why we didn't catch that it wasn't ever added | 15:18 |
johnsom | Just wanted to learn if I did something braindead when I fixed the braindead tests... Grin | 15:18 |
rm_work | i'm adding the missing listener quota test | 15:22 |
johnsom | Ok | 15:22 |
rm_work | and then seeing if i can rewrite this quota handling | 15:22 |
rm_work | ugh | 15:22 |
rm_work | i meant to sleep | 15:22 |
rm_work | but just kept working | 15:22 |
rm_work | ah LB quota test was missing too | 15:24 |
rm_work | ugh our quota exception blows | 15:25 |
rm_work | no idea WHICH quota | 15:25 |
*** csomerville has quit IRC | 15:26 | |
rm_work | i guess that normally would be obvious | 15:26 |
*** csomerville has joined #openstack-lbaas | 15:26 | |
openstackgerrit | German Eichberger proposed openstack/octavia master: Fixes unicode problems in p35 https://review.openstack.org/459346 | 15:30 |
*** KeithMnemonic has joined #openstack-lbaas | 15:30 | |
rm_work | LOL I derped on the copy/paste | 15:39 |
rm_work | but it's ok i'm about to fix it | 15:39 |
rm_work | my test was behaving oddly, realized it's because I fixed the issue where it'd blindly say everything was fine even if you were checking the wrong quota :P | 15:40 |
rm_work | hmmm this is odd | 15:43 |
rm_work | L7Rule doesn't have quotas :P | 15:43 |
rm_work | but there's a test for it | 15:43 |
rm_work | umm | 15:45 |
rm_work | so I guess technically our quota check just does nothing for other objects lol | 15:45 |
*** armax has joined #openstack-lbaas | 15:54 | |
*** amotoki has joined #openstack-lbaas | 15:56 | |
rm_work | yeah that was easier than I thought | 16:01 |
*** voelzmo has quit IRC | 16:02 | |
openstackgerrit | German Eichberger proposed openstack/octavia master: Fixes Octavia not working with Barbican https://review.openstack.org/458968 | 16:06 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add support for single-create for APIv2 https://review.openstack.org/459032 | 16:06 |
rm_work | johnsom: ^^ quota issue fixed | 16:06 |
rm_work | or rather, the testing | 16:06 |
rm_work | err, actually yes, also another quota issue | 16:07 |
rm_work | I feel like our quota system is a little wacky | 16:07 |
rm_work | but I am not going to dig toooo deeply into that right at the moment | 16:07 |
rm_work | I have plenty of other stuff to work on >_> | 16:07 |
xgerman | we need to get the TLS stuff straightened out… so we can use it in the lab ;-) | 16:11 |
rm_work | yes | 16:11 |
rm_work | I'll look at that shortly too | 16:11 |
rm_work | I'd REALLY like to show off a working single-create | 16:11 |
rm_work | with TLS | 16:12 |
rm_work | :3 | 16:12 |
*** jerrygb has quit IRC | 16:16 | |
xgerman | ;-) | 16:18 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Implement sorting and pagination for octavia https://review.openstack.org/382147 | 16:21 |
rm_work | xgerman: what were you doing to get that unicode bug to actually trigger <_< | 16:25 |
rm_work | I'm not sure how to reproduce | 16:25 |
rm_work | testing seemed fine on both py27 and py35 obviously | 16:25 |
xgerman | I was running tox -epep8 | 16:25 |
rm_work | because our gates are still working | 16:25 |
rm_work | err wut | 16:25 |
xgerman | on oython3 | 16:25 |
rm_work | aahh | 16:25 |
xgerman | so it should slide by our gates | 16:26 |
rm_work | is there an easy tox command to do that | 16:26 |
rm_work | or do i need to edit tox.ini | 16:26 |
*** jerrygb has joined #openstack-lbaas | 16:33 | |
johnsom | The only way I know to do it is to edit the tox.ini and add the override | 16:34 |
rm_work | yeah, did that | 16:41 |
rm_work | i feel like if i were a tox guru there's a slicker way to do this | 16:42 |
rm_work | ok BACK LATER | 16:45 |
*** sanfern has joined #openstack-lbaas | 17:02 | |
*** cpuga_ has quit IRC | 17:13 | |
*** cpuga has joined #openstack-lbaas | 17:13 | |
xgerman | afk for a bit | 17:20 |
harlowja | xgerman https://github.com/openstack/oslo.utils/blob/master/oslo_utils/encodeutils.py#L123 may be what u want? | 17:31 |
xgerman | Gotta check that out | 17:32 |
*** gcheresh_ has joined #openstack-lbaas | 17:39 | |
*** sanfern has quit IRC | 17:48 | |
*** eandersson has joined #openstack-lbaas | 17:54 | |
*** amotoki has quit IRC | 17:54 | |
*** chlong has joined #openstack-lbaas | 17:59 | |
*** catintheroof has quit IRC | 18:01 | |
xgerman | well, if I use that in | 18:13 |
xgerman | __unicode__ as exception_to_unicode(self) I could get an inifnite loop | 18:14 |
*** JudeC has joined #openstack-lbaas | 18:16 | |
harlowja | ya | 18:16 |
harlowja | lol | 18:16 |
harlowja | there used to be a base exception in oslo.utils for everyone | 18:18 |
harlowja | but never seemed to last | 18:19 |
harlowja | https://github.com/openstack/oslo.utils/blob/master/oslo_utils/excutils.py#L35 is the closest that exists | 18:19 |
xgerman | well, I could use thst to rewrite something else… | 18:20 |
harlowja | lol | 18:23 |
JudeC | Hey johnsom: Do you have any resources on the differences/similarities of the Octavia v1 vs v2 API? I'm trying to understand why there are 2 APIs and what I need to do as far as the client is concerned. | 18:32 |
xgerman | JudeC Octavia’s V1 API was <only> for the communication lbaasv2 Octavia plugin <-> Octavia —- so shouldn’t have any bearing on V2 (though it’s similar) | 18:35 |
JudeC | xgerman: thank you. | 18:37 |
*** catintheroof has joined #openstack-lbaas | 18:38 | |
openstackgerrit | German Eichberger proposed openstack/octavia master: Fixes Octavia not working with Barbican https://review.openstack.org/458968 | 18:55 |
*** cpuga_ has joined #openstack-lbaas | 19:05 | |
*** cpuga has quit IRC | 19:05 | |
JudeC | rest_method:: GET /v2.0/lbaas/loadbalancers/{loadbalancer_id}/stats | 19:10 |
JudeC | does this not actually exist in the v2 api yet? | 19:10 |
JudeC | https://github.com/openstack/octavia/blob/master/api-ref/source/v2/loadbalancer.inc | 19:11 |
johnsom | JudeC: right, ignore v1 and status/stats isn't working yet | 19:13 |
JudeC | ah ok just making sure I am not crazy | 19:14 |
JudeC | thanks | 19:14 |
openstackgerrit | German Eichberger proposed openstack/neutron-lbaas master: Octavia Proxy Plugin https://review.openstack.org/418530 | 19:27 |
*** jerrygb has quit IRC | 19:42 | |
*** pcaruana has quit IRC | 20:01 | |
*** harlowja has quit IRC | 20:03 | |
*** jerrygb has joined #openstack-lbaas | 20:17 | |
*** jerrygb has quit IRC | 20:21 | |
nmagnezi | o/ | 20:22 |
xgerman | o/ | 20:28 |
openstackgerrit | German Eichberger proposed openstack/octavia master: Fixes Octavia not working with Barbican https://review.openstack.org/458968 | 20:32 |
openstackgerrit | German Eichberger proposed openstack/octavia master: Fixes mysterious gdbm error https://review.openstack.org/459447 | 20:38 |
xgerman | ^^ I did a ton of simple fixes so approve away | 20:39 |
*** gcheresh_ has quit IRC | 20:44 | |
*** harlowja has joined #openstack-lbaas | 20:59 | |
*** catintheroof has quit IRC | 21:15 | |
*** aojea has quit IRC | 21:26 | |
rm_work | That's an interesting one xgerman | 21:48 |
xgerman | Yep . Was driving me insane | 21:49 |
nmagnezi | xgerman, looks like you are about to get you sanity back :) | 22:03 |
nmagnezi | your* | 22:03 |
*** fnaval has joined #openstack-lbaas | 23:03 | |
*** cpuga_ has quit IRC | 23:04 | |
*** fnaval has quit IRC | 23:18 | |
*** fnaval has joined #openstack-lbaas | 23:25 | |
*** fnaval has quit IRC | 23:26 | |
*** fnaval has joined #openstack-lbaas | 23:26 | |
*** fnaval has quit IRC | 23:26 | |
openstackgerrit | Jude Cross proposed openstack/python-octaviaclient master: [WIP] Add rest of load balancer commands https://review.openstack.org/454516 | 23:43 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!