Wednesday, 2017-06-07

« Tuesday, 2017-06-06 Index Thursday, 2017-06-08 »
johnsomWell, we have other "set" commands that don't have some options, but yeah, I get it.  you would be "setting" pool...00:00
rm_workright00:00
rm_workbesides the fact that it also doesn't work at the moment, heh00:01
johnsomrm_work so did you change your mind about the --pool00:19
rm_workeugh00:23
rm_workeuuuugh00:23
rm_workffff00:23
rm_workfffff00:23
rm_workmaybe just put it in the right order, i dunno <_<00:23
*** sshank has quit IRC00:27
openstackgerritMerged openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/47151600:31
rm_workk... we'll see00:32
rm_workjohnsom: what do you think <_<00:38
*** yamamoto_ has joined #openstack-lbaas00:38
johnsomYeah, set is strange.  I lean towards using the positionals00:40
rm_workjohnsom: just for set? or back on everything00:42
johnsomThey all should be the same00:43
rm_workok, so put them ALL back00:44
rm_workBUT, still change the order? >_>00:44
rm_worki hope00:44
*** yamamoto_ has quit IRC00:44
*** fnaval has quit IRC01:08
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/47152301:10
*** fnaval has joined #openstack-lbaas01:10
johnsomSure01:12
*** cpuga has quit IRC01:21
*** cpuga has joined #openstack-lbaas01:22
*** cpuga has quit IRC01:30
*** atoth has quit IRC01:34
*** yamamoto_ has joined #openstack-lbaas01:40
*** gongysh has joined #openstack-lbaas01:41
*** yamamoto_ has quit IRC01:45
*** chlong has quit IRC01:50
*** sanfern has quit IRC02:04
*** yamamoto_ has joined #openstack-lbaas02:16
openstackgerritMerged openstack/octavia master: Check keepalived health in the amphora  https://review.openstack.org/47008102:51
*** sanfern has joined #openstack-lbaas02:52
*** links has joined #openstack-lbaas02:52
*** aojea has joined #openstack-lbaas03:04
*** aojea has quit IRC03:08
*** gans has joined #openstack-lbaas03:35
*** blogan has joined #openstack-lbaas04:39
*** blogan__ has quit IRC04:41
*** yamamoto_ has quit IRC04:44
*** pcaruana has joined #openstack-lbaas04:56
*** aojea has joined #openstack-lbaas05:02
*** pcaruana has quit IRC05:14
*** kobis has joined #openstack-lbaas05:16
*** leitan has quit IRC05:19
*** yamamoto has joined #openstack-lbaas05:31
*** cpuga has joined #openstack-lbaas05:32
*** cpuga has quit IRC05:36
*** numan_ has joined #openstack-lbaas05:36
*** kobis has quit IRC05:48
*** aojea has quit IRC06:06
*** rcernin has joined #openstack-lbaas06:21
*** fnaval has quit IRC06:27
*** fnaval has joined #openstack-lbaas06:29
*** armax has quit IRC06:36
*** tonygunk has quit IRC06:49
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add member commands to client  https://review.openstack.org/46303506:57
*** eanderson_ has joined #openstack-lbaas06:59
*** pcaruana has joined #openstack-lbaas07:03
openstackgerritM V P Nitesh proposed openstack/octavia-dashboard master: Optimize the link address  https://review.openstack.org/45529807:05
*** tesseract has joined #openstack-lbaas07:11
*** aojea has joined #openstack-lbaas07:22
*** aojea has quit IRC07:22
*** aojea has joined #openstack-lbaas07:23
*** numan_ has quit IRC07:35
*** kobis has joined #openstack-lbaas07:36
*** dayou has quit IRC07:37
openstackgerritErik Olof Gunnar Andersson proposed openstack/octavia-dashboard master: Replace SortedDict with OrderedDict  https://review.openstack.org/47161107:39
eanderson_Just the same patch as for the old dashboard ^07:40
openstackgerritErik Olof Gunnar Andersson proposed openstack/octavia-dashboard master: Replace SortedDict with OrderedDict and fixing Python 3.5 test  https://review.openstack.org/47161107:51
*** rcernin has quit IRC07:52
*** rcernin has joined #openstack-lbaas07:52
openstackgerritErik Olof Gunnar Andersson proposed openstack/octavia-dashboard master: Replace SortedDict with OrderedDict and fixing Python 3.5 test  https://review.openstack.org/47161107:56
openstackgerritAdam Harwell proposed openstack/octavia master: Update devstack to properly configure nova-lxd img  https://review.openstack.org/45323708:21
openstackgerritAdam Harwell proposed openstack/octavia master: Allow using custom enum values for API fields  https://review.openstack.org/46385108:21
openstackgerritAdam Harwell proposed openstack/octavia master: Introduce nlbaas shim driver layer for APIv2  https://review.openstack.org/40939808:21
rm_workjust a few rebases08:23
*** gongysh has quit IRC08:25
eanderson_rm_work, do you know how types.MethodType works?08:28
eanderson_https://github.com/openstack/horizon/blob/4570b4cd7813c5b5d559a87c715f4ee6e6f1f63d/openstack_dashboard/test/integration_tests/pages/navigation.py#L33008:28
eanderson_trying to fix the octavia-dashboard gate -_-08:28
*** aojea has quit IRC08:28
*** eanderson_ is now known as eandersson_08:29
eandersson_I like that I had misspelled my own name on irc08:29
rm_workerm08:30
rm_worki am not sure08:30
*** gongysh has joined #openstack-lbaas08:33
*** aojea has joined #openstack-lbaas08:33
*** gcheresh_ has joined #openstack-lbaas08:34
eandersson_Let's see if this will work :D https://review.openstack.org/#/c/471638/08:39
eandersson_Assuming that the above patch gets merged we should have a working gate for octavia-dashboard08:48
eandersson_again08:49
*** eandersson_ has quit IRC09:05
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add member commands to client  https://review.openstack.org/46303509:12
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add l7policy commands to client  https://review.openstack.org/46243109:18
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Update help text for all commands  https://review.openstack.org/46644109:18
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add healthmonitor commands to client  https://review.openstack.org/46383009:18
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add l7rule commands to client  https://review.openstack.org/46280809:18
*** JudeC has quit IRC09:23
*** cpuga has joined #openstack-lbaas09:33
*** cpuga has quit IRC09:38
openstackgerritGanpat Agarwal proposed openstack/octavia master: Updating octavia configuration for routing haproxy log to external logging server  https://review.openstack.org/47168209:41
*** isantosp has joined #openstack-lbaas09:43
openstackgerritGanpat Agarwal proposed openstack/octavia master: Updating octavia configuration for routing haproxy log to external logging server  https://review.openstack.org/47168209:47
*** gans has quit IRC09:52
*** gans has joined #openstack-lbaas09:53
*** tonygunk has joined #openstack-lbaas09:56
*** tonygunk has quit IRC10:39
*** tonygunk has joined #openstack-lbaas10:45
*** sanfern has quit IRC10:51
*** gans has quit IRC10:53
*** yamamoto has quit IRC11:10
*** aojea has quit IRC11:16
*** atoth has joined #openstack-lbaas11:50
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/47173811:55
*** sanfern has joined #openstack-lbaas11:59
*** chlong has joined #openstack-lbaas12:02
*** gongysh has quit IRC12:19
*** gongysh has joined #openstack-lbaas12:19
*** gongysh has quit IRC12:23
*** yamamoto has joined #openstack-lbaas12:36
*** yamamoto has quit IRC12:47
*** gcheresh_ has quit IRC12:55
*** dayou has joined #openstack-lbaas12:57
*** yamamoto has joined #openstack-lbaas13:08
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/47176513:09
*** fnaval has quit IRC13:10
*** aojea has joined #openstack-lbaas13:23
*** fnaval has joined #openstack-lbaas13:26
*** belharar has joined #openstack-lbaas13:30
*** links has quit IRC13:30
*** cpuga has joined #openstack-lbaas13:35
*** chlong has quit IRC13:43
*** cpuga has quit IRC13:44
*** gans has joined #openstack-lbaas13:44
*** gans has quit IRC14:00
*** fnaval has quit IRC14:01
*** fnaval has joined #openstack-lbaas14:01
*** yamamoto has quit IRC14:03
*** yamamoto has joined #openstack-lbaas14:03
*** gans has joined #openstack-lbaas14:05
*** kobis has quit IRC14:05
*** cpuga has joined #openstack-lbaas14:06
*** kobis has joined #openstack-lbaas14:06
*** kobis has quit IRC14:06
*** cpuga has quit IRC14:07
*** cpuga has joined #openstack-lbaas14:08
*** yamamoto has quit IRC14:08
*** armax has joined #openstack-lbaas14:10
*** gans has quit IRC14:25
*** aojea has quit IRC14:37
*** sanfern has quit IRC14:37
*** sanfern has joined #openstack-lbaas14:38
*** rcernin has quit IRC15:11
*** gans has joined #openstack-lbaas15:27
*** chlong has joined #openstack-lbaas15:27
openstackgerritMerged openstack/neutron-lbaas master: tempest: Add a config for session persistence types  https://review.openstack.org/46751015:30
*** reedip_ has joined #openstack-lbaas15:39
*** aojea has joined #openstack-lbaas15:45
*** aojea has quit IRC15:50
*** gans has quit IRC15:54
*** kobis has joined #openstack-lbaas15:54
openstackgerritMichael Johnson proposed openstack/octavia-dashboard master: Update .gitreview for octavia-dashboard  https://review.openstack.org/47184115:58
johnsomrm_work xgerman_ Can we merge the above patch so we can fix the global-requirements proposal bot?15:59
*** cpuga has quit IRC15:59
*** sshank has joined #openstack-lbaas16:14
*** reedip_ has quit IRC16:30
openstackgerritMerged openstack/python-octaviaclient master: Updated from global requirements  https://review.openstack.org/47151516:32
*** tesseract has quit IRC16:34
*** kobis has quit IRC16:37
*** sshank has quit IRC16:47
*** sshank has joined #openstack-lbaas16:49
*** yamamoto has joined #openstack-lbaas17:06
*** yamamoto has quit IRC17:11
*** JudeC has joined #openstack-lbaas17:16
*** belharar has quit IRC17:17
*** rcernin has joined #openstack-lbaas17:30
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add healthmonitor commands to client  https://review.openstack.org/46383017:36
rm_workjohnsom: your gitreview patch failed, i think maybe it's the line you missed(?)17:38
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Update help text for all commands  https://review.openstack.org/46644117:38
rm_workjohnsom: ah or it's just that the gate has always been broken so we need to fix that before we can merge anything17:42
rm_workthough i still think you missed a line17:42
*** aojea has joined #openstack-lbaas17:42
eanderssonFor the octavia-dashboard17:54
eanderssonnot sure how to fix this line https://github.com/openstack/octavia-dashboard/blob/master/neutron_lbaas_dashboard/tests/integration_tests/tests/test_loadbalancers.py#L1317:54
eanderssonCan we disable this for now to fix the py35 tests?17:54
rm_workmaybe17:55
rm_workerrr17:55
eanderssonIt's broken on the Horizon side17:55
johnsomI was just looking at that too17:55
rm_workwhy does octavia-dashboard still have a "neutron_lbaas_dashboard" directory17:55
rm_workfff17:55
eanderssonThere is a patch for that17:55
johnsomBecause the patch that changed all of that never got finished17:55
rm_workok so i see why you "missed" (didn't) a line17:55
eanderssonI wrote this one at like 2 AM last night17:55
eanderssonhttps://review.openstack.org/#/c/471611/17:55
rm_workk17:55
eanderssonto fix the gate, but need to figure out that last one17:55
rm_workerrr17:57
rm_workis that even used17:57
rm_workoh right it's the baseclass17:57
rm_workerm17:57
rm_workyeah for now maybe just comment it out :(18:00
rm_workor does skipping the whole class cause it to not fail the py3 tests18:00
rm_worka skip could be better than commenting the whole thing :P18:00
eanderssonI opened an upstream pr for horizon, but not sure how types.MethodType works, and couldn't find any good documentation18:02
eanderssonhttps://review.openstack.org/#/c/471638/18:02
rm_workyeah the python docs for it were useless18:03
johnsomYeah, this changed between py2 and py318:04
eanderssonI did some local testing, and my change yielded the same result as far as I could see, but the tests still failed18:05
johnsomThere is a discussion here about using lambda: https://stackoverflow.com/questions/12177405/python2-vs-python3-function-to-method-binding18:05
johnsomThough I am not sure I follow all of this18:05
johnsomAh, and six seems to have something for this too18:08
johnsomsix.create_unbound_method ?18:09
rm_workah then six is prolly the way to go18:09
eanderssonfunny actually checked six, but I probably just dig a quick search on an exact match18:10
johnsomMind warped, not sure if they are trying bound or unbound.  Ugh, poor docs18:11
rm_workyeah docs have been really my bane recently18:12
eanderssonlol py3 version if def create_unbound_method(func, cls): return func18:13
rm_work(and yours, for different reasons lol)18:13
johnsomHa18:13
eandersson*if PY3:18:13
johnsomSo maybe you need the six.create_bound_method version?18:14
eanderssonYea - I think that would fix it.18:14
eanderssonI'll update the horizon patch18:16
rm_workyeah, did you do a depends-on in your dashboard patch?18:19
*** aojea has quit IRC18:20
eanderssonNot yet - I'll do that though18:31
eanderssonHow do I re-clone an existing patch? :D18:33
rm_workgit review -d <cr#>18:33
rm_workgit review -d 47163818:33
rm_workfor instance18:33
eanderssonthanks18:33
eanderssonhttps://review.openstack.org/#/c/471638/2/openstack_dashboard/test/integration_tests/pages/navigation.py18:37
eanderssonMy previous patch actually passed Jenkins as well, but using six is cleaner18:42
rm_workkk18:43
rm_workyeah now do the depends-on18:43
rm_workso we can verify it works18:43
rm_workand then we can hound some horizon folks18:43
*** sshank has quit IRC18:45
rm_workeandersson: is this not also a problem? http://logs.openstack.org/11/471611/3/check/gate-octavia-dashboard-nodejs4-npm-run-test/39596e8/console.html#_2017-06-07_08_05_41_18935518:45
openstackgerritErik Olof Gunnar Andersson proposed openstack/octavia-dashboard master: Replace SortedDict with OrderedDict and fixing Python 3.5 test  https://review.openstack.org/47161118:45
rm_workor is that something transient18:45
eanderssongood question18:46
eanderssonThose are non-voting at the moment though18:46
rm_workthis one isn't...18:47
eanderssono_O18:47
rm_workgate-octavia-dashboard-nodejs4-npm-run-test18:47
eanderssonYou are right -_-18:47
rm_workT_T18:47
eanderssonIt is non-voting on the neutron-lbaas-dashboard18:47
eanderssonso I just ignored it lol18:47
rm_workhmmmm18:47
rm_workdid we do it wrong for octavia-dashboard18:48
rm_workwe can fix the job config if so18:48
eanderssone.g. https://review.openstack.org/#/c/471523/18:48
eanderssonpy35 isn't active either, which is why it's passing18:48
eanderssonI think we should keep the py35 tests though18:48
rm_workhmmm18:49
rm_workummm, this is weird18:50
rm_workyeah we configured it totally differently18:50
rm_workI can normalize it18:50
eanderssonI thought that py35 was added as it's now a requirement afaik18:51
eanderssonbut yea better to get the ball rolling18:51
rm_workwell18:52
rm_worki'm just doing the nodejs fix18:52
rm_worknot removing py3518:52
eanderssongood18:52
rm_workso you should keep making sure that's fixed :)18:52
eanderssonI meant that I didn't realize it was misconfigured :p18:52
eanderssonbecause I missed the node stuff18:52
rm_worklint seems to be passing18:54
rm_workso i'll leave that voting18:54
rm_workhttps://review.openstack.org/#/c/471887/18:58
rm_workjohnsom: ^^18:59
*** cpuga has joined #openstack-lbaas19:06
eanderssonrobcresswell is on top of things19:06
eanderssonon the horizon side19:06
*** cpuga_ has joined #openstack-lbaas19:07
*** yamamoto has joined #openstack-lbaas19:08
*** cpuga_ has quit IRC19:09
*** cpuga has quit IRC19:10
*** yamamoto has quit IRC19:12
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add member commands to client  https://review.openstack.org/46303519:13
*** rcernin has quit IRC19:17
*** aojea has joined #openstack-lbaas19:17
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add member commands to client  https://review.openstack.org/46303519:25
*** sshank has joined #openstack-lbaas19:30
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add l7policy commands to client  https://review.openstack.org/46243119:31
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Update help text for all commands  https://review.openstack.org/46644119:31
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add healthmonitor commands to client  https://review.openstack.org/46383019:31
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add l7rule commands to client  https://review.openstack.org/46280819:31
eanderssonNot sure whats up with the merge for that review19:33
rm_workyeah ...19:35
*** rcernin has joined #openstack-lbaas19:35
rm_worksomething is breaking19:35
xgerman_not sure if it was the best idea to remove tenant-id19:36
xgerman_https://www.irccloud.com/pastebin/LSenTXEu/19:36
xgerman_guess I need to run  a tenant-id -> project-id in the proxy…19:37
eanderssontenant-id should be kept for now I think19:37
rm_workxgerman_: so fix it to use project_id :P19:37
rm_workyeah19:37
xgerman_it’s just annoying19:37
rm_workeandersson: it's outside deprecation period19:37
rm_workxgerman_: not more annoying that tenant_id still existing >_>19:37
eanderssonI see - just know that when neutron just removed tenant-id it triggered a bug :p19:38
xgerman_mmh, then why is neutron still using it?19:38
rm_workbecause they can't get their shit together ^_^19:38
rm_workxgerman_: don't strive to be neutron, lol19:38
eanderssonhaha19:38
rm_workhttps://www.youtube.com/watch?v=UYKKQn3WXh019:39
eanderssonWas reffering to this one https://bugs.launchpad.net/neutron/+bug/169595419:39
openstackLaunchpad bug 1695954 in neutron "QoS policy API does not accept 'tenant_id' filter" [Medium,Opinion] - Assigned to Akihiro Motoki (amotoki)19:39
rm_workyeah, actually removing the stuff is how we figure out what needs to be fixed19:40
eanderssonWish tenant_id should just go away :D19:40
rm_workif we never remove it, it'll be there forever19:40
eandersson*could19:40
rm_workeandersson: ok infra says you need to stop changing the depends-on commit message :P19:41
rm_workit makes a new PR and that aborts testing with said message19:41
eanderssonhaha19:41
eanderssonI see19:41
eanderssonYea - the horizon guys wanted a more detailed description19:42
eanderssonand I am terrible at writing those19:42
*** cpuga has joined #openstack-lbaas19:48
johnsomOctavia meeting starting soon on #openstack-meeting-alt19:57
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to clear some excessive connection counts while we debug the intermittent request failures reported over the past few minutes20:05
*** gcheresh_ has joined #openstack-lbaas20:17
*** sshank has quit IRC20:18
*** gcheresh_ has quit IRC20:29
*** atoth has quit IRC20:44
*** sshank has joined #openstack-lbaas20:45
*** pcaruana has quit IRC20:53
*** pcaruana has joined #openstack-lbaas20:53
JudeChttps://review.openstack.org/#/c/463035/ should pool and members be positional or use --pool/--member?21:01
JudeCI was going to bring it up in that meeting but we ran out of time21:02
rm_workpositional I think is the only thing that makes sense for SET on members :(21:03
rm_workunfortunately21:03
JudeCso positonals for SET and keyword arguments for the rest?21:04
rm_workeugh then it's inconsistent though21:04
rm_worki'd just say make it all positional, keep <pool> as the first arg21:04
rm_workas it's logically first21:04
rm_workand call it good21:04
rm_workI'd +2 that21:04
rm_workwhat do you think L7Rule will do?21:05
rm_workit's the only other one that's a sub-object, right?21:05
JudeCAwesome thats what is committed tight now :)21:05
JudeCum21:05
JudeCL7rule needs to change to match21:05
JudeCI think21:05
rm_workthey'll have the same issue21:05
*** kobis has joined #openstack-lbaas21:06
johnsomYeah, let's do positional for all21:13
johnsomDarn, sorry I forgot to bring that up21:13
eanderssonYou guys mind if I do a quick patch to replace all non-lazy loaded log lines? e.g. LOG.debug('....{0}....'.format(x))21:16
eanderssonBasically anything using either format, or % for logging21:16
*** pcaruana has quit IRC21:16
*** kobis has quit IRC21:17
eanderssone.g. https://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/health_daemon/health_daemon.py#L7521:17
eanderssonOther projects has been doing massive cleansup on this e.g. trove https://github.com/openstack/trove/commit/c5d5007d18bd43555804ac91a550d055efcd8ddb21:19
johnsomrm_work was the person pushing for format so...21:20
rm_workformat CAN be done properly21:21
rm_workthis isn't the case here21:21
rm_workeandersson: go for it21:21
eanderssonhah21:21
rm_workIMO21:21
rm_workand yes, format is the future21:21
eanderssonI just wish the logging module would use it.21:21
rm_workor rather, at least better than %21:21
rm_workmaybe there is some new hotness21:21
eanderssonThe problem with logging and format is that filtering won't work.21:21
eanderssonalso if you ignore lets say DEBUG messages, if you use format you will still populate the string21:22
eanderssonIt's silly a format is superior :P21:22
eanderssonrm_work: Do you want to keep format in non-log lines?21:23
eanderssone.g. https://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/agent/api_server/keepalived.py#L13721:24
eanderssonI rather just focus on log lines.21:24
rm_workyeah21:24
*** Aju has joined #openstack-lbaas21:29
*** afranc has quit IRC21:29
johnsomSo, yeah, be our guest!21:33
eanderssonAlmost done :D21:35
*** sshank has quit IRC21:41
*** sshank has joined #openstack-lbaas21:42
openstackgerritGerman Eichberger proposed openstack/neutron-lbaas master: Octavia Proxy Plugin  https://review.openstack.org/41853021:43
*** rcernin has quit IRC21:44
*** cpuga has quit IRC21:45
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add l7rule commands to client  https://review.openstack.org/46280821:46
*** blogan has quit IRC21:46
*** catintheroof has joined #openstack-lbaas21:47
johnsomrm_work xgerman_ I think OSC is in your hands22:02
JudeCjohnsom wait on merging those22:02
johnsomhttps://review.openstack.org/#/q/project:openstack/python-octaviaclient+status:open22:02
JudeCpushing in one more commit to fix the positionals22:02
johnsomI must have missed one, I thought I saw those updates22:03
rm_workjohnsom: yeah i'll be poking at it for a bit22:05
JudeCjohnsom: the gerrit thing messed me up and I am rectifying my commits right now :/22:06
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Update help text for all commands  https://review.openstack.org/46644122:17
openstackgerritJude Cross proposed openstack/python-octaviaclient master: Add healthmonitor commands to client  https://review.openstack.org/46383022:17
JudeCok22:17
JudeCthere we go22:17
*** aojea has quit IRC22:18
openstackgerritErik Olof Gunnar Andersson proposed openstack/octavia master: Handle log message interpolation by the logger  https://review.openstack.org/47194722:30
*** chlong has quit IRC22:32
eanderssonWill need many eyes on that one to make sure I didn't sneak in a typo ^ :D22:35
*** leitan has joined #openstack-lbaas22:38
*** catintheroof has quit IRC22:46
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/47195222:49
eanderssonjohnsom, rm_work https://github.com/openstack/octavia/blob/master/octavia/network/drivers/neutron/allowed_address_pairs.py#L10222:51
eanderssonNot sure how that can work22:51
eandersson_ is never imported22:51
rm_workthat's normal22:52
rm_work_ is pretty much never imported22:52
rm_workit's like... a global macro22:52
eanderssonoh22:52
rm_worksometimes i import it22:52
rm_workso pycharm will shut up22:52
eanderssonhaha22:52
johnsomYep22:52
johnsomGeez, 129 commits between pike-1 and pike-2 on octavia22:53
johnsomWe have been busy....22:53
eanderssonThat's nuts22:53
johnsom259 files changed22:53
rm_workdoes it have counts by author? :P22:53
johnsomIt's all api-ref....22:54
johnsomJust kidding....22:54
rm_worklolol22:54
eanderssonbtw no reason for the doulbe (( in some log lines right? e.g. LOG.warning(('hello world'))22:57
rm_workrofl22:57
rm_worki don't believe so22:57
eandersson:D22:57
johnsomNo22:57
eanderssonGonna fix those as well22:57
rm_workprobably used to have substitution happening or something22:57
eanderssonYea22:58
johnsomIt's probably more fall out from removing translations22:58
*** leitan_ has joined #openstack-lbaas23:03
*** leitan has quit IRC23:05
*** leitan has joined #openstack-lbaas23:07
openstackgerritErik Olof Gunnar Andersson proposed openstack/octavia master: Handle log message interpolation by the logger  https://review.openstack.org/47194723:09
*** leitan_ has quit IRC23:10
*** yamamoto_ has joined #openstack-lbaas23:11
eanderssonThat ^ ended up being a little bigger than expected :D23:12
*** openstack has joined #openstack-lbaas23:16
*** yamamoto_ has quit IRC23:16
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/47195823:22
eanderssonWhat da heck is wrong with the req bot ^23:23
johnsomThat is what my patch is for from this morning.  We need to merge that horizon patch before I can merge the fix23:24
eanderssonActually that is for the neutron-lbaas-dashboard23:24
eanderssonit isn't gate blocked23:24
eanderssononly the octavia-dashboard23:24
johnsomYep23:24
johnsomBut the octavia dashboad has a bad .gitreview config that is pushing it's GR patches to neutron-lbaas-dashboard23:25
eanderssonahhh23:25
eanderssonI see23:25
eanderssonGlad I decided to work on a fix for that at 2AM now then :D23:25
eanderssonbecause that bot is annoying23:25
johnsomYes, I spent a while this morning trying to figure out what was up23:27
*** JudeC has quit IRC23:30
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/47195923:38
openstackgerritMerged openstack/octavia master: Remove deprecated oslo_messaging.get_transport  https://review.openstack.org/47127223:40
johnsomAlright, Pike-2 releases up for review: https://review.openstack.org/47196023:42
*** yamamoto_ has joined #openstack-lbaas23:47
*** sshank has quit IRC23:54
openstackgerritOpenStack Proposal Bot proposed openstack/neutron-lbaas-dashboard master: Updated from global requirements  https://review.openstack.org/47196423:57
« Tuesday, 2017-06-06 Index Thursday, 2017-06-08 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!