Monday, 2017-12-04

« Sunday, 2017-12-03 Index Tuesday, 2017-12-05 »
*** sticker_ is now known as sticker00:08
*** yuanying_ has quit IRC00:43
*** yuanying has joined #openstack-lbaas00:43
*** annp has quit IRC01:27
*** openstackgerrit has joined #openstack-lbaas01:31
openstackgerritZhaoBo proposed openstack/octavia master: Extend api to accept qos_policy_id  https://review.openstack.org/45830801:31
*** yamamoto has joined #openstack-lbaas01:45
*** sanfern has quit IRC02:09
*** sshank has quit IRC02:52
*** sshank has joined #openstack-lbaas03:47
*** yamamoto has quit IRC03:53
*** codenamelxl_ has joined #openstack-lbaas03:55
*** yamamoto has joined #openstack-lbaas03:55
codenamelxl_Hi everyone, i'm curious since Octavia now a standsalone project. Do i need to set Neutron service_provider to LOADBALANCERV2:Octavia:neutron_lbaas.drivers.octavia.driver.OctaviaDriver:default? Thanks03:59
johnsomIf you are using neutron-lbaas you do, if you are not using neutron-lbaas but using the octavia endpoint you do not need to set that setting.04:01
codenamelxl_I'm creating it through Octavia dashboard, so i'm asuming that i'm not using neutron-lbass, right?04:04
johnsomRight, octavia-dashboard does not need neutron-lbaas.  Unless you got an early dev version04:06
codenamelxl_I'm on master branch of octavia-dashboard so i'm good to go, i guess.04:09
*** annp has joined #openstack-lbaas04:10
johnsomYep, no neutron-lbaas there04:10
*** links has joined #openstack-lbaas04:13
codenamelxl_So i may have bigger problem. My floating Ip attached to the LB is not working. I'm aware that there is a bug with floating IP and VIP which is fixed in Pike. I'm on Pike. Also there is a bug with the ARP of DVR router with VIP. I have confirmed that my problem is not it. Any suggestion where to look into? Thanks04:21
*** yamamoto_ has joined #openstack-lbaas04:47
*** yamamoto has quit IRC04:51
johnsomIt is most likely a DVR bug.  If the VIP works directly it is not an Octavia issue.04:55
*** Alex_Staf has joined #openstack-lbaas05:11
*** Alex_Staf has quit IRC05:20
codenamelxl_Thanks, i'll look into neutron. Oh, and i can't ping the VIP AND VRRP from insinde the Amphora. Is that behaviour normal?05:27
*** sanfern has joined #openstack-lbaas05:34
*** eN_Guruprasad_Rn has joined #openstack-lbaas06:04
*** sanfern has quit IRC06:06
*** sticker_ has joined #openstack-lbaas06:10
*** sticker has quit IRC06:13
*** sticker_ has quit IRC06:14
openstackgerrithuangshan proposed openstack/octavia master: Check if it is used when creating a load balancer using vip_port_id  https://review.openstack.org/52506906:18
openstackgerritAdam Harwell proposed openstack/octavia master: Switch to using PKCS12 for TLS Term certs  https://review.openstack.org/50417506:38
*** sshank has quit IRC06:44
*** cody-somerville has quit IRC06:56
*** cody-somerville has joined #openstack-lbaas07:09
*** dayou has quit IRC07:14
*** eN_Guruprasad_Rn has quit IRC07:37
*** cody-somerville has quit IRC07:49
*** rcernin has quit IRC07:49
*** codenamelxl_ has quit IRC07:54
*** cody-somerville has joined #openstack-lbaas08:02
*** dayou has joined #openstack-lbaas08:02
*** dmellado has quit IRC08:06
*** dmellado has joined #openstack-lbaas08:08
*** slaweq has joined #openstack-lbaas08:11
*** tesseract has joined #openstack-lbaas08:13
*** bar_ has joined #openstack-lbaas08:14
*** AlexeyAbashkin has joined #openstack-lbaas08:16
sapd_rm_work, johnsom I think we have a bug when interactive with barbican, I'm using user1 create a container secret to store tls data, and when I use user1 create a LB, The error is admin user (in octavia config) can't get this container, I think we should use context of user1 instead admin,08:16
*** dmellado has quit IRC08:18
*** dmellado has joined #openstack-lbaas08:18
*** eN_Guruprasad_Rn has joined #openstack-lbaas08:19
*** pcaruana has joined #openstack-lbaas08:23
*** rcernin has joined #openstack-lbaas08:35
*** knsahm has joined #openstack-lbaas08:41
*** yamamoto_ has quit IRC08:47
knsahmafter upgrading newton to ocata i cannot create loadbalancer08:48
knsahmi see this error in octvial.log08:48
knsahmERROR wsme.api [req-9b3dea37-9e30-4aab-a0a6-c5c722ac89f0 4341f577d0614f56b31a01b19ee26792 e592ef2e0efb48199ba082f9941c42dc - default default] Server-side error: "An auth plugin is required to determine endpoint URL".08:48
knsahmdoes anybody has an example octavia.conf for ocata?08:49
*** yamamoto has joined #openstack-lbaas08:58
dayouhttps://github.com/openstack/openstack-ansible-os_octavia/blob/master/templates/octavia.conf.j209:03
dayouHere is a template for newer versions of octavia.09:03
dayou[keystone_authtoken] section contains most about authentication to keystone09:04
knsahmthanks09:04
*** Guest13268 is now known as zigo09:09
*** cody-somerville has quit IRC09:12
*** slaweq has quit IRC09:49
*** salmankhan has joined #openstack-lbaas10:09
*** salmankhan has quit IRC10:12
*** salmankhan has joined #openstack-lbaas10:12
*** ianychoi_ is now known as ianychoi10:24
*** yamamoto has quit IRC10:31
*** annp has quit IRC10:33
openstackgerritSanthosh Fernandes proposed openstack/octavia master: [WIP] L3 ACTIVE-ACTIVE Data model impact  https://review.openstack.org/52472210:53
openstackgerritHengqing Hu proposed openstack/octavia master: Switch to using PKCS12 for TLS Term certs  https://review.openstack.org/50417511:12
*** dayou has quit IRC11:15
*** yamamoto has joined #openstack-lbaas11:16
numansHi, can some one please take a look at this patch - https://review.openstack.org/#/c/510921/ - It adds OVN driver to neutron lbaas v211:21
*** dayou has joined #openstack-lbaas11:22
openstackgerritGuoqiang Ding proposed openstack/neutron-lbaas master: Choose correct log option by listener protocol  https://review.openstack.org/45361211:52
*** sanfern has joined #openstack-lbaas12:25
*** krypto has joined #openstack-lbaas12:29
*** krypto has quit IRC12:29
*** krypto has joined #openstack-lbaas12:29
*** rcernin has quit IRC12:31
*** bar_ has quit IRC12:53
*** links has quit IRC12:54
*** b_bezak has joined #openstack-lbaas12:55
openstackgerritSanthosh Fernandes proposed openstack/octavia master: [WIP] L3 ACTIVE-ACTIVE Data model impact  https://review.openstack.org/52472213:07
*** links has joined #openstack-lbaas13:31
*** oanson has quit IRC13:35
*** oanson has joined #openstack-lbaas13:37
sanfernHi johnsom,13:54
*** yamamoto_ has joined #openstack-lbaas14:08
*** yamamoto has quit IRC14:11
*** yamamoto_ has quit IRC14:20
openstackgerritSanthosh Fernandes proposed openstack/octavia master: [WIP] L3 ACTIVE-ACTIVE Data model impact  https://review.openstack.org/52472214:21
*** fnaval has joined #openstack-lbaas14:28
*** yamamoto has joined #openstack-lbaas14:29
*** yamamoto has quit IRC14:35
*** dayou has quit IRC14:38
*** eN_Guruprasad_Rn has quit IRC14:49
*** yamamoto has joined #openstack-lbaas14:52
*** yamamoto has quit IRC15:04
*** links has quit IRC15:10
*** knsahm has quit IRC15:16
*** AlexeyAbashkin has quit IRC15:20
*** dayou has joined #openstack-lbaas15:22
*** dayou has joined #openstack-lbaas15:22
*** yamamoto has joined #openstack-lbaas15:25
*** yamamoto has quit IRC15:25
*** knsahm has joined #openstack-lbaas15:29
*** armax has joined #openstack-lbaas15:30
*** knsahm has quit IRC15:50
*** yamamoto has joined #openstack-lbaas16:00
johnsomsanfern o/16:14
*** yamamoto has quit IRC16:22
*** longstaff has joined #openstack-lbaas16:25
xgerman_sanfern said he has trouble with http://logs.openstack.org/22/524722/5/check/neutron-lbaasv2-dsvm-api/2b78496/16:26
johnsomOk16:27
*** dayou has quit IRC16:28
johnsomWell, it looks like every tempest test is failing with his patch.16:30
johnsomsanfern You have a bug in your SQL: http://logs.openstack.org/22/524722/5/check/octavia-v1-dsvm-scenario/c1fdfea/logs/devstacklog.txt.gz#_2017-12-04_14_45_22_95616:31
*** bar_ has joined #openstack-lbaas16:31
*** armax has quit IRC16:33
*** armax has joined #openstack-lbaas16:34
bar_johnsom, hey16:39
johnsombar_ Morning16:40
bar_johnsom, Did you read my reply? https://review.openstack.org/#/c/523931/16:40
johnsombar_ No, not yet.  It's still 8am on a Monday.  grin  Haven't made it there yet.16:42
bar_lol16:42
bar_johnsom, understandable .it's almost 7pm here...16:43
johnsomsapd_ You may be hitting the ACL issue with barbican.  See the cookbook: https://docs.openstack.org/octavia/latest/user/guides/basic-cookbook.html#deploy-a-tls-terminated-https-load-balancer16:45
johnsomsapd_ You either have to change the barbican RBAC to allow octavia in or add an ACL to the objects stored there allowing octavia access.  We hope to make this better with the pkcs12 patch, but that has not landed yet.16:46
*** yamamoto has joined #openstack-lbaas16:51
mnaseris the tenant_id or owner of the lbaas vip port octavia or the tenant that created the lbaas?16:56
mnaserim troubleshooting https://github.com/terraform-providers/terraform-provider-openstack/issues/17316:56
mnaserit looks like terraform tries to apply some security groups to the vip port once the lb is created16:57
johnsommnaser This is probably related to this: https://review.openstack.org/52425416:57
mnaseryes16:57
mnaserabsolutely that makes sense16:57
mnaseralso quick backport review if anyone doesnt mind - https://review.openstack.org/#/c/523901/16:57
johnsomGerman found that the VIP was under the service account instead of the tenant.16:57
johnsomOk, this is going to drive me nuts.  The latest Chrome is stuttering and spiking the CPU.  It seems to have gotten worse over the weekend.  Wonder if others are seeing this too....16:58
xgerman_yep, if you apply my patch terradform will work like a champ (though I don’t muck with sec rules)16:59
mnaserjohnsom: chrome has a task manager built in, it helps you16:59
xgerman_Safari…16:59
johnsomYeah, it just shows "browser" spiking the CPU....16:59
xgerman_also I have seen ways to run Chrome inside docker to constrain it better16:59
mnasercan i get a quick +2 on that backport so that we can go back to tracking stable/pike 100% rather than stable/pike+1 patch for when i update octavia? :>17:00
johnsommnaser I think your depends-on is an issue in that patch.  It points to master devstack....17:00
mnaserjohnsom: gives than its merged, it'll go through right away17:01
mnaserchange IDs are the same across branches17:01
johnsomRight, but you have octavia stable/pike pointing to devstack master, not devstack stable/pike17:01
*** yamamoto has quit IRC17:01
mnaserhm thats a good question i wonder if zuulv3 just drops that depends on17:02
mnaseror if it cherry picks it17:02
mnaseranyways ill remove it17:02
xgerman_k17:02
mnaserdone, didnt notify in here oddly enough17:02
mnaserhttps://review.openstack.org/#/c/523901/ updated17:02
mnaseracls for gerritbot? :>17:02
johnsomYeah, stable branches don't trigger the bot....17:03
*** b_bezak has quit IRC17:03
mnaserwould you like me to make a change to notify the channel?17:03
*** b_bezak has joined #openstack-lbaas17:04
*** bar_ has quit IRC17:04
johnsomI have been on  the fence, I don't think most projects have stable notify.17:04
mnaserno problem, in puppet-openstack world we're always mostly backporting so we have it there :p17:05
*** b_bezak has quit IRC17:08
*** krypto has quit IRC17:11
*** LutzB has quit IRC17:13
sanfernThank johnsom ,17:17
sanfernjohnsom, Can you please review https://review.openstack.org/#/c/521138/17:17
johnsomYep, it is on the list17:19
sanfernThank you johnsom17:20
*** tesseract has quit IRC17:20
sanfernHow can i reproduce sql tests locally and verify ?17:22
johnsomsanfern That is failing with the database migration.  So all you need is a stock octavia mysql database and run "octavia-db-manage --config-file <alembic.cfg> upgrade head to reproduce17:23
sanferntoo much work :(17:25
openstackgerritSanthosh Fernandes proposed openstack/octavia master: [WIP] L3 ACTIVE-ACTIVE Data model impact  https://review.openstack.org/52472217:28
*** LutzB has joined #openstack-lbaas17:32
*** armax has quit IRC17:49
*** armax has joined #openstack-lbaas17:54
*** krypto has joined #openstack-lbaas17:58
*** krypto has quit IRC17:58
*** krypto has joined #openstack-lbaas17:58
*** sanfern has quit IRC18:25
*** bar_ has joined #openstack-lbaas18:28
*** gcheresh has joined #openstack-lbaas18:29
*** gcheresh has quit IRC18:29
*** gcheresh has joined #openstack-lbaas18:30
*** sanfern has joined #openstack-lbaas18:39
*** salmankhan has quit IRC18:50
rm_worksapd_: no, that is known18:50
rm_worksapd_: you're supposed to either:18:50
rm_worksapd_: 1) Use ACLs in Barbican to allow the Octavia user to access the secret18:51
rm_worksapd_: 2) Give the Octavia user an admin role in Barbican that allows it to get all objects18:51
rm_worksapd_: check out https://docs.openstack.org/octavia/latest/user/guides/basic-cookbook.html#deploy-a-tls-terminated-https-load-balancer18:52
rm_worksapd_: It explains the ACL stuff and provides example commands18:53
*** armax has quit IRC18:55
johnsomHa, I pointed to the same place...19:03
rm_workah yeah i missed your response in the scrollback19:07
rm_worki JUST rebased pkcs12 btw19:07
rm_worklast night19:07
rm_workOMG I can't believe I misspelled a word19:08
rm_workit must have been late >_> I blame the time19:08
rm_workoh well, dayou fixed it19:09
bar_xgerman_, ping19:28
xgerman_pong19:28
xgerman_I installed your patch on a fresh devstack and then got that error19:29
*** armax has joined #openstack-lbaas19:29
bar_I know, I commented on my own patch that it is a known issue19:29
bar_It's not my code...19:29
xgerman_ok19:30
bar_osc_lib doesn't know to parse None response.19:30
xgerman_aha19:31
bar_I think it tries to unpack it without checking it's None19:31
xgerman_probably19:31
bar_Failover should work, though19:31
xgerman_I am not sure if merging something which causes an error wouldn’t confuse our users rm_work johnsom19:31
xgerman_nmagnezi ?19:32
xgerman_https://review.openstack.org/#/c/522666/1019:33
rm_workyeah we need to figure out a workaround19:33
xgerman_+119:34
johnsomYep19:34
xgerman_can we fix that in osc or are they aware of the bug?19:34
bar_I didn't notify\propose anyone\thing yet19:34
xgerman_ok, I think we should try that before doing a workaround on our end19:35
bar_ok, where should I start, open a bug? propose a patch?19:35
johnsomBug first, followup patches are always welcome19:36
bar_ok19:37
bar_so the octaviaclient patch is on-hold for now?19:37
johnsomDean is usually on top of OSC/lib issues, so I would expect a fast response19:37
bar_where do they manage their bugs?19:37
johnsomI think here: https://bugs.launchpad.net/python-openstackclient19:38
johnsomYep, that is what is on pypi19:39
johnsombar_ Do you have a debug output for the issue?19:40
bar_what do you mean?19:40
bar_--debug?19:40
johnsomopenstack --debug ....19:40
johnsomYeah19:40
bar_I could have it19:41
bar_johnsom, do you want me to send it to you, I'm about to report the bug.19:41
bar_?19:41
johnsomIf it's in the bug that is fine, just post the link19:42
bar_xgerman_, note that fresh devstack isn't enough to test this patch, since it has a not-yet-merged octavia dependency19:45
xgerman_mmh19:45
openstackgerritBar RH proposed openstack/octavia master: Fix filtering in list API calls  https://review.openstack.org/52268919:46
*** krypto has quit IRC19:50
openstackgerritAdam Harwell proposed openstack/octavia master: WIP: Floating IP Network Driver (spans L3s)  https://review.openstack.org/43561219:59
openstackgerritMerged openstack/python-octaviaclient master: Avoid tox_install.sh for constraints support  https://review.openstack.org/52483820:03
rm_workjohnsom: found a bug in our noop testing :/20:07
openstackgerritAdam Harwell proposed openstack/octavia master: Update compute noop driver and tests, enable build test  https://review.openstack.org/52529520:07
rm_work^^20:07
rm_workwe weren't even running the main test because it was misnamed20:08
rm_workand it was super broken20:08
bar_johnsom, debug log: http://paste.openstack.org/show/628119/20:08
johnsomJoy20:08
rm_workeh just noop20:08
rm_workerk missed a thing tho, one sec20:09
openstackgerritAdam Harwell proposed openstack/octavia master: Update compute noop driver and tests, enable build test  https://review.openstack.org/52529520:09
rm_workmissed a reference to availability_zone (which is internal to my patch)20:09
*** salmankhan has joined #openstack-lbaas20:09
johnsomrm_work Impressive unit tests in there too20:10
rm_worklolol20:10
rm_workyeaaaahhh20:10
rm_workbut at least this one *catches* issues20:10
rm_workthe persistent failure of the neutron-lbaas api tests on my FLIP patch were because this unit test wasn't catching a bug on my side20:11
rm_workif it was running, i would have noticed immediately that i forgot a thing :P20:11
rm_workI think20:11
rm_workactually maybe not <_< but still it's dumb20:11
johnsomHow do you feel about fixing those others?20:12
rm_workmeh? :P20:13
rm_workoh, test_status too, bleh20:13
rm_workbut also, lol yeah20:14
rm_workfine one sec20:14
johnsomAnd get amp, but it's like four that are not doing anything useful20:14
*** salmankhan has quit IRC20:14
rm_workyeah rofl20:15
rm_worki'm doing it20:15
johnsomThank you20:15
rm_workk, that was not difficult. man our testing is bad.20:19
rm_workwhy is our testing so bad20:20
rm_workare we bad?20:20
rm_worki don't want to be bad :(20:20
johnsomHahaha, yes, some of that reflects poorly on the cores and PTLs at the time...  Grin20:20
rm_worki guess a lot of this was in the original "we need to land something, just merge it plzplz"20:20
rm_workinitial patchsets20:21
* johnsom notes that was two years go...20:21
rm_workyes20:21
rm_workand now it is our turn to suffer for our haste/laziness20:21
rm_workpast me is a jerk20:21
johnsomYep20:21
johnsomShame nuns for everyone20:22
rm_workwaiting on pep8 (still sad this takes like 5 minutes to run)20:22
rm_workso much shame20:22
rm_workfinally finished the latest season :P20:22
rm_worklike, last week >_< I was so late20:22
rm_workbarely avoided spoilers by the skin of my teeth20:22
johnsomYeah, I am wondering if that pylint comment it spits out is something we can optimize or not.20:23
rm_workwelllll20:23
rm_workit's great if you're running one-patch above master20:23
rm_workbut if you have a chain and run tests at the end...20:23
johnsomYeah20:23
rm_workwe might need to query git for "how many patches ahead are we" and use that20:23
rm_worki guess it's possible20:23
rm_workbut i mean, even the first part takes a long time somehow20:23
johnsomNot sure how much time it would save...20:23
openstackgerritAdam Harwell proposed openstack/octavia master: Update compute noop driver/tests (many were disabled/useless)  https://review.openstack.org/52529520:24
rm_workyeah, not the majority20:24
rm_work^^ there you go20:24
rm_workthe way our noop driver *works* is actually a little shitty20:24
johnsomExcellent, thank you sir.20:24
rm_worklike half of those ops overwrite each other as you run them20:24
rm_workso really you can only trust it to see what the very last thing that was run was20:24
openstackgerritAdam Harwell proposed openstack/octavia master: Producer/endpoint code to allow for amphora failovers  https://review.openstack.org/52530220:32
rm_work^^ pre-req for when I add failover to the amphora-api resources20:32
rm_workjohnsom: do you think people would agree to merge a patch that adds data models / get methods /conversion methods for FloatingIPs even though technically we don't USE those in the standard driver? assuming there are tests :P20:35
johnsomWell, maybe the better question is would people support an act/stdby that uses FLIPs instead of VRRP.20:36
rm_workyeah i'm ... working towards that20:37
rm_workbut trying to keep the size of the patch small :P20:37
rm_workso adding a lot of these little things ahead of time paves the way very well20:37
rm_workjohnsom: also, I forget when/if I wrote this -- do you think this makes sense to have upstream? https://review.openstack.org/#/c/435612/86/octavia/amphorae/backends/agent/api_server/keepalived.py20:38
rm_workwas it upstream originally maybe and removed and i missed removing it?20:39
johnsomrm_work on the FLIP thing, I think just make a chain of patches that lead up to an act/stdby flip derivative.  If you really want to cover your bases, put up a small spec.20:40
rm_workI'm currently in the process of seeing if there's any bugfixes I did in my driver that need to be pulled out and actually merged20:40
johnsomOk.  On the keepalived thing, the only thought I have is about who is managing that pid file. Is it systemd or keepalived itself?  If it's systemd we need to look and make sure it exists for upstart and probably sysvinit (though I have an itch to deprecate that one, but it may be similar to gentoo).  I just remember some interesting issues with pid files and the init systems.20:43
johnsomOtherwise I am good with it20:43
johnsomAh, ok, we already use that, so makes sense to me.20:46
johnsombar_ Are you around still?20:50
bar_johnsom, yup20:50
johnsomI think the issue with the failover command is it's getting response data back, but the columns aren't defined.  I'm still looking at it, but I don't think this is a cliff issue20:51
johnsomosc-lib20:51
bar_johnsom, perhaps this should be corrected? https://github.com/openstack/octavia/blob/master/octavia/api/v2/controllers/load_balancer.py#L54220:56
johnsombar_ I found it and commented on the patch.20:58
johnsomIt was inheriting from "ShowOne" instead of command20:58
johnsomSo it expected return data20:59
johnsomThat is my guess.  Delete inherits from command.Command, which is what I think you want.20:59
bar_johnsom, Failover does no issue a delete call21:00
johnsombar_ Right, I was just comparing how those commands were developed.21:01
bar_I'll give it a try nonetheless21:01
bar_cool21:01
bar_thx!21:01
johnsomNP, let me know if that fixes you up.  I need to release a client soon and kind of want all of this in it21:02
bar_johnsom, note the Octavia dependency21:03
johnsomThanks for the reminder21:03
*** gcheresh has quit IRC21:15
*** jcross has joined #openstack-lbaas21:22
*** jcross has quit IRC21:22
*** jcross has joined #openstack-lbaas21:22
bar_johnsom, can you explain why it is an advantage to keep retries after non-neutron exception?21:24
johnsomI don't trust neutron to always wrap exceptions in a neutron-exception21:24
bar_ha, ok.21:25
johnsomDoes it hurt to keep the other exception in the loop?21:25
bar_I don't know.21:26
bar_Doesn't seem right, though21:27
johnsomWell, maybe another reviewer will tell me I am full of it....21:28
johnsombar_ I thought you were going to make the project ID optional in OSC21:29
bar_lol21:29
johnsomfor show quota21:29
bar_sorry for that! I was.21:30
bar_wait... no21:30
bar_you talked me out of it!21:30
johnsomOh, ok. I thought we were just going to magically make it happen in the client since we had the project ID from keystone already.  It was the API I was not sure we should change.21:31
bar_oh! hahha it's not even my patch, so magic all around21:32
johnsomAh, right.  NM21:32
johnsomWell, this isn't working for me anyway.21:33
johnsomstack@devstackpy27-2:~/project/testoscpatches/python-octaviaclient$ openstack loadbalancer quota set --loadbalancer 200 f808c170e2ff42609b16a41efb1aac8f21:33
johnsomMissing required argument. Requires at least one of: --health-monitor, --listener, --loadbalancer, --member, --listener, --pool21:33
bar_johnsom, Do you have set-up that supports QoS?21:34
bar_*Quota21:34
bar_blaaa21:34
bar_nvm21:34
johnsom????21:34
bar_my mistake21:35
bar_It works for me21:35
johnsompool works for me, but --loadbalancer doesn't21:35
*** sshank has joined #openstack-lbaas21:35
bar_Are you sure that you have the latest version?21:35
bar_because he corrected that in the last patch set21:36
johnsomhealth monitor doesn't either.  hmm, I grabbed the top of the chain21:37
bar_looknig21:37
johnsom2f66bcec210915439218a8347e56a76d5b5150c021:37
*** pcaruana has quit IRC21:39
bar_johnsom, found it21:48
johnsomThe attrs are coming in different.  metavar?21:48
bar_it's another flag, dest21:49
bar_The names in the validation function should correlate with get_quota_attrs21:52
bar_'s return attrs21:52
*** rcernin has joined #openstack-lbaas22:07
bar_johnsom, I revised my review22:07
johnsomOk22:07
xgerman_cores: the cutoff for Q-2 in Neutron is Wednesday so kindly review https://review.openstack.org/#/c/418530/22:09
*** longstaff has quit IRC22:09
*** longstaff has joined #openstack-lbaas22:14
*** armax has quit IRC22:33
*** armax has joined #openstack-lbaas22:36
bar_johnsom, the log from here: https://github.com/openstack/octavia/blob/master/octavia/controller/worker/controller_worker.py#L701 is supposed to appear in devstack@o-cw, right?22:37
johnsomYes, that would go in o-cw22:39
johnsomThough I think that code path is only run from o-hm, so probably in that log if it was an HM failover22:39
bar_johnsom, first things first, the change the suggest to the octavia-client patch worked.22:40
bar_*change you have suggested22:41
bar_but, I can't seem to find this log in o-cw22:41
johnsomThat code should not run based on the API failover, it is the failover_loadbalancer path.22:43
johnsomThe method you linked is used by the HM22:44
bar_ah22:44
openstackgerritBar RH proposed openstack/python-octaviaclient master: Complement Octavia client with a set of features  https://review.openstack.org/52266622:45
*** sshank has quit IRC22:51
johnsomlongstaff Any comments on my changes to the spec?  I will continue with the reset today/tomorrow.23:00
bar_johnsom, xgerman_, thanks for the +2. Rebase does not undo Workflow, right?23:00
xgerman_yep23:00
bar_thx23:01
bar_xgerman_, failover should not raise now.23:01
johnsomI am looking at that patch now.23:02
johnsombar_ It would be nice if these were broken out a bit more. FYI23:02
johnsomI'm not asking you to do that now, but in the future.23:03
longstaffjohnsom changes to provider driver spec look fine23:03
johnsomOk, cool.  I'm looking for feedback.  I hope to finish going through it in the next few days.23:03
bar_johnsom, i'm aware of it, i'm also aware of q2. note I have removed VIP_QOS support exactly for that reason.23:03
johnsomOk23:04
xgerman_bar_ looking23:22
*** longstaff has quit IRC23:30
*** armax has quit IRC23:38
*** yamamoto has joined #openstack-lbaas23:38
*** fnaval has quit IRC23:43
*** armax has joined #openstack-lbaas23:53
johnsombar_ Some comments for https://review.openstack.org/#/c/52266623:56
*** ianychoi has quit IRC23:59
« Sunday, 2017-12-03 Index Tuesday, 2017-12-05 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!