rm_work | defensive coding everywhere | 00:00 |
---|---|---|
rm_work | don't get caught/screwed by an external service | 00:00 |
*** longstaff has joined #openstack-lbaas | 00:00 | |
xgerman_ | yeah, it should be done but the question is priority — | 00:00 |
rm_work | k | 00:00 |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Allow case-insevsitive enteries when selecting from choices https://review.openstack.org/525791 | 00:00 |
xgerman_ | BTW: reviewed your patch right away ;-) | 00:01 |
rm_work | my priority is "what is affecting me right now" :P which this just did | 00:01 |
rm_work | appreciate it :P | 00:01 |
xgerman_ | yeah, I always forget the wacky cloud you run… | 00:02 |
tongl | anyone noticed that in neutron-lbaas, adding more than 100 members to pool will slow down response significantly as the number increases. | 00:03 |
tongl | I am wondering if this is related to db access or something. | 00:04 |
xgerman_ | we don’t use neutron-lbaas | 00:04 |
xgerman_ | but the db access in that is pretty wacky | 00:04 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Move loading the network driver into the flows https://review.openstack.org/525790 | 00:04 |
*** longstaff has quit IRC | 00:04 | |
johnsom | tongl Yes, if you mean API access, we are aware of that issue with neutron-lbaas. It should be resolved in the octavia API | 00:05 |
johnsom | Or, at least better | 00:05 |
tongl | Great. another reason to persuade our customer to move over to octavia. | 00:05 |
xgerman_ | +1 | 00:06 |
rm_work | xgerman_: resolved your issue i hope :) | 00:06 |
xgerman_ | yep, I gave you +1 | 00:06 |
xgerman_ | rongl this might help: https://review.openstack.org/#/c/418530/ - bypasses Neutron… | 00:06 |
xgerman_ | tongl: | 00:07 |
tongl | good pointer, I am looking at it. thanks german | 00:09 |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Allow case-insevsitive enteries when selecting from choices https://review.openstack.org/525791 | 00:11 |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Allow case-insevsitive enteries when selecting from choices https://review.openstack.org/525791 | 00:12 |
tongl | Just came back from a long business trip. Need to spend some time to pickup what I missed. | 00:12 |
openstackgerrit | Merged openstack/python-octaviaclient master: Add loadbalancer stats client api and osc https://review.openstack.org/523306 | 00:14 |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Allow case-insensitive enteries when selecting from choices https://review.openstack.org/525791 | 00:15 |
*** fnaval has quit IRC | 00:17 | |
*** threestrands has quit IRC | 00:25 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: DNM: Revert "Disable kvm on OVH infra instances" https://review.openstack.org/525729 | 00:33 |
*** fnaval has joined #openstack-lbaas | 00:35 | |
johnsom | rm_work Remember it's only the scenario jobs. The API jobs and lbaas jobs don't count. I have made that mistake... | 00:35 |
rm_work | ahhh lol | 00:36 |
rm_work | i was just thinking the api jobs would be ok but yeah :P | 00:36 |
*** tongl has quit IRC | 00:36 | |
rm_work | correct | 00:36 |
johnsom | I got excited only to realize my test was bogus because I was looking at the worng job | 00:36 |
*** tongl has joined #openstack-lbaas | 00:36 | |
rm_work | heh | 00:37 |
*** tongl has quit IRC | 00:40 | |
bar_ | johnsom, I submitted another octaviaclient patch (https://review.openstack.org/#/c/525791/). No dependencies this time. | 00:43 |
johnsom | bar_ Thanks. I'm not sure I will have time to test/review that for Q2, but we still have Q3, so... | 00:44 |
*** SumitNaiksatam has left #openstack-lbaas | 00:46 | |
*** bar_ has quit IRC | 00:47 | |
openstackgerrit | Michael Johnson proposed openstack/octavia-dashboard master: Catch up with horizon framework https://review.openstack.org/523249 | 00:58 |
rm_work | wooow | 01:04 |
rm_work | that's a change | 01:04 |
johnsom | Yeah, but it looks much better. | 01:04 |
johnsom | My only concern is it requires a new openstacksdk they have not released yet. | 01:04 |
rm_work | umm | 01:04 |
rm_work | ah. | 01:04 |
johnsom | health monitor fails without the fix in openstacksdk | 01:05 |
johnsom | It's merged, but not yet released, GR, etc. | 01:05 |
johnsom | dayou This looks really good. | 01:05 |
dayou | Thanks, man! | 01:06 |
johnsom | My only worry is the openstacksdk package isn't out yet. | 01:06 |
johnsom | We may need to release Q2 without this one, but do it in Q3 | 01:06 |
johnsom | Thoughts? | 01:06 |
dayou | Monty told me there should be a new release soon | 01:06 |
dayou | I am ok with your arrangment, have no idea what is Q2 and what is Q3. | 01:07 |
johnsom | Ah, Queens milestone 2 and milestone 3 release. The are intermediate releases before the official Queens release of OpenStack | 01:07 |
johnsom | Queens 3 is when we have to have all of the features in. | 01:08 |
dayou | Ah, I see, May I stack a few other patches on this? To fix further bugs in octavia-dashboard later. | 01:09 |
*** longstaff has joined #openstack-lbaas | 01:09 | |
johnsom | Yes, no problem since we will push it to merge in after Q2 | 01:10 |
dayou | Got you | 01:10 |
johnsom | I have one comment so far. I will keep looking at it for a few more minutes | 01:10 |
dayou | Yes, keep me updated on this | 01:11 |
johnsom | I have to say though, the details pages look much nicer. Great work | 01:12 |
*** sshank has quit IRC | 01:13 | |
dayou | Also make the modifying easier later, since now all are resource registry based, if there are changes in api, just need to change some names | 01:13 |
*** longstaff has quit IRC | 01:14 | |
johnsom | dayou Ok, that one thing is all I saw. Just a string a bit long. It's been that long, but I really noticed it here. | 01:20 |
openstackgerrit | Merged openstack/octavia master: Fix filtering in list API calls https://review.openstack.org/522689 | 01:21 |
johnsom | Ok, time to make dinner. Thanks folks, I think we are in pretty good shape for Q2 release tomorrow. I will get a patch going in the morning here. | 01:23 |
dayou | Yes sir, I'll change that. | 01:23 |
dayou | Enjoy your dinner, BTW! | 01:24 |
johnsom | dayou, oh, I see the LB uuid wraps to in the drop down. Maybe a little tweak on that? | 01:24 |
johnsom | Both very minor | 01:24 |
dayou | I'll try to tweak that | 01:24 |
johnsom | I never know if that is just my browser/system or not. | 01:25 |
dayou | UUIDs are long, so it might wrap sometimes, I have to start a devstack and repick that, was working on something else. | 01:27 |
*** sshank has joined #openstack-lbaas | 01:40 | |
*** longstaff has joined #openstack-lbaas | 01:51 | |
*** longstaff has quit IRC | 02:00 | |
*** longstaff has joined #openstack-lbaas | 02:00 | |
*** sshank has quit IRC | 02:02 | |
*** longstaff has quit IRC | 02:03 | |
*** longstaff has joined #openstack-lbaas | 02:03 | |
*** longstaff has quit IRC | 02:03 | |
openstackgerrit | ZhaoBo proposed openstack/octavia master: Extend api to accept qos_policy_id https://review.openstack.org/458308 | 02:03 |
openstackgerrit | ZhaoBo proposed openstack/octavia master: Support UDP load balance https://review.openstack.org/503606 | 02:04 |
*** oanson has quit IRC | 02:12 | |
*** jniesz has quit IRC | 02:12 | |
*** oanson has joined #openstack-lbaas | 02:12 | |
openstackgerrit | huangshan proposed openstack/octavia master: Amphora API Failover call https://review.openstack.org/525778 | 02:31 |
openstackgerrit | Hengqing Hu proposed openstack/octavia master: Add element and flag to disable DHCP on amp images https://review.openstack.org/520590 | 02:35 |
dayou | Adam, there is a possbile solution, I tried on some vms, it works, it's revert back to use eth0 for ubuntu | 02:38 |
dayou | So there won't be any suprise, also aligned with your solution for redhat distributions | 02:38 |
dayou | Maybe we should do the same for fedora also | 02:39 |
dayou | They also use predictable interface names | 02:39 |
dayou | Lukily the solution is the same, disable cloud init networking and add net.ifnames=0 biosdevname=0 to kernel boot options | 02:41 |
*** tongl has joined #openstack-lbaas | 02:42 | |
*** SumitNaiksatam_ has joined #openstack-lbaas | 02:49 | |
rm_work | hmmm | 02:49 |
rm_work | dayou: not sure we want to disable cloud-init networking >_> | 02:49 |
dayou | Other it would generate it's own network configuration files overwrite ours | 02:52 |
rm_work | i'm not sure how? | 02:55 |
rm_work | mine doesn't | 02:55 |
rm_work | or rather | 02:55 |
rm_work | mine takes care of the issue | 02:55 |
rm_work | and then the cloud-init config overwrites it maybe after that? | 02:55 |
rm_work | it seems like my VMs do initial networking *before* cloud-init runs or something <_< | 02:56 |
openstackgerrit | Merged openstack/neutron-lbaas master: Octavia Proxy Plugin https://review.openstack.org/418530 | 02:58 |
openstackgerrit | huangshan proposed openstack/octavia master: Check if it is used when creating a load balancer using vip_port_id https://review.openstack.org/525069 | 03:01 |
*** tongl has quit IRC | 03:02 | |
dayou | During runtime, it will generate /etc/network/interfaces.d/50-cloud-init.cfg on ubuntu. | 03:26 |
*** annp has joined #openstack-lbaas | 03:37 | |
*** cody-somerville has quit IRC | 03:44 | |
openstackgerrit | Hengqing Hu proposed openstack/octavia master: ignore api-ref/build directory https://review.openstack.org/522385 | 03:44 |
openstackgerrit | Hengqing Hu proposed openstack/octavia master: Add element and flag to disable DHCP on amp images https://review.openstack.org/520590 | 03:53 |
*** links has joined #openstack-lbaas | 03:58 | |
*** links has quit IRC | 04:01 | |
*** links has joined #openstack-lbaas | 04:01 | |
sapd_ | hi rm_work, I think we should use context of user (who create a LB) instead of admin user when create listener, because only this user can get the secret,. | 04:05 |
*** cody-somerville has joined #openstack-lbaas | 04:07 | |
*** yamamoto has joined #openstack-lbaas | 04:12 | |
rm_work | sapd_: that will work short term, but not long term | 04:31 |
rm_work | sapd_: on a failover we won't have that user context | 04:31 |
rm_work | BUT we can use that user context to set up the ACLs ourselves, which is a trick that we've discussed as a possibility | 04:32 |
sapd_ | But, when use admin user, the worker can't get the secret. | 04:32 |
rm_work | it can if you set up the ACLs as the user | 04:32 |
sapd_ | we have to set ACL for admin user | 04:32 |
rm_work | or if you set up the octavia service user as a barbican Admin | 04:32 |
rm_work | yes | 04:32 |
sapd_ | barbican admin is scoped in project, so we have to set that in all projects | 04:33 |
rm_work | you can set up barbican to have a global secret viewer role | 04:33 |
rm_work | and give that to octavia | 04:33 |
rm_work | it's not a GOOD idea, but it's possible, and then you don't need ACLs | 04:33 |
rm_work | but really we recommend ACLs | 04:33 |
*** annp has quit IRC | 04:41 | |
*** annp has joined #openstack-lbaas | 04:42 | |
sapd_ | normally, normal user do not know about admin user-id | 04:45 |
*** sapd_ has quit IRC | 04:48 | |
*** sapd has joined #openstack-lbaas | 04:50 | |
*** threestrands has joined #openstack-lbaas | 05:09 | |
*** threestrands has quit IRC | 05:09 | |
*** tongl has joined #openstack-lbaas | 05:14 | |
*** Alex_Staf has joined #openstack-lbaas | 05:17 | |
*** csomerville has quit IRC | 05:22 | |
*** csomerville has joined #openstack-lbaas | 05:23 | |
rm_work | sapd: it's true :/ | 05:24 |
rm_work | sapd: we were recommending you document it <_< | 05:24 |
rm_work | or considering making an API call to expose it | 05:24 |
rm_work | BUT, i think the better option is modifying the barbican driver to do the ACLs for you | 05:24 |
rm_work | which ... maybe I will do tomorrow | 05:24 |
rm_work | and you can test the patch :P | 05:24 |
*** csomerville has quit IRC | 05:28 | |
*** csomerville has joined #openstack-lbaas | 05:28 | |
*** SumitNaiksatam_ has quit IRC | 05:31 | |
sapd | rm_work, what patch? please show me! :D | 05:40 |
*** yamamoto_ has joined #openstack-lbaas | 05:50 | |
*** yamamoto has quit IRC | 05:53 | |
*** tongl has quit IRC | 05:56 | |
*** yamamoto has joined #openstack-lbaas | 06:04 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 06:07 | |
*** yamamoto_ has quit IRC | 06:07 | |
*** AlexeyAbashkin has quit IRC | 06:11 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 06:12 | |
*** salmankhan has joined #openstack-lbaas | 06:20 | |
*** salmankhan has quit IRC | 06:24 | |
*** AlexeyAbashkin has quit IRC | 06:26 | |
*** gcheresh has joined #openstack-lbaas | 06:30 | |
openstackgerrit | Santhosh Fernandes proposed openstack/octavia master: [WIP] L3 ACTIVE-ACTIVE Data model impact https://review.openstack.org/524722 | 06:37 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia-dashboard master: Imported Translations from Zanata https://review.openstack.org/525908 | 06:54 |
*** rcernin has quit IRC | 07:02 | |
*** csomerville has quit IRC | 07:10 | |
*** tongl has joined #openstack-lbaas | 07:21 | |
*** dokua has quit IRC | 07:24 | |
*** dokua has joined #openstack-lbaas | 07:38 | |
*** rcernin has joined #openstack-lbaas | 07:39 | |
*** yamamoto_ has joined #openstack-lbaas | 07:42 | |
*** yamamoto has quit IRC | 07:46 | |
*** kobis has joined #openstack-lbaas | 07:46 | |
openstackgerrit | Hengqing Hu proposed openstack/octavia-dashboard master: Catch up with horizon framework https://review.openstack.org/523249 | 07:54 |
*** dokua has quit IRC | 08:02 | |
*** tongl has quit IRC | 08:06 | |
openstackgerrit | Hengqing Hu proposed openstack/octavia master: Add element and flag to disable DHCP on amp images https://review.openstack.org/520590 | 08:06 |
*** mnaser has quit IRC | 08:08 | |
*** mnaser has joined #openstack-lbaas | 08:11 | |
*** tesseract has joined #openstack-lbaas | 08:19 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 08:32 | |
*** AlexeyAbashkin has quit IRC | 08:38 | |
oanson | rm_work, nmagnezi, my patch from yesterday passes gate ( https://review.openstack.org/#/c/525504/ ). And I can't move to pure octavia at the moment ( https://bugs.launchpad.net/kuryr-kubernetes/+bug/1736677 ). | 08:44 |
openstack | Launchpad bug 1736677 in kuryr-kubernetes "Add native Octavia driver to support k8s services" [Undecided,New] | 08:44 |
oanson | Any thoughts on how to proceed? | 08:44 |
*** AlexeyAbashkin has joined #openstack-lbaas | 08:44 | |
rm_work | hmmm, i wonder what is different | 08:45 |
rm_work | nothing should be required to "support the native API" | 08:45 |
rm_work | it's the same API | 08:45 |
rm_work | it should "just work" | 08:45 |
rm_work | i don't remember why the port was disabled to begin with | 08:45 |
rm_work | we can ask tomorrow during the meeting if there is time | 08:46 |
oanson | As part of this bug, we'll debug my environment to see why it fails. | 08:46 |
oanson | I am hoping this can be merged as a temporary workaround | 08:46 |
nmagnezi | oanson, will look into that flow | 08:47 |
oanson | nmagnezi, rm_work, thanks! | 08:47 |
nmagnezi | made a comment in the patch | 08:47 |
nmagnezi | I wonder why it's created like that in the first place | 08:47 |
nmagnezi | there must be a reason.. | 08:47 |
rm_work | maybe | 08:47 |
rm_work | johnsom MIGHT know | 08:47 |
rm_work | I definitely don't | 08:47 |
nmagnezi | rm_work, o/ | 08:47 |
rm_work | i/ | 08:48 |
nmagnezi | that's a new one.. :D | 08:48 |
rm_work | lol bedtime for me | 08:48 |
nmagnezi | the dot is the head? :D | 08:48 |
oanson | nmagnezi, I think admin_state_up is set to True in the HAProxy agent, when it 'binds' the port | 08:48 |
rm_work | the dot is me being tired and missing the 'o' key | 08:48 |
oanson | s/binds/plugs/ | 08:48 |
*** AlexeyAbashkin has quit IRC | 08:49 | |
rm_work | honestly, my care level for neutron-lbaas is rapidly approaching zero -- i don't know if diving into this too deeply is really worth it, if your patch passes devstack gates, that's good enough for me <_< | 08:49 |
*** b_bezak has joined #openstack-lbaas | 08:49 | |
rm_work | we'll poke people about it tomorrow in the meeting though | 08:49 |
rm_work | but you REALLY should look at just switching off n-lbaas to octavia if possible | 08:49 |
oanson | rm_work, that's a must. I'm guessing neutron-lbaas will be deleted once deprecation period is over. | 08:50 |
rm_work | yes, though deprecation period hasn't technically started yet | 08:50 |
rm_work | we're hoping to mark it deprecated in Queens | 08:51 |
oanson | Ah. I thought it was done in pike | 08:51 |
nmagnezi | rm_work, some ppl still care. we'll get more ppl onboard with Octavia as soon as we add providers support | 08:51 |
rm_work | but yeah, you really shouldn't wait, neutron-lbaas is a pile of cobbled together junk IMO <_< | 08:51 |
nmagnezi | which I hope will happen as soon as possible | 08:51 |
rm_work | yes, it's only held together because we need to support providers | 08:51 |
nmagnezi | because indeed n-lbaas is on life support atm | 08:51 |
rm_work | and until we do, it's the only option | 08:51 |
nmagnezi | oanson, how do you use LBaaS exactly? Octavia as an endpoint or as a provider for n-lbaas ? | 08:54 |
oanson | nmagnezi, I don't know - I am using Kuryr, which calls octavia/lbaas API | 08:54 |
oanson | I am just trying to support the Dragonflow end. | 08:54 |
oanson | Which is the actual wiring to the amphora VMs | 08:55 |
nmagnezi | oanson, dragonflow is an interface driver for Neutron? how does it come into play here? | 08:55 |
nmagnezi | sorry I don't know this project | 08:55 |
oanson | Dragonflow is a Neutron backend - it implements the Neutron API (L2, L3, trunk, etc.) | 08:56 |
*** yamamoto_ has quit IRC | 08:56 | |
nmagnezi | oanson, so it completely replaces ML2+OVS, right? | 08:56 |
oanson | Yes | 08:56 |
numans | nmagnezi, Hi, the patch to add OVN driver in lbaas v2 is ready with test cases - https://review.openstack.org/#/c/510921/. Could you please add this to your review queue :) | 08:57 |
nmagnezi | oanson, so aside from a wiring for Octavia's health-manager (which you'll need to do by yourself in dragonflow), I don't think there is something to hold you back from using Octavia as a separate endpoint | 08:58 |
oanson | True. Only Dragonflow doesn't call Octavia directly | 08:58 |
nmagnezi | oanson, maybe it's time to update dragonlow to use the Octavia client ? :) | 08:59 |
nmagnezi | numans, np! :-) | 08:59 |
oanson | nmagnezi, my meaning was, Dragonflow doesn't call LBaaS API at all | 08:59 |
*** dokua has joined #openstack-lbaas | 08:59 | |
numans | nmagnezi, thanks | 08:59 |
oanson | This is all done via Kuryr, and Kuryr will update the API calls (hence the bug) | 08:59 |
*** yamamoto has joined #openstack-lbaas | 09:04 | |
*** dokua has quit IRC | 09:04 | |
openstackgerrit | Santhosh Fernandes proposed openstack/octavia master: Adding exabgp-speaker element to amphora image https://review.openstack.org/490164 | 09:07 |
*** AlexeyAbashkin has joined #openstack-lbaas | 09:14 | |
*** aojea has joined #openstack-lbaas | 09:56 | |
*** dokua has joined #openstack-lbaas | 10:01 | |
*** yamamoto has quit IRC | 10:05 | |
*** dokua has quit IRC | 10:05 | |
*** yamamoto has joined #openstack-lbaas | 10:08 | |
*** salmankhan has joined #openstack-lbaas | 10:10 | |
*** yamamoto has quit IRC | 10:13 | |
openstackgerrit | Omer Anson proposed openstack/octavia master: Set VIP port to be enabled https://review.openstack.org/526019 | 10:13 |
*** annp has quit IRC | 10:14 | |
*** bar_ has joined #openstack-lbaas | 10:24 | |
*** eN_Guruprasad_Rn has joined #openstack-lbaas | 10:48 | |
*** bar_ has quit IRC | 10:50 | |
openstackgerrit | Hengqing Hu proposed openstack/octavia master: Add element and flag to disable DHCP on amp images https://review.openstack.org/520590 | 10:52 |
*** yamamoto has joined #openstack-lbaas | 11:01 | |
*** dokua has joined #openstack-lbaas | 11:02 | |
*** dokua has quit IRC | 11:06 | |
*** aojea_ has joined #openstack-lbaas | 11:17 | |
*** aojea has quit IRC | 11:17 | |
*** yamamoto has quit IRC | 11:19 | |
openstackgerrit | Carlos Goncalves proposed openstack/python-octaviaclient master: Add Quota client API and OSC support https://review.openstack.org/518767 | 11:21 |
*** links has quit IRC | 11:34 | |
*** rcernin has quit IRC | 11:39 | |
*** dokua has joined #openstack-lbaas | 11:42 | |
*** bar_ has joined #openstack-lbaas | 11:45 | |
*** kobis has quit IRC | 11:47 | |
*** links has joined #openstack-lbaas | 11:48 | |
*** kobis has joined #openstack-lbaas | 11:50 | |
*** dindin has joined #openstack-lbaas | 11:52 | |
*** dindin has left #openstack-lbaas | 11:52 | |
*** AlexeyAbashkin has quit IRC | 11:58 | |
*** pseudo_ has joined #openstack-lbaas | 12:01 | |
*** openstackgerrit has quit IRC | 12:03 | |
*** yamamoto has joined #openstack-lbaas | 12:05 | |
*** links has quit IRC | 12:08 | |
*** pseudo_ has quit IRC | 12:12 | |
*** links has joined #openstack-lbaas | 12:13 | |
*** openstackgerrit has joined #openstack-lbaas | 12:21 | |
openstackgerrit | Carlos Goncalves proposed openstack/python-octaviaclient master: Add Quota client API and OSC support https://review.openstack.org/518767 | 12:21 |
*** eN_Guruprasad_Rn has quit IRC | 12:21 | |
*** issp has quit IRC | 12:26 | |
openstackgerrit | Carlos Goncalves proposed openstack/python-octaviaclient master: Add Quota client API and OSC support https://review.openstack.org/518767 | 12:31 |
openstackgerrit | Omer Anson proposed openstack/octavia master: Set VIP port to be enabled https://review.openstack.org/526019 | 12:45 |
*** AlexeyAbashkin has joined #openstack-lbaas | 12:46 | |
*** b_bezak has quit IRC | 12:48 | |
*** salmankhan has quit IRC | 12:49 | |
*** salmankhan has joined #openstack-lbaas | 12:51 | |
*** tesseract has quit IRC | 12:53 | |
*** tesseract has joined #openstack-lbaas | 12:57 | |
openstackgerrit | Carlos Goncalves proposed openstack/python-octaviaclient master: Add Quota client API and OSC support https://review.openstack.org/518767 | 12:57 |
*** links has quit IRC | 13:23 | |
*** eN_Guruprasad_Rn has joined #openstack-lbaas | 13:28 | |
*** eN_Guruprasad_Rn has quit IRC | 13:43 | |
openstackgerrit | Hengqing Hu proposed openstack/octavia master: Add element and flag to disable DHCP on amp images https://review.openstack.org/520590 | 13:49 |
*** dayou has quit IRC | 13:58 | |
*** b_bezak has joined #openstack-lbaas | 14:01 | |
*** dayou has joined #openstack-lbaas | 14:06 | |
*** sanfern has quit IRC | 14:06 | |
*** fnaval has quit IRC | 14:07 | |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Extend loadbalancer_create valid VIP parameters combinations https://review.openstack.org/519439 | 14:11 |
*** salmankhan has quit IRC | 14:14 | |
*** armax has quit IRC | 14:17 | |
*** salmankhan has joined #openstack-lbaas | 14:27 | |
*** gcheresh has quit IRC | 14:36 | |
*** tesseract has quit IRC | 14:37 | |
*** tesseract has joined #openstack-lbaas | 14:44 | |
*** armax has joined #openstack-lbaas | 14:49 | |
*** chandankumar has joined #openstack-lbaas | 14:52 | |
chandankumar | Hello | 14:52 |
chandankumar | I am volunteering for tempest plugin split Queens community goal. | 14:52 |
chandankumar | for octavia project there are bunch of reviews up https://review.openstack.org/#/q/project:openstack/octavia-tempest-plugin | 14:53 |
chandankumar | against seperated tempest plugin | 14:53 |
chandankumar | My query is are we using the new tempest plugin? if yes, then we are planning to remove the intree tempest plugin? | 14:54 |
chandankumar | johnsom: hello ^^ | 14:54 |
*** kobis has quit IRC | 14:55 | |
*** fnaval has joined #openstack-lbaas | 14:55 | |
*** issp has joined #openstack-lbaas | 14:57 | |
*** knsahm has joined #openstack-lbaas | 15:05 | |
*** knsahm has quit IRC | 15:17 | |
openstackgerrit | German Eichberger proposed openstack/neutron-lbaas master: Adds the missing stats command and fixes status https://review.openstack.org/525704 | 15:23 |
*** knsahm has joined #openstack-lbaas | 15:30 | |
bar_ | xgerman_, johnsom, please review the quota patch https://review.openstack.org/#/c/518767/ if you can | 15:31 |
*** bzhao has quit IRC | 15:33 | |
*** bbzhao has quit IRC | 15:33 | |
*** tongl has joined #openstack-lbaas | 15:52 | |
*** longstaff has joined #openstack-lbaas | 15:55 | |
*** ianychoi has quit IRC | 15:56 | |
*** ianychoi_ has joined #openstack-lbaas | 15:56 | |
*** ianychoi_ is now known as ianychoi | 15:57 | |
johnsom | chandankumar The answer is yes, but sadly the work has stalled a bit. We need more reviews and to get that stack of patches straightened out. So, summary, still in plan, but at risk for queens at the current velocity. | 16:07 |
johnsom | bar_ Thanks! I will look first thing this morning | 16:07 |
chandankumar | johnsom: so new tempest plugin is ready? can we consume in octavia ci? | 16:08 |
bar_ | johnsom, thanks. A little heads up, I currently have merge conflict on the amphora+failover client patch | 16:09 |
johnsom | chandankumar, not ready yet, in progress. We have added a gates for it in the plugin project, just not yet in main Octavia. We need more of that to land. | 16:09 |
johnsom | bar_ that is fine, we can straighten that out later | 16:09 |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Add Quota client API and OSC support https://review.openstack.org/518767 | 16:21 |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Complement Octavia client with a set of features https://review.openstack.org/522666 | 16:22 |
*** knsahm has quit IRC | 16:29 | |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Add Quota client API and OSC support https://review.openstack.org/518767 | 16:31 |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Extend loadbalancer_create valid VIP parameters combinations https://review.openstack.org/519439 | 16:34 |
*** Alex_Staf has quit IRC | 16:51 | |
*** AlexeyAbashkin has quit IRC | 16:54 | |
*** sanfern has joined #openstack-lbaas | 17:07 | |
johnsom | bar_ stack@devstackpy27-2:~/devstack$ openstack loadbalancer quota set --loadbalancer 100 admin | 17:17 |
johnsom | Missing required argument. Requires at least one of: --health-monitor, --listener, --loadbalancer, --member, --listener, --pool | 17:17 |
*** eN_Guruprasad_Rn has joined #openstack-lbaas | 17:17 | |
bar_ | this is probably my fault | 17:17 |
johnsom | Oh, dang, that isn't master, there is a bad chain | 17:17 |
bar_ | yup | 17:18 |
johnsom | Yeah, master works. I'm going to keep checking that. I bet the others just need a rebase | 17:18 |
bar_ | https://review.openstack.org/#/c/522666/13 won't rebase automatically | 17:19 |
johnsom | Ok, there is a problem with health monitor. The output shows "health_monitor" but the command is --healthmonitor | 17:19 |
johnsom | Same with load_balancer and loadbalancer | 17:20 |
bar_ | ah, I saw that, but I was not sure it is a problem | 17:20 |
bar_ | see quota.inc | 17:20 |
johnsom | Yeah, the output needs to match the params. People use the output formatting as input into other calls. Plus it's just confusing | 17:21 |
bar_ | cgoncalves, ^^ | 17:21 |
*** eN_Guruprasad_Rn has quit IRC | 17:22 | |
johnsom | Since we already have --loadbalancer in another command, let's just drop the underscores here | 17:23 |
*** yamamoto has quit IRC | 17:23 | |
bar_ | johnsom, How much time do I have to fix the rebase conflict? | 17:25 |
johnsom | Umm, like now-ish. An hour? I'm creating the release patch right now. | 17:26 |
johnsom | So we need these things cleaned up as soon as we can as they still need reviews.... | 17:26 |
bar_ | johnsom, I'm currently occupied with the rebase. I would suggest string.replace('_','') on rows in all take_action that actually display something in quota.py | 17:30 |
johnsom | Ok, I need to finish setting up this patch, then I will take a look at the quota patch | 17:31 |
bar_ | If by 'this patch' you mean Complement Octavia client with a set of features, then patch 14 is dirty - don't try to fix it. | 17:32 |
*** aojea_ has quit IRC | 17:32 | |
johnsom | No, the release patch | 17:32 |
*** aojea has joined #openstack-lbaas | 17:35 | |
*** aojea has quit IRC | 17:40 | |
*** salmankhan has quit IRC | 17:47 | |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Complement Octavia client with a set of features https://review.openstack.org/522666 | 17:49 |
*** salmankhan has joined #openstack-lbaas | 17:49 | |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Complement Octavia client with a set of features https://review.openstack.org/522666 | 17:55 |
*** sshank has joined #openstack-lbaas | 17:57 | |
cgoncalves | bar_: aaaand we're back to the _ vs - vs oneword :D | 18:05 |
bar_ | cgoncalves, totally. I commented on your patch. | 18:05 |
johnsom | cgoncalves Ha, welcome to community based development.... So, I want to error on the side of consistency. Were there other comments? | 18:06 |
bar_ | not from my side | 18:06 |
johnsom | Ok, wasn't sure if I was the lone voicer or.... | 18:06 |
cgoncalves | bar_, johnsom: at this point, instead of workaround with str.replace and what not, I'd rather suggest going first for the consistency effort and then refresh the quota patch | 18:07 |
*** tesseract has quit IRC | 18:07 | |
bar_ | cgoncalves, it won't help, because the row names will never match the argument names. | 18:08 |
johnsom | So, just make load_balancer->loadbalancer and health_manager->healthmanager ? That is my proposal as it matches how loadbalancer is in listener output | 18:08 |
bar_ | row names originate from json response, while argument names don't have '_' | 18:08 |
bar_ | (=underscores) | 18:08 |
johnsom | Yeah, this all comes from the oddity of the osc rules I think. Looking for that. | 18:10 |
cgoncalves | the problem is that we have --loadbalancer(s) args elsewhere than quota. also I think --health_monitor or something, can't remember | 18:11 |
johnsom | The guidelines are all here: https://docs.openstack.org/python-openstackclient/latest/contributor/humaninterfaceguide.html | 18:12 |
cgoncalves | and it should be --load-balancer according to osc guidelines and octavia api expects load_balancer. osc translates automatically --load-balancer to api parameter load_balancer | 18:12 |
johnsom | But for now, let's just align them to no '_' then review for consistency in Q3 | 18:12 |
cgoncalves | k | 18:12 |
johnsom | Yeah, it looks like it should be '-' | 18:13 |
cgoncalves | --loadbalancer and --healthmonitor than | 18:13 |
johnsom | Ok. So we know we need to go to '-' | 18:13 |
cgoncalves | to be consistent with existing arguments | 18:13 |
cgoncalves | yes | 18:13 |
johnsom | So, let's do load-balancer and health-monitor for both the option and the show/list output column name | 18:13 |
cgoncalves | I had '-' in early patch sets.. ;) | 18:13 |
bar_ | johnsom, whoever wrote the rules had never had the word "loadbalancer" in mind. | 18:13 |
bar_ | ref: "openstack loadbalancer quota set --load-balancer -1" | 18:14 |
*** sshank has quit IRC | 18:14 | |
johnsom | Yeah, and everyone has an opinion on that... ha. I don't care what it is as long as it's consistent | 18:14 |
cgoncalves | johnsom: so --load-balancer and --health-monitor? | 18:14 |
bar_ | It's impossible to remember both loadbalancer and load-balancer in the same command line | 18:14 |
johnsom | Boy, all of our output is '_' though. | 18:15 |
johnsom | Yeah, let's be broken but consistent. 'loadbalancer' 'healthmonitor' | 18:15 |
bar_ | johnsom, I still +1 the current patch set. I think that is a fix beyond the quota patch. | 18:15 |
johnsom | let me look at what we have again. Just a second. | 18:16 |
johnsom | Sorry for the last minute research/confusion here. | 18:16 |
*** sshank has joined #openstack-lbaas | 18:16 | |
johnsom | Yeah, ok. Let's leave what is there | 18:17 |
*** salmankhan has quit IRC | 18:17 | |
bar_ | +! | 18:17 |
bar_ | +1 | 18:17 |
cgoncalves | \o/ | 18:18 |
*** jniesz has joined #openstack-lbaas | 18:18 | |
bar_ | https://review.openstack.org/#/c/519439/ needs +Workflow | 18:18 |
johnsom | cgoncalves FYI, we don't use DocImpact anymore. The docs are all in the repo now so the doc updates should be part of the patch. This was a recent change by the docs team. | 18:19 |
bar_ | xgerman_, thx | 18:19 |
*** sshank has quit IRC | 18:19 | |
xgerman_ | yeah, johnsom wants to release ;-) | 18:19 |
cgoncalves | johnsom: understood | 18:20 |
bar_ | https://review.openstack.org/#/c/522666 is still not good, I will rebase it once those two get merged | 18:20 |
johnsom | You can't rebase now? | 18:20 |
bar_ | It had rebase conflict before, currently its parent is master | 18:21 |
johnsom | Would you like me to rebase it for you? | 18:21 |
bar_ | I can do it if it is needed | 18:21 |
bar_ | or you could, I don't care | 18:21 |
*** sshank has joined #openstack-lbaas | 18:22 | |
johnsom | Give me a minute. I would like to get that in too | 18:22 |
bar_ | I thought it would be more robust to wait for the last patch set of the other two patches, instead of dealing with more conflict | 18:22 |
johnsom | It was all working | 18:22 |
bar_ | stats patch broke it earlier today | 18:23 |
bar_ | it had a lot of similar code at the very same files. | 18:23 |
*** yamamoto has joined #openstack-lbaas | 18:24 | |
bar_ | the current patch set is the product of manual rebase ontop of master | 18:24 |
rm_work | oanson: i just don't understand what "updates" to the calls need to happen. The API should be 100% backwards compatible. You should just have to switch the URL you're calling | 18:25 |
rm_work | bar_ / johnsom: usually the solution if you KNOW something else is going to merge first is to just go ahead and rebase it on the end of that chain :) | 18:28 |
johnsom | Right | 18:28 |
johnsom | Ugh, so it looks like there is a difference in the last patch about the URL path code.... | 18:29 |
bar_ | sorry, I didn't have a clue it's going to rebase before mine. stats is more recent... | 18:29 |
bar_ | *to rebase = to merge | 18:29 |
*** yamamoto has quit IRC | 18:30 | |
bar_ | johnsom, are you referring my patch? | 18:31 |
johnsom | Yeah, you have the right prefix, the quota patch doesn't but somehow gets it???? | 18:32 |
johnsom | Ah, you change them all | 18:33 |
openstackgerrit | Merged openstack/python-octaviaclient master: Add Quota client API and OSC support https://review.openstack.org/518767 | 18:42 |
openstackgerrit | Merged openstack/python-octaviaclient master: Extend loadbalancer_create valid VIP parameters combinations https://review.openstack.org/519439 | 18:46 |
bar_ | on it. | 18:47 |
rm_work | ok what's our priority merge list? | 18:48 |
rm_work | do we have one put together? | 18:48 |
rm_work | I have a little bit before lunch/meeting | 18:48 |
rm_work | (or, possibly lunch after the meeting...) | 18:48 |
johnsom | rm_work We are done except for this last client patch I am rebasing/fixing tests. It will need a review/test | 18:49 |
rm_work | k | 18:50 |
openstackgerrit | Michael Johnson proposed openstack/python-octaviaclient master: Complement Octavia client with a set of features https://review.openstack.org/522666 | 18:50 |
johnsom | This is the rebase ^^^ | 18:50 |
johnsom | But it has some test issues to fix, working on those | 18:50 |
openstackgerrit | Michael Johnson proposed openstack/python-octaviaclient master: Complement Octavia client with a set of features https://review.openstack.org/522666 | 18:53 |
bar_ | johnsom, thx | 18:59 |
openstackgerrit | Santhosh Fernandes proposed openstack/octavia master: [WIP] L3 ACTIVE-ACTIVE Data model impact https://review.openstack.org/524722 | 19:00 |
*** sshank has quit IRC | 19:00 | |
johnsom | bar_ NP, can you give it a quick scan and make sure nothing jumps out at you? | 19:02 |
johnsom | It seems to work for me. | 19:02 |
*** sanfern has quit IRC | 19:02 | |
bar_ | yeah, I'm testing it right now | 19:02 |
* rm_work improves test coverage | 19:09 | |
nmagnezi | this channel is becoming crowded | 19:10 |
rm_work | i wonder if it's possible to tweak coverage gate not to check the coverage compared to some static number, but just to check ... if coverage has gone down | 19:10 |
nmagnezi | me like :) | 19:10 |
rm_work | yeah we're doing pretty well compared to a lot of channels honestly >_> | 19:10 |
rm_work | it's nice for us, sad for them maybe | 19:10 |
*** sshank has joined #openstack-lbaas | 19:11 | |
nmagnezi | they are invited to join our little corner in openstack :) | 19:11 |
*** leitan has joined #openstack-lbaas | 19:14 | |
*** yamamoto has joined #openstack-lbaas | 19:26 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Move loading the network driver into the flows https://review.openstack.org/525790 | 19:29 |
rm_work | xgerman_: ^^ that should make you happy | 19:29 |
rm_work | coverage++ | 19:30 |
*** yamamoto has quit IRC | 19:31 | |
*** harlowja has quit IRC | 19:32 | |
xgerman_ | aweet | 19:33 |
xgerman_ | sweet | 19:33 |
rm_work | got the test you wanted and fixed coverage for most of the rest of that file :) thanks for the +2 | 19:34 |
*** harlowja has joined #openstack-lbaas | 19:36 | |
bar_ | https://review.openstack.org/#/c/522666/18 lgtm | 19:38 |
bar_ | johnsom, nmagnezi, rm_work, xgerman_ ^ | 19:39 |
xgerman_ | rm_work thanks | 19:40 |
xgerman_ | bar_ it looks we have some stats command in that without mention ing it in the commit message - | 19:42 |
xgerman_ | johnsom should we let that slide or… | 19:42 |
bar_ | xgerman_, stats is another patch, that's just rebase. | 19:43 |
johnsom | xgerman That came in from the stats patch parent | 19:43 |
xgerman_ | k, *grumble* can’t we do better rebases… | 19:43 |
*** sshank has quit IRC | 19:44 | |
johnsom | I think you mean can't gerrit do a better job a distinguishing parent patches | 19:45 |
xgerman_ | ^^ that | 19:45 |
openstackgerrit | Bar RH proposed openstack/octavia master: Fail-proof VIP deallocation task https://review.openstack.org/523931 | 19:49 |
*** Kowsalya has joined #openstack-lbaas | 19:57 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Amphora API Failover call https://review.openstack.org/525778 | 19:57 |
*** leitan has quit IRC | 19:59 | |
rm_work | ^^ not sure why this was rebased to begin with | 19:59 |
*** leitan has joined #openstack-lbaas | 19:59 | |
johnsom | #startmeeting Octavia | 20:00 |
openstack | Meeting started Wed Dec 6 20:00:15 2017 UTC and is due to finish in 60 minutes. The chair is johnsom. Information about MeetBot at http://wiki.debian.org/MeetBot. | 20:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 20:00 |
*** openstack changes topic to " (Meeting topic: Octavia)" | 20:00 | |
openstack | The meeting name has been set to 'octavia' | 20:00 |
*** b_bezak has quit IRC | 20:00 | |
johnsom | Hi folks! | 20:00 |
cgoncalves | o/ | 20:00 |
nmagnezi | o/ | 20:00 |
longstaff | hi | 20:00 |
rm_work | o/ | 20:00 |
bar_ | hi | 20:00 |
johnsom | #topic Announcements | 20:00 |
*** openstack changes topic to "Announcements (Meeting topic: Octavia)" | 20:00 | |
*** b_bezak has joined #openstack-lbaas | 20:00 | |
jniesz | hi | 20:01 |
johnsom | On the top of the announcements list is the milestone 2 release for queens. | 20:01 |
johnsom | I will be posting our release patch right after the meeting | 20:01 |
xgerman_ | o/ | 20:01 |
johnsom | Thank you to everyone for the great work that has gone into this patch! | 20:01 |
xgerman_ | +1 | 20:02 |
johnsom | Well, milestone I guess. | 20:02 |
rm_work | yeah, we still have until Q-3 to finish up remaining features | 20:02 |
xgerman_ | next last milestone is in 6 weeks! | 20:02 |
johnsom | This means, we are in the last segment before feature freeze at milestone 3. | 20:02 |
johnsom | Feature freeze for milestone 3 is Jan 22 | 20:03 |
nmagnezi | i wish we'll get the specs in before that milestone | 20:04 |
johnsom | We have a lot of stuff in-flight, so please review patches and vote. | 20:04 |
johnsom | I certainly hope so... | 20:04 |
*** leitan has quit IRC | 20:04 | |
rm_work | it'd have to be specs AND code, no? | 20:04 |
rm_work | to make Queens | 20:04 |
xgerman_ | yep, code | 20:04 |
johnsom | We can still merge specs, | 20:04 |
xgerman_ | +1 | 20:04 |
xgerman_ | I think they got a bit more relaxed with keeping specs rolling | 20:05 |
*** b_bezak has quit IRC | 20:05 | |
nmagnezi | +200 rm_work , but we need those in first.. trying to to be greedy here :) | 20:05 |
rm_work | heh | 20:05 |
johnsom | Also note, the PTG in Dublin is open for registration and the hotel block is available. | 20:06 |
johnsom | Any other announcements today? | 20:06 |
johnsom | #topic Brief progress reports / bugs needing review | 20:07 |
*** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)" | 20:07 | |
jniesz | #link https://review.openstack.org/#/c/519509/ | 20:07 |
johnsom | I have been working on the driver spec. | 20:07 |
johnsom | #link https://review.openstack.org/509957 | 20:08 |
jniesz | looks like we are close on that one, just need one more core : ) Looks at rm_work | 20:08 |
johnsom | I would like to see some reviews on the QoS patch: | 20:08 |
johnsom | #link https://review.openstack.org/458308 | 20:08 |
johnsom | That should pretty much be done. | 20:08 |
xgerman_ | okey | 20:09 |
johnsom | We also have a UDP protocol spec in flight that can use some reviews: | 20:09 |
johnsom | #link https://review.openstack.org/503606 | 20:09 |
xgerman_ | #link https://review.openstack.org/#/c/525704/ - watch that space | 20:09 |
rm_work | yeah i've been having some crazy internal fires, but that just wrapped up ... if someone compiles a list of patches ordered by priority, I will work down the list, otherwise I'll just pick random stuff from this meeting's links I guess | 20:10 |
johnsom | I have put in the community goals update patch for the tempest plugin (we need to report for MS2). Those could use some love as well. | 20:10 |
johnsom | rm_work I will try to put something together | 20:11 |
johnsom | Any other updates? | 20:12 |
nmagnezi | +1 , such list would be great to have | 20:12 |
jniesz | +1 same | 20:12 |
johnsom | Ok, we have a list of other topics on the agenda. I will go down the list and ask the requester to speak to them. | 20:13 |
johnsom | #topic (BAR_RH) Members API Improvements Proposal | 20:13 |
*** openstack changes topic to "(BAR_RH) Members API Improvements Proposal (Meeting topic: Octavia)" | 20:13 | |
bar_ | k | 20:13 |
bar_ | Currently the URL for members show is: rest_method:: GET /v2.0/lbaas/pools/{pool_id}/members/{member-id} | 20:13 |
bar_ | Why not allow to address a member WITHOUT POOL_ID. e.g.: GET /v2.0/octavia/members/{member_id} | 20:13 |
bar_ | That's my proposal pretty much, since member_id is unique | 20:14 |
cgoncalves | +1 | 20:14 |
xgerman_ | so basically that saves people from writing tow ids? Or is there another benefit? | 20:15 |
rm_work | yeah honestly i have been wondering this | 20:15 |
johnsom | Would it be for a situation where members are shared? | 20:15 |
rm_work | i think we were considering shared members | 20:15 |
nmagnezi | #link https://storyboard.openstack.org/#!/story/2001317 | 20:15 |
rm_work | ^^ yeah that | 20:15 |
rm_work | but, our DB model doesn't work for that | 20:15 |
johnsom | This decision pre-dates me on the project, so I don't have the historical reasoning | 20:15 |
nmagnezi | I'm in favor of that. but on the other hand I also submitted the story.. | 20:15 |
rm_work | since it puts pool_id directly in the member table schema | 20:15 |
rm_work | sooooo | 20:15 |
rm_work | this is really a shared-members discussion i think | 20:16 |
rm_work | schema is easier to change than API | 20:16 |
rm_work | if we change the API, we're stuck | 20:16 |
*** Kowsalya has quit IRC | 20:16 | |
johnsom | Well, for backward compatibility we need to retain the current API path. | 20:16 |
xgerman_ | +1 | 20:16 |
nmagnezi | rm_work, If members would be shared between the pools we'll need to think about this a bit more. for example an ability to get a list of pool the member is a part of etc | 20:17 |
nmagnezi | i agree with johnsom here | 20:17 |
bar_ | The new API must allow list in the field of pool_ids. | 20:18 |
openstackgerrit | Merged openstack/python-octaviaclient master: Complement Octavia client with a set of features https://review.openstack.org/522666 | 20:18 |
bar_ | if shared-members is an option. | 20:18 |
bar_ | yay! | 20:18 |
xgerman_ | well, the other problem I see is that we treat members as part of the pool and delete them with the pool | 20:18 |
nmagnezi | bar_, awesome job on ^^ :) | 20:19 |
bar_ | nmagnezi, thx | 20:19 |
nmagnezi | xgerman_, right. we actually discussed this in the providers spec review. currently when we delete a pool we cascade and delete members | 20:20 |
nmagnezi | and I think also health monitors | 20:20 |
cgoncalves | is there anyone we could ask the historical reasoning for pool_id in GET member? | 20:20 |
rm_work | umm | 20:21 |
rm_work | me, johnsom, xgerman_ | 20:21 |
nmagnezi | cgoncalves, git log ? :D | 20:21 |
rm_work | sbalukoff_ :P | 20:21 |
rm_work | we made the spec as-is | 20:21 |
nmagnezi | dougwig :P | 20:21 |
rm_work | yes, heh | 20:21 |
cgoncalves | haha! | 20:22 |
rm_work | dougwig but he is not here for me to highlight T_T | 20:22 |
johnsom | We could try to reach out to folks, but most everyone is not on OpenStack anymore. I think xgerman_ might be the only person that was in Atlanta when that API was designed. | 20:22 |
rm_work | <<--- | 20:22 |
rm_work | johnsom: weren't you also? | 20:22 |
johnsom | Nope | 20:22 |
johnsom | Before my time | 20:22 |
rm_work | yeah xgerman_ and me and sbalukoff_ and jorgem | 20:22 |
rm_work | and dougwig and ... | 20:22 |
rm_work | evgeny and sam | 20:22 |
rm_work | i am pretty sure it was for future shared members | 20:23 |
cgoncalves | ok, they all have got a notification on their irc clients. hopefully they will shed some light later | 20:23 |
rm_work | i think that's the only reason | 20:23 |
rm_work | just sbalukoff_ and i doubt it :P | 20:24 |
nmagnezi | i think that even if we don't get a reply about this, there's a value of looking at this with fresh eyes and decide about it | 20:24 |
rm_work | so let's table that and call it "Shared Members? Yes/No/Abort/Retry/Fail" | 20:24 |
nmagnezi | rm_work, not sure this is what bar_ had in mind :D | 20:25 |
cgoncalves | nmagnezi: +1 | 20:25 |
rm_work | Yes, but that's what the core of the discussion is | 20:26 |
bar_ | I am aware of that notion, and my API should be established in light of new notion like shared-members. | 20:26 |
rm_work | "Can we drop the pool-id on the member lookup" equates to "are we going to drop the idea of shared members" | 20:26 |
johnsom | Ok. Let's think about issues around shared members. (The only reason it matters is to limit multiple health monitors from pinging the members) | 20:26 |
rm_work | but, the HMs on different pools may be different ... | 20:26 |
rm_work | soooo | 20:26 |
rm_work | honestly i think that doesn't even matter | 20:27 |
rm_work | they SHOULD all do their own pings | 20:27 |
johnsom | I think we can consider *adding* a direct member query API. That might be independent of shared members. | 20:27 |
rm_work | k. that's a larger discussion we can have offline | 20:27 |
rm_work | our agenda today is packed | 20:27 |
johnsom | Yep. | 20:27 |
nmagnezi | johnsom, nothing prevents a user from adding the IP address as a pool member for two different pools, right? | 20:27 |
*** yamamoto has joined #openstack-lbaas | 20:27 | |
johnsom | bar_ Are you good with the discussion progress so far? Can we table it? | 20:27 |
nmagnezi | it's just a different member object | 20:27 |
rm_work | right | 20:28 |
johnsom | Right | 20:28 |
rm_work | the question was do we bother making member objects shared | 20:28 |
rm_work | i actually vote "no" | 20:28 |
rm_work | complication is not worth the return | 20:28 |
johnsom | Yeah, it gets pretty messy with different protocol pools, etc. | 20:28 |
*** beagles has joined #openstack-lbaas | 20:28 | |
bar_ | let's continue offline them | 20:28 |
bar_ | *then | 20:28 |
*** alee has joined #openstack-lbaas | 20:28 | |
johnsom | #topic (sanfern / rm_work) Changes to DB schema for VRRP ports | 20:28 |
*** openstack changes topic to "(sanfern / rm_work) Changes to DB schema for VRRP ports (Meeting topic: Octavia)" | 20:28 | |
alee | rm_work, yo | 20:29 |
johnsom | #link https://review.openstack.org/#/c/521138/ | 20:29 |
*** salmankhan has joined #openstack-lbaas | 20:29 | |
jniesz | I am covering for sanfern, since it is 2 am for hi | 20:29 |
jniesz | m | 20:29 |
jniesz | this is from the discussion we had at the PTG about changing the vrrp_ table names | 20:29 |
rm_work | yeah, i agree with the goal, i love it | 20:29 |
rm_work | but | 20:29 |
rm_work | is this a smart thing to do on the DB-schema side? | 20:29 |
rm_work | should we maybe just change the models and leave it at that? | 20:30 |
rm_work | the repos can do the translation | 20:30 |
alee | rm_work, hey --- I think I asked this before but you were out -- is there a doc to describe how to set up octavia with barbican? | 20:30 |
rm_work | alee: yes -- but hold on, middle of our meeting :P | 20:30 |
jniesz | I remember the reason was to make it obvious since vrrp was already bad naming and when the user looks in db | 20:30 |
alee | rm_work, oops sorry :) | 20:30 |
*** xgerman_ has quit IRC | 20:31 | |
*** fyxim has quit IRC | 20:31 | |
*** kong has quit IRC | 20:31 | |
*** ianychoi has quit IRC | 20:31 | |
*** ptoohill- has quit IRC | 20:31 | |
*** devfaz has quit IRC | 20:31 | |
johnsom | I think there are two issues here: | 20:31 |
johnsom | 1. Admin API output change for amphora field change. | 20:31 |
johnsom | 2. The change to the underlying database schema which would require a full control plane downtime. | 20:31 |
rm_work | ^^ I am concerned about #2 | 20:31 |
rm_work | I think even as deep as the Models it would be good to change this stuff | 20:32 |
rm_work | but I think between schema/repo we should leave it | 20:32 |
rm_work | if that's possible | 20:32 |
johnsom | On #1, I'm not so concerned about this. The paint hasn't dried on that admin API patch and we haven't shipped a release with it yet. | 20:32 |
rm_work | or, i could be wrong | 20:32 |
*** yamamoto has quit IRC | 20:32 | |
rm_work | and maybe no one cares about the db schema change | 20:32 |
rm_work | if all of you guys think it's OK, then I guess that's fine | 20:32 |
jniesz | for #2 I think control plane going down for short period of time for planned maintenance upgrade is ok | 20:33 |
johnsom | If people are coding directly to the database, shame on them. I have no problem breaking that. | 20:33 |
*** salmankhan has quit IRC | 20:33 | |
johnsom | The issue comes down to a control plane outage for upgrade right? | 20:33 |
rm_work | yeah | 20:34 |
johnsom | Did we drop everyone? There is a netsplit... | 20:34 |
jniesz | i'm still here | 20:34 |
rm_work | and i just seriously thought there were openstack guidelines around db schema changes | 20:34 |
nmagnezi | i'm still here | 20:35 |
johnsom | Ok, cool. | 20:35 |
*** aojea has joined #openstack-lbaas | 20:35 | |
nmagnezi | i think xgerman got disconnected | 20:35 |
jniesz | haven't we had to do schema changes in the past? | 20:35 |
johnsom | Well, for upgrade downtime there are assertions a team can make and get a governance tag. However, we have not yet made that assertion. | 20:35 |
johnsom | jniesz So far we have only done additions, no renames | 20:36 |
rm_work | yeah, no renames or removals | 20:37 |
rm_work | yet | 20:37 |
jniesz | well there is always a time for being first | 20:37 |
jniesz | : ) | 20:37 |
rm_work | basically | 20:37 |
rm_work | #vote? | 20:37 |
rm_work | I'll abstain | 20:37 |
johnsom | To me, as long as we maintain the API and provide a migration path, I don't have a problem with it as we have not asserted rolling upgrade or zero downtime upgrade yet. | 20:38 |
johnsom | Please don't abstain, your vote counts. Especially as you have this deployed. | 20:38 |
rm_work | right but | 20:38 |
jniesz | from my standpoint I think the naming makes more sense, and we started this patch based on feedback from the PTG | 20:38 |
rm_work | i would vote no | 20:38 |
rm_work | but | 20:38 |
rm_work | i don't care so much | 20:38 |
rm_work | ah i guess it makes sense just to vote that way, since we don't need unanimity | 20:39 |
jniesz | with active/active I think vrrp naming makes less sense than it does now | 20:39 |
rm_work | it already makes no sense | 20:39 |
rm_work | my objection has nothing to do with the renaming | 20:39 |
*** aojea has quit IRC | 20:39 | |
rm_work | i am a huge fan :P | 20:39 |
nmagnezi | I feel like i don't know enough about this (sorry for some reason that patch slipped my radar). so maybe I'm the one who needs to abstain | 20:39 |
johnsom | The other option is to do a two phase upgrade, one that adds and clones the field, then the operation updates the control plane, then one that removes the old field. | 20:39 |
johnsom | Should we table this for a week and put it on the next agenda so everyone has time to review? | 20:40 |
rm_work | meh | 20:40 |
rm_work | yeah we have time | 20:40 |
rm_work | it'll go in quick once we decide, so | 20:40 |
rm_work | not super worried | 20:40 |
jniesz | would like to get this merged or decided as it has a lot of depen | 20:41 |
johnsom | Ok, we will vote next week about the DB schema change. | 20:41 |
jniesz | for example adding frontend network option | 20:41 |
rm_work | the vote would be | 20:41 |
jniesz | in a way it is holding us up from proceeding on other items | 20:41 |
rm_work | "can we rename fields in our db schema" | 20:41 |
rm_work | don't really need to review the specific patch | 20:41 |
rm_work | if you know your answer to that question nir | 20:42 |
johnsom | jniesz I would move forward with what you have. The changes based on this vote should be very minimal. Every access to the DB has to go through the abstraction layer. | 20:42 |
johnsom | Ok, in the interest of time: | 20:43 |
johnsom | #topic (rm_work / BAR_RH) Specify management IP addresses per amphora | 20:43 |
*** openstack changes topic to "(rm_work / BAR_RH) Specify management IP addresses per amphora (Meeting topic: Octavia)" | 20:43 | |
johnsom | #link https://review.openstack.org/#/c/505158/ | 20:43 |
jniesz | but any patches for the abstraction layer would get impacted | 20:44 |
jniesz | that touched those tables | 20:44 |
bar_ | rm_work? | 20:44 |
rm_work | So, there's another approach for this | 20:44 |
johnsom | jniesz Adding the option would use the abstraction which I don't think is in question here, just what is behind the abstraction | 20:44 |
rm_work | that I think is better than mucking with the flows and the actual logic we use | 20:45 |
rm_work | (also it is true that pre-creating that port is problematic for my install) | 20:45 |
rm_work | so yes I have a vested interest here | 20:45 |
johnsom | This has a long history.... It pre-dates the network namespace and was blocked by the old agent framework being broken. | 20:45 |
rm_work | the issue is basically "we want to bind the agent on the amp to the mgmt-ip directly and not listen on 0.0.0.0" | 20:46 |
rm_work | the problem is that we need to send the config for the agent at boot time, which is before the IP is assigned | 20:46 |
rm_work | and there's no way to update it | 20:46 |
rm_work | SO | 20:46 |
*** xgerman_ has joined #openstack-lbaas | 20:47 | |
*** fyxim has joined #openstack-lbaas | 20:47 | |
*** kong has joined #openstack-lbaas | 20:47 | |
*** barjavel.freenode.net changes topic to "(BAR_RH) Members API Improvements Proposal (Meeting topic: Octavia)" | 20:47 | |
johnsom | We need a config update method, that is for sure. | 20:47 |
rm_work | the current solution is: pre-generate the port/IP for the mgmt interface, and bind it on amp boot, so we can send the IP in the pre-generated config | 20:47 |
*** ianychoi has joined #openstack-lbaas | 20:47 | |
*** ptoohill- has joined #openstack-lbaas | 20:47 | |
*** devfaz has joined #openstack-lbaas | 20:47 | |
rm_work | my proposal is that we do something simpler that requires a feature we want anyway: add the ability to send an updated config to the amp agent, and then we simply start on 0.0.0.0 and the first connection (which we are trying to do anyway) just sends a new config | 20:48 |
rm_work | and it restarts on the right interface | 20:48 |
xgerman_ | and I am bacl | 20:48 |
rm_work | welcome back xgerman_ | 20:49 |
nmagnezi | rm_work, to be frank, i see the binding to 0.0.0.0 as a potential security concern | 20:49 |
johnsom | rm_work for my background, what is the problem with pre-building the port? | 20:49 |
rm_work | oh ptoohill was also there in Atlanta IIRC :P | 20:49 |
cgoncalves | rm_work: couldn't another approach be leveraging cloud-init? I'm not certain but I guess we can get the IP at that phase and before configuring the agent | 20:49 |
rm_work | cgoncalves: hmmm I am not sure -- that's an interesting question | 20:50 |
rm_work | that could be a better approach than either of the ones i mentioned | 20:50 |
xgerman_ | pretty sure the computer knows it’s IP on the mgmt port | 20:50 |
nmagnezi | rm_work, can't we both listen to a specific ip address and have the config updates you mentioned? | 20:50 |
johnsom | Yeah, there might be an option to have cloud-init set that setting in the config file | 20:50 |
rm_work | nmagnezi: A) that's what we do now; B) We booted the amp, so it only HAS interfaces we told it to have at boot; C) we still do two-way-cert-auth | 20:50 |
johnsom | Well, right now it binds to 0.0.0.0 | 20:51 |
rm_work | right | 20:51 |
johnsom | in the default namespace | 20:51 |
rm_work | so we can have it bound to 0.0.0.0 for all of like .... 1 second | 20:51 |
rm_work | because we're literally polling the address to reach the amp agent | 20:51 |
rm_work | and if someone else managed to get there first and rebind it somewhere else... who cares, it's a blank amp, and we'll kill it momentarily anyway once we timeout (since our calls won't reach it) | 20:52 |
nmagnezi | btw that option for amphora agent ip bind also shows at octavia.conf , which does not make any sense. just a side note. | 20:52 |
rm_work | nmagnezi: err really? lol yeah that makes no sense | 20:52 |
nmagnezi | rm_work, yeah. bar_'s patch handles that as well | 20:53 |
rm_work | nmagnezi: where is that | 20:53 |
*** Kowsalya has joined #openstack-lbaas | 20:53 | |
rm_work | i actually don't see it | 20:53 |
xgerman_ | sorry being late — we can also use the mgmt subnet instead of 0.0.0.0 | 20:53 |
xgerman_ | why is that now workable? | 20:53 |
xgerman_ | now=not | 20:53 |
rm_work | xgerman_: that's what we're talking about -- HOW we do that | 20:53 |
johnsom | Those options were documented there as "amphora agent only" because they show up in the config settings. That is why they were there. people were putting up patches saying they were missing. | 20:53 |
xgerman_ | we know the mgmt subnet before booting the amp so we can just set it in the config? it in | 20:54 |
rm_work | johnsom: but i really am not seeing them. where do you see them? | 20:54 |
xgerman_ | teh config | 20:54 |
nmagnezi | rm_work, so to answer you: A) that does not mean we should keep doing that B) indeed. but someone later on could update the instance via nova and add interface with dhcp, no? C) indeed. but that does not mean we still need to accept mgmt traffic on all available addresses. | 20:54 |
rm_work | nmagnezi: there is no later | 20:54 |
nmagnezi | i don't recall any openstack services who bind to * | 20:54 |
rm_work | we're saying we rebind it immediately on boot | 20:54 |
rm_work | [12:48:07] <rm_work>my proposal is that we do something simpler that requires a feature we want anyway: add the ability to send an updated config to the amp agent, and then we simply start on 0.0.0.0 and the first connection (which we are trying to do anyway) just sends a new config | 20:55 |
*** sshank has joined #openstack-lbaas | 20:55 | |
rm_work | ^^ the new config binds it to the right IP | 20:55 |
xgerman_ | so a subnet CIDR is not good enough? | 20:55 |
jniesz | can't we pass the IP to bind through config drive, and then it binds on boot /start | 20:55 |
xgerman_ | +1 | 20:55 |
nmagnezi | rm_work, touche | 20:56 |
rm_work | xgerman_: how do we use that to set the bind? | 20:56 |
rm_work | jniesz: right the problem is that we don't know the IP until after the boot command is sent | 20:56 |
johnsom | xgerman_ You can't listen on a subnet, you can only listen (bind) to an address. | 20:56 |
xgerman_ | I can iptable drop them if I want… | 20:56 |
rm_work | jniesz: that is exactly the current patch's approach -- which requires it to pre-make the port | 20:56 |
rm_work | which i'd like to avoid | 20:56 |
nmagnezi | jniesz, that's what bar_'s patch is doing | 20:56 |
*** tongl has quit IRC | 20:56 | |
johnsom | jniesz Yes, technically that comes in via config drive from nova. That is the cloud-init option that was proposed earlier | 20:57 |
rm_work | we're about to be out of time here and i have a hard-stop in 3min T_T | 20:57 |
jniesz | or need something in the systemd script to read the IP off the interface | 20:57 |
johnsom | Yeah, me too | 20:57 |
rm_work | maybe we need to punt this also | 20:57 |
johnsom | lol | 20:57 |
rm_work | since maybe people need to read the existing patch | 20:57 |
rm_work | and see what it's doing | 20:57 |
nmagnezi | rm_work, maybe it's just becoming a late hour for me me , but i still didn't get why pre-creating that port is an issue O_o | 20:58 |
johnsom | Ok, I will put these on the next agenda too. I might re-order for fairness of the other topic we didn't get to. | 20:58 |
rm_work | nmagnezi: in our environment, we can't specify a network/subnet for VMs | 20:58 |
rm_work | we have to let them create their own ports | 20:58 |
rm_work | so we *can't* pre-create a port and then bind it | 20:58 |
nmagnezi | aha. | 20:58 |
rm_work | IIRC Cern does something similar | 20:58 |
rm_work | from talking with them before | 20:59 |
johnsom | Yeah, I think there are AZ issues with some deployments like that | 20:59 |
rm_work | yes | 20:59 |
rm_work | IMO we *cannot* merge this as it is | 20:59 |
johnsom | Ok, thanks folks! | 20:59 |
xgerman_ | yeah, we should avoid pre-creatign the port in case people do fancy SRV-IO stuff | 20:59 |
nmagnezi | well. can't say it's not a valid usecase. | 20:59 |
rm_work | i am just trying to be diplomatic :) | 20:59 |
nmagnezi | rm_work, let's discuss this tomorrow | 20:59 |
rm_work | kk | 20:59 |
johnsom | SRV-IO is a good example too | 20:59 |
nmagnezi | maybw we can figure a middle ground | 20:59 |
rm_work | i mean | 20:59 |
rm_work | i think you will be OK with my proposal | 21:00 |
jniesz | speaking of SR-IOV that has been giving me headaches with the X710 | 21:00 |
johnsom | #endmeeting | 21:00 |
*** openstack changes topic to "Welcome to LBaaS / Octavia - Queens development is now open." | 21:00 | |
rm_work | once i explain better | 21:00 |
openstack | Meeting ended Wed Dec 6 21:00:05 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:00 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2017/octavia.2017-12-06-20.00.html | 21:00 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2017/octavia.2017-12-06-20.00.txt | 21:00 |
openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2017/octavia.2017-12-06-20.00.log.html | 21:00 |
rm_work | nmagnezi: so yeah, tomorrow :) | 21:00 |
nmagnezi | :-) | 21:00 |
rm_work | i'll walk through what i'm talking about better | 21:00 |
rm_work | bbl | 21:00 |
nmagnezi | sorry, gotta drop | 21:00 |
*** harlowja has quit IRC | 21:00 | |
nmagnezi | johnsom, i will take the links list from this meeting as top review priority, until we'll have the extended list | 21:01 |
johnsom | Thanks! | 21:01 |
*** Kowsalya has quit IRC | 21:02 | |
*** harlowja has joined #openstack-lbaas | 21:03 | |
*** bar_ has quit IRC | 21:03 | |
*** longstaff has quit IRC | 21:04 | |
*** Kowsalya has joined #openstack-lbaas | 21:05 | |
*** tongl has joined #openstack-lbaas | 21:05 | |
xgerman_ | caught up - didn’t miss much due to the netsplit | 21:06 |
*** Kowsalya has quit IRC | 21:12 | |
*** gcheresh has joined #openstack-lbaas | 21:12 | |
*** sticker has joined #openstack-lbaas | 21:19 | |
*** yamamoto has joined #openstack-lbaas | 21:28 | |
*** gcheresh has quit IRC | 21:29 | |
*** bzhao has joined #openstack-lbaas | 21:30 | |
*** bbzhao has joined #openstack-lbaas | 21:30 | |
*** harlowja has quit IRC | 21:32 | |
*** yamamoto has quit IRC | 21:33 | |
*** aojea has joined #openstack-lbaas | 21:35 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 21:38 | |
*** openstackgerrit has quit IRC | 21:38 | |
*** sri_ has quit IRC | 21:38 | |
*** bar_ has joined #openstack-lbaas | 21:39 | |
*** aojea has quit IRC | 21:41 | |
*** aojea has joined #openstack-lbaas | 21:45 | |
*** aojea has quit IRC | 21:46 | |
*** aojea has joined #openstack-lbaas | 21:46 | |
beagles | is the username and project_name in the service_auth section of the configuration supposed to be that of the admin tenant? | 21:55 |
*** leitan has joined #openstack-lbaas | 22:00 | |
johnsom | beagles [service_auth] is the account octavia uses to request resources from other services, such as nova/neutron/barbican. You can use admin or setup an account for octavia and grant the right RBAC permissions for those service to this account. | 22:00 |
beagles | johnsom, ack thanks | 22:01 |
*** openstackgerrit has joined #openstack-lbaas | 22:01 | |
*** sri_ has joined #openstack-lbaas | 22:01 | |
*** rcernin has joined #openstack-lbaas | 22:01 | |
*** rcernin has quit IRC | 22:03 | |
*** rcernin has joined #openstack-lbaas | 22:03 | |
*** leitan has quit IRC | 22:05 | |
bar_ | johnsom, is the vip deallocation patch is pike-backport material? | 22:08 |
johnsom | Point me to which one you are talking about? | 22:08 |
bar_ | https://review.openstack.org/#/c/523931/ | 22:08 |
johnsom | bar_ Yes, I think that has the potential once it merges | 22:09 |
bar_ | johnsom, cool. Are there more pike deadlines in the near future, or we're already passed that? | 22:10 |
johnsom | bar_ The schedule for the releases is here: https://releases.openstack.org/ | 22:11 |
johnsom | Looks like Pike goes phase II 2/26 | 22:11 |
bar_ | got it. thanks | 22:11 |
*** sshank has quit IRC | 22:20 | |
*** yamamoto has joined #openstack-lbaas | 22:30 | |
*** aojea has quit IRC | 22:31 | |
*** longstaff has joined #openstack-lbaas | 22:32 | |
*** aojea has joined #openstack-lbaas | 22:33 | |
*** sshank has joined #openstack-lbaas | 22:34 | |
*** yamamoto has quit IRC | 22:35 | |
*** harlowja has joined #openstack-lbaas | 22:36 | |
*** AlexeyAbashkin has quit IRC | 22:43 | |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Add VIP QoS Policy client support https://review.openstack.org/526217 | 22:51 |
*** sshank has quit IRC | 22:54 | |
*** sshank has joined #openstack-lbaas | 22:57 | |
*** aojea has quit IRC | 23:02 | |
openstackgerrit | Bar RH proposed openstack/python-octaviaclient master: Allow case-insensitive enteries when selecting from choices https://review.openstack.org/525791 | 23:09 |
rm_work | So what were high priority review items? I am going to take a look at the stuff linked in the meeting now i guess | 23:19 |
rm_work | which are ... none | 23:20 |
rm_work | oh nm there they are | 23:20 |
*** openstack has joined #openstack-lbaas | 23:31 | |
*** ChanServ sets mode: +o openstack | 23:31 | |
*** yamamoto has joined #openstack-lbaas | 23:32 | |
*** yamamoto has quit IRC | 23:37 | |
xgerman_ | I think with Q-2 being cut the urgency is diminishing until Q-3 ;-) | 23:42 |
xgerman_ | timed out? https://review.openstack.org/#/c/525704/ — is our gate broken? | 23:42 |
xgerman_ | rm_work as the centos user this looks relevant for you, too: https://review.openstack.org/#/c/522626/ | 23:44 |
xgerman_ | wonder why nmagnezi isn’t reviewing that… | 23:44 |
*** armax has quit IRC | 23:45 | |
xgerman_ | ok, timeout fixed itself | 23:45 |
rm_work | yeah i am aware of it | 23:47 |
rm_work | i'll be looking | 23:47 |
xgerman_ | cool - thanks | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!