*** fnaval has quit IRC | 00:13 | |
*** Swami has quit IRC | 00:45 | |
*** JudeC has joined #openstack-lbaas | 00:49 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Reduce stestr concurrency to 1 for tempest jobs https://review.openstack.org/551801 | 00:50 |
---|---|---|
*** harlowja has quit IRC | 01:10 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/551533 | 01:14 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia master: Updated from global requirements https://review.openstack.org/552193 | 01:17 |
openstackgerrit | Merged openstack/octavia master: Rename q- to neutron- services https://review.openstack.org/544281 | 01:21 |
*** JudeC has quit IRC | 01:24 | |
*** rcernin has quit IRC | 02:04 | |
*** jaff_cheng has joined #openstack-lbaas | 02:04 | |
*** annp has joined #openstack-lbaas | 02:13 | |
*** rcernin has joined #openstack-lbaas | 03:07 | |
*** jaff_cheng has quit IRC | 03:23 | |
*** jaff_cheng has joined #openstack-lbaas | 03:24 | |
*** harlowja has joined #openstack-lbaas | 03:48 | |
*** links has joined #openstack-lbaas | 03:50 | |
openstackgerrit | wangqi proposed openstack/octavia-tempest-plugin master: Switch to tempest.common.utils.services https://review.openstack.org/552287 | 04:58 |
*** jaff_cheng has quit IRC | 05:30 | |
*** jaff_cheng has joined #openstack-lbaas | 05:30 | |
*** gcheresh has joined #openstack-lbaas | 05:34 | |
*** irenab has quit IRC | 05:36 | |
*** oanson has quit IRC | 05:37 | |
*** gcheresh has quit IRC | 05:41 | |
*** harlowja has quit IRC | 05:59 | |
*** oanson has joined #openstack-lbaas | 06:38 | |
*** irenab has joined #openstack-lbaas | 06:38 | |
*** oanson has quit IRC | 06:38 | |
*** irenab has quit IRC | 06:38 | |
*** kobis has joined #openstack-lbaas | 06:39 | |
*** oanson has joined #openstack-lbaas | 06:39 | |
*** irenab has joined #openstack-lbaas | 06:40 | |
*** JudeC has joined #openstack-lbaas | 06:57 | |
*** rcernin has quit IRC | 07:24 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-octaviaclient master: Updated from global requirements https://review.openstack.org/549570 | 07:27 |
*** JudeC has quit IRC | 07:29 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia-dashboard master: Imported Translations from Zanata https://review.openstack.org/550371 | 07:30 |
*** pcaruana has joined #openstack-lbaas | 07:42 | |
*** AlexeyAbashkin has joined #openstack-lbaas | 07:50 | |
*** links has quit IRC | 07:52 | |
*** links has joined #openstack-lbaas | 07:59 | |
*** tesseract has joined #openstack-lbaas | 08:19 | |
*** tesseract-RH has joined #openstack-lbaas | 08:20 | |
*** tesseract-RH has quit IRC | 08:20 | |
*** sticker has joined #openstack-lbaas | 08:34 | |
*** mburrows has quit IRC | 09:30 | |
*** dmellado has joined #openstack-lbaas | 09:47 | |
*** salmankhan has joined #openstack-lbaas | 10:12 | |
*** jaff_cheng has quit IRC | 10:38 | |
*** pcaruana has quit IRC | 10:45 | |
*** rcernin has joined #openstack-lbaas | 11:02 | |
*** yamamoto has quit IRC | 11:46 | |
*** yamamoto has joined #openstack-lbaas | 11:50 | |
*** rcernin has quit IRC | 12:00 | |
*** yamamoto has quit IRC | 12:01 | |
*** yamamoto has joined #openstack-lbaas | 12:01 | |
openstackgerrit | Daniel Mellado proposed openstack/neutron-lbaas master: Adapt plugin to new q- n- syntax https://review.openstack.org/552493 | 12:03 |
*** yamamoto has quit IRC | 12:06 | |
*** annp has quit IRC | 12:07 | |
rm_work | [02:57:22] <rm_work>though i bet 99% what is going to happen is that this whole test will just get dropped | 12:08 |
rm_work | [04:37:31] <cgoncalves>so I propose to keep it open until the neutron patch gets merged, and then we can abandon this one | 12:09 |
rm_work | ^^ exactly what I meant :P | 12:09 |
rm_work | which is probably fine | 12:09 |
cgoncalves | :) | 12:11 |
*** salmankhan has quit IRC | 12:12 | |
rm_work | so on https://review.openstack.org/#/c/551796/4/tox.ini | 12:24 |
rm_work | was reading scrollback here, and wasn't johnsom saying parallel mode was wrong there? | 12:25 |
rm_work | ah but we're not going to try to do specifically named files so it doesn't matter? | 12:25 |
*** salmankhan has joined #openstack-lbaas | 12:27 | |
*** atoth has joined #openstack-lbaas | 12:29 | |
rm_work | wait, why aren't the coverage tests running? | 12:29 |
rm_work | cgoncalves: i don't see the coverage test running in that patch? do we not have a gate for it? >_> | 12:32 |
cgoncalves | rm_work: heh, I thought we had | 12:50 |
cgoncalves | rm_work: want to propose it or shall I? | 12:51 |
rm_work | you've been doing gate patches recently, you go for it | 12:53 |
rm_work | i'm working through some logic | 12:53 |
rm_work | trying to decide how to fix this barbican ACL dumbness | 12:54 |
*** fnaval has joined #openstack-lbaas | 12:54 | |
*** HW-Peter has joined #openstack-lbaas | 13:08 | |
*** HW-Peter has quit IRC | 13:10 | |
*** HW-Peter has joined #openstack-lbaas | 13:11 | |
*** yamamoto has joined #openstack-lbaas | 13:34 | |
johnsom | rm_work: doing the API add the ACL thing? | 13:38 |
rm_work | yes | 13:38 |
johnsom | Sweet | 13:39 |
*** yamamoto has quit IRC | 13:39 | |
rm_work | well after i finish the patch that fixes our API usage of barbican :/ | 13:39 |
rm_work | we forgot to actually... do an API check for the cert | 13:39 |
rm_work | lol | 13:39 |
rm_work | we did it on the n-lbaas side but never on the octavia api side | 13:39 |
rm_work | that patch is pending but updating it to do more correct checks, one sec | 13:39 |
johnsom | Ok, I am not “in the office yet”, just picked up my phone for a bit. | 13:40 |
rm_work | k | 13:40 |
*** yamamoto has joined #openstack-lbaas | 13:53 | |
*** yamamoto has quit IRC | 13:55 | |
*** kobis has quit IRC | 14:01 | |
openstackgerrit | Merged openstack/neutron-lbaas master: Reduce stestr concurrency to 1 for tempest jobs https://review.openstack.org/551796 | 14:01 |
rm_work | there we go | 14:04 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Properly test access to tls_refs in the API layer https://review.openstack.org/550303 | 14:04 |
rm_work | now doing it *right* i think | 14:04 |
rm_work | so now it's possible to do the ACLs but it's not ... explicitly clear to me whether the session we have is the user token one | 14:05 |
openstackgerrit | Hengqing Hu proposed openstack/octavia-dashboard master: Add l7 support https://review.openstack.org/551947 | 14:07 |
rm_work | or rather, context | 14:11 |
openstackgerrit | Daniel Mellado proposed openstack/neutron-lbaas master: Add ml2_conf.ini default value in settings https://review.openstack.org/552527 | 14:14 |
*** kobis has joined #openstack-lbaas | 14:22 | |
rm_work | hmmm i think there may be too many gotchas with this... | 14:49 |
rm_work | i can kinda do it, but there's a lot of places where it kinda falls apart | 14:49 |
*** kobis has quit IRC | 14:50 | |
*** kobis has joined #openstack-lbaas | 14:53 | |
johnsom | rm_work need a second set of eyes? | 15:03 |
rm_work | gonna push up some code without any testing that's kinda ... a first go at mapping it out | 15:03 |
rm_work | in a moment | 15:03 |
johnsom | Ok | 15:04 |
*** kobis has quit IRC | 15:08 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: [WIP] Automatically set Barbican ACLs https://review.openstack.org/552549 | 15:17 |
*** sticker has quit IRC | 15:17 | |
rm_work | it's messy for a few reasons | 15:17 |
rm_work | johnsom: second set of eyes is good, but you may have more important things to focus on still, this soon back from your trip :) | 15:18 |
johnsom | Yeah, I have a few internal things to do today, but I will find a minute or two to take a look | 15:18 |
johnsom | FYI: Another DVR bug that can impact us: https://bugs.launchpad.net/neutron/+bug/1753434 | 15:21 |
openstack | Launchpad bug 1753434 in neutron "Unbound ports floating ip not working with address scopes in DVR HA " [Undecided,Confirmed] | 15:21 |
rm_work | <_< | 15:22 |
*** yamamoto has joined #openstack-lbaas | 15:28 | |
*** beagles is now known as beagles_food | 15:36 | |
*** yamamoto has quit IRC | 15:38 | |
*** JudeC has joined #openstack-lbaas | 15:43 | |
*** kobis has joined #openstack-lbaas | 15:45 | |
*** harlowja has joined #openstack-lbaas | 15:46 | |
*** JudeC has quit IRC | 15:50 | |
*** links has quit IRC | 15:55 | |
*** harlowja has quit IRC | 16:06 | |
johnsom | rm_work Gave you a few comments | 16:06 |
rm_work | k | 16:07 |
rm_work | hammering out backup members really quick | 16:07 |
johnsom | lol | 16:07 |
*** links has joined #openstack-lbaas | 16:08 | |
*** beagles_food is now known as beagles | 16:16 | |
*** kobis has quit IRC | 16:22 | |
*** kobis has joined #openstack-lbaas | 16:23 | |
*** links has quit IRC | 16:30 | |
*** gcheresh has joined #openstack-lbaas | 16:38 | |
*** kobis has quit IRC | 16:40 | |
*** gcheresh has quit IRC | 16:45 | |
*** JudeC has joined #openstack-lbaas | 16:49 | |
andreykurilin | rm_work: hi! I know that openstack/neutron-lbaas is deprecated, but do you know anythin about plans to make it compatible with a new devstack neutron naming?) | 16:54 |
rm_work | yes, we actually have mostly finished that work | 16:55 |
rm_work | I think it merged in the past couple of days | 16:55 |
rm_work | there's one more patch possibly outstanding there | 16:55 |
andreykurilin | cool, thanks | 16:55 |
andreykurilin | PS: we had legacy job with a bunch of neutron extensions - networking-bgpvpn, neutron-fwaas, neutron-lbaas, neutron-vpnaas, octavia (it worked together!). But as for new naming only octavia and vpnaas work | 16:56 |
*** kobis has joined #openstack-lbaas | 16:59 | |
rm_work | yes, because octavia is not tightly coupled with neutron, we are an API consumer only | 17:00 |
rm_work | but neutron-lbaas is ... a little wonky | 17:01 |
*** kobis has quit IRC | 17:01 | |
*** Swami has joined #openstack-lbaas | 17:06 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Allow members to be set as "backup" https://review.openstack.org/552632 | 17:09 |
rm_work | there | 17:10 |
rm_work | deciding whether i go to sorry-page or not | 17:20 |
*** kobis has joined #openstack-lbaas | 17:32 | |
*** AlexeyAbashkin has quit IRC | 17:34 | |
*** imacdonn has quit IRC | 17:44 | |
*** imacdonn has joined #openstack-lbaas | 17:44 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Devstack plugin image build option quoting fix https://review.openstack.org/552641 | 17:51 |
rm_work | johnsom: ^^ that one is annoying | 17:53 |
rm_work | keeps making my stacks fail >_< | 17:54 |
johnsom | I'm looking at this docs thing now | 17:54 |
*** kobis has quit IRC | 18:05 | |
*** kobis has joined #openstack-lbaas | 18:06 | |
*** kobis has quit IRC | 18:06 | |
*** kobis has joined #openstack-lbaas | 18:06 | |
*** kobis has quit IRC | 18:07 | |
*** kobis has joined #openstack-lbaas | 18:07 | |
*** kobis has quit IRC | 18:08 | |
*** salmankhan has quit IRC | 18:08 | |
*** kobis has joined #openstack-lbaas | 18:08 | |
*** kobis has quit IRC | 18:08 | |
*** kobis has joined #openstack-lbaas | 18:09 | |
*** kobis has quit IRC | 18:09 | |
rm_work | the sphinx change? | 18:14 |
rm_work | err i thought we could just ignore the requirements update until we fixed it as our requirements specifically have a "less than" that should block it | 18:16 |
rm_work | but it seems like it's affecting everything anyway somehow? <_< | 18:16 |
rm_work | also, wow gate queue is long O_o | 18:17 |
johnsom | https://www.irccloud.com/pastebin/rf4FJuQB/ | 18:27 |
*** harlowja has joined #openstack-lbaas | 18:30 | |
*** harlowja has quit IRC | 18:30 | |
johnsom | Yeah, so it looks like shpinx > 1.6.5 is broken | 18:46 |
*** AlexeyAbashkin has joined #openstack-lbaas | 18:58 | |
johnsom | So, this is back to the dumb thing in sphinx that it doesn't index folders with empty __init__.py and only sub-folders | 19:01 |
*** AlexeyAbashkin has quit IRC | 19:03 | |
*** tesseract has quit IRC | 19:11 | |
rm_work | <_< | 19:16 |
*** igageis has joined #openstack-lbaas | 19:35 | |
*** igageis has quit IRC | 19:37 | |
rm_work | johnsom: wait a minute ... so the context we have in the API layer... is that actually a user context? | 19:38 |
rm_work | so is our original cert lookup ALREADY using the user's token? | 19:38 |
johnsom | But the code that pulls the cert to install on the amp doesn't have the user context, it is async | 19:41 |
rm_work | right | 19:44 |
rm_work | but i knew that | 19:44 |
rm_work | i just thought the API side context was still "ours" | 19:44 |
rm_work | in that if I used it to perform actions it would be our actions, not the users | 19:44 |
rm_work | that changes things a lot | 19:45 |
johnsom | So, the docs issue is because the upper-constraint got bumped. It's not related to the G-R change. Everything is going to break. I have restored Jacky's patch: https://review.openstack.org/#/c/534765 | 19:51 |
rm_work | yeah sad | 19:58 |
rm_work | ah this is all different sessions anyway, nm, maybe doesn't change | 19:59 |
rm_work | so i think basically it's even more ridiculous: | 20:08 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: [WIP] Automatically set Barbican ACLs https://review.openstack.org/552549 | 20:08 |
johnsom | rm_work Still not sure I get this. Isn't get_cert only called from the backend? | 20:14 |
johnsom | o-cw? | 20:14 |
rm_work | see the patch it depends on | 20:15 |
rm_work | you missed my explanation of that bug earlier i think | 20:15 |
rm_work | it was like the first thing i mentioned when you came back | 20:15 |
johnsom | Ah, got it, yeah missed the other patch | 20:16 |
rm_work | we (I) totally forgot to put the check in the API layer | 20:16 |
rm_work | because... i dunno, dumb | 20:16 |
rm_work | neutron-lbaas did it properly | 20:16 |
rm_work | we did not | 20:16 |
rm_work | possibly because at the time it was API v1 and i didn't want to have it pull from barbican FOUR TIMES or something silly just to get the certs deployed | 20:17 |
johnsom | We had jsut a little bit going on at the time.... | 20:17 |
rm_work | yeah | 20:17 |
johnsom | Hmm, I thought we fixed all of the py35 issues with the certs... | 20:22 |
rm_work | this is one i added | 20:23 |
rm_work | i'm working on i | 20:23 |
rm_work | *it | 20:23 |
rm_work | of course at the last minute i decided to add one more test and neglected to also run py35 | 20:24 |
rm_work | was trying to improve coverage <_< | 20:25 |
rm_work | i see why no one bothered to cover this line | 20:25 |
rm_work | i think it's not worth it >_< | 20:25 |
*** harlowja has joined #openstack-lbaas | 20:37 | |
rm_work | which is better: | 20:48 |
rm_work | isinstance(passphrase, six.text_type) | 20:48 |
rm_work | type(passphrase) == six.text_typetype(passphrase) == six.text_type | 20:48 |
rm_work | err | 20:48 |
rm_work | type(passphrase) == six.text_type | 20:48 |
rm_work | isinstance(passphrase, six.text_type) | 20:48 |
rm_work | those two | 20:48 |
rm_work | i am unsure | 20:48 |
*** mburrows has joined #openstack-lbaas | 20:52 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Properly test access to tls_refs in the API layer https://review.openstack.org/550303 | 21:08 |
rm_work | k fixed | 21:08 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: [WIP] Automatically set Barbican ACLs https://review.openstack.org/552549 | 21:09 |
rm_work | what i would give just to have our gates work for a week | 21:11 |
rm_work | all it took was three days of broken to make me throw my hands up and just start merging stuff that seemed to make it better <_< | 21:12 |
rm_work | johnsom: that patch still has a pep8 error (well, lots of them) | 21:17 |
rm_work | need to disable H104 | 21:17 |
rm_work | ummm and somehow a bunch of other errors, wtf | 21:18 |
johnsom | Hmm, yeah, the logs were gone so I wasn't sure what was up with that. | 21:22 |
rm_work | yeah wtf these are valid | 21:22 |
rm_work | this is so weird | 21:22 |
rm_work | it's like flake8 maybe also wasn't checking stuff correctly sometimes? | 21:22 |
rm_work | but this fixes i?? | 21:22 |
rm_work | dunno | 21:22 |
rm_work | fixing all this suff | 21:22 |
rm_work | *stuff | 21:22 |
johnsom | Were we missing __init__.py files? | 21:23 |
johnsom | No, those are all updates | 21:23 |
rm_work | it's weird, they're all over the place | 21:26 |
rm_work | it's mostly E126 and E123 | 21:26 |
rm_work | so, indentation errrs | 21:26 |
rm_work | uhg i would be done by now but my macbook is lagging to all hell for some reason | 21:27 |
rm_work | hmmm docs test is also still failing for me though with the toctree thing i saw elsewhere | 21:29 |
rm_work | oh nm it's different | 21:29 |
johnsom | That is what we are fixing with the __init__ patch | 21:29 |
rm_work | octavia/amphorae/backends/agent/agent_jinja_cfg.py:docstring of octavia.amphorae.backends.agent.agent_jinja_cfg.AgentJinjaTemplater:0:duplicate object description of octavia.amphorae.backends.agent.agent_jinja_cfg.AgentJinjaTemplater, other instance in octavia/doc/source/contributor/modules/octavia.amphorae.backends.agent.rst, use :noindex: for one of them | 21:29 |
rm_work | this is breaking ON the init patch | 21:30 |
rm_work | looking into it now | 21:31 |
*** mburrows has quit IRC | 21:31 | |
*** mburrows has joined #openstack-lbaas | 21:31 | |
rm_work | is this breaking just because it's the first thing alphabetically to be checked | 21:32 |
rm_work | and they will all break? | 21:32 |
rm_work | regardless, pushing up the fixes | 21:32 |
rm_work | or | 21:32 |
rm_work | i guess i can wait for it to finish | 21:32 |
rm_work | hmmm the sphinx docs build works tho in gate so whatever | 21:35 |
rm_work | must be me | 21:35 |
*** AlexeyAbashkin has joined #openstack-lbaas | 21:36 | |
rm_work | ugh, johnsom can you copy off links to the runs you want from that patch | 21:37 |
rm_work | so i can push up the fix for the pep8 stuff | 21:37 |
rm_work | because it's got like an hour left i think | 21:38 |
johnsom | Go ahead. | 21:38 |
johnsom | The docs job passed | 21:38 |
rm_work | yeah k | 21:38 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add license for empty __init__.py https://review.openstack.org/534765 | 21:39 |
rm_work | my schedule is moved back a bit now, so mostly i'm working early early morning | 21:40 |
*** AlexeyAbashkin has quit IRC | 21:41 | |
johnsom | Hmm, we can override the checks in those files, but I'm not sure H104 really benefits us anyway. | 21:44 |
rm_work | it does not, IMO | 21:52 |
rm_work | i'm still perplexed by how those bad indentations ever got past flake8 | 21:53 |
rm_work | i was tempted to assume something had gone wrong and they were false positives locally that i should ignore... but... I can SEE that they were actually wrong | 21:54 |
rm_work | ah i think the docs fail locally was because of how it built the modules (in the source dir, wtf) and that i couldn't tell because it's in gitignore ... but nothing cleans it up | 21:55 |
rm_work | wiping them and re-running | 21:55 |
rm_work | yep <_< lame | 21:58 |
rm_work | wiping that helped | 21:58 |
rm_work | maybe should put that into the docs run | 21:58 |
*** rcernin has joined #openstack-lbaas | 21:59 | |
johnsom | removing the modules path? | 22:02 |
rm_work | johnsom: i'm gonna add that | 22:02 |
rm_work | doc/source/contributor/modules | 22:02 |
johnsom | I thought about it too | 22:02 |
johnsom | yeah | 22:02 |
rm_work | to the existing rm -rf command in the docs | 22:02 |
rm_work | k | 22:02 |
rm_work | it was still queued anyway | 22:03 |
rm_work | ... man, what is up today | 22:03 |
rm_work | such queues | 22:03 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add license for empty __init__.py https://review.openstack.org/534765 | 22:03 |
rm_work | hours of queues | 22:03 |
rm_work | i need to stop making new patches for a bit, i'm juggling like 6 outstanding now i think <_< | 22:05 |
rm_work | once the gates are better i will make an actual clear list of them, prioritized | 22:07 |
rm_work | do we have a review priority etherpad or something? I liked the one we had before | 22:07 |
johnsom | No, I don't have one going right now | 22:08 |
nmagnezi_ | rm_work, o/ re: https://review.openstack.org/#/c/548729 , I'm still not convinced Oracle should skip my suggestions.. including dib elements :P | 22:09 |
* nmagnezi_ goes back to OOO | 22:09 | |
*** fnaval has quit IRC | 22:27 | |
openstackgerrit | Merged openstack/neutron-lbaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/548848 | 22:50 |
*** yamamoto has joined #openstack-lbaas | 23:08 | |
openstackgerrit | Merged openstack/python-octaviaclient master: Updated from global requirements https://review.openstack.org/549570 | 23:16 |
openstackgerrit | German Eichberger proposed openstack/octavia master: Periodic job to build + publish diskimage https://review.openstack.org/549259 | 23:21 |
xgerman_ | ts. ts -1 for merge conflict as if gerrit isn’t his own man… | 23:21 |
johnsom | He's just trying to balance out the diversity tag | 23:22 |
johnsom | grin | 23:22 |
xgerman_ | I thought they got rid of it | 23:23 |
openstackgerrit | Merged openstack/python-octaviaclient master: fix error url https://review.openstack.org/540923 | 23:36 |
*** AlexeyAbashkin has joined #openstack-lbaas | 23:36 | |
openstackgerrit | Merged openstack/octavia-dashboard master: Imported Translations from Zanata https://review.openstack.org/550371 | 23:37 |
*** AlexeyAbashkin has quit IRC | 23:41 | |
openstackgerrit | Merged openstack/neutron-lbaas master: Updated from global requirements https://review.openstack.org/551533 | 23:42 |
openstackgerrit | Merged openstack/neutron-lbaas master: Imported Translations from Zanata https://review.openstack.org/548770 | 23:42 |
*** Swami has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!