| johnsom | https://review.openstack.org/#/c/571358/6/octavia/api/drivers/driver_lib.py L45 | 00:00 |
|---|---|---|
| rm_work | ah ok i did comment on the patch, cool | 00:00 |
| rm_work | ah so we ARE doing that | 00:00 |
| rm_work | >_> | 00:00 |
| rm_work | I actually would prefer if we *solved the problem* with the way we rely on that constraint | 00:00 |
| johnsom | Basically I realized my fancy fast bulk update gave the drivers license to overwrite *anything* on those objects, and it bypassed the relational checks, so I totally changed strategy on that | 00:01 |
| rm_work | because relying on a DB constraint for our validation feels icky | 00:01 |
| johnsom | Actually it's what it is for | 00:01 |
| rm_work | and I *would* like to have objects go to DELETED so we have records of listeners/pools/etc | 00:01 |
| rm_work | errr | 00:01 |
| rm_work | you fixed it by having it do a repo.delete if the status goes to DELETED | 00:01 |
| johnsom | I decided making sure our DB is consistent out weighed the "keep deleted stuff around" | 00:01 |
| rm_work | eh | 00:01 |
| johnsom | Yeah, so now it mirrors the current amphora behavior | 00:02 |
| johnsom | The only objects that we actually kept around was LB and listener | 00:02 |
| rm_work | current amphora behavior is DELETED stay in the DB :P | 00:02 |
| johnsom | nope | 00:02 |
| rm_work | yes | 00:03 |
| rm_work | we fixed it | 00:03 |
| johnsom | I thought so too, but it's only a few objects that actually leave stuff around | 00:03 |
| rm_work | amps stick around now for the expiry period | 00:03 |
| johnsom | Oh, right, it's LB and amp, not listener | 00:03 |
| johnsom | All of the rest currently deletes | 00:03 |
| rm_work | right | 00:03 |
| rm_work | which i don't like | 00:03 |
| rm_work | actually, it's not that i don't like it | 00:04 |
| rm_work | I *dislike* it | 00:04 |
| johnsom | Fair enough. I do really like the relational integrity checks in the DB. | 00:04 |
| rm_work | meh | 00:04 |
| rm_work | that's dangerously close to "logic in the DB" imo | 00:04 |
| rm_work | sure it's validation, but | 00:04 |
| *** SumitNaiksatam has quit IRC | 00:05 | |
| rm_work | we should be responsible for our validation layer | 00:05 |
| johnsom | It is logic in the DB, I don't deny that, but it's relational logic | 00:05 |
| johnsom | Anyway, we are working towards MS3, so I'm in "fix it" mode so that we can get in what we need and have a stable release. | 00:06 |
| johnsom | We still have this updates thing, the dual amp failure thing, plus migration tool / docs. | 00:06 |
| rm_work | k | 00:06 |
| rm_work | yes | 00:06 |
| rm_work | i think i agree with that prioritization | 00:06 |
| johnsom | And a bunch of stuff I want to land, like UDP | 00:06 |
| rm_work | maybe i'll look at fixing it <_< | 00:08 |
| johnsom | So, I need to run prep for dinner. I will work on the update issue tomorrow. Hopefully get us at least back to as functional as Queens again. | 00:08 |
| rm_work | kk yeah we're breaking for dinner here now | 00:08 |
| johnsom | Feel free to take the dual amp failure one too.... grin | 00:08 |
| *** longkb has joined #openstack-lbaas | 00:36 | |
| *** kbyrne has quit IRC | 00:38 | |
| *** kbyrne has joined #openstack-lbaas | 00:41 | |
| *** fnaval has joined #openstack-lbaas | 01:18 | |
| *** fnaval_ has joined #openstack-lbaas | 01:19 | |
| *** fnaval has quit IRC | 01:23 | |
| *** SumitNaiksatam has joined #openstack-lbaas | 01:29 | |
| *** sapd has quit IRC | 01:40 | |
| *** sapd has joined #openstack-lbaas | 01:44 | |
| *** annp has joined #openstack-lbaas | 01:47 | |
| *** hongbin has joined #openstack-lbaas | 02:02 | |
| *** ipsecguy has quit IRC | 02:13 | |
| *** ipsecguy has joined #openstack-lbaas | 02:15 | |
| *** rcernin is now known as rcernin|lunch | 02:35 | |
| *** hongbin has quit IRC | 03:26 | |
| *** ianychoi has joined #openstack-lbaas | 03:51 | |
| *** yamamoto has joined #openstack-lbaas | 04:08 | |
| *** nmanos has joined #openstack-lbaas | 05:22 | |
| *** nmanos has quit IRC | 05:23 | |
| *** pcaruana has quit IRC | 05:24 | |
| *** nmanos has joined #openstack-lbaas | 05:24 | |
| *** nmanos has quit IRC | 05:24 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 05:39 | |
| *** Alexey_Abashkin has joined #openstack-lbaas | 05:42 | |
| *** Alexey_Abashkin has quit IRC | 05:42 | |
| *** Alexey_Abashkin has joined #openstack-lbaas | 05:42 | |
| *** AlexeyAbashkin has quit IRC | 05:43 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 05:43 | |
| *** kobis has joined #openstack-lbaas | 05:43 | |
| *** AlexeyAbashkin has quit IRC | 05:45 | |
| *** kobis has quit IRC | 05:50 | |
| *** kobis has joined #openstack-lbaas | 06:24 | |
| *** pcaruana has joined #openstack-lbaas | 06:27 | |
| *** kobis has quit IRC | 06:34 | |
| *** kobis has joined #openstack-lbaas | 06:39 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 06:42 | |
| *** AlexeyAbashkin has quit IRC | 07:04 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 07:10 | |
| *** rcernin|lunch has quit IRC | 07:13 | |
| *** pcaruana has quit IRC | 07:34 | |
| *** b_bezak has joined #openstack-lbaas | 07:42 | |
| *** pcaruana has joined #openstack-lbaas | 07:49 | |
| *** pcaruana has quit IRC | 07:59 | |
| *** b_bezak has quit IRC | 08:03 | |
| *** nmanos has joined #openstack-lbaas | 08:10 | |
| *** pcaruana has joined #openstack-lbaas | 08:15 | |
| *** AlexeyAbashkin has quit IRC | 08:54 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 08:58 | |
| *** salmankhan has joined #openstack-lbaas | 08:59 | |
| *** kobis has quit IRC | 09:09 | |
| *** kobis has joined #openstack-lbaas | 09:36 | |
| *** Alexey_Abashkin has joined #openstack-lbaas | 09:40 | |
| *** AlexeyAbashkin has quit IRC | 09:40 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 09:40 | |
| *** dun has joined #openstack-lbaas | 09:53 | |
| *** salmankhan has quit IRC | 10:15 | |
| *** salmankhan has joined #openstack-lbaas | 10:15 | |
| *** annp has quit IRC | 10:22 | |
| *** AlexeyAbashkin has quit IRC | 10:28 | |
| *** longkb has quit IRC | 10:31 | |
| *** rpittau has joined #openstack-lbaas | 11:10 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 11:45 | |
| *** Alexey_Abashkin has joined #openstack-lbaas | 11:48 | |
| *** AlexeyAbashkin has quit IRC | 11:50 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 11:50 | |
| *** AlexeyAbashkin has quit IRC | 11:52 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 11:53 | |
| *** amuller has joined #openstack-lbaas | 11:56 | |
| *** longkb has joined #openstack-lbaas | 12:08 | |
| *** cristicalin has joined #openstack-lbaas | 12:09 | |
| *** salmankhan has quit IRC | 12:21 | |
| *** longkb has quit IRC | 12:27 | |
| *** salmankhan has joined #openstack-lbaas | 12:37 | |
| openstackgerrit | Jan Zerebecki proposed openstack/neutron-lbaas master: Improve speed of listing from DB https://review.openstack.org/568361 | 12:44 |
| *** fnaval_ has quit IRC | 12:47 | |
| *** fnaval has joined #openstack-lbaas | 12:47 | |
| *** pcaruana has quit IRC | 13:00 | |
| *** kman has joined #openstack-lbaas | 13:16 | |
| *** cristicalin has quit IRC | 13:19 | |
| *** AlexeyAbashkin has quit IRC | 13:24 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 13:32 | |
| *** salmankhan has quit IRC | 13:36 | |
| *** yamamoto has quit IRC | 13:36 | |
| *** yamamoto has joined #openstack-lbaas | 13:37 | |
| *** salmankhan has joined #openstack-lbaas | 13:38 | |
| *** atoth has joined #openstack-lbaas | 13:43 | |
| *** pcaruana has joined #openstack-lbaas | 13:46 | |
| *** nmanos has quit IRC | 14:02 | |
| *** kobis has quit IRC | 14:20 | |
| *** kman has quit IRC | 14:45 | |
| *** mordred has quit IRC | 14:55 | |
| *** mordred has joined #openstack-lbaas | 15:09 | |
| johnsom | cgoncalves I provided the answer to your PENDING story. | 15:29 |
| *** yamamoto has quit IRC | 15:39 | |
| *** yamamoto has joined #openstack-lbaas | 15:40 | |
| *** yamamoto has quit IRC | 15:45 | |
| *** mordred has quit IRC | 15:48 | |
| *** mordred has joined #openstack-lbaas | 15:52 | |
| *** AlexeyAbashkin has quit IRC | 15:57 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 16:01 | |
| *** keithmnemonic[m] has quit IRC | 16:08 | |
| *** SumitNaiksatam has quit IRC | 16:24 | |
| *** salmankhan has quit IRC | 16:33 | |
| *** Alexey_Abashkin has joined #openstack-lbaas | 16:33 | |
| *** Alexey_Abashkin has quit IRC | 16:35 | |
| *** AlexeyAbashkin has quit IRC | 16:35 | |
| *** salmankhan has joined #openstack-lbaas | 16:35 | |
| *** keithmnemonic[m] has joined #openstack-lbaas | 16:38 | |
| *** salmankhan has quit IRC | 16:42 | |
| *** yamamoto has joined #openstack-lbaas | 16:42 | |
| *** salmankhan has joined #openstack-lbaas | 16:46 | |
| *** yamamoto has quit IRC | 16:49 | |
| *** SumitNaiksatam has joined #openstack-lbaas | 16:51 | |
| *** salmankhan has quit IRC | 16:53 | |
| *** salmankhan has joined #openstack-lbaas | 16:56 | |
| *** sshank has joined #openstack-lbaas | 17:02 | |
| cgoncalves | johnsom, thanks! I'll make bubble it back to rhbz. this is a good candidate to be documented, if it's not yet somewhere upstream | 17:03 |
| cgoncalves | nmagnezi, ^ | 17:03 |
| cgoncalves | nmagnezi, https://storyboard.openstack.org/#!/story/2002216 | 17:03 |
| *** Swami has joined #openstack-lbaas | 17:14 | |
| *** salmankhan has quit IRC | 17:38 | |
| *** kobis has joined #openstack-lbaas | 17:45 | |
| *** devfaz has quit IRC | 17:47 | |
| *** devfaz has joined #openstack-lbaas | 17:51 | |
| *** kobis has quit IRC | 18:13 | |
| *** yamamoto has joined #openstack-lbaas | 18:47 | |
| *** dun has quit IRC | 19:07 | |
| *** amuller has quit IRC | 19:12 | |
| *** atoth has quit IRC | 19:21 | |
| *** sshank has quit IRC | 19:27 | |
| *** salmankhan has joined #openstack-lbaas | 19:30 | |
| *** salmankhan has quit IRC | 19:34 | |
| *** AlexeyAbashkin has joined #openstack-lbaas | 20:05 | |
| *** Alexey_Abashkin has joined #openstack-lbaas | 20:08 | |
| *** AlexeyAbashkin has quit IRC | 20:09 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 20:09 | |
| *** Alexey_Abashkin has joined #openstack-lbaas | 20:15 | |
| *** AlexeyAbashkin has quit IRC | 20:16 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 20:16 | |
| *** yamamoto has quit IRC | 20:23 | |
| johnsom | Quiet day here. I've been distracted with internal paperwork, so... Plan to get on that updates patch today though | 20:43 |
| *** keithmnemonic[m] has quit IRC | 20:49 | |
| *** AlexeyAbashkin has quit IRC | 20:52 | |
| *** juggsmcb has joined #openstack-lbaas | 20:55 | |
| *** juggsmcb has left #openstack-lbaas | 20:56 | |
| *** pcaruana has quit IRC | 21:04 | |
| *** keithmnemonic[m] has joined #openstack-lbaas | 21:11 | |
| *** aojea has joined #openstack-lbaas | 21:14 | |
| *** yamamoto has joined #openstack-lbaas | 21:24 | |
| *** sapd has quit IRC | 21:26 | |
| *** sapd has joined #openstack-lbaas | 21:27 | |
| *** sapd has quit IRC | 21:27 | |
| *** sapd has joined #openstack-lbaas | 21:27 | |
| openstackgerrit | Michael Johnson proposed openstack/neutron-lbaas master: Allow to create loadbalancer with chinese character https://review.openstack.org/569784 | 21:32 |
| *** yamamoto has quit IRC | 21:39 | |
| *** fnaval has quit IRC | 22:13 | |
| *** aojea has quit IRC | 22:23 | |
| *** fnaval has joined #openstack-lbaas | 22:36 | |
| *** fnaval has quit IRC | 22:39 | |
| *** rcernin has joined #openstack-lbaas | 22:44 | |
| mnaser | small reminder of https://review.openstack.org/#/c/574368/ if anyone has a few extra cycles :) | 23:03 |
| johnsom | Yeah, I think I can take a look at that soon | 23:04 |
| *** keithmnemonic[m] has quit IRC | 23:15 | |
| *** threestrands has joined #openstack-lbaas | 23:36 | |
| *** keithmnemonic[m] has joined #openstack-lbaas | 23:38 | |
| rm_work | johnsom: also when you have 15 seconds (the extravagant amount of time it'll take you to review this): https://review.openstack.org/#/c/573470/ | 23:53 |
| johnsom | rm_work same here: https://review.openstack.org/#/c/573431/ | 23:55 |
| rm_work | sure | 23:55 |
| johnsom | I am tempest testing the update fix now, if it's all good I will fix the unit tests I broke and push that up today. | 23:56 |
| rm_work | k | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!