*** rcernin has joined #openstack-lbaas | 00:05 | |
*** yamamoto has quit IRC | 00:34 | |
*** yamamoto has joined #openstack-lbaas | 00:55 | |
openstackgerrit | Adam Harwell proposed openstack/octavia-tempest-plugin master: Allow amp-list test to run in a busy environment https://review.opendev.org/607382 | 02:12 |
---|---|---|
*** goldyfruit has joined #openstack-lbaas | 02:25 | |
rm_work | johnsom / cgoncalves: https://review.opendev.org/#/c/688548/ / https://review.opendev.org/#/c/688546/ | 02:32 |
rm_work | ^_^ | 02:32 |
rm_work | need to start poking at the priority review list again soon | 02:33 |
rm_work | I just cleaned it up a bit | 02:33 |
rm_work | not sure I got everything though | 02:33 |
rm_work | I ... am going to try to make it to the meeting tomorrow. :D | 02:38 |
openstackgerrit | Merged openstack/octavia-dashboard master: Fix dashboard certificates skipping pkcs12 bundles https://review.opendev.org/683751 | 02:45 |
*** ramishra has joined #openstack-lbaas | 03:11 | |
*** ricolin has joined #openstack-lbaas | 03:16 | |
*** yamamoto has quit IRC | 03:33 | |
openstackgerrit | Merged openstack/octavia-tempest-plugin master: Fix positional formatting and add skip check https://review.opendev.org/673168 | 04:13 |
*** yamamoto has joined #openstack-lbaas | 04:22 | |
*** ajay33 has joined #openstack-lbaas | 04:34 | |
*** yamamoto has quit IRC | 05:05 | |
*** yamamoto has joined #openstack-lbaas | 05:08 | |
rm_work | cgoncalves: https://review.opendev.org/#/c/682501/ :D | 05:29 |
rm_work | pretty plz | 05:29 |
rm_work | so annoying | 05:29 |
openstackgerrit | Merged openstack/octavia master: [Trivial]Add missing ws between words https://review.opendev.org/689974 | 05:33 |
rm_work | cgoncalves: https://review.opendev.org/#/c/665103/ this too ^_^ | 05:58 |
*** yamamoto has quit IRC | 06:01 | |
*** ccamposr has joined #openstack-lbaas | 06:07 | |
*** ccamposr__ has joined #openstack-lbaas | 06:09 | |
*** ccamposr has quit IRC | 06:12 | |
*** yamamoto has joined #openstack-lbaas | 06:14 | |
*** yamamoto has quit IRC | 06:26 | |
*** yamamoto has joined #openstack-lbaas | 06:37 | |
*** rcernin has quit IRC | 06:37 | |
*** yamamoto has quit IRC | 06:49 | |
*** gcheresh_ has joined #openstack-lbaas | 06:51 | |
*** maciejjozefczyk has joined #openstack-lbaas | 06:52 | |
*** yamamoto has joined #openstack-lbaas | 06:55 | |
*** trident has quit IRC | 06:55 | |
*** trident has joined #openstack-lbaas | 07:00 | |
*** AlexStaf has joined #openstack-lbaas | 07:08 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/octavia-dashboard master: Imported Translations from Zanata https://review.opendev.org/690481 | 07:17 |
rm_work | cgoncalves: i see you got one of those -- but this one pretty plzzzz https://review.opendev.org/#/c/682501/ | 07:20 |
rm_work | hmm i guess i'm not sure if anyone but me (with core) has an OSX machine to test on tho >_> | 07:21 |
*** yamamoto has quit IRC | 07:24 | |
*** yamamoto has joined #openstack-lbaas | 07:36 | |
*** ivve has joined #openstack-lbaas | 07:39 | |
*** yamamoto has quit IRC | 07:55 | |
*** yamamoto has joined #openstack-lbaas | 07:57 | |
openstackgerrit | Dat Le proposed openstack/octavia stable/rocky: Support to create amphora with customized metadata https://review.opendev.org/690498 | 08:06 |
*** rpittau|afk is now known as rpittau | 08:07 | |
*** tkajinam has quit IRC | 08:10 | |
*** yamamoto has quit IRC | 08:17 | |
*** yamamoto has joined #openstack-lbaas | 08:20 | |
*** yamamoto has quit IRC | 08:26 | |
*** yamamoto has joined #openstack-lbaas | 08:26 | |
*** yamamoto has quit IRC | 08:32 | |
*** yamamoto has joined #openstack-lbaas | 08:33 | |
*** yamamoto has quit IRC | 08:37 | |
*** yamamoto has joined #openstack-lbaas | 08:38 | |
openstackgerrit | Merged openstack/octavia master: Do not set log format when 'no log' is set https://review.opendev.org/687936 | 08:40 |
*** pcaruana has joined #openstack-lbaas | 09:02 | |
*** ataraday_ has joined #openstack-lbaas | 09:04 | |
*** yamamoto has quit IRC | 09:14 | |
*** yamamoto has joined #openstack-lbaas | 09:14 | |
*** maciejjozefczyk has quit IRC | 09:20 | |
openstackgerrit | Merged openstack/octavia master: Allow IPv6 health network in devstack https://review.opendev.org/665103 | 09:20 |
*** maciejjozefczyk has joined #openstack-lbaas | 09:20 | |
*** rcernin has joined #openstack-lbaas | 09:23 | |
*** psachin has joined #openstack-lbaas | 09:46 | |
*** psachin has quit IRC | 09:52 | |
*** yamamoto has quit IRC | 10:17 | |
*** pcaruana has quit IRC | 10:41 | |
*** ramishra has quit IRC | 11:32 | |
*** AlexStaf has quit IRC | 11:43 | |
*** AlexStaf has joined #openstack-lbaas | 11:53 | |
*** yamamoto has joined #openstack-lbaas | 12:05 | |
*** yamamoto has quit IRC | 12:08 | |
*** goldyfruit has quit IRC | 12:14 | |
openstackgerrit | Ann Taraday proposed openstack/octavia master: Add option to set default ssl ciphers in haproxy https://review.opendev.org/685337 | 12:21 |
openstackgerrit | Ann Taraday proposed openstack/octavia master: Jobboard based controller https://review.opendev.org/647406 | 12:24 |
openstackgerrit | Ann Taraday proposed openstack/octavia master: Use retry for AmphoraComputeConnectivityWait https://review.opendev.org/662791 | 12:41 |
openstackgerrit | Ann Taraday proposed openstack/octavia master: Transition l7policy flows to dicts https://review.opendev.org/665977 | 12:43 |
openstackgerrit | Ann Taraday proposed openstack/octavia master: Transition l7rule flows to dicts https://review.opendev.org/668173 | 12:44 |
*** yamamoto has joined #openstack-lbaas | 12:48 | |
*** takamatsu has joined #openstack-lbaas | 12:48 | |
*** vishalmanchanda has joined #openstack-lbaas | 12:52 | |
*** pcaruana has joined #openstack-lbaas | 12:53 | |
*** yamamoto has quit IRC | 13:02 | |
*** rcernin has quit IRC | 13:24 | |
*** goldyfruit has joined #openstack-lbaas | 13:25 | |
*** ramishra has joined #openstack-lbaas | 13:48 | |
*** ajay33 has quit IRC | 13:49 | |
*** ivve has quit IRC | 14:05 | |
*** yamamoto has joined #openstack-lbaas | 14:33 | |
*** ataraday_ has quit IRC | 14:35 | |
*** yamamoto has quit IRC | 14:35 | |
*** numans has quit IRC | 14:43 | |
*** gcheresh_ has quit IRC | 14:56 | |
*** pcaruana has quit IRC | 14:57 | |
*** yamamoto has joined #openstack-lbaas | 15:07 | |
*** yamamoto has quit IRC | 15:11 | |
*** maciejjozefczyk has quit IRC | 15:16 | |
*** goldyfruit has quit IRC | 15:46 | |
*** yamamoto has joined #openstack-lbaas | 15:52 | |
*** ataraday_ has joined #openstack-lbaas | 15:58 | |
rm_work | #startmeeting Octavia | 16:00 |
openstack | Meeting started Wed Oct 23 16:00:01 2019 UTC and is due to finish in 60 minutes. The chair is rm_work. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
*** openstack changes topic to " (Meeting topic: Octavia)" | 16:00 | |
openstack | The meeting name has been set to 'octavia' | 16:00 |
johnsom | o/ | 16:00 |
rm_work | o/ | 16:00 |
colin- | hi | 16:00 |
haleyb | hi | 16:01 |
*** yamamoto has quit IRC | 16:01 | |
rm_work | #topic Announcements | 16:02 |
*** openstack changes topic to "Announcements (Meeting topic: Octavia)" | 16:02 | |
rm_work | Queens is transitioning to Extended Maintenance! | 16:02 |
rm_work | #link http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010161.html | 16:02 |
rm_work | Any other announcements today? | 16:03 |
cgoncalves | hi | 16:03 |
ataraday_ | hi | 16:03 |
johnsom | I have proposed a 1.11.0 python-octaviaclient release: https://review.opendev.org/690386 | 16:04 |
johnsom | #link https://review.opendev.org/690386 | 16:04 |
johnsom | There is no real functional changes, it is just to get PDF docs going and fix a help string bug that was breaking python-openstackclient docs. | 16:04 |
johnsom | So no need for people to rush and update. | 16:04 |
rm_work | cool | 16:05 |
johnsom | That is the only announcement I have | 16:05 |
rm_work | k | 16:05 |
rm_work | anyone else? | 16:05 |
rm_work | #topic Brief progress reports / bugs needing review | 16:06 |
*** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)" | 16:06 | |
rm_work | I started to refresh our Priority etherpad | 16:06 |
rm_work | #link https://etherpad.openstack.org/p/octavia-priority-reviews | 16:06 |
johnsom | I have been focused on a series of issues related to certificate handling. One of those patches has merged, the other I posted yesterday: | 16:07 |
johnsom | #link https://review.opendev.org/690444 | 16:07 |
johnsom | I also fixed an issue with the gates Friday related to version 2.4 of networkx (taskflow uses this). I have also submitted a patch to Taskflow to prepare it for the 2.x series of networkx. | 16:08 |
johnsom | #link https://review.opendev.org/689611 | 16:08 |
ataraday_ | Working on taskflow changes queue... Checking errors that job octavia-v2-dsvm-scenario-amphora-v2 got on them - if there are relevent etc.. | 16:08 |
*** maciejjozefczyk has joined #openstack-lbaas | 16:09 | |
ataraday_ | Looking forward reviews for #link https://review.opendev.org/#/c/689128/ | 16:09 |
johnsom | I have a few more TLS related patches to work on, then hopefully moving back to fixing the failover flow. | 16:09 |
rm_work | ataraday_: how close are those patches to us being able to merge the whole set? | 16:10 |
johnsom | ataraday_ Done, makes sense | 16:10 |
rm_work | i was kinda poking at them the other day | 16:10 |
rm_work | would love to get moving on those, and stuff tends to move faster once we get the base work merged | 16:11 |
ataraday_ | all changes ready for review :) | 16:11 |
ataraday_ | I rebased jobboard controller on the top of all refactor, so when extra change will be merged - like retry and tempest and job will be green - we can merge | 16:13 |
rm_work | cool | 16:13 |
rm_work | might try to get through those soon | 16:14 |
ataraday_ | Retry change #link https://review.opendev.org/#/c/662791/ | 16:14 |
rm_work | I just have one bugfix i'd like to see merged | 16:14 |
rm_work | #link https://review.opendev.org/#/c/688548/ | 16:14 |
rm_work | and its dep in octavia-lib | 16:15 |
rm_work | alright, moving on... | 16:16 |
rm_work | #topic Open Discussion | 16:16 |
*** openstack changes topic to "Open Discussion (Meeting topic: Octavia)" | 16:16 | |
rm_work | how is this meeting time for folks? any chance it could be a couple hours later? or is this pushing it? | 16:16 |
johnsom | FYI, we have an agenda etherpad for the Shanghai PTG: | 16:17 |
johnsom | #link https://etherpad.openstack.org/p/octavia-shanghai-U-ptg | 16:17 |
colin- | i am flexible | 16:17 |
johnsom | I am fine with a later time | 16:17 |
ataraday_ | for me this time is fine, but I can do later as well. | 16:18 |
cgoncalves | question would be what time and possibly different date. doodle? | 16:18 |
rm_work | well, yes, but mostly would like... 2 hours later for instance be workable for folks? | 16:19 |
cgoncalves | fine for me during non-DST (starting next week) | 16:20 |
rm_work | k, i can make a doodle but not sure what other times i'd like to put on there | 16:22 |
rm_work | might just be this time and that time :D | 16:22 |
cgoncalves | I'd say add as many time slots as possible | 16:25 |
rm_work | alright, anything else? | 16:25 |
johnsom | FYI, I have -2'd this feature patch to stable/rocky: | 16:25 |
johnsom | #link https://review.opendev.org/#/c/690498 | 16:25 |
cgoncalves | feature patch and straight to rocky? hmmmm | 16:25 |
johnsom | Right, it also references a blueprint that doesn't exist | 16:26 |
rm_work | probably running a rocky cloud | 16:26 |
rm_work | wouldn't mind some of that if it were proposed to master :) | 16:26 |
johnsom | Well, I wonder if they know how Octavia works. Monitoring amphora directly is.... questionable value. | 16:27 |
johnsom | But, yes, I commented that it could be proposed to master | 16:27 |
rm_work | right | 16:27 |
johnsom | Feel free to add additional comments, etc. | 16:27 |
rm_work | but sometimes they get lost | 16:27 |
rm_work | and it'd be nice info to have stamped on them :) | 16:27 |
rm_work | anywho, yes, can't be on rocky | 16:27 |
maciejjozefczyk | johnsom, rm_work hey! can you please take a look on this one? https://review.opendev.org/#/c/672264/ For now all the tests have ROUND_ROBIN algorithm hardcoded. That makes OVN tests not possible to successfully run (all the tests will be failing). That would be great to start running OVN gate first. Can we do a refactor of this issue later? | 16:28 |
maciejjozefczyk | I know thats not mona lisa, but that could unblock us, folks :) | 16:29 |
cgoncalves | maciejjozefczyk, octavia-tempest-plugin is branchless, hence there's no time-constraint (i.e. Usurri feature freeze) | 16:31 |
johnsom | I think the other cores should comment. I still stand behind my comment that adding a config option for which algorithm is tested is counter productive for the test suite in general. | 16:31 |
cgoncalves | plus, your patch also adds a new option. this means that sooner or later we would need to deprecate which comes at a cost | 16:32 |
rm_work | technically not ALL options get deprecated :D | 16:32 |
johnsom | Yeah, deprecation on a branchless repo is... painful | 16:33 |
cgoncalves | plus^2, agreeing with johnsom that we should test as many algorithms as possible. we don't want to run reconfigure and run tempest multiple times to test different algos | 16:33 |
maciejjozefczyk | cgoncalves, johnsom so that would need a refactor of whole octavia-tempest-plugin | 16:34 |
rm_work | yeah, might just want to have tests for each and skip them based on what's available? | 16:34 |
johnsom | rm_work That is what I proposed | 16:34 |
rm_work | so we can do a provider list | 16:34 |
rm_work | and detect that way which ones we can run | 16:34 |
johnsom | rm_work We already have a config for "provider" | 16:34 |
rm_work | ah | 16:34 |
johnsom | #link https://github.com/openstack/octavia-tempest-plugin/blob/master/octavia_tempest_plugin/config.py#L96 | 16:35 |
maciejjozefczyk | But its not only about skipping tests that are not accurate for given provider driver, for example this part: https://review.opendev.org/#/c/672264/9/octavia_tempest_plugin/tests/test_base.py is about checking if members are balanced | 16:36 |
johnsom | What I proposed is for each test that is using RR, we create another test that uses the "SOURCE_IP_PORT", then do a skip check for each based on the configured provider. | 16:36 |
johnsom | Since OVN doesn't support RR and amphora doesn't support "SOURCE_IP_PORT" | 16:37 |
rm_work | yep, seems sane to me | 16:37 |
rm_work | though that still makes it impossible to test multiple in one run | 16:38 |
johnsom | Yes, a "check member balanced" will need to be created for the "SOURCE_IP_PORT" algorithm. Or the test to at least be appropriate to test that algorithm. | 16:38 |
rm_work | we COULD do something smart and inspect providers and flavors and see if we should try testing with multiple flavors or something, or allow that to be configured | 16:38 |
rm_work | but at least just adding both tests would be a start | 16:39 |
maciejjozefczyk | So what about api tests? Like this? https://review.opendev.org/#/c/672264/9/octavia_tempest_plugin/tests/api/v2/test_member.py | 16:39 |
*** ccamposr__ has quit IRC | 16:39 | |
johnsom | rm_work Why would it? It would run all the tests that apply to that provider. The config option proposed is the only one that would limit it to only testing one per run. | 16:39 |
rm_work | no, you linked to the config option already merged that sets what provider to use | 16:40 |
rm_work | which is a single provider | 16:40 |
johnsom | rm_work Yes, test runs are validate against one "provider" at a time. The proposed patch would make test runs only valid for one provider and one LB algorithm. | 16:41 |
rm_work | yeah, but what you proposed still just runs one algorithm test | 16:41 |
rm_work | it does pick it correctly | 16:41 |
johnsom | rm_work Run per-provider seems valid given the other infrastructure requirements for them. | 16:41 |
rm_work | but if we want to run BOTH, we'd need to detect flavors, etc | 16:41 |
johnsom | rm_work I think we have confused you. | 16:42 |
rm_work | [09:33:25] cgoncalves:plus^2, agreeing with johnsom that we should test as many algorithms as possible. we don't want to run reconfigure and run tempest multiple times to test different algos | 16:42 |
johnsom | rm_work We should leave the provider config. That is valid. I'm just saying the algorithm tests should run all algorithms that are valid for a given provider. | 16:42 |
rm_work | [09:38:17] rm_work:though that still makes it impossible to test multiple in one run | 16:42 |
rm_work | [09:36:59] johnsom:What I proposed is for each test that is using RR, we create another test that uses the "SOURCE_IP_PORT", then do a skip check for each based on the configured provider. | 16:43 |
rm_work | ^^ that's two | 16:43 |
rm_work | one for each | 16:43 |
rm_work | and requires two runs and a reconfigure inbetween | 16:43 |
rm_work | it's technically possible to test both in one run | 16:43 |
rm_work | if there exist flavors to allow it | 16:43 |
johnsom | rm_work only because OVN doesn't support anything other than "SOURCE_IP_PORT". For amphora, one run should test multiple algorithms that it supports. Unlike the proposed patch. | 16:44 |
johnsom | rm_work No, this has nothing to do with flavors. | 16:44 |
maciejjozefczyk | johnsom, I don't understand. How? | 16:44 |
maciejjozefczyk | johnsom, Looks like everything is hardcoded, no? | 16:44 |
rm_work | yeah i'm talking less about the proposed patch, and more about what we WANT to see | 16:45 |
rm_work | johnsom: flavors are the only way to actually run with multiple providers at the same time right now | 16:45 |
rm_work | so yes, it has to do with flavors? | 16:45 |
johnsom | maciejjozefczyk That is what I am proposing instead of your patch. | 16:45 |
johnsom | rm_work We don't want to run multiple providers in one test run. That is not what I am proposing and I think it is a bad idea. | 16:46 |
cgoncalves | rm_work, disregard test of multiple providers in same run | 16:46 |
johnsom | rm_work We want one test run per provider, each running all of the algorithm tests it can. | 16:46 |
rm_work | k, then that requires us to duplicate our test a bunch of times | 16:46 |
rm_work | because right now it just tests RR | 16:47 |
rm_work | not just add SOURCE_IP | 16:47 |
cgoncalves | we want to have the ability to test multiple algorithms for the same provider in one run. e.g. test RR and LEAST_CONNECTION for a given provider | 16:47 |
johnsom | rm_work Right, today we only have tests for one algorithm. I am saying we should fix that. | 16:47 |
cgoncalves | +1 | 16:47 |
johnsom | cgoncalves +1 | 16:47 |
maciejjozefczyk | +1 cgoncalves | 16:47 |
cgoncalves | otherwise it also comes at a cost of exploding our CI job matrix | 16:47 |
rm_work | maciejjozefczyk: +1 | 16:47 |
cgoncalves | seems we're all in agreement, in a round-robin fashion :D | 16:48 |
maciejjozefczyk | johnsom, rm_work so how we could do it? inspect provider algorithm and then generate classes dynamically based on current code? that would have only changed unsed algorithm? | 16:48 |
rm_work | nah, just write the test a bunch | 16:48 |
rm_work | as long as it's fairly decomposed, it won't be a ton of code reuse | 16:48 |
rm_work | and then do skiptests depending on the config value for provider | 16:49 |
rm_work | we COULD try to be fancy and use one test and detect the provider and switch out the algorithm+test_func based on a dictionary of options | 16:49 |
rm_work | but | 16:49 |
rm_work | ¯\_(ツ)_/¯ | 16:50 |
johnsom | Well, that is an implementation detail. There would be a run for each algorithm and a validation for each algorithm. So, maybe separate tests is easier/better. | 16:50 |
haleyb | maciejjozefczyk: can you just create sub-classes with a single line selecting the algorithm, then @skip some? i think that's what ^^^ is ? | 16:50 |
rm_work | yes | 16:50 |
maciejjozefczyk | hum, so we have ~17 testfiles here https://review.opendev.org/#/c/672264/; for every class we're just inherit with given subclass? It will produce a lot of new classes | 16:50 |
*** rpittau is now known as rpittau|afk | 16:50 | |
rm_work | just another method | 16:51 |
rm_work | not another full class, I think | 16:51 |
rm_work | i mean, I guess you could do it that way too O_o | 16:51 |
* johnsom wonders if supporting the tempest suite for third party drivers is a good idea.... | 16:51 | |
rm_work | well, for a ton of tests (everything but traffic, pretty much) the only change is literally which default algorithm to use | 16:52 |
rm_work | so you *could* at a very high level (base test class?) just detect provider and select a "default algorithm" | 16:52 |
rm_work | and then for the tests where it *matters*, create copies and skip the ones that don't run | 16:53 |
johnsom | You would still want per-algorithm tests though | 16:53 |
rm_work | not for a ton of them | 16:53 |
johnsom | right, we said the same thing at the same time-ish | 16:53 |
rm_work | most tests don't actually CARE about the algorithm, they just provide it so it will be valid create syntax | 16:54 |
maciejjozefczyk | rm_work, like an API tests | 16:54 |
rm_work | yes, like all API tests | 16:54 |
maciejjozefczyk | maybe not all, | 16:54 |
cgoncalves | yeah but now we'd be actually testing the algorithm | 16:54 |
johnsom | It's really too bad there isn't support for RR in OVN | 16:54 |
maciejjozefczyk | johnsom, yeah... | 16:54 |
rm_work | well, we already have exactly one test for algorithm testing | 16:54 |
rm_work | the traffic-ops test | 16:54 |
rm_work | that's the one that'd actually benefit from having copies for each alg | 16:55 |
cgoncalves | right | 16:55 |
rm_work | but the majority of tests just need to fill that field with SOMETHING valid | 16:55 |
rm_work | so they can do their real testing which is "does a member create work or ERROR" | 16:55 |
johnsom | Agreed, something valid | 16:55 |
cgoncalves | algorithm validation with traffic is important also for certification purposes | 16:56 |
rm_work | so yes, for 99% of tests, selecting a default algorithm in a base class based on the provider would work | 16:56 |
johnsom | yep | 16:56 |
rm_work | then for the traffic tests, you'd want to actually put in the work to make them validate each algorithm | 16:56 |
rm_work | and skip as appropriate | 16:56 |
johnsom | Well, maybe a bit more than 99%, but yes. | 16:56 |
maciejjozefczyk | rm_work +1 | 16:56 |
maciejjozefczyk | rm_work I own you a beer in Shanghai | 16:57 |
johnsom | rm_work Yep. That is what I proposed in a comment on that patch. | 16:57 |
rm_work | lol yeah i guess i'll take it since johnsom isn't there :D | 16:57 |
maciejjozefczyk | johnsom, you too :) | 16:57 |
johnsom | lol | 16:57 |
cgoncalves | he can take the week after Shanghai :P | 16:57 |
maciejjozefczyk | ahh. :P | 16:57 |
maciejjozefczyk | ah, right, Barcelona | 16:57 |
maciejjozefczyk | ;) | 16:57 |
rm_work | k well, we went through the meeting time pretty well there | 16:58 |
rm_work | any parting comments? | 16:58 |
rm_work | we've got one more meeting before the summit | 16:58 |
rm_work | then will probably cancel the meeting during the summit, per usual | 16:59 |
johnsom | +1 | 16:59 |
rm_work | alright | 16:59 |
rm_work | thanks for coming folks! | 16:59 |
rm_work | #endmeeting | 16:59 |
*** openstack changes topic to "Discussions for OpenStack Octavia | Priority bug review list: https://etherpad.openstack.org/p/octavia-priority-reviews" | 16:59 | |
openstack | Meeting ended Wed Oct 23 16:59:54 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:59 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2019/octavia.2019-10-23-16.00.html | 16:59 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2019/octavia.2019-10-23-16.00.txt | 16:59 |
openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2019/octavia.2019-10-23-16.00.log.html | 17:00 |
maciejjozefczyk | Thanks! | 17:00 |
*** ataraday_ has quit IRC | 17:07 | |
cgoncalves | johnsom, rm_work: would you disagree that https://review.opendev.org/#/c/688546/ is not a backport candidate as it touches API? | 17:10 |
rm_work | yeah, that might be true... | 17:12 |
johnsom | cgoncalves Yeah, this one is nasty as it does change the API on providers. I considered asking for a compatibility method for the old signature. | 17:12 |
*** ricolin has quit IRC | 17:55 | |
*** vishalmanchanda has quit IRC | 17:59 | |
*** ricolin has joined #openstack-lbaas | 18:03 | |
*** ricolin has quit IRC | 18:25 | |
*** pcaruana has joined #openstack-lbaas | 18:38 | |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Fix listeners with SNI certificates https://review.opendev.org/690444 | 18:39 |
*** pcaruana has quit IRC | 18:44 | |
*** maciejjozefczyk has quit IRC | 18:50 | |
rm_work | johnsom: i think i'm gonna poke at building `--wait` for the loadbalancer client today | 18:56 |
rm_work | or --poll or ... whatever is most like what other services use | 18:56 |
rm_work | I think --wait is right | 18:56 |
rm_work | yeah, that's what nova uses | 18:57 |
rm_work | any objections? | 18:57 |
rm_work | would simplify a lot of stuff because i can't count the number of times i've rewritten the polling logic in various places | 18:57 |
rm_work | just poll at a sane interval and return the final LB state -- and code 0 for success, 1 for failure | 18:58 |
rm_work | anywho, brb loonch | 18:58 |
rm_work | Probably also `--wait-timeout <seconds>` | 19:00 |
johnsom | Sounds good to me | 19:01 |
johnsom | How often do you plan to poll? | 19:02 |
rm_work | Hmm... I'll look at what nova does, but I was thinking 2s or so | 19:06 |
rm_work | Speed will be better too on internal polling because it won't have to go through all the keystone auth stuff every single time | 19:06 |
johnsom | Yep | 19:12 |
*** gcheresh_ has joined #openstack-lbaas | 19:18 | |
*** abaindur has joined #openstack-lbaas | 19:21 | |
johnsom | If someone is bored and has cycles, we could go through and remove the six stuff for py27 | 19:28 |
*** gcheresh_ has quit IRC | 19:59 | |
*** gcheresh_ has joined #openstack-lbaas | 20:18 | |
*** gcheresh_ has quit IRC | 20:31 | |
rm_work | ooooooooooooh | 21:08 |
rm_work | oooooh | 21:08 |
rm_work | me | 21:08 |
rm_work | me me me | 21:08 |
rm_work | I love deleting cruft | 21:08 |
rm_work | it's one of my favorite activities :D | 21:08 |
rm_work | but ... i guess since it's fairly simple, someone else could probably do it as low-hanging fruit... | 21:09 |
johnsom | I'm itching for it to go, but I'm a bit busy right now with TLS SNI stuffs | 21:09 |
rm_work | ... except maybe some of the unicode parts lol | 21:09 |
johnsom | Just about to have an SNI tempest scenario. Handy to test my new patch... grin | 21:09 |
rm_work | how about I do it on top of your TLS work? unless you were hoping it was gone | 21:09 |
rm_work | so you don't have to deal with py2 unicode : | 21:10 |
rm_work | :D | 21:10 |
johnsom | Sure, this should be pretty close to good: https://review.opendev.org/690444 (it at least passes the existing TLS tests) | 21:10 |
johnsom | It's going to be one of those "touch everything" patches we should merge quickly IMO | 21:11 |
*** henriqueof has quit IRC | 21:15 | |
openstackgerrit | Merged openstack/octavia master: Fix some plug.py unit tests that broke on OSX https://review.opendev.org/682501 | 21:27 |
johnsom | rm_work ^^^^ There you go fruit fanboy | 21:29 |
rm_work | :P | 21:29 |
rm_work | yes, i am pleased | 21:29 |
rm_work | for the record, I despise Apple as a company, but their macbook hardware is just... better. | 21:30 |
rm_work | or it was, until this generation :/ | 21:30 |
*** goldyfruit has joined #openstack-lbaas | 21:38 | |
*** yamamoto has joined #openstack-lbaas | 21:59 | |
*** ccamposr has joined #openstack-lbaas | 22:02 | |
*** yamamoto has quit IRC | 22:03 | |
*** goldyfruit has quit IRC | 22:04 | |
*** ramishra has quit IRC | 22:07 | |
*** ccamposr has quit IRC | 22:17 | |
*** rcernin has joined #openstack-lbaas | 22:33 | |
*** tkajinam has joined #openstack-lbaas | 23:02 | |
*** abaindur has quit IRC | 23:03 | |
*** abaindur has joined #openstack-lbaas | 23:04 | |
*** yamamoto has joined #openstack-lbaas | 23:26 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!