*** hongbin has quit IRC | 00:15 | |
*** hongbin has joined #openstack-lbaas | 00:28 | |
rm_work | damnit, i was going to ask the original author for help on this confusing test: https://github.com/openstack/octavia/blame/master/octavia/tests/unit/network/drivers/neutron/test_allowed_address_pairs.py#L203 | 00:49 |
---|---|---|
rm_work | and then i looked at the git-blame <_< | 00:49 |
*** wuchunyang has joined #openstack-lbaas | 00:55 | |
*** wuchunyang has quit IRC | 01:06 | |
*** jamesdenton has joined #openstack-lbaas | 01:17 | |
*** jamesdenton has quit IRC | 01:22 | |
*** jamesdenton has joined #openstack-lbaas | 01:25 | |
*** wuchunyang has joined #openstack-lbaas | 01:41 | |
johnsom | lol, I hate it when that happens | 01:50 |
*** sapd1 has quit IRC | 02:20 | |
*** hongbin_ has joined #openstack-lbaas | 02:25 | |
*** hongbin has quit IRC | 02:28 | |
*** sapd__x has joined #openstack-lbaas | 02:38 | |
*** ramishra has joined #openstack-lbaas | 02:44 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Share the LB security group with the LB owner https://review.opendev.org/723735 | 03:17 |
*** psachin has joined #openstack-lbaas | 03:23 | |
*** hongbin_ has quit IRC | 03:29 | |
openstackgerrit | wu.chunyang proposed openstack/octavia master: Add notifications specification documens https://review.opendev.org/727915 | 03:40 |
wuchunyang | hi eveyone, will we have a discuss about octavia notification ? | 03:41 |
openstackgerrit | wu.chunyang proposed openstack/octavia master: Add notifications specification documens https://review.opendev.org/727915 | 03:50 |
*** wuchunyang has quit IRC | 04:05 | |
*** wuchunyang has joined #openstack-lbaas | 04:18 | |
*** wuchunyang has quit IRC | 04:23 | |
*** gcheresh has joined #openstack-lbaas | 04:33 | |
*** vishalmanchanda has joined #openstack-lbaas | 04:48 | |
*** wuchunyang has joined #openstack-lbaas | 04:56 | |
*** wuchunyang has quit IRC | 05:02 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Refactor the failover flows https://review.opendev.org/705317 | 05:11 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Share the LB security group with the LB owner https://review.opendev.org/723735 | 05:12 |
*** KeithMnemonic has quit IRC | 05:14 | |
openstackgerrit | wu.chunyang proposed openstack/octavia master: Fix hacking min version to 3.0.1 https://review.opendev.org/727931 | 05:52 |
*** wuchunyang has joined #openstack-lbaas | 05:57 | |
*** maciejjozefczyk has joined #openstack-lbaas | 07:06 | |
*** ccamposr has joined #openstack-lbaas | 07:11 | |
*** sapd1 has joined #openstack-lbaas | 07:11 | |
*** ccamposr__ has quit IRC | 07:14 | |
*** rpittau|afk is now known as rpittau | 07:33 | |
*** ataraday_ has joined #openstack-lbaas | 07:33 | |
openstackgerrit | wu.chunyang proposed openstack/octavia master: Fix hacking min version to 3.0.1 https://review.opendev.org/727931 | 08:31 |
openstackgerrit | Ann Taraday proposed openstack/octavia master: Add retry for getting amphora VM https://review.opendev.org/726084 | 10:10 |
*** wuchunyang has quit IRC | 10:14 | |
*** rpittau is now known as rpittau|bbl | 10:18 | |
openstackgerrit | Ann Taraday proposed openstack/octavia master: Add retry for getting amphora VM https://review.opendev.org/726084 | 10:20 |
openstackgerrit | melissaml proposed openstack/octavia master: Remove translation sections from setup.cfg https://review.opendev.org/728025 | 10:55 |
*** wuchunyang has joined #openstack-lbaas | 11:01 | |
*** happyhemant has joined #openstack-lbaas | 11:33 | |
*** servagem has joined #openstack-lbaas | 11:47 | |
*** tkajinam has quit IRC | 12:01 | |
*** rpittau|bbl is now known as rpittau | 12:15 | |
*** wuchunyang has quit IRC | 12:48 | |
*** psachin has quit IRC | 13:25 | |
johnsom | https://www.theregister.co.uk/2020/05/14/openstack_ussuri/ | 13:40 |
cgoncalves | yay! | 13:42 |
*** wuchunyang has joined #openstack-lbaas | 13:43 | |
*** KeithMnemonic has joined #openstack-lbaas | 13:43 | |
cgoncalves | one good metric for measuring how important OpenStack is to a (vendor) organization is by number of commits... | 13:46 |
*** TrevorV has joined #openstack-lbaas | 14:07 | |
*** riuzen has joined #openstack-lbaas | 14:32 | |
*** maciejjozefczyk has quit IRC | 14:33 | |
*** maciejjozefczyk has joined #openstack-lbaas | 14:33 | |
openstackgerrit | wu.chunyang proposed openstack/octavia master: Fix hacking min version to 3.0.1 https://review.opendev.org/727931 | 14:49 |
*** gcheresh has quit IRC | 15:03 | |
*** gcheresh has joined #openstack-lbaas | 15:10 | |
*** wuchunyang has quit IRC | 15:20 | |
*** riuzen has quit IRC | 15:22 | |
*** numans has joined #openstack-lbaas | 15:28 | |
*** rpittau is now known as rpittau|afk | 16:01 | |
*** gregwork has joined #openstack-lbaas | 16:03 | |
*** happyhemant has quit IRC | 16:22 | |
*** maciejjozefczyk has quit IRC | 16:39 | |
*** ccamposr__ has joined #openstack-lbaas | 16:40 | |
*** ccamposr has quit IRC | 16:43 | |
*** gcheresh has quit IRC | 16:44 | |
*** vishalmanchanda has quit IRC | 17:23 | |
*** gcheresh has joined #openstack-lbaas | 17:25 | |
*** gcheresh has quit IRC | 17:43 | |
*** sapd__x has quit IRC | 17:55 | |
*** ataraday_ has quit IRC | 18:26 | |
*** gcheresh has joined #openstack-lbaas | 19:16 | |
*** gcheresh has quit IRC | 19:40 | |
*** servagem has quit IRC | 20:19 | |
*** maciejjozefczyk has joined #openstack-lbaas | 20:36 | |
*** maciejjozefczyk has quit IRC | 20:42 | |
rm_work | hmmmmmmmmm docs build STILL broken and blocking pep8 fix? <_< | 21:47 |
rm_work | ugh so apparently somehow my SG change is catching ports before they have IPs? O_o | 21:48 |
rm_work | https://zuul.opendev.org/t/openstack/build/6cb4292884614a6c9cbcdadf342df308/log/controller/logs/screen-o-cw.txt#5219 | 21:48 |
rm_work | not sure how that's the case... how long do i need to wait for ports to get IPs? shouldn't they have one by the time it is bound? | 21:48 |
johnsom | The docs breakage was a new change in openstackdocstheme, the revert is making its way through requirements now. (per the e-mail) | 21:53 |
johnsom | Are you not checking if SGs are enabled? I think we have some tests that run on non-port security nets | 21:55 |
rm_work | hmmm i thought i was, will double check | 21:56 |
johnsom | Ah, nevermind, I can scroll up and see they are enabled | 21:56 |
rm_work | also yes, confirmed | 21:56 |
johnsom | oh, nevermind again, that is the extension | 21:56 |
rm_work | `if self.sec_grp_enabled and load_balancer:` | 21:56 |
rm_work | i guess i could add some logging and check if the port is actually IP'd | 21:57 |
johnsom | Yeah, I am just looking at your code to understand the timing in it | 21:58 |
rm_work | yeah i was trying to do it in the plug_port | 21:59 |
johnsom | plug_network seems to be where you got the error. | 21:59 |
johnsom | Yeah, So that call to neutron is async, I bet it's just not done yet when your call comes around. | 22:00 |
rm_work | err yeah plug_network | 22:00 |
rm_work | err which call | 22:00 |
johnsom | We just didn't care before as do a bunch of stuff before actually using that port | 22:00 |
rm_work | `attach_network_or_port`? | 22:00 |
johnsom | yeah | 22:01 |
*** TrevorV has quit IRC | 22:01 | |
rm_work | hmm | 22:01 |
johnsom | err, compute call, sorry, not neutron, but probably still neutron async behind the curtain | 22:01 |
johnsom | That would be my guess | 22:02 |
rm_work | yeah | 22:02 |
rm_work | maybe i can move the logic to the post-plug | 22:02 |
rm_work | but, that's an amp task not a network task | 22:03 |
johnsom | That is a amp call though, so maybe not the best place | 22:03 |
rm_work | maybe needs its own task | 22:03 |
johnsom | I might add a status waiter to compute.attach_net_or_port | 22:03 |
johnsom | Or some retries to your sg method | 22:04 |
rm_work | yeah that could work too, i suppose no matter where i put it, it risks not being done yet due to timing or other issues | 22:04 |
rm_work | not sure what object this is exactly | 22:05 |
rm_work | an "interface" is a port? kinda? | 22:05 |
rm_work | does this action actually have a status... | 22:06 |
johnsom | Well, this is "grumble, grumble, Brandon German" grumble. Sometimes it's a network driver object, sometimes it's a DB object | 22:06 |
rm_work | lol | 22:07 |
xgerman | Yeah, we ask nova to call Neutron to.., | 22:08 |
rm_work | in this case that "interface_attach" is even the name of the nova client call tho | 22:08 |
rm_work | but interface isn't actually a real nova object AFAIK | 22:09 |
johnsom | Well, the nova call doesn't return a status, so I would have to look if that compute driver call does a port query or not. | 22:09 |
xgerman | The benefit is that the if the vom dies nova cleans up the mess | 22:09 |
rm_work | `/servers/%s/os-interface` | 22:10 |
rm_work | hmm | 22:10 |
johnsom | Yeah, you would have to make another API call for status it looks like | 22:11 |
johnsom | https://docs.openstack.org/api-ref/compute/?expanded=create-interface-detail#id178 | 22:11 |
rm_work | i still don't understand what this even is | 22:12 |
rm_work | so there should be a client command to get port-interfaces on servers? | 22:12 |
rm_work | there's a GET defined... | 22:12 |
johnsom | https://docs.openstack.org/api-ref/compute/?expanded=create-interface-detail,show-port-interface-details-detail#show-port-interface-details | 22:13 |
johnsom | Yeah, but I don't know if that "port_state" is useful information or just, yeah, there is a port | 22:13 |
johnsom | It might be best to query the port in neutron directly | 22:14 |
rm_work | port doesn't have good status either... | 22:15 |
rm_work | UP/DOWN is not useful | 22:15 |
rm_work | `ip_allocation = deferred` isn't updated after it's complete, always stays like that forever | 22:16 |
rm_work | there's `data_plane_status` but it's just showing as `None` for me on our ports | 22:16 |
johnsom | data_plane_status | 22:16 |
johnsom | Oh | 22:16 |
rm_work | can look at `fixed_ips` i guess and just make sure it has one <_< | 22:16 |
rm_work | but worried if there are any cases where that might stall things badly | 22:16 |
xgerman | Don’t we retry until the next thing works? Why can’t you do that? | 22:17 |
johnsom | Right, that and maybe status which has a "BUILD" state, though I don't know that I have seen it | 22:17 |
rm_work | yeah I will try some retries first | 22:17 |
rm_work | and see what that looks like | 22:17 |
xgerman | Yep, that’s the k8s way | 22:18 |
xgerman | Retries... | 22:18 |
johnsom | Oh, then don't do that... grin | 22:18 |
xgerman | Lol | 22:18 |
johnsom | https://github.com/hjacobs/kubernetes-failure-stories | 22:19 |
johnsom | xgerman I got a laugh out of this: https://raw.githubusercontent.com/intel/multus-cni/master/doc/images/multus-pod-image.svg | 22:20 |
johnsom | Looks awfully familiar somehow | 22:20 |
xgerman | +1 | 22:23 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Share the LB security group with the LB owner https://review.opendev.org/723735 | 22:31 |
rm_work | k we'll see if retries help | 22:31 |
johnsom | Just keep beating on it until it accepts your SG! lol | 22:32 |
rm_work | :D | 22:50 |
*** tkajinam has joined #openstack-lbaas | 22:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!