*** yamamoto has joined #openstack-lbaas | 00:08 | |
*** yamamoto has quit IRC | 00:13 | |
*** sapd1 has quit IRC | 00:33 | |
openstackgerrit | suhaiming proposed openstack/octavia master: Correct a typo in the document https://review.opendev.org/745471 | 01:04 |
---|---|---|
*** lxkong has joined #openstack-lbaas | 01:20 | |
*** spatel has joined #openstack-lbaas | 01:28 | |
*** spatel has quit IRC | 01:28 | |
*** yamamoto has joined #openstack-lbaas | 02:17 | |
*** sapd1 has joined #openstack-lbaas | 02:42 | |
*** sapd1 has quit IRC | 02:47 | |
*** mvorwerk has joined #openstack-lbaas | 02:51 | |
*** sapd1 has joined #openstack-lbaas | 02:55 | |
*** mvorwerk has quit IRC | 02:56 | |
*** psachin has joined #openstack-lbaas | 03:35 | |
*** yamamoto has quit IRC | 04:01 | |
*** yamamoto has joined #openstack-lbaas | 04:06 | |
*** yamamoto has quit IRC | 04:23 | |
*** vishalmanchanda has joined #openstack-lbaas | 04:28 | |
*** ramishra has joined #openstack-lbaas | 04:31 | |
*** gcheresh_ has joined #openstack-lbaas | 05:00 | |
*** yamamoto has joined #openstack-lbaas | 05:02 | |
*** yamamoto has quit IRC | 05:11 | |
*** sapd1 has quit IRC | 05:37 | |
*** yamamoto has joined #openstack-lbaas | 05:42 | |
*** yamamoto has quit IRC | 05:45 | |
*** yamamoto has joined #openstack-lbaas | 05:54 | |
*** yamamoto has quit IRC | 06:00 | |
*** yamamoto has joined #openstack-lbaas | 06:39 | |
*** yamamoto has quit IRC | 06:42 | |
*** yamamoto has joined #openstack-lbaas | 06:42 | |
*** mvorwerk has joined #openstack-lbaas | 06:42 | |
*** gregwork has quit IRC | 06:49 | |
*** maciejjozefczyk has joined #openstack-lbaas | 07:08 | |
*** sapd1 has joined #openstack-lbaas | 07:19 | |
*** yamamoto has quit IRC | 07:27 | |
*** ataraday_ has joined #openstack-lbaas | 07:32 | |
*** maciejjozefczyk has quit IRC | 07:37 | |
*** ccamposr has joined #openstack-lbaas | 07:40 | |
*** maciejjozefczyk has joined #openstack-lbaas | 07:41 | |
*** ccamposr__ has quit IRC | 07:42 | |
*** maciejjozefczyk has quit IRC | 07:52 | |
*** yamamoto has joined #openstack-lbaas | 07:58 | |
*** maciejjozefczyk has joined #openstack-lbaas | 08:02 | |
*** yamamoto has quit IRC | 08:05 | |
openstackgerrit | Merged openstack/octavia master: [Trivial]Add missing space between words https://review.opendev.org/743476 | 08:32 |
*** yamamoto has joined #openstack-lbaas | 08:35 | |
*** maciejjozefczyk has quit IRC | 08:52 | |
*** maciejjozefczyk has joined #openstack-lbaas | 08:52 | |
*** yamamoto has quit IRC | 08:59 | |
*** sapd1 has quit IRC | 09:04 | |
*** born2bake has joined #openstack-lbaas | 09:09 | |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add ALPN support for TLS-terminated HTTPS LBs https://review.opendev.org/744520 | 09:17 |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add HTTP/2 over TLS support to amphora provider https://review.opendev.org/744905 | 09:17 |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add Copr cgoncalves/haproxy repo for CentOS amps https://review.opendev.org/744102 | 09:17 |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add DIB element octavia-lib https://review.opendev.org/745506 | 09:17 |
*** rcernin has quit IRC | 09:24 | |
*** yamamoto has joined #openstack-lbaas | 09:34 | |
*** sapd1 has joined #openstack-lbaas | 09:38 | |
*** yamamoto has quit IRC | 09:41 | |
*** yamamoto has joined #openstack-lbaas | 09:52 | |
*** yamamoto has quit IRC | 09:58 | |
*** yamamoto has joined #openstack-lbaas | 10:05 | |
*** yamamoto has quit IRC | 10:12 | |
*** yamamoto has joined #openstack-lbaas | 10:17 | |
*** vishalmanchanda has quit IRC | 10:18 | |
*** psachin has quit IRC | 10:36 | |
*** maciejjozefczyk has quit IRC | 10:48 | |
*** maciejjozefczyk has joined #openstack-lbaas | 10:51 | |
*** gcheresh_ has quit IRC | 10:54 | |
*** gcheresh_ has joined #openstack-lbaas | 11:01 | |
*** sapd1 has quit IRC | 11:25 | |
*** servagem has joined #openstack-lbaas | 11:54 | |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add DIB element octavia-lib https://review.opendev.org/745506 | 12:21 |
*** wuchunyang has joined #openstack-lbaas | 12:43 | |
*** wuchunyang has quit IRC | 12:45 | |
*** wuchunyang has joined #openstack-lbaas | 12:46 | |
*** wuchunyang has quit IRC | 12:48 | |
*** wuchunyang has joined #openstack-lbaas | 12:48 | |
*** yamamoto has quit IRC | 12:52 | |
*** wuchunyang has quit IRC | 12:53 | |
*** yamamoto has joined #openstack-lbaas | 12:53 | |
*** yamamoto has quit IRC | 12:53 | |
*** yamamoto has joined #openstack-lbaas | 12:54 | |
*** wuchunyang has joined #openstack-lbaas | 12:56 | |
*** wuchunyang has quit IRC | 12:57 | |
*** yamamoto has quit IRC | 12:58 | |
*** yamamoto has joined #openstack-lbaas | 13:00 | |
*** yamamoto has quit IRC | 13:04 | |
*** TrevorV has joined #openstack-lbaas | 13:49 | |
*** sapd1 has joined #openstack-lbaas | 14:01 | |
*** sapd1 has quit IRC | 14:08 | |
*** psachin has joined #openstack-lbaas | 14:10 | |
*** sapd1 has joined #openstack-lbaas | 14:25 | |
*** psachin has quit IRC | 14:30 | |
*** gcheresh_ has quit IRC | 14:51 | |
*** sapd1 has quit IRC | 14:56 | |
*** ataraday_ has quit IRC | 15:07 | |
*** armax has joined #openstack-lbaas | 15:16 | |
*** gcheresh_ has joined #openstack-lbaas | 15:48 | |
*** mvorwerk has quit IRC | 15:49 | |
*** mvorwerk has joined #openstack-lbaas | 15:53 | |
*** yamamoto has joined #openstack-lbaas | 15:58 | |
*** yamamoto has quit IRC | 16:18 | |
*** ramishra has quit IRC | 16:51 | |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add ALPN support for TLS-terminated HTTPS LBs https://review.opendev.org/744520 | 17:13 |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add ALPN support for TLS-terminated HTTPS LBs https://review.opendev.org/744520 | 17:34 |
openstackgerrit | Michael Johnson proposed openstack/octavia-tempest-plugin master: Adjust API tests for NotImplemented skip https://review.opendev.org/744805 | 18:13 |
johnsom | One more suite of tests to fix.... | 18:16 |
*** yamamoto has joined #openstack-lbaas | 18:17 | |
*** yamamoto has quit IRC | 18:29 | |
*** gcheresh_ has quit IRC | 18:32 | |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add DIB element octavia-lib https://review.opendev.org/745506 | 19:46 |
openstackgerrit | Carlos Goncalves proposed openstack/octavia master: Add ALPN support for TLS-terminated HTTPS LBs https://review.opendev.org/744520 | 19:46 |
haleyb | johnsom: i have a question about the 'create pool' API, wondering if you had a minute for a question | 20:22 |
johnsom | I sure do | 20:22 |
johnsom | Anything to take a break from test code... lol | 20:22 |
haleyb | maciej had started a fix for this bug, https://bugs.launchpad.net/neutron/+bug/1888646 | 20:22 |
openstack | Launchpad bug 1888646 in neutron "[OVN Octavia Provider] octavia_tempest_plugin.tests.api.v2.test_pool.PoolAPITest.test_pool_create_with_listener fails" [High,In progress] - Assigned to Brian Haley (brian-haley) | 20:22 |
haleyb | but i see conflicting code between the api and scenario tests, don't know if one is wrong | 20:23 |
haleyb | basically, he surmised a 'create pool' with a listener should yield an operating status of ONLINE | 20:23 |
haleyb | i can't find in the api-ref if that is correct | 20:24 |
johnsom | Well, per the API reference, the only case something is "OFFLINE" is if it is administratively disabled. | 20:25 |
haleyb | these two tests are different, let me paste | 20:26 |
haleyb | octavia_tempest_plugin.tests.scenario.v2.test_pool.PoolScenarioTest.test_TCP_SIP_pool_with_listener_CRUD | 20:26 |
haleyb | octavia_tempest_plugin.tests.api.v2.test_pool.PoolAPITest.test_pool_create_with_listener | 20:26 |
haleyb | the second checks operating status based on a listener being present, the first always checks OFFLINE | 20:26 |
*** yamamoto has joined #openstack-lbaas | 20:28 | |
johnsom | Yeah, so the json returned from the "create" call will have operating status "OFFLINE" and provisioning status "PENDING_CREATE" in it. After it is provisioned a call to "pool show" will return operating status "ONLINE" and provisioning status "ACTIVE". | 20:31 |
johnsom | Yeah, the scenario test there is a bit odd and subject to race I would say. | 20:33 |
haleyb | johnsom: so that operating status isn't dependent on a listener being in the pool? the api checks that | 20:34 |
haleyb | if has_listener and not CONF.load_balancer.test_with_noop: | 20:34 |
haleyb | check for ONLINE | 20:34 |
johnsom | Well if the pool is attached to the LB, it is not operational. Only if it's attached to a listener does it receive traffic. | 20:37 |
*** yamamoto has quit IRC | 20:38 | |
haleyb | so, should https://review.opendev.org/#/c/714004/29/octavia_tempest_plugin/tests/scenario/v2/test_pool.py#L440 be changed? i.e. check depending on listener_protocol? i can only guess that would fail against the amphora driver | 20:41 |
haleyb | that link doesnt work :( | 20:41 |
johnsom | There aren't 440 lines in that file | 20:42 |
johnsom | Well, the non-patch version of that file | 20:42 |
haleyb | i added the #L440 by hand, so was going to fail, was just trying to highlight L440 on the right-hand side | 20:42 |
*** yamamoto has joined #openstack-lbaas | 20:42 | |
haleyb | https://review.opendev.org/#/c/714004/29/octavia_tempest_plugin/tests/scenario/v2/test_pool.py@440 | 20:44 |
*** servagem has quit IRC | 20:48 | |
johnsom | Well, like I mentioned above, it's probably subject to race, but that test has passed that way for probably about three years. | 20:49 |
johnsom | Ah, I guessed wrong, two years. | 20:50 |
johnsom | lol | 20:50 |
*** TrevorV has quit IRC | 20:52 | |
haleyb | so it passes because the initial check shows it OFFLINE, but later could be ONLINE. with the OVN driver we can set the status right away, so we can pass the API or scenario test, but not both, i'll open a bug for the scenario test and try to make both the same | 20:55 |
johnsom | Operating status is observed status, so there is a time window before it switches to ONLINE. Basically we don't want to lie to the user by marking it ONLINE when in reality the pool is still being provisioned. So in OVN case, after all of the OVS instances are programmed would it go ONLINE. | 20:58 |
johnsom | In theory. Now, if you want to set it online right away, that is up to the driver I guess. | 20:59 |
*** maciejjozefczyk has quit IRC | 20:59 | |
haleyb | well, in this case i think maciej's change at https://review.opendev.org/#/c/742644/5/ovn_octavia_provider/helper.py is valid - the OVN DB command succeeded, and since there was a listener id given it should be ONLINE | 21:03 |
haleyb | but his assumption might be based off the test | 21:04 |
johnsom | Yeah, the API test is correct. | 21:05 |
*** ccamposr has quit IRC | 21:05 | |
johnsom | Yeah, that looks fine. Technically you don't need to set it OFFLINE as it would already be in that state. | 21:05 |
haleyb | the one that waits... so i guess it should also check for OFFLINE in an else: | 21:05 |
haleyb | and the scenario test could basically do the same thing, i just don't know about the noop check | 21:06 |
johnsom | Noop will never go online as there is nothing to observe that status. | 21:06 |
haleyb | right, guess i'm saying the check in the scenario test should also have the noop check | 21:08 |
johnsom | There is no point to running scenario tests with the noop drivers. | 21:10 |
haleyb | oh, that test_with_noop isn't going to be set, right :) | 21:11 |
*** rcernin has joined #openstack-lbaas | 21:49 | |
*** rcernin has quit IRC | 21:50 | |
*** rcernin has joined #openstack-lbaas | 21:50 | |
*** born2bake has quit IRC | 21:52 | |
*** ccamposr has joined #openstack-lbaas | 21:52 | |
*** tkajinam has joined #openstack-lbaas | 22:46 | |
johnsom | rm_work: https://storyboard.openstack.org/#!/story/2007998 | 23:07 |
rm_work | Yeah makes sense I think? But ugh. | 23:11 |
johnsom | Yeah, maybe just need a try/except block in the client when it compiles that "data" list? | 23:12 |
*** rcernin has quit IRC | 23:14 | |
*** rcernin has joined #openstack-lbaas | 23:17 | |
johnsom | Maybe you or sorrison can handle that? I'm a bit buried in tempest land at the moment. | 23:18 |
*** mvorwerk_ has joined #openstack-lbaas | 23:20 | |
*** mvorwerk has quit IRC | 23:22 | |
rm_work | Yeah wrapping up metrics soon | 23:31 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!