openstackgerrit | Brian Haley proposed openstack/octavia-tempest-plugin master: Use py3.5 compatible tempest https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/772794 | 01:02 |
---|---|---|
haleyb | rm_work: as far as gates, the tempest ones are borked | 01:03 |
rm_work | ok | 01:03 |
rm_work | and you're working it? | 01:03 |
haleyb | part was due to py2 going away, fixes merged for devstack but it's still failing, ^^ was just a random guess at debugging, but could be a dib issue? | 01:04 |
haleyb | my middle name has been "gate failure" | 01:05 |
johnsom | Do you have a link to a failed job? | 01:05 |
haleyb | https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/771888 is barfing on it's feet | 01:05 |
haleyb | the one-line change i did | 01:05 |
haleyb | all the scenario jobs are failing in all branches :( | 01:06 |
johnsom | Hmm, in that last zuul, one test failed, that was all | 01:06 |
rm_work | hmm k | 01:06 |
haleyb | the train and stein ones couldn't get a running devstack | 01:06 |
johnsom | Ussuri, the pip package DIB is installing is broken | 01:09 |
johnsom | https://zuul.opendev.org/t/openstack/build/e6c40e52ebdb48a297f633ffcea09670/log/controller/logs/dib-build/amphora-x64-haproxy.qcow2_log.txt#4751 | 01:10 |
haleyb | johnsom: so i guess i was on the right track with my last comment, i don't know how to fix that one | 01:10 |
*** sapd__x has joined #openstack-lbaas | 01:12 | |
johnsom | haleyb Looks like you don't have to: https://review.opendev.org/c/openstack/diskimage-builder/+/772254 | 01:14 |
haleyb | Yay! just don't tell me that needs to go through the dib stable branches | 01:15 |
johnsom | DIB is branchless | 01:15 |
johnsom | Which causes it's own problems, but... | 01:15 |
*** priteau has quit IRC | 01:16 | |
haleyb | if only we knew a dib core... | 01:16 |
rm_work | but WHO could help us | 01:17 |
johnsom | Hmmm | 01:18 |
haleyb | i think the WHO is busy with COVID :-p | 01:18 |
* haleyb bugs out | 01:19 | |
* johnsom is barely paying any attention as he is fighting ansible demons | 01:20 | |
rm_work | lol | 01:21 |
*** sapd__x has quit IRC | 02:07 | |
*** armax has quit IRC | 02:09 | |
*** nicolasbock_ has joined #openstack-lbaas | 02:21 | |
*** nicolasbock has quit IRC | 02:21 | |
*** irclogbot_2 has quit IRC | 02:21 | |
*** nicolasbock_ is now known as nicolasbock | 02:21 | |
*** irclogbot_3 has joined #openstack-lbaas | 02:23 | |
*** rcernin has quit IRC | 02:34 | |
*** rcernin has joined #openstack-lbaas | 02:36 | |
openstackgerrit | Brian Haley proposed openstack/octavia-tempest-plugin master: DNM - testing if DIB change fixes gate https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/772822 | 02:50 |
*** armax has joined #openstack-lbaas | 03:00 | |
*** armax has quit IRC | 03:11 | |
*** psachin has joined #openstack-lbaas | 03:37 | |
*** vishalmanchanda has joined #openstack-lbaas | 04:22 | |
*** lemko7 has joined #openstack-lbaas | 04:57 | |
*** lemko has quit IRC | 04:58 | |
*** lemko7 is now known as lemko | 04:58 | |
*** lemko2 has joined #openstack-lbaas | 05:11 | |
*** lemko has quit IRC | 05:12 | |
*** lemko2 is now known as lemko | 05:12 | |
*** rcernin has quit IRC | 06:18 | |
*** rcernin has joined #openstack-lbaas | 06:22 | |
*** gthiemonge has joined #openstack-lbaas | 06:30 | |
*** gthiemonge has quit IRC | 06:31 | |
*** gthiemonge has joined #openstack-lbaas | 06:31 | |
*** gcheresh has joined #openstack-lbaas | 06:48 | |
*** haleyb has quit IRC | 06:53 | |
*** ccamposr__ has joined #openstack-lbaas | 07:04 | |
*** ccamposr has quit IRC | 07:07 | |
openstackgerrit | Merged openstack/octavia-dashboard master: Imported Translations from Zanata https://review.opendev.org/c/openstack/octavia-dashboard/+/766679 | 07:37 |
*** haleyb has joined #openstack-lbaas | 07:37 | |
*** rcernin has quit IRC | 07:42 | |
openstackgerrit | Arkady Shtempler proposed openstack/octavia-tempest-plugin master: Refactoring - add pool of ports to be used in tests Please ignore this patchset!!! https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/755436 | 07:58 |
*** rcernin has joined #openstack-lbaas | 08:15 | |
*** rpittau|afk is now known as rpittau | 08:27 | |
*** haleyb has quit IRC | 08:41 | |
openstackgerrit | Arkady Shtempler proposed openstack/octavia-tempest-plugin master: Refactoring - add pool of ports to be used in tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/755436 | 08:50 |
*** tkajinam has quit IRC | 08:58 | |
rm_work | ugh lower-constraints failed on the pythonclient gate? | 09:02 |
rm_work | https://review.opendev.org/c/openstack/python-octaviaclient/+/762668 | 09:02 |
gthiemonge | rm_work: I'm on it | 09:02 |
rm_work | kk | 09:05 |
rm_work | pylint version removed or something? O_o | 09:05 |
*** yamamoto has quit IRC | 09:06 | |
gthiemonge | the new pip dependency resolver... | 09:07 |
rm_work | ah | 09:08 |
*** yamamoto has joined #openstack-lbaas | 09:13 | |
cgoncalves | FYI, proposed octavia releases for train and victoria | 09:45 |
cgoncalves | train: https://review.opendev.org/c/openstack/releases/+/772842 | 09:45 |
cgoncalves | victoria: https://review.opendev.org/c/openstack/releases/+/772843 | 09:45 |
rm_work | ok, were there any outstanding patches we actually needed to get in? | 09:45 |
rm_work | also, are we close to saying that's the last release for Train? I should probably figure out the EOL stuff again for Stein at least | 09:46 |
rm_work | cgoncalves: what version do you support in RH's distribution again? | 09:46 |
cgoncalves | rm_work, Train | 09:46 |
rm_work | k | 09:46 |
rm_work | so Stein can EOL? | 09:46 |
cgoncalves | fine for us | 09:47 |
rm_work | k, hopefully already EOL'd up to that... but I have a feeling maybe Rocky isn't | 09:47 |
cgoncalves | Train is part of an LTS release though | 09:47 |
rm_work | yeah that's fine | 09:47 |
cgoncalves | our release team pulls from branch so as long as we can merge patches is fine (even if not released) | 09:48 |
rm_work | k | 09:49 |
rm_work | well, EOL would archive the branch possibly... | 09:49 |
rm_work | but that's for another day to worry about, because as I said, just want to EOL up to stein :D | 09:49 |
rm_work | ah nice, rocky is EOL | 09:58 |
rm_work | do we have anything you think we NEED to merge in stein before an EOL? | 10:01 |
cgoncalves | rm_work, nothing comes to mind. there's only one stein patch open, very likely not going to merge ever: https://review.opendev.org/c/openstack/octavia/+/766198 | 10:12 |
rm_work | kk | 10:12 |
rm_work | yeah I am trying to put up the EOL patch but gerrit giving me problems (because of my system, not upstream) | 10:13 |
rm_work | my ssh agent doesn't get along with gerrit | 10:13 |
rm_work | it tries too many incorrect identity files before it gets to the right one, so gerrit rejects my connections T_T | 10:13 |
cgoncalves | having an identity crisis, uhm?! :) | 10:15 |
rm_work | aha, got it | 10:16 |
rm_work | set `IdentitiesOnly yes` in my ssh config for gerrit hosts | 10:16 |
rm_work | https://review.opendev.org/c/openstack/releases/+/772847 | 10:16 |
rm_work | I wonder if they will complain about an ML announcement <_< | 10:17 |
*** rcernin has quit IRC | 10:24 | |
*** osmanlicilegi has quit IRC | 10:27 | |
*** osmanlicilegi has joined #openstack-lbaas | 10:29 | |
openstackgerrit | Gregory Thiemonge proposed openstack/python-octaviaclient master: Fix lower-constraints job https://review.opendev.org/c/openstack/python-octaviaclient/+/772848 | 10:37 |
rm_work | ah lower-constraints also broken in octavia master? | 10:39 |
rm_work | I guess I should stop trying to merge stuff <_< | 10:40 |
gthiemonge | octavia master? | 10:40 |
rm_work | was trying to merge a bunch of changes in octavia | 10:40 |
rm_work | https://zuul.opendev.org/t/openstack/build/6594026ce9f24d31a39c7f991a234416 | 10:41 |
rm_work | xarlos: oh nm | 10:41 |
rm_work | errrrr | 10:41 |
rm_work | sorry bad ping | 10:41 |
rm_work | but, maybe it's just this patch | 10:41 |
rm_work | well, ussuri gates do appear to be broken tho | 10:42 |
rm_work | but I think we knew that | 10:42 |
xarlos | o/ :) | 10:42 |
gthiemonge | grenade? | 10:43 |
rm_work | ahhh i see, Carlos posted why, it has another depends-on | 10:43 |
rm_work | gthiemonge: looks like Carlos had something he wants on https://review.opendev.org/c/openstack/octavia/+/698086 and then it'll be good to go too | 10:44 |
gthiemonge | oh ok | 10:45 |
gthiemonge | I missed that one | 10:45 |
rm_work | oh lol, looks like that tags bug was already fixed by someone else: https://review.opendev.org/c/openstack/octavia/+/755828 | 10:48 |
gthiemonge | :-( | 10:49 |
rm_work | gthiemonge: Michael also seems to have had a question here: https://review.opendev.org/c/openstack/octavia/+/733898 | 10:49 |
gthiemonge | I reviewed it :D | 10:49 |
cgoncalves | gthiemonge, oh Greg... :D | 10:49 |
rm_work | lolol | 10:50 |
*** rcernin has joined #openstack-lbaas | 10:50 | |
gthiemonge | back in november, my brain doesn't work that far | 10:52 |
rm_work | lol | 10:52 |
rm_work | yeah sorry that's like... probably around the last time I actually did a review, too | 10:52 |
rm_work | I have been otherwise occupied | 10:53 |
rm_work | trying to get back into things | 10:53 |
rm_work | ugh this one is hurting me https://review.opendev.org/c/openstack/octavia/+/768316 | 10:54 |
rm_work | it's probably fine to do this? but so much SQL magic to unpack | 10:55 |
*** osmanlicilegi has quit IRC | 11:01 | |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Fix pools going into ERROR when updating the pool https://review.opendev.org/c/openstack/octavia/+/760461 | 11:03 |
*** osmanlicilegi has joined #openstack-lbaas | 11:05 | |
rm_work | ^^ rebase | 11:06 |
*** rcernin has quit IRC | 11:08 | |
openstackgerrit | Gregory Thiemonge proposed openstack/octavia master: Add haproxy-source backend element in DIB https://review.opendev.org/c/openstack/octavia/+/698086 | 11:16 |
gthiemonge | oops I haven't seen your last comments | 11:16 |
*** osmanlicilegi has quit IRC | 11:58 | |
*** osmanlicilegi has joined #openstack-lbaas | 12:01 | |
rm_work | The thing about ping check is a nit | 12:11 |
rm_work | And I could be misremembering | 12:11 |
rm_work | Bleh yeah gates on master not working either I guess | 12:14 |
rm_work | Will need to look tomorrow | 12:14 |
rm_work | Or... In the morning/afternoon of today I guess :D | 12:14 |
gthiemonge | rm_work: we need to merge https://review.opendev.org/c/openstack/octavia/+/752095 to fix the gates | 12:26 |
*** yamamoto has quit IRC | 12:29 | |
*** yamamoto has joined #openstack-lbaas | 12:33 | |
*** priteau has joined #openstack-lbaas | 12:43 | |
*** ccamposr has joined #openstack-lbaas | 12:43 | |
*** ccamposr__ has quit IRC | 12:45 | |
*** osmanlicilegi has quit IRC | 12:50 | |
*** osmanlicilegi has joined #openstack-lbaas | 12:55 | |
*** yamamoto has quit IRC | 12:57 | |
*** sapd__x has joined #openstack-lbaas | 13:01 | |
openstackgerrit | Carlos Gonçalves proposed openstack/octavia master: Add ALPN support for TLS-enabled pools https://review.opendev.org/c/openstack/octavia/+/752095 | 13:43 |
*** parallax_ has joined #openstack-lbaas | 13:45 | |
*** parallax has quit IRC | 13:45 | |
*** parallax_ is now known as parallax | 13:45 | |
*** sapd__x has quit IRC | 13:46 | |
*** sapd__x has joined #openstack-lbaas | 13:46 | |
*** vishalmanchanda has quit IRC | 13:51 | |
*** ccamposr__ has joined #openstack-lbaas | 13:55 | |
*** ccamposr has quit IRC | 13:57 | |
openstackgerrit | Ksawery Dziekoński proposed openstack/octavia master: Fix PK inspection and abstract raw SQL away to fix migrations on PostgreSQL https://review.opendev.org/c/openstack/octavia/+/768316 | 14:33 |
*** rcernin has joined #openstack-lbaas | 14:46 | |
*** haleyb has joined #openstack-lbaas | 14:57 | |
*** rcernin has quit IRC | 15:00 | |
*** yamamoto has joined #openstack-lbaas | 15:02 | |
*** yamamoto has quit IRC | 15:07 | |
*** armax has joined #openstack-lbaas | 15:18 | |
openstackgerrit | Brian Haley proposed openstack/octavia master: Bump oslo.log version to 4.3.0 https://review.opendev.org/c/openstack/octavia/+/763477 | 15:29 |
*** psachin has quit IRC | 16:00 | |
*** dosaboy has quit IRC | 16:41 | |
*** dosaboy has joined #openstack-lbaas | 16:41 | |
openstackgerrit | Brian Haley proposed openstack/octavia master: Bump oslo.log version to 4.3.0 https://review.opendev.org/c/openstack/octavia/+/763477 | 16:44 |
openstackgerrit | Brian Haley proposed openstack/octavia master: Bump oslo.policy version to 2.1.0 https://review.opendev.org/c/openstack/octavia/+/763926 | 16:46 |
haleyb | cgoncalves: i think we need https://review.opendev.org/c/openstack/diskimage-builder/+/772254 to fix our tempest gates, it seems to have stalled though | 16:57 |
*** yamamoto has joined #openstack-lbaas | 17:07 | |
*** gcheresh has quit IRC | 17:17 | |
*** yamamoto has quit IRC | 17:23 | |
rm_work | gthiemonge: wait how does that fix the gates O_o | 17:55 |
*** rpittau is now known as rpittau|afk | 17:57 | |
rm_work | Well, I'm not sure how this fixes the gates still, but it seems to have passed? And i reviewed it and it seems good, so may as well give it a shot, lol | 18:11 |
rm_work | Otherwise seems totally unrelated to the gate breakage | 18:11 |
*** sshnaidm|ruck has joined #openstack-lbaas | 18:45 | |
sshnaidm|ruck | hi, all, I have a question about octavia on devstack. I'm trying to setup a job in ansible openstack collections repo devstack based with octavia to check loadbalancer modules. I download amphora image, pass its location to devstack. Should I also upload it to cloud and tag or it should be done by devstack? https://review.opendev.org/c/openstack/ansible-collections-openstack/+/772613 | 18:45 |
sshnaidm|ruck | hope now it's a right channel) | 18:45 |
johnsom | Yep, right place now | 18:46 |
johnsom | The devstack plugin will build an image: https://github.com/openstack/octavia/blob/master/devstack/plugin.sh#L66 | 18:48 |
johnsom | Once that image is built, it will upload it to glance | 18:48 |
johnsom | https://github.com/openstack/octavia/blob/master/devstack/plugin.sh#L136 | 18:48 |
sshnaidm|ruck | johnsom, will it also tag? | 18:50 |
johnsom | Yes | 18:50 |
sshnaidm|ruck | and if I provide OCTAVIA_AMP_IMAGE_FILE and download it before, then it should pick it up | 18:52 |
sshnaidm|ruck | as I see from code.. | 18:52 |
johnsom | Yeah, if it's already in glance | 18:53 |
sshnaidm|ruck | johnsom, oh, so if I download image it's on me to upload it to glance? | 19:01 |
johnsom | Yeah, if you don't want devstack to build it for you, yes. | 19:01 |
johnsom | https://github.com/openstack/octavia/blob/master/devstack/plugin.sh#L733 | 19:02 |
sshnaidm|ruck | clear now, thanks johnsom | 19:08 |
johnsom | NP | 19:08 |
haleyb | rm_work: that fixes a bug in the functional 'tips' job on master | 19:08 |
rm_work | hmm | 19:14 |
*** yamamoto has joined #openstack-lbaas | 19:21 | |
haleyb | rm_work: i guess in more than that job now, for example, https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_409/763477/3/check/openstack-tox-functional-py36/4093cd5/testr_results.html shows three failures due to alpn_protocols being present | 19:34 |
*** ccamposr has joined #openstack-lbaas | 19:36 | |
rm_work | ugh ok i am really hating the new gerrit theme | 19:37 |
rm_work | is there any way to go back? | 19:37 |
rm_work | or is there anything that fixes it to actually show useful information? | 19:37 |
rm_work | woo, Stein EOL'd BTW :) | 19:38 |
*** ccamposr__ has quit IRC | 19:38 | |
rm_work | riding the Train to the future :P | 19:39 |
johnsom | Yeah, I'm not loving the new gerrit | 19:40 |
johnsom | Wait until you need to change the ACL on a gerrit group. | 19:40 |
rm_work | it's like they took all the most useful information that I always look at first on a patchset and just *removed it*, then took the rest and removed any trace of spacing and distinct formatting so it all flows together into a giant pile of trash | 19:49 |
rm_work | sorry, i haven't really looked at reviews in 3 months-ish, so i'm a bit late to the party here | 19:49 |
johnsom | Yeah, you have to hunt for it. Same for the job logs, etc. added a few layers of clicks to get to the goods | 19:50 |
rm_work | where is the zuul job status?? | 19:50 |
johnsom | comments | 19:50 |
*** yamamoto has quit IRC | 19:50 | |
rm_work | wtf | 19:50 |
rm_work | this is garbage | 19:50 |
rm_work | i wonder if there's any way to hack it back with greasemonkey... | 19:51 |
johnsom | lol, well there goes a week of your time | 19:51 |
*** jamesden_ is now known as jamesdenton | 19:53 | |
*** itsjg has joined #openstack-lbaas | 19:58 | |
*** rcernin has joined #openstack-lbaas | 20:03 | |
openstackgerrit | Merged openstack/octavia master: Add ALPN support for TLS-enabled pools https://review.opendev.org/c/openstack/octavia/+/752095 | 20:12 |
openstackgerrit | Brian Haley proposed openstack/octavia master: Bump oslo.log version to 4.3.0 https://review.opendev.org/c/openstack/octavia/+/763477 | 20:12 |
rm_work | ok, gonna start some rechecks, should pass now with that change merged? | 20:19 |
*** rcernin has quit IRC | 20:30 | |
*** rcernin has joined #openstack-lbaas | 20:41 | |
rm_work | haleyb: were you working on the stable branch gates too? | 20:51 |
*** zzzeek has quit IRC | 20:57 | |
*** zzzeek has joined #openstack-lbaas | 20:57 | |
*** spatel has joined #openstack-lbaas | 21:05 | |
spatel | johnsom: hey | 21:05 |
johnsom | spatel Hi | 21:05 |
spatel | quick question, on my controller node i am seeing 100 proc running of octavia-health-manager | 21:06 |
spatel | do we need that many? | 21:06 |
johnsom | No | 21:06 |
spatel | what is the best practice for small deployment? | 21:06 |
johnsom | Take a look at the [health_manager] section in the config. I think some of the thread counts default to core count. | 21:07 |
johnsom | rm_work might have some advice on a good number for the threads. | 21:08 |
spatel | i am planning to start with 8 proc and later i can add | 21:09 |
spatel | mostly health_manager is just for pining amphora right? | 21:09 |
spatel | or it does some heavy duty work? | 21:10 |
johnsom | Yeah, amps send a message every 10 seconds by default, each usually take .001 seconds to process | 21:10 |
spatel | my [health_manager] section doesn't have anything related thread so i believe its default | 21:10 |
rm_work | yeah there's some math involved based on size of amphora fleet, number of HM hosts, etc | 21:10 |
johnsom | They also rotate across the health managers you have running | 21:10 |
spatel | let me reduce count then | 21:10 |
spatel | thanks for input let me start with small number at beginning | 21:11 |
johnsom | Watch the log file, it will start whining at you if you set it too low. "THIS IS NOT GOOD", etc. | 21:13 |
spatel | 8 or 16 should be good for start | 21:14 |
spatel | johnsom: am i missing something what is the setting to control it - https://docs.openstack.org/octavia/latest/configuration/configref.html#health-manager | 21:17 |
rm_work | health_update_threads / stats_update_threads | 21:17 |
johnsom | failover_threads, health_update_threads, and stats_update_threads | 21:17 |
johnsom | I would not touch failover | 21:18 |
rm_work | yep | 21:18 |
rm_work | failover also has a low default (10) | 21:18 |
spatel | Thank you! | 21:18 |
spatel | why default is None, there should be limit for Default otherwise someone can exploit it :) | 21:19 |
johnsom | It defaults to a value based on the CPU cores on the host | 21:20 |
rm_work | these threads shouldn't cause a huge problem as most will be asleep, and yes, will be capped to some reasonable(ish) scaling value | 21:20 |
johnsom | Yeah, they don't take up much space other than in your process listing | 21:21 |
spatel | I am seeing 100 proc running and i have only 48 core cpu. | 21:22 |
rm_work | hyperthreaded? | 21:22 |
rm_work | 48 physical cores or logical cores? | 21:22 |
johnsom | That seems right. ~48 for health_update_threads and ~48 for stats_update_threads | 21:23 |
rm_work | ah right, yes | 21:23 |
rm_work | 48 each :D | 21:23 |
rm_work | plus master processes | 21:23 |
johnsom | right | 21:23 |
spatel | oh wait. i set it 16 and restart service and now its showing me 68 proc so look like not cpu core to core | 21:24 |
spatel | I have 48 logical core :) | 21:25 |
spatel | look like 4 proc per 1 thread | 21:25 |
spatel | if i set 16 thread then proc count will be 68 | 21:26 |
spatel | that is why i am seeing 100 | 21:26 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Add default value for enabled column in l7rule table https://review.opendev.org/c/openstack/octavia/+/761283 | 21:31 |
spatel | stats_update_threads = 4 / health_update_threads = 8 with that setting now i have 16 Proc running | 21:32 |
*** rcernin has quit IRC | 21:34 | |
*** itsjg has left #openstack-lbaas | 21:40 | |
*** yamamoto has joined #openstack-lbaas | 21:49 | |
*** rcernin has joined #openstack-lbaas | 21:51 | |
rm_work | hmm | 21:54 |
openstackgerrit | Brian Haley proposed openstack/octavia master: Bump oslo.policy version to 2.1.0 https://review.opendev.org/c/openstack/octavia/+/763926 | 21:54 |
spatel | rm_work: not sure what is the relation between stats_update_threads and health_update_threads | 22:13 |
rm_work | they are similar but separate queues | 22:13 |
rm_work | typically they probably will need to be similarly sized I think | 22:14 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Install HAProxy 2.x in CentOS amphora images https://review.opendev.org/c/openstack/octavia/+/744102 | 22:14 |
rm_work | ^^ rebased to kickstart tests again, spurious grenade failure AFAICT | 22:15 |
rm_work | nova failed to boot a VM | 22:15 |
rm_work | haleyb: `ebtables v1.8.4 (nf_tables): table `broute' is incompatible, use 'nft' tool.`? | 22:22 |
rm_work | hmm wait, maybe not the real error | 22:23 |
rm_work | I hate the way DIB has so many red herrings | 22:23 |
haleyb | rm_work: from stack.sh, funny i just saw the same thing | 22:24 |
johnsom | Tons of things are spewing that, it's not a real error. | 22:24 |
rm_work | k yeah | 22:24 |
rm_work | https://e4b577912a327c30f3e6-23ff2657fe87c0d4ee3109cc6b8bff44.ssl.cf5.rackcdn.com/768502/1/check/octavia-v2-dsvm-scenario-centos-8/d878d95/controller/logs/dib-build/amphora-x64-haproxy.qcow2_log.txt | 22:24 |
johnsom | Well, it probably is, but it doesn't stop things | 22:24 |
rm_work | `AttributeError: module 'pkg_resources' has no attribute 'get_distribution'` | 22:24 |
rm_work | pip / setuptools issues? | 22:24 |
haleyb | think it's a side-effect of something else. it's like when the end of the log says the neutron agents didn't start, it's never them :) | 22:25 |
rm_work | (trying to track down why all cent8 gates are failing) | 22:25 |
haleyb | oh, think i remember pinning something for that pkg one | 22:25 |
haleyb | or yeah, it's pip under the covers | 22:25 |
rm_work | looking at https://zuul.opendev.org/t/openstack/status#octavia and every change has cent8 and scenario-amphora-v2 failing | 22:25 |
johnsom | AttributeError: module 'pkg_resources' has no attribute 'get_distribution' <----- That is a real, blocking, error | 22:26 |
rm_work | yeah | 22:26 |
rm_work | the other one has this: | 22:27 |
rm_work | 2021-01-28 21:26:59.048957 | controller | [00;36mINFO alembic.runtime.migration [[00;36m-[00;36m] [01;35m[00;36mRunning upgrade -> 1cea328f0f65, initial_logbook_details_tables[00m[00m | 22:27 |
rm_work | 2021-01-28 21:26:59.326529 | controller | [01;31mCRITICAL octavia-db-manage [[00;36m-[01;31m] [01;35m[01;31mUnhandled error[00m: TypeError: create_foreign_key() missing 3 required positional arguments: 'constraint_name', 'source_table', and 'referent_table' | 22:27 |
johnsom | Hmm, someone broke a migration? | 22:27 |
rm_work | well, looks like that is a dynamic FK handler | 22:28 |
*** yamamoto has quit IRC | 22:28 | |
haleyb | https://review.opendev.org/c/openstack/octavia/+/752095 just merged with a migration, but the ids look ok | 22:31 |
*** spatel has quit IRC | 22:33 | |
rm_work | ahhhh that migration isn't even ours | 22:34 |
rm_work | that's a base alembic migration | 22:34 |
rm_work | .tox/functional/lib/python3.7/site-packages/taskflow/persistence/backends/sqlalchemy/alembic/versions/1cea328f0f65_initial_logbook_deta.py | 22:35 |
johnsom | Well, maybe it is. Ann added something like that to Octavia | 22:35 |
rm_work | look for `octavia-db-manage upgrade_persistence` in https://f9f07e2c910f387369c3-fe6c968e98fdbd85f0f135fdbc9bd3ed.ssl.cf5.rackcdn.com/763477/4/check/octavia-v2-dsvm-scenario-amphora-v2/66b4c1c/job-output.txt | 22:36 |
rm_work | yeah, that line in our plugin was added by Ann... in 2019? | 22:37 |
rm_work | so I feel like this must be the result of something else changing outside of the original change? possibly bad assumptions were made? | 22:38 |
johnsom | I don't think the migrations have changed in taskflow in a long while. | 22:38 |
johnsom | Yeah, no changes on the taskflow side | 22:40 |
rm_work | so how could https://review.opendev.org/c/openstack/octavia/+/752095/7/octavia/db/migration/alembic_migrations/versions/be9fdc039b51_add_pool_alpn_protocols_column.py have caused an issue? | 22:41 |
rm_work | does seem that this test was successful on previous merges | 22:42 |
rm_work | adds a column to the pool table... | 22:42 |
haleyb | i don't know if it did, just that it was the last commit | 22:42 |
rm_work | yeah, prior to that commit merging, it seems this test was passing | 22:42 |
*** yamamoto has joined #openstack-lbaas | 22:43 | |
rm_work | is this even supposed to be running? | 22:43 |
rm_work | why does `octavia-db-manage upgrade_persistence` start trying to do alembic internal migrations? | 22:44 |
rm_work | I think that is the issue | 22:44 |
johnsom | Link to the job logs? | 22:44 |
rm_work | look for `octavia-db-manage upgrade_persistence` in https://f9f07e2c910f387369c3-fe6c968e98fdbd85f0f135fdbc9bd3ed.ssl.cf5.rackcdn.com/763477/4/check/octavia-v2-dsvm-scenario-amphora-v2/66b4c1c/job-output.txt | 22:45 |
rm_work | the first thing the command tries to do is run an alembic internal migration | 22:45 |
rm_work | if you look just above at the other db-manage we run, it doesn't run those at all, so it's not like they're a bookend thing like I assumed | 22:46 |
johnsom | So, alembic changed under us | 22:51 |
johnsom | 1.5.0 changed create_foreign_key() | 22:52 |
rm_work | <_< | 22:52 |
rm_work | yeah the data they pass doesn't look AT ALL like what it's expecting | 22:52 |
johnsom | https://alembic.sqlalchemy.org/en/latest/changelog.html#change-da0bea3199b905783ddbd0cde968beec | 22:52 |
johnsom | https://github.com/openstack/taskflow/blob/master/taskflow/persistence/backends/sqlalchemy/alembic/versions/1cea328f0f65_initial_logbook_deta.py#L133 | 22:53 |
rm_work | AHHH taskflow | 22:53 |
rm_work | right | 22:54 |
johnsom | Yeah, Ann is running the migration from taskflow | 22:54 |
rm_work | sorry i missed that in the path i posted earlier lol | 22:54 |
johnsom | So, if you fix: https://github.com/openstack/taskflow/blob/master/taskflow/persistence/backends/sqlalchemy/alembic/versions/1cea328f0f65_initial_logbook_deta.py#L62 | 22:54 |
rm_work | yep | 22:54 |
johnsom | Ping me with a patch and I can review it. | 22:54 |
johnsom | I wonder if we need to pin alembic on stable... hmmm | 22:54 |
rm_work | hmmmmmmm k | 22:54 |
rm_work | ok, working on it | 22:56 |
johnsom | requirements bumped it 8 days ago | 22:57 |
johnsom | Ok, the one that broke it was probably 10 days ago, that was the bump to 1.5.0 | 22:59 |
*** AlexStaf has quit IRC | 22:59 | |
rm_work | https://review.opendev.org/c/openstack/taskflow/+/772953 | 23:00 |
rm_work | will this require a taskflow release and version bump on our side? <_< | 23:00 |
rm_work | would we be better off pinning for now? | 23:00 |
rm_work | ah nm, we can't | 23:00 |
rm_work | but also, not blocking gates, so it's not as big of a rush | 23:01 |
johnsom | Yeah, but I can help with that.... | 23:01 |
rm_work | heh | 23:01 |
openstackgerrit | Brian Haley proposed openstack/octavia master: Bump oslo.policy version to 2.1.0 https://review.opendev.org/c/openstack/octavia/+/763926 | 23:08 |
openstackgerrit | Brian Haley proposed openstack/octavia master: Add common system and project policy check strings to constants https://review.opendev.org/c/openstack/octavia/+/763478 | 23:09 |
*** emccormick has quit IRC | 23:37 | |
*** emccormick has joined #openstack-lbaas | 23:38 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!