rm_work | johnsom: did that patch look ok? | 00:42 |
---|---|---|
rm_work | meanwhile, like ... 60% through rebasing this AZ patch :D | 00:42 |
johnsom | Oh, let me look. Today kind of became a Designate day for me. | 00:45 |
johnsom | Hmm, the gate didn't like you... | 00:47 |
johnsom | Ah, the cache/mirror didn't like you | 00:48 |
johnsom | rm_work Any chance I can bug you for a release note? | 00:48 |
johnsom | Sure makes backporting easier.... | 00:49 |
rm_work | yeah I rechecked | 00:49 |
rm_work | uhh... yeah... *sigh* | 00:49 |
rm_work | i can't do it now | 00:49 |
rm_work | If I do anything to jeopardize my work on this rebase in progress, I will flip a table | 00:49 |
johnsom | Ok, well, zuul still doesn't like you, this time with the lower-constraints job. Maybe I can poke it | 00:50 |
johnsom | Ah, a random unix domain socket issue. (I should look into that sometime) | 00:51 |
rm_work | T_T | 00:52 |
rm_work | if you wanted to pop the note on there that's fine | 00:53 |
rm_work | otherwise... at this rate, guessing later this week XD | 00:53 |
rm_work | my brain is starting to grind to a halt, been staring at this rebase for 5 hours today and 6 hours yesterday | 00:53 |
rm_work | like, it shouldn't be that hard, but ... I managed to name a lot of the data structures the same, but they have different internal structures <_< | 00:54 |
johnsom | Yeah, I'm going to push a rel note. That will force a recheck anyway | 00:54 |
rm_work | so figuring out which one I have at any given point is making me go mad | 00:54 |
johnsom | lol, opps. I have been there and feel your pain | 00:54 |
rm_work | (between the Multi-AZ patch, which passes "availability zone" as a string, and the AZ patch that merged which is the DB data-structure) | 00:55 |
johnsom | Oh now what??? | 00:56 |
johnsom | https://www.irccloud.com/pastebin/bV9ZBfA0/ | 00:56 |
rm_work | wat | 00:56 |
johnsom | I wonder if that ssh issue fedora has had leached into this other vm | 00:56 |
rm_work | change is closed? | 00:56 |
rm_work | is the error? | 00:57 |
rm_work | wat | 00:57 |
johnsom | Oh, opps, no, my fault | 00:57 |
rm_work | yeah | 00:57 |
rm_work | that merged | 00:57 |
rm_work | :D | 00:57 |
openstackgerrit | Michael Johnson proposed openstack/octavia master: Fix empty Batch Member Update to unlock objects https://review.opendev.org/c/openstack/octavia/+/782342 | 00:59 |
johnsom | There we go | 01:00 |
johnsom | Ok, off to make dinner. I had too much ?fun? today messing with designate pool configs and parent/child zones. Two virtual desktops worth of ?fun?... | 01:00 |
johnsom | I proved out my theory, so at least I made progress. | 01:02 |
rm_work | johnsom: if you have a sec at some point ... doesn't this seem wrong to you? https://github.com/openstack/octavia/blob/57e7bd17bfa37c4972ae07adcc4e1b9a5535bbcd/octavia/controller/worker/v1/tasks/compute_tasks.py#L83-L90 | 01:11 |
rm_work | specifically line 90 | 01:11 |
rm_work | shouldn't it be: `amp_availability_zone = CONF.nova.availability_zone`? | 01:12 |
rm_work | we're assuming no "Octavia AZ" on a LB means that we pass no AZ to nova -- but nova's default AZ might not be the Octavia default nova-az, meaning we're building them in the wrong place in this case? | 01:12 |
rm_work | need logic check | 01:13 |
rm_work | sorrison: ^^ you might remember / understand this? lol | 01:13 |
*** rcernin has quit IRC | 01:34 | |
*** rcernin has joined #openstack-lbaas | 01:45 | |
*** rcernin has quit IRC | 01:46 | |
*** rcernin has joined #openstack-lbaas | 01:46 | |
*** sapd1 has joined #openstack-lbaas | 02:36 | |
*** tamas_erdei has joined #openstack-lbaas | 02:37 | |
*** terdei has quit IRC | 02:39 | |
*** tamas_erdei has quit IRC | 02:42 | |
*** rcernin has quit IRC | 02:45 | |
*** terdei has joined #openstack-lbaas | 02:48 | |
*** sapd1 has quit IRC | 02:56 | |
*** rcernin has joined #openstack-lbaas | 02:57 | |
*** rcernin has quit IRC | 02:57 | |
*** rcernin has joined #openstack-lbaas | 02:58 | |
*** xgerman has quit IRC | 03:26 | |
*** rcernin has quit IRC | 03:31 | |
*** rcernin has joined #openstack-lbaas | 03:38 | |
*** rcernin has quit IRC | 03:52 | |
*** rcernin has joined #openstack-lbaas | 03:52 | |
*** rcernin has quit IRC | 03:53 | |
*** rcernin has joined #openstack-lbaas | 03:54 | |
*** jamesdenton has quit IRC | 04:30 | |
*** jamesden_ has joined #openstack-lbaas | 04:31 | |
*** armax has joined #openstack-lbaas | 04:31 | |
*** armax has quit IRC | 04:33 | |
*** vishalmanchanda has joined #openstack-lbaas | 04:41 | |
*** jamesden_ has quit IRC | 04:55 | |
*** jamesdenton has joined #openstack-lbaas | 04:55 | |
*** jamesdenton has quit IRC | 05:32 | |
rm_work | FFFFFFFF | 05:33 |
openstackgerrit | Adam Harwell proposed openstack/octavia master: Experimental multi-az support https://review.opendev.org/c/openstack/octavia/+/558962 | 05:33 |
rm_work | still a bug somewhere around spares pools, i see two unit tests failing there for some reason, even though I tried to rip out all of the spares pool support (rather than trying to fix it again) | 05:34 |
rm_work | will look ... not now, my brain hurts | 05:34 |
*** jamesdenton has joined #openstack-lbaas | 05:40 | |
*** jamesdenton has quit IRC | 05:52 | |
*** psachin has joined #openstack-lbaas | 05:53 | |
*** jamesdenton has joined #openstack-lbaas | 05:53 | |
*** psachin has quit IRC | 06:01 | |
*** psachin has joined #openstack-lbaas | 06:51 | |
*** cgoncalves has quit IRC | 07:18 | |
*** cgoncalves has joined #openstack-lbaas | 07:20 | |
*** cgoncalves has quit IRC | 07:20 | |
*** cgoncalves has joined #openstack-lbaas | 07:21 | |
*** parallax has quit IRC | 07:29 | |
*** luksky has joined #openstack-lbaas | 07:55 | |
*** rcernin has quit IRC | 08:09 | |
*** rpittau|afk is now known as rpittau | 08:19 | |
*** rcernin has joined #openstack-lbaas | 08:52 | |
*** rcernin has quit IRC | 08:57 | |
*** vishalmanchanda has quit IRC | 09:01 | |
*** rcernin has joined #openstack-lbaas | 09:08 | |
*** rcernin has quit IRC | 09:32 | |
*** sapd1 has joined #openstack-lbaas | 09:40 | |
openstackgerrit | Ann Taraday proposed openstack/octavia master: Alias change amphorav2 -> amphora https://review.opendev.org/c/openstack/octavia/+/740432 | 09:40 |
*** vishalmanchanda has joined #openstack-lbaas | 09:42 | |
*** parallax has joined #openstack-lbaas | 09:54 | |
*** rcernin has joined #openstack-lbaas | 09:57 | |
*** strigazi has joined #openstack-lbaas | 09:58 | |
openstackgerrit | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add new scenario test to create LB in specific AZ https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/695349 | 09:58 |
*** rcernin has quit IRC | 10:02 | |
*** rcernin has joined #openstack-lbaas | 10:12 | |
*** rcernin has quit IRC | 10:22 | |
openstackgerrit | Merged openstack/python-octaviaclient stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/python-octaviaclient/+/781276 | 10:43 |
openstackgerrit | Merged openstack/octavia-lib stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/octavia-lib/+/781252 | 10:46 |
openstackgerrit | Merged openstack/python-octaviaclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/python-octaviaclient/+/781277 | 10:46 |
openstackgerrit | Merged openstack/octavia-lib stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/octavia-lib/+/781256 | 10:47 |
*** rcernin has joined #openstack-lbaas | 11:01 | |
*** rcernin has quit IRC | 11:01 | |
*** rcernin has joined #openstack-lbaas | 11:04 | |
*** sapd1 has quit IRC | 11:37 | |
*** gcheresh_ has quit IRC | 11:38 | |
*** gcheresh has joined #openstack-lbaas | 11:39 | |
*** rcernin has quit IRC | 11:58 | |
*** rcernin has joined #openstack-lbaas | 12:06 | |
*** rcernin has quit IRC | 12:22 | |
*** psachin has quit IRC | 12:50 | |
*** jamesdenton has quit IRC | 13:13 | |
*** jamesdenton has joined #openstack-lbaas | 13:13 | |
*** devfaz has quit IRC | 13:21 | |
*** devfaz has joined #openstack-lbaas | 13:24 | |
*** sapd1 has joined #openstack-lbaas | 14:00 | |
*** armax has joined #openstack-lbaas | 14:09 | |
*** __ministry1 has joined #openstack-lbaas | 15:21 | |
*** stand has joined #openstack-lbaas | 15:29 | |
*** xgerman has joined #openstack-lbaas | 15:47 | |
johnsom | #startmeeting Octavia | 16:00 |
openstack | Meeting started Wed Mar 24 16:00:56 2021 UTC and is due to finish in 60 minutes. The chair is johnsom. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
*** openstack changes topic to " (Meeting topic: Octavia)" | 16:00 | |
openstack | The meeting name has been set to 'octavia' | 16:01 |
johnsom | Hi everyone, and happy RC1 week! | 16:01 |
gthiemonge | hi | 16:01 |
haleyb | hi | 16:01 |
johnsom | #topic Announcements | 16:01 |
*** openstack changes topic to "Announcements (Meeting topic: Octavia)" | 16:01 | |
johnsom | RC1 milestone is this week | 16:01 |
johnsom | Just a reminder for folks, RC1 is the milestone where stable/wallaby will be created. | 16:02 |
johnsom | We should strive to have all bug fixes in RC1 as doing an RC2 is extra work. | 16:02 |
johnsom | Also note, docs and testing related patches can merge at anytime and are not impacted by the RC1 milestone. (Though don't break the test jobs please. grin) | 16:03 |
johnsom | #link https://releases.openstack.org/wallaby/schedule.html | 16:03 |
johnsom | We have a priority bug review list | 16:03 |
johnsom | #link https://etherpad.openstack.org/p/octavia-priority-reviews | 16:03 |
johnsom | As of this morning, there are ~15 candidate bugs for RC1. | 16:04 |
johnsom | My plan is to unlock the RC1 patch tomorrow morning. So, please help review patches. | 16:04 |
johnsom | Any questions/comments about RC1? | 16:04 |
gthiemonge | I'll move some of my patches to a "deferred to X" list | 16:05 |
johnsom | Sounds good, thanks! | 16:06 |
johnsom | Just a reminder, PTG (virtual and free) registration is open. It is free to register and virtual once again. | 16:06 |
johnsom | #link https://www.openstack.org/ptg/ | 16:06 |
johnsom | They promise no trains or leaking water pipes once again | 16:07 |
johnsom | Any other announcements this week? | 16:07 |
johnsom | #topic Brief progress reports / bugs needing review | 16:08 |
*** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)" | 16:08 | |
johnsom | I have been working on patch reviews, updating the priority list, and other non-Octavia related stuff. | 16:08 |
johnsom | I plan to take a minute here soon to look at my backend re-encryption tempest tests that appear to be failing and get those fixed. | 16:09 |
gthiemonge | I fixed an amphorav2 bug when using host_routes with a subnet: #link https://review.opendev.org/c/openstack/octavia/+/782279 | 16:10 |
johnsom | I guess I need to rebase the scoped token tempest tests as well. | 16:10 |
johnsom | Nice. People do use host routes with Octavia. | 16:10 |
johnsom | Any other updates today? | 16:12 |
johnsom | #topic Open Discussion | 16:12 |
*** openstack changes topic to "Open Discussion (Meeting topic: Octavia)" | 16:12 | |
johnsom | How about other topics? | 16:12 |
haleyb | just being pedantic, but the list of "Priority Patches" seems more like a list of "Old Patches" | 16:14 |
johnsom | Some of them, yes. So get reviewing! | 16:14 |
johnsom | lol | 16:14 |
johnsom | That also is a bit of a good sign in that the critical stuff is getting reviewed already. | 16:15 |
johnsom | I think overall the review velocity is down for Octavia, so we do have stuff sitting a while. <sad face> | 16:15 |
haleyb | it's almost like that list should be the deferred to Xena list | 16:15 |
johnsom | Well, I know the first one on the list we *should* really try to get in Wallaby. That is a nasty bug. | 16:16 |
johnsom | That patch was created this week-ish | 16:17 |
haleyb | johnsom: i'll assume you're talking about the batch update one, not the otherone | 16:17 |
johnsom | There can be only one "1." | 16:18 |
johnsom | grin | 16:18 |
johnsom | Are you looking at the priority patch list? Those are surely booted to Xena at this point. Those aren't ready for review yet | 16:19 |
haleyb | i was talking about the second priority list, which isn't a priority :) | 16:19 |
haleyb | "not really priority patches" | 16:19 |
johnsom | Yep | 16:19 |
johnsom | Maybe the new PTL will improve the wording. | 16:19 |
haleyb | etherpad will let me do it too :) | 16:20 |
gthiemonge | sure he will | 16:20 |
johnsom | Wait, I'm technically not the old PTL either. Maybe the current PTL will improve the wording. | 16:20 |
johnsom | Ok, any other topics or are we off to doing reviews? | 16:21 |
haleyb | reviews wins | 16:22 |
johnsom | Thanks everyone! RC1 or ... RC1 | 16:22 |
johnsom | #endmeeting | 16:22 |
*** openstack changes topic to "Discussions for OpenStack Octavia | Priority bug review list: https://etherpad.openstack.org/p/octavia-priority-reviews" | 16:22 | |
openstack | Meeting ended Wed Mar 24 16:22:21 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:22 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-03-24-16.00.html | 16:22 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-03-24-16.00.txt | 16:22 |
openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-03-24-16.00.log.html | 16:22 |
*** __ministry1 has quit IRC | 16:38 | |
*** wolsen has quit IRC | 16:47 | |
*** wolsen has joined #openstack-lbaas | 16:49 | |
*** rpittau is now known as rpittau|afk | 17:24 | |
*** jamesdenton has quit IRC | 18:04 | |
*** jamesdenton has joined #openstack-lbaas | 18:05 | |
*** rcernin has joined #openstack-lbaas | 18:19 | |
*** rcernin has quit IRC | 18:23 | |
*** livelace has joined #openstack-lbaas | 19:43 | |
*** jamesdenton has quit IRC | 20:52 | |
*** jamesden_ has joined #openstack-lbaas | 20:52 | |
*** rcernin has joined #openstack-lbaas | 21:01 | |
*** rcernin has quit IRC | 21:01 | |
*** rcernin has joined #openstack-lbaas | 21:02 | |
*** livelace has quit IRC | 21:03 | |
*** jamesden_ has quit IRC | 21:25 | |
*** jamesdenton has joined #openstack-lbaas | 21:25 | |
rm_work | johnsom: ^^ per my question way above, about a possible AZ bug... | 21:41 |
johnsom | From the meeting? | 21:42 |
johnsom | grin, JK | 21:42 |
rm_work | also, nice to see eyes on the v2 driver... i'm just about to be switching too | 21:43 |
rm_work | just reviewed and +A'd greg's fix | 21:43 |
johnsom | Yes, that looks incorrect to me as well. | 21:45 |
johnsom | Since you added a default value in the config file for that, we should probably use it | 21:45 |
johnsom | Plus, the default for the config is the same as "None" here | 21:46 |
johnsom | so, no backward breaking | 21:46 |
rm_work | yep | 21:46 |
rm_work | that multi-az patch actually got a bit simplified now, which is nice | 21:46 |
rm_work | honestly a ton of the rebase pain was because I decided to fix up some of the test files <_< | 21:47 |
rm_work | with regards to stuff that had nothing to do with my patch | 21:47 |
rm_work | because ???? | 21:47 |
rm_work | I hate 3-years-ago-me | 21:47 |
rm_work | I might break that out as a separate patch, and force myself to go through that rebase hell one more time, but get it merged quickly | 21:48 |
johnsom | Well, note that tomorrow we cut stable/wallaby so, "merged quickly" may be slightly delayed to limit our wallaby release pain. | 21:49 |
*** rcernin has quit IRC | 22:11 | |
*** rcernin has joined #openstack-lbaas | 22:26 | |
*** rcernin has quit IRC | 22:31 | |
*** rcernin has joined #openstack-lbaas | 22:32 | |
*** vishalmanchanda has quit IRC | 22:41 | |
rm_work | it'd be UNIT TESTS ONLY :D | 22:43 |
rm_work | no-op essentially | 22:43 |
rm_work | lots of cleanup | 22:43 |
rm_work | i mean, do we want unit tests cleaned up? yes/no | 22:43 |
rm_work | it's one of those things where doing it kinda sucks, but if we discourage people from doing it, it'll NEVER get done, and I think we want it? | 22:46 |
johnsom | Oh it's good stuff. Just saying, I'm not a fan a sifting through a ton of changes to backport some critical fix to stable/wallaby. | 23:14 |
*** stand has quit IRC | 23:20 | |
*** jamesdenton has quit IRC | 23:32 | |
*** jamesdenton has joined #openstack-lbaas | 23:34 | |
openstackgerrit | Merged openstack/octavia master: Fix using subnets with host_routes in amphorav2 driver https://review.opendev.org/c/openstack/octavia/+/782279 | 23:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!