Wednesday, 2021-03-24

rm_workjohnsom: did that patch look ok?00:42
rm_workmeanwhile, like ... 60% through rebasing this AZ patch :D00:42
johnsomOh, let me look. Today kind of became a Designate day for me.00:45
johnsomHmm, the gate didn't like you...00:47
johnsomAh, the cache/mirror didn't like you00:48
johnsomrm_work Any chance I can bug you for a release note?00:48
johnsomSure makes backporting easier....00:49
rm_workyeah I rechecked00:49
rm_workuhh... yeah... *sigh*00:49
rm_worki can't do it now00:49
rm_workIf I do anything to jeopardize my work on this rebase in progress, I will flip a table00:49
johnsomOk, well, zuul still doesn't like you, this time with the lower-constraints job. Maybe I can poke it00:50
johnsomAh, a random unix domain socket issue. (I should look into that sometime)00:51
rm_workT_T00:52
rm_workif you wanted to pop the note on there that's fine00:53
rm_workotherwise... at this rate, guessing later this week XD00:53
rm_workmy brain is starting to grind to a halt, been staring at this rebase for 5 hours today and 6 hours yesterday00:53
rm_worklike, it shouldn't be that hard, but ... I managed to name a lot of the data structures the same, but they have different internal structures <_<00:54
johnsomYeah, I'm going to push a rel note. That will force a recheck anyway00:54
rm_workso figuring out which one I have at any given point is making me go mad00:54
johnsomlol, opps. I have been there and feel your pain00:54
rm_work(between the Multi-AZ patch, which passes "availability zone" as a string, and the AZ patch that merged which is the DB data-structure)00:55
johnsomOh now what???00:56
johnsomhttps://www.irccloud.com/pastebin/bV9ZBfA0/00:56
rm_workwat00:56
johnsomI wonder if that ssh issue fedora has had leached into this other vm00:56
rm_workchange is closed?00:56
rm_workis the error?00:57
rm_workwat00:57
johnsomOh, opps, no, my fault00:57
rm_workyeah00:57
rm_workthat merged00:57
rm_work:D00:57
openstackgerritMichael Johnson proposed openstack/octavia master: Fix empty Batch Member Update to unlock objects  https://review.opendev.org/c/openstack/octavia/+/78234200:59
johnsomThere we go01:00
johnsomOk, off to make dinner. I had too much ?fun? today messing with designate pool configs and parent/child zones. Two virtual desktops worth of ?fun?...01:00
johnsomI proved out my theory, so at least I made progress.01:02
rm_workjohnsom: if you have a sec at some point ... doesn't this seem wrong to you? https://github.com/openstack/octavia/blob/57e7bd17bfa37c4972ae07adcc4e1b9a5535bbcd/octavia/controller/worker/v1/tasks/compute_tasks.py#L83-L9001:11
rm_workspecifically line 9001:11
rm_workshouldn't it be: `amp_availability_zone = CONF.nova.availability_zone`?01:12
rm_workwe're assuming no "Octavia AZ" on a LB means that we pass no AZ to nova -- but nova's default AZ might not be the Octavia default nova-az, meaning we're building them in the wrong place in this case?01:12
rm_workneed logic check01:13
rm_worksorrison: ^^ you might remember / understand this? lol01:13
*** rcernin has quit IRC01:34
*** rcernin has joined #openstack-lbaas01:45
*** rcernin has quit IRC01:46
*** rcernin has joined #openstack-lbaas01:46
*** sapd1 has joined #openstack-lbaas02:36
*** tamas_erdei has joined #openstack-lbaas02:37
*** terdei has quit IRC02:39
*** tamas_erdei has quit IRC02:42
*** rcernin has quit IRC02:45
*** terdei has joined #openstack-lbaas02:48
*** sapd1 has quit IRC02:56
*** rcernin has joined #openstack-lbaas02:57
*** rcernin has quit IRC02:57
*** rcernin has joined #openstack-lbaas02:58
*** xgerman has quit IRC03:26
*** rcernin has quit IRC03:31
*** rcernin has joined #openstack-lbaas03:38
*** rcernin has quit IRC03:52
*** rcernin has joined #openstack-lbaas03:52
*** rcernin has quit IRC03:53
*** rcernin has joined #openstack-lbaas03:54
*** jamesdenton has quit IRC04:30
*** jamesden_ has joined #openstack-lbaas04:31
*** armax has joined #openstack-lbaas04:31
*** armax has quit IRC04:33
*** vishalmanchanda has joined #openstack-lbaas04:41
*** jamesden_ has quit IRC04:55
*** jamesdenton has joined #openstack-lbaas04:55
*** jamesdenton has quit IRC05:32
rm_workFFFFFFFF05:33
openstackgerritAdam Harwell proposed openstack/octavia master: Experimental multi-az support  https://review.opendev.org/c/openstack/octavia/+/55896205:33
rm_workstill a bug somewhere around spares pools, i see two unit tests failing there for some reason, even though I tried to rip out all of the spares pool support (rather than trying to fix it again)05:34
rm_workwill look ... not now, my brain hurts05:34
*** jamesdenton has joined #openstack-lbaas05:40
*** jamesdenton has quit IRC05:52
*** psachin has joined #openstack-lbaas05:53
*** jamesdenton has joined #openstack-lbaas05:53
*** psachin has quit IRC06:01
*** psachin has joined #openstack-lbaas06:51
*** cgoncalves has quit IRC07:18
*** cgoncalves has joined #openstack-lbaas07:20
*** cgoncalves has quit IRC07:20
*** cgoncalves has joined #openstack-lbaas07:21
*** parallax has quit IRC07:29
*** luksky has joined #openstack-lbaas07:55
*** rcernin has quit IRC08:09
*** rpittau|afk is now known as rpittau08:19
*** rcernin has joined #openstack-lbaas08:52
*** rcernin has quit IRC08:57
*** vishalmanchanda has quit IRC09:01
*** rcernin has joined #openstack-lbaas09:08
*** rcernin has quit IRC09:32
*** sapd1 has joined #openstack-lbaas09:40
openstackgerritAnn Taraday proposed openstack/octavia master: Alias change amphorav2 -> amphora  https://review.opendev.org/c/openstack/octavia/+/74043209:40
*** vishalmanchanda has joined #openstack-lbaas09:42
*** parallax has joined #openstack-lbaas09:54
*** rcernin has joined #openstack-lbaas09:57
*** strigazi has joined #openstack-lbaas09:58
openstackgerritGregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add new scenario test to create LB in specific AZ  https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/69534909:58
*** rcernin has quit IRC10:02
*** rcernin has joined #openstack-lbaas10:12
*** rcernin has quit IRC10:22
openstackgerritMerged openstack/python-octaviaclient stable/wallaby: Update .gitreview for stable/wallaby  https://review.opendev.org/c/openstack/python-octaviaclient/+/78127610:43
openstackgerritMerged openstack/octavia-lib stable/wallaby: Update .gitreview for stable/wallaby  https://review.opendev.org/c/openstack/octavia-lib/+/78125210:46
openstackgerritMerged openstack/python-octaviaclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby  https://review.opendev.org/c/openstack/python-octaviaclient/+/78127710:46
openstackgerritMerged openstack/octavia-lib stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby  https://review.opendev.org/c/openstack/octavia-lib/+/78125610:47
*** rcernin has joined #openstack-lbaas11:01
*** rcernin has quit IRC11:01
*** rcernin has joined #openstack-lbaas11:04
*** sapd1 has quit IRC11:37
*** gcheresh_ has quit IRC11:38
*** gcheresh has joined #openstack-lbaas11:39
*** rcernin has quit IRC11:58
*** rcernin has joined #openstack-lbaas12:06
*** rcernin has quit IRC12:22
*** psachin has quit IRC12:50
*** jamesdenton has quit IRC13:13
*** jamesdenton has joined #openstack-lbaas13:13
*** devfaz has quit IRC13:21
*** devfaz has joined #openstack-lbaas13:24
*** sapd1 has joined #openstack-lbaas14:00
*** armax has joined #openstack-lbaas14:09
*** __ministry1 has joined #openstack-lbaas15:21
*** stand has joined #openstack-lbaas15:29
*** xgerman has joined #openstack-lbaas15:47
johnsom#startmeeting Octavia16:00
openstackMeeting started Wed Mar 24 16:00:56 2021 UTC and is due to finish in 60 minutes.  The chair is johnsom. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
*** openstack changes topic to " (Meeting topic: Octavia)"16:00
openstackThe meeting name has been set to 'octavia'16:01
johnsomHi everyone, and happy RC1 week!16:01
gthiemongehi16:01
haleybhi16:01
johnsom#topic Announcements16:01
*** openstack changes topic to "Announcements (Meeting topic: Octavia)"16:01
johnsomRC1 milestone is this week16:01
johnsomJust a reminder for folks, RC1 is the milestone where stable/wallaby will be created.16:02
johnsomWe should strive to have all bug fixes in RC1 as doing an RC2 is extra work.16:02
johnsomAlso note, docs and testing related patches can merge at anytime and are not impacted by the RC1 milestone. (Though don't break the test jobs please. grin)16:03
johnsom#link https://releases.openstack.org/wallaby/schedule.html16:03
johnsomWe have a priority bug review list16:03
johnsom#link https://etherpad.openstack.org/p/octavia-priority-reviews16:03
johnsomAs of this morning, there are ~15 candidate bugs for RC1.16:04
johnsomMy plan is to unlock the RC1 patch tomorrow morning. So, please help review patches.16:04
johnsomAny questions/comments about RC1?16:04
gthiemongeI'll move some of my patches to a "deferred to X" list16:05
johnsomSounds good, thanks!16:06
johnsomJust a reminder, PTG (virtual and free) registration is open. It is free to register and virtual once again.16:06
johnsom#link https://www.openstack.org/ptg/16:06
johnsomThey promise no trains or leaking water pipes once again16:07
johnsomAny other announcements this week?16:07
johnsom#topic Brief progress reports / bugs needing review16:08
*** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)"16:08
johnsomI have been working on patch reviews, updating the priority list, and other non-Octavia related stuff.16:08
johnsomI plan to take a minute here soon to look at my backend re-encryption tempest tests that appear to be failing and get those fixed.16:09
gthiemongeI fixed an amphorav2 bug when using host_routes with a subnet: #link https://review.opendev.org/c/openstack/octavia/+/78227916:10
johnsomI guess I need to rebase the scoped token tempest tests as well.16:10
johnsomNice. People do use host routes with Octavia.16:10
johnsomAny other updates today?16:12
johnsom#topic Open Discussion16:12
*** openstack changes topic to "Open Discussion (Meeting topic: Octavia)"16:12
johnsomHow about other topics?16:12
haleybjust being pedantic, but the list of "Priority Patches" seems more like a list of "Old Patches"16:14
johnsomSome of them, yes. So get reviewing!16:14
johnsomlol16:14
johnsomThat also is a bit of a good sign in that the critical stuff is getting reviewed already.16:15
johnsomI think overall the review velocity is down for Octavia, so we do have stuff sitting a while. <sad face>16:15
haleybit's almost like that list should be the deferred to Xena list16:15
johnsomWell, I know the first one on the list we *should* really try to get in Wallaby. That is a nasty bug.16:16
johnsomThat patch was created this week-ish16:17
haleybjohnsom: i'll assume you're talking about the batch update one, not the otherone16:17
johnsomThere can be only one "1."16:18
johnsomgrin16:18
johnsomAre you looking at the priority patch list? Those are surely booted to Xena at this point. Those aren't ready for review yet16:19
haleybi was talking about the second priority list, which isn't a priority :)16:19
haleyb"not really priority patches"16:19
johnsomYep16:19
johnsomMaybe the new PTL will improve the wording.16:19
haleybetherpad will let me do it too :)16:20
gthiemongesure he will16:20
johnsomWait, I'm technically not the old PTL either. Maybe the current PTL will improve the wording.16:20
johnsomOk, any other topics or are we off to doing reviews?16:21
haleybreviews wins16:22
johnsomThanks everyone! RC1 or ... RC116:22
johnsom#endmeeting16:22
*** openstack changes topic to "Discussions for OpenStack Octavia | Priority bug review list: https://etherpad.openstack.org/p/octavia-priority-reviews"16:22
openstackMeeting ended Wed Mar 24 16:22:21 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:22
openstackMinutes:        http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-03-24-16.00.html16:22
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-03-24-16.00.txt16:22
openstackLog:            http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-03-24-16.00.log.html16:22
*** __ministry1 has quit IRC16:38
*** wolsen has quit IRC16:47
*** wolsen has joined #openstack-lbaas16:49
*** rpittau is now known as rpittau|afk17:24
*** jamesdenton has quit IRC18:04
*** jamesdenton has joined #openstack-lbaas18:05
*** rcernin has joined #openstack-lbaas18:19
*** rcernin has quit IRC18:23
*** livelace has joined #openstack-lbaas19:43
*** jamesdenton has quit IRC20:52
*** jamesden_ has joined #openstack-lbaas20:52
*** rcernin has joined #openstack-lbaas21:01
*** rcernin has quit IRC21:01
*** rcernin has joined #openstack-lbaas21:02
*** livelace has quit IRC21:03
*** jamesden_ has quit IRC21:25
*** jamesdenton has joined #openstack-lbaas21:25
rm_workjohnsom: ^^ per my question way above, about a possible AZ bug...21:41
johnsomFrom the meeting?21:42
johnsomgrin, JK21:42
rm_workalso, nice to see eyes on the v2 driver... i'm just about to be switching too21:43
rm_workjust reviewed and +A'd greg's fix21:43
johnsomYes, that looks incorrect to me as well.21:45
johnsomSince you added a default value in the config file for that, we should probably use it21:45
johnsomPlus, the default for the config is the same as "None" here21:46
johnsomso, no backward breaking21:46
rm_workyep21:46
rm_workthat multi-az patch actually got a bit simplified now, which is nice21:46
rm_workhonestly a ton of the rebase pain was because I decided to fix up some of the test files <_<21:47
rm_workwith regards to stuff that had nothing to do with my patch21:47
rm_workbecause ????21:47
rm_workI hate 3-years-ago-me21:47
rm_workI might break that out as a separate patch, and force myself to go through that rebase hell one more time, but get it merged quickly21:48
johnsomWell, note that tomorrow we cut stable/wallaby so, "merged quickly" may be slightly delayed to limit our wallaby release pain.21:49
*** rcernin has quit IRC22:11
*** rcernin has joined #openstack-lbaas22:26
*** rcernin has quit IRC22:31
*** rcernin has joined #openstack-lbaas22:32
*** vishalmanchanda has quit IRC22:41
rm_workit'd be UNIT TESTS ONLY :D22:43
rm_workno-op essentially22:43
rm_worklots of cleanup22:43
rm_worki mean, do we want unit tests cleaned up? yes/no22:43
rm_workit's one of those things where doing it kinda sucks, but if we discourage people from doing it, it'll NEVER get done, and I think we want it?22:46
johnsomOh it's good stuff. Just saying, I'm not a fan a sifting through a ton of changes to backport some critical fix to stable/wallaby.23:14
*** stand has quit IRC23:20
*** jamesdenton has quit IRC23:32
*** jamesdenton has joined #openstack-lbaas23:34
openstackgerritMerged openstack/octavia master: Fix using subnets with host_routes in amphorav2 driver  https://review.opendev.org/c/openstack/octavia/+/78227923:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!