| *** sapd1_x has quit IRC | 00:28 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Use vip_subnet_selection_tag to select subnets https://review.opendev.org/c/openstack/octavia/+/788133 | 00:36 |
|---|---|---|
| *** njohnston has quit IRC | 01:03 | |
| *** tkajinam has joined #openstack-lbaas | 01:13 | |
| openstackgerrit | Takashi Kajinami proposed openstack/octavia-dashboard master: Support policy-in-code and deprecated policy https://review.opendev.org/c/openstack/octavia-dashboard/+/789691 | 02:18 |
| *** rcernin has quit IRC | 03:05 | |
| *** rcernin has joined #openstack-lbaas | 03:16 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Use vip_subnet_selection_tag to select subnets https://review.opendev.org/c/openstack/octavia/+/788133 | 03:19 |
| *** psachin has joined #openstack-lbaas | 03:37 | |
| *** sapd1_x has joined #openstack-lbaas | 04:15 | |
| *** vishalmanchanda has joined #openstack-lbaas | 04:51 | |
| *** xgerman has quit IRC | 05:03 | |
| *** sapd1_x has quit IRC | 05:30 | |
| *** damien_r has joined #openstack-lbaas | 06:27 | |
| *** damien_r has quit IRC | 06:31 | |
| *** damien_r has joined #openstack-lbaas | 06:37 | |
| openstackgerrit | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Move ubuntu jobs to focal https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/788954 | 06:54 |
| *** rpittau|afk is now known as rpittau | 07:12 | |
| *** sapd1_x has joined #openstack-lbaas | 07:18 | |
| *** rcernin has quit IRC | 07:21 | |
| *** rcernin has joined #openstack-lbaas | 07:25 | |
| *** sapd1_x has quit IRC | 07:42 | |
| *** sapd1_x has joined #openstack-lbaas | 07:49 | |
| *** rcernin has quit IRC | 07:59 | |
| *** ianychoi_ has quit IRC | 08:13 | |
| *** rcernin has joined #openstack-lbaas | 08:23 | |
| *** rcernin has quit IRC | 08:29 | |
| *** QG has joined #openstack-lbaas | 08:37 | |
| *** rcernin has joined #openstack-lbaas | 08:38 | |
| *** rcernin has quit IRC | 08:42 | |
| *** rcernin has joined #openstack-lbaas | 08:46 | |
| *** rcernin has quit IRC | 09:30 | |
| *** osmanlicilegi has quit IRC | 09:50 | |
| *** rcernin has joined #openstack-lbaas | 09:54 | |
| *** rcernin has quit IRC | 10:05 | |
| *** osmanlicilegi has joined #openstack-lbaas | 10:15 | |
| *** rcernin has joined #openstack-lbaas | 10:52 | |
| *** rcernin has quit IRC | 10:58 | |
| *** rcernin has joined #openstack-lbaas | 11:02 | |
| *** rcernin has quit IRC | 11:06 | |
| *** sapd1_x has quit IRC | 11:18 | |
| *** rcernin has joined #openstack-lbaas | 11:24 | |
| *** rcernin has quit IRC | 11:28 | |
| *** rcernin has joined #openstack-lbaas | 11:45 | |
| *** rcernin has quit IRC | 11:55 | |
| *** njohnston has joined #openstack-lbaas | 12:03 | |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Use vip_subnet_selection_tag to select subnets https://review.opendev.org/c/openstack/octavia/+/788133 | 12:03 |
| *** rcernin has joined #openstack-lbaas | 12:18 | |
| *** rcernin has quit IRC | 12:23 | |
| openstackgerrit | Merged openstack/octavia master: Optimize CountPoolChildrenForQuota task in amphorav2 https://review.opendev.org/c/openstack/octavia/+/788945 | 12:32 |
| openstackgerrit | Merged openstack/octavia master: Spare pool removal https://review.opendev.org/c/openstack/octavia/+/787722 | 12:33 |
| openstackgerrit | Merged openstack/octavia master: Fix comment for the ca_certificates_file opt https://review.opendev.org/c/openstack/octavia/+/784382 | 12:40 |
| openstackgerrit | Arieh Maron proposed openstack/octavia-tempest-plugin master: Updating _test_pool_CRUD to enable testing of updates to the load balancer algorithm: https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/789829 | 13:12 |
| *** dulek has quit IRC | 13:22 | |
| *** gregraka has quit IRC | 13:25 | |
| *** dulek has joined #openstack-lbaas | 13:35 | |
| openstackgerrit | Arieh Maron proposed openstack/octavia-tempest-plugin master: Updating _test_pool_CRUD to enable testing of updates to the load balancer algorithm: https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/770163 | 13:55 |
| rm_work | hmm, now that the spares pool code is gone... I wonder what happens to amps that existed in the spares pool, if it was configured? :D do they just sit there I guess and you have to use the amp delete command to admin-remove them? :P | 14:06 |
| rm_work | will that work properly? | 14:06 |
| * rm_work will have to poke at that later | 14:06 | |
| rm_work | didn't realize you were so far along that the removal was already merging! great to see it gone, very good simplification. just my paranoia at work :P | 14:07 |
| gthiemonge | rm_work: the old spare amps are detected as unattached/bogus amps by the HM, and then HM deletes them | 14:08 |
| rm_work | Nice | 14:09 |
| rm_work | Will have to read through the rest of that patch later | 14:09 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia/+/787722/4/releasenotes/notes/spare-pool-removal-7d51eae592d05874.yaml | 14:09 |
| *** gregraka has joined #openstack-lbaas | 14:20 | |
| johnsom | rm_work https://docs.openstack.org/api-ref/load-balancer/v2/index.html#remove-an-amphora is also an option | 14:22 |
| rm_work | Yeah that's what I was referring to | 14:25 |
| rm_work | But looks like Gregory handled it :) | 14:26 |
| *** rpittau is now known as rpittau|afk | 15:52 | |
| gthiemonge | #startmeeting Octavia | 16:00 |
| openstack | Meeting started Wed May 5 16:00:20 2021 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| *** openstack changes topic to " (Meeting topic: Octavia)" | 16:00 | |
| openstack | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | Hi folks | 16:00 |
| haleyb | hi | 16:00 |
| QG | Hi | 16:00 |
| gthiemonge | Oops, it looks like I forgot to update the agenda :/ | 16:00 |
| johnsom | o/ | 16:01 |
| gthiemonge | #topic Announcements | 16:01 |
| *** openstack changes topic to "Announcements (Meeting topic: Octavia)" | 16:01 | |
| gthiemonge | Call for community goals | 16:02 |
| gthiemonge | There's call for new community goals for the Y release | 16:02 |
| gthiemonge | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-May/022232.html | 16:02 |
| openstackgerrit | Arieh Maron proposed openstack/octavia-tempest-plugin master: Updating _test_pool_CRUD to enable testing of updates to the load balancer algorithm: https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/770163 | 16:02 |
| gthiemonge | johnsom: are there community goals for X? I cannot find anything | 16:03 |
| johnsom | No, there were not | 16:03 |
| johnsom | <meme of "vote for none of the above" pops in my head> | 16:04 |
| gthiemonge | lol | 16:04 |
| johnsom | #link https://governance.openstack.org/tc/goals/selected/index.html | 16:04 |
| johnsom | That is the list of "selected goals" | 16:04 |
| haleyb | We took cool-down cycle goal step for Xena | 16:04 |
| haleyb | cycle [7], so no selected goals for Xena. | 16:04 |
| gthiemonge | yeah there's a 404 -> https://governance.openstack.org/tc/goals/selected/xena/index.html | 16:05 |
| johnsom | I see there is a strong list of proposals: | 16:05 |
| johnsom | #link https://governance.openstack.org/tc/goals/proposed/index.html | 16:05 |
| * johnsom votes for "placeholder" | 16:05 | |
| gthiemonge | next announcement: | 16:06 |
| gthiemonge | Devstack dropping support for Ubuntu Bionic (on master) | 16:06 |
| gthiemonge | We received an email on openstack-discuss | 16:07 |
| gthiemonge | because we still have Ubuntu Bionic jobs on our master branch. | 16:07 |
| gthiemonge | Devstack is going to drop the Bionic support and asks people to move to Focal. | 16:07 |
| johnsom | Yeah, I think this was delayed due to the "switch base jobs to centos" discussion | 16:07 |
| gthiemonge | There's an open review for octavia-tempest-plugin: | 16:07 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/788954 | 16:08 |
| gthiemonge | johnsom: oh cool, but switching to focal doesn't look bad | 16:08 |
| gthiemonge | Note that train and ussuri branch will still use Bionic | 16:08 |
| johnsom | Yeah, the plan for centos never materialized. I think the proposed patch is still broken. | 16:09 |
| johnsom | So, moving forward with focal is a good idea | 16:09 |
| gthiemonge | We also need to send a patch for the octavia, there are some Bionic jobs: | 16:09 |
| gthiemonge | #link https://opendev.org/openstack/octavia/src/branch/master/zuul.d/jobs.yaml | 16:09 |
| gthiemonge | Any other announcements? | 16:10 |
| gthiemonge | ok | 16:11 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:11 |
| *** openstack changes topic to "Brief progress reports / bugs needing review (Meeting topic: Octavia)" | 16:11 | |
| gthiemonge | I'm working on the amphorav2, I have an new patch that needs reviews: | 16:12 |
| gthiemonge | #link https://review.opendev.org/c/openstack/octavia/+/789396 | 16:12 |
| gthiemonge | There's still an open bug/review in taskflow, but I think the amphorav2 jobs are now in a good shape. | 16:13 |
| johnsom | I have mostly been doing reviews. I did update the focal nightly build patch: | 16:13 |
| johnsom | #link https://review.opendev.org/c/openstack/octavia/+/763092 | 16:13 |
| johnsom | gthiemonge I answered your question on that | 16:13 |
| gthiemonge | thanks | 16:13 |
| johnsom | I think I also re-reviewed the taskflow patch this morning | 16:14 |
| gthiemonge | I hope we will be able to make amphorav2 the default driver soon | 16:14 |
| gthiemonge | #topic Open Discussion | 16:16 |
| *** openstack changes topic to "Open Discussion (Meeting topic: Octavia)" | 16:16 | |
| QG | I just want to introduce myself, I work at OVHCloud and we have started to integrate Octavia, if we can help, make tests, or reviews | 16:18 |
| johnsom | Hi QG, welcome! | 16:18 |
| johnsom | We certainly can use more reviewers, so please feel welcome to help us review patches. | 16:18 |
| gthiemonge | QG: Welcome! | 16:18 |
| johnsom | It's a great way to learn the code too. | 16:18 |
| QG | Thank you | 16:19 |
| johnsom | Also, if you have questions, this channel is pretty good about helping folks out. | 16:19 |
| gthiemonge | #link https://labs.ovh.com/public-cloud-lbaas | 16:20 |
| QG | johnsom Yes, thanks | 16:20 |
| johnsom | Nice | 16:20 |
| gthiemonge | Someone sent me this link to your site | 16:20 |
| QG | gthiemonge That's exactly it | 16:20 |
| gthiemonge | that explains the RFE you opened for the req/s limitation | 16:21 |
| QG | Exactly | 16:22 |
| johnsom | Ah, yes. I had some questions/comments on that RFE | 16:22 |
| QG | As we deploy Public Cloud we need to a way to do some req/s limitation | 16:24 |
| johnsom | You don't just charge by bytes in/out? grin | 16:24 |
| QG | No, we don't charge for the network | 16:25 |
| johnsom | Yeah, we have a few features along that line today, but the RFE seemed to be a new request. | 16:25 |
| johnsom | Do you have a developer that will work on that feature? | 16:25 |
| QG | Yeah Pierre-Yves, who opened the RFE will work on it | 16:26 |
| johnsom | It wasn't on the PTG topic list, so wasn't something we discussed. I think we can work out the details in the RFE story. | 16:26 |
| QG | yes we missed the PTG by a week | 16:27 |
| johnsom | Ok cool. Please let them know they can ask questions here and there are comments on the RFE. | 16:27 |
| johnsom | We are happy to help them be successful! | 16:27 |
| QG | Thanks ! sure no problem | 16:27 |
| gthiemonge | Cool! | 16:28 |
| gthiemonge | Hey, I'm on PTO next wednesday, should we cancel the meeting? | 16:28 |
| johnsom | Ah, good question. If we want to have it I can volunteer to run it. However, if we want a break I am good with that too | 16:29 |
| gthiemonge | Ok we can skip the next meeting | 16:30 |
| haleyb | i'm fine with canceling | 16:30 |
| gthiemonge | I'll send an email on openstack-discuss | 16:30 |
| gthiemonge | thanks | 16:30 |
| gthiemonge | any other topics today? | 16:31 |
| gthiemonge | Thanks everyone | 16:32 |
| gthiemonge | #endmeeting | 16:33 |
| johnsom | Thanks gthiemonge | 16:33 |
| *** openstack changes topic to "Discussions for OpenStack Octavia | Priority bug review list: https://etherpad.openstack.org/p/octavia-priority-reviews" | 16:33 | |
| openstack | Meeting ended Wed May 5 16:33:03 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:33 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-05-05-16.00.html | 16:33 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-05-05-16.00.txt | 16:33 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/octavia/2021/octavia.2021-05-05-16.00.log.html | 16:33 |
| QG | Thanks | 16:33 |
| *** psachin has quit IRC | 16:36 | |
| *** QG has quit IRC | 16:37 | |
| *** zzzeek has joined #openstack-lbaas | 16:45 | |
| *** zzzeek has quit IRC | 16:50 | |
| *** zzzeek has joined #openstack-lbaas | 16:52 | |
| *** osmanlicilegi has quit IRC | 16:54 | |
| *** osmanlicilegi has joined #openstack-lbaas | 17:00 | |
| *** zzzeek has quit IRC | 17:04 | |
| *** zzzeek has joined #openstack-lbaas | 17:08 | |
| *** vishalmanchanda has quit IRC | 18:46 | |
| openstackgerrit | Merged openstack/octavia master: Add nightly test image build job for focal https://review.opendev.org/c/openstack/octavia/+/763092 | 19:51 |
| *** xgerman has joined #openstack-lbaas | 22:02 | |
| *** armax has joined #openstack-lbaas | 22:58 | |
| *** armax has left #openstack-lbaas | 22:58 | |
| *** rcernin has joined #openstack-lbaas | 23:04 | |
| rm_work | FINALLY I think I see what's wrong | 23:21 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Use vip_subnet_selection_tag to select subnets https://review.opendev.org/c/openstack/octavia/+/788133 | 23:21 |
| rm_work | network driver isn't a singleton, and with the no-op driver where state is just stored internally, this does not work <_< | 23:21 |
| rm_work | maybe the correct fix is just to make the `utils.get_network_driver()` function a singleton handler? | 23:22 |
| rm_work | johnsom: can you think of any reason we don't do this for the network driver? | 23:22 |
| rm_work | it takes no context or anything for instantiation... | 23:23 |
| johnsom | Ugh, I remember there was a discussion of why the network driver isn't a singleton, but ... I don't remember any details. | 23:23 |
| rm_work | I'm gonna try making the change and see if it explodes stuff | 23:23 |
| johnsom | Token lifetime? | 23:23 |
| rm_work | hmmmm | 23:23 |
| rm_work | yeah that could be it | 23:23 |
| rm_work | does it not have a re-auth built in to the SDK? | 23:24 |
| rm_work | hmmm or would we be circumventing that basically | 23:24 |
| johnsom | https://github.com/openstack/octavia/blob/master/octavia/common/clients.py#L72 | 23:24 |
| rm_work | yeah reading through it | 23:25 |
| johnsom | You are in an area of the code I have only put duct tape on, I wasn't involved in it's origination much. | 23:25 |
| rm_work | but can a default KeystoneSession not re-auth? | 23:25 |
| * haleyb mic drops with the OVN provider network client link, https://github.com/openstack/ovn-octavia-provider/blob/master/ovn_octavia_provider/common/clients.py | 23:25 | |
| haleyb | that uses Singleton | 23:25 |
| rm_work | uhhh | 23:26 |
| rm_work | so are you saying we should avoid doing that, because OVN does it? :P | 23:26 |
| johnsom | Sounds right to me | 23:26 |
| johnsom | grin | 23:26 |
| rm_work | couldn't avoid that dig :P | 23:26 |
| haleyb | all i know is someone fixed that code, and i noticed Octavia was similar and didn't know who was right | 23:27 |
| haleyb | let sleeping dogs lie | 23:27 |
| rm_work | this is way more fancy than I was going to do for a singleton <_< | 23:27 |
| johnsom | Yeah, in the heady days of "we will support multiple network implementations" this decision was a bit higher up than the neutron client level | 23:27 |
| rm_work | I was just gonna make a global and set it :P | 23:27 |
| rm_work | is there an advantage to being so fancy with metaclassing | 23:28 |
| johnsom | So, wait, that client already is a singleton for the neutron auth part. | 23:28 |
| haleyb | rm_work: that would probably work too, i only know we saw memory (?) issues somewhere and doing it like that fixed it | 23:28 |
| rm_work | oh, because keystone is? | 23:28 |
| johnsom | It's really down to the network driver code itself, which is a lot safer | 23:28 |
| johnsom | https://github.com/openstack/octavia/blob/master/octavia/common/clients.py#L91 | 23:29 |
| rm_work | hmmm | 23:29 |
| rm_work | ok | 23:29 |
| johnsom | Ugh, why did you distract me from this deep code review on designate... sigh | 23:30 |
| rm_work | so actually it's up to the specific driver? | 23:30 |
| rm_work | so I could make the no-op driver specifically be a singleton | 23:30 |
| johnsom | Yes, that is true for sure. (thought it was really) | 23:30 |
| haleyb | johnsom: yes, i think when i saw that line i went hmmm as well, should be sufficient in OVN as well, or maybe this all belons in octavia-lib :) | 23:30 |
| johnsom | why wouldn't the no-op be a singleton????? | 23:30 |
| johnsom | haleyb I think it's a fail if drivers go through octavia-lib to go through neutron client IMO. | 23:31 |
| rm_work | right!? it should be | 23:31 |
| rm_work | but it doesn't appear to be | 23:31 |
| johnsom | rm_work I see zero risk in doing that in no-op | 23:32 |
| rm_work | yeah | 23:32 |
| haleyb | johnsom: well, we can define the same thing in many places then, and do it differently, or just once | 23:32 |
| johnsom | If anything, you should use neutron-lib.... lol | 23:33 |
| haleyb | now *that's* a zinger! | 23:33 |
| johnsom | grin | 23:34 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Use vip_subnet_selection_tag to select subnets https://review.opendev.org/c/openstack/octavia/+/788133 | 23:45 |
| openstackgerrit | Adam Harwell proposed openstack/octavia master: Use vip_subnet_selection_tag to select subnets https://review.opendev.org/c/openstack/octavia/+/788133 | 23:47 |
| rm_work | nm the Singleton stuff is in oslo_service ^^ :P thanks for the find johnsom | 23:47 |
| * johnsom puts on his oslo liaison badge | 23:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!