| etoneja | Hey! | 07:04 |
|---|---|---|
| etoneja | Can you please tell me if there any some reason why not to fulfill the current context from amphorae_driver when calling rpc methods (in current version empty dict is passing)? | 07:04 |
| etoneja | https://github.com/openstack/octavia/blob/bd01ad94dcea3eca7636f1286ceed0753b563a28/octavia/api/drivers/amphora_driver/v1/driver.py#L137 | 07:04 |
| gthiemonge | etoneja: hmm I have no idea | 07:13 |
| gthiemonge | etoneja: do you think we should pass a context? | 07:22 |
| etoneja | A little background. | 07:44 |
| etoneja | I use a threading as the queue subscribers mechanism, which implies a thread pool. If in any of the threads I define the context | 07:44 |
| etoneja | (example https://github.com/openstack/octavia/blob/bd01ad94dcea3eca7636f1286ceed0753b563a28/octavia/api/drivers/utils.py#L199), then all the following requests sent by this thread will have the "previous" context, since the context is stored in local thread storage. | 07:44 |
| etoneja | This does not lead to any significant problem, but because of this the incorrect context associated with the request will be recorded in the log (if use oslo_logging). | 07:44 |
| etoneja | In my opinion, the solution is either to define the context at the entry point in the each RPC method every time, or not to override this context along the way (when using threads, i dont test other mechanisms). | 07:44 |
| etoneja | In addition, if we pass the context, this will allow us to get better logging (as they will be associated with the global request identifier). | 07:44 |
| etoneja | I am fairly new to the topic and am afraid that I am may missing something. | 07:44 |
| opendevreview | Merged openstack/octavia master: Fix nft command line with negative priority values https://review.opendev.org/c/openstack/octavia/+/819265 | 13:48 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/xena: Fix nft command line with negative priority values https://review.opendev.org/c/openstack/octavia/+/820536 | 15:18 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/wallaby: Fix nft command line with negative priority values https://review.opendev.org/c/openstack/octavia/+/820537 | 15:26 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia stable/victoria: Fix nft command line with negative priority values https://review.opendev.org/c/openstack/octavia/+/820542 | 15:41 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!