| *** ysandeep is now known as ysandeep|afk | 01:33 | |
| *** ysandeep|afk is now known as ysandeep | 02:19 | |
| *** ysandeep is now known as ysandeep|afk | 04:15 | |
| *** ysandeep|afk is now known as ysandeep | 05:04 | |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add SCTP protocol scenario tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/738643 | 06:36 |
|---|---|---|
| gthiemonge | gmann: thanks for the heads up, I'll book it | 06:38 |
| *** ysandeep is now known as ysandeep|away | 07:01 | |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Rename Context to RequestContext https://review.opendev.org/c/openstack/octavia/+/827447 | 07:15 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia master: Pass config to castellan https://review.opendev.org/c/openstack/octavia/+/827456 | 07:18 |
| noonedeadpunk | tbh it's quite sad that these 2 were not reviewed and merged in time, as now castgelan will be completely unusable for one more release... | 07:19 |
| noonedeadpunk | unless these are considered as bugfixes and can be backported ;) | 07:20 |
| tweining | noonedeadpunk: yeah, I understand your frustration. we need to become better at reviewing new features in time. IMHO the castellan change could be considered a fix and backported. | 07:24 |
| tweining | also, always feel free to ping us to get things reviewed | 07:25 |
| tweining | hm, I mean the "pass config to castellan" one, the other one probably not. | 07:27 |
| noonedeadpunk | tweining: well, I tend to "trust the process" :D | 07:28 |
| noonedeadpunk | but yeah, that's fair note | 07:28 |
| noonedeadpunk | tweining: question - can https://review.opendev.org/c/openstack/octavia/+/859793 be a backport? | 07:32 |
| noonedeadpunk | It's quite clean cherry-pick | 07:32 |
| noonedeadpunk | I guess at least to Zed it should be fine? | 07:33 |
| tweining | hm, it looks backportable, but we'd have to get the opinion of gthiemonge and johnsom as well. | 07:36 |
| tweining | ah, gthiemonge voted on the original patch B+2 already, so I guess it is fine to do a zed backport as well. | 07:38 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia stable/zed: Fix barbican client with application credentials/trusts https://review.opendev.org/c/openstack/octavia/+/859912 | 07:40 |
| noonedeadpunk | ah indeed, I've missed it, sorry | 07:40 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/octavia stable/yoga: Fix barbican client with application credentials/trusts https://review.opendev.org/c/openstack/octavia/+/859913 | 07:40 |
| noonedeadpunk | not sure though if you backport release notes like that? | 07:41 |
| noonedeadpunk | as I've heard it's not worth doing like that, but rather re-add release not, otherwise reno goes crazy when renderring | 07:42 |
| tweining | I personally simply do a cherry-pick an leave everything as it was if possible. I'm not sure what you mean with re-add release notes. | 07:44 |
| *** ysandeep|away is now known as ysandeep|lunch | 08:10 | |
| noonedeadpunk | tweining: so reno does identify where reno should be added by commit SHA where it was merged. And with cherry pick it's same commit in different branches/tags | 08:20 |
| noonedeadpunk | Which confuses reno and it might add release note in unexpected releases or move them even futher then supposed to. But it's what I can recall from releases team explanation. Reno is a bit of magic for me tbh :D | 08:21 |
| tweining | interesting, I wasn't aware of that | 08:22 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add SCTP protocol scenario tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/738643 | 09:17 |
| *** ysandeep|lunch is now known as ysandeep | 09:40 | |
| *** ysandeep is now known as ysandeep|brb | 10:45 | |
| *** ysandeep|brb is now known as ysandeep | 11:13 | |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add SCTP protocol scenario tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/738643 | 13:17 |
| *** dkehn__ is now known as dkehn | 14:19 | |
| johnsom | tweining When you have a minute, it would be nice to merge this: https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/760471 | 15:07 |
| *** ysandeep is now known as ysandeep|out | 15:11 | |
| *** dkehn__ is now known as dkehn | 15:48 | |
| tweining | johnsom: done | 16:14 |
| johnsom | Thank you | 16:14 |
| gmann | gthiemonge: thanks | 18:06 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!