| opendevreview | Takashi Kajinami proposed openstack/octavia stable/2023.2: Fix remaining usage of [neutron] endpoint_type https://review.opendev.org/c/openstack/octavia/+/895798 | 03:57 |
|---|---|---|
| gthiemonge | #startmeeting Octavia | 16:00 |
| opendevmeet | Meeting started Wed Sep 20 16:00:26 2023 UTC and is due to finish in 60 minutes. The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'octavia' | 16:00 |
| gthiemonge | \o | 16:00 |
| johnsom | o/ | 16:00 |
| tweining | o/ | 16:00 |
| gthiemonge | #topic Announcements | 16:01 |
| gthiemonge | * 2023.2 Bobcat Release Schedule: R-2 | 16:01 |
| gthiemonge | release patches for RC1 are merged | 16:02 |
| gthiemonge | I think we're good to go for Bobcat ;-) | 16:02 |
| gthiemonge | \o/ | 16:02 |
| johnsom | Nice | 16:02 |
| gthiemonge | * 2024.1 Caracal vPTG | 16:03 |
| gthiemonge | reminder: PTG will be held virtually October 23-27 | 16:03 |
| gthiemonge | I haven't booked our session yet | 16:03 |
| gthiemonge | but I set up the etherpad for Octavia | 16:03 |
| gthiemonge | https://etherpad.opendev.org/p/caracal-ptg-octavia | 16:04 |
| gthiemonge | feel free to add your topics there! | 16:04 |
| gthiemonge | any other announcements folks? | 16:05 |
| tweining | no | 16:05 |
| gthiemonge | I'm going to skip the CI status section, no update this week | 16:07 |
| gthiemonge | #topic Brief progress reports / bugs needing review | 16:07 |
| gthiemonge | FYI I found a bug with the member batch update API | 16:08 |
| gthiemonge | there's race condition, it can make load balancer stuck in PENDING_UPDATE if your server is really loaded | 16:08 |
| gthiemonge | https://review.opendev.org/c/openstack/octavia/+/895251 | 16:08 |
| tweining | I hate race conditions. good job finding it. | 16:09 |
| gthiemonge | here's the launchpad | 16:10 |
| gthiemonge | https://bugs.launchpad.net/octavia/+bug/2036156 | 16:10 |
| johnsom | I remember talking about that one. +2 | 16:12 |
| gthiemonge | I have an action item: check if other PUT methods have similar issues | 16:13 |
| gthiemonge | #topic Open Discussion | 16:15 |
| gthiemonge | maybe you read this email on the ML: "[octavia] state of taskflow jobboards" | 16:15 |
| gthiemonge | they are asking clarification on the status of jobboard | 16:16 |
| gthiemonge | it's marked as experimental in the doc but not in the config | 16:16 |
| gthiemonge | my 2 cents: | 16:16 |
| gthiemonge | we had a few bugs with the jobboard backends when it was added | 16:17 |
| gthiemonge | I don't remember that we had any new jobboard-specific bug in the recent cycles (maybe 2 or 3 cycles?) | 16:17 |
| gthiemonge | so for me, it's no longer experimental | 16:17 |
| gthiemonge | (and we know that a few folks here are using it) | 16:17 |
| gthiemonge | any opinions? | 16:18 |
| johnsom | I haven't run with it a lot so I can't really comment much. | 16:19 |
| tweining | I can't comment because I haven't even touched jobboard | 16:19 |
| johnsom | I would like to hear from people that are running it | 16:19 |
| gthiemonge | hmm I don't see them on IRC | 16:19 |
| gthiemonge | (OVH Folks) | 16:19 |
| gthiemonge | alright, anyway, we can discuss it at the PTG if they join | 16:21 |
| gthiemonge | I will reply to this thread, I'll tell them that it will be discussed with operators | 16:21 |
| gthiemonge | thanks guys | 16:22 |
| tweining | I just saw https://review.opendev.org/c/openstack/octavia/+/873489 and that it has 2 CR+2s but no W+1 yet. are we still waiting for something? | 16:22 |
| gthiemonge | there's a test commit I think | 16:22 |
| gthiemonge | oh no there's a question from johnsom | 16:23 |
| gthiemonge | johnsom: can you check my answer? | 16:23 |
| johnsom | Yeah, that is fine. | 16:25 |
| gthiemonge | thanks | 16:25 |
| gthiemonge | ok, do you have any other topics? | 16:26 |
| tweining | only one | 16:26 |
| tweining | I had to rebase https://review.opendev.org/c/openstack/octavia/+/879749 again because of merge conflicts. it would be nice if you could review it. thanks gthiemonge for your review | 16:27 |
| tweining | it looks huge but it isn't really. | 16:28 |
| johnsom | Is this part of the PTI in any way? | 16:29 |
| tweining | what is PTI? | 16:29 |
| johnsom | https://governance.openstack.org/tc/reference/project-testing-interface.html | 16:30 |
| tweining | well, I know lots of other Openstack projects use mypy | 16:30 |
| johnsom | I just worry about adding some new thing that is more of a surface to break if we are the only project using it, etc. | 16:30 |
| tweining | https://codesearch.opendev.org/?q=mypy&i=nope&literal=nope&files=&excludeFiles=&repos= | 16:32 |
| tweining | as a bonus that patch fixes even a little bug | 16:33 |
| tweining | https://review.opendev.org/c/openstack/octavia/+/879749/34/octavia/cmd/prometheus_proxy.py#297 | 16:34 |
| tweining | honestly, I find it frustrating that octavia tends to be reluctant to adopt new technologies | 16:35 |
| gthiemonge | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_998/879749/34/check/octavia-mypy/9980559/mypy-report/index.html | 16:36 |
| gthiemonge | what about those reports | 16:36 |
| gthiemonge | what would be the next step? | 16:36 |
| johnsom | I think this patch is making a lot of unrelated changes too, like setup.cfg, etc. | 16:36 |
| tweining | those reports only show how little typing information is in our code | 16:36 |
| johnsom | This change is wrong: https://review.opendev.org/c/openstack/octavia/+/879749/34/octavia/cmd/prometheus_proxy.py#b742 | 16:36 |
| tweining | how is it wrong, "" is falsy | 16:38 |
| tweining | line.replace(False, map_tuple[0]) would be wrong, which is why mypy complained | 16:38 |
| johnsom | Before it was using False, for a boolean check. Changing it to an empty string is wrong. | 16:38 |
| johnsom | 746 is the conditional that would block the line.replace from running | 16:39 |
| johnsom | It looks like only nova, cinder, and a few oslo libraries use mypy | 16:40 |
| tweining | the alternative is that I ignore that line using an ignore comment | 16:41 |
| johnsom | Which is better than I thought frankly | 16:41 |
| gthiemonge | maybe that should be discussed in the review | 16:41 |
| tweining | I agree | 16:41 |
| johnsom | Yeah. It wasn't a priority to get into the release, so I haven't looked at it | 16:42 |
| gthiemonge | anything else? | 16:43 |
| gthiemonge | ok I guess that's it for today | 16:45 |
| gthiemonge | thank you guys! | 16:45 |
| gthiemonge | #endmeeting | 16:45 |
| opendevmeet | Meeting ended Wed Sep 20 16:45:33 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:45 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-09-20-16.00.html | 16:45 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-09-20-16.00.txt | 16:45 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/octavia/2023/octavia.2023-09-20-16.00.log.html | 16:45 |
| opendevreview | Merged openstack/octavia master: Add support for Rocky Linux https://review.opendev.org/c/openstack/octavia/+/873489 | 18:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!