| QG | Hello ! | 16:25 |
|---|---|---|
| QG | Do you know if we have the same full set of options for the Persistence database as the ones for the database section ? | 16:25 |
| QG | Like the connection_recycle_time or the max_pool_size and max_overflow ? | 16:25 |
| QG | i don't see any https://github.com/openstack/octavia/blob/master/octavia/common/config.py#L551 | 16:25 |
| tkajinam | afaik octavia imports subset of database options for persistent database but it does not provide "full" set of options | 16:45 |
| tkajinam | https://github.com/openstack/octavia/blob/master/octavia/controller/worker/v2/taskflow_jobboard_driver.py#L40-L43 | 16:45 |
| tkajinam | the list of options there comes from the options supported by taskflow library (taskflow library should pass options to underlying sqlalchemy). if you need additional tunables then you may have to update taskflow then octavia | 16:47 |
| tkajinam | now the equivalent option in sqlalchemy is hard-coded to 3600. it seems taskflow allows overriding it so we can probably use that interface in octavia, I guess | 16:49 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: Honor connection_recycle_timeout in MysqlPersistenceDriver https://review.opendev.org/c/openstack/octavia/+/900925 | 16:55 |
| gthiemon1e | wow that was fast! thanks for the patch tkajinam ;-) | 16:58 |
| QG | Wow Thanks for the infos tkajinam and also for the patch | 16:59 |
| tkajinam | gthiemon1e, QG ;-) | 17:00 |
| tkajinam | oslo.db has some retry options but afaik there are implemented in oslo.db itself and does not work for persistence database which is directly connected using sqlalchemy | 17:01 |
| tkajinam | there are a few other options but I don't see anything else I can add easily. Probably slave_connection is an interesting one though it may require some amount of changes in taskflow I guess | 17:03 |
| tkajinam | if you find anything else useful then it might worth creating a bug (assuming octavia no longer uses storyboard ?). note that configuring the options for persistence database selarately from oslo.db database is not supported now. | 17:07 |
| * tkajinam runs away | 17:07 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!