| gthiemonge | QG: "tox -efunctional" fails on your patch | 08:02 |
|---|---|---|
| QG | Hello gthiemonge, | 08:56 |
| QG | When i run it i have 10 tests failed : | 08:56 |
| QG | ====== | 08:56 |
| QG | Totals | 08:56 |
| QG | ====== | 08:56 |
| QG | Ran: 1362 tests in 248.1274 sec. | 08:56 |
| QG | - Passed: 1349 | 08:56 |
| QG | - Skipped: 3 | 08:56 |
| QG | - Expected Fail: 0 | 08:56 |
| QG | - Unexpected Success: 0 | 08:56 |
| QG | - Failed: 10 | 08:56 |
| QG | and the first one is octavia.tests.functional.api.v2.test_load_balancer.TestLoadBalancer.test_create_noop_network_and_subnet | 08:56 |
| QG | i run it using .tox/cover/bin/stestr run --no-discover octavia.tests.functional.api.v2.test_load_balancer.TestLoadBalancer.test_create_noop_network_and_subnet | 08:57 |
| QG | and : | 08:57 |
| QG | ====== | 08:57 |
| QG | Totals | 08:57 |
| QG | ====== | 08:57 |
| QG | Ran: 1 tests in 0.5754 sec. | 08:57 |
| QG | - Passed: 1 | 08:57 |
| frickler | QG: might be some interaction between tests then. also please use paste.opendev.org for multiline pastes | 08:58 |
| QG | Hi frickler, sorry about that ! will use it for the future | 08:59 |
| gthiemonge | QG: to fix that, you probably need to mock _validate_subnet in the functional tests (or you can mock the functions that are called by _validate_subnet) | 09:00 |
| gthiemonge | hm ok I see, let me check | 09:01 |
| gthiemonge | QG: maybe focus on the tests that are always failing, like octavia.tests.functional.api.v2.test_load_balancer.TestLoadBalancer.test_create_provider_octavia_no_port_sec | 09:12 |
| gthiemonge | QG: if you fix these tests, it may fix the test that is not always reproducible | 09:12 |
| QG | gthiemonge: ok thanks will work on those | 09:21 |
| skraynev | @johnsom hello, thank you for detailed response in the bug. I left couple thoughts in comment, could you please take a look: https://bugs.launchpad.net/octavia/+bug/2043582/comments/3 if suggestions are ok with it, I could take care about them and prepare PR. | 10:30 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Clarify certificate related config options https://review.opendev.org/c/openstack/octavia/+/901017 | 10:58 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia-tempest-plugin master: Add tests for additional VIPs https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/664462 | 14:38 |
| opendevreview | Quentin GROLLEAU proposed openstack/octavia master: Add validation for minimum number of ips when the subnet is specified https://review.opendev.org/c/openstack/octavia/+/898803 | 18:10 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!