| *** jph0 is now known as jph | 08:25 | |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: DNM test differen dsvm-noo-api config https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/907309 | 12:43 |
|---|---|---|
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: DNM test differen dsvm-noo-api config https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/907309 | 13:59 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Add TERMINATED_HTTPS listener API tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/893066 | 15:33 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Add TERMINATED_HTTPS listener API tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/893066 | 15:35 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Add TERMINATED_HTTPS listener API tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/893066 | 15:43 |
| QG | Hello everyone ! | 16:43 |
| QG | Is it a legitimate case when the user creates an lb this way? | 16:43 |
| QG | openstack loadbalancer create --name lb --vip-port-id bcfe386c-77bd-47b6-b127-48ae5c608fe6 --additional-vip subnet-id=7ada4a32-8479-48b5-b68e-429ec3cb54a6 | 16:44 |
| QG | i think it's a legitimate case and it ends in Traceback, i will create a bug in launchpad | 16:47 |
| gthiemonge | QG: I don't know if it's legitimate, but it's certainly a corner case. | 17:07 |
| gthiemonge | QG: IMO we should handle all the subnets (as VIP subnet + additional subnets) that are plugged into the provided port, but I'm sure we don't do that | 17:08 |
| gthiemonge | QG: then I believe that providing a port_id + additional vips should raise an ValidationException | 17:09 |
| tweining | I agree, it should never show a traceback. either it should work, or fail validation | 17:09 |
| gthiemonge | QG: in your case, is the subnet 7ada4a already plugged into the port? | 17:10 |
| QG | gthiemonge: why do you think it should raise an ValidationException ? | 17:10 |
| gthiemonge | QG: because I think a multivip LB should only be create with a vip_subnet_id + additional_vips[].subnet_id or a vip_port_id, and not a mix of port and subnets | 17:11 |
| gthiemonge | QG: anyway, please create a launchpad | 17:11 |
| QG | gthiemonge: Subnet 7ada4a32 belongs to the same network as the port's subnet does | 17:12 |
| QG | gthiemonge: what do you mean by already plugged into the port ? | 17:12 |
| QG | gthiemonge: yep i have : https://bugs.launchpad.net/octavia/+bug/2052455 | 17:13 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Test new HSTS feature https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/881546 | 17:14 |
| gthiemonge | QG: I mean that your subnet_2 should be alredy a one of fixed_ips of the port beofre creating the LB | 17:14 |
| gthiemonge | QG: I need to doublecheck but I think we don't handle multiple subnets in a vip_port_id, so there may be a bug | 17:14 |
| gthiemonge | QG: we can discuss that in the next weekly meeting | 17:15 |
| QG | gthiemonge: ah ok, so in this case the port subnet and the additional subnet are two different subnets but in the same network | 17:16 |
| gthiemonge | QG: does it work when you pass "--vip-subnet-id subnet_1"? | 17:39 |
| QG | gthiemonge: testing | 17:39 |
| QG | gthiemonge: yes it does | 17:42 |
| QG | in https://github.com/openstack/octavia/blob/master/octavia/controller/worker/v2/tasks/database_tasks.py#L496 additional_vips is empty when passing the vip_port_id but not when passing the vip-subnet-id | 17:43 |
| gthiemonge | I think we should validate that vip_subnet_id is passed when using vip_port_id and additional_vips[].subnet_id | 17:44 |
| QG | ahhhh but wait | 17:45 |
| QG | i think we are not entering in https://github.com/openstack/octavia/blob/master/octavia/api/v2/controllers/load_balancer.py#L229 | 18:01 |
| QG | no actually we are | 18:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!