| opendevreview | Takashi Kajinami proposed openstack/octavia master: Remove SQLAlchemy tips jobs https://review.opendev.org/c/openstack/octavia/+/915782 | 01:22 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/octavia master: DNM: Run functional job with sqlalchemy 2.0 https://review.opendev.org/c/openstack/octavia/+/915785 | 02:16 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: DNM: Run functional job with sqlalchemy 2.0 https://review.opendev.org/c/openstack/octavia/+/915785 | 02:41 |
| tkajinam | johnsom, oh. thanks for fixing that typo | 03:07 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: Remove SQLAlchemy tips jobs https://review.opendev.org/c/openstack/octavia/+/915782 | 05:57 |
| gthiemonge | tkajinam: thanks for working on the sqlalchemy2 stuff, do you want me to look at the most recent issue? | 06:20 |
| skraynev | @gthiemonge @johnsom Hello. Could you please help with merge backport patches: https://review.opendev.org/c/openstack/octavia/+/915359 and https://review.opendev.org/c/openstack/octavia/+/910464 (all branches except 2023.1 - it waits fix: https://review.opendev.org/c/openstack/octavia/+/915545) | 06:52 |
| gthiemonge | skraynev: sure | 07:10 |
| skraynev | thank you! | 07:10 |
| tkajinam | gthiemonge, yeah I've not yet looked into https://bugs.launchpad.net/octavia/+bug/2061348 so if you can take some moments for it then that'd be nice | 07:22 |
| gthiemonge | tkajinam: ack | 07:23 |
| tkajinam | gthiemonge, the 2nd error can be found in https://review.opendev.org/c/openstack/octavia/+/915782/ . just fyi. feel free to rebase it on a fix | 07:42 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Fix migration scripts with SQLAlchemy 2.0 https://review.opendev.org/c/openstack/octavia/+/915831 | 07:42 |
| gthiemonge | ^ I put it on top of your first fix | 07:43 |
| tkajinam | ok then let me put that bump patch on yours | 07:43 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Fix migration scripts with SQLAlchemy 2.0 https://review.opendev.org/c/openstack/octavia/+/915831 | 07:44 |
| tkajinam | oh, sorry I did it wrongly. let me fix it | 07:44 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Fix migration scripts with SQLAlchemy 2.0 https://review.opendev.org/c/openstack/octavia/+/915831 | 07:44 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: Remove SQLAlchemy tips jobs https://review.opendev.org/c/openstack/octavia/+/915782 | 07:44 |
| tkajinam | ok so now https://review.opendev.org/c/openstack/octavia/+/915782 should be tested with these two changes | 07:45 |
| tkajinam | let's see how it goes | 07:45 |
| tkajinam | gthiemonge, as a side discussion I wonder if it makes sense to try squashing migration scripts. Currently octavia carries 90+ migration scripts but I think most of these are for old releases and can be squashed now | 07:45 |
| gthiemonge | yeah this is a good topic | 07:46 |
| tkajinam | gthiemonge, I discussed similar topics for glance and manila during the PTG last week. | 07:46 |
| gthiemonge | yeah I was wondering why I should fix DB updates in 8 years old scripts... | 07:47 |
| tkajinam | yeah | 07:47 |
| gthiemonge | I'm adding it as a topic for this week's meeting | 07:48 |
| tkajinam | During the discussion in manila we agreed that asking any better way than manual squash to more knowledgeable people like zzzeek or stephenfin. probably you can also catch up with that discussion later in cycle and decided whether you actually start manual squash | 07:48 |
| tkajinam | s/decided/decide/ | 07:49 |
| gthiemonge | +1 | 07:49 |
| tkajinam | but yeah if you can bring the topic for early awareness and discussion then that's still very nice | 07:51 |
| gthiemonge | sure | 07:52 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: WIP Initial support for Jobboard etcd backend https://review.opendev.org/c/openstack/octavia/+/915834 | 08:31 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: Drop logic for SQLAlchemy < 2.0 https://review.opendev.org/c/openstack/octavia/+/915835 | 08:43 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: WIP Initial support for Jobboard etcd backend https://review.opendev.org/c/openstack/octavia/+/915834 | 09:01 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: Fix compatibility with SQLAlchemy 2.0 https://review.opendev.org/c/openstack/octavia/+/915772 | 09:05 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: SQLAlchemy 2.0: Drop use of removed autoload https://review.opendev.org/c/openstack/octavia/+/915772 | 09:05 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: SQLAlchemy 2.0: Drop use of removed autoload https://review.opendev.org/c/openstack/octavia/+/915772 | 09:05 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: Fix migration scripts with SQLAlchemy 2.0 https://review.opendev.org/c/openstack/octavia/+/915831 | 09:05 |
| opendevreview | Takashi Kajinami proposed openstack/octavia master: Remove SQLAlchemy tips jobs https://review.opendev.org/c/openstack/octavia/+/915782 | 09:06 |
| gthiemonge | tkajinam: it seems that taskflow is also broken: https://zuul.opendev.org/t/openstack/build/dca948cdf5784390b24e8759936b8e41 | 09:06 |
| gthiemonge | it's my fault too, I updated the code in octavia and taskflow for sqlalchemy 2 but I didn't check the migration scripts :/ | 09:08 |
| tkajinam | gthiemonge, I've created a patch to pull sqla 2.0 to all jobs. let's see if we find any other problems there https://review.opendev.org/c/openstack/taskflow/+/915839 | 09:13 |
| tkajinam | gthiemonge, yeah migration scripts and a few CLI tools are something not yet tested, as far as I've seen | 09:13 |
| tkajinam | but we are catching these now which is still good, I think | 09:14 |
| tkajinam | so we likely need to fix taskflow first and create a new release to unblock Octavia | 09:14 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: WIP Initial support for Jobboard etcd backend https://review.opendev.org/c/openstack/octavia/+/915834 | 09:20 |
| opendevreview | Merged openstack/octavia master: pyupgrade changes for Python3.8+ (3) https://review.opendev.org/c/openstack/octavia/+/905593 | 09:22 |
| opendevreview | Merged openstack/octavia master: pyupgrade changes for Python3.8+ (4) https://review.opendev.org/c/openstack/octavia/+/905594 | 09:46 |
| opendevreview | Merged openstack/octavia master: pyupgrade changes for Python3.8+ (5) https://review.opendev.org/c/openstack/octavia/+/905595 | 10:46 |
| opendevreview | Merged openstack/octavia master: pyupgrade changes for Python3.8+ (6) https://review.opendev.org/c/openstack/octavia/+/905596 | 10:46 |
| opendevreview | Merged openstack/octavia master: pyupgrade changes for Python3.8+ (7) https://review.opendev.org/c/openstack/octavia/+/899263 | 10:46 |
| opendevreview | Merged openstack/octavia master: Add pyupgrade hook to pre-commit config https://review.opendev.org/c/openstack/octavia/+/899264 | 10:46 |
| skraynev | @tkajinam does it affect stable branches ? before 2024.1 ? | 10:48 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Add TERMINATED_HTTPS listener API tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/893066 | 10:55 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Test new HSTS feature https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/881546 | 10:55 |
| tkajinam | skraynev, which problem are you talking about ? SQLAlchemy 2 compatibility ? | 10:56 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Add TERMINATED_HTTPS listener API tests https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/893066 | 10:57 |
| opendevreview | Tom Weininger proposed openstack/octavia-tempest-plugin master: Test new HSTS feature https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/881546 | 10:57 |
| skraynev | tkajinam: yes, which you discussed above. I accidentally read your discussion and now try to understand which versions are affected. | 10:58 |
| tkajinam | skraynev, https://github.com/openstack/requirements/blob/stable/2024.1/upper-constraints.txt#L157 | 11:00 |
| tkajinam | short answer is no but the above link would explain why | 11:03 |
| skraynev | thank you. got it! | 11:04 |
| opendevreview | Merged openstack/octavia stable/2024.1: Fix negative or 0 limit parameter in pagination https://review.opendev.org/c/openstack/octavia/+/915539 | 11:37 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: WIP Initial support for Jobboard etcd backend https://review.opendev.org/c/openstack/octavia/+/915834 | 11:58 |
| opendevreview | Merged openstack/octavia stable/zed: Fix negative or 0 limit parameter in pagination https://review.opendev.org/c/openstack/octavia/+/915536 | 12:00 |
| opendevreview | Takashi Kajinami proposed openstack/octavia-tempest-plugin master: Remove reference to train and ussir https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/915851 | 12:19 |
| opendevreview | Takashi Kajinami proposed openstack/octavia-tempest-plugin master: Update branch regex to adapt to unmaintained branches https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/915852 | 12:19 |
| opendevreview | Takashi Kajinami proposed openstack/octavia-tempest-plugin master: Add stable/2024.1 jobs https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/915853 | 12:19 |
| opendevreview | Takashi Kajinami proposed openstack/octavia-tempest-plugin master: Add stable/2024.1 jobs https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/915853 | 12:22 |
| opendevreview | Takashi Kajinami proposed openstack/octavia-tempest-plugin master: Remove reference to train and ussuri https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/915851 | 12:22 |
| opendevreview | Takashi Kajinami proposed openstack/octavia-tempest-plugin master: Update branch regex to adapt to unmaintained branches https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/915852 | 12:22 |
| opendevreview | Takashi Kajinami proposed openstack/octavia-tempest-plugin master: Add stable/2024.1 jobs https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/915853 | 12:22 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add typing information to octavia.amphorae package https://review.opendev.org/c/openstack/octavia/+/905193 | 12:24 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add typing information to octavia.api package https://review.opendev.org/c/openstack/octavia/+/905194 | 12:24 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Add typing information to remaining octavia code https://review.opendev.org/c/openstack/octavia/+/905195 | 12:24 |
| opendevreview | Tom Weininger proposed openstack/octavia master: Integrate mypy type checker https://review.opendev.org/c/openstack/octavia/+/879749 | 12:24 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: WIP Initial support for Jobboard etcd backend https://review.opendev.org/c/openstack/octavia/+/915834 | 13:34 |
| opendevreview | Gregory Thiemonge proposed openstack/octavia master: WIP Initial support for Jobboard etcd backend https://review.opendev.org/c/openstack/octavia/+/915834 | 14:47 |
| skraynev | johnsom: please add +2 for fix 2023.2 branch: https://review.opendev.org/c/openstack/octavia/+/915545 | 17:24 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily for a restart in order to apply a patch update | 18:36 | |
| opendevreview | Merged openstack/octavia stable/2023.2: Pin pylint (<=3.0.4) https://review.opendev.org/c/openstack/octavia/+/915545 | 23:34 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!